From nobody Mon Feb 9 08:29:02 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68E11242D79 for ; Tue, 21 Oct 2025 23:47:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761090423; cv=none; b=jURQydFbd6j6Ag+yH9cD2vfHETE8xVqbG79dXDofs643K3HGTL0wJ4zPvNANH2XbFfRxATnVt+EZ9lsGp1IFym1s9FqtatasBWm7CP5FiHj0footQKWu+CKQaw+9v7bfsjvuk67j6PJ4Slf0OO2rTowRwn8BKI0mgyKzuTVjjPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761090423; c=relaxed/simple; bh=5ZnZPrVDfdO+Z9/UM3e8BCikhyLuP+zNDA80rKqdbMY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iTeOXHYanjXO+01upWypGtMtNXSz2/PMo6ZrTvJrHeI02B4aKmbAmu/EENpzrEuh7s39wmYwdkfYBUDXTEk2f9975aOCbIyEysfS7LoSI9YO7RE9qwtMFYt0Nn9TlvjjrbXjr8hkESLAPBRFir51Zh4dnL6AdVwntQptSgT67q0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vqdj+cUa; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vqdj+cUa" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-33bda2306c5so4910636a91.0 for ; Tue, 21 Oct 2025 16:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761090420; x=1761695220; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j0IJv9dMDzYNAhk3DeojEckJoVGEYAGQr1mrX7CZmVI=; b=Vqdj+cUaCyzRB2LdHTMt+fj0JxAaquTyxp/ZrCnavf+AB3YESX1HVyy9YKyIhibLvm v9vbK2HR8036+s7W2/lSpQV1lLNcvG3u9ham/tkcWXd7h290PF/S+F8TK5qTza5K5LOQ mxW+p0SlwMB9qYC0Jvd780awJhLkxdqw7XlsujJ6Ik8QcC1TIQrC7rzVqL6XX9btXDNx L3XlnfBgqiDAtjPflEwwLyGyKV+LPw0CAvp0nDUeNVnQIfkF0UgEDSs/faSySvPN2I3B ReC4M+pysdIsU0eGyxfWUZBGdemrI/7KtCBmmDkbe2r1NcyxRx4MZgKI14iZ8+bh3YqC 0CwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761090420; x=1761695220; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j0IJv9dMDzYNAhk3DeojEckJoVGEYAGQr1mrX7CZmVI=; b=WC8A/Z0C55kJdgLSdQ3Ui97dXz5w4w6CwstXpuhdS68rpvtuBs3g3KbF2cfbq3ElNP WLyUGn33ZecqEZfYotAytkFQVtIPTm8RpneH4eIUWtxR2lprl9nj1MW5qr3PUJp44w1v ii4YW5+IcySp/J7vffcRHDTjGuk118EQUCfEN2Y0EoczpczkmsUGWEe/2qZjNMTLB9AL ewvInFAboCa9dOKEUJyjduM/YPahBpPaV6ezlIZzVcNrjkudl8JjfKyaqxaDgYsO4WqT lDQTJnrmPJ9lMl5d2AwjGoEezQnl2U0kOiiGtx6r5oUMGdJKQ2kYrd04yEVvhhvY0MmF pFQg== X-Forwarded-Encrypted: i=1; AJvYcCXakoL7ybPEUOjyoqL8Yrv71ggqQ8vf2vsOq92KsoHMhrDK3QcnGJ/IsN5Ig+O+4j4iqUOGL6wVF03Lx+w=@vger.kernel.org X-Gm-Message-State: AOJu0YydVcm0i6knZeBCdyyTvcXZey4RbDG29hC6CCdg1vZ7yNxJqEKS p5Xq5Notva+QH8xPgfNKEPzYXJZmyPOJbUUvgn1ii8cJwWf85SblT1W/ X-Gm-Gg: ASbGncsRAbnt5eHocI8oJSXCR0V3OZ+uW6G2DqfRfECyvrZJT70ki+wKcpKhVD3lPk5 sl95qGRaAsPBh1ogByYEGBcRp7Zomze9FNR8wf1SnuPquaVEnPxc8cNzZkJ/SEeK+hNVbuXbTLa cSMPd7D7MYnobFpcOgXJ7WOwZrPCqMaygz01R0gNPHBRNDEq9sCOULsiDOnpnxGgxGJ6Cd8timY 85X78N8uZOy0JwCg2WccIsOZLhX5ylXyjnFrmzcebaZl/ycvZHx+Vyyp4YiFZi3kJHt7rcKnaYT dbe6Dg7ExPQehMNTAqvvPdsZ5DHj6rUrAnjXBQEeg52vKV6LDNGgEUChS0rlydsX2hAqQTz1+Y3 vWb1PCeQRdXv+gFFmnZOEBSLIjswRzVkW4e6dHINeDL4nW+M15G/5Ln8aegkvoWWIMl07oELocC oj1cRJN6ey9tSHJ+1I9Nk= X-Google-Smtp-Source: AGHT+IENkRWCpby5KoDuBC94CdB6Y+P0mIUVkUr8FgnjZ2JlIaa5Ku2Bjeg3lNWDeg1OBhPgmqH52g== X-Received: by 2002:a17:90b:28c4:b0:327:c0c6:8829 with SMTP id 98e67ed59e1d1-33bcf8e4f50mr24622081a91.24.1761090420572; Tue, 21 Oct 2025 16:47:00 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:70::]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b6a76645c61sm11811785a12.3.2025.10.21.16.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Oct 2025 16:47:00 -0700 (PDT) From: Bobby Eshleman Date: Tue, 21 Oct 2025 16:46:45 -0700 Subject: [PATCH net-next v7 02/26] vsock/virtio: pack struct virtio_vsock_skb_cb Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251021-vsock-vmtest-v7-2-0661b7b6f081@meta.com> References: <20251021-vsock-vmtest-v7-0-0661b7b6f081@meta.com> In-Reply-To: <20251021-vsock-vmtest-v7-0-0661b7b6f081@meta.com> To: Stefano Garzarella , Shuah Khan , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?utf-8?q?Eugenio_P=C3=A9rez?= , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , Bobby Eshleman Cc: virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, berrange@redhat.com, Bobby Eshleman X-Mailer: b4 0.13.0 From: Bobby Eshleman Reduce holes in struct virtio_vsock_skb_cb. As this struct continues to grow, we want to keep it trimmed down so it doesn't exceed the size of skb->cb (currently 48 bytes). Eliminating the 2 byte hole provides an additional two bytes for new fields at the end of the structure. It does not shrink the total size, however. Future work could include combining fields like reply and tap_delivered into a single bitfield, but currently doing so will not make the total struct size smaller (although, would extend the tail-end padding area by one byte). Before this patch: struct virtio_vsock_skb_cb { bool reply; /* 0 1 */ bool tap_delivered; /* 1 1 */ /* XXX 2 bytes hole, try to pack */ u32 offset; /* 4 4 */ /* size: 8, cachelines: 1, members: 3 */ /* sum members: 6, holes: 1, sum holes: 2 */ /* last cacheline: 8 bytes */ }; ; After this patch: struct virtio_vsock_skb_cb { u32 offset; /* 0 4 */ bool reply; /* 4 1 */ bool tap_delivered; /* 5 1 */ /* size: 8, cachelines: 1, members: 3 */ /* padding: 2 */ /* last cacheline: 8 bytes */ }; Signed-off-by: Bobby Eshleman --- include/linux/virtio_vsock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h index 0c67543a45c8..87cf4dcac78a 100644 --- a/include/linux/virtio_vsock.h +++ b/include/linux/virtio_vsock.h @@ -10,9 +10,9 @@ #define VIRTIO_VSOCK_SKB_HEADROOM (sizeof(struct virtio_vsock_hdr)) =20 struct virtio_vsock_skb_cb { + u32 offset; bool reply; bool tap_delivered; - u32 offset; }; =20 #define VIRTIO_VSOCK_SKB_CB(skb) ((struct virtio_vsock_skb_cb *)((skb)->cb= )) --=20 2.47.3