From nobody Sun Feb 8 06:53:59 2026 Received: from MTA-08-4.privateemail.com (mta-08-4.privateemail.com [198.54.122.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33018355034 for ; Tue, 21 Oct 2025 12:17:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.54.122.147 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761049039; cv=none; b=ADQuX3H7EkP+gekCJp+jVz28flDniOLTN3QFQEu6MfAMYC7gXSP+7aM3kJgUaoGo5Zt517vXYj5bppklwgOa7RUd9aHM8n6vuVXcmyT8gJ/7I8XAoBdegv4alV1W6TOYixHU82tN/9map/CtH0LyMaAQk50DGW1OGUqoqgMRKek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761049039; c=relaxed/simple; bh=uZv0x3wx3Gxr6XcL+voEowtpQlpNWPH2FnQJC7GDLF8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MeGOjxt1GHdYsCiUZ98FGvcTHwisuCwmo2Aof8jEPd1Y+Jh4Pkms3PEGIpSCgjtfdYIUs0g6Df8oQmoAoVp/4AxNeiYjmdzdNCV7OAG0pt7u6iHAVCbY/BlkdQoLdp02a7qGobQM0jcgBvX7bLXcbyLbMi33Swu65aG0k5SbQLE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lukowski.dev; spf=pass smtp.mailfrom=lukowski.dev; dkim=pass (2048-bit key) header.d=lukowski.dev header.i=@lukowski.dev header.b=wnpwlGxO; arc=none smtp.client-ip=198.54.122.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lukowski.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lukowski.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lukowski.dev header.i=@lukowski.dev header.b="wnpwlGxO" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=lukowski.dev; s=default; t=1761049036; bh=uZv0x3wx3Gxr6XcL+voEowtpQlpNWPH2FnQJC7GDLF8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=wnpwlGxOAeBGAF4ncvDx0Q/mhgGU54DnGDk+Ih45ycwn12CzJ2aPY9wtNrA/sv3hA ICGsHZjaQ9NarBmIySpMsZue9KZfYHwkPGB8c0WIC+MPLld8sEionioijS3EX+wKMd gxdLA/sodLTzru7Dh1rSBSGM6rnYa16NlnR5bVjMK2Y4WkZEdIn1hX4c7y+q7Ewj15 TGdZQWUjxLf2lh58N7THk5gY2Q5KBayg/tBNsqyfzghozyqXzWTlxuNUUe5LIsHhNX JQpX4RzAQUmmQnO9ljLQGgOxpbrl+iOG+rAY0lUbECW2qVUeMd53i9Qb3ToF1eovVt w94Jf+YIm2f/w== Received: from mta-08.privateemail.com (localhost [127.0.0.1]) by mta-08.privateemail.com (Postfix) with ESMTP id 4crWWc2NPDz3hhTS; Tue, 21 Oct 2025 08:17:16 -0400 (EDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa (unknown [150.228.61.72]) by mta-08.privateemail.com (Postfix) with ESMTPA; Tue, 21 Oct 2025 08:17:07 -0400 (EDT) From: Olle Lukowski Date: Tue, 21 Oct 2025 15:16:27 +0300 Subject: [PATCH 1/3] staging: most: i2c: replace BUG_ON() with WARN_ON_ONCE() and return error Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251021-staging-most-warn-v1-1-4cdd3745bbdc@lukowski.dev> References: <20251021-staging-most-warn-v1-0-4cdd3745bbdc@lukowski.dev> In-Reply-To: <20251021-staging-most-warn-v1-0-4cdd3745bbdc@lukowski.dev> To: Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Olle Lukowski X-Mailer: b4 0.14.3 X-Virus-Scanned: ClamAV using ClamSMTP Replace BUG_ON() checks for invalid channel indices with WARN_ON_ONCE() and return -EINVAL to avoid crashing the kernel unnecessarily. Signed-off-by: Olle Lukowski --- drivers/staging/most/i2c/i2c.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/i2c/i2c.c b/drivers/staging/most/i2c/i2c.c index 184b2dd11..b9267c3fc 100644 --- a/drivers/staging/most/i2c/i2c.c +++ b/drivers/staging/most/i2c/i2c.c @@ -71,7 +71,8 @@ static int configure_channel(struct most_interface *most_= iface, struct hdm_i2c *dev =3D to_hdm(most_iface); unsigned int delay, pr; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D NUM_CHANNELS); + if (WARN_ON_ONCE(ch_idx < 0 || ch_idx >=3D NUM_CHANNELS)) + return -EINVAL; =20 if (channel_config->data_type !=3D MOST_CH_CONTROL) { pr_err("bad data type for channel %d\n", ch_idx); @@ -125,7 +126,8 @@ static int enqueue(struct most_interface *most_iface, struct hdm_i2c *dev =3D to_hdm(most_iface); int ret; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D NUM_CHANNELS); + if (WARN_ON_ONCE(ch_idx < 0 || ch_idx >=3D NUM_CHANNELS)) + return -EINVAL; =20 if (ch_idx =3D=3D CH_RX) { /* RX */ @@ -170,7 +172,8 @@ static int poison_channel(struct most_interface *most_i= face, struct hdm_i2c *dev =3D to_hdm(most_iface); struct mbo *mbo; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D NUM_CHANNELS); + if (WARN_ON_ONCE(ch_idx < 0 || ch_idx >=3D NUM_CHANNELS)) + return -EINVAL; =20 if (ch_idx =3D=3D CH_RX) { if (!polling_rate) --=20 2.51.1