From nobody Wed Oct 22 15:57:34 2025 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 854B634F27F for ; Tue, 21 Oct 2025 18:09:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761070192; cv=none; b=KSkWjgBt1shGRRd8foECKkaqg7T+rAufGCrroSxo5iyIrswoVMbGqDM67z/LIq9dQOJ4lsWJOB/1EEr9XoKKRgPAxOmMCLaDc/vjDxsFrgGPd5oI9v8yYB24bEJB9ilHwOfAyTSJBSfUKxPZz2j5yuvBI5L+Fix4HNg9x3SSWLE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761070192; c=relaxed/simple; bh=ZGXcHkmbv56726TD7p8UHQeGT1lZPP7DN45mrJa7mZg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VK7/kxMK0oV8nRMVkExoq1j0hPa3j+DzYTzpMRH67YRxs177n5YxUVu3BFUS5Fv2zdfj8jczYNS6ot+Rg5TUwoaX/Is6I6ldm4/9x49GJw3airbNXFfUDTrZQWCmmUTExJS+HxXj6cIq+0WwgmwSMHYjPJksp3nI8w3oPh5LCAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=OcBXuJSM; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="OcBXuJSM" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b54f55a290cso897037166b.2 for ; Tue, 21 Oct 2025 11:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1761070189; x=1761674989; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0YfaUIno/O6RD7wQ5yEegdmcS8V7ZlB/+cNbw2kl/R4=; b=OcBXuJSMqpr8xn1UgL2kwTzT1/KDvwgTWuHKSY/rCOLVJjv2lImhtHrSG6WA1f4d6o HjFqBFw3FsXE28cK3PGoK8bPhGuGTNupn+rNmIp7ACGVmJ+nb+r8kJ4sQLHiG5lMHc89 13GvZlgUF2Yiy/9xXABoiredxFIDzzqCtcOtjyKMiFdhpI4waDxEadThwmrRqXQq0nJV BncgXf92rVUN4Fe/Z7+a1nBTOeKe5Uz9g3ZKSwTqx4cjjzBWz8WxuvCntGPRVgwn9Ivc UhKfIGrczs21z9MDVznfHQcV+seJhx0IJQtDoMBz98uObeQs+l6mzgHu7doONAANxo2z hWrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761070189; x=1761674989; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0YfaUIno/O6RD7wQ5yEegdmcS8V7ZlB/+cNbw2kl/R4=; b=OWkoBH1QPkmI4uJRqknGC69VMZrkA5AnM2kQkoljZf5ZhHQVZSGv+Q0wsEUvBgMRAe IqrR7RGEgdj/S/aOKH1ysdbBHadPt+MCwvmba1mwwCJKaEqUZUq1CKlZ/ewQwapI9D9n Fxzon57WPSX7HMo1vJdTnJ/41HOYMgtS7+f/ybKRdisDFX8AX+wBrX4vrAExXUu2hAWt DJe9RGDa7GjtCt8myWzjb9Xjj5wzKIRHOvTlr5CL9YcO1jc/G//tCkywKlgf4Y0zT/+C zUjtC0HT+aEeGIx+qmJXLpT5BtkmDEWkDXy+ygkMvwOrfPl6hjv9eIyYeF7O8MsOfuLD ddKw== X-Forwarded-Encrypted: i=1; AJvYcCW0JgfOfJWt1MD+46yuxg0bmf3CMpAcQwQ9JKPaWXQ+m+AitJgz8SgfF4eO0M3y0V+py0aoKBK9fZIIofI=@vger.kernel.org X-Gm-Message-State: AOJu0YxZw+leaMx1jIuDJumlUIpeQYvpwWOSfOKqJe1EbbG37NS1rHyT xnGwCALL+1283V7DTkpurvqQdBnM6wuXHaTl7uCmQiVy+gpwhF5No+gtq//Wsp4qiCc= X-Gm-Gg: ASbGncvfmQphbwRE/YGavNWl9yMUP9dRSKSUpHBieclWuTJgVZbO0pFfwhXRK2BlbL1 ceLeZiolTNrLDQwfcZzOsVLp8T5P2NugN+A00R4oH+z4uBWkumUEK7jPhcZuTqMYulx0Shveevn RPBw6lFEPgdGPrsw8c7DGF5dKNe3EGG8Rf/h5yD2LAbRVaY+vcGomqLpgvh/k+sBjI52BeSsVoO MVtwQ/hvBnw5TsywDuCnzOTrBH+wtd91udaj42subWxaNs7OUMLxzhlOhVyzesOVxZrPdoY1lM6 8F3u3DUPA9u15fbNAOiWY0aG9P/+6vmjPGAtVQUr5abVRCNSOesrc7RTnCNP5OYaPSWeU+HuV+w jqL+n9HOf91h1Ytvop6TGQ9+KViPwxrmcTYVGUDbN5hZvaVtGpIwlTe6dZzXzk8MJLMsHaKZeNO G8b5BjvzLMWF0rAwnB+A== X-Google-Smtp-Source: AGHT+IH0GvSCHSJ20rzTQIYXRIwE1CXZMXwC+rc2yBk+UDlF2kTkV8GiuD1hoeoFg1MLq44vUKK9vw== X-Received: by 2002:a17:907:3e95:b0:b3e:e16a:8cdb with SMTP id a640c23a62f3a-b6472d5bb74mr2145989666b.12.1761070188807; Tue, 21 Oct 2025 11:09:48 -0700 (PDT) Received: from otso.local ([213.208.157.251]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b65e8393778sm1116758166b.24.2025.10.21.11.09.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Oct 2025 11:09:48 -0700 (PDT) From: Luca Weiss Date: Tue, 21 Oct 2025 20:08:54 +0200 Subject: [PATCH 1/2] clk: qcom: camcc-sm6350: Fix PLL config of PLL2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251021-agera-pll-fixups-v1-1-8c1d8aff4afc@fairphone.com> References: <20251021-agera-pll-fixups-v1-0-8c1d8aff4afc@fairphone.com> In-Reply-To: <20251021-agera-pll-fixups-v1-0-8c1d8aff4afc@fairphone.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Konrad Dybcio , Danila Tikhonov , Taniya Das Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761070183; l=1397; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=ZGXcHkmbv56726TD7p8UHQeGT1lZPP7DN45mrJa7mZg=; b=UzHql+ztd4+bmvd4/QcSLSyY9exbAqVYLuqxHcofhDRwOY1qW3O6zhiRfnGAwZqLYAQZfD8eu vuR4eKcKjnKC0i4M+G1CukRWENcz3btSloxO6iim5OpczIPdnaBQV3p X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= The 'Agera' PLLs (with clk_agera_pll_configure) do not take some of the parameters that are provided in the vendor driver. Instead the upstream configuration should provide the final user_ctl value that is written to the USER_CTL register. Fix the config so that the PLL is configured correctly, and fixes CAMCC_MCLK* being stuck off. Fixes: 80f5451d9a7c ("clk: qcom: Add camera clock controller driver for SM6= 350") Suggested-by: Taniya Das Signed-off-by: Luca Weiss Reviewed-by: Abel Vesa Reviewed-by: Taniya Das --- drivers/clk/qcom/camcc-sm6350.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/clk/qcom/camcc-sm6350.c b/drivers/clk/qcom/camcc-sm635= 0.c index 8aac97d29ce3..87806392a59d 100644 --- a/drivers/clk/qcom/camcc-sm6350.c +++ b/drivers/clk/qcom/camcc-sm6350.c @@ -145,15 +145,11 @@ static struct clk_alpha_pll_postdiv camcc_pll1_out_ev= en =3D { static const struct alpha_pll_config camcc_pll2_config =3D { .l =3D 0x64, .alpha =3D 0x0, - .post_div_val =3D 0x3 << 8, - .post_div_mask =3D 0x3 << 8, - .aux_output_mask =3D BIT(1), - .main_output_mask =3D BIT(0), - .early_output_mask =3D BIT(3), .config_ctl_val =3D 0x20000800, .config_ctl_hi_val =3D 0x400003d2, .test_ctl_val =3D 0x04000400, .test_ctl_hi_val =3D 0x00004000, + .user_ctl_val =3D 0x0000030b, }; =20 static struct clk_alpha_pll camcc_pll2 =3D { --=20 2.51.1 From nobody Wed Oct 22 15:57:34 2025 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 704A8350292 for ; Tue, 21 Oct 2025 18:09:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761070194; cv=none; b=oNpYYJqrauU1eURHxxqcb0TtKI/k/zy2lT8d8D7zKwSi3ORBWG5eg+qFBRWySAeRlHp+JcpYXSKkeZMpcVwfQPtmDRefWax4tvoAHNW9kQgJbkdK0WIy5rgfBnPPRdgkEjz7cCclUoYVHJlA5JT9zjJW/LLV3WLtEw4zZKkEIE8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761070194; c=relaxed/simple; bh=2Eq9A/AKwnR3gDsuZiWxdapYlfrJ603IEtmRzywXGso=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=B/+Co129J4FXmwoVws0DJFCCFuCWnQ/gjVp9Wa2fS1llKqukCH1B4DjSqxF0HcddlLDV1tS4sJreTaAUkSgIsq8sh5C8Iy67ONyp1NZzlVXR1hD2jqjmW8f+CguqT+3mJ309XdjbfvPaO9BL0a5rCC7OBSjrSHfU+JT1R9rPhBQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=sh1xbfEs; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="sh1xbfEs" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b5a8184144dso965059666b.1 for ; Tue, 21 Oct 2025 11:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1761070191; x=1761674991; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fZfW33wDtMvPrY5GE5lKPaP3JYy6uTE6Yvy/BumW9Tk=; b=sh1xbfEsyxanZhnJmfRlO51HBynpowWXhNcWWzxCls8DOoxtH+tF+SMuDv4h0N+zIw Q9VFMeD5DXWVUxy7814uTRkzm03NGgEXi+uiAaiU8oi8awVUu4tBhavwhUpEF/Tw1TXl HQvEuZN3qsGAq/3ST+y50EfczyPtH4Xp9g+zhDYCRTMRUBTjBmbM7puP+8R0nBoFDZqZ XNqUQVrb2WvXEgk0rQN+jUU8+q3EHHa5JQO7oyUP1CNIA5UFkGwAFbE6u0daksFN5TSr IHk+SaXCU7z1lWtlGyUuHpQBKYUeqv5M0DHDYFvCl3PprphxtMvr5idP92uN9yrRmj/O oVcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761070191; x=1761674991; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fZfW33wDtMvPrY5GE5lKPaP3JYy6uTE6Yvy/BumW9Tk=; b=vRSnuYKqVg0eXq/SadAokAxHlErabmxHXFsegBQmwyJaBxahxOVG/C9uGXEi3Qie2Y 97+MZgnmXgA6it6idY1lRqqzMluktLLYadP8hSGx6Y9DINAgQ77MH87me1gL22FqJpc3 we+TWuL+KE2yaPPCCqW/iCQRWdh78avceNPY9Oel7BmhKZH3/jMR4n1FcSeXFc97dUyn f0JQLJR+BRVd0wmzSUSdk2d+nKePQmkxhzB9u90Yijhw0soeJ/UYt8TNp+mVII7WkprN OQ+DEJ/RgSN1W+gzVThDNShedzOSjjN4nAmBseXW6p5VyA8NHuX+7nRSKzM5ecFZjQEb /cdA== X-Forwarded-Encrypted: i=1; AJvYcCX+4Ep3Zv1uyVm6H/egfnUSmbvH/4sD9k0bp8ww7XbtHHlIfqGnNsHoNuYBXiE0cdXsNW+YMM4RS3O/+tU=@vger.kernel.org X-Gm-Message-State: AOJu0YzqewqFCDns1EJysjxitiMJYC9S0cov7ZtRQsLxDQ8z250Gm1X3 SsU+vV2FtGs/jHsFw8OFwjwke963KZ9MCBIB6Zfy9G78ANRs+sqxr4I6B4k6Y2jd5Ow= X-Gm-Gg: ASbGnctScNAbaua2cnerKFt9J71xoaEsfxoqZ94uK1W+bWDFmwGJxKRZlLUoCs831h0 fejd8MRkc5tJEm/ZytIOXa4Uh7GMmmuYoa5XU4uVfi64VV68Yeb/pAlHW/0rt7ivHOz9+D4N5kC e/E43TjM23PAv2OqEsw/7AUvOJ5RiTfMmEnLcUauUM/kmGl2dwwAaNY/i7nmASnuIiJ4zlt5B5x hIPdi3qz4NlZiOXCK+ynuN+MejHb9/dGZY0etmFOzIB/VYBkbT6yM0B2fEtYOwVVaUGlR4VA7HF JsgR+VC99t0nb6N7QQGeihx+Rtfj6G1gnp++OY+s72GMQhr5CrWYnfOWl+5IgxvzsYOLgmnAK5S Cpe9AxWQOiQdNFRSXqnEexb3ZZAdub9V4d3L9+DLK5AebaQYNYKLhT+rAuVQLPl25SVP3EgFol6 tGHg78JfI= X-Google-Smtp-Source: AGHT+IEtlpg7hHwYviAs9wYaJ8CDpbBGpkeU1rbRL5K3RYBz0JwLkuE1x94/3J0jWIixwOjEj4tdUA== X-Received: by 2002:a17:907:9288:b0:b3c:a161:6843 with SMTP id a640c23a62f3a-b647403a56amr2215928266b.4.1761070190578; Tue, 21 Oct 2025 11:09:50 -0700 (PDT) Received: from otso.local ([213.208.157.251]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b65e8393778sm1116758166b.24.2025.10.21.11.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Oct 2025 11:09:50 -0700 (PDT) From: Luca Weiss Date: Tue, 21 Oct 2025 20:08:55 +0200 Subject: [PATCH 2/2] clk: qcom: camcc-sm7150: Fix PLL config of PLL2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251021-agera-pll-fixups-v1-2-8c1d8aff4afc@fairphone.com> References: <20251021-agera-pll-fixups-v1-0-8c1d8aff4afc@fairphone.com> In-Reply-To: <20251021-agera-pll-fixups-v1-0-8c1d8aff4afc@fairphone.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Konrad Dybcio , Danila Tikhonov , Taniya Das Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1761070183; l=1299; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=2Eq9A/AKwnR3gDsuZiWxdapYlfrJ603IEtmRzywXGso=; b=f6OVJw7dVaXmR3bN8+qrmYA4vRl/NtjHLvMpHGDllO4eZ6Umrt9okj7FpWsAidTFfMYCwvrIZ iLD5F0UgX4PAioKrJoBKaV0jcuvrWD9MRfX9FRK+H0QYJ90gLRud5yX X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= The 'Agera' PLLs (with clk_agera_pll_configure) do not take some of the parameters that are provided in the vendor driver. Instead the upstream configuration should provide the final user_ctl value that is written to the USER_CTL register. Fix the config so that the PLL is configured correctly. Fixes: 9f0532da4226 ("clk: qcom: Add Camera Clock Controller driver for SM7= 150") Suggested-by: Taniya Das Signed-off-by: Luca Weiss Reviewed-by: Abel Vesa Reviewed-by: Taniya Das --- drivers/clk/qcom/camcc-sm7150.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/clk/qcom/camcc-sm7150.c b/drivers/clk/qcom/camcc-sm715= 0.c index 4a3baf5d8e85..590548cac45b 100644 --- a/drivers/clk/qcom/camcc-sm7150.c +++ b/drivers/clk/qcom/camcc-sm7150.c @@ -139,13 +139,9 @@ static struct clk_fixed_factor camcc_pll1_out_even =3D= { /* 1920MHz configuration */ static const struct alpha_pll_config camcc_pll2_config =3D { .l =3D 0x64, - .post_div_val =3D 0x3 << 8, - .post_div_mask =3D 0x3 << 8, - .early_output_mask =3D BIT(3), - .aux_output_mask =3D BIT(1), - .main_output_mask =3D BIT(0), .config_ctl_hi_val =3D 0x400003d6, .config_ctl_val =3D 0x20000954, + .user_ctl_val =3D 0x0000030b, }; =20 static struct clk_alpha_pll camcc_pll2 =3D { --=20 2.51.1