From nobody Sat Feb 7 18:20:26 2026 Received: from fra-out-008.esa.eu-central-1.outbound.mail-perimeter.amazon.com (fra-out-008.esa.eu-central-1.outbound.mail-perimeter.amazon.com [35.158.23.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E355284671; Mon, 20 Oct 2025 16:14:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=35.158.23.94 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760976858; cv=none; b=Ool+zj6+6xiSoKjZgzYPUVsJX/Ul/DrvB33n8P/EX+fTyN9IhV8QkS6UzYmqHNbOqZmUqiGTAb8QFNVxxa8MLOhfRyYEGsUvXqRkxx09Rewk/VK863ib0xf6CHT1jD8KbQWonHFVCnrjNVn2DMldPm7ma0GW55+BN+w3VngcWB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760976858; c=relaxed/simple; bh=n0SF7XdAN+SKJyChrtucQj/9yIMiZFAkj8Z+b9LPqOc=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=NYdmuzpF9Rv3qaPEECPlUTkrKukk783JX5HOLbIEQmt3jyieZALKmyu5i+z6bCLjF0mnV7AidbjuekXnwceP8b/ZdkwosYj+BTCwlIMKy1RI3JhHembn30twza44+JLqQFOhSN6Wql9ILi3dd/Uvs8k57WvGQiBieQ5woHotoYU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.co.uk; spf=pass smtp.mailfrom=amazon.co.uk; dkim=pass (2048-bit key) header.d=amazon.co.uk header.i=@amazon.co.uk header.b=r0bRcpFQ; arc=none smtp.client-ip=35.158.23.94 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.co.uk header.i=@amazon.co.uk header.b="r0bRcpFQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazoncorp2; t=1760976856; x=1792512856; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bDE/UgJKgZwC9aFtGJ5WbzVcYQJbFk3uDJQx4+C3IGI=; b=r0bRcpFQYQSgEYyyRC1u+Pax4sOFVP9KFNoJkD3H7JYfW4K7OSFk1qFO zJCi+7v1pqJCSG8tdBPsCeG0OXoOjKZgFcLuJ+zspK/WeawtFYRC1EGRe 9UbYNmudCYXvxcIxBMgMFNhp5IkjgZIJ6rQJU+w9CsXe6bxYPNN8j+PHJ QyLk+OrQIGI2YutMSONsdPzsEhAQouquYgPoE1mqdc4yWxZaHnA9cSe6p zChzQ0nWDH5IYd7Rme25rRFU67mR8fvCRAxwe5GQcAgkAbiqzQcHTqgq/ ZkVASFpUT6umqw6hqxps899Y1bAvUZRj824WYYsHbBcX8gR8vxwrdrLZX A==; X-CSE-ConnectionGUID: EzV4z7h5Tyq/esQTJyqbfg== X-CSE-MsgGUID: TWPY43StSWiT/Jkndqj2qg== X-IronPort-AV: E=Sophos;i="6.19,242,1754956800"; d="scan'208";a="3899445" Received: from ip-10-6-11-83.eu-central-1.compute.internal (HELO smtpout.naws.eu-central-1.prod.farcaster.email.amazon.dev) ([10.6.11.83]) by internal-fra-out-008.esa.eu-central-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2025 16:14:06 +0000 Received: from EX19MTAEUB001.ant.amazon.com [54.240.197.234:19895] by smtpin.naws.eu-central-1.prod.farcaster.email.amazon.dev [10.0.18.241:2525] with esmtp (Farcaster) id a5299e80-435c-40e6-94ce-2de2a320a4cc; Mon, 20 Oct 2025 16:14:06 +0000 (UTC) X-Farcaster-Flow-ID: a5299e80-435c-40e6-94ce-2de2a320a4cc Received: from EX19D022EUC003.ant.amazon.com (10.252.51.167) by EX19MTAEUB001.ant.amazon.com (10.252.51.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.20; Mon, 20 Oct 2025 16:14:05 +0000 Received: from EX19D022EUC002.ant.amazon.com (10.252.51.137) by EX19D022EUC003.ant.amazon.com (10.252.51.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.20; Mon, 20 Oct 2025 16:14:05 +0000 Received: from EX19D022EUC002.ant.amazon.com ([fe80::bd:307b:4d3a:7d80]) by EX19D022EUC002.ant.amazon.com ([fe80::bd:307b:4d3a:7d80%3]) with mapi id 15.02.2562.020; Mon, 20 Oct 2025 16:14:05 +0000 From: "Kalyazin, Nikita" To: "pbonzini@redhat.com" , "shuah@kernel.org" CC: "kvm@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "seanjc@google.com" , "david@redhat.com" , "jthoughton@google.com" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Manwaring, Derek" , "Cali, Marco" , "Kalyazin, Nikita" Subject: [PATCH v6 1/2] KVM: guest_memfd: add generic population via write Thread-Topic: [PATCH v6 1/2] KVM: guest_memfd: add generic population via write Thread-Index: AQHcQdyOdC7YhcHS8EaGGq7hvFXtwg== Date: Mon, 20 Oct 2025 16:14:05 +0000 Message-ID: <20251020161352.69257-2-kalyazin@amazon.com> References: <20251020161352.69257-1-kalyazin@amazon.com> In-Reply-To: <20251020161352.69257-1-kalyazin@amazon.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Nikita Kalyazin write syscall populates guest_memfd with user-supplied data in a generic way, ie no vendor-specific preparation is performed. If the request is not page-aligned, the remaining bytes are initialised to 0. write is only supported for non-CoCo setups where guest memory is not hardware-encrypted. Signed-off-by: Nikita Kalyazin --- virt/kvm/guest_memfd.c | 48 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c index 94bafd6c558c..f4e218049afa 100644 --- a/virt/kvm/guest_memfd.c +++ b/virt/kvm/guest_memfd.c @@ -380,6 +380,8 @@ static int kvm_gmem_mmap(struct file *file, struct vm_a= rea_struct *vma) =20 static struct file_operations kvm_gmem_fops =3D { .mmap =3D kvm_gmem_mmap, + .llseek =3D default_llseek, + .write_iter =3D generic_perform_write, .open =3D generic_file_open, .release =3D kvm_gmem_release, .fallocate =3D kvm_gmem_fallocate, @@ -390,6 +392,49 @@ void kvm_gmem_init(struct module *module) kvm_gmem_fops.owner =3D module; } =20 +static int kvm_kmem_gmem_write_begin(const struct kiocb *kiocb, + struct address_space *mapping, + loff_t pos, unsigned int len, + struct folio **foliop, + void **fsdata) +{ + struct file *file =3D kiocb->ki_filp; + struct inode *inode =3D file_inode(file); + pgoff_t index =3D pos >> PAGE_SHIFT; + struct folio *folio; + + if (!kvm_gmem_supports_mmap(inode)) + return -ENODEV; + + if (pos + len > i_size_read(inode)) + return -EINVAL; + + folio =3D kvm_gmem_get_folio(inode, index); + if (IS_ERR(folio)) + return -EFAULT; + + *foliop =3D folio; + return 0; +} + +static int kvm_kmem_gmem_write_end(const struct kiocb *kiocb, + struct address_space *mapping, + loff_t pos, unsigned int len, + unsigned int copied, + struct folio *folio, void *fsdata) +{ + if (copied && copied < len) { + unsigned int from =3D pos & ((1UL << folio_order(folio)) - 1); + + folio_zero_range(folio, from + copied, len - copied); + } + + folio_unlock(folio); + folio_put(folio); + + return copied; +} + static int kvm_gmem_migrate_folio(struct address_space *mapping, struct folio *dst, struct folio *src, enum migrate_mode mode) @@ -442,6 +487,8 @@ static void kvm_gmem_free_folio(struct folio *folio) =20 static const struct address_space_operations kvm_gmem_aops =3D { .dirty_folio =3D noop_dirty_folio, + .write_begin =3D kvm_kmem_gmem_write_begin, + .write_end =3D kvm_kmem_gmem_write_end, .migrate_folio =3D kvm_gmem_migrate_folio, .error_remove_folio =3D kvm_gmem_error_folio, #ifdef CONFIG_HAVE_KVM_ARCH_GMEM_INVALIDATE @@ -489,6 +536,7 @@ static int __kvm_gmem_create(struct kvm *kvm, loff_t si= ze, u64 flags) } =20 file->f_flags |=3D O_LARGEFILE; + file->f_mode |=3D FMODE_LSEEK | FMODE_PWRITE; =20 inode =3D file->f_inode; WARN_ON(file->f_mapping !=3D inode->i_mapping); --=20 2.50.1 From nobody Sat Feb 7 18:20:26 2026 Received: from fra-out-002.esa.eu-central-1.outbound.mail-perimeter.amazon.com (fra-out-002.esa.eu-central-1.outbound.mail-perimeter.amazon.com [3.65.3.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03F4A279917; Mon, 20 Oct 2025 16:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=3.65.3.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760976875; cv=none; b=H7X+S9lLAzMLlX1kPQPnQNRIDuQJCf8cZNlhwcq5VJY+EDGlBFsbYPDA7U+Xz52TNxmyB/zwFyrTrI9Xlt63ePxMT8iSXa/7rzOF/n/lqqXPTBIBrGiSFLhcRGNzZFwQNvx8rVNxjW/pA/9riRyEF/2dx/IZwSln2AmBfsxwWzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760976875; c=relaxed/simple; bh=luCWr/Ti5SiD6fz+TpJW/iL8yE1ZLZnMzX0YcwCrUyg=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=YO26dQXd6O6N9EllYellSMylI4DNqC/+WtWKA0CIr7Oc2VvRLZ2qrq2eVsDXqo9vLiKD7GC+YNKru2j0/hE4K4nboTA0LyiHdzAJSh0bem1R+yNaO3Vg8XgNYtj6fkEzuoOL8JkhjBmxgzOHjrWAkA3P35gOVuuyiBFEYkj0ru8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.co.uk; spf=pass smtp.mailfrom=amazon.co.uk; dkim=pass (2048-bit key) header.d=amazon.co.uk header.i=@amazon.co.uk header.b=RKZF37ra; arc=none smtp.client-ip=3.65.3.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.co.uk header.i=@amazon.co.uk header.b="RKZF37ra" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazoncorp2; t=1760976873; x=1792512873; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Q24GU8FcFCs6WJb9C+XwHstoC5iy5s3AhZ8lLVXQMsU=; b=RKZF37racKRjX2zf0QAbUJJu6AgxU2GUPfqO68CdMRW1eAtZpMbdeio2 Sndza5GbheYIIFdhhkyyXoIrlRuiv/SozVjp6fKy6mBFdyx1hH7gowfbp BQjio+QVnS2JTn5dqGevmBL3LXClDPMKWh9WFOBcLHnsEqKA9KCQ6FXZK 1gzg5wiMU7a7RJPSimPho1TivgVrIoPWazwhbfNx10763/9tu5Err2IiI yKbHSF05pxpW8WnxWvMyBQRueyh/mdAFbOOyHlFHmkNsnRgXBM8qVvv0M JDQjI3XI+oOtQyxhTchiIGG/olHNYgkNJdvHEJkwptOnAZIYMqsYBlO8T g==; X-CSE-ConnectionGUID: q1YPj9UCS+C9pLJ1GqSwKw== X-CSE-MsgGUID: 6KYuymc7Sv+p6+VzGT1Dvg== X-IronPort-AV: E=Sophos;i="6.19,242,1754956800"; d="scan'208";a="3895146" Received: from ip-10-6-11-83.eu-central-1.compute.internal (HELO smtpout.naws.eu-central-1.prod.farcaster.email.amazon.dev) ([10.6.11.83]) by internal-fra-out-002.esa.eu-central-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2025 16:14:17 +0000 Received: from EX19MTAEUA001.ant.amazon.com [54.240.197.233:15098] by smtpin.naws.eu-central-1.prod.farcaster.email.amazon.dev [10.0.47.14:2525] with esmtp (Farcaster) id bf172871-1a0f-446d-960b-c321c4ef4f18; Mon, 20 Oct 2025 16:14:17 +0000 (UTC) X-Farcaster-Flow-ID: bf172871-1a0f-446d-960b-c321c4ef4f18 Received: from EX19D022EUC001.ant.amazon.com (10.252.51.254) by EX19MTAEUA001.ant.amazon.com (10.252.50.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.20; Mon, 20 Oct 2025 16:14:17 +0000 Received: from EX19D022EUC002.ant.amazon.com (10.252.51.137) by EX19D022EUC001.ant.amazon.com (10.252.51.254) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.20; Mon, 20 Oct 2025 16:14:16 +0000 Received: from EX19D022EUC002.ant.amazon.com ([fe80::bd:307b:4d3a:7d80]) by EX19D022EUC002.ant.amazon.com ([fe80::bd:307b:4d3a:7d80%3]) with mapi id 15.02.2562.020; Mon, 20 Oct 2025 16:14:16 +0000 From: "Kalyazin, Nikita" To: "pbonzini@redhat.com" , "shuah@kernel.org" CC: "kvm@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "seanjc@google.com" , "david@redhat.com" , "jthoughton@google.com" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Manwaring, Derek" , "Cali, Marco" , "Kalyazin, Nikita" Subject: [PATCH v6 2/2] KVM: selftests: update guest_memfd write tests Thread-Topic: [PATCH v6 2/2] KVM: selftests: update guest_memfd write tests Thread-Index: AQHcQdyVtSwBRiB1XUqIh7uAE+bzAw== Date: Mon, 20 Oct 2025 16:14:16 +0000 Message-ID: <20251020161352.69257-3-kalyazin@amazon.com> References: <20251020161352.69257-1-kalyazin@amazon.com> In-Reply-To: <20251020161352.69257-1-kalyazin@amazon.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Nikita Kalyazin This is to reflect that the write syscall is now implemented for guest_memfd. Signed-off-by: Nikita Kalyazin --- .../testing/selftests/kvm/guest_memfd_test.c | 51 ++++++++++++++++--- 1 file changed, 45 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing= /selftests/kvm/guest_memfd_test.c index b3ca6737f304..be1f78542d64 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -24,18 +24,55 @@ #include "test_util.h" #include "ucall_common.h" =20 -static void test_file_read_write(int fd) +static void test_file_read(int fd) { char buf[64]; =20 TEST_ASSERT(read(fd, buf, sizeof(buf)) < 0, "read on a guest_mem fd should fail"); - TEST_ASSERT(write(fd, buf, sizeof(buf)) < 0, - "write on a guest_mem fd should fail"); TEST_ASSERT(pread(fd, buf, sizeof(buf), 0) < 0, "pread on a guest_mem fd should fail"); - TEST_ASSERT(pwrite(fd, buf, sizeof(buf), 0) < 0, - "pwrite on a guest_mem fd should fail"); +} + +static void test_write_supported(int fd, size_t total_size) +{ + size_t page_size =3D getpagesize(); + void *buf =3D NULL; + int ret; + + ret =3D posix_memalign(&buf, page_size, total_size); + TEST_ASSERT_EQ(ret, 0); + + ret =3D pwrite(fd, buf, page_size, total_size); + TEST_ASSERT(ret =3D=3D -1, "writing past the file size on a guest_mem fd = should fail"); + TEST_ASSERT_EQ(errno, EINVAL); + + ret =3D pwrite(fd, buf, page_size, 0); + TEST_ASSERT(ret =3D=3D page_size, "write on a guest_mem fd should succeed= "); + + ret =3D fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, 0, page= _size); + TEST_ASSERT(!ret, "fallocate(PUNCH_HOLE) should succeed"); + + free(buf); +} + +static void test_write_not_supported(int fd, size_t total_size) +{ + size_t page_size =3D getpagesize(); + void *buf =3D NULL; + int ret; + + ret =3D posix_memalign(&buf, page_size, total_size); + TEST_ASSERT_EQ(ret, 0); + + ret =3D pwrite(fd, buf, page_size, 0); + TEST_ASSERT(ret =3D=3D -1, "write on guest_mem fd should fail"); + TEST_ASSERT_EQ(errno, ENODEV); + + ret =3D fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, 0, page= _size); + TEST_ASSERT(!ret, "fallocate(PUNCH_HOLE) should succeed"); + + free(buf); } =20 static void test_mmap_supported(int fd, size_t page_size, size_t total_siz= e) @@ -281,12 +318,14 @@ static void test_guest_memfd(unsigned long vm_type) =20 fd =3D vm_create_guest_memfd(vm, total_size, flags); =20 - test_file_read_write(fd); + test_file_read(fd); =20 if (flags & GUEST_MEMFD_FLAG_MMAP) { + test_write_supported(fd, total_size); test_mmap_supported(fd, page_size, total_size); test_fault_overflow(fd, page_size, total_size); } else { + test_write_not_supported(fd, total_size); test_mmap_not_supported(fd, page_size, total_size); } =20 --=20 2.50.1