From nobody Wed Dec 17 13:51:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7203F2C0266; Mon, 20 Oct 2025 04:56:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760936197; cv=none; b=iiD5NyXzpP//fvT0r49l7QA6x+JuwWdKzL2d3m9/npnPlSAs88M+AHpPHPPUdRBINZ5RV03HCCLQCZ35hK/HuKOO8GH7za01EG71wqoUTCVd14NcrslhtNoTkOf+SzIHrXT3kfzzILdsbYOutlHJ/X7Gyooh4UghX6Dru0lOyJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760936197; c=relaxed/simple; bh=FyWhY5bdBhnBjSs0edv55LlddyoKr6zkeQMAkUftQ70=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a+JmbbjSI+ZydRnYD/EvXKxRO+aLFm+JIShc410TB8n56IzHWnU+qJ5NGexS2xCIu7s4Cqkaayw1VjX8GImFBLRSV50G8hjyJRxIrJudbou46hFD4ajibfeoHPLVwD9mKnMPxSNunQed4yAowyMUfKimE04Kgrx0vduMn0v6u+g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NbNsoq84; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NbNsoq84" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 359C5C19421; Mon, 20 Oct 2025 04:56:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760936197; bh=FyWhY5bdBhnBjSs0edv55LlddyoKr6zkeQMAkUftQ70=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NbNsoq84dyjFRgMtcA96mVS3b2XBf/pIlooEgaFs7+3i3Js3NvAioIrM2QRxCIlP1 /DOGUZbzxwJ4KKeBhXqDDv4JiyyEjq0GB2z7WpCYzWXXz9Rf1H0NvQD5PFEHPiYQyD imxXO+6wv/dj6NmQv0NGW9LGXYGFGtzX91pvNr3c05Uy/onWLbKggp6mymu+e8OROV VT6RlQiMHAItRzYMwbcqZBc9vNeMdGnTJynywE2hPYur8MMwPNkeXm4hxe3+42Fvu5 hc9U1b4dykspZiNE1Ca0cI2qIn9gHGir7D/03Ln7dzDP6PSuOd6LSN6dUCTugJ+1IK U9bBDOJbtYpcA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vAhwn-0000000083B-0zoc; Mon, 20 Oct 2025 06:56:41 +0200 From: Johan Hovold To: Joerg Roedel , Will Deacon Cc: Robin Murphy , Sven Peter , Janne Grunau , Rob Clark , Marek Szyprowski , Yong Wu , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai , Thierry Reding , Krishna Reddy , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH v3 05/14] iommu/mediatek: fix device leak on of_xlate() Date: Mon, 20 Oct 2025 06:53:09 +0200 Message-ID: <20251020045318.30690-6-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20251020045318.30690-1-johan@kernel.org> References: <20251020045318.30690-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference taken to the iommu platform device when looking up its driver data during of_xlate(). Fixes: 0df4fabe208d ("iommu/mediatek: Add mt8173 IOMMU driver") Cc: stable@vger.kernel.org # 4.6 Acked-by: Robin Murphy Reviewed-by: Yong Wu Signed-off-by: Johan Hovold Reviewed-by: AngeloGioacchino Del Regno --- drivers/iommu/mtk_iommu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 0e0285348d2b..8d8e85186188 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -974,6 +974,8 @@ static int mtk_iommu_of_xlate(struct device *dev, return -EINVAL; =20 dev_iommu_priv_set(dev, platform_get_drvdata(m4updev)); + + put_device(&m4updev->dev); } =20 return iommu_fwspec_add_ids(dev, args->args, 1); --=20 2.49.1