From nobody Sat Feb 7 12:35:04 2026 Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A1042F546D for ; Mon, 20 Oct 2025 09:35:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760952955; cv=none; b=WUB71OmiO4Xy4QX776dKCvsu8w6BVSPYrow7LM2uA8xc3QRUELly5UeiuaIG/7HTmQUUH3hPVT86IjpLqSQshoCWmOZwTK86IMC9buJccbzJ4Hy54CRfwezF3EiworWC2uKJuvFWl2Ps0JX2oYNVORJUN7nXvT8T/wwu8Q7bbhk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760952955; c=relaxed/simple; bh=Rj3Cv0A0AFvlIdCz5QQRixaigsXAGVT7hj4kSACuzHY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=AC29iVd75u0nzdpfdeE+YQAZw9oRxAxBL1bX4DmCcd870BBdumJE0iiRRNeeHHh7mzor5m6jhlFHYkfnD9HJiZ4GyUSuhP0AJMjcvh2WleZ5MSOtdBVyxuuvxnrKfY5EmpSf99zscenr6ssCW+unVYQdTMuEFSk1GD2AmVLlqL8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kEDvq1Hu; arc=none smtp.client-ip=209.85.221.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kEDvq1Hu" Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-426ff59a320so5825514f8f.3 for ; Mon, 20 Oct 2025 02:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1760952952; x=1761557752; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=IQ/tfUyYnFA5M9VsXSlnSLFGwbCz4/7ogPBgd0QPqz8=; b=kEDvq1HulWNUpzq1QJMxsApVBhkwv0/XEYpfweEeIxZz5kxbFnE+CUgc/0VBH1FW2j SQKki0+uUhs2AJ+T3nVDX4s9unCLQ/LuVK/tJs4KxZmez5GXqEwwuVj4llvTs0VqYwzj uq1sXLugekvdeAbiAj1KxQCoj6x8J3jzjEseOxeUGLEJ4rVFdjOQ276EZk2RCICEDdrY LkjOJ+EnZi0rgiTar5PDPXt/LNnmBn9ZfFEDb0yrJCiKpEMQCHhlcmcflTdsD+/Nq6/t QufBWo0I67T7jeovjCffEw9ZIw/X/JDoawXdV0oEOBM/nOhlN1HihhBxJsnHcxhlNJTA CSBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760952952; x=1761557752; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IQ/tfUyYnFA5M9VsXSlnSLFGwbCz4/7ogPBgd0QPqz8=; b=UpfjH2fCnVfTpSCw4prEolOg/q5NC5jF0ku+Zw8e31zBbFpIONhdgsKpV7NUi7KlyK JisgkzjRiFjjQcMzh9gpeNZxq1s+lVxoh9b5TXawq7M0RXsWq3OpTmuN/MiQuHJWkfwW DHmZoIFqDuCBqvmNalPSf3WCpbfdfgFMpULvy1aKm3Ss7aL8HBjbG0HVvfz3ghhY6zqv ch0a64TttqYasBQeruCTLLih3zraSWkhVKLN5gbbgI+AoY4WC+wuX0rYyyEQ2t2eqwN0 Yoh8sMqnDZhsECdnO7BvkeyB4BOs1p1+4A/+zv4eNdLpu6kpLvjyM6uX4I4Hb5BvEmbY 3N6A== X-Forwarded-Encrypted: i=1; AJvYcCUxx5249MbSqJUv0mxKtKSGde8zZ1wujnzImprrPgYkDxiROukNyGU5bLGYwND2VXF6ayXfsP6Ak2h71Tw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9mCB97orJLiKBqsjbPbHJkIJjKc680ZTrCbHuTGIHtqr1RQm1 I62sBSG2EJEVcaBuNd/pEwWGAJtxm3HDuAUbpDTh1fSLwbg/s2yX23uOC3CXFV1Y0QgMc0nBEY5 tV9y/2w6RwkrPUAIedA== X-Google-Smtp-Source: AGHT+IHkHZkomFzjib5JOKNGBWO6OTU3fGhk+HTOmg4VbQ9B2LuZx7BK0Fqf50b8EvR6TWFduVWrCYrhCF+fRGs= X-Received: from wrmp17.prod.google.com ([2002:adf:e611:0:b0:3ee:1586:6c7a]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a5d:5f82:0:b0:3eb:5245:7c1f with SMTP id ffacd0b85a97d-42704d7ea04mr6947439f8f.2.1760952951574; Mon, 20 Oct 2025 02:35:51 -0700 (PDT) Date: Mon, 20 Oct 2025 09:35:34 +0000 In-Reply-To: <20251020-clk-send-sync-v2-0-44ab533ae084@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251020-clk-send-sync-v2-0-44ab533ae084@google.com> X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=1120; i=aliceryhl@google.com; h=from:subject:message-id; bh=Rj3Cv0A0AFvlIdCz5QQRixaigsXAGVT7hj4kSACuzHY=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBo9gJ0REHnnmRjuUcXmyar5evdHcpqd7O9bOlbp b8p5mfvUKCJAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCaPYCdAAKCRAEWL7uWMY5 RjunD/9OSGEajhA31CYLMpj12QvqjwYd26hG4WCYAqisJiPP9b95yWC0X/zTIib3+aGDkZQOwDB Ra7rND7uAdDfnQl6n3cQ7TN0O9jGTjcqx3CPEGnx60WNUuJuG1FgjI9eaYqnu15BkkYPxgLFRGA icfaMnV949dRkd0qxdk1HbJ+7cC9kPx+JXqEG0dxF1vAYyvjkJO4JXmRO7IWcJg22YJ8v0xqMzm LeaQsNgPknR+duhFZNbDQYMx6HkpN0ESBdNZWJazjqSt1dqUBIIYPOQIvQNYRXn8ZujIlDcadGe OoAXiWN2htu4tyc7pIsFrcJ4T9RsRg/xW5w/pWFi7DCcg0T1ZAcNG5PEsAAiEd6BxQn6rDJ43+m LX9P1rg2SlsYfcHxXpek42B+U+2RH34D5oIlU1RMkcwlrZy/WPW7dj/ObKYCNrz9a9ctJ149I40 2iqb/r9DrUW9VU8AG+gQxk9HsTksT7+9VanENR2X8p78gWPF9k2WQ5yOAJdub+ivHPCatt/Ekyk qKuJ823yf0Ogoe5SZZ3/FGx84Ptfedr0DIE+kCABXXID+z6MIUXpniQIG9wxxtl25F2I/Kp8eXs LnpAVIJfgp97lZjPeUOt7MmKvu3cXslMdq7ztj+kAv4+f4xQbHlrujuGvBdR7qfCyF8QUOFe5my jZjTBl1D/li30Nw== X-Mailer: b4 0.14.2 Message-ID: <20251020-clk-send-sync-v2-1-44ab533ae084@google.com> Subject: [PATCH v2 1/2] rust: clk: implement Send and Sync From: Alice Ryhl To: Michael Turquette , Stephen Boyd Cc: Viresh Kumar , Miguel Ojeda , Boqun Feng , Gary Guo , "=?utf-8?q?Bj=C3=B6rn_Roy_Baron?=" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Daniel Almeida , linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alice Ryhl Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable These traits are required for drivers to embed the Clk type in their own data structures because driver data structures are usually required to be Send. Since the Clk type is thread-safe, implement the relevant traits. Signed-off-by: Alice Ryhl Acked-by: Viresh Kumar Reviewed-by: Boqun Feng Reviewed-by: Danilo Krummrich --- rust/kernel/clk.rs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/rust/kernel/clk.rs b/rust/kernel/clk.rs index 1e6c8c42fb3a321951e275101848b35e1ae5c2a8..0a290202da69669d670ddad2b67= 62a1d5f1d912e 100644 --- a/rust/kernel/clk.rs +++ b/rust/kernel/clk.rs @@ -129,6 +129,13 @@ mod common_clk { #[repr(transparent)] pub struct Clk(*mut bindings::clk); =20 + // SAFETY: It is safe to call `clk_put` on another thread than where `= clk_get` was called. + unsafe impl Send for Clk {} + + // SAFETY: It is safe to call any combination of the `&self` methods i= n parallel, as the + // methods are synchronized internally. + unsafe impl Sync for Clk {} + impl Clk { /// Gets [`Clk`] corresponding to a [`Device`] and a connection id. /// --=20 2.51.0.915.g61a8936c21-goog From nobody Sat Feb 7 12:35:04 2026 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64A512F6184 for ; Mon, 20 Oct 2025 09:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760952956; cv=none; b=iyrm9gvBhMuIi0eovqNEFwAXcF0XUVxkpQGWcigEqG7f8SkYPzmY3GmTvtW+TJip1vOIDDcnQHAHTNo7pDsG/qChBhJhFyhweCHvyENBP/QKXflXYBnpwGtojuzPWgAR61ICDGFfcNP9BHxxwkFEc8pIpvh0pHBAhUt+fws/DeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760952956; c=relaxed/simple; bh=Re+DOU6/e6dkcK3rl4TDT3ox52jxcfPQEvS5zL7tp/g=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Gay7I+j/640UK8c4NBCAO3dDc/0S4Zn8KKWE80AWTDu9h71TsKjfsIJk1whvgyRLPE4pAsNCguVoahPMYcoQ03yzpRXZvXdEozlN1GNf09EKzccRLZuULIa/AfHj+HtjAySuunH0JWfvf6z4jNGxKPXuugJa28NmwrImxKR9pro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=1RUFl2LW; arc=none smtp.client-ip=209.85.221.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="1RUFl2LW" Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-42700160169so2189214f8f.1 for ; Mon, 20 Oct 2025 02:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1760952953; x=1761557753; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=M4tqO9Ss7dvk0HhlC8ItWFcBE+vqGHgkt9qscACZJ4U=; b=1RUFl2LWMYmE0wZ7SZRuwEEQkImEJTM/VTw9bsGEhkblqTUgPHPnf4W46mqSkmfNMw GvrwVA2X6PLl0Cm6eP+J1TuoRC1x7J/tjlQDvu9n4sqYe9E+6tj3ONopelDCWlbUY2d/ Lg3XsxX69Eiay3qcA3Id4aOS+YQr3PN4hnPXsfFM6ZzSLpuPUkG/YHTIYB4cXkongzuQ GBVIXU6mEuVRoEGqQdVETYB1BF3YEzE9znm9WGwtkT+RHfeoylG+Ev5M40cot5HW1AVI dnYVHOsSMICSdvLcemgumkWMglHL9naXxH1HGFzPL8Qh3ssB1XuR8tbqH8JDqjfkHoc/ eKGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760952953; x=1761557753; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M4tqO9Ss7dvk0HhlC8ItWFcBE+vqGHgkt9qscACZJ4U=; b=wlV2lF7hWc+IV5NF3U7jWvkESk/d2r7xOUF6CeDt5wrcgZLuAZl9/xKzatoP6gDsOR qcOulZAPyCI4DjCx/gjubHYAhmyckAWK9RLE6cuF61xScvqzBWi1JEDOrFO09ReklRqT n/mfCw6wc4KzN0Iqu3Szt+WlFGp55En/RWpgNcWGDAeDF7CU8Pa7cTp6H9XgBmXS9XDg dwTuFUAqO4MTh1XsFQq3ylc/d5UHZEk0Tlriu7zPp4bmRYreCi3G528hFT/rltRpp4Q4 A2BVZ/msgvEpK+MFXhW6/57/WLz7DnOIdt1NMyv8Afeq/5caw/x22zLWyLVEmIPSvwyA IduA== X-Forwarded-Encrypted: i=1; AJvYcCXBXr00oSXXofOksaTjn6a19V7zwrs+5sPKaR3vdvms9ZJJj3E3lKXL+ksa/ZgF6zUBvftOgjCz42Tdnq8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/GzTnCAby5JHQs5lYZOccP4bxtX8l5LFmo8GvmDi58KxXnYJS jDfiOYXBjZYQsCHE1bMSF4LcsTOYk5tdL91WDkFqxlEakSRww5ezYJjg/UYURdgXIEwz7u2oWBm H1vjBpVMEP6GUtUOGSQ== X-Google-Smtp-Source: AGHT+IEPdMgaAsWVjr61PyUGcldq0t0ZV5oF0MkmxsMnMiNypMU138b1txPZ8fl/PFCxXF3KGb7789Q8USnSNmM= X-Received: from wrbea3.prod.google.com ([2002:a05:6000:ec3:b0:426:da8f:f403]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:26c4:b0:427:202:d4d2 with SMTP id ffacd0b85a97d-42704db5b02mr8051029f8f.58.1760952952791; Mon, 20 Oct 2025 02:35:52 -0700 (PDT) Date: Mon, 20 Oct 2025 09:35:35 +0000 In-Reply-To: <20251020-clk-send-sync-v2-0-44ab533ae084@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251020-clk-send-sync-v2-0-44ab533ae084@google.com> X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=1503; i=aliceryhl@google.com; h=from:subject:message-id; bh=Re+DOU6/e6dkcK3rl4TDT3ox52jxcfPQEvS5zL7tp/g=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBo9gJ07vy/mXgVpdOzBOWq5qGFjx03OJ2lFgfAi n22Xp8hhmyJAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCaPYCdAAKCRAEWL7uWMY5 Rij2EACyfhsJPjQ4ytTfDpEjKd1ocl5UxJUPZpGWrQOsDzjPSSTHDC9vOEsFkkzpAyXeU17d0Qs m/3yYJmuQSOsCPb8cV3ltxv4qU8Z75tF/b6lst22W3fK5G8lqSiGblXNW1gx4TgZ757iFAXCvWF ciPm3m6C8M8SIqAa99IIaE8oEUPZBCAnisRRPVJ77Me8S7cNE3xSHr79A1sN6s2yxNWmOjKZ7Yb GJu5Wh2dWMZBp3N+Uz9XC69a3s4rBRyJ2yRvh8PVAQ4tAkjq4yq5yOIQUl3LJ+O7bnJbeclMfQ0 lRB3CR8c7lEba8t4rg6naXb/oFC6W46wlVoT9T04sPOqEMUXQZQbe+eTMUlwCWDoPrJjp/v07IF zjql0Hsf3HgAq6UAKoiFs1PdrvxC638uoLpVT7guRvlca/JbxR/Syjttxb8NfJzMAwGpNpb7mgG 1A3UL9bH0iyXJNzd1JhXR9kv2MQK8XnOczxR9/Lnu+ZsDk2DQeWHAQSAtChVD4gObn3L5KX3R62 ZMeTuFI0nUJRPevoZ5q5D1lNZveSmGuiGAkuk7tDZaaHkeUiEzroKk2k8FugE5A2g2YnpgzH0gA jpgdtAV6a85Ru+ZL2g5oGmNYPDwBIrUMS+5LLf82YGg3oRm3qK2YeKhYjVgX60UorqxiABR+V9T CQ9akw67fcYzwXw== X-Mailer: b4 0.14.2 Message-ID: <20251020-clk-send-sync-v2-2-44ab533ae084@google.com> Subject: [PATCH v2 2/2] tyr: remove impl Send/Sync for TyrData From: Alice Ryhl To: Michael Turquette , Stephen Boyd Cc: Viresh Kumar , Miguel Ojeda , Boqun Feng , Gary Guo , "=?utf-8?q?Bj=C3=B6rn_Roy_Baron?=" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Daniel Almeida , linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alice Ryhl Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Now that clk implements Send and Sync, we no longer need to manually implement these traits for TyrData. Thus remove the implementations. The comment also mentions the regulator. However, the regulator had the traits added in commit 9a200cbdb543 ("rust: regulator: implement Send and Sync for Regulator"), which is already in mainline. Signed-off-by: Alice Ryhl Reviewed-by: Boqun Feng Reviewed-by: Danilo Krummrich --- drivers/gpu/drm/tyr/driver.rs | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/tyr/driver.rs b/drivers/gpu/drm/tyr/driver.rs index d5625dd1e41c8406494b267d4ac560c442a8012c..574b85bbc497f8d1053d16a11f7= 7ecbe2c87bfb2 100644 --- a/drivers/gpu/drm/tyr/driver.rs +++ b/drivers/gpu/drm/tyr/driver.rs @@ -53,18 +53,6 @@ pub(crate) struct TyrData { pub(crate) gpu_info: GpuInfo, } =20 -// Both `Clk` and `Regulator` do not implement `Send` or `Sync`, but they -// should. There are patches on the mailing list to address this, but they= have -// not landed yet. -// -// For now, add this workaround so that this patch compiles with the promi= se -// that it will be removed in a future patch. -// -// SAFETY: This will be removed in a future patch. -unsafe impl Send for TyrData {} -// SAFETY: This will be removed in a future patch. -unsafe impl Sync for TyrData {} - fn issue_soft_reset(dev: &Device, iomem: &Devres) -> Result { regs::GPU_CMD.write(dev, iomem, regs::GPU_CMD_SOFT_RESET)?; =20 --=20 2.51.0.915.g61a8936c21-goog