From nobody Sat Feb 7 08:27:51 2026 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E514122836C for ; Sat, 18 Oct 2025 15:18:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760800691; cv=none; b=Q5yM5ZXjyMOjJwmwhdqOy1BYdElRw7SZmCxySy3gnanWq9JC0pm3bGqkMBGW36m/y/eZT6dBrlhjRxmR0/8kS7eBB8T/wD0pY0LJSxBKHXXUpQTqM7fFgKkT778eeg508+0BdTOpJpB0foa6hTgy+mPSf0YT6bL/D73IWwWh8oM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760800691; c=relaxed/simple; bh=uPnH5ewj9MAoqq1yVrco8LvFEZu5ocqvEtDb1ZRbnWw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GznQzhzo8iBSXRmd83lYz5ZAmNyC+AyJhNxH0uryExAah+O1Uln+3otm4I5NrGbJUAT70XShk38Ioc7U4vRaenOK6auDI9djgScQS41ntz6kN7jo0Us/dl5147yts9/rHlK4LirOV5Hul7lA9Z8o7kZi/QSrttz1LgREKez+woc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=googlemail.com; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b=NbOvrSpT; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=googlemail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="NbOvrSpT" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-b50206773adso731922266b.0 for ; Sat, 18 Oct 2025 08:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1760800684; x=1761405484; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=0ziuauqYm5nAIFZTrsIsUXlvSa4YCy2hrgmDn3UImNQ=; b=NbOvrSpT5b6SMtAxSgF/eT61MVylZoRTA9IQdmsIu8/HWXUKDu9UGhMSq87BN5feG5 PSBVs7dCEOkh3vybsvPXniZmlklB8EHlcxjaO+v3MoHDlwVYI/s00Rogg/ln/qDAv068 iqRMOszYKYYFpYGBjN3xtjT08mSMxQXTWjLbWFGA8YJejxXn9a5iY6KHy9HTMugG3Vhp wdxeR7SjALhGPmRzck4morX9LkUEVOe/nPqjEvS1ZmF7Hkpe6KxDWds3EnuZdqN349I0 jF0oYIWwF3jzaZThgqrhXICzPXP0aVXTgzTGgteYJZjl7AnNsBiKnPQPZECa6/Qau3Wz 0Mtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760800684; x=1761405484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0ziuauqYm5nAIFZTrsIsUXlvSa4YCy2hrgmDn3UImNQ=; b=qdccz7vj7EVEPgRd6xD4crZAaZfXSTEO1p52iFFw4txICybhhKlC3LQtXzLqhJKtlN 3nZtStV1R59K+F6JfnuL0rZg9fAFrXdpVW0goLnfIgxMfRrFnwAVh0yCII1EZ1jC5xZ5 tbjUOXh1HhNNrq4pTUswmvcp0yEDerIOPfWK/sxnLcxXY6A1LW3l+OeV2ieCmZF1vrpG YTrfDeFkxdWhOyy9C5u02/pLkVPhGEVIreEdc1cH+MnotzH2aTQkkfabr1ySdJjpVIR0 LK1MVm6IcxEHDPwTxL9wjiCCLKV7n6Qs0dCuXj4kWFMzYZ4ymfrWs4Kw2rWkyc3u3dpw e8TA== X-Forwarded-Encrypted: i=1; AJvYcCVwyb3ajyQosphQ57Hm3705SPLDjTJwrwwmWbdZxS3edoYNj/YhehesRNVEEZsYv88rjGnoaViwjTTx5eA=@vger.kernel.org X-Gm-Message-State: AOJu0YwYmbkKkxX1GeEviB0XzMkBP5QjwtNbsFogCsSEMuKx5czq7LRS +LGf6a0V0CGFzeNmjXfFcrOi19fJHwkx/6ixAGQT8AA1iD+xJjLqaW72aIoOLr7QEW8= X-Gm-Gg: ASbGnctUT0XsORbdglnlCl9FycBMxZCiTzGAePmK4kxMLOpX+ZnXb8FWcdOSK6E8npa Du/gVCp8NhtZXSqXeX+5433VcVfUjtJ6SwEu81PtCVmXx47uDx6gr0CmSoDlVMSNgAX+l0+Gl3a 3Ie0HWTciA9RLIDPGlfrMIxxMW4ZmmuRNOopkHi0GdAbrPixsdTLVmUxTl2Vyi/2Zzf/Pb0H8D9 C/EWHy3Dv0sNJVSm9Oww3PTetnXPKWD8xAipUQQvtXHQOD8p0eP8bJ6lTRuGCgGBeXqaECq4yCK MS7izOs1TpfFHIBZDlRKTtMUyqyEuZSABTBHAhZdy9/WbkfYF7H0P/BictJ0o7OXq68O1q68vwU UwdkphKckR+ve03PoFZLhG1pId7rzwn0KUgxUfGcwngLfh3DD0CB2cBHfrXZ58rT/Gg5jyxui6Z n1dvaYQZFk7U9nZqwSCFRrFE64/sczJzQKpSVUW59Wm8DaZ8xu/6H/g/FYAibz5QvIQ0FiNBC8v g== X-Google-Smtp-Source: AGHT+IG9vq0qMlQ90uZLTJ+7i+vyez08khY42hQiH9++p1pjab0KxXKoIzUX4plMAY7ETu5kWV6yhg== X-Received: by 2002:a17:907:894f:b0:b33:821f:156e with SMTP id a640c23a62f3a-b605249e3b3mr1287934366b.12.1760800683677; Sat, 18 Oct 2025 08:18:03 -0700 (PDT) Received: from tycho (p200300c1c7311b00ba8584fffebf2b17.dip0.t-ipconnect.de. [2003:c1:c731:1b00:ba85:84ff:febf:2b17]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b65eb036846sm259983366b.54.2025.10.18.08.18.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Oct 2025 08:18:03 -0700 (PDT) Sender: Zahari Doychev From: Zahari Doychev To: donald.hunter@gmail.com, kuba@kernel.org Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, jacob.e.keller@intel.com, ast@fiberby.net, matttbe@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, johannes@sipsolutions.net, zahari.doychev@linux.com Subject: [PATCH 3/4] tools: ynl: call nested attribute free function for indexed arrays Date: Sat, 18 Oct 2025 17:17:36 +0200 Message-ID: <20251018151737.365485-4-zahari.doychev@linux.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251018151737.365485-1-zahari.doychev@linux.com> References: <20251018151737.365485-1-zahari.doychev@linux.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When freeing indexed arrays, the corresponding free function should be called for each entry of the indexed array. For example, for for 'struct tc_act_attrs' 'tc_act_attrs_free(...)' needs to be called for each entry. Previously, memory leaks were reported when enabling the ASAN analyzer. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D874=3D=3DERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f221fd20cb5 in malloc ./debug/gcc/gcc/libsanitizer/asan/asan_mall= oc_linux.cpp:67 #1 0x55c98db048af in tc_act_attrs_set_options_vlan_parms ../generated/t= c-user.h:2813 #2 0x55c98db048af in main ./linux/tools/net/ynl/samples/tc-filter-add.= c:71 Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f221fd20cb5 in malloc ./debug/gcc/gcc/libsanitizer/asan/asan_mall= oc_linux.cpp:67 #1 0x55c98db04a93 in tc_act_attrs_set_options_vlan_parms ../generated/t= c-user.h:2813 #2 0x55c98db04a93 in main ./linux/tools/net/ynl/samples/tc-filter-add.c= :74 Direct leak of 10 byte(s) in 2 object(s) allocated from: #0 0x7f221fd20cb5 in malloc ./debug/gcc/gcc/libsanitizer/asan/asan_mall= oc_linux.cpp:67 #1 0x55c98db0527d in tc_act_attrs_set_kind ../generated/tc-user.h:1622 SUMMARY: AddressSanitizer: 58 byte(s) leaked in 4 allocation(s). The following diff illustrates the changes introduced compared to the previous version of the code. void tc_flower_attrs_free(struct tc_flower_attrs *obj) { + unsigned int i; + free(obj->indev); + for (i =3D 0; i < obj->_count.act; i++) + tc_act_attrs_free(&obj->act[i]); free(obj->act); free(obj->key_eth_dst); free(obj->key_eth_dst_mask); Signed-off-by: Zahari Doychev Reviewed-by: Jakub Kicinski --- tools/net/ynl/pyynl/ynl_gen_c.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen= _c.py index 58086b101057..aadeb3abcad8 100755 --- a/tools/net/ynl/pyynl/ynl_gen_c.py +++ b/tools/net/ynl/pyynl/ynl_gen_c.py @@ -861,6 +861,18 @@ class TypeIndexedArray(Type): return [f"{member} =3D {self.c_name};", f"{presence} =3D n_{self.c_name};"] =20 + def free_needs_iter(self): + return self.sub_type =3D=3D 'nest' + + def _free_lines(self, ri, var, ref): + lines =3D [] + if self.sub_type =3D=3D 'nest': + lines +=3D [ + f"for (i =3D 0; i < {var}->{ref}_count.{self.c_name}; i++)= ", + f'{self.nested_render_name}_free(&{var}->{ref}{self.c_name= }[i]);', + ] + lines +=3D f"free({var}->{ref}{self.c_name});", + return lines =20 class TypeNestTypeValue(Type): def _complex_member_type(self, ri): --=20 2.51.0