From nobody Sat Feb 7 18:21:18 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16F3522FDEC for ; Sat, 18 Oct 2025 05:45:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760766302; cv=none; b=BmxrzTdh8PvDTInJG1jHOtGaaZ29yXWj8LAXfFTFypAsScapwkpsSUdZ3+g53oihM2OVC+5+bjLPyqAJ60rJe+T8eC032GanO3L/BeRmumqLj85SYL/DfGsYqOPqvuayVOZVmfQK0lDoWdUm4j1u6QNb3AWT7l4H6k/q3gY3rJ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760766302; c=relaxed/simple; bh=h7f7ZWtVJI2DIDI9Rl3L83ur3hWLteJgDYDRZ8/rwBc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kLn9I4RI601r4d8IiyTJ6HjjLTfrAsbFOxpHvpAoGw1Vdsyb7Wgljw1J881igCkf2IePNr23qsCzbcCB097riednbRwSKtRWYieElR2JVdaFHaYDIqpre6D2Ec9S4x3Y6tzn83bqvjGQZxBSWj4LJE8mTDchWAajmm7mm7TsHEg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0x0f.com; spf=pass smtp.mailfrom=0x0f.com; dkim=pass (1024-bit key) header.d=0x0f.com header.i=@0x0f.com header.b=OY5RoZMh; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0x0f.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0x0f.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=0x0f.com header.i=@0x0f.com header.b="OY5RoZMh" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-781db5068b8so2170003b3a.0 for ; Fri, 17 Oct 2025 22:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; t=1760766300; x=1761371100; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=89BI59zwmh1Ubu37m+UzRMVYEbxdBWMilagPFw2Lo2s=; b=OY5RoZMhYddl0a+wItiD9LgycamsF1hVf9dljcXLdCSG5vVYmC7sdx/Liid5XodtVG 7E5HdMp16Arpp74/iqAoB2+f6VmclGTJtJMN1BSY1gsEQE+Fb3YhJh/xW3QikrmOYHsH 2yuRQ0UKFFYtM/IYIkJDNNHtP0TesOlGaE260= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760766300; x=1761371100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=89BI59zwmh1Ubu37m+UzRMVYEbxdBWMilagPFw2Lo2s=; b=IkYLZ0stsVOJRPZng0WcdZTOZQZnqBWMuBWvVncWRBcvGcZvy2qg5JFlPQ6ey9o2j1 p4vcuDWhs1iCuDu/g0L6BH3uaRDvM9HkyhHMmoXJfEbWzvRItyXmfCcWKnnql42/1T1I Q0wzFxHkQ5qm/ZdAi8bqVI/R2UWByFyZUD1+XPyA8mMTm3pihGIT+DUYFfmNnP70+XaX gqSOZ7lWe7rXm6qPBfDiUQ7osxiPKBybYhi5YH9t+Wcq1/zD+jM4+iyV+c0xz8dL1BKL 2GgifpjfcUSBP+hGUuSraisoK3e2IsEC9Q2LwiPlDsF4oy5Ag3vAl7lzl6YRChcO8WI/ 6PLw== X-Forwarded-Encrypted: i=1; AJvYcCWZlNk/VFimijzcPG8YYn3W6E7GZqzP8kXKFqfxMYfdHzhTlgbwuTKKWJE9SI8wMGmyb8OsmlYKfEYiHdY=@vger.kernel.org X-Gm-Message-State: AOJu0YzR2noBDtxy06tMe/kFOANrsa9zNNxO1kBdlw09F4jSV0uC3N69 kIp4cREwPsp3/N5mlBwHgJ1W83g6Wa/WX7l7PiQ2c9wNYbnEpItghWishGIsa4zsufI= X-Gm-Gg: ASbGncv6lKjZcG1p276wQmreCPJj3qNuvmZjQG62mRTWOg6BXChHSA4teu6M/kSKJ2a eCDSfI0WVO+LzhstTkZU4IIVMwf7hfvDI20umtbpNfqY1VzNd9S+HyClJ8GtivLcfMzrhRcc/NY jdTsNoJgLI9PguU2en2919xHis6lxnNq8A6fpDK8M0FYZPQkbNIRUkTEaaB2yqshizFbG9TnCFM DEoht5iReawfZy10xZERDTeE/N0PWOboZoaQsVAbAlAYMy2I96Vp2CUAHTE8H3l5DgrOgNt7WsL zZBfmxuRjDhGrJpPbihstbamochaG5p15rdf+qmaViSv73HL+fXsUCKTRTc3pZoRoLqskEiZdAs ZZeVi4Ox4WUOUmvHy/BO2N5fWSGTtq5OudRBJZLnwHINdQ9hercv6bDk62JXWLVYoBmw8ja65ja XDeLyGdErUFPhhU/vhd+Dps6mXbjiEL7a1wRqXBbsjZ5x4THoO2hQ= X-Google-Smtp-Source: AGHT+IEHbWRy0UQfKYZEKhc6rfju/pKkbqQ6hk4S/GiStG+bKUHgiK4+G/rplbVGaAB9yEUU3M4bFA== X-Received: by 2002:a05:6a21:6daa:b0:306:2a14:d0d4 with SMTP id adf61e73a8af0-334a8625728mr7189585637.43.1760766300265; Fri, 17 Oct 2025 22:45:00 -0700 (PDT) Received: from shiro (p1391188-ipxg00a01sizuokaden.shizuoka.ocn.ne.jp. [153.222.3.188]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-b6a76645c61sm1657222a12.3.2025.10.17.22.44.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 22:45:00 -0700 (PDT) From: Daniel Palmer To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@gmail.com, simona@ffwll.ch, wuhoipok@gmail.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Palmer Subject: [PATCH 1/3] drm/radeon: Clean up pdev->dev instances in probe Date: Sat, 18 Oct 2025 14:44:49 +0900 Message-ID: <20251018054451.259432-2-daniel@0x0f.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251018054451.259432-1-daniel@0x0f.com> References: <20251018054451.259432-1-daniel@0x0f.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Get a struct device pointer from the start and use it. Signed-off-by: Daniel Palmer --- drivers/gpu/drm/radeon/radeon_drv.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/r= adeon_drv.c index 88e821d67af7..eb5138da8d5b 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -262,6 +262,7 @@ static int radeon_pci_probe(struct pci_dev *pdev, unsigned long flags =3D 0; struct drm_device *ddev; struct radeon_device *rdev; + struct device *dev =3D &pdev->dev; const struct drm_format_info *format; int ret; =20 @@ -277,7 +278,7 @@ static int radeon_pci_probe(struct pci_dev *pdev, case CHIP_VERDE: case CHIP_OLAND: case CHIP_HAINAN: - dev_info(&pdev->dev, + dev_info(dev, "SI support disabled by module param\n"); return -ENODEV; } @@ -289,7 +290,7 @@ static int radeon_pci_probe(struct pci_dev *pdev, case CHIP_HAWAII: case CHIP_KABINI: case CHIP_MULLINS: - dev_info(&pdev->dev, + dev_info(dev, "CIK support disabled by module param\n"); return -ENODEV; } @@ -303,11 +304,11 @@ static int radeon_pci_probe(struct pci_dev *pdev, if (ret) return ret; =20 - rdev =3D devm_drm_dev_alloc(&pdev->dev, &kms_driver, typeof(*rdev), ddev); + rdev =3D devm_drm_dev_alloc(dev, &kms_driver, typeof(*rdev), ddev); if (IS_ERR(rdev)) return PTR_ERR(rdev); =20 - rdev->dev =3D &pdev->dev; + rdev->dev =3D dev; rdev->pdev =3D pdev; ddev =3D rdev_to_drm(rdev); ddev->dev_private =3D rdev; --=20 2.51.0 From nobody Sat Feb 7 18:21:18 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BF6527C84B for ; Sat, 18 Oct 2025 05:45:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760766308; cv=none; b=jcXsp6Z2ihwUDscwS+J/TxgO1zgYNDWyW+EPIND8QwI2e2nNUzQSIhnwDTA7VoZ6Ij85QtHbKeq3qsmPna1BFuhoeAWxvNh/0w82c0Sm3k4uTB5Wj+pdk88yp6NLP1eLWiPZhF1sLJKZn3J0W73GTahggAUunOiBJLTnFBuQq5c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760766308; c=relaxed/simple; bh=KaZzZuA8TQDpbsoSLk8AxZHwe5KtcN19DuSyt3eabX8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gvMv4OPBpeC/ky7T0/Ao8Io2iJAqPQ1MlsZczggqiLvHyqn+3yfNUKUADPgQclbdeHzLJyXScPRg9pX8xyk2cf1urtdcRI5DhZEW+RrQp+k+PauZNJyGKPkLzDJtSdJXVREGd164Bb5YJ+KYZPc+cGttDdQ+Hyf52925UrZHOqo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0x0f.com; spf=pass smtp.mailfrom=0x0f.com; dkim=pass (1024-bit key) header.d=0x0f.com header.i=@0x0f.com header.b=p/E7XPWW; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0x0f.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0x0f.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=0x0f.com header.i=@0x0f.com header.b="p/E7XPWW" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7a213c3c3f5so3585323b3a.3 for ; Fri, 17 Oct 2025 22:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; t=1760766303; x=1761371103; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VmUPjTR3yMW64aVQGfGVjFZpeabfMfYHxfBKINbWsBI=; b=p/E7XPWW8BWttLaorYfJX+11hAP1KMnLrFDlulaVl50/+p6e8SS0lEnMmDC95247Zc N3/AW0A1BsQ9HwHb3kHQHiIdafbgGNG0KYLL2EKbgevtY7Z/XHA77yotV8e94awgINM+ ITBykGkHj6TAiHcbA/ZMTR2rY6fet7oes/Yqk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760766303; x=1761371103; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VmUPjTR3yMW64aVQGfGVjFZpeabfMfYHxfBKINbWsBI=; b=w+mo6vh6OLMYZclfR6FCqhjlC6bD5kK3P3J1K4XqG+QVPHmDn3nxDOzlQEQEWkr2GS /KC0JmQQPPpJMJyuyfMlcN4q5Xw4SENzFV7FWtNuZG1blSmssPxbrXEhEI6D/V3JMPzd /b3Tp2949Z5O4IfKEmRKjFRsOqbHwFXDIJVGzJqeKZLPZBEZJPu0LS0qPB7bMpumy2tY IFXXifbm3hX/Bpb6CxGO4+NSJh/UQctSelhtHpMOt2BzkM3S2XdCGhbhHl0yBfbVtIq8 B+6z57ULOiQdJjp1zAx+ZVhifnBXMExhsMObhM3ZXRkSif+a+VeQaKBrdTi5J5iFB32l 91wQ== X-Forwarded-Encrypted: i=1; AJvYcCVo2bz+l48YOvVAfcAWVP+CzAHo8rooviFTqABzIGkRoZv7lXrWYpYQsnNzbEFkpp7aOqVYnlhxcZauPcY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1PU0JaH56PrXoMobsaRTQ7qweXEVYuGH+7a6sAhTfp/FTrGOF GjGedapS4BPcger/KNxRosM5jMXkdddJbXJx5IgnIUJ5bbQVOfPPj9FUj7JllVK0QPs= X-Gm-Gg: ASbGnctbc+g2TG7rJayKuvauuju5YpuXBVTLX7FJVJ8gtrPI/XznZNIM2zmv38SwT1e z2nI3cGjFZa7RlxyGtD5gVsjLgw/wYGgWEw0LACMNbrr5JH8z68bolxVowWzqf/GJ70j3S1g2xl Lp1F1EzLunKrnUHEyH42UDfbDAgMuoRoi9fVRUror40AYwpi7XoHTKE9SxaHlTmrVquguSRMYY/ D2JPPdwC4myWDt5e50k+8sWm1WbStHMVRJQRMkHjFlUQs8iCbW1fBnftVddGVlpUt0Bm3836vMt 45Ejiwd3j2KwkZFdvqg42kDVBuBaj60XfAY0OkEG9Z51DdroIMy9nqF32EOcuPGZRsI1E8uoHwu wFKNFDEKB8nENTkBQjOA/WQ2e9h75pjztD4Th/0J20H7Tn2P7EPxTryAOsoKa71LszR9B6KY1gJ x/11f/Mhy64T4Gx+FSjxZEaai/NwOTmH3EwICW6kYg X-Google-Smtp-Source: AGHT+IE0n5z7f/IMMhO8RMH8A+89s4jb/Yrjx1i30f1bpPQKuZW8GFOMc0cHZQNBYLb0n3r/GPAvpw== X-Received: by 2002:a05:6a21:3e15:b0:334:b57f:554a with SMTP id adf61e73a8af0-334b57f5562mr3664489637.25.1760766302707; Fri, 17 Oct 2025 22:45:02 -0700 (PDT) Received: from shiro (p1391188-ipxg00a01sizuokaden.shizuoka.ocn.ne.jp. [153.222.3.188]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-b6a76645c61sm1657222a12.3.2025.10.17.22.45.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 22:45:02 -0700 (PDT) From: Daniel Palmer To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@gmail.com, simona@ffwll.ch, wuhoipok@gmail.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Palmer Subject: [PATCH 2/3] drm/radeon: Do not kfree() devres managed rdev Date: Sat, 18 Oct 2025 14:44:50 +0900 Message-ID: <20251018054451.259432-3-daniel@0x0f.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251018054451.259432-1-daniel@0x0f.com> References: <20251018054451.259432-1-daniel@0x0f.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since the allocation of the drivers main structure was changed to devm_drm_dev_alloc() rdev is managed by devres and we shouldn't be calling kfree() on it. This fixes things exploding if the driver probe fails and devres cleans up the rdev after we already free'd it. Fixes: a9ed2f052c5c ("drm/radeon: change drm_dev_alloc to devm_drm_dev_allo= c") Signed-off-by: Daniel Palmer --- drivers/gpu/drm/radeon/radeon_kms.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/r= adeon_kms.c index 645e33bf7947..ba1446acd703 100644 --- a/drivers/gpu/drm/radeon/radeon_kms.c +++ b/drivers/gpu/drm/radeon/radeon_kms.c @@ -84,7 +84,6 @@ void radeon_driver_unload_kms(struct drm_device *dev) rdev->agp =3D NULL; =20 done_free: - kfree(rdev); dev->dev_private =3D NULL; } =20 --=20 2.51.0 From nobody Sat Feb 7 18:21:18 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C17B283124 for ; Sat, 18 Oct 2025 05:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760766309; cv=none; b=tTFgrBsovMkJnHOVtIsq6wXWJH+q2ZWqu7JBGcK7Wex/UdoCcbuLPP8e9kUoRdKaUSw/AO4wNCh02mXWqSf+HuQKqwraQpgjyGfcswlWviPLcgovMUF6OJlYZQEDzBC5C9Whfwn1D92uEeISnzz/ZlScMtsM+cIp6dVJ79TfX8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760766309; c=relaxed/simple; bh=iwfUgV2B9myGMPJUG6AdS/9k9YhfWcC7PvRS3rewzMU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fj+b7UmGaZYbsrH0BaRjV/RYQMh3tqUc7olb5z6LlduSX8LNJ/sD+hHvMNuvKaj5n1iXjUGNdyJA/MgyOVRt9J//kf0qM29Cfz9JOsDnbpqswPV32PsvRshgKmLAMWVH7Fg5CHrvcpUmAdO6bLgP8yV8cGlbKKF6e1YUpIHf6m4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0x0f.com; spf=pass smtp.mailfrom=0x0f.com; dkim=pass (1024-bit key) header.d=0x0f.com header.i=@0x0f.com header.b=nhDhGd09; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0x0f.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0x0f.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=0x0f.com header.i=@0x0f.com header.b="nhDhGd09" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-77f343231fcso1794701b3a.3 for ; Fri, 17 Oct 2025 22:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; t=1760766305; x=1761371105; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MQOTysCBScI2CzYaQCtToYUiGDVsPF1DI/yzJf9rUmc=; b=nhDhGd09lCfgA4L/z/DqOa4yeR2X2JQr0dgxFyDVcoUcI/s/sjPElYz/rH9GfHk4vU dxCgnJv1YV4GvomkZIf+Bn/dFeUMRH7km8jJ14h5NnAkY7LHhWYNMGDJQVPklUFVUQxo vi3xLDAwzuqsvFlMkxBM79AsP18XS2KnK4qDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760766305; x=1761371105; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MQOTysCBScI2CzYaQCtToYUiGDVsPF1DI/yzJf9rUmc=; b=ruLIuGU8QlbQombF04HHmGAvqUd7pv4btLecWxZgJ2Eiozgw1foai0GWDKE9o2unNk aFklI7WxWavHeAQOBuiRr96yVln2Z21S0ClPTTZXUWIs2hvrqF20yCHToWhyx0+6hGGK xABZ9okkmTe2GU/VcYatCKaGrXKv+o7TRx4mhfkkaKumu82tieoNoDODswt3skDNbEyp VRKAF3/U1l5t+hhnEBY4+3Jn+qg2apxB2plreR+BngtLGxU14Yxee5CdCZJA+VPexwxF 1nPXGCe+tkNvhat9llhXT7zqxl9Q5Y85xJ1RgWkgnsavzlfJAobH/CgSyPx1Mm5LPb+s rndQ== X-Forwarded-Encrypted: i=1; AJvYcCVRjgz48AXe83nWOIdjXCMsNV4LQN6QJrizR5Ow9HrXY8ZOhu1oUDrV8Ura0e1QnyTz28RrFVvq2VjWlMc=@vger.kernel.org X-Gm-Message-State: AOJu0YwQRd9ZCVdWMDXECXRzrYh4kFAN+kSWqhqTs+WQbC/PCVYNgBkG 8/3ul3Dtd0yivvuXzCQiC+uMGxUQa+2jf46lGPMzz9XyrqVIL0wHvwp5sgiuz3xyCrM= X-Gm-Gg: ASbGncv7gb3ZU/TxlKeRtoI8bw3iQQkj5J6/ZbZrdLtqbC/EPwAC97oMgz4/ocli9Rw DDWd3SEnkVQSJBqSEpiRkR/s3TfbJKbauWWycF1xF9D9Z6ltZ1pLsJxKG34ewAH01u4yusUBG29 Atxh587BE/D8vr/bBQWa0gYMJVGxfK32hxnoeEHrsjJn6w2SYleDARooVhMKl40TId8KvmFvzDz zykMVZ/6uwlQ/7Rj3roHUP4rdkr9nDnx2+oqpIOrHm7SMuryrFgtr+hYQft7BJRmi82WA/MmoIs DWUEpBu1I30SLgJcL6/hwRvpHgis543vQFcEbTGaSGsi0ISbCR2zoo+SEBoa9ByOD2vxezQplPS dEbYAUjw2nPmlQpWJDtss+DGB/WKB5lcSiYkCCCgFzD8JykRcSWuX8JtR0uIfYgT14bBpwaozxe 2skYdyXvL5+QUfSJYWHSFliJi2A6LuisNdmfyY1kr8aF7RM7/PjSo= X-Google-Smtp-Source: AGHT+IGy3J41ApbLMLRcrOO9pkHemkNxPjtpkJmBEBFlBmY9XVIw/TLuT/llEZB3A4RXYe9syKnQyg== X-Received: by 2002:a05:6a20:b38a:b0:334:aa54:bb2c with SMTP id adf61e73a8af0-334aa54bbd2mr5825208637.8.1760766305361; Fri, 17 Oct 2025 22:45:05 -0700 (PDT) Received: from shiro (p1391188-ipxg00a01sizuokaden.shizuoka.ocn.ne.jp. [153.222.3.188]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-b6a76645c61sm1657222a12.3.2025.10.17.22.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 22:45:04 -0700 (PDT) From: Daniel Palmer To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@gmail.com, simona@ffwll.ch, wuhoipok@gmail.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Palmer Subject: [PATCH 3/3] drm/radeon: Remove calls to drm_put_dev() Date: Sat, 18 Oct 2025 14:44:51 +0900 Message-ID: <20251018054451.259432-4-daniel@0x0f.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251018054451.259432-1-daniel@0x0f.com> References: <20251018054451.259432-1-daniel@0x0f.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since the allocation of the drivers main structure was changed to devm_drm_dev_alloc() drm_put_dev()'ing to trigger it to be free'd should be done by devres. However, drm_put_dev() is still in the probe error and device remove paths. When the driver fails to probe warnings like the following are shown because devres is trying to drm_put_dev() after the driver already did it. [ 5.642230] radeon 0000:01:05.0: probe with driver radeon failed with er= ror -22 [ 5.649605] ------------[ cut here ]------------ [ 5.649607] refcount_t: underflow; use-after-free. [ 5.649620] WARNING: CPU: 0 PID: 357 at lib/refcount.c:28 refcount_warn_= saturate+0xbe/0x110 Fixes: a9ed2f052c5c ("drm/radeon: change drm_dev_alloc to devm_drm_dev_allo= c") Signed-off-by: Daniel Palmer --- drivers/gpu/drm/radeon/radeon_drv.c | 25 ++++--------------------- 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/r= adeon_drv.c index eb5138da8d5b..350f88af888d 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -315,17 +315,17 @@ static int radeon_pci_probe(struct pci_dev *pdev, =20 ret =3D pci_enable_device(pdev); if (ret) - goto err_free; + return ret; =20 pci_set_drvdata(pdev, ddev); =20 ret =3D radeon_driver_load_kms(ddev, flags); if (ret) - goto err_agp; + goto err; =20 ret =3D drm_dev_register(ddev, flags); if (ret) - goto err_agp; + goto err; =20 if (rdev->mc.real_vram_size <=3D (8 * 1024 * 1024)) format =3D drm_format_info(DRM_FORMAT_C8); @@ -338,30 +338,14 @@ static int radeon_pci_probe(struct pci_dev *pdev, =20 return 0; =20 -err_agp: +err: pci_disable_device(pdev); -err_free: - drm_dev_put(ddev); return ret; } =20 -static void -radeon_pci_remove(struct pci_dev *pdev) -{ - struct drm_device *dev =3D pci_get_drvdata(pdev); - - drm_put_dev(dev); -} - static void radeon_pci_shutdown(struct pci_dev *pdev) { - /* if we are running in a VM, make sure the device - * torn down properly on reboot/shutdown - */ - if (radeon_device_is_virtual()) - radeon_pci_remove(pdev); - #if defined(CONFIG_PPC64) || defined(CONFIG_MACH_LOONGSON64) /* * Some adapters need to be suspended before a @@ -614,7 +598,6 @@ static struct pci_driver radeon_kms_pci_driver =3D { .name =3D DRIVER_NAME, .id_table =3D pciidlist, .probe =3D radeon_pci_probe, - .remove =3D radeon_pci_remove, .shutdown =3D radeon_pci_shutdown, .driver.pm =3D &radeon_pm_ops, }; --=20 2.51.0