From nobody Mon Feb 9 17:22:32 2026 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC6902512C8 for ; Sat, 18 Oct 2025 02:02:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760752955; cv=none; b=MsLr+ygHRnRD0aSplCIcEA+fMxZE5hOGUPhB3pRV28ijLjWaivAy9USrWa3WomcyA4WpHIUipGZL1HvwOn714WlM10sqCQv7SbfEAeM8J84Dzi0BANZmFbnz3ptTSVyFvOxVNu7ydIx5Bh+bsfuLDv3DfTpwt2+0fesRG6Ihz0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760752955; c=relaxed/simple; bh=29+P4pWa8FWUP1XwE/tCMa4X1wBauIadGEuAgBL8wcs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uTy3Gde7F5eq2cGZ/+wuImzm03P6YMmZzJvTxUYWJJ23H48MuXlT6HC8F7baaRCBCWNrcO5UOR8gpg2Hnc0Wyvf3eLX4TlZM1tvE7h5kDudw6ES+zTfWz5pdyJzw3RkWCEIfPUtyG9ZUIvbP4WM/rZH05uWobWfappt8GN1tAcs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=e3/+m6pa; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="e3/+m6pa" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 5269EC041FD; Sat, 18 Oct 2025 02:02:11 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id A72FE60701; Sat, 18 Oct 2025 02:02:30 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 45F7E102F236C; Sat, 18 Oct 2025 04:02:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1760752949; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=3WsXha5E73t8H3r1jXZgYyBkA1sGJtDmBUPYHsAPgho=; b=e3/+m6paQCIv/rZUbfcao0pEFooQwtorz9C3j91XWW0gJAu5PLHhN4mcXXjugPumMAsdQJ ZPduGQF6mPCIJDxpSF58lpxXtZ7SkdOPu3NBHaajGbYAOl/RiO6owRyGoR4E2b3oNlVrpS 3hKrRsewvxLRMoZ2J+cwG5LWmCTwNjE68eY9I9uUOT2TmvmU+W8VkItnzqNY33KRarHsGY Pa/3tLgizGCWUaRDZhjTQtGfYoOkQk6vTZq0flVggUtZ8n2iehePL/G8paGMYYckmToNrh 9WgTPJ0JzppGhUw74p8/EIY5mZYaHZvX+JAME/qG4Q9+Zt+WuneCIvI0ttt0bQ== From: Louis Chauvet Date: Sat, 18 Oct 2025 04:01:19 +0200 Subject: [PATCH 19/22] drm/vkms: Introduce configfs for connector EDID Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251018-vkms-all-config-v1-19-a7760755d92d@bootlin.com> References: <20251018-vkms-all-config-v1-0-a7760755d92d@bootlin.com> In-Reply-To: <20251018-vkms-all-config-v1-0-a7760755d92d@bootlin.com> To: Haneen Mohammed , Simona Vetter , Melissa Wen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , jose.exposito89@gmail.com, Jonathan Corbet Cc: victoria@system76.com, sebastian.wick@redhat.com, victoria@system76.com, airlied@gmail.com, thomas.petazzoni@bootlin.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4873; i=louis.chauvet@bootlin.com; h=from:subject:message-id; bh=29+P4pWa8FWUP1XwE/tCMa4X1wBauIadGEuAgBL8wcs=; b=owEBbQKS/ZANAwAKASCtLsZbECziAcsmYgBo8vT/s/CkQqnu5wUsyu7DMmkVLS/BHAGpY03MX eDbMs4G4RyJAjMEAAEKAB0WIQRPj7g/vng8MQxQWQQgrS7GWxAs4gUCaPL0/wAKCRAgrS7GWxAs 4gdsEACi8ysFOTzAs6OWBQ0nBsvZF0gjkHu9dgzrC+VUepM8QCoRO1Lp8Yd4UukCcZVnmqEqY52 nMMdJFWNT2wBTduT0zIk40lLwPUMnh5gtTKcerulGPg1r1N2AXJZ1XOhZZcsX4ec3tHB6gInJ9l Ql68HZsMbY7U+/Kcx3Q6Ca5+3Y+be98fk6orfSv3lEkPNNC8utDUlexF7tX6Bz37ghWBykC0n41 phtGlwidsgZBtNEENF/zvOI8kn0cmo5W8UtfIPmsfXxlSi57KgZUapSAzQpqgQtKOIcHFxwOGa0 TD27JS3+4WBNxIqbtsuHlBKyoE77VJzO2JASJvLGvRHwGsOY+FD10hrDA53d3wZkjSyH+GUF8Qp hR3K1p6FJgZcsHBBzdpioAbTDVniMmaNRSQy2M6DvqnGT1e6mNEqEsoRqq7z//ULlOckQrshQDV M6HVxhFH1bxMDh5+9LyXmn1y/BuxpXhm53QH5dfqscDCOXFL299GO4+HniZB66YapPUCSaFX8Tr GXrYC+967k0TuWC/aDOTNUL9xuGtEPR9pFdqElYt7IVEHfJ+kJtCJNr7GX08d/wxytgyO2AobxH LloEw0XMBoEt/QoSwN8dVFdybfq7fWusuarO9adN3odt7jMAbM7fJKHZVhFXXqxd+/hVw9Ydorc 5AQWORh2bVuTW7Q== X-Developer-Key: i=louis.chauvet@bootlin.com; a=openpgp; fpr=8B7104AE9A272D6693F527F2EC1883F55E0B40A5 X-Last-TLS-Session-Version: TLSv1.3 Introduce new attributes to configure EDID of a connector: - edid_enable - chose if the connector will have an EDD or not - edid - raw edid content Due to limitation of ConfigFS, the max len of EDID is PAGE_SIZE (4kB on x86), it should be sufficient for many tests. One possible evolution is using a ConfigFS blob to allow bigger EDID. Signed-off-by: Louis Chauvet --- Documentation/gpu/vkms.rst | 5 ++- drivers/gpu/drm/vkms/vkms_configfs.c | 81 ++++++++++++++++++++++++++++++++= +++- 2 files changed, 84 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index 650d6f6e79fd..bbd03f61e61c 100644 --- a/Documentation/gpu/vkms.rst +++ b/Documentation/gpu/vkms.rst @@ -135,7 +135,7 @@ Last but not least, create one or more connectors:: =20 sudo mkdir /config/vkms/my-vkms/connectors/connector0 =20 -Connectors have 3 configurable attribute: +Connectors have 5 configurable attribute: =20 - status: Connection status: 1 connected, 2 disconnected, 3 unknown (same = values as those exposed by the "status" property of a connector) @@ -144,6 +144,9 @@ Connectors have 3 configurable attribute: If supported_colorspaces is not 0, the HDR_OUTPUT_METADATA will also be = created. Value is a bitfield, 0x1 =3D NO_DATA, 0x2 =3D SMPTE_170M_YCC... see enum= drm_colorspace for full list. +- edid_enabled: Enable or not EDID for this connector. Some connectors may= not have an + EDID but just a list of modes, this attribute allows to disable EDID pro= perty. +- edid: Content of the EDID. Ignored if edid_enabled is not set =20 =20 To finish the configuration, link the different pipeline items:: diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/drivers/gpu/drm/vkms/vk= ms_configfs.c index 909f4557caec..a977c0842cd6 100644 --- a/drivers/gpu/drm/vkms/vkms_configfs.c +++ b/drivers/gpu/drm/vkms/vkms_configfs.c @@ -1,5 +1,4 @@ // SPDX-License-Identifier: GPL-2.0+ -#include "asm-generic/errno-base.h" #include #include #include @@ -1222,14 +1221,94 @@ static ssize_t connector_supported_colorspaces_stor= e(struct config_item *item, return count; } =20 +static ssize_t connector_edid_enabled_show(struct config_item *item, char = *page) +{ + struct vkms_configfs_connector *connector; + bool enabled; + + connector =3D connector_item_to_vkms_configfs_connector(item); + + scoped_guard(mutex, &connector->dev->lock) + enabled =3D vkms_config_connector_get_edid_enabled(connector->config); + + return sprintf(page, "%d\n", enabled); +} + +static ssize_t connector_edid_enabled_store(struct config_item *item, + const char *page, size_t count) +{ + struct vkms_configfs_connector *connector; + struct vkms_config_connector *connector_cfg; + bool enabled; + + connector =3D connector_item_to_vkms_configfs_connector(item); + connector_cfg =3D connector->config; + + if (kstrtobool(page, &enabled)) + return -EINVAL; + + scoped_guard(mutex, &connector->dev->lock) + { + vkms_config_connector_set_edid_enabled(connector_cfg, enabled); + + if (connector->dev->enabled && + vkms_config_connector_get_status(connector_cfg) !=3D + connector_status_disconnected) + vkms_trigger_connector_hotplug(connector->dev->config->dev); + } + return count; +} + +static ssize_t connector_edid_show(struct config_item *item, char *page) +{ + struct vkms_configfs_connector *connector; + + connector =3D connector_item_to_vkms_configfs_connector(item); + + scoped_guard(mutex, &connector->dev->lock) + { + unsigned int len =3D 0; + const u8 *edid =3D vkms_config_connector_get_edid(connector->config, &le= n); + + memcpy(page, edid, min(len, PAGE_SIZE)); + return min(len, PAGE_SIZE); + } + + return -EINVAL; +} + +static ssize_t connector_edid_store(struct config_item *item, + const char *page, size_t count) +{ + struct vkms_configfs_connector *connector; + + connector =3D connector_item_to_vkms_configfs_connector(item); + + scoped_guard(mutex, &connector->dev->lock) + { + vkms_config_connector_set_edid(connector->config, page, count); + + if (connector->dev->enabled && + vkms_config_connector_get_status(connector->config) !=3D + connector_status_disconnected) + vkms_trigger_connector_hotplug(connector->dev->config->dev); + } + + return count; +} + CONFIGFS_ATTR(connector_, status); CONFIGFS_ATTR(connector_, type); CONFIGFS_ATTR(connector_, supported_colorspaces); +CONFIGFS_ATTR(connector_, edid_enabled); +CONFIGFS_ATTR(connector_, edid); =20 static struct configfs_attribute *connector_item_attrs[] =3D { &connector_attr_status, &connector_attr_type, &connector_attr_supported_colorspaces, + &connector_attr_edid_enabled, + &connector_attr_edid, NULL, }; =20 --=20 2.51.0