From nobody Mon Feb 9 10:27:07 2026 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E083E23536C; Sat, 18 Oct 2025 02:02:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760752936; cv=none; b=UAOhH2ATyuQ2lLJ2po1pC2RUw7WFsmqgStNCT0LVBFvJXhg/wWGxr2er2yroqoOjiToxAjOslEXTwgQkI8YT9CaL7H4TibzYMC38rh37APhDaygEppNCmFi8KBFESPmAOfSoJAmzW9QKBynfEz6b4TyUzX7sS8TuDWlGdF0Ib60= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760752936; c=relaxed/simple; bh=rnZm7r0xEd9LrIvetwHGtyd26t99JexCbu1jReAcAkA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OgW5P5wx763C+qWKh+q76+oenPR/p1ivwk/zWdvlEImFXuCDRV0N71Sxrt2gG/PSliyRjmtNF2cRIWMXU/iLeSXlbvYALLKgu410ii5c9bu7GNcrnhEzdLCx6Ab72JNhSJFBKQllYxDH5GcD5IppDO0MN7tLLqgcCyn5p7wLHR4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=G6PTXMbJ; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="G6PTXMbJ" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 18F93C035A7; Sat, 18 Oct 2025 02:01:54 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 6EB9D60701; Sat, 18 Oct 2025 02:02:13 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C4D10102F236F; Sat, 18 Oct 2025 04:02:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1760752932; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=wuzcvgdxKucfzXi8j9im5vi/vTJhBZGMa5n+dwDEVE8=; b=G6PTXMbJ2EaohODqgvnjVzWRhmqz/rtYZmiCb9ifBrVZxX4qToO8NttU3cVVLGoHzHc9e6 3btjYWvTZMxCUiLEToLnyBhnC7DHTzMBWbrDEazYoALYhYM0McJBwueWaa7IIsNvkfcnZI lnLbMONXzDJWBxdjn1rAFNP/E17J5NKIFVm+sViXiwRDIrIE5Z4fH02CHSyDaXk7SKMlUA xMXyjo6yFIVV35NrilWVFORS+0ogSBM464dJ7wPYDf12SlW1Y9U9q4VZNSElnoJdjzkWhY 0EuWlY8OKag9kIt55e9HYc9CO5F0xCnQRq5C8sQbLh0B4yR0bhArhKuzBffXJg== From: Louis Chauvet Date: Sat, 18 Oct 2025 04:01:11 +0200 Subject: [PATCH 11/22] drm/vkms: Properly render plane using their zpos Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251018-vkms-all-config-v1-11-a7760755d92d@bootlin.com> References: <20251018-vkms-all-config-v1-0-a7760755d92d@bootlin.com> In-Reply-To: <20251018-vkms-all-config-v1-0-a7760755d92d@bootlin.com> To: Haneen Mohammed , Simona Vetter , Melissa Wen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , jose.exposito89@gmail.com, Jonathan Corbet Cc: victoria@system76.com, sebastian.wick@redhat.com, victoria@system76.com, airlied@gmail.com, thomas.petazzoni@bootlin.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Louis Chauvet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1521; i=louis.chauvet@bootlin.com; h=from:subject:message-id; bh=rnZm7r0xEd9LrIvetwHGtyd26t99JexCbu1jReAcAkA=; b=owEBbQKS/ZANAwAKASCtLsZbECziAcsmYgBo8vT+xoIue1CpAIt4T6KN7jou+Bm1RD5sZk06R Y9MqZmRzrGJAjMEAAEKAB0WIQRPj7g/vng8MQxQWQQgrS7GWxAs4gUCaPL0/gAKCRAgrS7GWxAs 4gswD/9uz11YdVk/AI3/365zjvg18lMdo4jHtEy8xMti9+hcxrUil51n1yf5iwXrhkIToD6zHf4 i/PAkjqr/R59R+btkABHQUm7fOmiVKzDLpmGXOsMBU5eXlm4g6KaPKLH/oUyd0Tax7cEaEJUJYh /y1JkEj1r32BYFJp2EaGl+tbX6B4FfabljJzeR2pG+1KJIrwH0U7t8s7t1WjelTSjd5DLF8/rYs rOrA5N7Svo4d1LYOhdOgySm+Mu8JghwH+bD6RlE6BeMEESNnUhhXHFI9BPic7l3/L2hZMbdl1xm Gv7KVU7hhqzRwn7iZSM2WLfk7T3XbpuA+YSIBN5DbvVcOru3fFl9aTwicRfiR+nAA6ezG8THBLR QUx27OZ287igzrR/0BPnJdSfE3Mjfh7P9I1qwGtaswrMeJIA+mWAoxr/cRkKezeQLe/L+LSBuJ1 YRHU5iiDFqWXAyAmnotVNVZBZGrjuxyXIsW2bP1Icq1y5KUg9KmmXY71kpxRcK4ynmbg54JvIR2 SAlyos/XtBMZbaxVTWcYL51ALTI/WSH68MwVbEEaMgwf3IMDOXsGxJy2x7asKcknsyntYJP6ou9 LYkkjTs4HYygNQhyurMd0DERmZ1FUAkEARbhYW/pA1WPIAJgMEYZJ0Cc3SsO6aML4YQRA1cKcq2 7B23EQ03kCe447Q== X-Developer-Key: i=louis.chauvet@bootlin.com; a=openpgp; fpr=8B7104AE9A272D6693F527F2EC1883F55E0B40A5 X-Last-TLS-Session-Version: TLSv1.3 Currently planes are rendered in creation order. This is not an issue, but with the introduction of new zpos configuration, it is required to properly render planes. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_crtc.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_c= rtc.c index bac0790c6577..0524c47460fb 100644 --- a/drivers/gpu/drm/vkms/vkms_crtc.c +++ b/drivers/gpu/drm/vkms/vkms_crtc.c @@ -4,6 +4,7 @@ =20 #include #include +#include #include #include #include @@ -141,14 +142,20 @@ static int vkms_crtc_atomic_check(struct drm_crtc *cr= tc, return -ENOMEM; vkms_state->num_active_planes =3D i; =20 - i =3D 0; + ret =3D drm_atomic_normalize_zpos(crtc->dev, state); + if (ret) + return ret; + drm_for_each_plane_mask(plane, crtc->dev, crtc_state->plane_mask) { plane_state =3D drm_atomic_get_new_plane_state(crtc_state->state, plane); =20 if (!plane_state->visible) continue; =20 - vkms_state->active_planes[i++] =3D + // Order planes according to their normalized_zpos + // After drm_atomic_normalize_zpos, the possible values are 0..n_planes-1 + // so store them using this index + vkms_state->active_planes[plane_state->normalized_zpos] =3D to_vkms_plane_state(plane_state); } =20 --=20 2.51.0