From nobody Fri Dec 19 12:16:45 2025 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFE632DF6E6 for ; Fri, 17 Oct 2025 16:43:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760719386; cv=none; b=p0OWwSJs/nM6RQTdxsVR92Q6LSN6O2oCgXZUPRtISKGSxWZRS6I/zFQIb55yWI1alIbwYJUQUaBG4q4mO/E2FA938sFqddLKbVFbfTrpY/+1xMcf80YI3B+HI1VvTHDS4gyMzvViTEy1LHIPnh2zLT1VLs8eX79U6EZJphsJBwI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760719386; c=relaxed/simple; bh=C+z7sypaWzV70HTwj6KI3rPfmg2IyKDpJvcZ0i7QuuU=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Jwvptq3CHw6PfYKawGMAlUXSzaGJBPQTARlb4DaA9mihL/BnG/M84dVTVpG7uHqTVhn0i2cqxc4Hn56h91FWGVvzlsupsq20lHi7pvxFsSs4eHzff0uU1mpI69MaB/CdeivTp1y8sS554V5w8f+bx52aV00x5neJ32ITtsb/Eek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=SMikJuUq; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="SMikJuUq" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b3d196b7eeeso391992266b.0 for ; Fri, 17 Oct 2025 09:43:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1760719382; x=1761324182; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=YQX98Tf2y0MkdvdIOBqjljpmh/9Imc0tmR+fXFJYM8E=; b=SMikJuUqUItID1Sasvbl8VDEC8epNziP5TS6X+LP8g3banXTQ5UpC0l2rheNJvbkQn t8hSNgJ6lCPlddJBPOsXxSpGC+blYKWld9KevVlUYMdiSgwfyv+W39z/rDVRk61NcyEg aq1QCjhBJJC3pneN8d6N6KnhWXBJe5yop2cwonOnGgg0Nk7IFHxUMn5b6PrsKlolTKl0 kqJHwF+sNj9F5aOxukavEWYlfoVaTKnRKeEW9OCuSiKDZV6PUc6mdzIJqCpbdXZKeUpk ET99TdrLGrWgKO80CyTCBoGnKLmAto9/Z/m4em+ZmkBEsTuiknNcEGN9g7++WUOuiUiy Ms5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760719382; x=1761324182; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YQX98Tf2y0MkdvdIOBqjljpmh/9Imc0tmR+fXFJYM8E=; b=OdzH59LSWOMonKCrfei4vhTDQ23JhLh7y6x/FS3eyqCYu6354JLBOCMTMHe9yRN5Pv bkVGUKQ06sLWB8bZlToM9MpR+CgeWfcyt13oHfx31/XqXBn6W4tXbhouhKuUIyLHon7w M78S5qad+FrSUkMWAXWhRy7Nniid61/YkXN8mPgQQU2KkCMtyC06FBpAa2jb1rN0SRrf m/F5d/My1wkWDWKYiTImuy5LN0alFTMvwIDgCOHctKJ0p/jRbYbavWtf75l8w84wG2tX f2QCJflCwDpnJUBfN35kV4bQcaA4l6tllvuBg3GK7FCsoxTpksFlzJ5xZIgCt+S2+fYU vYgw== X-Forwarded-Encrypted: i=1; AJvYcCWhxZFMZfdX1aybZ2ASJP6t0AxT/o7zLGwScNSpMECxovcAXOIBAVKpm8HHONFsTjsuJJ8o8AmFr/l4p+o=@vger.kernel.org X-Gm-Message-State: AOJu0Yxo/KKhWFfNpozZUrdrvCHumNdBgRgjENzh0TroV2rw7TGCoQsw SocXq8e4TGwD0iyE/n9jRlO9HXRxN5OW9wO5oLWbF6DVdfZEhH+gwAGyCxsszVpmRUI= X-Gm-Gg: ASbGncuqORWhCaxX12GYSW0T7ltUvn12g6bDv0RLVDa7J2+UEpjHU+e71ovlxiDJNgm ujryNZhpgdKBtR61JpavtNV1idbBa036Xqaz3e0OPTyqzarrCHoGIAzq//IntfO2CMYmCtVtjGX k9ISnjm4khVRODmoLG/ih09lhvtZQ/ztuQck/WmV/JDYYnj7o4YtQIq6mHmPJDa4I4C8rRKU+Lh ZZjcEzohLI2sQpdX0B1K0cPrJU/OaE8Eno6q329b/iZOaDoauypLeXiTBYgXYNBloKqC4RQa2RM c4PRXeDQ5CGCkTyus55nybwr7HQgvfk6tLn18fgO9irZMYLADKtKbEufekImX+O2Y+XSyONYwj0 2bUiBSHU9DAR5eDmMYcG8YgXybCB6eKcE0vOvwbz3Mgvc6CmEO6NzlPhjiYWmcGdXBzRDAGhIW8 1UQcQpy6oBakp+a0ePoxHToyEoWKxwh6wi09eJ X-Google-Smtp-Source: AGHT+IHcSVLRPmaNpo/l1hcAlmozuaLO9Zw2xYWDm+QeXDkQRKPSWUG23uhTVPllrDvezkmyiTTUAg== X-Received: by 2002:a17:907:2686:b0:b42:1324:7986 with SMTP id a640c23a62f3a-b647254f3afmr440216166b.6.1760719381757; Fri, 17 Oct 2025 09:43:01 -0700 (PDT) Received: from localhost (mob-176-247-36-41.net.vodafone.it. [176.247.36.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b65ebc4d552sm13771266b.80.2025.10.17.09.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 09:43:00 -0700 (PDT) From: Francesco Lavra To: Lorenzo Bianconi , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/2] iio: imu: st_lsm6dsx: Decouple sensor ODR from FIFO batch data rate Date: Fri, 17 Oct 2025 18:42:55 +0200 Message-Id: <20251017164255.1251060-3-flavra@baylibre.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20251017164255.1251060-1-flavra@baylibre.com> References: <20251017164255.1251060-1-flavra@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=8633; i=flavra@baylibre.com; h=from:subject; bh=C+z7sypaWzV70HTwj6KI3rPfmg2IyKDpJvcZ0i7QuuU=; b=owEB7QES/pANAwAKAe3xO3POlDZfAcsmYgBo8nH/QAuLBrSbvOQSUJF7FwtMAsMXUmk/rp4ED dXaLhqPd9uJAbMEAAEKAB0WIQSGV4VPlTvcox7DFObt8TtzzpQ2XwUCaPJx/wAKCRDt8TtzzpQ2 X0dmDACNrQbNuPJ2vhlv/H3Ai6EBxNnucTmSJSU4f+Ax0CLgl61xZHuUIFh1sWq/g+SWCkeRYq+ R5pFfCh9wVLq7Lu/gBMz1vDELQMMG1ZSmZpffuDskOYHXNQYYCfjbXYAp0ekUqIZVQnRZ/xqmVw jo3T4NJc/BNQ4Eyc/AFxIUrqn8ApDRHoZMgBEJjO8DPOeDF4xAqECGQWdPyB6+j7Cq/2KHT29r+ cdiTsmGli2LbwOI7X6mQw682whQa6J8gEqhhFcOa7jSGmEYEbYBFXSqrOgA9Uar/3K8uYX7fx3+ cS8Xio225shc7y+ocvmO2/yAW+1HDAr8kp5LgUXhm7/1voGymMzpfXuUj/ZMi6N/FUNGTAWV6v/ WhFTSQkXaLnyTu9S8Smt38plUiO/9nD9EE4EQViWZKinnpzKo7lH7aC8vldboe+lq0fL2CrztDG CrV4KWYKJCqXVY+bpgiukFrKEWi+7hiAK9JtQqjGJ5J3eIXa3WM1+/zK3E6IhK2/dR9wg= X-Developer-Key: i=flavra@baylibre.com; a=openpgp; fpr=8657854F953BDCA31EC314E6EDF13B73CE94365F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The rate at which accelerometer or gyroscope sensor samples are fed to the hardware FIFO (batch data rate, or BDR) does not have to coincide with the sensor sampling frequency (output data rate, or ODR); the only requirement is for the BDR to not be greater than the ODR. Having a BDR lower than the ODR is useful in cases where an application requires a high sampling rate for accurate detection of motion events (e.g. wakeup events), but wants to read sensor sample values from the hardware FIFO at a lower data rate (e.g. to minimize the amount of I2C or SPI traffic and the rate of periodic interrupts). To support the above use case, add a sampling_frequency sysfs attribute to the buffer directory of st_lsm6dsx IIO devices, which controls the BDR for a given sensor independently from the "main" sampling_frequency attribute (which controls the ODR); introduce a new `hwfifo_odr_mHz` field in struct st_lsm6dsx_sensor to keep track of the current BDR value, and use this field instead of the `odr` field in the code that deals with the FIFO data rate. In the sensor hub driver, make the hwfifo_odr_mHz value always mirror the odr value, since there is no separate configuration setting to control the BDR for data produced by the sensor hub functionality. For backwards compatibility, set the buffer frequency equal to the main frequency whenever the latter is updated via sysfs; if userspace wants a different buffer frequency, it has to write to the relevant sysfs attribute after any writes to the main frequency attribute. Signed-off-by: Francesco Lavra Acked-by: Lorenzo Bianconi --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h | 2 + .../iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c | 71 ++++++++++++++++--- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 7 +- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c | 2 + 4 files changed, 72 insertions(+), 10 deletions(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_l= sm6dsx/st_lsm6dsx.h index bd366c6e282a..3cd520bdec46 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h @@ -366,6 +366,7 @@ enum st_lsm6dsx_fifo_mode { * @hw: Pointer to instance of struct st_lsm6dsx_hw. * @gain: Configured sensor sensitivity. * @odr: Output data rate of the sensor [mHz]. + * hwfifo_odr_mHz: Batch data rate for hardware FIFO [mHz] * @samples_to_discard: Number of samples to discard for filters settling = time. * @watermark: Sensor watermark level. * @decimator: Sensor decimation factor. @@ -380,6 +381,7 @@ struct st_lsm6dsx_sensor { =20 u32 gain; u32 odr; + u32 hwfifo_odr_mHz; =20 u16 samples_to_discard; u16 watermark; diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c b/drivers/iio/i= mu/st_lsm6dsx/st_lsm6dsx_buffer.c index 8a9d2593576a..55d877745575 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c @@ -56,6 +56,7 @@ #include #include #include +#include #include #include =20 @@ -105,7 +106,7 @@ static int st_lsm6dsx_get_decimator_val(struct st_lsm6dsx_sensor *sensor, u32 max_odr) { const int max_size =3D ARRAY_SIZE(st_lsm6dsx_decimator_table); - u32 decimator =3D max_odr / sensor->odr; + u32 decimator =3D max_odr / sensor->hwfifo_odr_mHz; int i; =20 if (decimator > 1) @@ -136,14 +137,14 @@ static void st_lsm6dsx_get_max_min_odr(struct st_lsm6= dsx_hw *hw, if (!(hw->enable_mask & BIT(sensor->id))) continue; =20 - *max_odr =3D max_t(u32, *max_odr, sensor->odr); - *min_odr =3D min_t(u32, *min_odr, sensor->odr); + *max_odr =3D max(*max_odr, sensor->hwfifo_odr_mHz); + *min_odr =3D min(*min_odr, sensor->hwfifo_odr_mHz); } } =20 static u8 st_lsm6dsx_get_sip(struct st_lsm6dsx_sensor *sensor, u32 min_odr) { - u8 sip =3D sensor->odr / min_odr; + u8 sip =3D sensor->hwfifo_odr_mHz / min_odr; =20 return sip > 1 ? round_down(sip, 2) : sip; } @@ -231,7 +232,7 @@ static int st_lsm6dsx_set_fifo_odr(struct st_lsm6dsx_se= nsor *sensor, if (enable) { int err; =20 - err =3D st_lsm6dsx_check_odr(sensor, sensor->odr, + err =3D st_lsm6dsx_check_odr(sensor, sensor->hwfifo_odr_mHz, &data); if (err < 0) return err; @@ -713,7 +714,7 @@ st_lsm6dsx_update_samples_to_discard(struct st_lsm6dsx_= sensor *sensor) =20 data =3D &hw->settings->samples_to_discard[sensor->id]; for (i =3D 0; i < ST_LSM6DSX_ODR_LIST_SIZE; i++) { - if (data->val[i].milli_hz =3D=3D sensor->odr) { + if (data->val[i].milli_hz =3D=3D sensor->hwfifo_odr_mHz) { sensor->samples_to_discard =3D data->val[i].samples; return; } @@ -799,6 +800,59 @@ static const struct iio_buffer_setup_ops st_lsm6dsx_bu= ffer_ops =3D { .postdisable =3D st_lsm6dsx_buffer_postdisable, }; =20 +static ssize_t st_lsm6dsx_hwfifo_odr_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct st_lsm6dsx_sensor *sensor =3D iio_priv(dev_to_iio_dev(dev)); + + return sysfs_emit(buf, "%d.%03d\n", sensor->hwfifo_odr_mHz / 1000, + sensor->hwfifo_odr_mHz % 1000); +} + +static ssize_t st_lsm6dsx_hwfifo_odr_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t len) +{ + struct iio_dev *iio_dev =3D dev_to_iio_dev(dev); + struct st_lsm6dsx_sensor *sensor =3D iio_priv(iio_dev); + int integer, milli; + int ret; + u32 hwfifo_odr; + u8 data; + + if (!iio_device_claim_direct(iio_dev)) + return -EBUSY; + + ret =3D iio_str_to_fixpoint(buf, 100, &integer, &milli); + if (ret) + goto out; + + hwfifo_odr =3D integer * 1000 + milli; + ret =3D st_lsm6dsx_check_odr(sensor, hwfifo_odr, &data); + if (ret < 0) + goto out; + + hwfifo_odr =3D ret; + + /* the batch data rate must not exceed the sensor output data rate */ + if (hwfifo_odr <=3D sensor->odr) + sensor->hwfifo_odr_mHz =3D hwfifo_odr; + else + ret =3D -EINVAL; + +out: + iio_device_release_direct(iio_dev); + + return ret < 0 ? ret : len; +} + +static IIO_DEV_ATTR_SAMP_FREQ(0664, st_lsm6dsx_hwfifo_odr_show, st_lsm6dsx= _hwfifo_odr_store); + +static const struct iio_dev_attr *st_lsm6dsx_buffer_attrs[] =3D { + &iio_dev_attr_sampling_frequency, + NULL +}; + int st_lsm6dsx_fifo_setup(struct st_lsm6dsx_hw *hw) { int i, ret; @@ -807,8 +861,9 @@ int st_lsm6dsx_fifo_setup(struct st_lsm6dsx_hw *hw) if (!hw->iio_devs[i]) continue; =20 - ret =3D devm_iio_kfifo_buffer_setup(hw->dev, hw->iio_devs[i], - &st_lsm6dsx_buffer_ops); + ret =3D devm_iio_kfifo_buffer_setup_ext(hw->dev, hw->iio_devs[i], + &st_lsm6dsx_buffer_ops, + st_lsm6dsx_buffer_attrs); if (ret) return ret; } diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu= /st_lsm6dsx/st_lsm6dsx_core.c index c65ad49829e7..216160549b5a 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c @@ -1847,10 +1847,12 @@ static int st_lsm6dsx_write_raw(struct iio_dev *iio= _dev, =20 val =3D val * 1000 + val2 / 1000; val =3D st_lsm6dsx_check_odr(sensor, val, &data); - if (val < 0) + if (val < 0) { err =3D val; - else + } else { sensor->odr =3D val; + sensor->hwfifo_odr_mHz =3D val; + } break; } default: @@ -2384,6 +2386,7 @@ static struct iio_dev *st_lsm6dsx_alloc_iiodev(struct= st_lsm6dsx_hw *hw, sensor->id =3D id; sensor->hw =3D hw; sensor->odr =3D hw->settings->odr_table[id].odr_avl[0].milli_hz; + sensor->hwfifo_odr_mHz =3D sensor->odr; sensor->gain =3D hw->settings->fs_table[id].fs_avl[0].gain; sensor->watermark =3D 1; =20 diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c b/drivers/iio/imu= /st_lsm6dsx/st_lsm6dsx_shub.c index 3c5e65dc0f97..d6a1eeb151ca 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c @@ -640,6 +640,7 @@ __st_lsm6dsx_shub_write_raw(struct iio_dev *iio_dev, =20 sensor->ext_info.slv_odr =3D val; sensor->odr =3D odr; + sensor->hwfifo_odr_mHz =3D odr; return 0; } case IIO_CHAN_INFO_SCALE: @@ -746,6 +747,7 @@ st_lsm6dsx_shub_alloc_iiodev(struct st_lsm6dsx_hw *hw, sensor->id =3D id; sensor->hw =3D hw; sensor->odr =3D hw->settings->odr_table[ref_id].odr_avl[0].milli_hz; + sensor->hwfifo_odr_mHz =3D sensor->odr; sensor->ext_info.slv_odr =3D info->odr_table.odr_avl[0].milli_hz; sensor->gain =3D info->fs_table.fs_avl[0].gain; sensor->ext_info.settings =3D info; --=20 2.39.5