From nobody Mon Feb 9 02:12:52 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0ADC33033E; Fri, 17 Oct 2025 13:35:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760708146; cv=none; b=D1E6Vq4HLkWm8Jj7f6cfSWGqCebPudooIujLVExliluH4IC2J06LhCAvrjwAaUJW/uvRC6QJ2TbYSlEaEZOLZjXmcbgf850MC11+rh7soHWd5GvodkmGrihsc2O0GqR4LseqfHl5WD8URhtU+A5Lq1StGITXvEQdeUjWtGNXwPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760708146; c=relaxed/simple; bh=6cWsfVK2uywEugF7lxsG4Yh9ydRfGMntJrHORzhDVkE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m9ECZOoIaA/5j50M5G58tNn21NByqboWCH7VfPZ2Mg5Gk0zyX5kqYOlEqcDUWL9R0FhQVhJCRx1i9DP9fnGdr3UKdxlW3WNa0oLtBtpstNJwX8tcY23KGXsNWWwJxfcWrPh36Hbi4cpYZnqEzV1Eupdf7RCVRJRIj02XdEk1QaM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WzAim2Ft; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WzAim2Ft" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1760708144; x=1792244144; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6cWsfVK2uywEugF7lxsG4Yh9ydRfGMntJrHORzhDVkE=; b=WzAim2FtNaK35efn8dhpJJP5Y84aGIm5BoHU/qwmF7ewIiAzJCE7bSAK HXtJunTOs+qQj6ciZYLZwV9vf3efzdG2KhU0698aTxyEkpjNUq/Wp/TOo hr0Nw86998s2k6Q3waJklW/eIfzSRmosh3BFOsY4ErirOTnhzUDtVE7mT DkY/woI5P4l5DLO8jngxZcet0A94bsKCXThlf6182P7dmyuDGEEf9/gKX FmXNAr1JfBYXsa5R+r3lzDORr1JcKiKG7lYlN9eENQyRERblnXoSMBd9O 2BKXslX+ytDQx4J7Eps7SiM0Mc9zAb1YxOJbWWnrCfTFkMi9dZIy96rJ7 A==; X-CSE-ConnectionGUID: IqKjX1TWQYuRN+7JDWKy0Q== X-CSE-MsgGUID: WjNz5PaSQR2pcgQxwGderw== X-IronPort-AV: E=McAfee;i="6800,10657,11585"; a="63065069" X-IronPort-AV: E=Sophos;i="6.19,236,1754982000"; d="scan'208";a="63065069" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2025 06:35:27 -0700 X-CSE-ConnectionGUID: gKeP+cXbT6ax9cP8SQcYig== X-CSE-MsgGUID: H6mglz3GRx+7F8DG4fPbXw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,236,1754982000"; d="scan'208";a="181925286" Received: from fdefranc-mobl3.ger.corp.intel.com (HELO fdefranc-mobl3.intel.com) ([10.245.246.215]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2025 06:35:14 -0700 From: "Fabio M. De Francesco" To: linux-cxl@vger.kernel.org Cc: "Rafael J . Wysocki" , Len Brown , Tony Luck , Borislav Petkov , Hanjun Guo , Mauro Carvalho Chehab , Shuai Xue , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Mahesh J Salgaonkar , Oliver O'Halloran , Bjorn Helgaas , Sunil V L , Xiaofei Tan , Mario Limonciello , Huacai Chen , Heinrich Schuchardt , Arnd Bergmann , "Fabio M . De Francesco" , Peter Zijlstra , Ingo Molnar , Guo Weikang , Xin Li , Will Deacon , Huang Yiwei , Gavin Shan , Smita Koralahalli , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Li Ming , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Kuppuswamy Sathyanarayanan , Karolina Stolarek , Jon Pan-Doh , Lukas Wunner , Shiju Jose , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org Subject: [PATCH 5/6 v5] acpi/ghes: Add helper to copy CXL protocol error info to work struct Date: Fri, 17 Oct 2025 15:30:50 +0200 Message-ID: <20251017133357.1150982-6-fabio.m.de.francesco@linux.intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251017133357.1150982-1-fabio.m.de.francesco@linux.intel.com> References: <20251017133357.1150982-1-fabio.m.de.francesco@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make a helper out of cxl_cper_post_prot_err() that checks the CXL agent type and copy the CPER CXL protocol errors information to a work data structure. Signed-off-by: Fabio M. De Francesco --- drivers/acpi/apei/ghes.c | 42 ++++++++++++++++++++++++++-------------- include/cxl/event.h | 10 ++++++++++ 2 files changed, 37 insertions(+), 15 deletions(-) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index e69ae864f43d3..e0f8b8ed2b7c4 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -734,20 +734,12 @@ int cxl_cper_sec_prot_err_valid(struct cxl_cper_sec_p= rot_err *prot_err) } EXPORT_SYMBOL_GPL(cxl_cper_sec_prot_err_valid); =20 -static void cxl_cper_post_prot_err(struct cxl_cper_sec_prot_err *prot_err, - int severity) +int cxl_cper_sec_prot_err_copy_to_wd(struct cxl_cper_prot_err_work_data *w= d, + struct cxl_cper_sec_prot_err *prot_err, + int severity) { - struct cxl_cper_prot_err_work_data wd; u8 *dvsec_start, *cap_start; =20 - if (cxl_cper_sec_prot_err_valid(prot_err)) - return; - - guard(spinlock_irqsave)(&cxl_cper_prot_err_work_lock); - - if (!cxl_cper_prot_err_work) - return; - switch (prot_err->agent_type) { case RCD: case DEVICE: @@ -756,20 +748,40 @@ static void cxl_cper_post_prot_err(struct cxl_cper_se= c_prot_err *prot_err, case RP: case DSP: case USP: - memcpy(&wd.prot_err, prot_err, sizeof(wd.prot_err)); + memcpy(wd->prot_err, prot_err, sizeof(wd->prot_err)); =20 dvsec_start =3D (u8 *)(prot_err + 1); cap_start =3D dvsec_start + prot_err->dvsec_len; =20 - memcpy(&wd.ras_cap, cap_start, sizeof(wd.ras_cap)); - wd.severity =3D cper_severity_to_aer(severity); + memcpy(wd->ras_cap, cap_start, sizeof(wd->ras_cap)); + wd->severity =3D cper_severity_to_aer(severity); break; default: pr_err_ratelimited("CXL CPER invalid agent type: %d\n", prot_err->agent_type); - return; + return -EINVAL; } =20 + return 0; +} +EXPORT_SYMBOL_GPL(cxl_cper_sec_prot_err_copy_to_wd); + +static void cxl_cper_post_prot_err(struct cxl_cper_sec_prot_err *prot_err, + int severity) +{ + struct cxl_cper_prot_err_work_data wd; + + if (cxl_cper_sec_prot_err_valid(prot_err)) + return; + + guard(spinlock_irqsave)(&cxl_cper_prot_err_work_lock); + + if (!cxl_cper_prot_err_work) + return; + + if (cxl_cper_sec_prot_err_copy_to_wd(&wd, prot_err, severity)) + return; + if (!kfifo_put(&cxl_cper_prot_err_fifo, wd)) { pr_err_ratelimited("CXL CPER kfifo overflow\n"); return; diff --git a/include/cxl/event.h b/include/cxl/event.h index e1deb66c2197e..5f06cea5d6005 100644 --- a/include/cxl/event.h +++ b/include/cxl/event.h @@ -322,12 +322,22 @@ static inline int cxl_cper_prot_err_kfifo_get(struct = cxl_cper_prot_err_work_data =20 #ifdef CONFIG_ACPI_APEI_PCIEAER int cxl_cper_sec_prot_err_valid(struct cxl_cper_sec_prot_err *prot_err); +int cxl_cper_sec_prot_err_copy_to_wd(struct cxl_cper_prot_err_work_data *w= d, + struct cxl_cper_sec_prot_err *prot_err, + int severity); #else static inline int cxl_cper_sec_prot_err_valid(struct cxl_cper_sec_prot_err *prot_err) { return -EINVAL; } +static inline int +cxl_cper_sec_prot_err_copy_to_wd(struct cxl_cper_prot_err_work_data *wd, + struct cxl_cper_sec_prot_err *prot_err, + int severity) +{ + return -EINVAL; +} #endif =20 #endif /* _LINUX_CXL_EVENT_H */ --=20 2.51.0