From nobody Sun Feb 8 08:42:46 2026 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A66C73176F4 for ; Fri, 17 Oct 2025 10:47:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.189 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760698037; cv=none; b=EJi3H/J4aiJS4bxfZ4mK120pcjFFE198YwJr+xUlwTF2kKsninebGaqAoEdS77/sQV3qS/CALPWPTakbUGdtu/X2z0303maSDDyS70/uibPxM4ow36/55qTxEmtqUpRFSzq+4BLhHv/F40dRAdJcjm2gDf1CgaLfGFDFSDrC70U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760698037; c=relaxed/simple; bh=tcIlwaOGiNZtpJGtvN/32z9akCHze0ufgBSqOsGlyNw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e/GiXv4vrLK4unBXkpqPMG2Du7tBwijWv4BtrM6tZi3gkPECMvZ2nx37qa9Tgy7LQ9OG6ZGVvpT/F6USNGmmVICWdhKCCIk9nxzJL70igU3z9lf/4svZ+S11UgoZIMptCZwe39Kjyku26pcu5HB5NojUhE1PUjvQhcYUlCiP8qc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=he+zXtp8; arc=none smtp.client-ip=95.215.58.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="he+zXtp8" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760698033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=swp3WkGBp1peL2t9zaCuTnxbSeRuSFHx09RPC0A1m2Y=; b=he+zXtp89BkoXlXIn1zzrwryf7POQ+WWRDzNQXuwePyaELTh939bOJNNU1K5qG3vPP7eBc Bc3XoHDMTmb5Ac4kVunNXNFAaYpf43ZEAHOXBvNn6kbTg7fDyBzH5S0IRGpPMm1vliUEJB WFq7+Vr2pl1ZGKWIDk7hBZMSLb6B7+s= From: chenxiaosong.chenxiaosong@linux.dev To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org, linkinjeon@samba.org Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, ChenXiaoSong Subject: [PATCH v2 1/6] smb/server: fix return value of smb2_read() Date: Fri, 17 Oct 2025 18:46:07 +0800 Message-ID: <20251017104613.3094031-2-chenxiaosong.chenxiaosong@linux.dev> In-Reply-To: <20251017104613.3094031-1-chenxiaosong.chenxiaosong@linux.dev> References: <20251017104613.3094031-1-chenxiaosong.chenxiaosong@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: ChenXiaoSong STATUS_END_OF_FILE maps to the linux error -ENODATA. Perhaps in the future we can move client/smb2maperror.c into common/ and then call map_smb2_to_linux_error() to get the linux error. Signed-off-by: ChenXiaoSong --- fs/smb/server/smb2pdu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index f901ae18e68a..f80a3dbb2d4e 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -6842,7 +6842,7 @@ int smb2_read(struct ksmbd_work *work) rsp->hdr.Status =3D STATUS_END_OF_FILE; smb2_set_err_rsp(work); ksmbd_fd_put(work, fp); - return 0; + return -ENODATA; } =20 ksmbd_debug(SMB, "nbytes %zu, offset %lld mincount %zu\n", --=20 2.43.0 From nobody Sun Feb 8 08:42:46 2026 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C90443176EF for ; Fri, 17 Oct 2025 10:47:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760698039; cv=none; b=fJnG5JnlBPWLUgqVnxi4HZZEcUiq2H+qe736keuYWnmorIj46IKWGd1k3XXU6izJYPe961aZYJDSGl2K7UzZ9C9Xq7/uD5M0hpLA8SWl1xh5Dwil7z9q3cDnYo4SpRwoLENVlJgKr59NZTcffKCU+2Uu9Pu8F5lfqAOhD8s3jIw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760698039; c=relaxed/simple; bh=SsjGT9r6HTcpAf+hm/ib3M0giSRUy6czGOiO/GTMoEI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cy5WbdI9ZTCi0bZXJO/iPsheReDdkVXNwVMZ8ujFWcaAjq1LwnWbG5h+0L8XwpbP5rERDjpVoVz+i7sgTTWbiChfUTzbzXMa6seBHZfS/Y0MwnFFjXpxirdSb66Zt/1gR2agaXXLCEmHuEgicJG+1+zHgxSEFuel09LxftwNVIc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=o88TdpTN; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="o88TdpTN" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760698036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LZYpSan4Xtg7ipurLAFtn4+9Ilq4Ux2WxUZkDOjKwiw=; b=o88TdpTN4hfthhPIvkcfwedosu8vdQLJKse3L54R5aKjmm/TCC+BxMA8s/VTFThpJ6nIxD LV4X/Q6P5FIAVwhYjsU2mma82X6fSsWJGnUMJupc9D2qJYx5rD/Jx7MDu7CUel77lZK3XM 5syoOZyZh0SzzeSJEfn9Wp7DKrdkZ+g= From: chenxiaosong.chenxiaosong@linux.dev To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org, linkinjeon@samba.org Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, ChenXiaoSong Subject: [PATCH v2 2/6] smb/server: fix return value of smb2_notify() Date: Fri, 17 Oct 2025 18:46:08 +0800 Message-ID: <20251017104613.3094031-3-chenxiaosong.chenxiaosong@linux.dev> In-Reply-To: <20251017104613.3094031-1-chenxiaosong.chenxiaosong@linux.dev> References: <20251017104613.3094031-1-chenxiaosong.chenxiaosong@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: ChenXiaoSong smb2_notify() should return error code when an error occurs, __process_request() will print the error messages. I may implement the SMB2 CHANGE_NOTIFY response (see MS-SMB2 2.2.36) in the future. Signed-off-by: ChenXiaoSong --- fs/smb/server/smb2pdu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index f80a3dbb2d4e..5b5f25a2eb8a 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -8787,7 +8787,7 @@ int smb2_oplock_break(struct ksmbd_work *work) * smb2_notify() - handler for smb2 notify request * @work: smb work containing notify command buffer * - * Return: 0 + * Return: 0 on success, otherwise error */ int smb2_notify(struct ksmbd_work *work) { @@ -8801,12 +8801,12 @@ int smb2_notify(struct ksmbd_work *work) if (work->next_smb2_rcv_hdr_off && req->hdr.NextCommand) { rsp->hdr.Status =3D STATUS_INTERNAL_ERROR; smb2_set_err_rsp(work); - return 0; + return -EIO; } =20 smb2_set_err_rsp(work); rsp->hdr.Status =3D STATUS_NOT_IMPLEMENTED; - return 0; + return -EOPNOTSUPP; } =20 /** --=20 2.43.0 From nobody Sun Feb 8 08:42:46 2026 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08438319617 for ; Fri, 17 Oct 2025 10:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760698041; cv=none; b=WT+RoF5am6yjYL/FiFtcd2vtRt6598ye72x5MSSrLcbVUeBoX9Si17ubBE4NCxiQWJYxnMegz8mxeSkCpry+1itsMGO+4IYLOYcONkFyWKbV6fNnaH8fSu3yBJDF5bfDWhBGHNNES9MH1HdpDBSnb3jmE/Rl2utGryxVWd18Olw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760698041; c=relaxed/simple; bh=VqJHVOFZ5DJNwWqt0hUqYv/FSyzj6l3KwrSTbGbdmVw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TSIdoaULfelD61uV9hMSTT8fWGf6n2Ap1xrLKf+UOMsXrjf4Y767np7rwJJxiIauWgF9fYS5UYOnvslQngioor2cG5K3htSuzaJHsS+ESMK93yVnMq7jpV9mPnvlvQyTbR2Ap0mqF/dqxND8jFcdH+AD4p3MakfB+nUA7LsGu2k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ZOMJ6MMv; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ZOMJ6MMv" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760698038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X5EtpvT+zBTCFB3awZnIjhy/RC7yn8lCbwKpgPvLVjg=; b=ZOMJ6MMvGMXc6k1+8GQSSCLZ9aA4IVXq3IWIljq9BWs9J0VwP4/JKtYsspzYjtyG3NoPH8 77ed11ZBruo1wappBJKpXoDfiKaucI8oI0Kg5BHwIPYphwbuvNLtP59nb1wPpxX8uENwM8 eWovRUSy5MzlEWErStaLbKkSjFJTgeE= From: chenxiaosong.chenxiaosong@linux.dev To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org, linkinjeon@samba.org Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, ChenXiaoSong Subject: [PATCH v2 3/6] smb/server: fix return value of smb2_query_dir() Date: Fri, 17 Oct 2025 18:46:09 +0800 Message-ID: <20251017104613.3094031-4-chenxiaosong.chenxiaosong@linux.dev> In-Reply-To: <20251017104613.3094031-1-chenxiaosong.chenxiaosong@linux.dev> References: <20251017104613.3094031-1-chenxiaosong.chenxiaosong@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: ChenXiaoSong __process_request() will not print error messages if smb2_query_dir() always returns 0. Fix this by returning the correct value at the end of function. Signed-off-by: ChenXiaoSong --- fs/smb/server/smb2pdu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 5b5f25a2eb8a..ff264249f405 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -4560,7 +4560,7 @@ int smb2_query_dir(struct ksmbd_work *work) smb2_set_err_rsp(work); ksmbd_fd_put(work, dir_fp); ksmbd_revert_fsids(work); - return 0; + return rc; } =20 /** --=20 2.43.0 From nobody Sun Feb 8 08:42:46 2026 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AAAF3195FC for ; Fri, 17 Oct 2025 10:47:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760698043; cv=none; b=oMThyfD9gGxhOLK2oAVgZxMh9qdwiq+K/vPWkTdIq7ouw6NYWxYM1UNBejweC1g+e5FH3VKYb2+vAzNrJqthI7r0XUT/7l1Yi6S0XGBg21Zx9Ymb9vI+yA65sXtQiYuryKz3oXyofmXYGS5dTs09UUfB2WGK6YQ5iKaaqLvND0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760698043; c=relaxed/simple; bh=q+0zsdyq5lrbkvcHsrd8oeUeJalcLNU3Uz1DgUyInxU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CVPBAFJD+Cigd3PVTbhtc8BPjey8huBISqTq81XsnJ6PpOdfP5ocM4WxG7emwQlDs5smAQQPGbAnTIa3wsGZIN61ITz71ZOpooayKxsG5/WNmdcHNUluoShtOXuRSd8Elhmfq1MVEasP5mwdSD3FtCzgRZg1krcS/HSIQKOMAH4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=sFONZgnU; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="sFONZgnU" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760698040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=etMM8r9NXRpmxE2GxxUG1NPFqiTlE+SOElV3r/BrVvE=; b=sFONZgnUcY4dQ48cVW+siAb4UkCv9creoNYlr1vRvF4t9eIQBeiBfGwUniiizk5wNUNrgD eOQV4W1/mi8mp/hFsAyIRGZRuCxtNCEM0ns+DzqR5Fb7ihViXXAcEXS56dO36vN3BplBK6 TmGfriv5noAvOBg9DuFUXQ3o7m2gBuI= From: chenxiaosong.chenxiaosong@linux.dev To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org, linkinjeon@samba.org Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, ChenXiaoSong Subject: [PATCH v2 4/6] smb/server: fix return value of smb2_ioctl() Date: Fri, 17 Oct 2025 18:46:10 +0800 Message-ID: <20251017104613.3094031-5-chenxiaosong.chenxiaosong@linux.dev> In-Reply-To: <20251017104613.3094031-1-chenxiaosong.chenxiaosong@linux.dev> References: <20251017104613.3094031-1-chenxiaosong.chenxiaosong@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: ChenXiaoSong __process_request() will not print error messages if smb2_ioctl() always returns 0. Fix this by returning the correct value at the end of function. Signed-off-by: ChenXiaoSong --- fs/smb/server/smb2pdu.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index ff264249f405..efd545882ba8 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -8164,7 +8164,7 @@ int smb2_ioctl(struct ksmbd_work *work) id =3D req->VolatileFileId; =20 if (req->Flags !=3D cpu_to_le32(SMB2_0_IOCTL_IS_FSCTL)) { - rsp->hdr.Status =3D STATUS_NOT_SUPPORTED; + ret =3D -EOPNOTSUPP; goto out; } =20 @@ -8184,8 +8184,9 @@ int smb2_ioctl(struct ksmbd_work *work) case FSCTL_DFS_GET_REFERRALS: case FSCTL_DFS_GET_REFERRALS_EX: /* Not support DFS yet */ + ret =3D -EOPNOTSUPP; rsp->hdr.Status =3D STATUS_FS_DRIVER_REQUIRED; - goto out; + goto out2; case FSCTL_CREATE_OR_GET_OBJECT_ID: { struct file_object_buf_type1_ioctl_rsp *obj_buf; @@ -8475,8 +8476,10 @@ int smb2_ioctl(struct ksmbd_work *work) rsp->hdr.Status =3D STATUS_BUFFER_TOO_SMALL; else if (ret < 0 || rsp->hdr.Status =3D=3D 0) rsp->hdr.Status =3D STATUS_INVALID_PARAMETER; + +out2: smb2_set_err_rsp(work); - return 0; + return ret; } =20 /** --=20 2.43.0 From nobody Sun Feb 8 08:42:46 2026 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 663A631AF16 for ; Fri, 17 Oct 2025 10:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760698046; cv=none; b=cRX5QYN8jmp0mkuWm3cqAx6Uxqm7M76/vEb/g/RT3ueYcfaNVJFpT7ClPVUkuNPQRi9WN5HHbe7iVOTwZ6VImOl9FSE0ElEaHmF9rikJo1QWrRifQOBZNsRRLIRUrlyMp3PjbU7P/sgwfJH+2L9/eZZpb5WqAP18uWVJxUTv234= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760698046; c=relaxed/simple; bh=Gh3YgjFcDXtZ7SA8UhKIu3nNpGj/2pFyEh11+vMOhLY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pMwhEkdZVcoGtfL4mQo5jqUdzwz0qyNeyJGhJQpCY/CiLbpmM/3cfLSy/+gSUqFlMXx4BuGNU22a0fcQMIzDsRB/Kyp7etgZDHsTjxblFStA2I3s0FBoot2+4jAfybw6/HHTC0VBUCU53aMTu81D8ewx+ed1oQugpVkwDPLdYT4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Xs3rWhk4; arc=none smtp.client-ip=95.215.58.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Xs3rWhk4" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760698042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vrudYtd8ywS576Vt//9nP99kCLAQAPdrXe41FpuXVI8=; b=Xs3rWhk4iacmLshPgx0szQBRfAnxQ0DTT80q9Ur28OuNXlCtSCg0H6ZbKtajHUcmMNPZIC Ntq/5f9YtNO+0mdwAuedB9DIf5mCLERvB0NptHnvUPg5yBam4ILt/ShqRiWbRVk+8nwcVJ 9G+qGaK537XDaUf9SDienhwB7j1wskw= From: chenxiaosong.chenxiaosong@linux.dev To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org, linkinjeon@samba.org Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, ChenXiaoSong Subject: [PATCH v2 5/6] smb/server: fix return value of smb2_oplock_break() Date: Fri, 17 Oct 2025 18:46:11 +0800 Message-ID: <20251017104613.3094031-6-chenxiaosong.chenxiaosong@linux.dev> In-Reply-To: <20251017104613.3094031-1-chenxiaosong.chenxiaosong@linux.dev> References: <20251017104613.3094031-1-chenxiaosong.chenxiaosong@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: ChenXiaoSong smb2_oplock_break() should return error code when an error occurs, __process_request() will print the error messages. Signed-off-by: ChenXiaoSong --- fs/smb/server/smb2pdu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index efd545882ba8..06e4c21ad4a8 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -8758,7 +8758,7 @@ static void smb21_lease_break_ack(struct ksmbd_work *= work) * smb2_oplock_break() - dispatcher for smb2.0 and 2.1 oplock/lease break * @work: smb work containing oplock/lease break command buffer * - * Return: 0 + * Return: 0 on success, otherwise error */ int smb2_oplock_break(struct ksmbd_work *work) { @@ -8781,6 +8781,7 @@ int smb2_oplock_break(struct ksmbd_work *work) le16_to_cpu(req->StructureSize)); rsp->hdr.Status =3D STATUS_INVALID_PARAMETER; smb2_set_err_rsp(work); + return -EINVAL; } =20 return 0; --=20 2.43.0 From nobody Sun Feb 8 08:42:46 2026 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7976A31CA4C for ; Fri, 17 Oct 2025 10:47:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760698048; cv=none; b=KsPDo7l3CH6+vgzmHFj62dcGYINC5xuGiGb0utpoQ8dWXyGNwN+U2Mooe4d6qtN7wdwQk5NpvLkEXJ2zfXN4xyFoFVIUWbioN9MN1U4CedI7+jxGpng2V8/kOcYaryyNOkpdSjuyalob69ACBskfOGnm040lt8HqIj8ANmtbVhM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760698048; c=relaxed/simple; bh=nZUS6gfRCnWHR2PlTcF00h3XbFItns9vJu+Zy2lv5S4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FkhhDMHqpMg9dJQJcQwXFrFTc8wDIbnd2sDNtpOITSedksVTGpNPnr8ilPU0KCJTWK8b8zoalXWbYPz9w8R9HqUzjZV36yfu+WTl5ql+LFz1nhYjPQGEDxq8h3tgEKchLER4pMSOpRVempVHNhNjhSgALB3oVoLUVIp0qHYZfEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=v8KMjGQh; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="v8KMjGQh" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760698044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y5efMjCW0y1u13VzQpJkPhSCCtNBBW6zz612984MrWw=; b=v8KMjGQhoUYaY3C5qNU49rQ4Kg6dzWiOwOLv0CfqnDhrKbdAJEDeOfWp8S83740S7OW+4h 56+Rjpbx39c7lCWMVKj4k7GVhfTtRZJ/tmf7qjxmVaOxT0Vh6B6f6PABavrnnajUDLLalB 6/k1vXHH6R+U2LRu1qNTeDDO3GLZV/4= From: chenxiaosong.chenxiaosong@linux.dev To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org, linkinjeon@samba.org Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, ChenXiaoSong Subject: [PATCH v2 6/6] smb/server: update some misguided comment of smb2_0_server_cmds proc Date: Fri, 17 Oct 2025 18:46:12 +0800 Message-ID: <20251017104613.3094031-7-chenxiaosong.chenxiaosong@linux.dev> In-Reply-To: <20251017104613.3094031-1-chenxiaosong.chenxiaosong@linux.dev> References: <20251017104613.3094031-1-chenxiaosong.chenxiaosong@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: ChenXiaoSong These functions return error code rather than always returning 0. Signed-off-by: ChenXiaoSong --- fs/smb/server/smb2pdu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 06e4c21ad4a8..52cb0519b974 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -2168,7 +2168,7 @@ static int smb2_create_open_flags(bool file_present, = __le32 access, * smb2_tree_disconnect() - handler for smb tree connect request * @work: smb work containing request buffer * - * Return: 0 + * Return: 0 on success, otherwise error */ int smb2_tree_disconnect(struct ksmbd_work *work) { @@ -2232,7 +2232,7 @@ int smb2_tree_disconnect(struct ksmbd_work *work) * smb2_session_logoff() - handler for session log off request * @work: smb work containing request buffer * - * Return: 0 + * Return: 0 on success, otherwise error */ int smb2_session_logoff(struct ksmbd_work *work) { @@ -5844,7 +5844,7 @@ static noinline int smb2_close_pipe(struct ksmbd_work= *work) * smb2_close() - handler for smb2 close file command * @work: smb work containing close request buffer * - * Return: 0 + * Return: 0 on success, otherwise error */ int smb2_close(struct ksmbd_work *work) { @@ -5969,7 +5969,7 @@ int smb2_close(struct ksmbd_work *work) * smb2_echo() - handler for smb2 echo(ping) command * @work: smb work containing echo request buffer * - * Return: 0 + * Return: 0 on success, otherwise error */ int smb2_echo(struct ksmbd_work *work) { --=20 2.43.0