From nobody Sat Feb 7 18:15:16 2026 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F24382D46C0 for ; Fri, 17 Oct 2025 08:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690862; cv=none; b=UxQyzWw+D8NmEzcnRRLxFFIs4HELW3KPMJJUQNhG1+iBG6SpGixIYEpJiSETux1d4P5EXjhf4vZzxarVYSvSZ163IqWMTkV4Hks6bmyxf/PsD51psN67lylEDtbSeA2Dw4t7ZUF8iyXUo12Y9JWQnHCESVr8TWQ9zv4GgTvT86U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690862; c=relaxed/simple; bh=CjX26dHKR3o3Fa7F8XrzqNNhWDzdKttza6bC16IEK2I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iaQHo3kjats8hVkxQIfElF/ImeH5+Kk40BCUr5ai4FhQSQ093gkBHxLqJ3BadPxI0m7cqqA6H9xSWEfgqbMfN7fJYxgu20eED3iPlkOJb6kIFvypyfOfSElWuXpOd69LF4CCXYaVpOkL50/l5gcueii3neJZFAROkoyVeT7Udwc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=iynT5OuM; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="iynT5OuM" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760690858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TUKub55LO4pkScjbYvCh6eTwpk6yIxN5nwficBztYac=; b=iynT5OuM+vPpdZUfN046Vd/q+M8/5CO1ziaPSlxBLHaR+5z732bhzufs8974spJA4Rqc+c FFcySELVTwYAG1RcPKiMqKWQ3Oi2VZze9HYrVHKgTjNyH6IjBjgNezIBJUNgR3B+n45R1L bnBd1K7nsOQlPsqO7CJtkpfICTJHm5w= From: chenxiaosong.chenxiaosong@linux.dev To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org, linkinjeon@samba.org Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, ChenXiaoSong Subject: [PATCH 1/6] smb/server: fix return value of smb2_read() Date: Fri, 17 Oct 2025 16:46:05 +0800 Message-ID: <20251017084610.3085644-2-chenxiaosong.chenxiaosong@linux.dev> In-Reply-To: <20251017084610.3085644-1-chenxiaosong.chenxiaosong@linux.dev> References: <20251017084610.3085644-1-chenxiaosong.chenxiaosong@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: ChenXiaoSong STATUS_END_OF_FILE maps to the linux error -ENODATA. Perhaps in the future we can move client/smb2maperror.c into common/ and then call map_smb2_to_linux_error() to get the linux error. Signed-off-by: ChenXiaoSong --- fs/smb/server/smb2pdu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index f901ae18e68a..83d8a325b9ea 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -6842,7 +6842,7 @@ int smb2_read(struct ksmbd_work *work) rsp->hdr.Status =3D STATUS_END_OF_FILE; smb2_set_err_rsp(work); ksmbd_fd_put(work, fp); - return 0; + return -ENODATA,; } =20 ksmbd_debug(SMB, "nbytes %zu, offset %lld mincount %zu\n", --=20 2.43.0 From nobody Sat Feb 7 18:15:16 2026 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94FBD2D4B68 for ; Fri, 17 Oct 2025 08:47:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690864; cv=none; b=U1VH7I4dPxyvzBGVoCSL0se+lyFSe1uwvB6IegyEbyLDIgBc791gpVjnc2eDUpICgxTGMueaANdZP1zFJ0nNgg0Qw44Hm9mPKIDQtlc1JF8HfaETKxb8LNIvr8n5qnYzVLlnvQcV/4z3oS6qxS1h8K6xi4UMGlAj/DayzEeaOmM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690864; c=relaxed/simple; bh=Ba+3pejaChmk2QyZVT8xo3VjUarSz5pmVAh4K1rtou8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uDg3b4LbOLirTyEsfw5a8t3BPk7HbraVsmKe300o8njecMYnK5nTnU7E6k+riKi6rKJyknQEccptCS+jogNuema7eVsi2X8/1RsRdIVk/abEe0e10wWrvimu3Y7GN/v9uf7J+yC+pppwoi78zF1U2/d3+GEy4X2yPYBcb+GVbGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=FO9sAZPe; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="FO9sAZPe" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760690860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/a90+DgKbkpVVTV75K9PtVsd1T594Qs1clx0lbfizLA=; b=FO9sAZPeoIV2VbqNWHQ2pWokcicadh4MQFhweuI+gT/Qxb1fZcSA9Dvx1pX8hLndfWa2CZ TqJqU8np0tt0JClVMcwzyiXpDA8SkRXo0umLFfVNe7IqRwaQ7C+WNdjA3EW3I4FQeE3Zbv xXavxTNryOa3+HFcRqv6V5wCIU4eNfg= From: chenxiaosong.chenxiaosong@linux.dev To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org, linkinjeon@samba.org Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, ChenXiaoSong Subject: [PATCH 2/6] smb/server: fix return value of smb2_notify() Date: Fri, 17 Oct 2025 16:46:06 +0800 Message-ID: <20251017084610.3085644-3-chenxiaosong.chenxiaosong@linux.dev> In-Reply-To: <20251017084610.3085644-1-chenxiaosong.chenxiaosong@linux.dev> References: <20251017084610.3085644-1-chenxiaosong.chenxiaosong@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: ChenXiaoSong smb2_notify() should return error code when an error occurs, __process_request() will print the error messages. I may implement the SMB2 CHANGE_NOTIFY response (see MS-SMB2 2.2.36) in the future. Signed-off-by: ChenXiaoSong --- fs/smb/server/smb2pdu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 83d8a325b9ea..c040df0a2073 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -8787,7 +8787,7 @@ int smb2_oplock_break(struct ksmbd_work *work) * smb2_notify() - handler for smb2 notify request * @work: smb work containing notify command buffer * - * Return: 0 + * Return: 0 on success, otherwise error */ int smb2_notify(struct ksmbd_work *work) { @@ -8801,12 +8801,12 @@ int smb2_notify(struct ksmbd_work *work) if (work->next_smb2_rcv_hdr_off && req->hdr.NextCommand) { rsp->hdr.Status =3D STATUS_INTERNAL_ERROR; smb2_set_err_rsp(work); - return 0; + return -EIO; } =20 smb2_set_err_rsp(work); rsp->hdr.Status =3D STATUS_NOT_IMPLEMENTED; - return 0; + return -EOPNOTSUPP,; } =20 /** --=20 2.43.0 From nobody Sat Feb 7 18:15:16 2026 Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A3AE2D0627 for ; Fri, 17 Oct 2025 08:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690867; cv=none; b=YXpRdkOTZuRC+vbE1NQYzrmJS7HiPiPwui+4PONyAgSVsfCV/tHVPu3H4pI9/2ueTKSz8157V48WnkjhPjP4CDj2BLDl0RwbTEeQOmp0Acw1HlJtR9t6e0gMOqpij517vt4H5WeGL3WUaUgQFKCZ5fTyQ/5HKB9D6pgJOijgFYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690867; c=relaxed/simple; bh=J5jDEy6dWJfTdezTDyrpSiK9Q8q9P9729q0PqTXGExw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c/P5niA6lG//B3XiJP+9pPQLgc2QQ/MyVMhptu15PhitpptCJvdLXnM1V7S5xNESoywhrfGre3njaecWDIU7Cf6S4uog4C0X761wLWwHjiP5lgp78dqKh7nUT1Qx+cMvVK/2xKIK522izraPKN5Br6yJ0wWSf2k/Ku+1vvWnC40= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=xAstrqe5; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="xAstrqe5" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760690863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OHBOYirulXGWUGklwoehPzY2gRDp6I8e8rVR26YDppo=; b=xAstrqe5Lgs/P5vHfrAgiKg78f4uTFQd7ZQpEfZaoKPAZS0k0/CzAl+dt/ybOYAMnbdwQ2 UxFTVO8cqBqeRliJVcRDBMqSnMHov4nZ9f14MtRaFiaLqsEL8mRrWhGJ+deGLaTZVv61bi HVYmgFBY0PLHeNPZ4Paa8lJs5TyZM6g= From: chenxiaosong.chenxiaosong@linux.dev To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org, linkinjeon@samba.org Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, ChenXiaoSong Subject: [PATCH 3/6] smb/server: fix return value of smb2_query_dir() Date: Fri, 17 Oct 2025 16:46:07 +0800 Message-ID: <20251017084610.3085644-4-chenxiaosong.chenxiaosong@linux.dev> In-Reply-To: <20251017084610.3085644-1-chenxiaosong.chenxiaosong@linux.dev> References: <20251017084610.3085644-1-chenxiaosong.chenxiaosong@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: ChenXiaoSong __process_request() will not print error messages if smb2_query_dir() always returns 0. Fix this by returning the correct value at the end of function. Signed-off-by: ChenXiaoSong --- fs/smb/server/smb2pdu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index c040df0a2073..dabc3a49bd15 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -4560,7 +4560,7 @@ int smb2_query_dir(struct ksmbd_work *work) smb2_set_err_rsp(work); ksmbd_fd_put(work, dir_fp); ksmbd_revert_fsids(work); - return 0; + return rc; } =20 /** --=20 2.43.0 From nobody Sat Feb 7 18:15:16 2026 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58FC32D663E for ; Fri, 17 Oct 2025 08:47:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690870; cv=none; b=DCnAaBje5OCkpBEY6ZqvR9M90OgB1x+MepyBKktPhuJvv8CVrDop5dvzrp72noqxdiObZKxl/RB1cZTm9ReuOnguhA/uR2m0XzrlEJJNHh8aQo6r/nicR9b5mbaY3meSdn/8QLodfgfJ9CdTzZgPO60RK3Erz9NH383xu1ar6YM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690870; c=relaxed/simple; bh=0ejlBeYgsjf0yzrToJWQLaAJSPIvKw9k6d/kIcSydks=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HaO4xQPm+RKYQrJBUvdxWb3kn1zMCVBrZhUCfQlYSozg39Qj3PUo8ybfYofpp/lXkRgle6ETXZCsFfyJDxG0nEZeAAP16W8LK9gCkwUqHQp+yGHnUIwaM47TyB09+7YiUh+E4yAEWJGiaEdYcMpl6k/fYIOYVJoXul+rKlgrKuc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=FHtz2F+1; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="FHtz2F+1" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760690865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qwZWDA5HLOWbfxMRMASRFjvRbgY9RlH+PUY+xTprNME=; b=FHtz2F+18xS8wDugSK57OG1m0EZNglCfMSGKlxmQlWBgQAbjkpz3e7rzRgPrm8zs0pRMq1 IFAJg6ntmdNFF+LEyIcTJe5dvgwHD1x8h76TzipZlzuyIE8iYZDnmbDzTa0v1RdNdl3GJ8 eEanYUvNXz3OIYB4nWqmUGmDVozIa84= From: chenxiaosong.chenxiaosong@linux.dev To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org, linkinjeon@samba.org Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, ChenXiaoSong Subject: [PATCH 4/6] smb/server: fix return value of smb2_ioctl() Date: Fri, 17 Oct 2025 16:46:08 +0800 Message-ID: <20251017084610.3085644-5-chenxiaosong.chenxiaosong@linux.dev> In-Reply-To: <20251017084610.3085644-1-chenxiaosong.chenxiaosong@linux.dev> References: <20251017084610.3085644-1-chenxiaosong.chenxiaosong@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: ChenXiaoSong __process_request() will not print error messages if smb2_ioctl() always returns 0. Fix this by returning the correct value at the end of function. Signed-off-by: ChenXiaoSong --- fs/smb/server/smb2pdu.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index dabc3a49bd15..488915a8639b 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -8164,7 +8164,7 @@ int smb2_ioctl(struct ksmbd_work *work) id =3D req->VolatileFileId; =20 if (req->Flags !=3D cpu_to_le32(SMB2_0_IOCTL_IS_FSCTL)) { - rsp->hdr.Status =3D STATUS_NOT_SUPPORTED; + ret =3D -EOPNOTSUPP; goto out; } =20 @@ -8184,8 +8184,9 @@ int smb2_ioctl(struct ksmbd_work *work) case FSCTL_DFS_GET_REFERRALS: case FSCTL_DFS_GET_REFERRALS_EX: /* Not support DFS yet */ + ret =3D -EOPNOTSUPP; rsp->hdr.Status =3D STATUS_FS_DRIVER_REQUIRED; - goto out; + goto out2; case FSCTL_CREATE_OR_GET_OBJECT_ID: { struct file_object_buf_type1_ioctl_rsp *obj_buf; @@ -8475,8 +8476,10 @@ int smb2_ioctl(struct ksmbd_work *work) rsp->hdr.Status =3D STATUS_BUFFER_TOO_SMALL; else if (ret < 0 || rsp->hdr.Status =3D=3D 0) rsp->hdr.Status =3D STATUS_INVALID_PARAMETER; + +out2: smb2_set_err_rsp(work); - return 0; + return ret; } =20 /** --=20 2.43.0 From nobody Sat Feb 7 18:15:16 2026 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49EFF2D6E62 for ; Fri, 17 Oct 2025 08:47:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690873; cv=none; b=OBPcGkYQ0nh04otQTK5TlCGgjtfVfnrFUlrcuPCHGO9iGZqWIfQQS3rwTWVj/KQc7el5MhLQOgofYg/ct11SUjDLw/VQruRTO7T1sZlWE0musk5hshJa1yNmy9yp6V5LY5L8i/eCRHlglxYP2lvtzWM+jvvU+sdUVZeoHwLLCeY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690873; c=relaxed/simple; bh=4eRYz3mKnTAvBwpEGpRVJVevMc1IYOTT5tGNt+ozL2A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KbK3HFCDKpcYWgLhK8GHoLY+lyKq77/Ndr1oKDAhWCJWvPt0p7o8oupqoesZDQfhN6GZXjeak8qpHklMlDPrRyby9Re16s/r2ob2q6DcFjHCArgB5TvzICuKlvyEcm/ngTLjGba3EONgY7MJxjMFz91uCaiYPzyyKMK++RVeDOQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ciiXhzl8; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ciiXhzl8" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760690869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IeylPqYoeDoBboS7TSWJZkfOUBBzD89xIxyEDj64vKo=; b=ciiXhzl8/hVBYpjZ7Tw/6Y0ZyGUNIWioc/8pPHnSl9dQIiHt3GgTlMbslqpXH57ZTY7GhO 3UxMBYi2frBSCpW0Y+hhmVeMDi5ZqxRwpnPJjt+ln8Cp4qxyV1Y1a47Arkz5OAcpKNVzMW 6JzrbPq/OXYivqdiXnL9HN9BFaLSnBw= From: chenxiaosong.chenxiaosong@linux.dev To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org, linkinjeon@samba.org Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, ChenXiaoSong Subject: [PATCH 5/6] smb/server: fix return value of smb2_oplock_break() Date: Fri, 17 Oct 2025 16:46:09 +0800 Message-ID: <20251017084610.3085644-6-chenxiaosong.chenxiaosong@linux.dev> In-Reply-To: <20251017084610.3085644-1-chenxiaosong.chenxiaosong@linux.dev> References: <20251017084610.3085644-1-chenxiaosong.chenxiaosong@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: ChenXiaoSong smb2_oplock_break() should return error code when an error occurs, __process_request() will print the error messages. Signed-off-by: ChenXiaoSong --- fs/smb/server/smb2pdu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 488915a8639b..0fb517838325 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -8758,7 +8758,7 @@ static void smb21_lease_break_ack(struct ksmbd_work *= work) * smb2_oplock_break() - dispatcher for smb2.0 and 2.1 oplock/lease break * @work: smb work containing oplock/lease break command buffer * - * Return: 0 + * Return: 0 on success, otherwise error */ int smb2_oplock_break(struct ksmbd_work *work) { @@ -8781,6 +8781,7 @@ int smb2_oplock_break(struct ksmbd_work *work) le16_to_cpu(req->StructureSize)); rsp->hdr.Status =3D STATUS_INVALID_PARAMETER; smb2_set_err_rsp(work); + return -EINVAL; } =20 return 0; --=20 2.43.0 From nobody Sat Feb 7 18:15:16 2026 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61A5D2D3218 for ; Fri, 17 Oct 2025 08:47:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690876; cv=none; b=MXnQ3G+4tcGY8GnjQJeaFJxwbI03LFUXhQxkhvVo2zu/hiQ+rROQjFTA1M0qXQfzNqD31GyPE+XnaPJhPLBX0oQ7NAv+7ilaG8ftschGRqj11dDIT1gzq8EqsKDLP7HtTw65Lg6Nj2RMqhk0apjn2Wwik3YATQB7HOjsKUi8ghk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760690876; c=relaxed/simple; bh=Smwkl3d6C9d5R43QKpDslC7vUv+Zi3b+/WBFLL5/d4A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E0Ve0YB4S2NUpPBcrB88NnVXDUOlP2MXU7MydMWYwsqSKdgVlJRKLnkwVz1gDFgBjCMrLSz799Hl1WDFeXXFUAECq8Y5nOgPPuO9I3A+TtSyUHbvEYzOogeoaEdfQ/aVJrUrDCzlwu1xhVdMCOrEQXrweArzFI/MF0TM8Jkm6JE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=koLMRnxk; arc=none smtp.client-ip=95.215.58.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="koLMRnxk" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760690871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eQckkc68Kr1WClPbN+XkVmK2MPKAUeYvLWYVQK2kNuU=; b=koLMRnxkrMt6jAOBgk/S4xdtIwWvyLCBjslANTg11vVCTqT9sDApGmnDDltqD7JexGfDhU sNKVKjlaLyfJGLILWBqy5pNU4QrcwH5Zu6393y1cgdiVjoIoeLC5MhZ4j7VgOFeXxacnke 2u8NtiiKFNK5Y/MruFlNmJmFUtifwL8= From: chenxiaosong.chenxiaosong@linux.dev To: sfrench@samba.org, smfrench@gmail.com, linkinjeon@kernel.org, linkinjeon@samba.org Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, ChenXiaoSong Subject: [PATCH 6/6] smb/server: update some misguided comment of smb2_0_server_cmds proc Date: Fri, 17 Oct 2025 16:46:10 +0800 Message-ID: <20251017084610.3085644-7-chenxiaosong.chenxiaosong@linux.dev> In-Reply-To: <20251017084610.3085644-1-chenxiaosong.chenxiaosong@linux.dev> References: <20251017084610.3085644-1-chenxiaosong.chenxiaosong@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: ChenXiaoSong These functions return error code rather than always returning 0. Signed-off-by: ChenXiaoSong --- fs/smb/server/smb2pdu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 0fb517838325..9ddfc2dbe07c 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -2168,7 +2168,7 @@ static int smb2_create_open_flags(bool file_present, = __le32 access, * smb2_tree_disconnect() - handler for smb tree connect request * @work: smb work containing request buffer * - * Return: 0 + * Return: 0 on success, otherwise error */ int smb2_tree_disconnect(struct ksmbd_work *work) { @@ -2232,7 +2232,7 @@ int smb2_tree_disconnect(struct ksmbd_work *work) * smb2_session_logoff() - handler for session log off request * @work: smb work containing request buffer * - * Return: 0 + * Return: 0 on success, otherwise error */ int smb2_session_logoff(struct ksmbd_work *work) { @@ -5844,7 +5844,7 @@ static noinline int smb2_close_pipe(struct ksmbd_work= *work) * smb2_close() - handler for smb2 close file command * @work: smb work containing close request buffer * - * Return: 0 + * Return: 0 on success, otherwise error */ int smb2_close(struct ksmbd_work *work) { @@ -5969,7 +5969,7 @@ int smb2_close(struct ksmbd_work *work) * smb2_echo() - handler for smb2 echo(ping) command * @work: smb work containing echo request buffer * - * Return: 0 + * Return: 0 on success, otherwise error */ int smb2_echo(struct ksmbd_work *work) { --=20 2.43.0