From nobody Sun Dec 14 11:34:18 2025 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF37F30FF13; Fri, 17 Oct 2025 06:50:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=60.244.123.138 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760683847; cv=none; b=SjnYzz3kZkaUNOMOnOkOCVTcrhYrZInltdcZK44mnwiEptxhunYdQAfln7pWz6WClTfwlBJB8ifiI6g7LCHu/oXDgYJ7AGW83pD3E9RTH07rtPoajXxD55h7m/ppLxlKNoBNS4qS/rIAw4Mfs6i1DrqVQakDiYgeBrqyAWECKiA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760683847; c=relaxed/simple; bh=UiAwNTCczeqwsgzs06yKTkxZrBswu/uDgDJqQEr4GMU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fienLD4eoK6wAi8/+7CDKZ1YiyL2pnAnjRMO/11vmAjG6LgiMOzjm/IHQD9L1Hspn7me1aC0wyPROelWkWkDt4mlSHp65XrLBHWvN14WlIP+wPynAy/X+1/52Dzzz6c6nBNLu2OF8CH4zvXUccz1Jjj+yDyuUCnrAd5qRsXsZgY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=FwxNELTa; arc=none smtp.client-ip=60.244.123.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="FwxNELTa" X-UUID: 94236c00ab2511f0ae1e63ff8927bad3-20251017 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=G+KbgUO49/2FINC89cHZwglkPFewWhy41958OhTGyuY=; b=FwxNELTaj3I/yAt6pmvEAYgIXN5UTm2KOibKC4kezha0rgARUp9tVQBYUtJP0H9p9EHtjPD2Go/zkx+nevD2zOVitTU+bCmbc9xoKmQKVrv5f01LO/pxBD2m65Y7r+25Xd3zddt6Aq5dD8vRSfQdr1h2LB7fisMINu+FRlj+2LU=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.6,REQID:92305f39-3f1b-466e-8b50-b2c08f77f429,IP:0,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION:r elease,TS:0 X-CID-META: VersionHash:a9d874c,CLOUDID:0a6d45b9-795c-4f99-91f3-c115e0d49051,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|836|888|898,TC:-5,Content: 0|15|50,EDM:-3,IP:nil,URL:0,File:130,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0, OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 94236c00ab2511f0ae1e63ff8927bad3-20251017 Received: from mtkmbs14n2.mediatek.inc [(172.21.101.76)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 939130012; Fri, 17 Oct 2025 14:50:33 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by MTKMBS09N1.mediatek.inc (172.21.101.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Fri, 17 Oct 2025 14:50:31 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1748.10 via Frontend Transport; Fri, 17 Oct 2025 14:50:31 +0800 From: Jason-JH Lin To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jassi Brar , Chun-Kuang Hu , AngeloGioacchino Del Regno , Mauro Carvalho Chehab CC: Matthias Brugger , Nicolas Dufresne , Jason-JH Lin , Nancy Lin , Singo Chang , Paul-PL Chen , Moudy Ho , Xiandong Wang , Sirius Wang , Fei Shao , Chen-yu Tsai , , , , , , , Subject: [PATCH v8 11/20] soc: mediatek: mtk-cmdq: Add mminfra_offset adjustment for DRAM addresses Date: Fri, 17 Oct 2025 14:44:36 +0800 Message-ID: <20251017065028.1676930-12-jason-jh.lin@mediatek.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20251017065028.1676930-1-jason-jh.lin@mediatek.com> References: <20251017065028.1676930-1-jason-jh.lin@mediatek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MTK: N Content-Type: text/plain; charset="utf-8" Since GCE has been moved to MMINFRA in MT8196, all transactions from MMINFRA to DRAM will have their addresses adjusted by subtracting a mminfra_offset. Therefore, the CMDQ helper driver needs to get the mminfra_offset value of the SoC from cmdq_mbox_priv of cmdq_pkt and then add it to the DRAM address when generating instructions to ensure GCE accesses the correct DRAM address. CMDQ users can then call CMDQ helper APIs as usual. Signed-off-by: Jason-JH Lin Reviewed-by: AngeloGioacchino Del Regno --- drivers/soc/mediatek/mtk-cmdq-helper.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/= mtk-cmdq-helper.c index a884e481efa6..1b4d4a1e2984 100644 --- a/drivers/soc/mediatek/mtk-cmdq-helper.c +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c @@ -372,6 +372,7 @@ int cmdq_pkt_mem_move(struct cmdq_pkt *pkt, dma_addr_t = src_addr, dma_addr_t dst_ int ret; =20 /* read the value of src_addr into high_addr_reg_idx */ + src_addr +=3D pkt->priv.mminfra_offset; ret =3D cmdq_pkt_assign(pkt, high_addr_reg_idx, CMDQ_ADDR_HIGH(src_addr)); if (ret < 0) return ret; @@ -380,6 +381,7 @@ int cmdq_pkt_mem_move(struct cmdq_pkt *pkt, dma_addr_t = src_addr, dma_addr_t dst_ return ret; =20 /* write the value of value_reg_idx into dst_addr */ + dst_addr +=3D pkt->priv.mminfra_offset; ret =3D cmdq_pkt_assign(pkt, high_addr_reg_idx, CMDQ_ADDR_HIGH(dst_addr)); if (ret < 0) return ret; @@ -505,7 +507,7 @@ int cmdq_pkt_poll_addr(struct cmdq_pkt *pkt, dma_addr_t= addr, u32 value, u32 mas inst.op =3D CMDQ_CODE_MASK; inst.dst_t =3D CMDQ_REG_TYPE; inst.sop =3D CMDQ_POLL_ADDR_GPR; - inst.value =3D addr; + inst.value =3D addr + pkt->priv.mminfra_offset; ret =3D cmdq_pkt_append_command(pkt, inst); if (ret < 0) return ret; @@ -565,7 +567,7 @@ int cmdq_pkt_jump_abs(struct cmdq_pkt *pkt, dma_addr_t = addr, u8 shift_pa) struct cmdq_instruction inst =3D { .op =3D CMDQ_CODE_JUMP, .offset =3D CMDQ_JUMP_ABSOLUTE, - .value =3D addr >> shift_pa + .value =3D (addr + pkt->priv.mminfra_offset) >> pkt->priv.shift_pa }; return cmdq_pkt_append_command(pkt, inst); } --=20 2.43.0