From nobody Sat Feb 7 11:31:39 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C99D1C862E; Fri, 17 Oct 2025 05:58:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760680697; cv=none; b=nihGuG6NtVs2PdTq2G7OSGWzFtZBRpwccgOE7LLiofC2+YJ35qmtFX1bDf8NysiGfGf8oL7Z4jfdQFAojRoJlCGcXScBj661TnSLF9Nh0mTw0oeNAL5k2CkfRbB1TAO2YRanrtxgAMuPPu8zyfnirfx+6ffhNCyuXbewumsofWA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760680697; c=relaxed/simple; bh=cTmwKSoqOEd/Lnhdk3mDeZtjBj5ydGFnJ6HadMug0IY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hKcuHmsJgDg+sAy68m5A9djynKkgZ6GP1SM40jy2+IKebCHEFNHV8MoXxNRebJjbgyzBfZJnFW9muhC9rq+Rjx99tsxMRZskAxwoappaBF4Qm9rth08phJEtW+RpHg95DQqWV1eqGYDBMyR0w0VZ5BLjTWpLOhWgNxLi7nXfQao= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SUSE9sTO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SUSE9sTO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88150C4CEE7; Fri, 17 Oct 2025 05:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760680695; bh=cTmwKSoqOEd/Lnhdk3mDeZtjBj5ydGFnJ6HadMug0IY=; h=From:To:Cc:Subject:Date:From; b=SUSE9sTOG8yy52ucL+RRpKcOjlxuVURKh36E0yyCxUcHOyXtRcNXGdAIgfdr+yynV I5qXPxiFczz/vxkahoqJBcBN4T6IoCGwC56/LWMNycFbResCBHtOsNia2bsc39Qc5Q 6ZPs/eSIjacviqQaCdJ5yy9NESr2F2TjZ+xqd4eqSZxqL6Lmqg0pDZSfachndGqqdq 52YAluf08EGWdbyltDfC86gZe7Xs79cAZ+CCnHsckZZT6erAHLYkBsu8+3YIq0xlWw C+gJQe5dw+yzGNq5165EY5bdbA124aRLlIGzcgOsQWWczlHXZikW2IJVInLTrdLOHN i9IO/eL9EBI2Q== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1v9dTm-0000000025x-0A7O; Fri, 17 Oct 2025 07:58:18 +0200 From: Johan Hovold To: Vikash Garodia , Dikshita Agarwal , "Bryan ODonoghue" Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH] media: venus: drop bogus probe deferrals Date: Fri, 17 Oct 2025 07:58:09 +0200 Message-ID: <20251017055809.8037-1-johan@kernel.org> X-Mailer: git-send-email 2.49.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The encoder and decoder platform devices are registered by the venus driver as children of the venus device, but even if someone were to mess this up no amount of probe deferring is going to conjure up a parent. Relatedly, the venus driver sets its driver data before registering the child devices and if this ever breaks we want to learn about it by failing probe. Signed-off-by: Johan Hovold Reviewed-by: Bryan O'Donoghue Reviewed-by: Dikshita Agarwal Reviewed-by: Vikash Garodia --- drivers/media/platform/qcom/venus/vdec.c | 5 +---- drivers/media/platform/qcom/venus/venc.c | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platf= orm/qcom/venus/vdec.c index 55c27345b7d8..2d822ad86dce 100644 --- a/drivers/media/platform/qcom/venus/vdec.c +++ b/drivers/media/platform/qcom/venus/vdec.c @@ -1778,12 +1778,9 @@ static int vdec_probe(struct platform_device *pdev) struct venus_core *core; int ret; =20 - if (!dev->parent) - return -EPROBE_DEFER; - core =3D dev_get_drvdata(dev->parent); if (!core) - return -EPROBE_DEFER; + return -EINVAL; =20 platform_set_drvdata(pdev, core); =20 diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platf= orm/qcom/venus/venc.c index fba07557a399..f1abd2bdce6b 100644 --- a/drivers/media/platform/qcom/venus/venc.c +++ b/drivers/media/platform/qcom/venus/venc.c @@ -1560,12 +1560,9 @@ static int venc_probe(struct platform_device *pdev) struct venus_core *core; int ret; =20 - if (!dev->parent) - return -EPROBE_DEFER; - core =3D dev_get_drvdata(dev->parent); if (!core) - return -EPROBE_DEFER; + return -EINVAL; =20 platform_set_drvdata(pdev, core); =20 --=20 2.49.1