From nobody Sun Feb 8 00:11:26 2026 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 538532566D9 for ; Fri, 17 Oct 2025 20:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731213; cv=none; b=LRuKhwx76x70dSK20/Yx76PWmI57EVcleEBrLrmyHrcJxgiVTEfAVeylmICaa7PmvwduZZTv9Yi2wXawxZ4uuTnXVyxNG5uoIVUniOMkuIp3GsRBaOTk4e/Bmhh/2LLz47ZrPdgf9awvZaR1+S+Mrrp78y4hb9O5MsqmDRwrWco= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731213; c=relaxed/simple; bh=j4CxU22f5f5xHLw6uVxf327bBBJgMniZTot+Nm5mz0E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hGbEcfRXYL7rKMwhUPma0JLJBx1K7cSZc8zTXhUxjKj9j6eg8awTZ4/p2U2AmRKU60V2UjtGGSnARsfe9ehkrCPPhiHHrRpXOiXTeH8ba37AkWwHGf5aT80mIDpKiD6i5b0FwrAh3CYM6O627TRLnyw+iwuNMpFCHHrrUEiPZDw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PWk658bC; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PWk658bC" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-371e4858f74so27128661fa.1 for ; Fri, 17 Oct 2025 13:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760731209; x=1761336009; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FW9/6WAzhrFRAj+VvpEcKL8n1ZBRl0dJtQSc+UHoxRY=; b=PWk658bCJ41xt/bpQYGYJxP14/C3q3IWlI2Aghk9fk4E0rV6LdSq258qeIDE+ZIPqR dDmweSikgJVmqJ8TlGqDoHWyo8E95BXJ+jmMTSUN8viPWuKo2wxjXrq7KGb3660QiSDv A07jIoA3fzlm5RYhozjHnQLtdHYccu8Q8qWtW34V+SxsR+H9wwZluyWH60aH4Lo7UPc0 ccw9njuy1r0rvsgMSg2SkNmjLjDzdcXJ5XnpBg2KlsvSzQnXGUbONJIQ1aeqlmgefMlo 9hag2hwQeZYgpJZdiPS869x58sB25Wm4XAQroIxj2c+PF+s8VtSnP5d4lAG0uaIj5T9W +eFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760731209; x=1761336009; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FW9/6WAzhrFRAj+VvpEcKL8n1ZBRl0dJtQSc+UHoxRY=; b=Wv1zfPg8YtUmPHj7aQ5QOyXQjod3SStUGE4owTZ5/i54k7i/D/quwBL9IYpg4Pt6nO CusQ0Wy7ZA00cSRyBV19MuQ0amM4RCw4ILlLA6PKbn7Ll4e2POpbzWiOAsQ2n3A9jehF pqv7FpDOhMfmsTbiY7tB8mUN3Jajk+rE+TvmyQefiAjK5Bw7HTHqzs2bPLO3vOkhGvrM bc4arVpvru8wsGZcBUST8m/JlEtGk9wgCSYCuKI3tqCfFw99V9fL29otw31/cB7lQTTB 5zXrh0tVpS3AZQtuR5sf5qVi2lHT2CFTRd9CY0qtvPOZ04QOkSJBb8U2pYJ9InvGUBkl u9+A== X-Forwarded-Encrypted: i=1; AJvYcCXBSyr3G1mbnCJ+wST0uh52hHpJBnafTVSguQfkV0ZqbrKwSeHqb1DjQGbCenpnH3AArOX/3h5l/az1pD4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9Y9M1ogqYQY4DjNs7+0bUF5XMdXSH0IWXOX1SeVj8BUPHvP1E yLkqmeH5u55r3QVLep1QWMMo5f5HaDVJsmnchUwT6RGhycKre7U32xNc X-Gm-Gg: ASbGncsC8vjcmUhTYZ1jFwZVU+I+a9Le0q7B04djgBYtExg8OKcywpsXmOQanWc+u7u uC/IfAGejlQwgtp8xAeXYP1WiWjrSP2koOizqv6Q8j3cQ0oJigK0djRqbv0UXP28FW82Um3k30b /1ursavW7B5/kapMn9UPBMLOBFZ7P4sXqda+f3vxT5Av18xkb4QYygJTwwKDN7mKvTLeG4beJeV LKVSxKx48tOypwCaxnSe8l5e/ZKAoS7vlz5jX2h9c86I2P+MQycml05Az2GWi+S9IMtib6KqiKZ lOA825EbJcfO7tjLEUPVFnT9Cw0jd8yTg8ejIvkU5k75ZPmuzURYcNhY36pzejg1/iOZcag/9Zc JGKj29XT0HGNaze+zOe//XyBMb+d3aQIidqbtTxyDyAq81EM/uusrCRplRYGVUSWIm8QvPxS4c1 z/s9ekvJoq5blBEu4Ax6N80CzKtd5iwEpkm/DRSoNSabT2amd776+p/6TkQfIMBA== X-Google-Smtp-Source: AGHT+IEQgaJHNjNCzev2AElmYZvm0Ji4cjMgDetLxA+1NUJ+RNTYtKrBYXG44qqxgaS1GwNzvFxAkw== X-Received: by 2002:a05:651c:4353:20b0:377:991f:c1bc with SMTP id 38308e7fff4ca-377991fc573mr13307731fa.5.1760731209147; Fri, 17 Oct 2025 13:00:09 -0700 (PDT) Received: from [192.168.1.244] (public-nat-13.vpngate.v4.open.ad.jp. [219.100.37.245]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-377a921d99bsm1580861fa.22.2025.10.17.12.59.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 13:00:08 -0700 (PDT) From: Vladimir Lypak Date: Fri, 17 Oct 2025 19:58:35 +0000 Subject: [PATCH 1/6] drm/msm/dpu: Fix allocation of RGB SSPPs without scaling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251017-b4-dpu-fixes-v1-1-40ce5993eeb6@gmail.com> References: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> In-Reply-To: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Kalyan Thota , Vinod Polimera , Konrad Dybcio , =?utf-8?q?Barnab=C3=A1s_Cz=C3=A9m=C3=A1n?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Vladimir Lypak X-Mailer: b4 0.14.2 Due to condition in dpu_rm_reserve_sspp, RGB SSPPs are only tried when scaling is requested, which prevents those SSPPs from being reserved if we don't need scaling at all. Instead we should check if YUV support is requested, since scaling on RGB SSPPs is optional and is not implemented in driver yet. Fixes: 774bcfb73176 ("drm/msm/dpu: add support for virtual planes") Signed-off-by: Vladimir Lypak Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/d= isp/dpu1/dpu_rm.c index 2c77c74fac0fda649da8ce19b7b3c6cb32b9535c..d9c3b0a1d0914a47f86ac9a854f= bcede021e73cb 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c @@ -842,7 +842,7 @@ struct dpu_hw_sspp *dpu_rm_reserve_sspp(struct dpu_rm *= rm, =20 if (!reqs->scale && !reqs->yuv) hw_sspp =3D dpu_rm_try_sspp(rm, global_state, crtc, reqs, SSPP_TYPE_DMA); - if (!hw_sspp && reqs->scale) + if (!hw_sspp && !reqs->yuv) hw_sspp =3D dpu_rm_try_sspp(rm, global_state, crtc, reqs, SSPP_TYPE_RGB); if (!hw_sspp) hw_sspp =3D dpu_rm_try_sspp(rm, global_state, crtc, reqs, SSPP_TYPE_VIG); --=20 2.51.0 From nobody Sun Feb 8 00:11:26 2026 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A74823A98E for ; Fri, 17 Oct 2025 20:00:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731230; cv=none; b=Pe8Fpa1Gxw6uecvSmeuXuRzxP/MojgoY78+SxnMx3WFoszN/pDKqdVeE95fv6cgF2g6FR1nr23K2jobMMBvoCuKojRq9MZDoCFHRycpzYg8d4OpcNam+0RzY9gUiNTeVtHWayCyBJX7nFIj/C1mctmgh0mYYnV0amGp6a1JMsxM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731230; c=relaxed/simple; bh=l9a8wUxnUFKjAxqJPfeNN/SOxfzcybhdFcIL4XU/Lq0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uzRUEHBXG7t9EaAci43T84QMrbqzoSHg6xrQ2WHrLFNl0+PoIiHRGNip/NmvoquWkIR7zV/E676ob/6BZ6SHlrcvTEYynSkN67MkAK+GXRI6P5vYiOcgMCFfuDGejohIl07pstzLRJLVE9cAdlkPnxZs0bEFFNbnvxyR62h1T/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JiTm0Tj2; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JiTm0Tj2" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-3612c38b902so21584811fa.2 for ; Fri, 17 Oct 2025 13:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760731226; x=1761336026; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=W7XqOWl1cfsF52QRqm2uO00zKVuXynKW/bvPOkip0X0=; b=JiTm0Tj2DSi5R7TX7So6hieCFl7rQPQ4a/tGMVDgIfYP4OJ4JTae0EXFcE2wtaBWZ+ mOMULhN6uWglZUdFceH9bih+nXYNOmfHsr2VCTh6kDjutf5V8G1RbCXQN20OPLXc6NQK 3tj0J6u28plgIPQWk1yxZNMD4AByAJyaFkv98J/ym0KP0Hlu3cNl3wR26avUHYmRbhrj zH1LGsKOtBEDAxRCuxix0w8mAufqNaPqmL0KDzrsq8jcNmHscjOmn716IuOmtYYQcGMd 2UkGyKUzt6GXGydvvDqlRMMipE4I7L0EqUkbvwEDeeeULlVzACsaa5XKQq/bHMlA0Lja O3Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760731226; x=1761336026; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W7XqOWl1cfsF52QRqm2uO00zKVuXynKW/bvPOkip0X0=; b=WSm9SjwsN9y9GRC52cmQLA3Xf/FcWb4QI+zT4QLZfRCxd2jhjQm8U9/9gZvmBQa/8/ FD2vANpqrO/r92uLCfI3wpLnD/Ot59FBzypMh+4vSKDPHUyAk2FnY3SvxOWlI8CWDCVv /GJIz9fUAnKhnk7rRilpxmQIqK4yszCUr+hIPx0oX+WBJ5lCIiEaRgmY5AOdOtaEpwk8 k7bS3T0QxLvdMlYlSKmsAPzMsS5CBcE7ZcMqqB7HMuzEMN7PIGJHGPDe3MyfjBFTA6ok K2Ml+Er88ExlI2dVnTujxiuYD1KByTssuwcEMPuo88duwR631/I2a/zusn+dh9TuyxLQ nUxg== X-Forwarded-Encrypted: i=1; AJvYcCXKdkdFfIlPI0D7g+aN5dp89Gf6FxXUrcetmSJ/rRzpbDO+mwVs9E2wWUHHvpb7hbyHpqcBkQOP3HnYSvM=@vger.kernel.org X-Gm-Message-State: AOJu0YxKbhF4EdlKY7N13xoRVDGgmImGAHnOzODeVkgB9d02POASCwT8 71JYs5LoXQGeuzJ5aArWQSfDNqYoimrPxnTm5K8/JPzo/rnphuLq9O7H X-Gm-Gg: ASbGncvkbDFj8KBOwOol+y5h4mkXBxLvlFljLL/WGlLyFxijHuiN9C2RDG2C0AKHjoV i0BE342ZwSawuxYM3vcNr9AN3DjbjByRLPUGy5N0BuXPsnnXWNYzebx86mq7EyEN30Mgka/XGkd 7HUSmxLBr+I15s79evSV201jpza8l9rw5neptgITbP/lpn8rnm8+pkZJu54VefWilUadWlMdC5u s2sRdF9/YEOQ7LyikrfVp2Gda+3sOuMtJLjQTVUBSokZBFeY7uePj53p2tqDFFMjmVfMWvPAEZM v1a8txAzF+HjV1tNxZCyKqyYzBfZmuJyJquhy9MbjwTd/zXX+EIrRA7NtcAs2az2YbPqILQdhQe nCNw6BDux9dwhzpdCOSkr74I70d+EtxGTI7jUlIRID0DZSl8jty2XGXWIg6F7Cpo1BfxwoJYjdu J7H/+3o6A3ua/g5GgHs1YnGDJiDYCorS0dQg8G+BPnf2RttO/2ilo= X-Google-Smtp-Source: AGHT+IFrm/3xtNQT3MBQMvkncf7kZPyKKqAIptXvvBOXIh8nfNhykS0BMD1amwffzbPJvG3jZUH5AQ== X-Received: by 2002:a2e:bc11:0:b0:36e:f1ae:d4bc with SMTP id 38308e7fff4ca-37797888c0cmr16609961fa.14.1760731226308; Fri, 17 Oct 2025 13:00:26 -0700 (PDT) Received: from [192.168.1.244] (public-nat-13.vpngate.v4.open.ad.jp. [219.100.37.245]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-377a921d99bsm1580861fa.22.2025.10.17.13.00.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 13:00:26 -0700 (PDT) From: Vladimir Lypak Date: Fri, 17 Oct 2025 19:58:36 +0000 Subject: [PATCH 2/6] drm/msm/dpu: Propagate error from dpu_assign_plane_resources Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251017-b4-dpu-fixes-v1-2-40ce5993eeb6@gmail.com> References: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> In-Reply-To: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Kalyan Thota , Vinod Polimera , Konrad Dybcio , =?utf-8?q?Barnab=C3=A1s_Cz=C3=A9m=C3=A1n?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Vladimir Lypak X-Mailer: b4 0.14.2 The dpu_plane_virtual_assign_resources function might fail if there is no suitable SSPP(s) for the plane. This leaves sspp field in plane state uninitialized and later leads to NULL dereference during commit: Call trace: _dpu_crtc_blend_setup+0x194/0x620 [msm] (P) dpu_crtc_atomic_begin+0xe4/0x240 [msm] drm_atomic_helper_commit_planes+0x88/0x358 msm_atomic_commit_tail+0x1b4/0x8b8 [msm] commit_tail+0xa8/0x1b0 drm_atomic_helper_commit+0x180/0x1a0 drm_atomic_commit+0x94/0xe0 drm_mode_atomic_ioctl+0xa88/0xd60 drm_ioctl_kernel+0xc4/0x138 drm_ioctl+0x364/0x4f0 __arm64_sys_ioctl+0xac/0x108 invoke_syscall.constprop.0+0x48/0x100 el0_svc_common.constprop.0+0x40/0xe8 do_el0_svc+0x24/0x38 el0_svc+0x30/0xe0 el0t_64_sync_handler+0xa0/0xe8 el0t_64_sync+0x198/0x1a0 Fixes: 3ed12a3664b3 ("drm/msm/dpu: allow sharing SSPP between planes") Signed-off-by: Vladimir Lypak Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/ms= m/disp/dpu1/dpu_plane.c index f54cf0faa1c7c8c00eb68b8b45ca2fc776f7f62f..d198a65a2c5fef5fbdebc9c383a= 4b08bc71b8bf3 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -1278,7 +1278,7 @@ int dpu_assign_plane_resources(struct dpu_global_stat= e *global_state, state, plane_state, prev_adjacent_plane_state); if (ret) - break; + return ret; =20 prev_adjacent_plane_state =3D plane_state; } --=20 2.51.0 From nobody Sun Feb 8 00:11:26 2026 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAD0C23A98E for ; Fri, 17 Oct 2025 20:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731244; cv=none; b=fIQ8OzKkmaa8yMCUcm+gdp+Qq4mVdFdZHXbnQYVIagvd0Dt+JwgLxZ2GtAFNrbRJAKBl8vnSLBPNb+ms2yBnUDXsFgKFJomrINL6rUuwff4fcYz318GGv248Upr3W0wr2h0cWy5hOBD15ofbkkKpE6NArbUMdFJ8q/IuIUHixus= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731244; c=relaxed/simple; bh=F2zDecP6+oFfoSg8W+FxJSa/s3jTLYNPTNsWj2Zuph0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=X/Mxe9vX9RLcqtPQkBykYSkKCb2OugckJe7qXOsfqawp6rp7PC1V/i+tg8RYUf3zvXUI5xrE86QZ3t5teUV2ws7IAKgILKe42TeOEp0iXEOneAAGylnVhtws3e3sm/GmXxWYMnMdGdf4pkM8z+zPr4b6kGGpSGmLFPmv+mJSGmw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CoDgKL6q; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CoDgKL6q" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-367874aeeacso23853161fa.1 for ; Fri, 17 Oct 2025 13:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760731241; x=1761336041; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xQNJSxr8t/BdOOWVzHAAqI48NQwvfIqpyN0Al86/+Ik=; b=CoDgKL6qeSpEtOdkltiQdM6lKq8SKshtM0o1TwwAIBBTknGFxW593YMFj0VIcdfLoG xRB1VUhpRIB/AmGKtTTd0F0gFWoODULuI6hrDBkrjINmugpZpGPuMXooBsgpVdvIH6r+ KHiLC8BKbySk7nolP/XlhQpJaco+zt0lMMAHfsWv3XtzG61l718SD4RWv2w9Qudq+peY aPmVIoCE4O4WA4jC0UOxRGt3zlP/JMWgJO7jRKdrr6Cn7w3WqmJ+JcLtSSdD/xPaOcqS QwvmZxFffVRb0zTvw8+OsBRpqTGeo+pE57cgkck3wPBzaCpLdkEoC6CwmoA5giT/wroH F3bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760731241; x=1761336041; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xQNJSxr8t/BdOOWVzHAAqI48NQwvfIqpyN0Al86/+Ik=; b=C8sRQGo7s/+BdVocbFYwubV71POwjCC5/k8auLM0x4N0MIKx2h4lJyPY0c/P98hngI DUQlieEFAni7K4j0QUOUhqpd6twWUWihHB8aGa59uC9DDTErmcGbhWdS3ZhFglhiEqW5 rhscqpTaCuyjt8R+AuvthiHupAI2B6sWlyflrS6Cb2kQDQUb1hl2RH6e+Q0LMoT9e7Lc /rU4rQL/ODf/up8ieJcrwRpDJbpNt16ISgszQoakWeoHpDDxuHFSIfsYxU8SjgC6rWc1 5e4R66rF7yU0+jRqr1ZZU/SACnqkAOMHZGiZ1N/9SmhFYRcmeB1LcrTjzxGfI9nqfALS zqAg== X-Forwarded-Encrypted: i=1; AJvYcCV88AGQX/6rXKBmv6oqVQiLp8BhD+AEJFjesYSX86eM8wRD4qxw5KcKRLB6934ddMKAZAdX02X7B68vGac=@vger.kernel.org X-Gm-Message-State: AOJu0YwV0RTEd3aoK5iEUjB4Ty3gxs955OCruf8PlauNoO+wBjemLvqG V8xaTRuA7u+EERx91Inr4jrEIKf+uB5tj3gm4Jz2DKD7V8wKfzaqr42K X-Gm-Gg: ASbGncu4Qr6ruk7CAisVgxd6crmB1+/LGv7Ab78foxP4zOq2dAtufVDQ1AbuUW1Z1sk scn3Cf8NVCh8/k0sqUTiBUIBbtN5T/HcBiAmjNw9wgJEwFY+oF1wQMojfQLvY58qZpHwLNEYc2S I2wgwXr/TXSzraUDnrBlVTFA7vfNHDXVXPOa/L4cjIv5jtF9FNzE6gkHQ6OJ4iXyVS0oLAD0oey 3miTvLzxoWLPr8wrEgjo5RrXNmPKm9Osf2Hsm5jHZiAnjh3bFCrvgxRXBTn6zJoomnQy/cMLb96 TNkh+UzcPuxUZ0lp/2fyQnVY3s+I0sD1EwEHRxb5B6CXZoj+nAD4YOEsmLSWlCaODn2s81xZX60 pYUEYDs1aDhpEhonQyEpN9GWEr990lrmZ9HGeu49VlzpZ5LUIwXHv79wiBPVjnU70E6IFlEaPw7 nhTc6gmVfED7t8CxwMCAdljIIkpL7n3CgHT+bSfQZFEP1ySEPaQBkT5aqfJD4Mdg== X-Google-Smtp-Source: AGHT+IGNU4fQjBz2jSA6DBrpEqZEn5tDNBRAgHPtQC9tAm1M2lku7pLWWHwNUw5re71jbQvu9jXrmA== X-Received: by 2002:a2e:bd03:0:b0:333:e590:1bc9 with SMTP id 38308e7fff4ca-37797a0e735mr14647271fa.24.1760731240714; Fri, 17 Oct 2025 13:00:40 -0700 (PDT) Received: from [192.168.1.244] (public-nat-13.vpngate.v4.open.ad.jp. [219.100.37.245]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-377a921d99bsm1580861fa.22.2025.10.17.13.00.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 13:00:40 -0700 (PDT) From: Vladimir Lypak Date: Fri, 17 Oct 2025 19:58:37 +0000 Subject: [PATCH 3/6] drm/msm/dpu: Disable scaling for unsupported scaler types Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251017-b4-dpu-fixes-v1-3-40ce5993eeb6@gmail.com> References: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> In-Reply-To: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Kalyan Thota , Vinod Polimera , Konrad Dybcio , =?utf-8?q?Barnab=C3=A1s_Cz=C3=A9m=C3=A1n?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Vladimir Lypak X-Mailer: b4 0.14.2 Scaling is not implemented for some type of scalers (QSEED2 and RGB) but it was unintentionally re-enabled with change below. The remaining condition in dpu_plane_atomic_check_pipe is not enough because it only checks for length of scaler block (which is present). This patch adds a additional check for setup_scaler operation. Fixes: 8f15005783b8 ("drm/msm/dpu: move scaling limitations out of the hw_c= atalog") Signed-off-by: Vladimir Lypak Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/ms= m/disp/dpu1/dpu_plane.c index d198a65a2c5fef5fbdebc9c383a4b08bc71b8bf3..6effe0fa4837284a1f038e4907c= 4c91d239aeb8b 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -740,7 +740,7 @@ static int dpu_plane_atomic_check_pipe(struct dpu_plane= *pdpu, * We already have verified scaling against platform limitations. * Now check if the SSPP supports scaling at all. */ - if (!sblk->scaler_blk.len && + if (!(sblk->scaler_blk.len && pipe->sspp->ops.setup_scaler) && ((drm_rect_width(&new_plane_state->src) >> 16 !=3D drm_rect_width(&new_plane_state->dst)) || (drm_rect_height(&new_plane_state->src) >> 16 !=3D --=20 2.51.0 From nobody Sun Feb 8 00:11:26 2026 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6980A23EA8F for ; Fri, 17 Oct 2025 20:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731258; cv=none; b=d3UARiRN6C7pSXg1x8qewXS6MDJkeWb6CRGHvkNvIYkn4hAj+FTL9UN+7ewaFrkqmu9G7yXs1oMa815kcfgErbv3Pq/lNDk8dQkOb/BsS7aFm7JRq8uJG0B0o5kve6cjWsLtMOYttuucBJMVn9oQV0S2hohwYDckZH1Bd4BOklg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731258; c=relaxed/simple; bh=knh/HEr6cHlCZELVAiS5ohJ6Yl7S9RjBxDHyiwEz+aI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DOFPBru3xxTLRSh1NwOvOxBgCpBsr+R6gDAzsh+0uocUdiN/VF06wI5SUzhVjdCn9cwzpMlVhvJj6EwLKcLc5dO7QXrR8HUF5EbAP/JfbJKhooDsgSaqp6g/zHdVddXvnqk05/iaAhXBOdKT220SB1fD1q+HVuNp+QbPZP5Z/CY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JfJzAwrs; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JfJzAwrs" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-376466f1280so23244961fa.0 for ; Fri, 17 Oct 2025 13:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760731254; x=1761336054; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=E6uQHUW9ChgQjFk3rZ7rRlcJ/k+AJJTDJCwK+JBs0nE=; b=JfJzAwrs9Ld0x9V1GMpWf4iWNzb4WEtCUlUuF2V9I/x171shRXRB1ioKB6xUxomY3C uwjIWslSaZ9J0OOnOWAaY7d5tMEyZrupGO7VQDQbHitxMUWBAIUU8OCmQA5FjqzJiENE r3zqOEgpsfRjphaANU7l/egU4Vb+BNBEBfwOyMGBnCwW2+As74D4bp7NEIy1cs/Pb21r t22xNQ3bXQr2BCNFDTlbb0SPEcM0KYZPkNJPkokHzLV5J/wgvSVmF1w+phPyQBTNKMWt ImmpMAceWM0BroqMwLU/aSebFkB2KreUHufTqzVoIhh7DOh7OSv5FsIgdACrdcuGyt3g UUkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760731254; x=1761336054; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E6uQHUW9ChgQjFk3rZ7rRlcJ/k+AJJTDJCwK+JBs0nE=; b=HzaQdBOFE3GcK3MD1ijF8MSUIXLkF0mcQNr1UAboL2nlYX5PWlVoTseQw6pPiqy4fg HaVD0fQkTPZiVO9rDZjtgPqm8xtLfGVlDJeFiqFfabF9yF2DvRvvrz3BM25LFfp5yygF NigY6d4N+ZAVUqHOYkrZbUjD5BPF12w4f52fJRe7fBFNd42KKEeTkl82EXYLOZIdcwDa YFgEuihGFCOXTCpiCthvKpCR8Fuizl3C0OCYkRchoGJnKrMjHm3DdDfdwv14Z82WVl2C 6ZhzYnVOlAqFlX90gfePJRloDn52R7gVVzvwYnCZpeB4wbWo4MINu/0MLCM5YrHCQFyS bsgA== X-Forwarded-Encrypted: i=1; AJvYcCX54xstRbdkc+kgUbdOpNbL/4MTuKBBqHAlvOxw7PHWA10tT/4Bq3ipO4d8Q5b11ghbdRUfBSmyP8IU9Ec=@vger.kernel.org X-Gm-Message-State: AOJu0YzwLkKDRdYVN6VxPhNr9ivMQT2Jf/+BdFpQ8aqYoP17WD0bmVA+ my44/W76HYYl0CeC2vN0LHEr5t6dRPTW5hZAu9q9GhbvsZQyhS5miBLe X-Gm-Gg: ASbGncs1Wpr6E8PfJZhejn42SQ43zRhBa10uM+qBh1gOUZPD5o21p+OELE2EWUE/uHA nM8hBFHdI/pJRi68UkgAZasbfw2BHF+Je0jPkNo3Ox09sYXPsSlkFGJ9Qf/5HiyNYMk3xt1LFxz 2DU9werLg8nwoX3kKkNBrgtGGH5TmBbWPNCTcUEUXvOL5bkxOLeqrQne1Sy08AfabObaQAKByP1 pA996p5cm3YvzV1Ccavoyl6BCb4QFYKPJooYwj2qzo2nZBqsbGzTGUwXlV6F1mYPL2KjiE2Oaqj k98g4JYXjgxZ3sxByap/jixF5DZckzJUgBvV2bdAQm8/leq37s1u/kVOj2UR5FBHzAe30VQAjlG pOPF2/S9UGrxAgd7moka3u7EmEYzX40cU9jfraR5Et7tnEYANQYOYTuEUg/t64tGQ0huQrb1dpk Q2smu2rO+ia4u6aKSIIY7k5SwU+dHnmsrUJOUJz42ARUMGD+i1S6AnXeCBpnUDDA== X-Google-Smtp-Source: AGHT+IENQjN/CUYsH9VFFm4pVHWkRuMc9LBZvX1RWDo3Xnsvi+JcACMpM7wNhoU7fWK1Lo5cRQfMcA== X-Received: by 2002:a05:651c:1586:b0:36b:5945:d3e8 with SMTP id 38308e7fff4ca-3779796dc35mr16004461fa.39.1760731254333; Fri, 17 Oct 2025 13:00:54 -0700 (PDT) Received: from [192.168.1.244] (public-nat-13.vpngate.v4.open.ad.jp. [219.100.37.245]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-377a921d99bsm1580861fa.22.2025.10.17.13.00.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 13:00:54 -0700 (PDT) From: Vladimir Lypak Date: Fri, 17 Oct 2025 19:58:38 +0000 Subject: [PATCH 4/6] drm/msm/dpu: Fix pixel extension sub-sampling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251017-b4-dpu-fixes-v1-4-40ce5993eeb6@gmail.com> References: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> In-Reply-To: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Kalyan Thota , Vinod Polimera , Konrad Dybcio , =?utf-8?q?Barnab=C3=A1s_Cz=C3=A9m=C3=A1n?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Vladimir Lypak X-Mailer: b4 0.14.2 In _dpu_plane_setup_pixel_ext function instead of dividing just chroma source resolution once (component 1 and 2), second component is divided once more because src_w and src_h variable is reused between iterations. Third component receives wrong source resolution too (from component 2). To fix this introduce temporary variables for each iteration. Fixes: dabfdd89eaa9 ("drm/msm/disp/dpu1: add inline rotation support for sc= 7280") Signed-off-by: Vladimir Lypak Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/ms= m/disp/dpu1/dpu_plane.c index 6effe0fa4837284a1f038e4907c4c91d239aeb8b..905524ceeb1f192c093f1be7f57= 1b29eb4b53379 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c @@ -500,13 +500,15 @@ static void _dpu_plane_setup_pixel_ext(struct dpu_hw_= scaler3_cfg *scale_cfg, int i; =20 for (i =3D 0; i < DPU_MAX_PLANES; i++) { + uint32_t w =3D src_w, h =3D src_h; + if (i =3D=3D DPU_SSPP_COMP_1_2 || i =3D=3D DPU_SSPP_COMP_2) { - src_w /=3D chroma_subsmpl_h; - src_h /=3D chroma_subsmpl_v; + w /=3D chroma_subsmpl_h; + h /=3D chroma_subsmpl_v; } =20 - pixel_ext->num_ext_pxls_top[i] =3D src_h; - pixel_ext->num_ext_pxls_left[i] =3D src_w; + pixel_ext->num_ext_pxls_top[i] =3D h; + pixel_ext->num_ext_pxls_left[i] =3D w; } } =20 --=20 2.51.0 From nobody Sun Feb 8 00:11:26 2026 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B45614F125 for ; Fri, 17 Oct 2025 20:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731273; cv=none; b=uXqc71pQlAfIVwaXvhV3xNr/XiJbHG7h1LXtwOEOPQlsIyL/xYNDS2j3aklR/rhFq2x0kC9I+3Ni6jxl1WZU2Kyz173HoH2cXl4BEdeomOZPIZHz8CcQpUVtpM+WqAEbqIbo+VgPmshDmmxaDNYxNnf4ZNVkTDtF0tXHpyfOymU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760731273; c=relaxed/simple; bh=K2ZJWWVPxcS3Zb+xMa4QB2/1GTr41KU5/gINSseGrdA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mJ11ReBgQqpR1W0lMoJqmnEkwDMkS2/Ww7cXBqzNYOeROvzZJr0gz2a8OHW1ORfbn0DEQDWeMTzdVqSD0E3e7HeOZ2LdnpyxTUFqjXLwOD9MQLB+pBiPTPGs/ELwmG0cGmB19aKd35r/UVndRag8Dc1rtaXbZqhmOaWsDauDC0o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bXC6HAQl; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bXC6HAQl" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-375ff2b3ba4so24313261fa.0 for ; Fri, 17 Oct 2025 13:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760731270; x=1761336070; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZvamalkucLTXF0UtA58TBlyJrhax3HxRIT0v5R1YbAI=; b=bXC6HAQlCEI2dbevg0C4d1K4kgdW6/cSzS0y3dR1/ieHdkFq5QtxOAAEOpqvO4UtcJ U12jQRuyu8/p4RvrQxJCk85Ze3b/hPPyExOMTNjhk5Rl7KPZ0SULlHz2ivd8rz2m9IVl opyN28g53EtRTqjbpL6+/OsyWkChNkn50I3zDMbNtevJLvra7iSEJ/xmerUoURrSsBBp htO7X0w6LhRRoi26YUVv21ydFJvS1eFWoZBNpHrNIJyVO9umC+++Hg1oqaomQhI5vC5j EZtY58NdHAGydXX8O0YqXMBahVuyhe8UBEk/bTv8XdFEZJ5UniU3R0HKdCOHlkZFiuPP jlZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760731270; x=1761336070; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZvamalkucLTXF0UtA58TBlyJrhax3HxRIT0v5R1YbAI=; b=Ho5OsFUfWJ4BxSqHgPM05jaSqS4+QWBxYBj03OuXXetQe7fEl2XS1m0OiODF/SvEm2 ilyyz3pZZma651ULGVp3ajqywMeNqPey+XkYbRbGk1tHqFw5P18y/tiCU93l2j78n5Ov gWwxq366IOxXZA4PFPk8FwhP595CO6eq2iO5sdCXDRGx3RgoEVr1qp56OtCTvTCcmEra +BhfqSXzo/TGRrQJ4hd/sBWW6rEdQhkFSZzgZ4i0dHuG0dGOn78TU/PE/Ci/0Foh27zX OTGsrH2tGEzJpRrh3pekwh86F8Gj7wFtCM0dGUt0ragj83gLf4z1RRPtVkqLLUtj8ma/ dXWQ== X-Forwarded-Encrypted: i=1; AJvYcCWoka6oabb+OHJ+sp9OLP3OhInv8dXeOYBxACH3PNjGWngF9li61UGLTs+XQT+9R39hLqt4K4v7F0xz7Cc=@vger.kernel.org X-Gm-Message-State: AOJu0Yym/8P4CqaQSI8FvQvG8CuYByOjVzvav3KZ+/L865O+tgqDI5Hg mgrEjUD6gKRlh/9J1Y4aZIowqqrcNbJfibsiuk2EyRu44gFDlxoj4N+x X-Gm-Gg: ASbGncvr5u4McxQOieSMRwdC6rIO7OiHThlH0gZD4ZlG8gIJ55YmYx0HWBtZbJJhQJH qlZaTEniAH+b972O6SxRYxIjGCyZsLkRY0a5qe6WtWSv8dFeMWhvCBEq0dvyvunJEiTMl7an0oV zIavRiJuu8OPsqir8aRVLnCGW6604Si+SF/9Fmu/d9JxBMEYnWip1/6mXH121mSlickEeHnMzdv CVExoZvL+O64wJCzJhMcNjJGk4XxJ4KCFzQY7FzUULk28G+wU7PWW4ihvT9up/jp4Mh16KPFAfR Rdf2zqeML2kt8jKX3yLHC/2M5mdwcT1fiWpvPB4AtWnoVbo6W/VcpOcNEuzwiMn2sde/toQtJwe s3YriucZWfskyb+xURVpLmNl9hkwxe82YFesDj3lo/sKzRUBV9uXfPJFlOHGc/PCOd7jSXpjSTm L9jPVFW26NLgrLdmGpMnJ0km/3ZtiGNwwrWnvVsOyl7rZBWosquxOJUDphpiQyxA== X-Google-Smtp-Source: AGHT+IGGkPzUg9+WLDnfzSVIMAOLQOKXgwa2ttL1tbW7RtbDwguoGHJ6HNdyipMTINLcvQ/30wWafQ== X-Received: by 2002:a2e:a583:0:b0:35f:246:a751 with SMTP id 38308e7fff4ca-3779781d39emr17282741fa.5.1760731270001; Fri, 17 Oct 2025 13:01:10 -0700 (PDT) Received: from [192.168.1.244] (public-nat-13.vpngate.v4.open.ad.jp. [219.100.37.245]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-377a921d99bsm1580861fa.22.2025.10.17.13.00.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 13:01:09 -0700 (PDT) From: Vladimir Lypak Date: Fri, 17 Oct 2025 19:58:39 +0000 Subject: [PATCH 5/6] drm/msm/dpu: Require linear modifier for writeback framebuffers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251017-b4-dpu-fixes-v1-5-40ce5993eeb6@gmail.com> References: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> In-Reply-To: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Kalyan Thota , Vinod Polimera , Konrad Dybcio , =?utf-8?q?Barnab=C3=A1s_Cz=C3=A9m=C3=A1n?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Vladimir Lypak X-Mailer: b4 0.14.2 UBWC-related register configuration for writeback is not implemented in the driver yet but there aren't any checks for non-linear modifiers in atomic_check. Thus when compressed framebuffer is attached to writeback connector it will be filled with linear image data. This patch forbids non-linear modifiers for writeback framebuffers until UBWC support for writeback is properly implemented. Fixes: 71174f362d67 ("drm/msm/dpu: move writeback's atomic_check to dpu_wri= teback.c") Signed-off-by: Vladimir Lypak Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/dr= m/msm/disp/dpu1/dpu_writeback.c index cd73468e369a93c50303db2a7d4499bcb17be5d1..7545c0293efbd8f7eb34a4ac56f= 616b7cadae1c0 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c @@ -72,6 +72,9 @@ static int dpu_wb_conn_atomic_check(struct drm_connector = *connector, DPU_ERROR("invalid fb w=3D%d, maxlinewidth=3D%u\n", fb->width, dpu_wb_conn->maxlinewidth); return -EINVAL; + } else if (fb->modifier !=3D DRM_FORMAT_MOD_LINEAR) { + DPU_ERROR("unsupported fb modifier:%#llx\n", fb->modifier); + return -EINVAL; } =20 return drm_atomic_helper_check_wb_connector_state(conn_state->connector, = conn_state->state); --=20 2.51.0 From nobody Sun Feb 8 00:11:26 2026 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E37FD354AEE for ; Sat, 18 Oct 2025 15:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760801606; cv=none; b=kJNHIS8bijsLuUmsR6T0P/fFg0G6FpGe59RCeKmGt7RuEzQ0cWfCdSm+1BCmNT68bgfL+/RUBGWIZXzMw/aC0WuYB2CBQzfJw+xXoC9XmWG+E5GhZZ2+xO1W9C5m0B+dnzn6/7Z8UVwQ7n/sTkW4ydbULJyURh4tjansNERXI9U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760801606; c=relaxed/simple; bh=Qc5FDyxe5YWtLm0XuQFXvXeE2CU4zdKg88u3qvubN2Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q7U2jK9K2tyCIixpRbgtEZIFAdS6U/IXJQbG6kaBRtGiHdUW3L2Nr9Xq6RctAb93ZDSj+gDzZLB4CMx4HPL88fKuByEMoYtn9Gp5Kpf3vlTJjZLvrWcqbqZTpcVRcF1pnpD9G8S3sBHWYE7Af3mNa5Gm4iRNxytogMnmZ2x5YSU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qz2XzfAx; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qz2XzfAx" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-58affa66f2bso3583249e87.1 for ; Sat, 18 Oct 2025 08:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760801603; x=1761406403; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JI8wqflBoJeSVeIoguEa5qYxvXUp8LZtN2UpxTSv8wU=; b=Qz2XzfAxHxhw/R0P99YCKttOMDBl4ikZHNa+7AUDea64Y2/0DjgCp3UG4avEurdW68 DjX4aBuM0HkYO/fW+3ITsZ2gLfoApRLoj32FO255H9J+rgdLb/6rl+vF0aAy2qd/VtOj HXh+xjADbCDf+WLkQaZIiiElRLTmD4aeG+Az+KJzwrA0PyAuulxlZuZ/q5dln6Ea8L9Y jv/xo+8z2r3ztbRQAmoXxqvhwnG+z7q6yoDN5EsT/buxvNLjJpGlPHl1gsdeocfkQA/u 6K3YKa9gTA4o1kI90yBAusyCBbmtgPOnKck7h5j47Fi46sz71bguYzpw3Qj0ulfUa4Bx LKVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760801603; x=1761406403; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JI8wqflBoJeSVeIoguEa5qYxvXUp8LZtN2UpxTSv8wU=; b=KfV5ibRv9QF4gngel25JH7O6uSePoT0grvHOBJ/mJU6bPfyYOy3HtLcphjfRZu3Onx /eXGtVZ50zoiieM3ARTefii8uzKLyUCFkVURIcqdfYFiZChIDPaiAzL2OsbglvFGTqeY Bqfl7fJgRwp24/asMj+aXdv1bhnUbq60KmQAKWd2oGLG4apBrrao8ZCBti/I/XfQHMXe Lt4dxJ31HhzQMaflKyWwi8p1b9cyTN9rwYhvjxrvhCPf4XkbTtL82NoEORQc+cr+iepl n7b85D8xP7fGB239winT4FS1uBmsRBiuBUwsVFtJDLmrB48tw/TGPEsWrISJcLs09uLU pAig== X-Forwarded-Encrypted: i=1; AJvYcCV+p4BwEW91D5UHrxukfoEsTs6vcuAbqemUr0/hadjA/ZI899Re5Y91OfB7seR43nwzsJtQK4j7tH7VkmI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/diCsPS710aTBNZ7hSQz8mP8zf6G5TDg02bXHvxYJIhfhzZmT DTcMZnNMaTC9W47fPCwwlR+yTaQejn6chBcr3+rPfmHYx9HI91hU2oTF X-Gm-Gg: ASbGnctMZFMpwvwN2i22DVXSwa52e2/OSy3bw/d4FNrSNdgMSFSfPOXQ7sQzmVvw2TT FOGsZUNp4cOEUDKwXV8B9+Zb2OpQINiZ1/CIU7m7NnRd7Xa6XpyNmltmHdVxVKmYzsZYe52ShNO DQDIDE/12Ss6pUdAoWXD/fdSnt2WfPNXe9U02lCGVdhAKMHlg2034JV2knYhVAmTXbB9ixXylbi BN/Z9BwTiKTeER+Tun1Y0GHdfPJOpeXvodWk4Jde9afKC4/mr2JgbkUDH2u2hgC3/C4vdbjL/lj n1rsuxzCvsSdwbt3H4S6nnfrUNZvHFgoKnn2epY5UOVdZc9RXpFuLgpfMcX7tM+091RtEuMerE3 6zYIHxCMOJfrPZVcbqAn/KLDCq+p1ooZQSqFF8R5nJN7PC7LrnrZlxM/Uc6fTJMwuaZFnTI9HUP gPlQrPcChydWQjm/dm4pPahBLuKHwGhaQZx2QFpOsVzG6e+Dygn+iUuM2BYDwEK5qq X-Google-Smtp-Source: AGHT+IHNJGLhJHT1HKOGPxf4DSdDJIV4Mlmc7c1/MsjKbF5l/T+nMmFrzXfeEG2XR7zYb9PwANEW8w== X-Received: by 2002:a05:6512:1154:b0:591:c379:69d0 with SMTP id 2adb3069b0e04-591d850d2e6mr2429125e87.5.1760801602965; Sat, 18 Oct 2025 08:33:22 -0700 (PDT) Received: from localhost (public-nat-13.vpngate.v4.open.ad.jp. [219.100.37.245]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-591def272d0sm836014e87.108.2025.10.18.08.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Oct 2025 08:33:22 -0700 (PDT) From: Vladimir Lypak Date: Sat, 18 Oct 2025 14:33:43 +0000 Subject: [PATCH 6/6] drm/msm/dpu: Disable broken YUV on QSEED2 hardware Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251018-b4-dpu-fixes-v1-6-1852278064d0@gmail.com> References: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> In-Reply-To: <20251017-b4-dpu-fixes-v1-0-40ce5993eeb6@gmail.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Kalyan Thota , Vinod Polimera , Konrad Dybcio , =?utf-8?q?Barnab=C3=A1s_Cz=C3=A9m=C3=A1n?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Vladimir Lypak X-Mailer: b4 0.14.2 YUV formats on this hardware needs scaling for chroma planes. However it is not implemented for QSEED2 which breaks display pipeline if YUV format is used (causing partial and corrupted output with PPDONE timeouts). This patch temporarily disables YUV by switching affected sub-block to RGB only format list. Fixes: daf9a92daeb8 ("drm/msm/dpu: Add support for MSM8996") Signed-off-by: Vladimir Lypak Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/d= rm/msm/disp/dpu1/dpu_hw_catalog.c index 6641455c4ec6a2d082644f1488ea5f5605ccc208..9f8d1bba9139a7e09ee321cf1b6= f30f96890918f 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c @@ -267,8 +267,8 @@ static const u32 wb2_formats_rgb_yuv[] =3D { .base =3D 0x200, .len =3D 0xa0,}, \ .csc_blk =3D {.name =3D "csc", \ .base =3D 0x320, .len =3D 0x100,}, \ - .format_list =3D plane_formats_yuv, \ - .num_formats =3D ARRAY_SIZE(plane_formats_yuv), \ + .format_list =3D plane_formats, \ + .num_formats =3D ARRAY_SIZE(plane_formats), \ .rotation_cfg =3D NULL, \ } =20 --=20 2.51.0