From nobody Sat Feb 7 19:41:22 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7CDD32D0F2 for ; Thu, 16 Oct 2025 16:15:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760631302; cv=none; b=uGXYNFKKuDebUk75H3h9sl4+XVwJrJlRVp62T5lzfZWaPv8EmV/vAdCaa6Vff4xAOL2ll71y7JOfZowywPG8Y6WNnTJSmc1hB2auI9lVhZeabMLtJJLi/RVOeIcSsQRiJV7LZqKFt0BDurzWNiW0ocZwYalI60iKVL6prQdBH6U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760631302; c=relaxed/simple; bh=CAhmlVpNgjfXOj8lSkUQjgUpSSdRvC/yRyLgyFGBUv4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s+fvrgTO7/EVfpoADIGsGyA1G4X1yKMpJsFl40Pt3Ev1ze/BI6zOjzBhPHptBqf+GRG6ylVn/Id36GhC3Q4k6dktR73isAQ86vRNPPWKLZIatQdRjNlub4b9ZOGiACkvkvEznAZbS/mfldjexkdrxDEF09S0sNPsuYe8MsyyxHs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CfmYPOQu; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CfmYPOQu" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47109187c32so5234305e9.2 for ; Thu, 16 Oct 2025 09:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760631299; x=1761236099; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XsjCaRuVjABsOrX7YYvRpKJqzHL0cubRF6Hom6jKdNU=; b=CfmYPOQuAikafPBC05CFasy6cKk0kmj8+cef0TVGMdrsoPsrO0qJKYOqoGGBptXVWQ xhc+HlvAE1pMqbG5viZwR6993tMi1d/MNUmIopfNA6RgesglzF4NdfdwzsA5t1fAyzSH BK7YC5k+0Yf6thHzt+LxGv4+S9ncoxwwWfcrsz/upX71PX52O7WDSAtNZQsZEohnKw2M z2Z3kQ95nMdeekoBC1/yo2BGKOQGQUfHWrAi+A4RAOjrIMZqBPVAatyLkzF5ncmVic9U w6Ey/9nGIk2sp4pbRUNTV6WkDNW2e0ZnZAWS81VkyVzf6fPF+K4q5zqv/ezDCcN7/WMf zDVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760631299; x=1761236099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XsjCaRuVjABsOrX7YYvRpKJqzHL0cubRF6Hom6jKdNU=; b=I0ejXO5VEN5j2vzFy5ADV120DgsUtOrUSTH/Bwwuxq3mLmwGWvT5mfP7U/5nM+Pwau N031yORAhh/YtNIp0NOxSy2RjDh4Khj3HPfw/zcNPI6BqVqi+aFNm2G6rA+Aae+nnWQF eP8TrMesthtQt9pZylgOzQsdlyax7cGje8I4QYVr2lterSvSq6ie23jPrVaBqkmCYVHM 8Qbwea1je6Byj9W8R6KYtKYO1/fFJ6n7dVhxt13UzCUtBSqfo9KHgUB5saEH7R+Tsrao mtry2Twm/hXoXcDbCOG5C4GFBb5U+sE8SQT3hWS3wwKUBsWEyCUvSQDxP/GlWwyvxL00 LRkQ== X-Forwarded-Encrypted: i=1; AJvYcCVIUG7rtH/6U/NkJlcLSzZgLlFJ1LEaLmBlKgTlYVxOVkuyT5tCI7WMsduyEwB0zIGnCLFuUnVVNXVBHdQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxVkQSyUJMDHXAMyqkzOA1xafTWuSfGwY+ggm0ifZiVzoWnrYWf bsimx177RqhVZdeQFP00u6A3gNVMsncyPtSahsMOVdTGKhX5bxWZXDoZ X-Gm-Gg: ASbGncuzW5E6wrQUhwlhjW0yBB8lof+bhSLWmEvbAgqW8No1ZRxeHGsCMb5+j4yiqfJ Xuhfw7djA4ULgtZQVOtpKsvybb1HwvodxPtVxpzlyWx/EaosBsLSj2+xfeb32riGjNLbd/fvCHy MHPaMwf+Ge+bEE7ig/xvOCxSzWjO0S7bLnoxUTb3SUn4tK3J2vGl5cIe0r01ZPEiJG7kPq0GIu/ XW6VvnssKo8DGsdKGx0tU+8CQfYDhy8hPX8PImKm72Jsvbl+rryN+zEBJtcLhAlDRk0hQXLk535 R8smiFlyjMUai/xq6r2wSuIK5SJnU+Guj3Z2hWcrOxPkfvU273+Wta7Fx+jl4xMGyFPCw6s9cut pi/EfJ7NRRECbIijaJyupJvZ7U3xsejFlwDSBl6LmU46RXqHVQMnkmE+DNBJJJM3QaBZ5N+hACQ Je3soU3g== X-Google-Smtp-Source: AGHT+IEKty8nwgNyyjLYDrrm1byKY80JX1Lr6PPCNGTkEJg3G1LBRa0WdrhWOustfFNHSRExFFdAew== X-Received: by 2002:a05:600c:4710:b0:471:115e:9605 with SMTP id 5b1f17b1804b1-4711791fc13mr4177695e9.35.1760631298908; Thu, 16 Oct 2025 09:14:58 -0700 (PDT) Received: from hangmanPC.. ([86.124.201.90]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-471143663afsm35654025e9.0.2025.10.16.09.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Oct 2025 09:14:58 -0700 (PDT) From: Cezar Chiru To: wsa+renesas@sang-engineering.com, andi.shyti@kernel.org Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Cezar Chiru Subject: [PATCH v6 1/3] i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c Date: Thu, 16 Oct 2025 19:14:15 +0300 Message-ID: <20251016161417.15545-2-chiru.cezar.89@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251016161417.15545-1-chiru.cezar.89@gmail.com> References: <20250926154520.40583-1-chiru.cezar.89@gmail.com> <20251016161417.15545-1-chiru.cezar.89@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove debug macros and printk and dev_debg function calls from file as no change was done for 16 years. Request by I2C SUBSYSTEM maintainer Wolfram Sang. Signed-off-by: Cezar Chiru --- drivers/i2c/algos/i2c-algo-pcf.c | 59 -------------------------------- 1 file changed, 59 deletions(-) diff --git a/drivers/i2c/algos/i2c-algo-pcf.c b/drivers/i2c/algos/i2c-algo-= pcf.c index fd563e845d4b..7e2d8ff33d75 100644 --- a/drivers/i2c/algos/i2c-algo-pcf.c +++ b/drivers/i2c/algos/i2c-algo-pcf.c @@ -23,17 +23,8 @@ #include "i2c-algo-pcf.h" =20 =20 -#define DEB2(x) if (i2c_debug >=3D 2) x -#define DEB3(x) if (i2c_debug >=3D 3) x /* print several statistical value= s */ -#define DEBPROTO(x) if (i2c_debug >=3D 9) x; - /* debug the protocol by showing transferred bits */ #define DEF_TIMEOUT 16 =20 -/* - * module parameters: - */ -static int i2c_debug; - /* setting states on the bus with the right timing: */ =20 #define set_pcf(adap, ctl, val) adap->setpcf(adap->data, ctl, val) @@ -47,27 +38,21 @@ static int i2c_debug; =20 static void i2c_start(struct i2c_algo_pcf_data *adap) { - DEBPROTO(printk(KERN_DEBUG "S ")); set_pcf(adap, 1, I2C_PCF_START); } =20 static void i2c_repstart(struct i2c_algo_pcf_data *adap) { - DEBPROTO(printk(" Sr ")); set_pcf(adap, 1, I2C_PCF_REPSTART); } =20 static void i2c_stop(struct i2c_algo_pcf_data *adap) { - DEBPROTO(printk("P\n")); set_pcf(adap, 1, I2C_PCF_STOP); } =20 static void handle_lab(struct i2c_algo_pcf_data *adap, const int *status) { - DEB2(printk(KERN_INFO - "i2c-algo-pcf.o: lost arbitration (CSR 0x%02x)\n", - *status)); /* * Cleanup from LAB -- reset and enable ESO. * This resets the PCF8584; since we've lost the bus, no @@ -88,9 +73,6 @@ static void handle_lab(struct i2c_algo_pcf_data *adap, co= nst int *status) if (adap->lab_mdelay) mdelay(adap->lab_mdelay); =20 - DEB2(printk(KERN_INFO - "i2c-algo-pcf.o: reset LAB condition (CSR 0x%02x)\n", - get_pcf(adap, 1))); } =20 static int wait_for_bb(struct i2c_algo_pcf_data *adap) @@ -151,9 +133,6 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *ada= p) { unsigned char temp; =20 - DEB3(printk(KERN_DEBUG "i2c-algo-pcf.o: PCF state 0x%02x\n", - get_pcf(adap, 1))); - /* S1=3D0x80: S0 selected, serial interface off */ set_pcf(adap, 1, I2C_PCF_PIN); /* @@ -161,7 +140,6 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *ada= p) * PCF8584 does that when ESO is zero */ if (((temp =3D get_pcf(adap, 1)) & 0x7f) !=3D (0)) { - DEB2(printk(KERN_ERR "i2c-algo-pcf.o: PCF detection failed -- can't sele= ct S0 (0x%02x).\n", temp)); return -ENXIO; /* definitely not PCF8584 */ } =20 @@ -169,7 +147,6 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *ada= p) i2c_outb(adap, get_own(adap)); /* check it's really written */ if ((temp =3D i2c_inb(adap)) !=3D get_own(adap)) { - DEB2(printk(KERN_ERR "i2c-algo-pcf.o: PCF detection failed -- can't set = S0 (0x%02x).\n", temp)); return -ENXIO; } =20 @@ -177,7 +154,6 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *ada= p) set_pcf(adap, 1, I2C_PCF_PIN | I2C_PCF_ES1); /* check to see S2 now selected */ if (((temp =3D get_pcf(adap, 1)) & 0x7f) !=3D I2C_PCF_ES1) { - DEB2(printk(KERN_ERR "i2c-algo-pcf.o: PCF detection failed -- can't sele= ct S2 (0x%02x).\n", temp)); return -ENXIO; } =20 @@ -185,7 +161,6 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *ada= p) i2c_outb(adap, get_clock(adap)); /* check it's really written, the only 5 lowest bits does matter */ if (((temp =3D i2c_inb(adap)) & 0x1f) !=3D get_clock(adap)) { - DEB2(printk(KERN_ERR "i2c-algo-pcf.o: PCF detection failed -- can't set = S2 (0x%02x).\n", temp)); return -ENXIO; } =20 @@ -194,7 +169,6 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *ada= p) =20 /* check to see PCF is really idled and we can access status register */ if ((temp =3D get_pcf(adap, 1)) !=3D (I2C_PCF_PIN | I2C_PCF_BB)) { - DEB2(printk(KERN_ERR "i2c-algo-pcf.o: PCF detection failed -- can't sele= ct S1` (0x%02x).\n", temp)); return -ENXIO; } =20 @@ -210,8 +184,6 @@ static int pcf_sendbytes(struct i2c_adapter *i2c_adap, = const char *buf, int wrcount, status, timeout; =20 for (wrcount=3D0; wrcountdev, "i2c_write: writing %2.2X\n", - buf[wrcount] & 0xff)); i2c_outb(adap, buf[wrcount]); timeout =3D wait_for_pin(adap, &status); if (timeout) { @@ -307,8 +279,6 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, /* Check for bus busy */ timeout =3D wait_for_bb(adap); if (timeout) { - DEB2(printk(KERN_ERR "i2c-algo-pcf.o: " - "Timeout waiting for BB in pcf_xfer\n");) i =3D -EIO; goto out; } @@ -316,10 +286,6 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, for (i =3D 0;ret >=3D 0 && i < num; i++) { pmsg =3D &msgs[i]; =20 - DEB2(printk(KERN_DEBUG "i2c-algo-pcf.o: Doing %s %d bytes to 0x%02x - %d= of %d messages\n", - str_read_write(pmsg->flags & I2C_M_RD), - pmsg->len, pmsg->addr, i + 1, num);) - ret =3D pcf_doAddress(adap, pmsg); =20 /* Send START */ @@ -335,8 +301,6 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, goto out; } i2c_stop(adap); - DEB2(printk(KERN_ERR "i2c-algo-pcf.o: Timeout waiting " - "for PIN(1) in pcf_xfer\n");) i =3D -EREMOTEIO; goto out; } @@ -344,34 +308,17 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, /* Check LRB (last rcvd bit - slave ack) */ if (status & I2C_PCF_LRB) { i2c_stop(adap); - DEB2(printk(KERN_ERR "i2c-algo-pcf.o: No LRB(1) in pcf_xfer\n");) i =3D -EREMOTEIO; goto out; } =20 - DEB3(printk(KERN_DEBUG "i2c-algo-pcf.o: Msg %d, addr=3D0x%x, flags=3D0x%= x, len=3D%d\n", - i, msgs[i].addr, msgs[i].flags, msgs[i].len);) =20 if (pmsg->flags & I2C_M_RD) { ret =3D pcf_readbytes(i2c_adap, pmsg->buf, pmsg->len, (i + 1 =3D=3D num)); - - if (ret !=3D pmsg->len) { - DEB2(printk(KERN_DEBUG "i2c-algo-pcf.o: fail: " - "only read %d bytes.\n",ret)); - } else { - DEB2(printk(KERN_DEBUG "i2c-algo-pcf.o: read %d bytes.\n",ret)); - } } else { ret =3D pcf_sendbytes(i2c_adap, pmsg->buf, pmsg->len, (i + 1 =3D=3D num)); - - if (ret !=3D pmsg->len) { - DEB2(printk(KERN_DEBUG "i2c-algo-pcf.o: fail: " - "only wrote %d bytes.\n",ret)); - } else { - DEB2(printk(KERN_DEBUG "i2c-algo-pcf.o: wrote %d bytes.\n",ret)); - } } } =20 @@ -401,8 +348,6 @@ int i2c_pcf_add_bus(struct i2c_adapter *adap) struct i2c_algo_pcf_data *pcf_adap =3D adap->algo_data; int rval; =20 - DEB2(dev_dbg(&adap->dev, "hw routines registered.\n")); - /* register new adapter to i2c module... */ adap->algo =3D &pcf_algo; =20 @@ -418,7 +363,3 @@ EXPORT_SYMBOL(i2c_pcf_add_bus); MODULE_AUTHOR("Hans Berglund "); MODULE_DESCRIPTION("I2C-Bus PCF8584 algorithm"); MODULE_LICENSE("GPL"); - -module_param(i2c_debug, int, S_IRUGO | S_IWUSR); -MODULE_PARM_DESC(i2c_debug, - "debug level - 0 off; 1 normal; 2,3 more verbose; 9 pcf-protocol"); --=20 2.43.0 From nobody Sat Feb 7 19:41:22 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8E5B23EABC for ; Thu, 16 Oct 2025 16:15:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760631309; cv=none; b=ekmSgncUuPmUnpBBsoEufXiXR1RYtJaqpmLKEoh1u9aDdfv36Z/yunudzP8UwRvpSZVIbLIuv03bZ+2gFLIUsfugM1vbdvEy3vfmFO898H+9vATp3a3xOd8yOBiBvb+HvK5i/L6s9NQpJR/wR7cNl+xVOfeSZQzgRGQakFWHIOU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760631309; c=relaxed/simple; bh=LHZjH2UMXa92SxXhNcHHvMGpkdxmO+gWMcsE10ROlWg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X5SFScDI+IGIm3OiZOAjQlX/YqYJIxUmrMovnXFkgcdgrld7bRpHriF1G+/s9k4DBx6D/LiyLpwvpMSSVLNPsyXsyxOOvi9eUT9MwzBYP70xqp+3EbWWLRNhFJZ3HTCgnTpyij08PPMDGGAXZn/WXtnZSstg8et7qS2Iupt/OBA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EICEMrVV; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EICEMrVV" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47114a40161so8033055e9.3 for ; Thu, 16 Oct 2025 09:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760631306; x=1761236106; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XH2k5qkD7Z3u1A48Y16IYSnGNDzLTVrlHvL80g4n3eU=; b=EICEMrVVqwZijQMAW2fbczanNC5lCvGCBwU1YjZqYr196Hrc3ejTd1dKfJ9xhev1hd ElmtGDTyhrL+y5LZnW4ld0tLEjDXVDNknyI69fLXDkUYpGeafUUsU5j5YF0PF77Spd/W SqwQOYYNYGF9VqpPvmqakUuXbGfg1iWfEr65bxFwwi572RkADTEhvjRdTINq8RR1ah5m +itsH0X1eMSqA6xCjFHWEuRwke2CNr7BHZTd7/qd0/7RStJnnjg0keTJ2eZMfFLiU0V0 dDw3ib05GgRhmUXQS9Y4tkFpugBV7GmMDugzj7di3zQ8J3/YD0qltc762bkt7nmi8sKF RfFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760631306; x=1761236106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XH2k5qkD7Z3u1A48Y16IYSnGNDzLTVrlHvL80g4n3eU=; b=tp6ZD6CcSn4xJle5irXwi6RBRev5I2E1ZtXbWrEm/eZHYO/KQHYL6SlKNEV/pqTpuG SrvjVbFLftO+cRr6rQVPzZAvuEdTBA9Ibj7l4hVd+H/TwTOmj/qUQdLaHfEDxgqxXfTk SWHH3/56aWyEdXWB6bFgp6b7ZK25wxM8TWfMOJSxMFSs4ogRZH4Ripu/mJXFjPA2Lnai 1DP417JAEdu4D/+3P9aLPsegElXQDxCcMTnImyb/2JpcepVjRII86qB3TeInm8R3Dl6v tNIt2aGnPecVCDGt+fabrv54rm8JJwqNUbtT1AQmJX66lETPltTN2CpzANS1TB4Verp0 jQWA== X-Forwarded-Encrypted: i=1; AJvYcCUTSbyGIVL37bizo/bIARP/4rDnXs1Cw47A+VBm5ZqxxBiWVKYFyLLF2mf2eyj9JQ5InSRr74jNXHwoZJs=@vger.kernel.org X-Gm-Message-State: AOJu0YxSTe1zSmVGbmBbhwEUM/RmZUr7tGnGqHNV+1Mjgjuq1HivVVdL JZsI52CCQDHcTpZg3eWGtmOqNyBV7kcz9Wxe9nXwK03CXF/w3nYW97eftTlsKA== X-Gm-Gg: ASbGncszUoGk7aEC8xfsdh4OyAhceSso5IGzqFoTOdf1fnMSrlYHCSlCMXG6ShEMSWP mETyg7sDOtwf5D3NDAH+d8mJPgOtlgbevrIEKzMJvldo4qMjgd5LCbSX9TX34b+iPkyCLIplRJs 4eenTolnHQpZZKsfHHSmVXPznD90dDwbCLg1uRUf4VhNStWM9/N07cA+xzUyjGPXNcoRRcrkkGq /aJUj1HUsTXidd3ZdAaqTuIn8bU45xu8ibL4DGey6dOEuvSu4AaIWE3s6npSRyR80TCl4pGLT9A /xkexIVBnFQPXhHxNocLA1LYpldiTH12zpLUzDKKtWzEdhkiQ+G45POHiWId6SB56ROlO8Di0H+ I9IYDuclE21792mSkGkinazqjbUiywgApVkW4/FOBxQ5zfgYfJjx3cPIFggJcIlh/2qdKX2gf6C isXZuhqg== X-Google-Smtp-Source: AGHT+IG3rVGmDp5olNfg9dU57+0wldzU8oxoJTE26xYya7QDoKqMwVqjPrv0UHx0OszQgqPF83LVow== X-Received: by 2002:a05:600c:19d4:b0:45d:5c71:769a with SMTP id 5b1f17b1804b1-47117903e2amr4046915e9.26.1760631305709; Thu, 16 Oct 2025 09:15:05 -0700 (PDT) Received: from hangmanPC.. ([86.124.201.90]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-471143663afsm35654025e9.0.2025.10.16.09.15.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Oct 2025 09:15:05 -0700 (PDT) From: Cezar Chiru To: wsa+renesas@sang-engineering.com, andi.shyti@kernel.org Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Cezar Chiru Subject: [PATCH v6 2/3] i2c: pcf8584: Fix do not use assignment inside if conditional Date: Thu, 16 Oct 2025 19:14:16 +0300 Message-ID: <20251016161417.15545-3-chiru.cezar.89@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251016161417.15545-1-chiru.cezar.89@gmail.com> References: <20250926154520.40583-1-chiru.cezar.89@gmail.com> <20251016161417.15545-1-chiru.cezar.89@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Assign inside of 'if' conditional is not allowed. Move assignment from inside 'if' conditional, to one line before each 'if'conditional statement that caused errors. Enforce errors fixing based on checkpatch.pl output on file. Signed-off-by: Cezar Chiru --- drivers/i2c/algos/i2c-algo-pcf.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/i2c/algos/i2c-algo-pcf.c b/drivers/i2c/algos/i2c-algo-= pcf.c index 7e2d8ff33d75..41a81d37e880 100644 --- a/drivers/i2c/algos/i2c-algo-pcf.c +++ b/drivers/i2c/algos/i2c-algo-pcf.c @@ -129,7 +129,7 @@ static int wait_for_pin(struct i2c_algo_pcf_data *adap,= int *status) * * vdovikin: added detect code for PCF8584 */ -static int pcf_init_8584 (struct i2c_algo_pcf_data *adap) +static int pcf_init_8584(struct i2c_algo_pcf_data *adap) { unsigned char temp; =20 @@ -139,38 +139,38 @@ static int pcf_init_8584 (struct i2c_algo_pcf_data *a= dap) * check to see S1 now used as R/W ctrl - * PCF8584 does that when ESO is zero */ - if (((temp =3D get_pcf(adap, 1)) & 0x7f) !=3D (0)) { + temp =3D get_pcf(adap, 1); + if ((temp & 0x7f) !=3D 0) return -ENXIO; /* definitely not PCF8584 */ - } =20 /* load own address in S0, effective address is (own << 1) */ i2c_outb(adap, get_own(adap)); /* check it's really written */ - if ((temp =3D i2c_inb(adap)) !=3D get_own(adap)) { + temp =3D i2c_inb(adap); + if (temp !=3D get_own(adap)) return -ENXIO; - } =20 /* S1=3D0xA0, next byte in S2 */ set_pcf(adap, 1, I2C_PCF_PIN | I2C_PCF_ES1); /* check to see S2 now selected */ - if (((temp =3D get_pcf(adap, 1)) & 0x7f) !=3D I2C_PCF_ES1) { + temp =3D get_pcf(adap, 1); + if ((temp & 0x7f) !=3D I2C_PCF_ES1) return -ENXIO; - } =20 /* load clock register S2 */ i2c_outb(adap, get_clock(adap)); /* check it's really written, the only 5 lowest bits does matter */ - if (((temp =3D i2c_inb(adap)) & 0x1f) !=3D get_clock(adap)) { + temp =3D i2c_inb(adap); + if ((temp & 0x1f) !=3D get_clock(adap)) return -ENXIO; - } =20 /* Enable serial interface, idle, S0 selected */ set_pcf(adap, 1, I2C_PCF_IDLE); =20 /* check to see PCF is really idled and we can access status register */ - if ((temp =3D get_pcf(adap, 1)) !=3D (I2C_PCF_PIN | I2C_PCF_BB)) { + temp =3D get_pcf(adap, 1); + if (temp !=3D (I2C_PCF_PIN | I2C_PCF_BB)) return -ENXIO; - } =20 printk(KERN_DEBUG "i2c-algo-pcf.o: detected and initialized PCF8584.\n"); =20 @@ -218,7 +218,8 @@ static int pcf_readbytes(struct i2c_adapter *i2c_adap, = char *buf, /* increment number of bytes to read by one -- read dummy byte */ for (i =3D 0; i <=3D count; i++) { =20 - if ((wfp =3D wait_for_pin(adap, &status))) { + wfp =3D wait_for_pin(adap, &status); + if (wfp) { if (wfp =3D=3D -EINTR) return -EINTR; /* arbitration lost */ =20 @@ -351,7 +352,8 @@ int i2c_pcf_add_bus(struct i2c_adapter *adap) /* register new adapter to i2c module... */ adap->algo =3D &pcf_algo; =20 - if ((rval =3D pcf_init_8584(pcf_adap))) + rval =3D pcf_init_8584(pcf_adap); + if (rval) return rval; =20 rval =3D i2c_add_adapter(adap); --=20 2.43.0 From nobody Sat Feb 7 19:41:22 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFFA02FABEE for ; Thu, 16 Oct 2025 16:15:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760631311; cv=none; b=pxqsPdlLZe4DwJaj2NVr6KtWEKDaRstiS2cy5NzyhwfdI47GT4dd7/0d18vBhFmqVGpOvzlW6JUNiB8P+zCqci8AWNYHKD4WtNQrqi/T2CcShua5ogOR8j3f8RCZ/u7Djl864X0QOnqvwzJ/RKBFD7iJHd/3olialhlgnMTyOLI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760631311; c=relaxed/simple; bh=1S7qkacQtOJLn4B5dSDEdf4PQhZDBi/JrvSfER614yc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kyUxVvOCQf6xiv+9QJ2bqXJK8tglnSQFq8P5I3Qp/ivAybuJa6V34sXNfH7ObV56F2pAdOANNOvB6XP6e0F3U2T3hx4Z+BxaIcKa6dr3EAk4+HZVf8d9mtpV+W2BNB8UgXZI+P3LXuVWKNzWXz0xrdt9qAhqV+m5LUDMEcoS2L4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h4dO/SMG; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h4dO/SMG" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47112edf9f7so5187495e9.0 for ; Thu, 16 Oct 2025 09:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760631308; x=1761236108; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IQ5MmPkHxZioIeQfPFm5x4+gWD/pC2wMeHLaiRdBbYA=; b=h4dO/SMGUjf06sdezexgkxWFQaWEVWunlIje+Vp/9z2D3/TF6Ad37dk0PvbodLbXhI OwqnY/ef5ENb+790W/+folYpzhwAwyDVZPH7DDd3L401oSqPtymwBz5soDil2wLXxuip uUVX/7IZH1IRR4ct+/zzwVqyodAYuT5SFt1ct0Ol9E7weVf1yECOXQtiCWNBdycahseJ F0omWbtrj8O+YbBm4d77TNGf24kYj2fP2gg4slTFJs2F+9FVDhaG6mLmE6GAdxEXBcDo KSyB5c/hKkpDoFklq+gAUnUzWv9kIQ1nXltJ11QKpq+LH5mJnSKEh5P/UgepFw6SAHKk IHfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760631308; x=1761236108; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IQ5MmPkHxZioIeQfPFm5x4+gWD/pC2wMeHLaiRdBbYA=; b=Eqr2YaWFkVcMzS1ZQdIfta/6+gno0/bHwxbAJzeGG0wALpB2+HUHLZUa4GEnAAarJ1 ClQ7rKai+xNJ5alEexBPqwFTk2UQRdjJ6g8qxmL8TE63SbjlkYml+QDfhE1SIdVMVt+A sUhj8PSs5DVRiQV9cBddn12zHLqH4UfO6cDeku6/JFMGU8VprDhU0GVvdfHwjx9OTdf2 XmFPhSVo98FfbBxOmhHpeddr7hqEhezAC2ZSHCeWgHjxtt1CNYsYjzhqNFfrk41NN6yA N4kMf0PawqZ48bxLWt4n09RzvThlJK3211Qn7HSZY7LDPT0E0E82RO/90BfWKFtmvgqJ CrqA== X-Forwarded-Encrypted: i=1; AJvYcCUwSkBozfqIdlT0uOiwg4JjbDoNB9whrGWeh3SQtw6QwLEXdiw47CNNZrzSaRW+b/McZ2aso3j91Ny5OrI=@vger.kernel.org X-Gm-Message-State: AOJu0YwWLnxQz6ZPcKIWK10NULPpvA2saIIrax1o8DoX4SoMoAAr130a y3ZPtNSPoURV+7VIPCfhKR1PbHwW8Rq8mgzOCtpdTfHx2wZk/QvISSvIGW/o4Q== X-Gm-Gg: ASbGnctH98X1qrg++5gNLDzEakFSRgNYTVGjAneM+xZOyjZ9W0zPOyzdFDrI4BZ6ULZ f+RtXACIXUW+K8eCSeLNvYkoyOAA1bt8mQp96IRx2c3iP2fpyHBQ3WxsXc14dwvXy9OTGE62nj/ AipT/a+ZNdTf7S14aWDLKYN4bv8LV0qsTsfMJAngH4pCLKAC1Qso5PgEvAavjvQ5A154DiRinR/ dXOJa3hgo5CHM/H8xDIrSb3WsGvbTz7rtuQ7YR0pI7epBRh1rOCHU0qppUIvgcX3A0KD3sNbwIV 633iZ5FBw14Nxh0UsLaXhrfHGzjLlXyN99ft3n1+kcBjOlLN1wBl9juipuD6H+G/Xh8BeKwvseL buM/CAUkoGtwiG8BW3bhOs4q9RlAbogXxmmPITnge+rZrR2qMARk46P9eBus/WQ8hQZpITAz8YK i9CPX6IQiYmTMtB8G1 X-Google-Smtp-Source: AGHT+IFze29dl8vMjJDBxLAzhOIyds7dSrfcHIK9v1xZIW8d3NBlF+kSTR7WBTP80GFdC7rAjNgDTA== X-Received: by 2002:a05:600c:5287:b0:471:1337:7220 with SMTP id 5b1f17b1804b1-47117874810mr4363165e9.3.1760631307981; Thu, 16 Oct 2025 09:15:07 -0700 (PDT) Received: from hangmanPC.. ([86.124.201.90]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-471143663afsm35654025e9.0.2025.10.16.09.15.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Oct 2025 09:15:07 -0700 (PDT) From: Cezar Chiru To: wsa+renesas@sang-engineering.com, andi.shyti@kernel.org Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Cezar Chiru Subject: [PATCH v6 3/3] i2c: pcf8584: Fix space(s) required before or after different operators Date: Thu, 16 Oct 2025 19:14:17 +0300 Message-ID: <20251016161417.15545-4-chiru.cezar.89@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251016161417.15545-1-chiru.cezar.89@gmail.com> References: <20250926154520.40583-1-chiru.cezar.89@gmail.com> <20251016161417.15545-1-chiru.cezar.89@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Require spaces around '=3D', '>' and '<'. Add space(s) around binary operators. Enforce errors fixing based on checkpatch.pl output on file. Signed-off-by: Cezar Chiru --- drivers/i2c/algos/i2c-algo-pcf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/algos/i2c-algo-pcf.c b/drivers/i2c/algos/i2c-algo-= pcf.c index 41a81d37e880..d675d484fe66 100644 --- a/drivers/i2c/algos/i2c-algo-pcf.c +++ b/drivers/i2c/algos/i2c-algo-pcf.c @@ -183,7 +183,7 @@ static int pcf_sendbytes(struct i2c_adapter *i2c_adap, = const char *buf, struct i2c_algo_pcf_data *adap =3D i2c_adap->algo_data; int wrcount, status, timeout; =20 - for (wrcount=3D0; wrcountalgo_data; struct i2c_msg *pmsg; int i; - int ret=3D0, timeout, status; + int ret =3D 0, timeout, status; =20 if (adap->xfer_begin) adap->xfer_begin(adap->data); @@ -284,7 +284,7 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, goto out; } =20 - for (i =3D 0;ret >=3D 0 && i < num; i++) { + for (i =3D 0; ret >=3D 0 && i < num; i++) { pmsg =3D &msgs[i]; =20 ret =3D pcf_doAddress(adap, pmsg); --=20 2.43.0