From nobody Mon Feb 9 03:52:52 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B815A32D0DB for ; Thu, 16 Oct 2025 16:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760630910; cv=none; b=NONDekCGY4oCsTo+DJ3p9NZb65frfpuMH/ZAu0UoViR1X5VsqCiEGph5JzvQu5s8THJCeTlwiTUbWo2uq0wEa6b5/5wcX31JtfGWwxRhEN0IPbuhS0NMVofNfzOBiXYgS4G3xo3FJpF90xjmodlFGdMYdJf+640xBaA2nF80CUg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760630910; c=relaxed/simple; bh=1W6726b6s8hC+gJBj2Ljp1SG20lHiAdl2ClI15dwHqQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=bwHPLW4SZH+5ayr+xmWXoZMq+mTkDywLwSPXut1omi4RC223l5b0WhttytZ/Pt8se74L4K2LXU7HH0Kq/1s9aelZfUMO1BZIXSyW6G4BSHF7jIV0gWEX9HROZ0aKXzkMHhgQpk5AopomZGFm2Uy9dedAa+LRuFkx1Ol/KVnFiSA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WL9FNAMm; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WL9FNAMm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760630907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BTjbXzfdMPFmTq5CiXRvNts61W+d2MXa+OQ9XQk41MY=; b=WL9FNAMmeiAwgZuVtIpHft/HeMw6h8JjNXmm999kgNP9+SpsZ7hBdttGeMmPqXMd62LXxi J35vD+bWbbixDRlzXJ57vfzNuBqF4ePP2lDWATYLisEidN8stbboVj6EWq+PZ+J5eb44vk UA2DSSuFLnvKhvXYtQByzFglIzJXFKE= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-u0RMceWUMwCp4jFmMkjywQ-1; Thu, 16 Oct 2025 12:08:26 -0400 X-MC-Unique: u0RMceWUMwCp4jFmMkjywQ-1 X-Mimecast-MFC-AGG-ID: u0RMceWUMwCp4jFmMkjywQ_1760630906 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-87c1f18cbc6so17503126d6.1 for ; Thu, 16 Oct 2025 09:08:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760630905; x=1761235705; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BTjbXzfdMPFmTq5CiXRvNts61W+d2MXa+OQ9XQk41MY=; b=quhQl/P3O0UJEohw0jS5zRFJxZJ80Il6CVhMg/yeJmCfw/Z1j/XgyvqNqPB2vAE+ua zpKOTM0pJ9vSG54651hULqZngvmAZbv2fmtMPs/oEtY6eT5n07zKvPJN0R5rLIqMtnKk Y7iREjpMK7x+eVLmZNP6cbJ+rf0c4lyEd2en9skc9RVVTvAoCG7B/SAaHAJvcEhwr9/Y fIIXjvGxpHw2N+IosUB/m7ZFvs8WQi/KiJEUs2t/B6GSPGk3Maoy+hsIgk+fxupzieV6 fJoc4eOtKBzXqbPSRFamiglflkU+bidsT6phzpa56deu8sOrsK+v08wtFx0VOnVUCAKW wheg== X-Forwarded-Encrypted: i=1; AJvYcCWUYLW/z6MiBIdD773Si/Pq+lRbZXr9NCtGwUcovxVyAFRo6OLCKn3r4lVG2K9MvvPPB7wNrsqJA3XODAc=@vger.kernel.org X-Gm-Message-State: AOJu0YycJs779qb2xNAuILNYuzijMGF0HGJ2tuyqLCjuT2WQY3zipkJc twcEVsBUlLWCoWpzAv+hNzsF60GqblWvreFs8mNpHYkHbZdxt34D5YdcSw/Mhf8+9n3Q2dSQXdf 3+XVpldGdzprUqbutf+AgOXNuBfp2Fbdi9LwvjEpm7bOtOlvMjJDymCR0aU/Xu4xTcOb46aBqRQ == X-Gm-Gg: ASbGnct5r5irvHRcAo0yWQ4+R/eXoVDO0a+tuPaDyxDS+Qvyd3+71BElQ2zxop4U8ie htF2SILlibCsyD8dALxMKyF6JFz4hvrTGL9Ze2WheTuwk1oG1kocHudYBSPB1yBW/t6k4sdKquz umYUncoQegWIU2Jstl7WfgsfkUq+ZtcyZLlILT1ZiEMH7TevSs2x2mDsnlSpElfEjy/Fd1JEDOP 9qIenRYYqp6XU7o0eFnQKZXQny0wvdS+6e18cYmd1rUw+1t7vQOvceg+Hfv7GQQvQYogbgX9iJG 3q6LOPEeZLFPLfD+hAMCXPP4UaqwDnXP0PcOqYPp8CNcHTBZTg5I9sSa7Km9/SWQUG7fwzY1awv dSigWALSlocfg1KAu/2oyVjBk6HsM11IwBDs+rK/wbKcxA9r4ZeN4GCKIK4iLlBFdfzXUFQ== X-Received: by 2002:a05:622a:130d:b0:4e8:8a5e:6dc4 with SMTP id d75a77b69052e-4e89d3e7f64mr9077281cf.79.1760630904311; Thu, 16 Oct 2025 09:08:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGtZrwo8eKunqrW1ZX26p0P/KX7TpXb/FgnwTi4CXt26VbUSEz89WMw80Ziq/vE1CwQ6xEdig== X-Received: by 2002:a05:622a:130d:b0:4e8:8a5e:6dc4 with SMTP id d75a77b69052e-4e89d3e7f64mr9076761cf.79.1760630903879; Thu, 16 Oct 2025 09:08:23 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4e89e723033sm778991cf.36.2025.10.16.09.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Oct 2025 09:08:23 -0700 (PDT) From: Brian Masney Date: Thu, 16 Oct 2025 12:08:12 -0400 Subject: [PATCH RESEND] i2c: busses: bcm2835: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251016-i2c-round-rate-resend-v1-1-96dd1d725e8f@redhat.com> X-B4-Tracking: v=1; b=H4sIAGsY8WgC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI1NDA0Mz3UyjZN2i/NK8FN2ixJJU3aLU4lQg2yAx1cg8xTzN3NTIUgmot6A oNS2zAmxutFKQa7Crn4tSbG0tAIG/XihvAAAA X-Change-ID: 20251016-i2c-round-rate-resend-0ae27d7f7529 To: Andi Shyti , Florian Fainelli , Ray Jui , Maxime Ripard , Stephen Boyd , Scott Branden , Broadcom internal kernel review list Cc: linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2123; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=1W6726b6s8hC+gJBj2Ljp1SG20lHiAdl2ClI15dwHqQ=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDI+SpRdj7zNMjvRJearcyn3jvcCybGbvzCpT/zf80RFZ bakgINVRykLgxgXg6yYIsuSXKOCiNRVtvfuaLLAzGFlAhnCwMUpABdxZvgf2ty/NiPw2Wmf3y+k wjw/Sgh1SvIc3c68oL70Vk3QcZubjAx9KQfdhaLOvZ/5oe8Kx7O0/wkzcubZlK+NmSm+fW6363Z eAA== X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate(). Signed-off-by: Brian Masney --- My original posting received no feedback. https://lore.kernel.org/linux-clk/20250810-i2c-round-rate-v1-1-9488b57153e7= @redhat.com/T/ I'm hoping to get this merged so that we can remove the round_rate() clk op from the clk core. The clk maintainer (Stephen) mentioned this work in his last pull to Linus. https://lore.kernel.org/linux-clk/20251007051720.11386-1-sboyd@kernel.org/ --- drivers/i2c/busses/i2c-bcm2835.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2= 835.c index 8554e790f8e36c5a1cf56c0aab8556b377f2bbdf..0d7e2654a534e92a529f27fdc04= 9812359678522 100644 --- a/drivers/i2c/busses/i2c-bcm2835.c +++ b/drivers/i2c/busses/i2c-bcm2835.c @@ -137,12 +137,14 @@ static int clk_bcm2835_i2c_set_rate(struct clk_hw *hw= , unsigned long rate, return 0; } =20 -static long clk_bcm2835_i2c_round_rate(struct clk_hw *hw, unsigned long ra= te, - unsigned long *parent_rate) +static int clk_bcm2835_i2c_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - u32 divider =3D clk_bcm2835_i2c_calc_divider(rate, *parent_rate); + u32 divider =3D clk_bcm2835_i2c_calc_divider(req->rate, req->best_parent_= rate); =20 - return DIV_ROUND_UP(*parent_rate, divider); + req->rate =3D DIV_ROUND_UP(req->best_parent_rate, divider); + + return 0; } =20 static unsigned long clk_bcm2835_i2c_recalc_rate(struct clk_hw *hw, @@ -156,7 +158,7 @@ static unsigned long clk_bcm2835_i2c_recalc_rate(struct= clk_hw *hw, =20 static const struct clk_ops clk_bcm2835_i2c_ops =3D { .set_rate =3D clk_bcm2835_i2c_set_rate, - .round_rate =3D clk_bcm2835_i2c_round_rate, + .determine_rate =3D clk_bcm2835_i2c_determine_rate, .recalc_rate =3D clk_bcm2835_i2c_recalc_rate, }; =20 --- base-commit: 2433b84761658ef123ae683508bc461b07c5b0f0 change-id: 20251016-i2c-round-rate-resend-0ae27d7f7529 Best regards, --=20 Brian Masney