From nobody Tue Feb 10 09:15:46 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67EA9311964; Wed, 15 Oct 2025 19:33:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760556808; cv=none; b=ccrMbsf8p2zfMVZS/UhsZppQZ9ilI/88Yfg7jG0Op22o3VQ1Yk9ebVb+4NW/DvOmU2nKz7TYsx0py1Am5em5qta3765k4IwrjGPJXtROP2Ym2Iuh5/PQhvUPJUYjfgb55g/dn5FcLRwTGAkxasOw37s+PE/Ca7+tpBlnuAti/rQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760556808; c=relaxed/simple; bh=LhxeTyRSi5tzmuwdniowFXTW4S9TVULOnCm6iJl08r8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G9Y5LR7YxXofBh4KPEmfpreoqgmzLShE0B4Oo4/RZQG/aWJr+5HgHd1v3V9n27/Z6IRC56NL62CEgIRBKy79b4WOdMDsWzWYiAZnOGw/xvpoLbyzcXlS67D+DeSFVLubsQrv2q2w8cF9q0/lHui/3U1mIAvlBnz400xCFgbHhmc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YxroU3xW; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YxroU3xW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1760556806; x=1792092806; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=LhxeTyRSi5tzmuwdniowFXTW4S9TVULOnCm6iJl08r8=; b=YxroU3xWpPn3abk1H8GwaRMmFtS+ESdad6297ncwVRx5V0Eko0g+XFeZ 04DEzJMvpkqkdx2jVcnhw77fTCfG35iEw+FiS5AOtntiEx2yFOykjTH9w emtSJO48DtQ13JpHHIpvmeaxXH9HuBu9v/gqLD7Dzue/xj5NkDDcdnLL1 E70NQPChw1uVcJGuaRK6qKoxaC+MtS9qxaMR0kSQZQ9F5wNd0autd5Ahs ngGcWaJS6Hgacr4ubldNZxXc+4jyHhTYpnw3NfFKQrF1niONpSrks0g/N HjcjhW+kZE6whG+PsltRH99uDTP770+TQTiIXNjqkxcrFYDz7fL9RF+5m w==; X-CSE-ConnectionGUID: /fV6t/r9SresP6VDIoLJAg== X-CSE-MsgGUID: 2OPzdydURO2mHotJSB/utg== X-IronPort-AV: E=McAfee;i="6800,10657,11583"; a="74083549" X-IronPort-AV: E=Sophos;i="6.19,232,1754982000"; d="scan'208";a="74083549" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2025 12:33:15 -0700 X-CSE-ConnectionGUID: jAooUi/mTxqzoIwkZ5QraA== X-CSE-MsgGUID: IAlimD0aQDybKpWuM6LafA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,232,1754982000"; d="scan'208";a="182044901" Received: from orcnseosdtjek.jf.intel.com (HELO [10.166.28.70]) ([10.166.28.70]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2025 12:33:15 -0700 From: Jacob Keller Date: Wed, 15 Oct 2025 12:32:06 -0700 Subject: [PATCH net-next 10/14] ice: add tracking of good transmit timestamps Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251015-jk-iwl-next-2025-10-15-v1-10-79c70b9ddab8@intel.com> References: <20251015-jk-iwl-next-2025-10-15-v1-0-79c70b9ddab8@intel.com> In-Reply-To: <20251015-jk-iwl-next-2025-10-15-v1-0-79c70b9ddab8@intel.com> To: Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Tony Nguyen , Przemek Kitszel , Andrew Lunn , Alexander Lobakin Cc: netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jacob Keller , Rinitha S , Aleksandr Loktionov , jbrandeburg@cloudflare.com X-Mailer: b4 0.15-dev-96507 X-Developer-Signature: v=1; a=openpgp-sha256; l=3125; i=jacob.e.keller@intel.com; h=from:subject:message-id; bh=v6YKr0JvH0CzlK42kuefD+8jO5JXcihujiXU5BaupJY=; b=owGbwMvMwCWWNS3WLp9f4wXjabUkhoz3335s27Xl8N+lZdtuRCz+tenq4luTtvJdiV/FaC/4x qZ99RtJho5SFgYxLgZZMUUWBYeQldeNJ4RpvXGWg5nDygQyhIGLUwAmcuEdI8Pepk0vtvzSnWHR e+6dc1rn/ga+H1ov5pjs/ctcnsGdUrmNkaErMUHwjGuQ7Gy+zD4dx4fhPpUpsj9Mb3edEHbZ9KD gPAcA X-Developer-Key: i=jacob.e.keller@intel.com; a=openpgp; fpr=204054A9D73390562AEC431E6A965D3E6F0F28E8 From: Jesse Brandeburg As a pre-requisite to implementing timestamp statistics, start tracking successful PTP timestamps. There already existed a trace event, but add a counter as well so it can be displayed by the next patch. Good count is a u64 as it is much more likely to be incremented. The existing error stats are all u32 as before, and are less likely so will wrap less. Reviewed-by: Jacob Keller Reviewed-by: Jakub Kicinski Reviewed-by: Simon Horman Signed-off-by: Jesse Brandeburg Tested-by: Rinitha S Reviewed-by: Aleksandr Loktionov Signed-off-by: Jacob Keller --- drivers/net/ethernet/intel/ice/ice_ptp.h | 2 ++ drivers/net/ethernet/intel/ice/ice_ptp.c | 9 +++++++++ 2 files changed, 11 insertions(+) diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.h b/drivers/net/etherne= t/intel/ice/ice_ptp.h index 137f2070a2d9..27016aac4f1e 100644 --- a/drivers/net/ethernet/intel/ice/ice_ptp.h +++ b/drivers/net/ethernet/intel/ice/ice_ptp.h @@ -237,6 +237,7 @@ struct ice_ptp_pin_desc { * @clock: pointer to registered PTP clock device * @tstamp_config: hardware timestamping configuration * @reset_time: kernel time after clock stop on reset + * @tx_hwtstamp_good: number of completed Tx timestamp requests * @tx_hwtstamp_skipped: number of Tx time stamp requests skipped * @tx_hwtstamp_timeouts: number of Tx skbs discarded with no time stamp * @tx_hwtstamp_flushed: number of Tx skbs flushed due to interface closed @@ -261,6 +262,7 @@ struct ice_ptp { struct ptp_clock *clock; struct kernel_hwtstamp_config tstamp_config; u64 reset_time; + u64 tx_hwtstamp_good; u32 tx_hwtstamp_skipped; u32 tx_hwtstamp_timeouts; u32 tx_hwtstamp_flushed; diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/etherne= t/intel/ice/ice_ptp.c index fb0f6365a6d6..4f50e952bfb5 100644 --- a/drivers/net/ethernet/intel/ice/ice_ptp.c +++ b/drivers/net/ethernet/intel/ice/ice_ptp.c @@ -500,6 +500,9 @@ void ice_ptp_complete_tx_single_tstamp(struct ice_ptp_t= x *tx) if (tstamp) { shhwtstamps.hwtstamp =3D ns_to_ktime(tstamp); ice_trace(tx_tstamp_complete, skb, idx); + + /* Count the number of Tx timestamps that succeeded */ + pf->ptp.tx_hwtstamp_good++; } =20 skb_tstamp_tx(skb, &shhwtstamps); @@ -558,6 +561,7 @@ static void ice_ptp_process_tx_tstamp(struct ice_ptp_tx= *tx) { struct ice_ptp_port *ptp_port; unsigned long flags; + u32 tstamp_good =3D 0; struct ice_pf *pf; struct ice_hw *hw; u64 tstamp_ready; @@ -658,11 +662,16 @@ static void ice_ptp_process_tx_tstamp(struct ice_ptp_= tx *tx) if (tstamp) { shhwtstamps.hwtstamp =3D ns_to_ktime(tstamp); ice_trace(tx_tstamp_complete, skb, idx); + + /* Count the number of Tx timestamps that succeeded */ + tstamp_good++; } =20 skb_tstamp_tx(skb, &shhwtstamps); dev_kfree_skb_any(skb); } + + pf->ptp.tx_hwtstamp_good +=3D tstamp_good; } =20 /** --=20 2.51.0.rc1.197.g6d975e95c9d7