From nobody Fri Dec 19 20:32:39 2025 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9128E30F81C for ; Tue, 14 Oct 2025 11:32:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760441572; cv=none; b=oKy6jmvpjJW/eUy9WJqF7uMCeYY6v6Ys5/Ujy/fes8Qc8Xoy64avmUigJ8OkQkdyK5sNPv/IwS+nyutfNSt7xlWz4SC8adrNKEBGcyFR6uDhPyQLQaVZAi4dmUEMcWH4UEiQM5oV6Ae0ZF8E7emK//PPhmFP9F3hpnWOmsBbOjg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760441572; c=relaxed/simple; bh=HhxulXQwatE6PXjsTOpERvUEfgAFTPUo3nVaCBHQfkY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AM41UJ5HSICubiPO591DGBeSV2W34xuxjz+DUSfSqK00NZdPDp47d5wERF/oOc9+eikrc32z6JqCFeY4cJxpWRFyKD3B9APNc59CtACEiV3hg1sdDLtEQM+a3sI0zmvVYdWEAy0htx6gNABmLfUCc95EYwef57JpRH85kHCOJnY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PaU4TmEt; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PaU4TmEt" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-781db5068b8so4159183b3a.0 for ; Tue, 14 Oct 2025 04:32:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760441570; x=1761046370; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CBUWIXVuX9TSH7iwZbReBbw9Y6KDyRcjsjDA5QvkLIc=; b=PaU4TmEt4KOBIKsAOesotTtCbsPJNe0uTBzp1QxRhSROJLCFT8q3MLq7fcYGVyz9VP wvrGO+gajyrZo5OBt4aa1RMRUjghgq7A34fNjsxs/jXg5xCx0ClBALErQrM7MIAkFKvp Rg0Rga+omEoCSAQSLWuMNDnmTLQlzU8uMv7cTvxvErr9lWROseEV+IyurMnBdZ0TRb5e B01ek1VIlVQZnTMvGVpH6AXyaVe/YMVQXBnAOriI0szXoSUHtJs5g9X6iXeeTXricn6l Lpe3GNz7Raf/+roEOGNnvsyh/NEpTHcrCV0sMwdjYIUAt7N69e4ytH2c13YncqXSr3vN KIoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760441570; x=1761046370; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CBUWIXVuX9TSH7iwZbReBbw9Y6KDyRcjsjDA5QvkLIc=; b=QB42rfvOuKVp/zt9FKzuByEw6hmeiJCN6stl0o/B7+Zu4nVQ0IteEAnQwDnqbVKBnk 6YwZI5n2/yGylnyUh8Vj1QfLPIhmynoLgMWmVo4RDBEaZwtHbSak/vzKw110sCzGQBrr /O/o9A8eLaREue+YCKejTiJWDytgs2RSq9esHV3LdDV28i6DWeh7asSbw3+vZOmBZOzG eHw6jM5gXbGu4vq4jQG9bSCTNOXvZEzsK+KGVuTE62PFpJ1nAHsf5jMMDXU+9BOGz5/Y ePuq5fidFOkULMiSg4YN5wMTyrjhg/+SAaZfY7GKG0BoBQcQ0LTejT1CksVunfo/ellY E/sA== X-Forwarded-Encrypted: i=1; AJvYcCXRYrQV41asEO+z9BY8WvtfY7kOWSzELYUDYm8eIllWYQEJymAmf1uaSLcu0qruf7fN344UlUbIXRlvVFc=@vger.kernel.org X-Gm-Message-State: AOJu0YwxYP18rBogowBuEY/outG3uGDHw8N/QquMpuxTtC4OvUTEhbw0 3d3NbiLKiaxvTB1KrjMHK/L8zs+dQJGKWVrkZLl7635xddQZ+6FSd2j7 X-Gm-Gg: ASbGncv042xeTExqArrkmm8JXu0mxG62Ov73ThF1t5hqzM/DZMU33zLA3xFphu+eRUR 2yEU+1nximRPsB5izrcVOB0zdvVrkCtjQPjnkji0g1cNrZPAAEwEwkjstoq7CVr9Spp2G2GSa2Q NbBKW1NJCdvSnBHxRyc8Ky99Gn4BiZkS0wygU79ckSS1xCxR8627dyXlNLeUzam1TicofwOzJty FmMl21Gx3dvnXC1obo3Bt/vSh3ifd8Uc3j4tk0tJBykSZDRlHeUY2H1TYz5vbCAm9DechhGBkFs 0nrMWy2RFH0+qU+h+CMWW8GCdz1/ht/WYI5D1Ks1x4JX0aRxToP7+b5ZHxkXY6G9osij/u2MuzF YUXOvpbTiR2ZgPUMEqcnHtEhnJR1gOfinHQkQnbA= X-Google-Smtp-Source: AGHT+IHUZvlwK/tHfChIoy9WwwPnZcMKeQjitVT4QrngVrm6V72sz77ULhr0gyxke52yNoTSgqWuAA== X-Received: by 2002:a05:6a00:c8c:b0:77f:6971:c590 with SMTP id d2e1a72fcca58-79387d0f36amr26600669b3a.22.1760441569783; Tue, 14 Oct 2025 04:32:49 -0700 (PDT) Received: from rockpi-5b ([45.112.0.108]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7992d0965c3sm14871383b3a.52.2025.10.14.04.32.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 04:32:49 -0700 (PDT) From: Anand Moon To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-omap@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-pci@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR TI DRA7XX/J721E), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 1/3] PCI: j721e: Propagate dev_err_probe return value Date: Tue, 14 Oct 2025 17:02:27 +0530 Message-ID: <20251014113234.44418-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251014113234.44418-1-linux.amoon@gmail.com> References: <20251014113234.44418-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Ensure that the return value from dev_err_probe() is consistently assigned back to ret in all error paths within j721e_pcie_probe(). This ensures the original error code are propagation for debugging. Cc: Siddharth Vadapalli Signed-off-by: Anand Moon --- v1: new patch in this series --- drivers/pci/controller/cadence/pci-j721e.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/contr= oller/cadence/pci-j721e.c index 5bc5ab20aa6d..9c7bfa77a66e 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -569,20 +569,20 @@ static int j721e_pcie_probe(struct platform_device *p= dev) pm_runtime_enable(dev); ret =3D pm_runtime_get_sync(dev); if (ret < 0) { - dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n"); + ret =3D dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n"); goto err_get_sync; } =20 ret =3D j721e_pcie_ctrl_init(pcie); if (ret < 0) { - dev_err_probe(dev, ret, "j721e_pcie_ctrl_init failed\n"); + ret =3D dev_err_probe(dev, ret, "j721e_pcie_ctrl_init failed\n"); goto err_get_sync; } =20 ret =3D devm_request_irq(dev, irq, j721e_pcie_link_irq_handler, 0, "j721e-pcie-link-down-irq", pcie); if (ret < 0) { - dev_err_probe(dev, ret, "failed to request link state IRQ %d\n", irq); + ret =3D dev_err_probe(dev, ret, "failed to request link state IRQ %d\n",= irq); goto err_get_sync; } =20 @@ -599,7 +599,7 @@ static int j721e_pcie_probe(struct platform_device *pde= v) =20 ret =3D cdns_pcie_init_phy(dev, cdns_pcie); if (ret) { - dev_err_probe(dev, ret, "Failed to init phy\n"); + ret =3D dev_err_probe(dev, ret, "Failed to init phy\n"); goto err_get_sync; } =20 @@ -611,7 +611,7 @@ static int j721e_pcie_probe(struct platform_device *pde= v) =20 ret =3D clk_prepare_enable(clk); if (ret) { - dev_err_probe(dev, ret, "failed to enable pcie_refclk\n"); + ret =3D dev_err_probe(dev, ret, "failed to enable pcie_refclk\n"); goto err_pcie_setup; } pcie->refclk =3D clk; @@ -638,7 +638,7 @@ static int j721e_pcie_probe(struct platform_device *pde= v) case PCI_MODE_EP: ret =3D cdns_pcie_init_phy(dev, cdns_pcie); if (ret) { - dev_err_probe(dev, ret, "Failed to init phy\n"); + ret =3D dev_err_probe(dev, ret, "Failed to init phy\n"); goto err_get_sync; } =20 --=20 2.50.1 From nobody Fri Dec 19 20:32:39 2025 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F39F30F81C for ; Tue, 14 Oct 2025 11:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760441578; cv=none; b=nl435Vfcz9rTNh3zb3KtNgWAd7WbblGbVQwph/rd+58G8lgrLhNE6BBODv6wA/KwCV6ZQ+umXsj/ZUUJF9Z/uUXV1TZailKgs8Fykjhi8NDf5izWyVy008ohGvtxFwI6rDP4sUp4gh7u+V0EnB+k3lw0N6ig/JTduyUu6m3OROc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760441578; c=relaxed/simple; bh=PoKOs9TgSjfkqiMX2+2Ly0Vb1OFpd3epTvsXddSqn5Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ojaLN1aN0hLo/yPuKVsv3BLgKS3lK43WsMz2iJfVFtzBUQUmLS/uE2Wt/tOM6KGYhkkgRUx6ptJ6j/D2zqA+kwTWuTFYk2iXzuAyGG+c/99kA+slIKbtHopsCbyZ1Z3yJiv7F+M+gIjJyfGuSWqkZjeFATIvsCToPJerj5n0cBk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ccpaD//s; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ccpaD//s" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-79ef9d1805fso482464b3a.1 for ; Tue, 14 Oct 2025 04:32:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760441576; x=1761046376; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E7UerwX9ObkYiq6vERvNVgcsL6sbi2km2IZoP2hNgnA=; b=ccpaD//spzzaSxtfpn3a98ddUjjV4cDzVLsd6W4R+fWzJVH62b33RPfUti9wtAaMQ7 qbe560HBwhjH4dJLIZmhmErnseh4HF1OtaoPuw//OFfhUD+ciFhLPIHrny/6qhTYKEv9 LVvJcqFHWqG37vPIBWYgtU6awZE3g4whDYHnswG5xbI0XOo/NVDxp36m3APC2nq6ElOy eAkCG/m2qDjNckqrJ3A3M2KpcSf8FNMySAe8gNopyGWEzqhEq2srdvy6aYUgREiFEBkU XStKv/DCCCTnJUEO90DJH+znobht6GOC6v9MXKsVK3/fQxl7OS/OEpB14gLC+ld0XPnW i2uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760441576; x=1761046376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E7UerwX9ObkYiq6vERvNVgcsL6sbi2km2IZoP2hNgnA=; b=WRYvfpCk09VLD9lbDy+GH9XUy1tJG5rdT2FRc409hHyPEeGRunmRM+b9VtK/xwgRZn cjSswu284J2gSs9wJJw7w5B628/EPazcwDraLrCgOdzjOZH8gcF6KoYHPzEaurR5ygy0 aeHtFG6P4FXbAPC0AubJdVwqxDUcYyeWLkHVUC2jirMEf9CNx7nCRBDi1BeuQQEaH1mC KxXzOWy4FpcLStJxW4vzqn2OVm8jFHQL/dgxaE2h3H6PK6S+4KEaD3638EbnRfLS1esf vujdSAvUgMOnXWgwEKHVWxgllk0pePq2MppqZ5/4iRikt6BTJnnAoaF4KVy1KvDdTv4N FjgQ== X-Forwarded-Encrypted: i=1; AJvYcCVIoaarImFRWR2GhBlKUH+V7EX1vLNUFG/rIxyf14qawWu4w0/X9zcbz5ZofVaMtBGsh8zNQyPPnPpTSww=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf461euZKhtz7sii4gNmQPpjIJpHSWEUS9fr7nRwGDJCcN5g+7 uZInKQY3nK28ZW1FQ4c7HO7q3j2wglNiIv9/lXOq0nZArRee/zEQiHH3 X-Gm-Gg: ASbGncvM6e28k0B1wI6oU6f11pbSJqr1KsFSfbW/vH7DC6/XLm2i9iaO1tnxBLTAhU0 muPmeX19MG3vtYRUntQF63/aNo5U8Qw8jW05jKNouR7kdT5DsS7d33TLMAfUGiZIiZ/z56wCtRC +T8FyIShftaOc/0SC/9OOGwKmzuvbWiZ8vpYgNNAQGDTy9deyiPVcf2SviyaZ1VDpTEWjyaHc7i kpXwJyoGVVvNAf6wKUBHAUif3nnTjrBsfccj7WJT7KHB+oTSDQj9kGciFRlASdTjPXB4EgjmEri 2DETpw71sldHMuSLzxDxQVuTQLguwh3zYpUGXTEEPacT461LavF5xVsbpcThSa3YsPCI6JBBQxi NGwYhskln3fhQuvo4rzpk6dJCM2t6c+tugA8Vj1305nQ7eui0RA== X-Google-Smtp-Source: AGHT+IFL/A1wjKWekovh/oihjR4JIjfCM839DB7WtztyHa+NpAIMVWIzCgumtsxtL4h7BgUTWYN4Fw== X-Received: by 2002:a05:6a00:182a:b0:781:275a:29d9 with SMTP id d2e1a72fcca58-7938742c7aemr32083308b3a.18.1760441575343; Tue, 14 Oct 2025 04:32:55 -0700 (PDT) Received: from rockpi-5b ([45.112.0.108]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7992d0965c3sm14871383b3a.52.2025.10.14.04.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 04:32:54 -0700 (PDT) From: Anand Moon To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-omap@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-pci@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR TI DRA7XX/J721E), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 2/3] PCI: j721e: Use devm_clk_get_optional_enabled() to get the clock Date: Tue, 14 Oct 2025 17:02:28 +0530 Message-ID: <20251014113234.44418-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251014113234.44418-1-linux.amoon@gmail.com> References: <20251014113234.44418-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Use devm_clk_get_optional_enabled() helper instead of calling devm_clk_get_optional() and then clk_prepare_enable(). It simplifies the error handling and makes the code more compact. This changes removes the unnecessary clk variable and assigns the result of the devm_clk_get_optional_enabled() call directly to pcie->refclk. This makes the code more concise and readable without changing the behavior. Cc: Siddharth Vadapalli Signed-off-by: Anand Moon --- v1: Drop explicit clk_disable_unprepare =E2=80=94 handled by devm_clk_get_o= ptional_enabled Since devm_clk_get_optional_enabled internally manages clk_prepare_enab= le and clk_disable_unprepare as part of its lifecycle, the explicit call to clk_disable_unprepare is redundant and can be safely removed. --- drivers/pci/controller/cadence/pci-j721e.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/contr= oller/cadence/pci-j721e.c index 9c7bfa77a66e..ed8e182f0772 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -479,7 +479,6 @@ static int j721e_pcie_probe(struct platform_device *pde= v) struct cdns_pcie_ep *ep =3D NULL; struct gpio_desc *gpiod; void __iomem *base; - struct clk *clk; u32 num_lanes; u32 mode; int ret; @@ -603,18 +602,11 @@ static int j721e_pcie_probe(struct platform_device *p= dev) goto err_get_sync; } =20 - clk =3D devm_clk_get_optional(dev, "pcie_refclk"); - if (IS_ERR(clk)) { - ret =3D dev_err_probe(dev, PTR_ERR(clk), "failed to get pcie_refclk\n"); - goto err_pcie_setup; - } - - ret =3D clk_prepare_enable(clk); - if (ret) { + pcie->refclk =3D devm_clk_get_optional_enabled(dev, "pcie_refclk"); + if (IS_ERR(pcie->refclk)) { ret =3D dev_err_probe(dev, ret, "failed to enable pcie_refclk\n"); goto err_pcie_setup; } - pcie->refclk =3D clk; =20 /* * Section 2.2 of the PCI Express Card Electromechanical @@ -630,7 +622,6 @@ static int j721e_pcie_probe(struct platform_device *pde= v) =20 ret =3D cdns_pcie_host_setup(rc); if (ret < 0) { - clk_disable_unprepare(pcie->refclk); goto err_pcie_setup; } =20 @@ -679,7 +670,6 @@ static void j721e_pcie_remove(struct platform_device *p= dev) =20 gpiod_set_value_cansleep(pcie->reset_gpio, 0); =20 - clk_disable_unprepare(pcie->refclk); cdns_pcie_disable_phy(cdns_pcie); j721e_pcie_disable_link_irq(pcie); pm_runtime_put(dev); --=20 2.50.1 From nobody Fri Dec 19 20:32:39 2025 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 133FA30EF70 for ; Tue, 14 Oct 2025 11:33:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760441583; cv=none; b=KxmM08nKqHfpmrTDbwznGYU64VoZymsvbFZ7cxEG/pzePmXYC28UHOy96dudKXSKhtBX9C/z8VH1kimxtJxmSjqCpPeGrNhDx/Btc/CPQcH4L/SMF77SnUrkIbhLtIOC2GPtKmdSGxUYYhwkGke4eoEsIHfwO2YN5gcnzvhQqiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760441583; c=relaxed/simple; bh=m4JimLcVKSmkW3C/jrPc3p4+w8KZ9hwzs7ARWBUJAzk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gRvDPBANZ2h1cKpyfo6cnqEsq5qQ4HI4HFSv/t2ydVcJfBGXtkLWWtd5HXenWlXoLZJzymrohPACgoD9soGjGhOxsPH4GJQFygYaq2+wG++nsLokaa+L/NcVfBpgzQsu7kQCVHMxqpD5We2QEBZ1NQ44w+Y2gizWXnxSlLTRlq4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kzswigXC; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kzswigXC" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-781251eec51so4318027b3a.3 for ; Tue, 14 Oct 2025 04:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760441581; x=1761046381; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xpDUom30mVihFUe1ZHKp2VNngPZC0EmXCJHb+H0vcDc=; b=kzswigXCMa5zypTQT6Ndr/rdapTXIxq+T/K27hAHz95bezqtleqQqIi2oZBF0l1kKo Rqil6btCRVZ9kbA6C13vINA4uqWPq1LnufOdryc/zGsAt0Bwj9E5K6Shuo3s9uWjRNEE iL7oVNkTl8l34vRWTgjlHsXL0CPBj3gdc31fGruY36wPVIDdetyPzTXmYHb+teIRIsnY OR1KxnofNzV/7NJG4EG4RdkkfL2+TGit4uhi1G2efqhJG+mqUwlHxjg3z6kq14NMrFNq lL6vfKYlbQGB3aiUUrn9145vyWIR0LktAb5zvKZUgAW8v4AhBUmJm8Z55D+PV0oCGvfE pzdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760441581; x=1761046381; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xpDUom30mVihFUe1ZHKp2VNngPZC0EmXCJHb+H0vcDc=; b=IYng+4o9qQkMoLGOfIevPGClJDCEEm2S8f59QgIXJXULKX7pHvWj0msXIltaZZW087 ecI0cdLRZaktLXvJlWlYs8bDqtRo7+bC+X2BII+NcDiugNMXzLp7gW+LkWRtHQLS3/lj 2p9tljjyhIOhvwUXM8mbPHksPUoKN3j975WYulTdW1chaWawufsxbbc3oiFJbGnrqLHa k8K1tuFOMQnLoYOG2uQqUtCQk3NqLuEyHsUbdaBOkMc9CqCDvlWwELLzb+jB7gHxU4U+ js1rPakuK35OfL9Eo8lZNINMRMkmTH4jn+Sd0blUoQzxW6yjNlaEiGO3fl/5rcFQOz5q iBxQ== X-Forwarded-Encrypted: i=1; AJvYcCUtoxoFeAXtyHvos/B4Wsa0AStWaH+ajp9MN4WjMrgr3A/LzDylU4eMY3v3px+lhHJBnjAHvV9Y2cp5+6A=@vger.kernel.org X-Gm-Message-State: AOJu0YwYHQztmPNUQ2CE+c3kvxZhDIuYcybscoy4bgloDia2MiEBmrnN cRqHunq5Hcacn01vBRc06odNQDLa2daTI6hMoN8hPYVy7y1GSwVv2FG3 X-Gm-Gg: ASbGncuxWUYg+WzmhMt35lKfiaVV8135JeC/cqJs6MkeQPr8gPTpIi7zwW0y/oELnAz yKm0Fd7VCxOHYfXzMJAifupZIREQ8+UcjbMklLu2NJOn50iCwhER9xeoQeTYxrNPqSvbJtV8opC PSHJ/skN0HNLJqVToh7jxTOZlLT0t0ekshW9ATXe+trU8svteB8HtOxwvUHjIk7Z3hvpG3UGthZ Tk0FCVWxL2w2E+Xt9NXFlKZnLZpc+3v2+rGX1FsvwB0soMrGqL2eIKuK1/4hokVh6LatycCaUzl fE8PSAIN0EHH4dahgk9jERF8Ip9Gw0RH3OM/7QSng3b7RpnMMOVTGdHaU1WFFN5V1tEn4yxGbEc myNP1sAvxJfbCZMseKLcxH2RFl0ZMYqNRC7Ni5nd4DCIP+1Qn1g== X-Google-Smtp-Source: AGHT+IFVLpe1YlyoBz6ibhhreG6Fl3FbCAxKdtEs4SmjRs5bXwF82T38vjadMP9BpiSOiF7uDxR7XA== X-Received: by 2002:a05:6a00:1705:b0:78c:97fa:6170 with SMTP id d2e1a72fcca58-79387242e1amr34246206b3a.17.1760441581102; Tue, 14 Oct 2025 04:33:01 -0700 (PDT) Received: from rockpi-5b ([45.112.0.108]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7992d0965c3sm14871383b3a.52.2025.10.14.04.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 04:33:00 -0700 (PDT) From: Anand Moon To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-omap@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-pci@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR TI DRA7XX/J721E), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [PATCH v1 3/3] PCI: j721e: Use inline reset GPIO assignment and drop local variable Date: Tue, 14 Oct 2025 17:02:29 +0530 Message-ID: <20251014113234.44418-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251014113234.44418-1-linux.amoon@gmail.com> References: <20251014113234.44418-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change removes the unnecessary local gpiod variable and assigns the result of the devm_gpiod_get_optional() call directly to pcie->reset_gpio. This makes the code more concise and readable without changing the behavior. Cc: Siddharth Vadapalli Reviewed-by: Siddharth Vadapalli Signed-off-by: Anand Moon --- v1: Add Rb - Siddharth --- drivers/pci/controller/cadence/pci-j721e.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/contr= oller/cadence/pci-j721e.c index ed8e182f0772..bd8fda0baba8 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -477,7 +477,6 @@ static int j721e_pcie_probe(struct platform_device *pde= v) struct j721e_pcie *pcie; struct cdns_pcie_rc *rc =3D NULL; struct cdns_pcie_ep *ep =3D NULL; - struct gpio_desc *gpiod; void __iomem *base; u32 num_lanes; u32 mode; @@ -589,12 +588,12 @@ static int j721e_pcie_probe(struct platform_device *p= dev) =20 switch (mode) { case PCI_MODE_RC: - gpiod =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); - if (IS_ERR(gpiod)) { - ret =3D dev_err_probe(dev, PTR_ERR(gpiod), "Failed to get reset GPIO\n"= ); + pcie->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW= ); + if (IS_ERR(pcie->reset_gpio)) { + ret =3D dev_err_probe(dev, PTR_ERR(pcie->reset_gpio), + "Failed to get reset GPIO\n"); goto err_get_sync; } - pcie->reset_gpio =3D gpiod; =20 ret =3D cdns_pcie_init_phy(dev, cdns_pcie); if (ret) { @@ -615,9 +614,9 @@ static int j721e_pcie_probe(struct platform_device *pde= v) * This shall ensure that the power and the reference clock * are stable. */ - if (gpiod) { + if (pcie->reset_gpio) { msleep(PCIE_T_PVPERL_MS); - gpiod_set_value_cansleep(gpiod, 1); + gpiod_set_value_cansleep(pcie->reset_gpio, 1); } =20 ret =3D cdns_pcie_host_setup(rc); --=20 2.50.1