From nobody Fri Dec 19 19:01:35 2025 Received: from smtpbguseast1.qq.com (smtpbguseast1.qq.com [54.204.34.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C6C82E6CB3; Tue, 14 Oct 2025 07:27:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.204.34.129 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760426880; cv=none; b=h6ZcXp1IKmbmonMtUikmG9cBXAb7a2GKbTzgwTNjWlL7fjbK9szDYIVRQnYFjPRxR5yvUPPijdwySL2Z+vxjAkyc2Gqli0sRgjK+V9nn0SwPakwbOHWMi41wgw139Yj0NODxEr8QbGjNbfWMu7Hy7FeEV4tTcieY9f9O0LBiI2o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760426880; c=relaxed/simple; bh=TG1RgJEsVR/aHZhCSznAcSiMQiruU4NjsN5itqkUYcM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gpQMH3hKJEN1Rx5HR3j9uafpXZ/oUAklqZB13qU0K0iJw47PQGqkjXGhraytQFNdJhiDgLJb+mS9vywsgujpcLSPoUSDzQX8rble5TSvD55xTmaRToHdeIIhP0rxFVqH7TqsB5mcQa6e6V+XFllUHOjb63X3VWlqTHH2FFjjCrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mucse.com; spf=pass smtp.mailfrom=mucse.com; arc=none smtp.client-ip=54.204.34.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mucse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mucse.com X-QQ-mid: zesmtpsz2t1760426863t1ebade9d X-QQ-Originating-IP: Tz11S9/WaU5RUFL/yI8wPOxWIcSQxBW7zyKxmryRgfc= Received: from localhost.localdomain ( [203.174.112.180]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 14 Oct 2025 15:27:41 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 9777684139916137296 EX-QQ-RecipientCnt: 13 From: Dong Yibo To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, andrew+netdev@lunn.ch, danishanwar@ti.com, vadim.fedorenko@linux.dev Cc: netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, dong100@mucse.com Subject: [PATCH net-next v14 5/5] net: rnpgbe: Add register_netdev Date: Tue, 14 Oct 2025 15:27:11 +0800 Message-Id: <20251014072711.13448-6-dong100@mucse.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251014072711.13448-1-dong100@mucse.com> References: <20251014072711.13448-1-dong100@mucse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpsz:mucse.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-QQ-XMAILINFO: N4WhQbLQyIqSQo/hzNa/l79ndX67Olg3np4Orfk9SJ3NRoMSSgKQ3+lK jQJantD7msVmNITM9bafeZb3OA5yWXZQlXFOPCixC6SGXc7vuB9TAUc7sqSYsdviZf94Jur YGrslzqIigaJYb9FXJUqKzhdjr72HlfL4veUGd1eg5F7xJFLY1gBEtKmYAQvLdxgRrkhNY4 UkQMM9xDDSJBaPJ09ycpwA5VqzMMCjhXw54MhidUYNnncoov1kaEFQc1lJ0tjlld327Rsl6 VHBvkXlebQw+QDj+r8XG2vfZEHJvqz7Tfy7ajDvr+TGZ7RdbuX1GVWj9x90uJ9AiQdBpKoo t3rn7lbJ8fQCoY/pINpUWoWOzEUeW2iwJRkuD6ZOGl6ypw//ozd9ThdDp7Af6x5TkwbNNkk Bi62mV7Ja8X64eS7hO4tMmIOIhKI22KQ64bNeXWZu38WuLhdqIxrPJo3O45acB4+md+8Zyn yzxEhrMZb1DiWYlkszH3llbm7CU+onQ+7XamUcwApi+Om3IVmWKKGnrqCP9bOsHw3oIpw4z spTQxA4m3hYZ97t7CaAbYHmCZjiFVI7pIDdqLyXQBRGoCxZxFy7QsIyuscRkIKw0893uUOw XkodRRM58D3Dsio1NeT50Vd88U3QCEiI32FAw0++GnQPD9SIMny7cUqxcfCFOEHKGmrn20S 5zP4XsufyHoi0Wg/gOISqJnJpGA9QGdxkySDh9/E98GP1hkGyUFFYcumJ2Tcq5GOpSx/jBX Cb5y8cxZ9naq9K6vDdE+bmdHNbxukxgERcM2Dl2dTKQ5ZufhPiAG8zKnYZFB2vHd3qHgKZ6 lrp8gJldYKPTW4SwxysK9ZUzI5pH5gyVNhWGxM3lVbFSg12jAL3+ApYpLKy1GaIpW+QtNcA z539NPaSJBpCJ6Ypzk0bnLmfB1tgJKm0nyY/OmezwkigB4D0hEb/fPW9do1HmN0zdwBfvdD ZOt/mAjZntsHUKaBqoA3sW+TgmaMqvOvqh79b6lP5MPanVh/A2HTxe5s1Xh38GcBsJf4zW7 imswBP9B+tQwfh2LGijx3tiyLRKcQ= X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU= X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" Complete the network device (netdev) registration flow for Mucse Gbe Ethernet chips, including: 1. Hardware state initialization: - Send powerup notification to firmware (via echo_fw_status) - Sync with firmware - Reset hardware 2. MAC address handling: - Retrieve permanent MAC from firmware (via mucse_mbx_get_macaddr) - Fallback to random valid MAC (eth_random_addr) if not valid mac from Fw Signed-off-by: Dong Yibo Reviewed-by: Vadim Fedorenko --- drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h | 24 ++++ .../net/ethernet/mucse/rnpgbe/rnpgbe_chip.c | 73 +++++++++++ drivers/net/ethernet/mucse/rnpgbe/rnpgbe_hw.h | 2 + .../net/ethernet/mucse/rnpgbe/rnpgbe_main.c | 117 +++++++++++++++++- 4 files changed, 214 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h b/drivers/net/ether= net/mucse/rnpgbe/rnpgbe.h index 794581471b22..a8604bf34fc6 100644 --- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h @@ -6,6 +6,7 @@ =20 #include #include +#include =20 enum rnpgbe_boards { board_n500, @@ -34,18 +35,38 @@ struct mucse_mbx_info { u32 fwpf_ctrl_base; }; =20 +/* Enum for firmware notification modes, + * more modes (e.g., portup, link_report) will be added in future + **/ +enum { + mucse_fw_powerup, +}; + struct mucse_hw { void __iomem *hw_addr; + struct pci_dev *pdev; struct mucse_mbx_info mbx; + int port; + u8 perm_addr[ETH_ALEN]; u8 pfvfnum; }; =20 +struct mucse_stats { + u64 tx_dropped; +}; + struct mucse { struct net_device *netdev; struct pci_dev *pdev; struct mucse_hw hw; + struct mucse_stats stats; }; =20 +int rnpgbe_get_permanent_mac(struct mucse_hw *hw); +int rnpgbe_reset_hw(struct mucse_hw *hw); +int rnpgbe_send_notify(struct mucse_hw *hw, + bool enable, + int mode); int rnpgbe_init_hw(struct mucse_hw *hw, int board_type); =20 /* Device IDs */ @@ -54,4 +75,7 @@ int rnpgbe_init_hw(struct mucse_hw *hw, int board_type); #define RNPGBE_DEVICE_ID_N500_DUAL_PORT 0x8318 #define RNPGBE_DEVICE_ID_N210 0x8208 #define RNPGBE_DEVICE_ID_N210L 0x820a + +#define mucse_hw_wr32(hw, reg, val) \ + writel((val), (hw)->hw_addr + (reg)) #endif /* _RNPGBE_H */ diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c b/drivers/net/= ethernet/mucse/rnpgbe/rnpgbe_chip.c index 5739db98f12a..2ec6e28d2c35 100644 --- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c @@ -1,11 +1,82 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright(c) 2020 - 2025 Mucse Corporation. */ =20 +#include #include +#include =20 #include "rnpgbe.h" #include "rnpgbe_hw.h" #include "rnpgbe_mbx.h" +#include "rnpgbe_mbx_fw.h" + +/** + * rnpgbe_get_permanent_mac - Get permanent mac + * @hw: hw information structure + * + * rnpgbe_get_permanent_mac tries to get mac from hw + * + * Return: 0 on success, negative errno on failure + **/ +int rnpgbe_get_permanent_mac(struct mucse_hw *hw) +{ + struct device *dev =3D &hw->pdev->dev; + u8 *mac_addr =3D hw->perm_addr; + int err; + + err =3D mucse_mbx_get_macaddr(hw, hw->pfvfnum, mac_addr, hw->port); + if (err) { + dev_err(dev, "Failed to get MAC from FW %d\n", err); + return err; + } + + if (!is_valid_ether_addr(mac_addr)) { + dev_err(dev, "Failed to get valid MAC from FW\n"); + return -EINVAL; + } + + return 0; +} + +/** + * rnpgbe_reset_hw - Do a hardware reset + * @hw: hw information structure + * + * rnpgbe_reset_hw calls fw to do a hardware + * reset, and cleans some regs to default. + * + * Return: 0 on success, negative errno on failure + **/ +int rnpgbe_reset_hw(struct mucse_hw *hw) +{ + mucse_hw_wr32(hw, RNPGBE_DMA_AXI_EN, 0); + return mucse_mbx_reset_hw(hw); +} + +/** + * rnpgbe_send_notify - Echo fw status + * @hw: hw information structure + * @enable: true or false status + * @mode: status mode + * + * Return: 0 on success, negative errno on failure + **/ +int rnpgbe_send_notify(struct mucse_hw *hw, + bool enable, + int mode) +{ + int err; + /* Keep switch struct to support more modes in the future */ + switch (mode) { + case mucse_fw_powerup: + err =3D mucse_mbx_powerup(hw, enable); + break; + default: + err =3D -EINVAL; + } + + return err; +} =20 /** * rnpgbe_init_n500 - Setup n500 hw info @@ -50,6 +121,8 @@ int rnpgbe_init_hw(struct mucse_hw *hw, int board_type) { struct mucse_mbx_info *mbx =3D &hw->mbx; =20 + hw->port =3D 0; + mbx->pf2fw_mbx_ctrl =3D MUCSE_GBE_PFFW_MBX_CTRL_OFFSET; mbx->fwpf_mbx_mask =3D MUCSE_GBE_FWPF_MBX_MASK_OFFSET; =20 diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_hw.h b/drivers/net/et= hernet/mucse/rnpgbe/rnpgbe_hw.h index 268f572936aa..e77e6bc3d3e3 100644 --- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_hw.h +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_hw.h @@ -11,5 +11,7 @@ #define MUCSE_N210_FWPF_CTRL_BASE 0x29400 #define MUCSE_N210_FWPF_SHM_BASE 0x2d900 =20 +#define RNPGBE_DMA_AXI_EN 0x0010 + #define RNPGBE_MAX_QUEUES 8 #endif /* _RNPGBE_HW_H */ diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c b/drivers/net/= ethernet/mucse/rnpgbe/rnpgbe_main.c index d8aaac79ff4b..e4392ddfbce2 100644 --- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c @@ -7,6 +7,7 @@ =20 #include "rnpgbe.h" #include "rnpgbe_hw.h" +#include "rnpgbe_mbx_fw.h" =20 static const char rnpgbe_driver_name[] =3D "rnpgbe"; =20 @@ -24,6 +25,58 @@ static struct pci_device_id rnpgbe_pci_tbl[] =3D { {0, }, }; =20 +/** + * rnpgbe_open - Called when a network interface is made active + * @netdev: network interface device structure + * + * The open entry point is called when a network interface is made + * active by the system (IFF_UP). + * + * Return: 0 + **/ +static int rnpgbe_open(struct net_device *netdev) +{ + return 0; +} + +/** + * rnpgbe_close - Disables a network interface + * @netdev: network interface device structure + * + * The close entry point is called when an interface is de-activated + * by the OS. + * + * Return: 0, this is not allowed to fail + **/ +static int rnpgbe_close(struct net_device *netdev) +{ + return 0; +} + +/** + * rnpgbe_xmit_frame - Send a skb to driver + * @skb: skb structure to be sent + * @netdev: network interface device structure + * + * Return: NETDEV_TX_OK + **/ +static netdev_tx_t rnpgbe_xmit_frame(struct sk_buff *skb, + struct net_device *netdev) +{ + struct mucse *mucse =3D netdev_priv(netdev); + + dev_kfree_skb_any(skb); + mucse->stats.tx_dropped++; + + return NETDEV_TX_OK; +} + +static const struct net_device_ops rnpgbe_netdev_ops =3D { + .ndo_open =3D rnpgbe_open, + .ndo_stop =3D rnpgbe_close, + .ndo_start_xmit =3D rnpgbe_xmit_frame, +}; + /** * rnpgbe_add_adapter - Add netdev for this pci_dev * @pdev: PCI device information structure @@ -42,7 +95,7 @@ static int rnpgbe_add_adapter(struct pci_dev *pdev, void __iomem *hw_addr; struct mucse *mucse; struct mucse_hw *hw; - int err; + int err, err_notify; =20 netdev =3D alloc_etherdev_mq(sizeof(struct mucse), RNPGBE_MAX_QUEUES); if (!netdev) @@ -64,14 +117,66 @@ static int rnpgbe_add_adapter(struct pci_dev *pdev, } =20 hw->hw_addr =3D hw_addr; + hw->pdev =3D pdev; + err =3D rnpgbe_init_hw(hw, board_type); if (err) { dev_err(&pdev->dev, "Init hw err %d\n", err); goto err_free_net; } + /* Step 1: Send power-up notification to firmware (no response expected) + * This informs firmware to initialize hardware power state, but + * firmware only acknowledges receipt without returning data. Must be + * done before synchronization as firmware may be in low-power idle + * state initially. + */ + err_notify =3D rnpgbe_send_notify(hw, true, mucse_fw_powerup); + if (err_notify) { + dev_warn(&pdev->dev, "Send powerup to hw failed %d\n", + err_notify); + dev_warn(&pdev->dev, "Maybe low performance\n"); + } + /* Step 2: Synchronize mailbox communication with firmware (requires + * response) After power-up, confirm firmware is ready to process + * requests with responses. This ensures subsequent request/response + * interactions work reliably. + */ + err =3D mucse_mbx_sync_fw(hw); + if (err) { + dev_err(&pdev->dev, "Sync fw failed! %d\n", err); + goto err_powerdown; + } =20 - return 0; + netdev->netdev_ops =3D &rnpgbe_netdev_ops; + err =3D rnpgbe_reset_hw(hw); + if (err) { + dev_err(&pdev->dev, "Hw reset failed %d\n", err); + goto err_powerdown; + } + + err =3D rnpgbe_get_permanent_mac(hw); + if (err =3D=3D -EINVAL) { + dev_warn(&pdev->dev, "Using random MAC\n"); + eth_random_addr(hw->perm_addr); + } else if (err) { + dev_err(&pdev->dev, "get perm_addr failed %d\n", err); + goto err_powerdown; + } + + eth_hw_addr_set(netdev, hw->perm_addr); + err =3D register_netdev(netdev); + if (err) + goto err_powerdown; =20 + return 0; +err_powerdown: + /* notify powerdown only powerup ok */ + if (!err_notify) { + err_notify =3D rnpgbe_send_notify(hw, false, mucse_fw_powerup); + if (err_notify) + dev_warn(&pdev->dev, "Send powerdown to hw failed %d\n", + err_notify); + } err_free_net: free_netdev(netdev); return err; @@ -138,11 +243,17 @@ static int rnpgbe_probe(struct pci_dev *pdev, const s= truct pci_device_id *id) static void rnpgbe_rm_adapter(struct pci_dev *pdev) { struct mucse *mucse =3D pci_get_drvdata(pdev); + struct mucse_hw *hw =3D &mucse->hw; struct net_device *netdev; + int err; =20 if (!mucse) return; netdev =3D mucse->netdev; + unregister_netdev(netdev); + err =3D rnpgbe_send_notify(hw, false, mucse_fw_powerup); + if (err) + dev_warn(&pdev->dev, "Send powerdown to hw failed %d\n", err); free_netdev(netdev); } =20 @@ -173,6 +284,8 @@ static void rnpgbe_dev_shutdown(struct pci_dev *pdev) =20 rtnl_lock(); netif_device_detach(netdev); + if (netif_running(netdev)) + rnpgbe_close(netdev); rtnl_unlock(); pci_disable_device(pdev); } --=20 2.25.1