From nobody Fri Dec 19 20:32:44 2025 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A35163101D1 for ; Tue, 14 Oct 2025 15:26:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760455572; cv=none; b=azkWg3NcLAZfHDbA9LL120tde33yi1E6nIu3lgmNsXF/EPzfIHW4Uqz+ua/GJetWNGe72qxd8M3wyVf6S2m0akoV73uetNJlxUSMe7Sq7EiIwUnpbtxR5KBFS0XDl/i0R45rK9Sc+BIN3OgnVG6Bq904eG6zo5ivx2axzJ0ObrI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760455572; c=relaxed/simple; bh=CT1bzRQQrvXj1L+037G7R/WgnGR8oL5lCpFHntM/vIk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HhUcPyHD98TLp3SbUT6UWKN4ep10jRxRenjiWWL/Cw5aY4YvEbCgaMqVsnEgBaC9iBfnmJyFWMd6QbEEtznl42Fd3hpS6sBN4cnhgqvsQNyToxMmhv6eIMxFJlJ0n+G7gKJ7/7IoipgkfCZMVRHo0DF6dTbQ2Y+YjncpteueV4g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=f2EZJFRX; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="f2EZJFRX" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 182AFC09F96; Tue, 14 Oct 2025 15:25:49 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 225A6606EC; Tue, 14 Oct 2025 15:26:08 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3F306102F22A4; Tue, 14 Oct 2025 17:26:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1760455566; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=mE1ukws3xTG0cWL7icCcyRG8jWl2qscLbVc2UTcXqFk=; b=f2EZJFRXZ2ZMTUGjPe0bCerWThWyVyi2zbMaXj9oz8T3vpnH3OvmcydG6O8+fUulfMx5Ii lzxzSS739wVNf95F7NiIgRaIEabJYKL4p/O1Kp9e/uA+flP8kQnIP+vE3lvXoTJVAkDlwL VeitrSCQt8jbIiBNWd9A6rMhi4ud0g9siQ6D4eQbyS7mV9vvTy219/zmWJUI6IMRKsFlKO M1sQXAnmBDvzFNcje/6DficfL3GAvJdipe4MBQ6LJSwmczh870JEzSXdDnC7HVL6aZ/tRC klWSx+Ee7/A0OTRFKljapsTBYWB8kKmAOvpSiBFWNZ5DNeH30WuMiVs0eaCvDA== From: =?utf-8?q?Th=C3=A9o_Lebrun?= Date: Tue, 14 Oct 2025 17:25:15 +0200 Subject: [PATCH net-next 14/15] net: macb: apply reverse christmas tree in macb_tx_map() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251014-macb-cleanup-v1-14-31cd266e22cd@bootlin.com> References: <20251014-macb-cleanup-v1-0-31cd266e22cd@bootlin.com> In-Reply-To: <20251014-macb-cleanup-v1-0-31cd266e22cd@bootlin.com> To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nicolas Ferre , Claudiu Beznea , Richard Cochran , Russell King Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Kondratiev , Tawfik Bayouk , Thomas Petazzoni , =?utf-8?q?Gr=C3=A9gory_Clement?= , =?utf-8?q?Beno=C3=AEt_Monin?= , Maxime Chevallier , =?utf-8?q?Th=C3=A9o_Lebrun?= X-Mailer: b4 0.14.2 X-Last-TLS-Session-Version: TLSv1.3 The arguments grew over time; follow conventions and apply reverse christmas tree (RCT). Signed-off-by: Th=C3=A9o Lebrun --- drivers/net/ethernet/cadence/macb_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/etherne= t/cadence/macb_main.c index dd3b13fa304715b4629c20120a908262af106a2d..e15fcdd43d778c685dbb9273869= 04362b8dba8b9 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -1988,14 +1988,14 @@ static unsigned int macb_tx_map(struct macb *bp, struct sk_buff *skb, unsigned int hdrlen) { - dma_addr_t mapping; + unsigned int f, nr_frags =3D skb_shinfo(skb)->nr_frags; unsigned int len, i, tx_head =3D queue->tx_head; + u32 ctrl, lso_ctrl =3D 0, seq_ctrl =3D 0; + unsigned int eof =3D 1, mss_mfs =3D 0; struct macb_tx_skb *tx_skb =3D NULL; struct macb_dma_desc *desc; unsigned int offset, size; - unsigned int f, nr_frags =3D skb_shinfo(skb)->nr_frags; - unsigned int eof =3D 1, mss_mfs =3D 0; - u32 ctrl, lso_ctrl =3D 0, seq_ctrl =3D 0; + dma_addr_t mapping; =20 /* LSO */ if (skb_shinfo(skb)->gso_size !=3D 0) { --=20 2.51.0