From nobody Sat Feb 7 21:52:54 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6CE314A8B for ; Mon, 13 Oct 2025 10:17:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760350667; cv=none; b=jdWosAehae0CkHKVIq8K9c9HroJWMbg6cfEEneV/SMr4KOLfntpn0Ic8D4dqE4vtKwkWUOQ1sCF9ieJ3Q8VzAAXzDMkYfwRn3Y6c23px1pCpHzOlHaYiILyrqHt50XUZGru28trQFo89EXqxWMknag1Cl7mo9l/OROqLRl059VI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760350667; c=relaxed/simple; bh=fLqhCB9ZHaE35jEAvUwL/XlQACvFsJNj7NN+aAdIw+E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UOuh+tP2pmc8qm/v35n6jMWTX6JSbCEPFxxPUqdbTeQ3YFVX94FizyojALMPuDMo2Ds7vwk4otZ2/O8dcN6YqkF2t+qDPn+WW0Xr7+HHWsJlRjRCNOvVeog83NL84DpGnfszfWygNwl27ob9DSWzWucpgSgF5o5N2nBUBbchi9c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e3qX2/5i; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e3qX2/5i" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-3304a57d842so3327308a91.3 for ; Mon, 13 Oct 2025 03:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760350665; x=1760955465; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rL8Zvity0qBrpOIGKiLq2gATcEJ0bdlrudF1QRk85so=; b=e3qX2/5iepCXH6WkrSyxJe7ORCQ8SRV46El9RZmkR9AV4HwElRyK5OFc4nLFWqN1tR gnoeHcNW+nIS8o9uiAV/SE1Q7wl3F/qE9E+mee3jeFpwZk0rH2a3+8OAaUiapa5W9yfd x2zFo6OEod/Fz/y2Q76TpjFZqPfhGw8ntS9SXeTAoD4jwQySMmTGK0eUUbI3pHLI6YVH EQeXTy9Rf2qdt4Uj/zPNtaD5CEJN7UK1yXFM+T2gdrMiUykhhDWw4eN+Sr6J51Ep4aAB DarIacU/aSAQE2TRaE39UJXVQ4L+HKfRfv5p7XX2mMicXKJ53h9IQOHM6kP2NtygFNKb X4xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760350665; x=1760955465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rL8Zvity0qBrpOIGKiLq2gATcEJ0bdlrudF1QRk85so=; b=uuSQv5x4/KIJNhjoV/SMIYW1p25nRSnvTfSrfa+7bsiDTFnPvbNt40P/JgRTa1D37D X5/dJsDU0r6Vf2sEzHV9n8EcY3kSzzLUWS1kHRD27DBpqp7vP0Wby/gIzjNoLohDaptd 4Y4Ezpm+UZECtbodmzr9Dkx/aqfGOPBq+hOI2jG9Ut3vE2qPSDZCVYve5wjV+CFjHbVE 1X7MfM53OGlm2xgBzU68Y8yi845nn3ieiOkZWj5W2zaUGDo+8JRhFoR+s/hDJTyTIMtz FRZj0xmHtxAB56egUeTH41TaQhRO+v0xK+XOs40/kLt5UYx9ldGrYFCs3BZyjBPpXSv8 RPpw== X-Forwarded-Encrypted: i=1; AJvYcCXQckCcUpx40hrMEsSnT9auZWAAxjbS7U+Alal18a/6eKTkEG6bdMck5zUS+3RavV5qEoGzFsZ/MTDPAi4=@vger.kernel.org X-Gm-Message-State: AOJu0YyxK3X6mT1uakD8PhxFeWj487j6469vnLWgeUEOCy6WVwlFTPf3 6hPjy+ZZYQodYoqpmoDm+yd3GUvr7bcykMfq/toaoJUUa6xNX4nO6WMR X-Gm-Gg: ASbGncvm5uCp/tbMq6h7mLcRmxH4ImJaXwYoskqB9cPn/t1tQ34w4YSxoQgmPh0PpRB T7gjSHlUHLB3/U5kPviNshhPsYvikjcE7+5fPTlA0pLC3qj7jQbj08OO6ucyjcc9QmAYNUZTMcJ Th1c+xmOJNkOEuvGgPp5iEpIEw4a/IjhSNprtLVx1sNCHA7OilR3ZmJd0Jlmlg0VS5Dso8Ss4gN 13oE7X7gOTSU12Gc+4KWcfMXepFhqjSLZnXPg6Xm2/gfmeHr9EcifVflUM8m17x8VS8BMArKrc8 bmEqCVvSz5YqCgYPFtYoaw7K/7kDqzREiCd4xXucxNU4oGKJAyV6lidpNe0kf9JUXtPyuPZN/tH NZUa3ERI2V1jXWjki3y75At3kxitqMuaN4aakmh7gw5tDOOomcQ== X-Google-Smtp-Source: AGHT+IHcngJ21CdNAU4iF9jGL+GrQ8wIh2V4zG56kXYLEpN2UR66JICC8m/eBuKADrldWfXWqWJEAw== X-Received: by 2002:a17:90b:3846:b0:339:a323:30fe with SMTP id 98e67ed59e1d1-33b51168e73mr29465661a91.14.1760350665091; Mon, 13 Oct 2025 03:17:45 -0700 (PDT) Received: from rockpi-5b ([45.112.0.108]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33b52a5656dsm7422864a91.11.2025.10.13.03.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 03:17:44 -0700 (PDT) From: Anand Moon To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-omap@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-pci@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR TI DRA7XX/J721E), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [RFC v1 1/2] PCI: j721e: Use devm_clk_get_optional_enabled() to get the clock Date: Mon, 13 Oct 2025 15:47:23 +0530 Message-ID: <20251013101727.129260-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251013101727.129260-1-linux.amoon@gmail.com> References: <20251013101727.129260-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use devm_clk_get_optional_enabled() helper instead of calling devm_clk_get_optional() and then clk_prepare_enable(). It simplifies the error handling and makes the code more compact. This changes removes the unnecessary clk variable and assigns the result of the devm_clk_get_optional_enabled() call directly to pcie->refclk. This makes the code more concise and readable without changing the behavior. Cc: Siddharth Vadapalli Signed-off-by: Anand Moon --- drivers/pci/controller/cadence/pci-j721e.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/contr= oller/cadence/pci-j721e.c index 5bc5ab20aa6d..d6bbd04c615b 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -479,7 +479,6 @@ static int j721e_pcie_probe(struct platform_device *pde= v) struct cdns_pcie_ep *ep =3D NULL; struct gpio_desc *gpiod; void __iomem *base; - struct clk *clk; u32 num_lanes; u32 mode; int ret; @@ -603,18 +602,11 @@ static int j721e_pcie_probe(struct platform_device *p= dev) goto err_get_sync; } =20 - clk =3D devm_clk_get_optional(dev, "pcie_refclk"); - if (IS_ERR(clk)) { - ret =3D dev_err_probe(dev, PTR_ERR(clk), "failed to get pcie_refclk\n"); - goto err_pcie_setup; - } - - ret =3D clk_prepare_enable(clk); - if (ret) { + pcie->refclk =3D devm_clk_get_optional_enabled(dev, "pcie_refclk"); + if (IS_ERR(pcie->refclk)) { dev_err_probe(dev, ret, "failed to enable pcie_refclk\n"); goto err_pcie_setup; } - pcie->refclk =3D clk; =20 /* * Section 2.2 of the PCI Express Card Electromechanical --=20 2.50.1 From nobody Sat Feb 7 21:52:54 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C6432FF170 for ; Mon, 13 Oct 2025 10:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760350674; cv=none; b=CZh+UkdnHlOTAN8M8gHllL/b9sKkw3l5McQuSDVpwk0x/8YrYIhBsWjwfFoK4OzmEIDyc8qH0dBVYYuWFircaQ2oMtKLHWGSicwVH9QpF5cTRFlslxDoOvBHvhxr1pABeFGky5/ZYmtosvsvVltfP2MGL3uHCzCdo75bmTAGnKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760350674; c=relaxed/simple; bh=gNh1Q25ZNGRtB3EJ1DwzkXZengb0FpJ74GxfaGXFVu8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TfmAXpH2uNt6CmOCCUGs5xtqRWuRdr09M4JRoVA0p70stNAH/1C+87ijGGr9ql93s7DQ2L9QJ+WvBkXEHSiwobQEKf7k2Rrh/r20K0E05UMFql6MIupmYsqMrJ7vXyxapip2u7XAOOFfS+MQGXH5Rqs68Rq2+36SekWE7gsmesU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ajHd53Uu; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ajHd53Uu" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-33082aed31dso4196200a91.3 for ; Mon, 13 Oct 2025 03:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760350671; x=1760955471; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=19kHdtY5ZhpAxDQMVT/2nG/beuKDqoa8OjmMddMbQbE=; b=ajHd53UudJG9M7Br4Ob6S4j01SwITX8ETUlwysJE9vrgDAva67AoEdTzmOOyypBe4Z 0500bfcaRTIOo5/VQ0h231a8WJZVJu1lrZOQ2uCEv07RQKH/fFkh2Se2ifBPDYGe42Qt GXDbCp4iJQbf9gePk2Lp9A/6/EljtPvW5iSBEvrSUwvl3t+AxujQ1Ox2TsS6LtkDqEeL uqAWH29HRRrB2sGVoQv0CLC10xr/4yq1UNa+7vEmu4oENc2q+NFKoaLFPt39FzIDx5ON T90TmL7kTXu4EuZ/Poy9LKfE2rXeK6XjC4O8THgAdcWaRKYIPpEzDX2iZ5H7F0ibIA4Z sWCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760350671; x=1760955471; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=19kHdtY5ZhpAxDQMVT/2nG/beuKDqoa8OjmMddMbQbE=; b=ozvREOUeesseKH1/9BWvJ/SJ6ShVOx5Vs5PvTc+XcB9hSk80Uwuic4bZrBQ6hnRVrC raXqrJa0I8peGyncCfPjYJn0GkWPdOt+VgUZiXPA8BV8Az1ZARr5hMYi6zXrSQbnC218 Orz1B7mgXDKC/5knZqmx32ME8e4jX50yIi8Ln5/ER89XVZ0H3aGxFBhQJr5J35QogPMZ 3dqjFIdq6FKFOa4zicxsslzIgvj2QO7DRXFGXtdZmR+k67VlPsB/aPSiW2xlOZtbFAzV Kj1qGgZCRVEYYfyVOsphe6PsP+B9u6w+/1tENWRte4GguKS40zhWqnio3GAxwIAPiv1S 8n/g== X-Forwarded-Encrypted: i=1; AJvYcCViNOJV+6Do6oZFOtabOMhgapbf7lKaP9uTYpff7K3s/w0rxngxpUjB0Md5RT9ElXfN2tCtOgp4YgV/0Bg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/9cv1OaE5HSUKTscRnC9aKmuOlA15EYkVH9b9ChkYeeknIJMi 3N8oXoSot+LvAnPS24neXpY8O4F1seGuPTGNSuK6Zp2z1BVIS7YSFn4aFB4MNhnM X-Gm-Gg: ASbGncsxmr2bi1ZStiAvUHNL0OOp32FmawCrtk5hPIV3FsCIESHbdc4DfikrkeHLjzJ svhIH89I8el2AdiLuNg4ErCB/4NNC92x1F5tuDOzoB1e5+aF/bZA5q0KqTtD8B4+0zFWqSbRv1g WvgQpTt2oz+77WU5E3mzoHrpYiNHjVX3bTysnbhACBCkq2GaWDFg13agYO4Y6MMcCEwep1bXoB1 VwDkIOqkyHf29Jf/J7oKhB5M5JwwEfuVQGN1RPVpuuZbAkUE3c9gj0Xrv2HWBzF7VEr4ea8qEAe NO5v7vd0siNBxua0SEYgwf4h1JnusLyhCMimbYcDeNZkwGW9jRlSQkRH5NEgwU3wSZsouzMmM8b 0kNoX7ujFcfex7i7vQTCLQZys9aX6MWKxX7iiqFQZIAqgDsikfQ== X-Google-Smtp-Source: AGHT+IEyZirSf3fnKNnVB5Ye7lidBycAPJF9I2FEB25F5npassyZdVGtvN5Z0VaAFP1R3FsWO44BJg== X-Received: by 2002:a17:90b:4990:b0:338:3b73:39ce with SMTP id 98e67ed59e1d1-33b5138e3a7mr27708156a91.25.1760350671380; Mon, 13 Oct 2025 03:17:51 -0700 (PDT) Received: from rockpi-5b ([45.112.0.108]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33b52a5656dsm7422864a91.11.2025.10.13.03.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 03:17:50 -0700 (PDT) From: Anand Moon To: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , linux-omap@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-pci@vger.kernel.org (open list:PCI DRIVER FOR TI DRA7XX/J721E), linux-arm-kernel@lists.infradead.org (moderated list:PCI DRIVER FOR TI DRA7XX/J721E), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [RFC v1 2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable Date: Mon, 13 Oct 2025 15:47:24 +0530 Message-ID: <20251013101727.129260-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251013101727.129260-1-linux.amoon@gmail.com> References: <20251013101727.129260-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change removes the unnecessary local gpiod variable and assigns the result of the devm_gpiod_get_optional() call directly to pcie->reset_gpio. This makes the code more concise and readable without changing the behavior. Cc: Siddharth Vadapalli Signed-off-by: Anand Moon Reviewed-by: Siddharth Vadapalli --- drivers/pci/controller/cadence/pci-j721e.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/contr= oller/cadence/pci-j721e.c index d6bbd04c615b..1ece4b183dfa 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -477,7 +477,6 @@ static int j721e_pcie_probe(struct platform_device *pde= v) struct j721e_pcie *pcie; struct cdns_pcie_rc *rc =3D NULL; struct cdns_pcie_ep *ep =3D NULL; - struct gpio_desc *gpiod; void __iomem *base; u32 num_lanes; u32 mode; @@ -589,12 +588,12 @@ static int j721e_pcie_probe(struct platform_device *p= dev) =20 switch (mode) { case PCI_MODE_RC: - gpiod =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); - if (IS_ERR(gpiod)) { - ret =3D dev_err_probe(dev, PTR_ERR(gpiod), "Failed to get reset GPIO\n"= ); + pcie->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW= ); + if (IS_ERR(pcie->reset_gpio)) { + ret =3D dev_err_probe(dev, PTR_ERR(pcie->reset_gpio), + "Failed to get reset GPIO\n"); goto err_get_sync; } - pcie->reset_gpio =3D gpiod; =20 ret =3D cdns_pcie_init_phy(dev, cdns_pcie); if (ret) { @@ -615,9 +614,9 @@ static int j721e_pcie_probe(struct platform_device *pde= v) * This shall ensure that the power and the reference clock * are stable. */ - if (gpiod) { + if (pcie->reset_gpio) { msleep(PCIE_T_PVPERL_MS); - gpiod_set_value_cansleep(gpiod, 1); + gpiod_set_value_cansleep(pcie->reset_gpio, 1); } =20 ret =3D cdns_pcie_host_setup(rc); --=20 2.50.1