From nobody Sun Feb 8 10:29:54 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A5B934BA34 for ; Sun, 12 Oct 2025 11:43:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760269434; cv=none; b=fgdNV7uf35EGhat5JLGspvqqAaT3nNM7MIkdvzviwlo8ajtrfzooY+qOAg+SSrylQLAy63y5aY2JIB6FR5DguIhFkV2aDaum9LWbUrvm0E8atBosam5zuCIoPUAIDtQPRNJmz6x9bitXNFFI4K2XkMCFUb1EzPkHqPlIomGAjJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760269434; c=relaxed/simple; bh=6y/+Ym+lfn1LpRZEISDxrN4k0+KtYrti9fdNPHotsvE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=YAOjzRQvJGhzKXtIJlk5yX/gB4E0/7L+XNkUpXJSJJKDbmZZ4fpUylcIk5+iEbPvPx+WOmwlFBZUKDyBmS9vpGgKhEQPspRPbqcA0LB/2LuKJw1fvYJtxUwi/l585aEsUsEdeL+fHdW8Y55ISLrpPiSs5DFuRiDcCzITVh0huiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l1zRWgS4; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l1zRWgS4" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2699ef1b4e3so6904485ad.0 for ; Sun, 12 Oct 2025 04:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760269432; x=1760874232; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=USHDG0+JmOBcx0jbr24WMthkctDA2Gayuw3MyojmYCQ=; b=l1zRWgS4a7U4xYW+l7OhOONwUslMDXWL74ig+1Nj5YSfBKqt30ToB5nSw7dIHnKUfA 8bGr3aGntwwmcBQ/oELp4WLqDGvL67wFgyAzr3MEVS6G6o4so+ehCWCkQY4fzfnhHml2 wb5JERk9v4eBrypHsOm0138HGPLKKHcrGF25qzbeHd7v76hWek3oGaWtt8RO5bpD0NQv QDWlWMsx1Lx8/tHgq3bXLqDDoMryqnbMHCm21ipUmKmTxmc/5h3TkPVdqyvoMY5SRNor k242dwmcnnZswpYdMn9roxCM2DjrNuu5bFNVzR1huTemxmrJJQMbox05M+kxoKjuN4Yj IVTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760269432; x=1760874232; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=USHDG0+JmOBcx0jbr24WMthkctDA2Gayuw3MyojmYCQ=; b=XJxlguPoFcthT9M1xrv7QYs79S3T3PNdE62ajr6qhtt1eAGgNBqy0h8swbUxD7VO85 A0mdxhCUUSAiZCUW6xhk0ZnUZqcbCCLy4Y15EfEc6L2fOllLgRfOzCaz++G8Ry+4jEmi Ly7p9weHV+Sqe5rqSRS1KDLvEIxVV7F3fp2mRVpk1Ok7YdYm/KYZLy2KniwkD9YqhqD7 LQdpa0YR/Z0HFX3VugNE1uRqCFVWNLvEkIloYCzvMcvQ/cuxYZzf1+ATTt/f/LDYAClL gYWF675OxMjstXYYZPiTtIV3sJlLko7BJttNqJkGG/0CiNc7GGiS1mnWP0h3SNMOoci2 oh4Q== X-Forwarded-Encrypted: i=1; AJvYcCXeMQjwHDYVfRloAPQd7GIIC+IfuNc6oI0K93gPt8IOgwHHei3LJ4G4LI7+Q+xRhqvJaPLPxEgYs8vvF+M=@vger.kernel.org X-Gm-Message-State: AOJu0YwYbNebxfQqiEZItQ7h4v9xO1Y5xjkn72kCG1qcf+7+ORK8jAFF KWURpfXx2Y6Oseus9WPob23U54a6Ty4ru3ZPFuonC0R6kIaEegi6J3Ih X-Gm-Gg: ASbGncsvmDAdMSM/bJWJ6qaInodHZRrhFZxeR1G0ZZ0QUFhj3snwqe6BILegSo6u9L7 4dNTi+sbe7Y6OC6E7R+q7dwBw4b+NYYJ83DpwdQKxsVzedjF4R2ZS0Yd2vv2hLxHjWmyLWZL2KF gvS846sA01mHrN9KbuJwawK9vx77Nz7/btMKWqtW9aJ8w0Rnw+9GWT9BcuxDV28LNep+0T9pQ97 6xPgbkTcSWtCixWF2p25ZGLboBhmBbTHWrT5GHKOwSosihZiH09pLOwr4k/hFRcu/6fIBeSCCNb 47+ggnJoBcSejgwloZK0Su3SfjzQLFUEPO+Qoj76GB1TnGrvooSc8Y2dU11kBx4EWikq800kkrI bs3eC1uQ+79yfLlVY4GQmvmfBblLzSE2FPSsxWOnWAMdQQt3GGql797wQF2O3 X-Google-Smtp-Source: AGHT+IGypspxQsTm5Mkv7DMf7X8k8qJOWGtMt9Bw/674OqX23p3nDn2lBbAGZaVVMBIMGceLwJVYEQ== X-Received: by 2002:a17:902:c40b:b0:267:b312:9cd8 with SMTP id d9443c01a7336-290273038efmr116023985ad.8.1760269432532; Sun, 12 Oct 2025 04:43:52 -0700 (PDT) Received: from [127.0.1.1] ([2406:7400:98:ffd0:f64e:1796:666b:a343]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b678df2799esm6454765a12.29.2025.10.12.04.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Oct 2025 04:43:51 -0700 (PDT) From: Ranganath V N Date: Sun, 12 Oct 2025 17:13:27 +0530 Subject: [PATCH] hwmon: sht3x: initialize variable 'ret' in update_interval_write(). Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251012-my_driver_work-v1-1-9e5fe6de51f4@gmail.com> X-B4-Tracking: v=1; b=H4sIAF6U62gC/x3M0QpAMBSA4VfRubayI2leRRJzcJLRWQ0t7265/ C7+P4InYfLQZBGEAns+XILOM7Dr4BZSPCUDFljpQqPan34SDiT9dcim6npEtFgaMgZSdArNfP/ DtnvfDwQrpJZgAAAA To: Jean Delvare , Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Ranganath V N X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1760269428; l=1589; i=vnranganath.20@gmail.com; s=20250816; h=from:subject:message-id; bh=6y/+Ym+lfn1LpRZEISDxrN4k0+KtYrti9fdNPHotsvE=; b=c32/ZK7DyB+6pjgQZVueqDLfafDQshNuAblaXCyCNg+tKBhX5RvTz3FbAK5Fih8rmsxzW5UIE tk3EPXRTEnGAmnat/t6dYfp9H2GaW7t6k2be6+6nAhF9POM4VyLRxCT X-Developer-Key: i=vnranganath.20@gmail.com; a=ed25519; pk=7mxHFYWOcIJ5Ls8etzgLkcB0M8/hxmOh8pH6Mce5Z1A= fix for the smatch errors: drivers/hwmon/sht3x.c:606 update_interval_write() error: uninitialized symb= ol 'ret'. The warning can occur when both the data->mode and mode which is derived from get_mode_from_update_interval() are zero. In this case, no i2c command is sent and ret remains undefined before reaching the coman return path. When both data->mode and mode are zero, the device remains in single shot mode and no configuration change is required. In such cases, it is correct to treat the operation as successful without issuing any i2c transfer. To address this, initialize 'ret' to 'SHT3X_CMD_LENGTH'. this makes the no-operation path return success while keeping the existing error to all other paths. This change removes the smatch errors. Tested by compiling. Signed-off-by: Ranganath V N --- drivers/hwmon/sht3x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c index 557ad3e7752a..4b52d57eaad8 100644 --- a/drivers/hwmon/sht3x.c +++ b/drivers/hwmon/sht3x.c @@ -553,7 +553,7 @@ static int update_interval_read(struct device *dev) static int update_interval_write(struct device *dev, int val) { u8 mode; - int ret; + int ret =3D SHT3X_CMD_LENGTH; const char *command; struct sht3x_data *data =3D dev_get_drvdata(dev); struct i2c_client *client =3D data->client; --- base-commit: e5f0a698b34ed76002dc5cff3804a61c80233a7a change-id: 20251012-my_driver_work-77b22c239e99 Best regards, --=20 Ranganath V N