From nobody Fri Dec 19 10:35:33 2025 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7527970808 for ; Thu, 9 Oct 2025 19:06:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760036787; cv=none; b=u13bW5CYwsJhjql4lqnjnj2Ai8Z5VpSQqoGs0lZh+PLZBK/XQ9ZGJ536a616kvI6hdHC1YhmrdP7HhS/Drmr7i17d54PeghoiD24xFYPyGpUbMIBhceofPWqmcO2gBECMEiWJAkjqciB6CCc/fW6nvjpO20j3pqaTcxStu+t2cM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760036787; c=relaxed/simple; bh=ddLCZ0Erq4J+fD+SEojwpwJBX3/dCdE8Jy+xB1E/FKc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uLJ2PNnzWUDOG2SH/mz99gaJONjUOlWgAifL8hVs+srO6RSp2m/vPc4oghXoxU143M/4hDWCRzFvWUCM8deQQlgG3wtdgug6JLUGsE0moGWeu0TioF9D5pCmK2P3s/uabZ5legkMbYFV9UAvXPFzMThqulHtkLEfEfFwjwC85WI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QuvQxGL3; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QuvQxGL3" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-339c9bf3492so1713468a91.2 for ; Thu, 09 Oct 2025 12:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760036786; x=1760641586; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JEjGknaIQTT5zCZesWXYRLiR/b6Jtfo4VUqPR/aQN+c=; b=QuvQxGL3qJSUDIrk16yTSZbMAzVfSwjOk0rReFZkk1ldmXdX3DOenttBNbucot8BLO buzqt7OZOEwIeEwqy2UsWxFkvC8fN8bBkXtr3Ig+q4U/P/cF0HzRsS4Tl/+mZJLAvJ8x 9Rm4dNi7R8yOUFq4t63Xt1jcfE/BTK2DrYgN8G0LW+OYmLZzDkVbgSw7+8zkwy/o6Qu3 +mYmIFaShEjzvEtJfNzBEdNw/c/a1ClIWIwdiwMW8SZkLY1JeTFIPMK+m7OT1WQtXI/C mg5i5RJa9KfutLiQrkuSVXQmbkBsnh50v8/3fYcAS8TZHa1ucJMF9xlfJbEPYECELZmV Vs4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760036786; x=1760641586; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JEjGknaIQTT5zCZesWXYRLiR/b6Jtfo4VUqPR/aQN+c=; b=dRrbHl0hIu38T6LoDPJEVVJyuDz5DABQlmHOl17onUBEPgR01qRnfkOQ1V+Bk9tX4E ZbEnJqJBkXuzam6cZciI4l/U5MvlbIy6wQzh50DAZM5a+ZtpmV5HAhVw53cp/zuhsbND I6rtEqRXJrorm2h/KN8hb49wfg4KbX1EXfPr3SVEsiJin4AXGjf5PTge56MylYEnXNHh g2jJd1Lp64K9wy6dykzXZlzcB2K2yEt/j3rCy2z/RCo6ryintGVxMSPDWBgFkOVF1HPQ k+YRVuZ1X3w3/tsCowP2Ogumx4nLVRK6AmHaBQO/RkETY49JtWOzMMlB7KHJw4m5xJ1v D/sg== X-Forwarded-Encrypted: i=1; AJvYcCX71yTo1Q/sf84EW+yE/EkVysL6S09JuWgHlL8kLc3qKDXVVnh9Z0FWki/J1M+j6v9xEyBFqHsKgQJ3NDo=@vger.kernel.org X-Gm-Message-State: AOJu0YxVzFdUnBbyRh5yXA1wrlUXY1Ay/gkIXzb3qVJ9rajH/3n+cFMf 61QSBjyKP4d0ZaulMuHY1A+0NjeQ2wdod8msdlXQpt5yDxhxQGc9YfvJ X-Gm-Gg: ASbGncsJAQ81PZNGeEMy5LPavgfuPLc4vO5M23fP6H8oHkBahdtsgO+qU3zg6+ffyaZ H+oIM6XwXap/glSSJOmJA4yJT+Amcd6P5il6CKVIz8z8GzJKTKB2T/Xwtjc2Qfhk2dI5Cfi6r+q TJE2qJEZg2VYfMWUZoFMCgnCJQgPf0bN66MS8k17Dn90Fcc0eVn16uYPe2tshPsvOFsftoK7fPy q/CVRyxAvVgYHQzR/1LG0ry6lbQhYZfet5R2+171V+W0whLTugDj6ef2y0AWLQBdb+yasFBXFq4 VOTePXKsPjjAWOcf7TLeZ2EsbxdX0v6Tv0FjBEzEcRz3UTL+aFUmQ4JfGBKjuDaPNMePP+fOg1B bPRGJcEUoEVjSX/DFVTx0/AjnwkGP5EztdE5fwCqFnky8JVzIpxwuRyTnWQ== X-Google-Smtp-Source: AGHT+IFXUt6VUamHbHYZHs4517klUwXoUlo89uzt3GFSwzjhloph9wZ5hjH2CwLWBaE4x3gtGf/L2w== X-Received: by 2002:a17:90b:3b50:b0:32b:8b8d:c2d1 with SMTP id 98e67ed59e1d1-33b5127ba49mr10126458a91.21.1760036785539; Thu, 09 Oct 2025 12:06:25 -0700 (PDT) Received: from mythos-cloud ([175.204.162.54]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b678df4ba7fsm350174a12.32.2025.10.09.12.06.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 12:06:25 -0700 (PDT) From: Yeounsu Moon To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yeounsu Moon Subject: [PATCH net] net: dlink: fix null dereference in receive_packet() Date: Fri, 10 Oct 2025 04:02:22 +0900 Message-ID: <20251009190222.4777-1-yyyynoom@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If `np->rx_skbuff[entry]` was not allocated before reuse, `receive_packet()` will cause null dereference. This patch fixes the issue by breaking out of the loop when `np->rx_skbuff[entry]` is `NULL`. Found by inspection. Signed-off-by: Yeounsu Moon Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Tested-on: D-Link DGE-550T Rev-A3 --- drivers/net/ethernet/dlink/dl2k.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethernet/dlink= /dl2k.c index 1996d2e4e3e2..aa3840454fcb 100644 --- a/drivers/net/ethernet/dlink/dl2k.c +++ b/drivers/net/ethernet/dlink/dl2k.c @@ -969,6 +969,8 @@ receive_packet (struct net_device *dev) if (pkt_len <=3D copy_thresh) skb =3D netdev_alloc_skb_ip_align(dev, pkt_len); if (!skb) { + if (!np->rx_skbuff[entry]) + break; dma_unmap_single(&np->pdev->dev, desc_to_dma(desc), np->rx_buf_sz, --=20 2.51.0