From nobody Fri Dec 19 10:25:40 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AB8221FF21; Thu, 9 Oct 2025 16:18:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760026686; cv=none; b=JIfGVT4ce0Abx4fruy2KfPmqo7+O+2iS9R0e8++5DqP9Qs78cDCNKiJz/O5SIeBqMpa3CIqu0NpAEKZpjgH//fcx5wSu30sORsctgv+bcAp1n8Kbe9PmUBALJkMakxdqju2sb5cu8YRlZIJwI1OjCpExXk7UoBnrx0WPpL5s5ZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760026686; c=relaxed/simple; bh=HSSJ1Qaqpo27FTDdPNyDDR5M+Wsq3o8Vh0hTZZ48Oxo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PMzzRHY+PCfS8WzxE08JoykkPeFR6gshbHQoeuumtzqQt8GJydVYmZULUqi+kX7EU5gCPuTHKNLlLi1kwJQjiQo2ZXWEYPp9BcwypetsOIHh6IJsvDgJLi7p6pPKq5WexaW6a2bPaHcw9mMPRpkoniKME8i3lI5IPPMTd3aIDgc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AsoOXKMk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AsoOXKMk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6229C4CEF7; Thu, 9 Oct 2025 16:18:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760026685; bh=HSSJ1Qaqpo27FTDdPNyDDR5M+Wsq3o8Vh0hTZZ48Oxo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AsoOXKMk9v7ikFwDTnUPclRi8KyIfAK0Ub/8NLTf5/Lwbil9D5AA3AMTELwYnY53O F6R0/hUq43Ai+7rE9emBNVLwmxT7EysuQVfxttldmBRrDDxBDmh0TCkSVDEW6S60dY ZsW/MgyrpWTTnnq4JQkiL4S9n/6jxtLbKJYoLBbMByzTvVUmGH2xZGdz53avu/IHmP iqkD1qTSWSr+umHnIfhPx9+zCpESWkDDwXx0z7SWAYdBHUBZEP8bWpKf+4uTBYnx/1 7aW/8tekkkzNtBkKmoHUvQuV/Zopoc9QWBGg6d/i58gskf4G3/H5Nd0irefuhDrked 0qAD/dseKBDag== From: "Mario Limonciello (AMD)" To: "Gautham R . Shenoy" Cc: Perry Yuan , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)), linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING FRAMEWORK), "Mario Limonciello (AMD)" Subject: [PATCH v2 1/6] cpufreq/amd-pstate: Use sysfs_match_string() for epp Date: Thu, 9 Oct 2025 11:17:51 -0500 Message-ID: <20251009161756.2728199-2-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251009161756.2728199-1-superm1@kernel.org> References: <20251009161756.2728199-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rather than scanning the buffer and manually matching the string use the sysfs macros. Signed-off-by: Mario Limonciello (AMD) --- v2: * Drop NULL from energy_perf_strings too (Gautham) --- drivers/cpufreq/amd-pstate.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index b44f0f7a5ba1c..0bc5013448873 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -118,7 +118,6 @@ static const char * const energy_perf_strings[] =3D { [EPP_INDEX_BALANCE_PERFORMANCE] =3D "balance_performance", [EPP_INDEX_BALANCE_POWERSAVE] =3D "balance_power", [EPP_INDEX_POWERSAVE] =3D "power", - NULL }; =20 static unsigned int epp_values[] =3D { @@ -1137,16 +1136,15 @@ static ssize_t show_amd_pstate_hw_prefcore(struct c= pufreq_policy *policy, static ssize_t show_energy_performance_available_preferences( struct cpufreq_policy *policy, char *buf) { - int i =3D 0; - int offset =3D 0; + int offset =3D 0, i; struct amd_cpudata *cpudata =3D policy->driver_data; =20 if (cpudata->policy =3D=3D CPUFREQ_POLICY_PERFORMANCE) return sysfs_emit_at(buf, offset, "%s\n", energy_perf_strings[EPP_INDEX_PERFORMANCE]); =20 - while (energy_perf_strings[i] !=3D NULL) - offset +=3D sysfs_emit_at(buf, offset, "%s ", energy_perf_strings[i++]); + for (i =3D 0; i < ARRAY_SIZE(energy_perf_strings); i++) + offset +=3D sysfs_emit_at(buf, offset, "%s ", energy_perf_strings[i]); =20 offset +=3D sysfs_emit_at(buf, offset, "\n"); =20 @@ -1157,15 +1155,10 @@ static ssize_t store_energy_performance_preference( struct cpufreq_policy *policy, const char *buf, size_t count) { struct amd_cpudata *cpudata =3D policy->driver_data; - char str_preference[21]; ssize_t ret; u8 epp; =20 - ret =3D sscanf(buf, "%20s", str_preference); - if (ret !=3D 1) - return -EINVAL; - - ret =3D match_string(energy_perf_strings, -1, str_preference); + ret =3D sysfs_match_string(energy_perf_strings, buf); if (ret < 0) return -EINVAL; =20 --=20 2.43.0 From nobody Fri Dec 19 10:25:40 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AB1C21D5B0; Thu, 9 Oct 2025 16:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760026686; cv=none; b=miE0VnQOGgcFGOV9zom1mi5PH2cjkGqJTQWMvaadNXTr7tayk1tx5Pllxpzsg8yW8dOW+0YaDVZGaCuWF8u1enZAaRWhWwzOugFZbgXpGOPqe2uHUrJCPKKM6ubHc3TJcoOObKWWVuELYHO7JQGz8rPXv0eu2OdGU1evFVeAHzg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760026686; c=relaxed/simple; bh=qtGTM4ocQv+yktymuvzDr9klOqnGIF1RjjjPQWx2JWU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ndspTpMdn/KAnWF4jVYkTIC/YTDjrixoQdkzwJEQne6Qy1ZOC40D0a1Zf1icERNacjejt4bMIaJIZiPfduBjc851PDYgDsdGHGeEr5iXZQtD3GBquOFaAnOC7V4fan3UDrGYrj8LDoBNwGASHvd8E9Atkv1U+1KWLrd9TTOval4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FZjl+6gD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FZjl+6gD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82C6BC4CEF8; Thu, 9 Oct 2025 16:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760026686; bh=qtGTM4ocQv+yktymuvzDr9klOqnGIF1RjjjPQWx2JWU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FZjl+6gDMbXmfD7huwmwfCA0AZWlfvKV9kzXSgeHMXvOCNlZ6S/Lv30xC2nLcfJy5 5LuTlW13jkodgoqGUipTZmRRssXukozRlQBN7q3KsanNRZrECxwXiOTZx2kYKSnsVB AHKToqNd0MCkUw7Jx4EakQj8eE0lFPh++L3H9g/8tbbFjFnGtgpGxI42x44dKe6OJX AY7PhqD1QE6t2ts6qx8XZmHX+QrDC42uiAhsLBitoeo6ISwFfZZ1XkwIBXCA3C0jtY gZjMlvCx4VIR61xkoxoteJfdHV7biCyJX8sxxLXVyI7L/P28DE9W+byKAWh9xoxKKV 2jd0AMRloum9w== From: "Mario Limonciello (AMD)" To: "Gautham R . Shenoy" Cc: Perry Yuan , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)), linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING FRAMEWORK), "Mario Limonciello (AMD)" Subject: [PATCH v2 2/6] cpufreq/amd-pstate: Drop NULL value from amd_pstate_mode_string Date: Thu, 9 Oct 2025 11:17:52 -0500 Message-ID: <20251009161756.2728199-3-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251009161756.2728199-1-superm1@kernel.org> References: <20251009161756.2728199-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" None of the users actually look for the NULL value. To avoid risk of regression introducing a new value but forgetting to add a string add a static assert to test AMD_PSTATE_MAX matches the array size. Signed-off-by: Mario Limonciello (AMD) --- drivers/cpufreq/amd-pstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 0bc5013448873..a5b9e5baf4234 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -65,8 +65,8 @@ static const char * const amd_pstate_mode_string[] =3D { [AMD_PSTATE_PASSIVE] =3D "passive", [AMD_PSTATE_ACTIVE] =3D "active", [AMD_PSTATE_GUIDED] =3D "guided", - NULL, }; +static_assert(ARRAY_SIZE(amd_pstate_mode_string) =3D=3D AMD_PSTATE_MAX); =20 const char *amd_pstate_get_mode_string(enum amd_pstate_mode mode) { --=20 2.43.0 From nobody Fri Dec 19 10:25:40 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61C54225403; Thu, 9 Oct 2025 16:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760026687; cv=none; b=Dd9RKrzgsCKoU8kcA7UnDAS8R7vUfvA8X0ZfX6oERDGj8UZABgsIN3WVDRi0mrrQUUlJtCAng+LifEamVtlvBONZ6OcpmC8vpiVWjBbZMkJ4DsUnrUP8fhiA4xL9XgupRuqrv4SxEuMmjXVXHrUYGPMpCOUOuNR7/tRQNY7hmGM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760026687; c=relaxed/simple; bh=btMwNG95kFkM6A4AfAqNPbyfByjtAq5BN5TIgBVnsRM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Crz7XPRtPQS5D2k0OM9TqB/5wigjdbrR+mXxvfDKyQUofRHSD6aWXTO2F15XijcY0ouxFe7lY31x3P2kRm8fQzqec05IFClpQ0CET92Iczb+ptwPePr5vTT/mwjTKaQMpWg7WquBnH6NFNM3+N2IBr4HUyTPS+cP/8adGGVGsGU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t9Xs4NLD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t9Xs4NLD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50F91C4CEE7; Thu, 9 Oct 2025 16:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760026686; bh=btMwNG95kFkM6A4AfAqNPbyfByjtAq5BN5TIgBVnsRM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t9Xs4NLDDyJe+k+ivU9TTfICx/2Ydh7qZIrIoq4+5JTVMfmd7EYcJHYg08yNw1AcQ 4+uMXsdXHTOuCU0UvR939NEIs3EGTqwVM+4FDcpCoXqV5QKWB/JtLYxwnvZVscgnsh 3grug++NMafBoDNZzOc2OCKxMhcRWOlmr/OuKC9T8cZnXidHxjpjqY0MJP9a2ARpjA 4kNOyu9n5g2rHnLsxYK7/fKFXiPA7K4Qev0tQvxYLr85L49fcWIiMROsnke0HB7lGs 8N4FJglvvkIbQILcoHr0gs1zxDZ5bk0F6Yk1QbJDdTKOXtlzBtZ4MLfd6BixJW2TqV MP33u7rK6yFeQ== From: "Mario Limonciello (AMD)" To: "Gautham R . Shenoy" Cc: Perry Yuan , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)), linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING FRAMEWORK), "Mario Limonciello (AMD)" Subject: [PATCH v2 3/6] cpufreq/amd-pstate: Make amd_pstate_get_mode_string() never return NULL Date: Thu, 9 Oct 2025 11:17:53 -0500 Message-ID: <20251009161756.2728199-4-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251009161756.2728199-1-superm1@kernel.org> References: <20251009161756.2728199-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" amd_pstate_get_mode_string() is only used by amd-pstate-ut. Set the failure path to use AMD_PSTATE_UNDEFINED ("undefined") to avoid showing "(null)" as a string when running test suite. Signed-off-by: Mario Limonciello (AMD) --- drivers/cpufreq/amd-pstate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index a5b9e5baf4234..5feb9f5e3a491 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -70,8 +70,8 @@ static_assert(ARRAY_SIZE(amd_pstate_mode_string) =3D=3D A= MD_PSTATE_MAX); =20 const char *amd_pstate_get_mode_string(enum amd_pstate_mode mode) { - if (mode < 0 || mode >=3D AMD_PSTATE_MAX) - return NULL; + if (mode < AMD_PSTATE_UNDEFINED || mode >=3D AMD_PSTATE_MAX) + mode =3D AMD_PSTATE_UNDEFINED; return amd_pstate_mode_string[mode]; } EXPORT_SYMBOL_GPL(amd_pstate_get_mode_string); --=20 2.43.0 From nobody Fri Dec 19 10:25:40 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BCA122F77E; Thu, 9 Oct 2025 16:18:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760026688; cv=none; b=qBLcOuEu7zonK63aBOVrt5eW/nV3TQ2uUZ3j4/XjraeQazCNDcTADNGKh/fCcFMh5H/TESE/5/8se6LZ0jqrSzcaII418kVY1SQJe/SjskdzcoIw/pS2/dSaQqm3WSpQPuzpHIA85jtzdnlWuSIf/kVPlwUAGpnXvMY13sF8dT0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760026688; c=relaxed/simple; bh=46QjrBY51KkQ/h8L2AvGf466oaYcMm8u//jJges89zs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UHFh/atuwZ2Nl5NjcL5T5wNzTxde3rkTTx7KZSJ3+aMC+1dEsMO02AAWPoXGqFrf0KWMI8c36IXAhVdQkqbK30gj2eE1FehmOWjiEGJhWD8oeSQFf+1d3yq0KuDMehyOuvkyNzliXuv4fqJ70SJuxuQFB8cOgAsGDwzrR09rrCE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oEkmWRla; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oEkmWRla" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 262B1C4AF0B; Thu, 9 Oct 2025 16:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760026687; bh=46QjrBY51KkQ/h8L2AvGf466oaYcMm8u//jJges89zs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oEkmWRlaGX2ru1DvbZVOih8N3lHZfkL0adIznbGnX0h7k46VwY6jo2G++Ouf2bjRi MAvNpBo89KEYLMGfetGIDPh4dfA3xxXtc6pIX60O8ttVZew92AXqNLovLD0IIhDlPe N9frOAJUNH5S2t0uzwB8e2jFPaU63WGF5oWXjaJw6sN67yCBWglHv4iEoS2CtnD9d3 Xc0+7/SR7fnOOknfH+JhuZixZwEcIv9cJqU4hKCqJFklyiSMmuxDbZgbXVbgcPHDvB mT2Ea8pu3hogE4Em80V1xi14/kkiv5vXEn7CrPpv4o/4SZvT12i8a2WSW3BOc8AILd oYtXl06JBph3A== From: "Mario Limonciello (AMD)" To: "Gautham R . Shenoy" Cc: Perry Yuan , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)), linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING FRAMEWORK), "Mario Limonciello (AMD)" Subject: [PATCH v2 4/6] cpufreq/amd-pstate: Adjust return values in amd_pstate_update_status() Date: Thu, 9 Oct 2025 11:17:54 -0500 Message-ID: <20251009161756.2728199-5-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251009161756.2728199-1-superm1@kernel.org> References: <20251009161756.2728199-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" get_mode_idx_from_str() already checks the upper boundary for a string sent. Drop the extra check in amd_pstate_update_status() and pass the return code if there is a failure. Signed-off-by: Mario Limonciello (AMD) --- drivers/cpufreq/amd-pstate.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 5feb9f5e3a491..2d2ef53d12447 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1346,9 +1346,8 @@ int amd_pstate_update_status(const char *buf, size_t = size) return -EINVAL; =20 mode_idx =3D get_mode_idx_from_str(buf, size); - - if (mode_idx < 0 || mode_idx >=3D AMD_PSTATE_MAX) - return -EINVAL; + if (mode_idx < 0) + return mode_idx; =20 if (mode_state_machine[cppc_state][mode_idx]) { guard(mutex)(&amd_pstate_driver_lock); --=20 2.43.0 From nobody Fri Dec 19 10:25:40 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF0F423958A; Thu, 9 Oct 2025 16:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760026689; cv=none; b=r5FsmozFc2DC02kD3Zy656A+AkGNMcPcq/73Lt2Gq+Gv7rV4RzUqwmLPy7wi4AkH4OQLitpqgMgA2KpbgvipvQ9PtW+vlrNkb+IGHGCnOanZdKMeXzKa6dnYU0cmrAGmfG6s5jMN24x18O5JcxIcdumj0kl6h+AHNWimcznojbE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760026689; c=relaxed/simple; bh=oGfp+Ic9aXFjfu18qJINok3RloZ50Sy8jmz7OKzlZNU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LPEMFlWKw1K3P6LVjnqTxLi0gnXO6yYvi19jgXeOG3XwJt3i+ERMGwfCOtpCFUP1Ra6V4umM7igT+nrjtWnZqQkoq+XmrwfYN9YUNN6pHR5h/n69/UQ8ons9XOuoiDMtko99fbY/CTUWbscsp5ybK88nlrV9iSvtLEPIFtEsg8o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZKxqnAsa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZKxqnAsa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6B54C4CEE7; Thu, 9 Oct 2025 16:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760026688; bh=oGfp+Ic9aXFjfu18qJINok3RloZ50Sy8jmz7OKzlZNU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZKxqnAsaNgGfmZHe6e563+Ybd495RBfBtaa0Y11b8nJq3opY4x4l6i2VKBLlMwjoC JBOIOcNBfQdXUkFuP2ZGiDp9k1HevxseQa/49pUia0Lhk08ZoCNssWry+6nfGnsv1m /m78EDxE69VVTe23xVYt4allkbU3zUakwl0fgayn9jIBkUlRJAdqx8ST6/RsUXxGDW nGJnVc/vYIwBfNF0iE1sVfRxhw/5wOcc/QUtOi+Xl9YpRwn2xjWRA/91deXZCJWARx NYGwJONhJqETSIoaOe4ySxg4XXRPNMCe1met0cPAFhJB1iSjZMVW8bCKDAjVip/rjo iNi9r8Bb5D33A== From: "Mario Limonciello (AMD)" To: "Gautham R . Shenoy" Cc: Perry Yuan , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)), linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING FRAMEWORK), "Mario Limonciello (AMD)" Subject: [PATCH v2 5/6] cpufreq/amd-pstate: Fix some whitespace issues Date: Thu, 9 Oct 2025 11:17:55 -0500 Message-ID: <20251009161756.2728199-6-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251009161756.2728199-1-superm1@kernel.org> References: <20251009161756.2728199-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add whitespace around the equals and remove leading space. Signed-off-by: Mario Limonciello (AMD) --- drivers/cpufreq/amd-pstate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 2d2ef53d12447..a0f21ac1205af 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -126,7 +126,7 @@ static unsigned int epp_values[] =3D { [EPP_INDEX_BALANCE_PERFORMANCE] =3D AMD_CPPC_EPP_BALANCE_PERFORMANCE, [EPP_INDEX_BALANCE_POWERSAVE] =3D AMD_CPPC_EPP_BALANCE_POWERSAVE, [EPP_INDEX_POWERSAVE] =3D AMD_CPPC_EPP_POWERSAVE, - }; +}; =20 typedef int (*cppc_mode_transition_fn)(int); =20 @@ -182,7 +182,7 @@ static inline int get_mode_idx_from_str(const char *str= , size_t size) { int i; =20 - for (i=3D0; i < AMD_PSTATE_MAX; i++) { + for (i =3D 0; i < AMD_PSTATE_MAX; i++) { if (!strncmp(str, amd_pstate_mode_string[i], size)) return i; } --=20 2.43.0 From nobody Fri Dec 19 10:25:40 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63F1A23D29A; Thu, 9 Oct 2025 16:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760026689; cv=none; b=He/Btr5sr2Ndr61xoreQcwn2DayU3DlC4Cu8k04xmyV4mn5X7rR3JRUJ7psdh8ayzgrDN3bpeXpnO1H8dbdq66F7UgXkJN3tPNun3u5KrYPbOcmBx9+uKTPhj0BWFNYfjKJ9tE/6bc0EprJy0txersx9E8A2cwd8Eh18DV6H3H8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760026689; c=relaxed/simple; bh=j58A4Hz5lIQl6pHqMa5ejtgHdIt3ANU2L+r+wOOB74I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uYlbisY7JvuXDGpEuAElK71JLfo+5weev103D8CCnJzjOsooouRQVrMAaXPxcuk4CjKlvAlVTRC1mLLb2/1tvJs7a5mCppeNwCAphGB2oyrmBai9Z8fQViGN5EKWgcKT0XLk/tZDF2M3GtYw4771OqsN4IujEkAV7rHGPm/f0Ng= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dmkpxN3x; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dmkpxN3x" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2B76C4CEFE; Thu, 9 Oct 2025 16:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760026689; bh=j58A4Hz5lIQl6pHqMa5ejtgHdIt3ANU2L+r+wOOB74I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dmkpxN3xdkLckMK31ofkFOvv+kVkTp1wdfsSQEDF6xGtuCRBtLABvNsC7Bg9NuGUh dr416Scb2S2URXkYJFeTPr/VnQAu1sZyAPeTIxALFKqDklYOMfk0nm7/oz9NFkKD6k ynsqjiGDVgGNsaT3qhcoeV08L2koGeKcsCwFXKSVmV1s82b2fVJkUTZgJlTNNRpVer ZWLgJ9d0cDds4lN7aqdvQUc8vrjj7vtgVNFMFqnMjqZyAlAH8gP4e57SSCCIvdJn5a jx21Kt9OBO+yVu9j8DbmQwLWnyXSN1roFJ1OezebxrgiFWN2L+P7J2G3vXiXvfK1FH WStXmqt0ND1UQ== From: "Mario Limonciello (AMD)" To: "Gautham R . Shenoy" Cc: Perry Yuan , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)), linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING FRAMEWORK), "Mario Limonciello (AMD)" Subject: [PATCH v2 6/6] cpufreq/amd-pstate: Add static asserts for EPP indices Date: Thu, 9 Oct 2025 11:17:56 -0500 Message-ID: <20251009161756.2728199-7-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251009161756.2728199-1-superm1@kernel.org> References: <20251009161756.2728199-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In case a new index is introduced add a static assert to make sure that strings and values are updated. Signed-off-by: Mario Limonciello (AMD) --- drivers/cpufreq/amd-pstate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index a0f21ac1205af..b3dad7cde46f0 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -110,6 +110,7 @@ enum energy_perf_value_index { EPP_INDEX_BALANCE_PERFORMANCE, EPP_INDEX_BALANCE_POWERSAVE, EPP_INDEX_POWERSAVE, + EPP_INDEX_MAX, }; =20 static const char * const energy_perf_strings[] =3D { @@ -119,6 +120,7 @@ static const char * const energy_perf_strings[] =3D { [EPP_INDEX_BALANCE_POWERSAVE] =3D "balance_power", [EPP_INDEX_POWERSAVE] =3D "power", }; +static_assert(ARRAY_SIZE(energy_perf_strings) =3D=3D EPP_INDEX_MAX); =20 static unsigned int epp_values[] =3D { [EPP_INDEX_DEFAULT] =3D 0, @@ -127,6 +129,7 @@ static unsigned int epp_values[] =3D { [EPP_INDEX_BALANCE_POWERSAVE] =3D AMD_CPPC_EPP_BALANCE_POWERSAVE, [EPP_INDEX_POWERSAVE] =3D AMD_CPPC_EPP_POWERSAVE, }; +static_assert(ARRAY_SIZE(epp_values) =3D=3D EPP_INDEX_MAX); =20 typedef int (*cppc_mode_transition_fn)(int); =20 --=20 2.43.0