From nobody Fri Dec 19 09:01:16 2025 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93C4D241CB7 for ; Thu, 9 Oct 2025 09:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760001833; cv=none; b=eeRAo87GMjeb9iIuVmBEWe+JLVBGsIZ3zTlMHTuhlSnq7ejH97xv+vR9rE9ufyqpIMSqHde//jdOVBmpo6Fhj2UE6KB290ieoEX5MymVUQZpl9DIfr0bNVy/eQGGfXeX+FxXxbv6FeNyPIP6C8kd/WmhLuy//z4313eFCYsU7t8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760001833; c=relaxed/simple; bh=Fcp0jPHuTaTEqj1AeQwmDUWdnPD+3eJn9JS0FEQIwCI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nT13fR3auhBYs3f18hNteokrHW377OeX55UhyB4cNMR068EzAOHLh6QQOsxkANrGKWh1+Q0V6aM9X3Dy3BfsYRZHjurLlYhOOc5NDjeA2PgBY61fFopp/L04irfrHhRtFD/1H9Ly1bmIJPhoRKLrRHxsktR1k1Pm/U2VWilAxH4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=QZY/vbHr; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="QZY/vbHr" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760001818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=4+ivuVc0pjauohQnwAnQmgWCo18q7rQO//Il1Z5pDkI=; b=QZY/vbHrRB/rCyBfesv9Z2RDIxgEjgiKiecm/PF/eZ0F33H1eP6amKz82mDHDXU4/9P4ga vkSqMr8hps/8zuw3sbm342wB2l6WpbcRz/o1xhTNfuxMqj6s22Fa4Kl4f6VbiQKH1DVA1X o3MPT8V0d3yCRnPrg0nTnGzDHq3De60= From: Matthew Schwartz To: harry.wentland@amd.com, christian.koenig@amd.com, sunpeng.li@amd.com, airlied@gmail.com, simona@ffwll.ch, alexander.deucher@amd.com Cc: linux-kernel@vger.kernel.org, mario.limonciello@amd.com, amd-gfx@lists.freedesktop.org, stable@vger.kernel.org, regressions@lists.linux.dev, Matthew Schwartz Subject: [PATCH] Revert "drm/amd/display: Only restore backlight after amdgpu_dm_init or dm_resume" Date: Thu, 9 Oct 2025 11:23:01 +0200 Message-ID: <20251009092301.13212-1-matthew.schwartz@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" This fix regressed the original issue that commit d83c747a1225 ("drm/amd/display: Fix brightness level not retained over reboot") solved, so revert it until a different approach to solve the regression that it caused with AMD_PRIVATE_COLOR is found. Fixes: a490c8d77d50 ("drm/amd/display: Only restore backlight after amdgpu_= dm_init or dm_resume") Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4620 Signed-off-by: Matthew Schwartz --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 ++++-------- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 7 ------- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 8e1622bf7a42..21281e684b84 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -2081,8 +2081,6 @@ static int amdgpu_dm_init(struct amdgpu_device *adev) =20 dc_hardware_init(adev->dm.dc); =20 - adev->dm.restore_backlight =3D true; - adev->dm.hpd_rx_offload_wq =3D hpd_rx_irq_create_workqueue(adev); if (!adev->dm.hpd_rx_offload_wq) { drm_err(adev_to_drm(adev), "failed to create hpd rx offload workqueue.\n= "); @@ -3438,7 +3436,6 @@ static int dm_resume(struct amdgpu_ip_block *ip_block) dc_set_power_state(dm->dc, DC_ACPI_CM_POWER_STATE_D0); =20 dc_resume(dm->dc); - adev->dm.restore_backlight =3D true; =20 amdgpu_dm_irq_resume_early(adev); =20 @@ -9965,6 +9962,7 @@ static void amdgpu_dm_commit_streams(struct drm_atomi= c_state *state, bool mode_set_reset_required =3D false; u32 i; struct dc_commit_streams_params params =3D {dc_state->streams, dc_state->= stream_count}; + bool set_backlight_level =3D false; =20 /* Disable writeback */ for_each_old_connector_in_state(state, connector, old_con_state, i) { @@ -10084,6 +10082,7 @@ static void amdgpu_dm_commit_streams(struct drm_ato= mic_state *state, acrtc->hw_mode =3D new_crtc_state->mode; crtc->hwmode =3D new_crtc_state->mode; mode_set_reset_required =3D true; + set_backlight_level =3D true; } else if (modereset_required(new_crtc_state)) { drm_dbg_atomic(dev, "Atomic commit: RESET. crtc id %d:[%p]\n", @@ -10140,16 +10139,13 @@ static void amdgpu_dm_commit_streams(struct drm_a= tomic_state *state, * to fix a flicker issue. * It will cause the dm->actual_brightness is not the current panel brigh= tness * level. (the dm->brightness is the correct panel level) - * So we set the backlight level with dm->brightness value after initial - * set mode. Use restore_backlight flag to avoid setting backlight level - * for every subsequent mode set. + * So we set the backlight level with dm->brightness value after set mode */ - if (dm->restore_backlight) { + if (set_backlight_level) { for (i =3D 0; i < dm->num_of_edps; i++) { if (dm->backlight_dev[i]) amdgpu_dm_backlight_set_level(dm, i, dm->brightness[i]); } - dm->restore_backlight =3D false; } } =20 diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.h index 009f206226f0..db75e991ac7b 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h @@ -630,13 +630,6 @@ struct amdgpu_display_manager { */ u32 actual_brightness[AMDGPU_DM_MAX_NUM_EDP]; =20 - /** - * @restore_backlight: - * - * Flag to indicate whether to restore backlight after modeset. - */ - bool restore_backlight; - /** * @aux_hpd_discon_quirk: * --=20 2.51.0