From nobody Fri Dec 19 08:56:25 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72ED51EA7D2; Thu, 9 Oct 2025 06:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759992508; cv=none; b=frtANBE2P7/mdcEPz2LJ6uuPsm0wU7BpBu6wGouJ+ywGgbUwBESTcUWJrwEZy09IsqFF7ZcYUrBjgELloG9YjD1nqXDmwmmwV0y05GVfY1TmBFY6bp8p11ISAb9xUTDIHT5C7m3Nz87K3gxiWhu0IoK0gM+TR87Xwwj749/SvtI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759992508; c=relaxed/simple; bh=DDjKpr6gtv7Sbw5NKGi8tB6eysY8h2EsJ4D5k4IEpiQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gegED06JEKt+cyuJM5cC9Tqs2GmqM88d9xLAK/1rfw42y/NIsUdgiIsPVV+AMI2pSium3o1A6F/Yppg73OgQq8aIUpZJ76MjAdVR8obb4H3ThTFEEt6AQvf98V6qGwPlHYwbpUGxBnnrL9LE+urZAZEKJPnCQxX1yyHE+c7XlqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u8Ip4fj3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u8Ip4fj3" Received: by smtp.kernel.org (Postfix) with ESMTPS id EEE3AC4CEF9; Thu, 9 Oct 2025 06:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759992508; bh=DDjKpr6gtv7Sbw5NKGi8tB6eysY8h2EsJ4D5k4IEpiQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=u8Ip4fj3WcI8ZBqrCkDuUs4NN+BSaXF21LK1pxB+JtyNMi3Ju2h/LhBe3r+sHygaq P+1+e/ZhR1yVQ1xLZeeOlmO5PJbZkCAUjJO5DmZJGJwTAhaToNrYElvOeFs3xsRVWN foQp2zAyYFj+YRcjjws/gOf30wEt1qkjUHgsplU5gcvRmG3VzHF9LCNXJWpT2FKtkO OifT7C4fQVNSiy/c4KRj7FcjvzR4XXK8aUFrYeWLPNUvDXEPGbEfayNdNUCwdUwkHd 40qPin308Se4CNTYnJbK1c3tkJu24o5SCgJsSQTt78igZ2QJdFPLMkG4w+uz/CmjUz b67No4lduQVtA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC1C3CCA470; Thu, 9 Oct 2025 06:48:27 +0000 (UTC) From: Maud Spierings via B4 Relay Date: Thu, 09 Oct 2025 08:48:25 +0200 Subject: [PATCH v4 1/4] dt-bindings: backlight: Add max25014 bindings Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251009-max25014-v4-1-6adb2a0aa35f@gocontroll.com> References: <20251009-max25014-v4-0-6adb2a0aa35f@gocontroll.com> In-Reply-To: <20251009-max25014-v4-0-6adb2a0aa35f@gocontroll.com> To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Liam Girdwood , Mark Brown Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Maud Spierings X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1759992506; l=3924; i=maudspierings@gocontroll.com; s=20250214; h=from:subject:message-id; bh=9GoY1YFZup8pyevGMqP0p2CbHPXkb49eiT7Kk0Aql2c=; b=UTjxhRktWaJOCpVH6gPGCMfTW3yTl1VRmKMfw3ZqGDel/DpQX0w9z2TUyP2RDcHVhlFV1p58m 68O/GoD9kEgDWP6i3NF+m3joPvLgytuKbxJZjcaCTet5R9sS0BsNQtT X-Developer-Key: i=maudspierings@gocontroll.com; a=ed25519; pk=7chUb8XpaTQDvWhzTdHC0YPMkTDloELEC7q94tOUyPg= X-Endpoint-Received: by B4 Relay for maudspierings@gocontroll.com/20250214 with auth_id=341 X-Original-From: Maud Spierings Reply-To: maudspierings@gocontroll.com From: Maud Spierings The Maxim MAX25014 is a 4-channel automotive grade backlight driver IC with integrated boost controller. In the current implementation the control registers for channel 1, control all channels. So only one led subnode with led-sources is supported right now. If at some point the driver functionality is expanded the bindings can be easily extended with it. Signed-off-by: Maud Spierings --- .../bindings/leds/backlight/maxim,max25014.yaml | 109 +++++++++++++++++= ++++ MAINTAINERS | 5 + 2 files changed, 114 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/backlight/maxim,max2501= 4.yaml b/Documentation/devicetree/bindings/leds/backlight/maxim,max25014.ya= ml new file mode 100644 index 0000000000000..496520e1374e5 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml @@ -0,0 +1,109 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/maxim,max25014.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim max25014 backlight controller + +maintainers: + - Maud Spierings + +properties: + compatible: + enum: + - maxim,max25014 + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + enable-gpios: + maxItems: 1 + + interrupts: + maxItems: 1 + + power-supply: + description: Regulator which controls the boost converter input rail. + + pwms: + maxItems: 1 + + maxim,iset: + $ref: /schemas/types.yaml#/definitions/uint32 + maximum: 15 + default: 11 + description: + Value of the ISET register field. This controls the current scale of= the + outputs, a higher number means more current. + +patternProperties: + "^led@[01]$": + type: object + description: Properties for a string of connected LEDs. + $ref: common.yaml# + + properties: + reg: + const: 0 + + led-sources: + allOf: + - minItems: 1 + maxItems: 4 + items: + minimum: 0 + maximum: 3 + default: [0, 1, 2, 3] + + default-brightness: + minimum: 0 + maximum: 100 + default: 50 + + required: + - reg + + additionalProperties: false + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + backlight@6f { + compatible =3D "maxim,max25014"; + reg =3D <0x6f>; + enable-gpios =3D <&gpio1 4 GPIO_ACTIVE_HIGH>; + interrupt-parent =3D <&gpio1>; + interrupts =3D <2 IRQ_TYPE_EDGE_FALLING>; + power-supply =3D <®_backlight>; + pwms =3D <&pwm1>; + maxim,iset =3D <7>; + + #address-cells =3D <1>; + #size-cells =3D <0>; + + led@0 { + reg =3D <0>; + led-sources =3D <0 1 2 3>; + default-brightness =3D <50>; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 47fbc5e06808f..be5e2515900ce 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15171,6 +15171,11 @@ F: Documentation/userspace-api/media/drivers/max21= 75.rst F: drivers/media/i2c/max2175* F: include/uapi/linux/max2175.h =20 +MAX25014 BACKLIGHT DRIVER +M: Maud Spierings +S: Maintained +F: Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml + MAX31335 RTC DRIVER M: Antoniu Miclaus L: linux-rtc@vger.kernel.org --=20 2.51.0 From nobody Fri Dec 19 08:56:25 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DAC42C2340; Thu, 9 Oct 2025 06:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759992508; cv=none; b=hD9PK/E3FEYLWM4AicExZpKN8L707NP1gZgwMsI+qoZnnOfDXRqs94udN/Ak6m/2Konm+FBmiA1+G/Wiubgf91uvbh1qIE1z0B2WFAiwwu+N2QRqPEbZiaiyi1heJNh7Pr8X8LmeEJ2h7V4rrdrEv2CUAlVBKSKwJZHkvayV+yU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759992508; c=relaxed/simple; bh=L6L8DsGYbwCbX7aXW5VLbFB6yC3cIzbSjzEF0Shwrm4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Aza6Fx+CFi/4nnW0Zcce88w4AIQEvwKz6DqwiIDo4uXggzVthb8Y4U4CATCRABVx5rlMU84mk5CG0KMUYOzJ0kytvJBP+hgxsk+3FpnY/BDRpPzUS+pxHOG4pDl0pdKDOvIHidfesG4+Zd+NWVUvJlXC3j+n3hLBNTYDKbWF2GM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oDJbfPMx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oDJbfPMx" Received: by smtp.kernel.org (Postfix) with ESMTPS id 0A0EDC4CEF7; Thu, 9 Oct 2025 06:48:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759992508; bh=L6L8DsGYbwCbX7aXW5VLbFB6yC3cIzbSjzEF0Shwrm4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=oDJbfPMxCPhs0OwGY3tEUtAptAigt6GlnDyxHdOCfAKzQ14yAhwOk3qYWMk8QgR22 VDXLkp4R3GdJ3Du2ztYJutGwXWatWr5wNVqDjYHPhUyW+RVoaizFgqE5InbFk/po/e ICFe/UMYg+wIPEzbTKeKOGlt15CLrUVa5zt37Hrsxv2pmLKhe5/J3dFq8l7j1BKBC1 nG7x/OkwvZ5ilPF+3SoLzWR/COWTCeXdjggScGHN7QoQrGBNNRvNoa1/HMl0Zfyup3 iqhFogDJsWoAt3DcrJ0NAz6WEgg9Yf0ZVqDfMJfZaTZ92iQKhU33J6g66VHaAiT2mm ai6sj8EGRhPbA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC292CCD183; Thu, 9 Oct 2025 06:48:27 +0000 (UTC) From: Maud Spierings via B4 Relay Date: Thu, 09 Oct 2025 08:48:26 +0200 Subject: [PATCH v4 2/4] backlight: add max25014atg backlight Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251009-max25014-v4-2-6adb2a0aa35f@gocontroll.com> References: <20251009-max25014-v4-0-6adb2a0aa35f@gocontroll.com> In-Reply-To: <20251009-max25014-v4-0-6adb2a0aa35f@gocontroll.com> To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Liam Girdwood , Mark Brown Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Maud Spierings X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1759992506; l=13707; i=maudspierings@gocontroll.com; s=20250214; h=from:subject:message-id; bh=ejgHwguGo8ypJDZfsOet4yiDaYhz0Oa+gVY64tz5exU=; b=/U0j0eJhAgE8Gi9eRSN8QQFjxoOHhPI95MnFaiphQ6EoWq3zpIxPExJ7yMdr7DwUjL0Lft7E/ Ky+ThtMeM9FDxpTWVZ/oH/Tubx0bwFFV8bUWuZSgutUly2xR8chSoV7 X-Developer-Key: i=maudspierings@gocontroll.com; a=ed25519; pk=7chUb8XpaTQDvWhzTdHC0YPMkTDloELEC7q94tOUyPg= X-Endpoint-Received: by B4 Relay for maudspierings@gocontroll.com/20250214 with auth_id=341 X-Original-From: Maud Spierings Reply-To: maudspierings@gocontroll.com From: Maud Spierings The Maxim MAX25014 is a 4-channel automotive grade backlight driver IC with integrated boost controller. Signed-off-by: Maud Spierings --- MAINTAINERS | 1 + drivers/video/backlight/Kconfig | 7 + drivers/video/backlight/Makefile | 1 + drivers/video/backlight/max25014.c | 409 +++++++++++++++++++++++++++++++++= ++++ 4 files changed, 418 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index be5e2515900ce..77bb4fd3474e1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15175,6 +15175,7 @@ MAX25014 BACKLIGHT DRIVER M: Maud Spierings S: Maintained F: Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml +F: drivers/video/backlight/max25014.c =20 MAX31335 RTC DRIVER M: Antoniu Miclaus diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kcon= fig index d9374d208ceeb..d3bb6ccd41853 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -262,6 +262,13 @@ config BACKLIGHT_DA9052 help Enable the Backlight Driver for DA9052-BC and DA9053-AA/Bx PMICs. =20 +config BACKLIGHT_MAX25014 + tristate "Backlight driver for the Maxim MAX25014 chip" + depends on I2C + select REGMAP_I2C + help + If you are using a MAX25014 chip as a backlight driver say Y to enable = it. + config BACKLIGHT_MAX8925 tristate "Backlight driver for MAX8925" depends on MFD_MAX8925 diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Mak= efile index dfbb169bf6ea2..1170d9ec40b8d 100644 --- a/drivers/video/backlight/Makefile +++ b/drivers/video/backlight/Makefile @@ -45,6 +45,7 @@ obj-$(CONFIG_BACKLIGHT_LOCOMO) +=3D locomolcd.o obj-$(CONFIG_BACKLIGHT_LP855X) +=3D lp855x_bl.o obj-$(CONFIG_BACKLIGHT_LP8788) +=3D lp8788_bl.o obj-$(CONFIG_BACKLIGHT_LV5207LP) +=3D lv5207lp.o +obj-$(CONFIG_BACKLIGHT_MAX25014) +=3D max25014.o obj-$(CONFIG_BACKLIGHT_MAX8925) +=3D max8925_bl.o obj-$(CONFIG_BACKLIGHT_MP3309C) +=3D mp3309c.o obj-$(CONFIG_BACKLIGHT_MT6370) +=3D mt6370-backlight.o diff --git a/drivers/video/backlight/max25014.c b/drivers/video/backlight/m= ax25014.c new file mode 100644 index 0000000000000..36bae508697e8 --- /dev/null +++ b/drivers/video/backlight/max25014.c @@ -0,0 +1,409 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Backlight driver for Maxim MAX25014 + * + * Copyright (C) 2025 GOcontroll B.V. + * Author: Maud Spierings + */ + +#include +#include +#include +#include +#include + +#define MAX25014_ISET_DEFAULT_100 11 +#define MAX_BRIGHTNESS 100 +#define MIN_BRIGHTNESS 0 +#define TON_MAX 130720 /* @153Hz */ +#define TON_STEP 1307 /* @153Hz */ +#define TON_MIN 0 + +#define MAX25014_DEV_ID 0x00 +#define MAX25014_REV_ID 0x01 +#define MAX25014_ISET 0x02 +#define MAX25014_IMODE 0x03 +#define MAX25014_TON1H 0x04 +#define MAX25014_TON1L 0x05 +#define MAX25014_TON2H 0x06 +#define MAX25014_TON2L 0x07 +#define MAX25014_TON3H 0x08 +#define MAX25014_TON3L 0x09 +#define MAX25014_TON4H 0x0A +#define MAX25014_TON4L 0x0B +#define MAX25014_TON_1_4_LSB 0x0C +#define MAX25014_SETTING 0x12 +#define MAX25014_DISABLE 0x13 +#define MAX25014_BSTMON 0x14 +#define MAX25014_IOUT1 0x15 +#define MAX25014_IOUT2 0x16 +#define MAX25014_IOUT3 0x17 +#define MAX25014_IOUT4 0x18 +#define MAX25014_OPEN 0x1B +#define MAX25014_SHORT_GND 0x1C +#define MAX25014_SHORT_LED 0x1D +#define MAX25014_MASK 0x1E +#define MAX25014_DIAG 0x1F + +#define MAX25014_IMODE_HDIM BIT(2) +#define MAX25014_ISET_ENABLE BIT(5) +#define MAX25014_ISET_PSEN BIT(4) +#define MAX25014_DIAG_HW_RST BIT(2) +#define MAX25014_SETTING_FPWM GENMASK(6, 4) + +struct max25014 { + struct i2c_client *client; + struct backlight_device *bl; + struct regmap *regmap; + struct gpio_desc *enable; + struct regulator *vin; /* regulator for boost converter Vin rail */ + uint32_t iset; + uint8_t strings_mask; +}; + +static const struct regmap_config max25014_regmap_config =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + .max_register =3D MAX25014_DIAG, +}; + +/** + * @brief control the brightness with i2c registers + * + * @param regmap trivial + * @param brt brightness + * @return int + */ +static int max25014_register_control(struct regmap *regmap, uint32_t brt) +{ + uint32_t reg =3D TON_STEP * brt; + int ret; + /* + * 18 bit number lowest, 2 bits in first register, + * next lowest 8 in the L register, next 8 in the H register + * Seemingly setting the strength of only one string controls all of + * them, individual settings don't affect the outcome. + */ + + ret =3D regmap_write(regmap, MAX25014_TON_1_4_LSB, reg & 0b00000011); + if (ret !=3D 0) + return ret; + ret =3D regmap_write(regmap, MAX25014_TON1L, (reg >> 2) & 0b11111111); + if (ret !=3D 0) + return ret; + return regmap_write(regmap, MAX25014_TON1H, (reg >> 10) & 0b11111111); +} + +static int max25014_check_errors(struct max25014 *maxim) +{ + uint8_t i; + int ret; + uint32_t val; + + ret =3D regmap_read(maxim->regmap, MAX25014_OPEN, &val); + if (ret !=3D 0) + return ret; + if (val > 0) { + dev_err(&maxim->client->dev, "Open led strings detected on:\n"); + for (i =3D 0; i < 4; i++) { + if (val & 1 << i) + dev_err(&maxim->client->dev, "string %d\n", i + 1); + } + return -EIO; + } + + ret =3D regmap_read(maxim->regmap, MAX25014_SHORT_GND, &val); + if (ret !=3D 0) + return ret; + if (val > 0) { + dev_err(&maxim->client->dev, "Short to ground detected on:\n"); + for (i =3D 0; i < 4; i++) { + if (val & 1 << i) + dev_err(&maxim->client->dev, "string %d\n", i + 1); + } + return -EIO; + } + + ret =3D regmap_read(maxim->regmap, MAX25014_SHORT_GND, &val); + if (ret !=3D 0) + return ret; + if (val > 0) { + dev_err(&maxim->client->dev, "Shorted led detected on:\n"); + for (i =3D 0; i < 4; i++) { + if (val & 1 << i) + dev_err(&maxim->client->dev, "string %d\n", i + 1); + } + return -EIO; + } + + ret =3D regmap_read(maxim->regmap, MAX25014_DIAG, &val); + if (ret !=3D 0) + return ret; + /* + * The HW_RST bit always starts at 1 after power up. + * It is reset on first read, does not indicate an error. + */ + if (val > 0 && val !=3D MAX25014_DIAG_HW_RST) { + if (val & 0b1) + dev_err(&maxim->client->dev, + "Overtemperature shutdown\n"); + if (val & 0b10) + dev_err(&maxim->client->dev, + "Chip is getting too hot (>125C)\n"); + if (val & 0b1000) + dev_err(&maxim->client->dev, + "Boost converter overvoltage\n"); + if (val & 0b10000) + dev_err(&maxim->client->dev, + "Boost converter undervoltage\n"); + if (val & 0b100000) + dev_err(&maxim->client->dev, "IREF out of range\n"); + return -EIO; + } + return 0; +} + +/* + * 1. disable unused strings + * 2. set dim mode + * 3. set initial brightness + * 4. set setting register + * 5. enable the backlight + */ +static int max25014_configure(struct max25014 *maxim) +{ + int ret; + uint32_t val; + + ret =3D regmap_write(maxim->regmap, MAX25014_DISABLE, + maxim->strings_mask); + if (ret !=3D 0) + return ret; + + ret =3D regmap_write(maxim->regmap, MAX25014_IMODE, MAX25014_IMODE_HDIM); + if (ret !=3D 0) + return ret; + + ret =3D regmap_read(maxim->regmap, MAX25014_SETTING, &val); + if (ret !=3D 0) + return ret; + + ret =3D regmap_write(maxim->regmap, MAX25014_SETTING, + val & ~MAX25014_SETTING_FPWM); + if (ret !=3D 0) + return ret; + + ret =3D regmap_write(maxim->regmap, MAX25014_ISET, + maxim->iset | MAX25014_ISET_ENABLE | + MAX25014_ISET_PSEN); + return ret; +} + +static int max25014_update_status(struct backlight_device *bl_dev) +{ + struct max25014 *maxim =3D bl_get_data(bl_dev); + + if (backlight_is_blank(maxim->bl)) + bl_dev->props.brightness =3D 0; + + return max25014_register_control(maxim->regmap, + bl_dev->props.brightness); +} + +static const struct backlight_ops max25014_bl_ops =3D { + .options =3D BL_CORE_SUSPENDRESUME, + .update_status =3D max25014_update_status, +}; + +static int max25014_parse_dt(struct max25014 *maxim, + uint32_t *initial_brightness) +{ + struct device *dev =3D &maxim->client->dev; + struct device_node *node =3D dev->of_node; + struct fwnode_handle *child; + uint32_t strings[4]; + int res, i; + + if (!node) { + dev_err(dev, "no platform data\n"); + return -EINVAL; + } + + child =3D device_get_next_child_node(dev, NULL); + if (child) { + res =3D fwnode_property_count_u32(child, "led-sources"); + if (res > 0) { + fwnode_property_read_u32_array(child, "led-sources", + strings, res); + + /* set all strings as disabled, then enable those in led-sources*/ + maxim->strings_mask =3D 0xf; + for (i =3D 0; i < res; i++) { + if (strings[i] <=3D 4) + maxim->strings_mask &=3D ~BIT(strings[i]); + } + } + + fwnode_property_read_u32(child, "default-brightness", + initial_brightness); + + fwnode_handle_put(child); + } + + maxim->iset =3D MAX25014_ISET_DEFAULT_100; + of_property_read_u32(node, "maxim,iset", &maxim->iset); + + if (maxim->iset < 0 || maxim->iset > 15) { + dev_err(dev, + "Invalid iset, should be a value from 0-15, entered was %d\n", + maxim->iset); + return -EINVAL; + } + + if (*initial_brightness < 0 || *initial_brightness > 100) { + dev_err(dev, + "Invalid initial brightness, should be a value from 0-100, entered was = %d\n", + *initial_brightness); + return -EINVAL; + } + + return 0; +} + +static int max25014_probe(struct i2c_client *cl) +{ + struct backlight_device *bl; + const struct i2c_device_id *id =3D i2c_client_get_device_id(cl); + struct max25014 *maxim; + struct backlight_properties props; + int ret; + uint32_t initial_brightness =3D 50; + + maxim =3D devm_kzalloc(&cl->dev, sizeof(struct max25014), GFP_KERNEL); + if (!maxim) + return -ENOMEM; + + maxim->client =3D cl; + + ret =3D max25014_parse_dt(maxim, &initial_brightness); + if (ret < 0) + return ret; + + maxim->vin =3D devm_regulator_get_optional(&maxim->client->dev, "power"); + if (IS_ERR(maxim->vin)) { + if (PTR_ERR(maxim->vin) =3D=3D -EPROBE_DEFER) + return -EPROBE_DEFER; + maxim->vin =3D NULL; + } + + if (maxim->vin) { + ret =3D regulator_enable(maxim->vin); + if (ret < 0) { + dev_err(&maxim->client->dev, + "failed to enable Vin: %d\n", ret); + return ret; + } + } + + maxim->enable =3D devm_gpiod_get_optional(&maxim->client->dev, "enable", + GPIOD_ASIS); + if (IS_ERR(maxim->enable)) { + ret =3D PTR_ERR(maxim->enable); + dev_err(&maxim->client->dev, "failed to get enable gpio: %d\n", + ret); + goto disable_vin; + } + + if (maxim->enable) + gpiod_set_value_cansleep(maxim->enable, 1); + + /* Enable can be tied to vin rail wait if either is available */ + if (maxim->enable || maxim->vin) { + /* Datasheet Electrical Characteristics tSTARTUP 2ms */ + usleep_range(2000, 2500); + } + + maxim->regmap =3D devm_regmap_init_i2c(cl, &max25014_regmap_config); + if (IS_ERR(maxim->regmap)) { + ret =3D PTR_ERR(maxim->regmap); + dev_err(&maxim->client->dev, + "failed to initialize the i2c regmap: %d\n", ret); + goto disable_full; + } + + i2c_set_clientdata(cl, maxim); + + ret =3D max25014_check_errors(maxim); + if (ret) { /* error is already reported in the above function */ + goto disable_full; + } + + ret =3D max25014_configure(maxim); + if (ret) { + dev_err(&maxim->client->dev, "device config err: %d", ret); + goto disable_full; + } + + memset(&props, 0, sizeof(props)); + props.type =3D BACKLIGHT_PLATFORM; + props.max_brightness =3D MAX_BRIGHTNESS; + props.brightness =3D initial_brightness; + props.scale =3D BACKLIGHT_SCALE_LINEAR; + + bl =3D devm_backlight_device_register(&maxim->client->dev, id->name, + &maxim->client->dev, maxim, + &max25014_bl_ops, &props); + if (IS_ERR(bl)) + return PTR_ERR(bl); + + maxim->bl =3D bl; + + return 0; + +disable_full: + if (maxim->enable) + gpiod_set_value_cansleep(maxim->enable, 0); +disable_vin: + if (maxim->vin) + regulator_disable(maxim->vin); + return ret; +} + +static void max25014_remove(struct i2c_client *cl) +{ + struct max25014 *maxim =3D i2c_get_clientdata(cl); + + maxim->bl->props.brightness =3D 0; + max25014_update_status(maxim->bl); + if (maxim->enable) + gpiod_set_value_cansleep(maxim->enable, 0); + if (maxim->vin) + regulator_disable(maxim->vin); +} + +static const struct of_device_id max25014_dt_ids[] =3D { + { .compatible =3D "maxim,max25014", }, + { } +}; +MODULE_DEVICE_TABLE(of, max25014_dt_ids); + +static const struct i2c_device_id max25014_ids[] =3D { + { "max25014" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, max25014_ids); + +static struct i2c_driver max25014_driver =3D { + .driver =3D { + .name =3D KBUILD_MODNAME, + .of_match_table =3D of_match_ptr(max25014_dt_ids), + }, + .probe =3D max25014_probe, + .remove =3D max25014_remove, + .id_table =3D max25014_ids, +}; +module_i2c_driver(max25014_driver); + +MODULE_DESCRIPTION("Maxim MAX25014 backlight driver"); +MODULE_AUTHOR("Maud Spierings "); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Fri Dec 19 08:56:25 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DA542C21F8; Thu, 9 Oct 2025 06:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759992508; cv=none; b=qjokXMB5sHrtLYRWKTVzXS8RcJNMvHbE/ziu9ajxxieQULQlJpqUgSyQEF87gPpHCiPEMWR0oR8o5LjXPTZhYbJs36G4EvwIzetLbQnW5i4mfZzq2bEuoQo8CIms5p5ksl6Pp76VYU+1pPYidHbARdU0Ha2J1IdggG9XbMgW0cU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759992508; c=relaxed/simple; bh=SFunblszffFvM+56Io8frqu3y1mfSmEnNBHnGNH6i7M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AozjlS9eRAuHtIYa3AKzPLh3BjAw3WRxf520t6DxXlPdkc5hi5QKBLBbZkVXd9tAaHnW8zxGaXcJk5aiUhAyB+yZVDsNJ3r1bBSvh5om0aIx8YuZpDD72xbhez/wvyf1lre3Fxf6uLrjMdookaMSwzihj7lWVS4BDYY5M9bBp10= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IVVBAgXr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IVVBAgXr" Received: by smtp.kernel.org (Postfix) with ESMTPS id 12F00C116D0; Thu, 9 Oct 2025 06:48:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759992508; bh=SFunblszffFvM+56Io8frqu3y1mfSmEnNBHnGNH6i7M=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=IVVBAgXrXXl/5dl2VmF2Mbm6cEqRokVFGq7mclxsg4fG52d2JYbfOCC1Rcd5sjfbY 7CkI7LC7wO4yp6AmIVqu68sHmbhVNkbTC0movbNANrVCi0j6DTLcrXcKS7SR91RXqH mcYl0PjMD7xfetquEzkJjX0Tw59CgUa1ak/KaAGaBL4Tdcsg8uUrwBF7Krm0ekXXb+ scCGVYdoBYA54qfZg0feszkBL8VOTATk7/x8K4WLcl/ParbZLlrYkP/4CPg7RnFGmG hJ/NH/MyFPlrn1R2Of7ciMKB/njVHPn8iazvLWWWhKM58pVTVYaj88E6GnzGn6MGkp zlbN/e9bi8aow== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06EA7CCD188; Thu, 9 Oct 2025 06:48:28 +0000 (UTC) From: Maud Spierings via B4 Relay Date: Thu, 09 Oct 2025 08:48:27 +0200 Subject: [PATCH v4 3/4] arm64: dts: freescale: moduline-display-av101hdt-a10: add backlight Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251009-max25014-v4-3-6adb2a0aa35f@gocontroll.com> References: <20251009-max25014-v4-0-6adb2a0aa35f@gocontroll.com> In-Reply-To: <20251009-max25014-v4-0-6adb2a0aa35f@gocontroll.com> To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Liam Girdwood , Mark Brown Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Maud Spierings X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1759992506; l=1656; i=maudspierings@gocontroll.com; s=20250214; h=from:subject:message-id; bh=y4Wl1rNyuel5kjZN3m44EWcCr4I5S9GstAu3HGV56iM=; b=h40vWHPkpauVPc3CSs+IWxRf0co2q25wUyI39psVNwuRLJaoHF4qyjaaCAsXuXxpZxcj2atBu HRKSG8k/wxcBEH4CbI2I2L2NS+ooRR/mNPBGmG/yIUkazhrUMHGmx8z X-Developer-Key: i=maudspierings@gocontroll.com; a=ed25519; pk=7chUb8XpaTQDvWhzTdHC0YPMkTDloELEC7q94tOUyPg= X-Endpoint-Received: by B4 Relay for maudspierings@gocontroll.com/20250214 with auth_id=341 X-Original-From: Maud Spierings Reply-To: maudspierings@gocontroll.com From: Maud Spierings Add the missing backlight driver. Signed-off-by: Maud Spierings --- ...x8p-ml81-moduline-display-106-av101hdt-a10.dtso | 32 ++++++++++++++++++= ++++ 1 file changed, 32 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-displa= y-106-av101hdt-a10.dtso b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-mo= duline-display-106-av101hdt-a10.dtso index e3965caca6be4..e8107145a7f3b 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106-a= v101hdt-a10.dtso +++ b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106-a= v101hdt-a10.dtso @@ -17,6 +17,7 @@ =20 panel { compatible =3D "boe,av101hdt-a10"; + backlight =3D <&backlight>; enable-gpios =3D <&gpio1 7 GPIO_ACTIVE_HIGH>; pinctrl-0 =3D <&pinctrl_panel>; pinctrl-names =3D "default"; @@ -40,7 +41,38 @@ reg_vbus: regulator-vbus { }; }; =20 +&i2c4 { + #address-cells =3D <1>; + #size-cells =3D <0>; + + backlight: backlight@6f { + compatible =3D "maxim,max25014"; + reg =3D <0x6f>; + default-brightness =3D <50>; + enable-gpios =3D <&gpio1 4 GPIO_ACTIVE_HIGH>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&pinctrl_backlight>; + maxim,iset =3D <7>; + + #address-cells =3D <1>; + #size-cells =3D <0>; + + led@0 { + reg =3D <0>; + led-sources =3D <0 1 2>; + default-brightness =3D <50>; + }; + }; +}; + &iomuxc { + pinctrl_backlight: backlightgrp { + fsl,pins =3D < + MX8MP_IOMUXC_GPIO1_IO04__GPIO1_IO04 + (MX8MP_PULL_UP | MX8MP_PULL_ENABLE) + >; + }; + pinctrl_panel: panelgrp { fsl,pins =3D < MX8MP_IOMUXC_GPIO1_IO07__GPIO1_IO07 --=20 2.51.0 From nobody Fri Dec 19 08:56:25 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97A542C234F; Thu, 9 Oct 2025 06:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759992508; cv=none; b=rfkTKK3RYwu1AT167I33h4Am9j37pxeSELNl0BaS4BzRM6HyD2i/EmgxTnPsiw0OLnaYKbQ1/h/HvEL9hWN7eI/7s+rQFY3JFHuaatcJ6aknUI1WdnrOfK45PzMD1YXb+wF9HVnh0iINtTmPK+NAG03Sr7xrVexvH8CQIRgJOhA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759992508; c=relaxed/simple; bh=4XdM9wcnYNU2LkGINpDAAZjGYWWB2K+VEu9ljuY48hg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CtVED2aEkPifhBPTcEY58jNaiPVJCBY/mOLr6ALxj0kSAoD0QT7DbnRwzBoJYOvV40D+fcs5OwKiioQMfvOiOSv5bfPmjfIkO6ACkuX3QRJcerEdPn5vMZYoPkgWByXi5rWQTS3i7UkdNF0WUJYPjKlo2OlZEEZbbpqy/3CzjPQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t5sxhCFG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t5sxhCFG" Received: by smtp.kernel.org (Postfix) with ESMTPS id 22F54C19422; Thu, 9 Oct 2025 06:48:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759992508; bh=4XdM9wcnYNU2LkGINpDAAZjGYWWB2K+VEu9ljuY48hg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=t5sxhCFGq8b5VeeXou6XoRRkX07P0L4X3ewWchOXZ3YMk914cwNj3CIEmm7AZ96Dd k5hIAn0/tToXGFHWwC2KSrFvuQui2WgERwkrfXdUD1dqq+58qtZPX4kAEMWz2zrIX8 Z/Dg4htbyiNw4Rgi++o/2n0oBgVw+OPyQHK2c2D4RF2uZkv9lOYEcQbqf+Ma2aV2Ef zJNffkmDiEYna2O56rYp+bCWNtRN70dPt48/TFdpyK0440vsxRAZ3jHdz1oVZVV91S b4dxStQWhzSiTy0PXumg/h6JcyGQIMOcUmlnGvIjvfotQYb7aVqSPZM4OFHBzLqqnc vnRzMNSiyxRJA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18572CCD18A; Thu, 9 Oct 2025 06:48:28 +0000 (UTC) From: Maud Spierings via B4 Relay Date: Thu, 09 Oct 2025 08:48:28 +0200 Subject: [PATCH v4 4/4] arm64: dts: freescale: moduline-display-av123z7m-n17: add backlight Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251009-max25014-v4-4-6adb2a0aa35f@gocontroll.com> References: <20251009-max25014-v4-0-6adb2a0aa35f@gocontroll.com> In-Reply-To: <20251009-max25014-v4-0-6adb2a0aa35f@gocontroll.com> To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Liam Girdwood , Mark Brown Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Maud Spierings X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1759992506; l=1639; i=maudspierings@gocontroll.com; s=20250214; h=from:subject:message-id; bh=pWeAK4Rn7wjoYLcVlDOrdhK/tMcB60QeJTaIHG+EMUw=; b=M1+ka83/gjtFmtqPnLvMWm+kXFyj+0T+dYJTiIImhhAqPMKlwgthVMhg/haaB6ZkpiwXQMoQE R/U68uJ0KQUBSRMKPSpeeKyR+gkZXexQBuiIbfUL3OxNmbGA6yOxHX8 X-Developer-Key: i=maudspierings@gocontroll.com; a=ed25519; pk=7chUb8XpaTQDvWhzTdHC0YPMkTDloELEC7q94tOUyPg= X-Endpoint-Received: by B4 Relay for maudspierings@gocontroll.com/20250214 with auth_id=341 X-Original-From: Maud Spierings Reply-To: maudspierings@gocontroll.com From: Maud Spierings Add the missing backlight. Signed-off-by: Maud Spierings --- ...x8p-ml81-moduline-display-106-av123z7m-n17.dtso | 27 ++++++++++++++++++= +++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-displa= y-106-av123z7m-n17.dtso b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-mo= duline-display-106-av123z7m-n17.dtso index 3eb665ce9d5d2..c320e0f563af9 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106-a= v123z7m-n17.dtso +++ b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106-a= v123z7m-n17.dtso @@ -16,6 +16,7 @@ =20 panel { compatible =3D "boe,av123z7m-n17"; + backlight =3D <&backlight>; enable-gpios =3D <&gpio1 7 GPIO_ACTIVE_HIGH>; pinctrl-0 =3D <&pinctrl_panel>; pinctrl-names =3D "default"; @@ -91,10 +92,34 @@ lvds1_out: endpoint { }; }; =20 - /* max25014 @ 0x6f */ + backlight: backlight@6f { + compatible =3D "maxim,max25014"; + reg =3D <0x6f>; + default-brightness =3D <50>; + enable-gpios =3D <&gpio1 4 GPIO_ACTIVE_HIGH>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&pinctrl_backlight>; + maxim,iset =3D <7>; + + #address-cells =3D <1>; + #size-cells =3D <0>; + + led@0 { + reg =3D <0>; + led-sources =3D <0 1 2 3>; + default-brightness =3D <50>; + }; + }; }; =20 &iomuxc { + pinctrl_backlight: backlightgrp { + fsl,pins =3D < + MX8MP_IOMUXC_GPIO1_IO04__GPIO1_IO04 + (MX8MP_PULL_UP | MX8MP_PULL_ENABLE) + >; + }; + pinctrl_lvds_bridge: lvdsbridgegrp { fsl,pins =3D < MX8MP_IOMUXC_SAI1_TXD2__GPIO4_IO14 --=20 2.51.0