From nobody Wed Dec 17 21:15:16 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FB561B4F2C; Fri, 10 Oct 2025 00:04:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760054657; cv=none; b=fbrHUho+zsb84gW5sLsU2+ccDe4mVt3xKB88X1suXsPT9GNEWxmOTuCf/wNYUdLPLCFKOYOFKrRazg2g19YlB+rgaIKK2RbGOxsD0Dkvb77ikEyNfXzOcCOZYc9tsIV+rIh74nnOYtbGAdfmJZDE7dUq39/0IQ9sHbO9HBkitpY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760054657; c=relaxed/simple; bh=K/RaOnVi05JVkqqhHTGCjiBc/V2HGVq76P40JXdtSTg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p0mqlLJ1eB+h8ynsFxsOKzaaFQ+DxUhUaYyM8g4lKc6daHyNtWbEbPMDY0Kz4edD5Du0X3jxFooYwWDXlnATH4RYb6JvAwfXaTBlEe8RqK/FIabCmI/b0ctbiK3tdsEffocwf5QCVLWmYsFqvmYSkNDEoRmATj3RLK1KSqj3K1o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=AjLadrK5; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="AjLadrK5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1760054656; x=1791590656; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=K/RaOnVi05JVkqqhHTGCjiBc/V2HGVq76P40JXdtSTg=; b=AjLadrK5rxBv0LgziNlw/skZCByt8FM55Gg8f8bjzdmAe4JMzHLqgtJo XumNvMRBTN9wKGtkhEdE8DmR/lFIKbIVu2+wlixMiJJEYpIl02pbscro5 5kqHtrJA+OLOOrTxPNNbLura2WHW5uDqi8gqHutWTI3iMl5z/MlTiaXDl emefK0g1AxhM+p5F3BYPAREfYIap6Ir6iPtj+U9OHnc9PuGUvaZZ1gL/b JKnLeLujL1mD+KY/fTSxFC4UWiLssLkwa94HPeR2t9bgS78ENp7GSwUY1 cqHxWrg8HUvYOk6LuhypoNt22h0tFEm/LJAXEb4mocGiIzre/p4nM6qaW w==; X-CSE-ConnectionGUID: uKCR4ouBT82a8oDvXgcFwA== X-CSE-MsgGUID: avS6vPAnT0a70YOlsbrUag== X-IronPort-AV: E=McAfee;i="6800,10657,11577"; a="62316108" X-IronPort-AV: E=Sophos;i="6.19,217,1754982000"; d="scan'208";a="62316108" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2025 17:04:10 -0700 X-CSE-ConnectionGUID: a7aExJGCSCOeWEfAn8bhsQ== X-CSE-MsgGUID: 8obgRRF7T5OwlPUMC2IsmQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,217,1754982000"; d="scan'208";a="180858283" Received: from orcnseosdtjek.jf.intel.com (HELO [10.166.28.70]) ([10.166.28.70]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2025 17:04:09 -0700 From: Jacob Keller Date: Thu, 09 Oct 2025 17:03:51 -0700 Subject: [PATCH net v3 6/6] ixgbe: fix too early devlink_free() in ixgbe_remove() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251009-jk-iwl-net-2025-10-01-v3-6-ef32a425b92a@intel.com> References: <20251009-jk-iwl-net-2025-10-01-v3-0-ef32a425b92a@intel.com> In-Reply-To: <20251009-jk-iwl-net-2025-10-01-v3-0-ef32a425b92a@intel.com> To: Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Emil Tantilov , Alexander Lobakin , Willem de Bruijn , Sridhar Samudrala , Phani Burra , Piotr Kwapulinski , Simon Horman , Radoslaw Tyl , Jedrzej Jagielski Cc: Konstantin Ilichev , Milena Olech , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jacob Keller , Koichiro Den , Rinitha S , Aleksandr Loktionov , Paul Menzel X-Mailer: b4 0.15-dev-89294 X-Developer-Signature: v=1; a=openpgp-sha256; l=2595; i=jacob.e.keller@intel.com; h=from:subject:message-id; bh=jhRfq8T2cyWOmChhBNbcupsEiMKPHxR5Fk20EtnVGug=; b=owGbwMvMwCWWNS3WLp9f4wXjabUkhowXvhVz9L3/bfm68h5L8ps6rdKd39crh6/eyvJd49a8a 8cefP26oqOUhUGMi0FWTJFFwSFk5XXjCWFab5zlYOawMoEMYeDiFICJfPzC8Fckj0Uo/9OM9e0s 7xxmzpC/78A9P02K6Zntrx/qSjd0ZM8xMtyqzaq1+SVzgaN+96Em2e5pS96al+lwC/pPuMbq/33 Ob3YA X-Developer-Key: i=jacob.e.keller@intel.com; a=openpgp; fpr=204054A9D73390562AEC431E6A965D3E6F0F28E8 From: Koichiro Den Since ixgbe_adapter is embedded in devlink, calling devlink_free() prematurely in the ixgbe_remove() path can lead to UAF. Move devlink_free() to the end. KASAN report: BUG: KASAN: use-after-free in ixgbe_reset_interrupt_capability+0x140/0x180= [ixgbe] Read of size 8 at addr ffff0000adf813e0 by task bash/2095 CPU: 1 UID: 0 PID: 2095 Comm: bash Tainted: G S 6.17.0-rc2-tnguy.net-queu= e+ #1 PREEMPT(full) [...] Call trace: show_stack+0x30/0x90 (C) dump_stack_lvl+0x9c/0xd0 print_address_description.constprop.0+0x90/0x310 print_report+0x104/0x1f0 kasan_report+0x88/0x180 __asan_report_load8_noabort+0x20/0x30 ixgbe_reset_interrupt_capability+0x140/0x180 [ixgbe] ixgbe_clear_interrupt_scheme+0xf8/0x130 [ixgbe] ixgbe_remove+0x2d0/0x8c0 [ixgbe] pci_device_remove+0xa0/0x220 device_remove+0xb8/0x170 device_release_driver_internal+0x318/0x490 device_driver_detach+0x40/0x68 unbind_store+0xec/0x118 drv_attr_store+0x64/0xb8 sysfs_kf_write+0xcc/0x138 kernfs_fop_write_iter+0x294/0x440 new_sync_write+0x1fc/0x588 vfs_write+0x480/0x6a0 ksys_write+0xf0/0x1e0 __arm64_sys_write+0x70/0xc0 invoke_syscall.constprop.0+0xcc/0x280 el0_svc_common.constprop.0+0xa8/0x248 do_el0_svc+0x44/0x68 el0_svc+0x54/0x160 el0t_64_sync_handler+0xa0/0xe8 el0t_64_sync+0x1b0/0x1b8 Fixes: a0285236ab93 ("ixgbe: add initial devlink support") Signed-off-by: Koichiro Den Tested-by: Rinitha S Reviewed-by: Jedrzej Jagielski Reviewed-by: Aleksandr Loktionov Reviewed-by: Paul Menzel Signed-off-by: Jacob Keller --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/et= hernet/intel/ixgbe/ixgbe_main.c index 90d4e57b1c93..ca1ccc630001 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -12101,7 +12101,6 @@ static void ixgbe_remove(struct pci_dev *pdev) =20 devl_port_unregister(&adapter->devlink_port); devl_unlock(adapter->devlink); - devlink_free(adapter->devlink); =20 ixgbe_stop_ipsec_offload(adapter); ixgbe_clear_interrupt_scheme(adapter); @@ -12137,6 +12136,8 @@ static void ixgbe_remove(struct pci_dev *pdev) =20 if (disable_dev) pci_disable_device(pdev); + + devlink_free(adapter->devlink); } =20 /** --=20 2.51.0.rc1.197.g6d975e95c9d7