From nobody Mon Feb 9 19:25:20 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A4461F03D8 for ; Thu, 9 Oct 2025 15:25:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760023512; cv=none; b=E6pKPcidTTxSW1M6puaC807dfscdbUrES6DPNMPb8qK5kI6qNC4cJdSpuGBmZ2zlzXwKWrT83SGD01Cz5S6s3QaQSU9iUtVal2gi6juHBbkFHLgEBxS265Z3XT9rKj/01M0HmWd3QpCI+oJgSCgqWfC7/r+HoOJAefsOvuFlhB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760023512; c=relaxed/simple; bh=8Ji8C7SpUzRnr4uMcWokKZW8lUvYX6JJLUSo4lu5Nb0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dyiK7nXASpfTAzlG31YJcpsPfSgAGv4Sf75fD/zoeoAQEZhJTw6KjQUlTHoY/WQ7p953J9yrU42LkuvirWGxgeim73TSSM/Z0XDnIxTU3ax6yYEx0/sIN5QXVhonCI3RQZOluw6B11k5ffn32JvwRL9OVtDdLInLYmodT/hhZAA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=txHzJWNF; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="txHzJWNF" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b3c2c748bc8so147288766b.2 for ; Thu, 09 Oct 2025 08:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760023507; x=1760628307; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ousPsrsRzOuJ9D//mwlWhy/3PCTfUESlugicNK8z87Q=; b=txHzJWNFiTE2JcnC5bG/2BCoGJAALc13E+ze6lvCIdC1ko4/4SY5l9qMQr+GBNDgxN OiS3lN1EMVH7eWdRPwPz221avsGZuWhF3rSzIOa3r0h+y1MB9O8572mwfHkSHosz8g6L aG7MIrvX1bqhP993pyHFq7zAm1Ied0ThMOpJixADrCRzhlvfXpBumRVYeq6N4p6gkVZm W8Ug8Q6nnSeqe5yTT2EI+/MvO/dYrkS4muRChBf0FcPXauk4yQRCDxiz05BzBOe0MUgG ucdD2Y9lj+pnpDeE6GDhA6ZoSZ6+RUYAWEx3rSfsh/28C1VwAsAOLXHprOGCj78ERZDU F0gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760023507; x=1760628307; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ousPsrsRzOuJ9D//mwlWhy/3PCTfUESlugicNK8z87Q=; b=ZFoewh00RbCxnuxNV3FcUznR73vNoxymYJW6s4MVuk4iReRi+5fqrKndSvnI6cjvAL ShqxWzmix+IpUtaK5u6zxBJZr7KtuUf78FEV+IDs7yjHhrYxAviCUX/nkLf+qKZ64u+s E7RqDJbxl/+9pp4i14FYg5/hcTZI8EAnhIogSaJCNxdN/0ln30DZmA8jCvaqtHtgh2FM FUgvF9d5JhZSPWfu/NtyRNbvZ3IgwOTfcc2USMKM2AtrR+uM3/zS/LikAqKgHt5N9kEn fIb327FJlmN3h7UPJMqXLPpGug280iueLuQ2JXYiYzRdtMP5Jx/gAb7Sr2JUczrLS7Cp Svwg== X-Forwarded-Encrypted: i=1; AJvYcCViD6SPk87+/Fr+2Fx99PU9s7jvywY1izFootAgjGkqyAH23/wgtVNA2Rz+lMlQi7z1hmtyOTIm3/+BmYY=@vger.kernel.org X-Gm-Message-State: AOJu0YxQOimuCzvlpyqQ83eQOXKi+cCrJmW8tn6p7443NGCteY98iZpb xKlvdg40fbVjCuh3FEjV79ix1JJK9rnsSfYXwAblAOiAkOgtM2UoZurAHVOpflgI4zM= X-Gm-Gg: ASbGnctH22ccJ/NY/Zr0TM9UpgYIyxILTsJ8HuigjcTBlUWP258Y/rtVxlE5TXjkLdo eKYp8D3mDFL1600FWu9rpfSaY9s2On95dswk7artPOLLZy6jqE9MUYujJe9v8/sButLzqdDCypX n+sDXmtXVCqA1DYHuTFU3Yt04v+J3gLlpkG1Z46cvUYDc2wPtF746s5/ESumLtOX9oC033VdKln EAskJ/TqyMQkOfRjpX7BTv/2RA6jEYMr08he9qfH3zDF2A8S/6A8S0TAscfPZo9GjrJnjWXXUXX RySmvhS1nNOOeTkB+Yd102s8m4vqxJE6nzEDMvrOw7Xe+qktTNNum7yqy22vcxO3Ys+jHhHehoy uIwtxoBMJfFTk7bDr65gThN693yBxI5FKpSUnOu60DM39xNqGgbD7zyIKJs1OnCXBlttPlkmTh9 ExtXyssgppoVougrZBkleEFb6ASqg6WULhGsct8hVMLkhOfskD3UY= X-Google-Smtp-Source: AGHT+IGU5YJiQEOLDla4H1yxJNOxda/6iu+/j1tDENPR+jWfagJHuOHAMVeCVTX+CKrhpEHAyCcJqQ== X-Received: by 2002:a17:907:934a:b0:b48:730:dbb3 with SMTP id a640c23a62f3a-b50ac1cc3eemr881096366b.32.1760023507336; Thu, 09 Oct 2025 08:25:07 -0700 (PDT) Received: from puffmais2.c.googlers.com (224.138.204.35.bc.googleusercontent.com. [35.204.138.224]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b486970b36fsm1908967566b.62.2025.10.09.08.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 08:25:06 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Thu, 09 Oct 2025 16:25:06 +0100 Subject: [PATCH v2 04/10] pmdomain: samsung: plug potential memleak during probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251009-gs101-pd-v2-4-3f4a6db2af39@linaro.org> References: <20251009-gs101-pd-v2-0-3f4a6db2af39@linaro.org> In-Reply-To: <20251009-gs101-pd-v2-0-3f4a6db2af39@linaro.org> To: Krzysztof Kozlowski , Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson , Marek Szyprowski Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , stable@vger.kernel.org X-Mailer: b4 0.14.2 of_genpd_add_provider_simple() could fail, in which case this code leaks the domain name, pd->pd.name. Use devm_kstrdup_const() to plug this leak. As a side-effect, we can simplify existing error handling. Fixes: c09a3e6c97f0 ("soc: samsung: pm_domains: Convert to regular platform= driver") Cc: stable@vger.kernel.org Reviewed-by: Peter Griffin Signed-off-by: Andr=C3=A9 Draszik Reviewed-by: Krzysztof Kozlowski --- v2: reword commit message, as this isn't a pure simplification --- drivers/pmdomain/samsung/exynos-pm-domains.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/pmdomain/samsung/exynos-pm-domains.c b/drivers/pmdomai= n/samsung/exynos-pm-domains.c index 5d478bb37ad68afc7aed7c6ae19b5fefc94a9035..f53e1bd2479807988f969774b4b= 7b4c5739c1aba 100644 --- a/drivers/pmdomain/samsung/exynos-pm-domains.c +++ b/drivers/pmdomain/samsung/exynos-pm-domains.c @@ -92,13 +92,14 @@ static const struct of_device_id exynos_pm_domain_of_ma= tch[] =3D { { }, }; =20 -static const char *exynos_get_domain_name(struct device_node *node) +static const char *exynos_get_domain_name(struct device *dev, + struct device_node *node) { const char *name; =20 if (of_property_read_string(node, "label", &name) < 0) name =3D kbasename(node->full_name); - return kstrdup_const(name, GFP_KERNEL); + return devm_kstrdup_const(dev, name, GFP_KERNEL); } =20 static int exynos_pd_probe(struct platform_device *pdev) @@ -115,15 +116,13 @@ static int exynos_pd_probe(struct platform_device *pd= ev) if (!pd) return -ENOMEM; =20 - pd->pd.name =3D exynos_get_domain_name(np); + pd->pd.name =3D exynos_get_domain_name(dev, np); if (!pd->pd.name) return -ENOMEM; =20 pd->base =3D of_iomap(np, 0); - if (!pd->base) { - kfree_const(pd->pd.name); + if (!pd->base) return -ENODEV; - } =20 pd->pd.power_off =3D exynos_pd_power_off; pd->pd.power_on =3D exynos_pd_power_on; --=20 2.51.0.710.ga91ca5db03-goog