From nobody Mon Feb 9 14:00:20 2026 Received: from mail.hostpark.net (mail.hostpark.net [212.243.197.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD7D925782A; Wed, 8 Oct 2025 12:55:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.243.197.30 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759928159; cv=none; b=E/TyqjVwL9wbg0v57mhB0qTN2FmPKXb+r27jLy28QmPEdBBOLXjiqMWX7PLjXcB5GMNR0UaUKKgvKBf/MdbVzIuI/p+BuS0Zgh4whNkYzaACK8sXPiJ3yYwSA5UR6udm46BotnaB/OIR6GioR0s/feiPaPDcp9u5yLQElI/wjBk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759928159; c=relaxed/simple; bh=pDfzvHYumkVNgP6Bt5JPh8DBBBEuka+mLIWH3ZAsB2o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=atA1fIAKvaQfHKmII73F+aOD4yiA1yl1QixHJkAqivOOtZGiYZPzAOjnht0HJx0sRmB/dSljp6jn2WDGXqHGLpZEUZjMoXKZhTpvyR7fT7xcM62fLGuACDq+IGEoUq1QdIY/r9CiYQRcsMIOJ7QEd/jRc3BnLEj8LWd7KheoLe0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=klarinett.li; spf=pass smtp.mailfrom=klarinett.li; dkim=pass (1024-bit key) header.d=klarinett.li header.i=@klarinett.li header.b=vN4sZAug; arc=none smtp.client-ip=212.243.197.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=klarinett.li Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=klarinett.li Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=klarinett.li header.i=@klarinett.li header.b="vN4sZAug" Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 308291626A; Wed, 08 Oct 2025 14:50:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=klarinett.li; h= content-transfer-encoding:mime-version:x-mailer:message-id:date :date:subject:subject:from:from; s=sel2011a; t=1759927814; bh=pD fzvHYumkVNgP6Bt5JPh8DBBBEuka+mLIWH3ZAsB2o=; b=vN4sZAugpzoz2+uT9T 8IQQnCxYyVpNNcNZ/bHq6PufnqkdwfRGcnYiI2QqQ1LcqvwuHvJQ/IZpGwu+hbz7 3rg4ZlwUuy5b6whf62mh0qTBWHHPB6RX8qoU+7KdKZEOtGba8vopOOpokFDceugm pDvu3FH+YefZAU1EU98quYmXg= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavis, port 10224) with ESMTP id a5dJLw3_iP49; Wed, 8 Oct 2025 14:50:14 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id A3E951614C; Wed, 08 Oct 2025 14:50:13 +0200 (CEST) From: Christian Hitz To: Lee Jones , Pavel Machek Cc: Christian Hitz , stable@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] leds: leds-lp50xx: allow LED 0 to be added to module bank Date: Wed, 8 Oct 2025 14:32:21 +0200 Message-ID: <20251008123222.1117331-1-christian@klarinett.li> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Christian Hitz led_banks contains LED module number(s) that should be grouped into the module bank. led_banks is 0-initialized. By checking the led_banks entries for 0, un-set entries are detected. But a 0-entry also indicates that LED module 0 should be grouped into the module bank. By only iterating over the available entries no check for unused entries is required and LED module 0 can be added to bank. Signed-off-by: Christian Hitz Cc: stable@vger.kernel.org Reviewed-by: Jacek Anaszewski --- drivers/leds/leds-lp50xx.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c index 94f8ef6b482c..d50c7f3e8f99 100644 --- a/drivers/leds/leds-lp50xx.c +++ b/drivers/leds/leds-lp50xx.c @@ -341,17 +341,15 @@ static int lp50xx_brightness_set(struct led_classdev = *cdev, return ret; } =20 -static int lp50xx_set_banks(struct lp50xx *priv, u32 led_banks[]) +static int lp50xx_set_banks(struct lp50xx *priv, u32 led_banks[], int num_= leds) { u8 led_config_lo, led_config_hi; u32 bank_enable_mask =3D 0; int ret; int i; =20 - for (i =3D 0; i < priv->chip_info->max_modules; i++) { - if (led_banks[i]) - bank_enable_mask |=3D (1 << led_banks[i]); - } + for (i =3D 0; i < num_leds; i++) + bank_enable_mask |=3D (1 << led_banks[i]); =20 led_config_lo =3D bank_enable_mask; led_config_hi =3D bank_enable_mask >> 8; @@ -405,7 +403,7 @@ static int lp50xx_probe_leds(struct fwnode_handle *chil= d, struct lp50xx *priv, return ret; } =20 - ret =3D lp50xx_set_banks(priv, led_banks); + ret =3D lp50xx_set_banks(priv, led_banks, num_leds); if (ret) { dev_err(priv->dev, "Cannot setup banked LEDs\n"); return ret; --=20 2.51.0