From nobody Wed Feb 11 06:30:12 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8166535966 for ; Wed, 8 Oct 2025 12:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759926757; cv=none; b=pxrXSHZbXtaPLXNffVWyimh2vs9Z9H4iugLQIperMZ53dvOxt/PCGfijeojTmDsStlnEd1RW+sNsXvIYGJEd2J10QJ6h/8sCc67+58m2y/y8mq8jjUVqdbyWrn1Nmz/lELMNEonNrUBEoFyoP2kIehG0fwbMAn9CDxOrDOlZ/PA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759926757; c=relaxed/simple; bh=BbNmQemkRXT0PPX4T4yxdzIGVzZNni1zIWvxlTMEN54=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=Qdbygd/bGlTDa/7SBiJhGIFw5jFGBV3t7Qh54T3kX7uvV03uEKTiNXV34keaMtWfJVg3A3Lc9D0zPNRjRLw6YZQfv1MBoZuEt/tzGK649Wajkm0QPLuZMU2ujr52NrJ6J9pXkj3SCaWo+oRh5UkF43N4pcibvSh+6eC+EeGH3SM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RFRHUhLS; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RFRHUhLS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759926754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=fKLnyQUCu2ZpDNTuQSd/OvsIqqCGMU2IGAT+l5MmJp8=; b=RFRHUhLScq37EZGpDRWPtiKFpBqw/eLT+gSUyjCv7YSa8WKH1s+PpgOnOGdSdnQEiwvE2D +5tFq8UwXYZEIIdYmBCeTzOfP2JURp2mOexwTcO5yQTQgqOj6qZbdILagk7E5/O4Sp4jhI vWzgwgHP8Ra7VqLKgi90mdSFlsPIn+M= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-37-beVTel1LMU6LMlCra8z7dQ-1; Wed, 08 Oct 2025 08:32:33 -0400 X-MC-Unique: beVTel1LMU6LMlCra8z7dQ-1 X-Mimecast-MFC-AGG-ID: beVTel1LMU6LMlCra8z7dQ_1759926752 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BA65419560A1; Wed, 8 Oct 2025 12:32:31 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.227.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 7FB2B180047F; Wed, 8 Oct 2025 12:32:27 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 8 Oct 2025 14:31:11 +0200 (CEST) Date: Wed, 8 Oct 2025 14:31:05 +0200 From: Oleg Nesterov To: Alexander Viro , Boqun Feng , David Howells , Ingo Molnar , Li RongQing , Linus Torvalds , Peter Zijlstra , Waiman Long , Will Deacon Cc: linux-kernel@vger.kernel.org Subject: [PATCH v2 4/4] seqlock: change do_io_accounting() to use scoped_seqlock_read_irqsave() Message-ID: <20251008123105.GA20449@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251008123014.GA20413@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To simplify the code and make it more readable. Signed-off-by: Oleg Nesterov --- fs/proc/base.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index 62d35631ba8c..08113bb6af1d 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -3041,20 +3041,14 @@ static int do_io_accounting(struct task_struct *tas= k, struct seq_file *m, int wh if (whole) { struct signal_struct *sig =3D task->signal; struct task_struct *t; - unsigned int seq =3D 1; - unsigned long flags; =20 rcu_read_lock(); - do { - seq++; /* 2 on the 1st/lockless path, otherwise odd */ - flags =3D read_seqbegin_or_lock_irqsave(&sig->stats_lock, &seq); - + scoped_seqlock_read_irqsave(&sig->stats_lock) { acct =3D sig->ioac; __for_each_thread(sig, t) task_io_accounting_add(&acct, &t->ioac); =20 - } while (need_seqretry(&sig->stats_lock, seq)); - done_seqretry_irqrestore(&sig->stats_lock, seq, flags); + } rcu_read_unlock(); } else { acct =3D task->ioac; --=20 2.25.1.362.g51ebf55