From nobody Sun Feb 8 02:21:47 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33F2F2E7F13 for ; Tue, 7 Oct 2025 16:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759854150; cv=none; b=RBDcPNj1CpJTlHnp+WpeWrRRhyixmd+m21QUIDEV9GcFC+5A2Mz26EzjOZ8dcgIjBFF7fXZtDh2LojcjfJV/JYYtPv7jp1wuKa54tXKQ2yFRm3Hu6M2ixuYwPp7ldvCL0W0KA9sWfqnBBfrl5BPF2eTk4IlphwYU23p9f7dqOsk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759854150; c=relaxed/simple; bh=jNPXFguZ0o33eieY8lz73vZNTUwXVK/ZZse4W5W/FWs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tde95MDl3Uyvir0+dH303LbS6mC36BeKxysv0JMk/42nOkKqZYZznIOgNDcHEJYWh2GZc2vnBrIXpLNZ+5K4RvFpq4TN4RtYd3KM0mxOIkL/Jg2aWF9bdRfzDwauttPwWH+kBdikFJ+JBLubGd7X4qOdvG7Fq2F5vVVLQX3lG2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PV3YpeQe; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PV3YpeQe" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-b593def09e3so4787487a12.2 for ; Tue, 07 Oct 2025 09:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759854148; x=1760458948; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PpoHs7x3DMAGLg3gdog2cHx5D9ViCBx9xQddbSTGLHY=; b=PV3YpeQeTFIl2wsKaDZByDBNmRKdoqol6WSHRz6SdDnrLV4MyaXQvyQiByFh0spgCS +ScbZJhGvjgjQ9cVpBBh+gmTD4xoEqR6JojPfsJ45t8KRytjwqcATnSuyxCB58AxBxF7 nvsuGq9x6WSIp2ogFhLc6GS6/DOeEvshGMEGZx0FOrHYyMsb3666X3GCb2vlUwKoJJ1R 2bmlNDQrsW6x9b8rzXD7TEezTFZL+ZVHu0wbp6bFunpDkxaD11ldpB1y8tpumpak4/Rp IdGzOzk4+GDtwcKGwVBcKaQ6Fyvj/jqz/q3HHBUQAwSla9MWZYAMEdoFlVU1TUwFBpL2 d25g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759854148; x=1760458948; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PpoHs7x3DMAGLg3gdog2cHx5D9ViCBx9xQddbSTGLHY=; b=N6b0uNoy2VpqO3qAFyEYoz8KqTJCVDghrcCxn4zcxNXVF1QfeNimi2vSplquUVE/d0 vPGC2aV+Nr4wrZo0yctH1RfRUd/oCrRYdy7QrHEMEIFwT+lbvPblnzGM8Q34ZrVhFm3H 3AG6xnu/gaH50jxanUXCbbnDi56ijrVW0v2x8ghMTCNKdXfW2sUd3vHr4xDC0cOtSkDF N0jOm4IJXBzxc+BdZrJ8Z9gNgN7rUUPEmXkK1wu69Vj9kuS5c0czbWWgG0ANmCDIz/ZX OKQpLGu6TohLIiMPRv2Y/VVZarJ38szdeftCQpdYtnohZNK4UNbIGWExLC76Y6lqx7EW Q9AQ== X-Forwarded-Encrypted: i=1; AJvYcCXSQQL2sv8AuLVN6aIPzTbMNAr0+KSbfTByX29muXMk1Jx8Q+fljl93o3Guu87MqPgHyoSnQTMKUMDHrfw=@vger.kernel.org X-Gm-Message-State: AOJu0Yynv2NBOLgTyeEToP/g6dcptdFxjnXC1weNNUS8Ze7hJxjZDPg/ hKjDFp8vhKeBJwJz6GIRd80Bnf22Iok9EY16RSSaPOKGG+sReqCzPoig X-Gm-Gg: ASbGncu4uSGDbP4TqvMqrCxEP7vfV+u4oSGj8c7Ul/9fNBUOhNamCTL3eLp9YroqH2J BhWuCjBgN4fYg3vc1nvWt4dUnh6z4yQM1WGTxt8gLM4VlYUXi4dRzvIOahueas1cZ+QrMkJaNSC 3noy5DOT7lqqCYMq0Qz22wwcwY9uL1bKn0s4F+Pd9pkr0WBGyzB2/abeX4+bE2P7Ky8UBhR8uF4 xaX32SbMLMUPube75VtzYS1YEMLHtm3nw3C2AP56Lc1eurTDUPuxoj/mNo/1V5yNXmEKMTj6YTt +mq3Xkf3HHsBmXI/cUxBLx6UVFIUJ1yVjVyL1u8SntvDygcbnIvVSSOit+r1MoekHX9Z9G19xFA 3YYEklk9mZweNnw1Fze/758u5MGNBAJKjOjCOPgRBguTGcxCxQJclELWUjy5OQIs= X-Google-Smtp-Source: AGHT+IEVmC+M/InRT3VdaLJRW/KctK/jw/7e7suEc5r/fdcvZSXq5B54eCtA1zk17y2IKaq6ovlUJw== X-Received: by 2002:a17:90b:1e0c:b0:32e:87fa:d975 with SMTP id 98e67ed59e1d1-33b513ebbedmr59703a91.34.1759854147989; Tue, 07 Oct 2025 09:22:27 -0700 (PDT) Received: from rakuram-MSI.. ([2405:201:d027:f04e:d2f9:a2da:e7d:3e96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-339ee0f830fsm1431733a91.5.2025.10.07.09.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Oct 2025 09:22:27 -0700 (PDT) From: Rakuram Eswaran To: ulf.hansson@linaro.org Cc: zhoubinbin@loongson.cn, u.kleine-koenig@baylibre.com, chenhuacai@kernel.org, david.hunter.linux@gmail.com, skhan@linuxfoundation.org, khalid@kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, rakuram.e96@gmail.com, linux-kernel-mentees@lists.linux.dev, kernel test robot , Dan Carpenter Subject: [PATCH] mmc: pxamci: Fix passing NULL to PTR_ERR() in pxamci_probe() Date: Tue, 7 Oct 2025 21:47:44 +0530 Message-ID: <20251007161948.12442-1-rakuram.e96@gmail.com> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Smatch reported: drivers/mmc/host/pxamci.c:709 pxamci_probe() warn: passing zero to 'PTR_ERR' Case 1: When dma_request_chan() fails, host->dma_chan_rx is an ERR_PTR(), but it is reset to NULL before using PTR_ERR(), resulting in PTR_ERR(0). This mistakenly returns 0 instead of the real error code. Case 2: When devm_clk_get() fails, host->clk is an ERR_PTR() resulting in the simil= ar issue like case 1.=20 Store the error code before nullifying the pointers in both the cases. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202510041841.pRlunIfl-lkp@intel.com/ Fixes: 58c40f3faf742c ("mmc: pxamci: Use devm_mmc_alloc_host() helper") Signed-off-by: Rakuram Eswaran Reviewed-by: Binbin Zhou Reviewed-by: Dan Carpenter Reviewed-by: Khalid Aziz --- Build and Analysis: This patch was compiled against the configuration file reported by 0day CI in the above link (config: s390-randconfig-r071-20251004) using `s390x-linux-gnu-gcc (Ubuntu 14.2.0-19ubuntu2) 14.2.0`.=20 Static analysis was performed with Smatch to ensure the reported warning=20 no longer reproduces after applying this fix. Command used for verification: ARCH=3Ds390 CROSS_COMPILE=3Ds390x-linux-gnu- \ ~/project/smatch/smatch_scripts/kchecker ./drivers/mmc/host/pxamci.c drivers/mmc/host/pxamci.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index 26d03352af63..4fab693d3b32 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc/host/pxamci.c @@ -653,8 +653,9 @@ static int pxamci_probe(struct platform_device *pdev) =20 host->clk =3D devm_clk_get(dev, NULL); if (IS_ERR(host->clk)) { + ret =3D PTR_ERR(host->clk); host->clk =3D NULL; - return PTR_ERR(host->clk); + return ret; } =20 host->clkrate =3D clk_get_rate(host->clk); @@ -705,8 +706,9 @@ static int pxamci_probe(struct platform_device *pdev) =20 host->dma_chan_rx =3D dma_request_chan(dev, "rx"); if (IS_ERR(host->dma_chan_rx)) { + ret =3D PTR_ERR(host->dma_chan_rx); host->dma_chan_rx =3D NULL; - return dev_err_probe(dev, PTR_ERR(host->dma_chan_rx), + return dev_err_probe(dev, ret, "unable to request rx dma channel\n"); } =20 --=20 2.48.1