From nobody Mon Feb 9 15:10:08 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 568822E2F05 for ; Tue, 7 Oct 2025 15:03:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759849406; cv=pass; b=JFIXS49vyuRwYLeb5fPn6aMgCZ2J3DpIx6VEvccO64u6QQpC972UWc9qoSJqiSuwpZdB2I5Qknuu6quZkRsSsb5igSjquwcQOGP2zvS7GhMR7adnI8K29VbaD3fqyhbUUd8Jygjx2Or8vz0SFiMidrXTkktlGA335rUZTQz3a5M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759849406; c=relaxed/simple; bh=T1KP++pdpAKhBqkLIvU0lKLyUYOHHin9wwPwyKc3qW8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aYc2nFcHlS3UbpEF9f6L+3NKD+9t5nXx0NVFK/MPCZAVhTzo71DQUAcoPPRHr7MG0EiF9FeWzkQKfGtuLcxxg4AuIBkAMZx/WGeXHUU/umYncx/oRqjHF8XEhJd0NuvyWYWf/AhwanJGDXF3xgZtJDjCRQFADkUbt/6j0+nVusM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=h+3eK45s; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="h+3eK45s" ARC-Seal: i=1; a=rsa-sha256; t=1759849384; cv=none; d=zohomail.com; s=zohoarc; b=TksvRt1BLOoAKEvrhfosMKCpaFV/saii23xt4lbVsR3TnkAbdqxfF34ljyUPcBuPfZ11KC9Qt7O336UJOMZSW5u6fFjAe8X25Ta2ydstI2KzfJdTu60Q6Iwtp+jn9EbaI7PjfaRVi2epHo5RaHdLAUWccdL/neAnSBlafKbp4jM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759849384; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=5QawNYWd7VxW2zSnBaGlclqdmfFfU4hdRw2ONf/G3V0=; b=bM+Ui7jdKk4IUPAb4AkHDnU9S0lIi2ulXFwRUWkCKVxjgrj22YyO4tr3N5QY0T3oeEiWT6+6vE9NWjpnRYVvJFuTSQj8GmvMkhagJ5L6gRYZZuS3hgGHyeDvIBh7I7lpiqlfu+9A6k5T/MDH7gU2eMa0CjIaggUv90GsAasZ1ZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1759849384; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=5QawNYWd7VxW2zSnBaGlclqdmfFfU4hdRw2ONf/G3V0=; b=h+3eK45sv0zu87L04G4JdQY5tJj+w0zi25Koi8R4ekOiWb29+5nEC1F5v3nsXFZt ns3b/8+ZfzEuBr1Aw6SYK1gG0L8b/G2BtOOGBIy/6SeEXfylv6qIFGBfzNXOwWbDFUk XscXOJIBOmJ60p5JT1wGhYhDVZbtwTv1UmxhnirY= Received: by mx.zohomail.com with SMTPS id 1759849381716860.2690265101397; Tue, 7 Oct 2025 08:03:01 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Rob Herring , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v5 07/12] drm/panfrost: Don't rework job IRQ enable mask in the enable path Date: Tue, 7 Oct 2025 16:01:49 +0100 Message-ID: <20251007150216.254250-8-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251007150216.254250-1-adrian.larumbe@collabora.com> References: <20251007150216.254250-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Up until now, panfrost_job_enable_interrupts() would always recalculate the same job IRQ enablement mask, which is effectively a constant. Replace it with a compile-time constant value, and also in another couple places where an equivalent expression was being used. Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_device.h | 4 ++++ drivers/gpu/drm/panfrost/panfrost_job.c | 19 ++++--------------- 2 files changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/p= anfrost/panfrost_device.h index 474b232bb38e..ac7147ed806b 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.h +++ b/drivers/gpu/drm/panfrost/panfrost_device.h @@ -26,6 +26,10 @@ struct panfrost_perfcnt; =20 #define MAX_PM_DOMAINS 5 =20 +#define ALL_JS_INT_MASK \ + (GENMASK(16 + NUM_JOB_SLOTS - 1, 16) | \ + GENMASK(NUM_JOB_SLOTS - 1, 0)) + enum panfrost_drv_comp_bits { PANFROST_COMP_BIT_GPU, PANFROST_COMP_BIT_JOB, diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panf= rost/panfrost_job.c index 1b3af5d52081..ff525d3efd76 100644 --- a/drivers/gpu/drm/panfrost/panfrost_job.c +++ b/drivers/gpu/drm/panfrost/panfrost_job.c @@ -428,17 +428,10 @@ static struct dma_fence *panfrost_job_run(struct drm_= sched_job *sched_job) =20 void panfrost_job_enable_interrupts(struct panfrost_device *pfdev) { - int j; - u32 irq_mask =3D 0; - clear_bit(PANFROST_COMP_BIT_JOB, pfdev->is_suspended); =20 - for (j =3D 0; j < NUM_JOB_SLOTS; j++) { - irq_mask |=3D MK_JS_MASK(j); - } - - job_write(pfdev, JOB_INT_CLEAR, irq_mask); - job_write(pfdev, JOB_INT_MASK, irq_mask); + job_write(pfdev, JOB_INT_CLEAR, ALL_JS_INT_MASK); + job_write(pfdev, JOB_INT_MASK, ALL_JS_INT_MASK); } =20 void panfrost_job_suspend_irq(struct panfrost_device *pfdev) @@ -757,9 +750,7 @@ panfrost_reset(struct panfrost_device *pfdev, drm_sched_start(&pfdev->js->queue[i].sched, 0); =20 /* Re-enable job interrupts now that everything has been restarted. */ - job_write(pfdev, JOB_INT_MASK, - GENMASK(16 + NUM_JOB_SLOTS - 1, 16) | - GENMASK(NUM_JOB_SLOTS - 1, 0)); + job_write(pfdev, JOB_INT_MASK, ALL_JS_INT_MASK); =20 dma_fence_end_signalling(cookie); } @@ -832,9 +823,7 @@ static irqreturn_t panfrost_job_irq_handler_thread(int = irq, void *data) =20 /* Enable interrupts only if we're not about to get suspended */ if (!test_bit(PANFROST_COMP_BIT_JOB, pfdev->is_suspended)) - job_write(pfdev, JOB_INT_MASK, - GENMASK(16 + NUM_JOB_SLOTS - 1, 16) | - GENMASK(NUM_JOB_SLOTS - 1, 0)); + job_write(pfdev, JOB_INT_MASK, ALL_JS_INT_MASK); =20 return IRQ_HANDLED; } --=20 2.51.0