From nobody Wed Feb 11 19:09:27 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2B962D8799; Tue, 7 Oct 2025 09:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759830296; cv=none; b=YP5X3NZWrg5GL2xNweUg/r4PZ/Bk+adyK4YH0Fq2e+RB3hHkUk5uw2XqtVn9Uhfl2ulRENRjQ59mhl+x0+qcc0pz8P6BoCfK8n9swX/2OTe5ArNiXS6gcZDJ+/imRt3/JrYUHUYJM76d61V8ReRYE1uhn+qOco9dOvzIRj0tyqI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759830296; c=relaxed/simple; bh=sHAs1h2nj+F5QylxrrHzaX1LNy9B3/05QnbSzhIUHoE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i5wTz6M8/bW0+THUfx8jsqdNwzc1X8o2+Wu4wX5I/tIy94xZVnOvx8bBx0xWv1Gw0xtcOzcbauupQC6OTxaQ3pJX4TvmqZRr2eHqE1W6OCC71hQQ+RrDjUQiyKnLMSewi4MYyrB7Q6bKxtf0OmFTANZaznIaIDhuFd6I1ChlhsY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hGobKLQ8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hGobKLQ8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F881C4CEF9; Tue, 7 Oct 2025 09:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759830295; bh=sHAs1h2nj+F5QylxrrHzaX1LNy9B3/05QnbSzhIUHoE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hGobKLQ8yajJbGwbnsBI/ukgknoOyJO6eaw4Acko2LP+OFrp9uk67LgL64U+qa0lF gc4URbPn+TYv3ocJqp8Vpha6Zds1a9LPKy0zO4Sv5FM4AUflQt9HM4YeDsMDWD+Q/Q OgPsCr8iEzd6ObFySWekM0kuy6D8LQTyS5Z6iYEgFD43UHVcPjlt/dYZbjW6NyANTM MUTfs64tBKg2vq7V/TG9Z+RAZNS8j32jJ3YCKYRGwbuOBZZ5+0a/j1WZJ/vbGu7iJq s5ADMtrOLJz+nCbu/A/5Kse6nncaVY3ciRbDhgbqQ1d5n41IXlmT9CTkT5yRWjHlBG 1zDyZzEX8aW/g== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1v64FZ-0000000035t-212c; Tue, 07 Oct 2025 11:44:53 +0200 From: Johan Hovold To: Joerg Roedel , Will Deacon Cc: Robin Murphy , Sven Peter , Janne Grunau , Rob Clark , Marek Szyprowski , Yong Wu , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai , Thierry Reding , Krishna Reddy , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Honghui Zhang Subject: [PATCH v2 08/14] iommu/mediatek-v1: fix device leak on probe_device() Date: Tue, 7 Oct 2025 11:43:21 +0200 Message-ID: <20251007094327.11734-9-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20251007094327.11734-1-johan@kernel.org> References: <20251007094327.11734-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference taken to the iommu platform device when looking up its driver data during probe_device(). Fixes: b17336c55d89 ("iommu/mediatek: add support for mtk iommu generation = one HW") Cc: stable@vger.kernel.org # 4.8 Cc: Honghui Zhang Acked-by: Robin Murphy Signed-off-by: Johan Hovold Reviewed-by: Yong Wu --- drivers/iommu/mtk_iommu_v1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c index 10cc0b1197e8..de9153c0a82f 100644 --- a/drivers/iommu/mtk_iommu_v1.c +++ b/drivers/iommu/mtk_iommu_v1.c @@ -435,6 +435,8 @@ static int mtk_iommu_v1_create_mapping(struct device *d= ev, return -EINVAL; =20 dev_iommu_priv_set(dev, platform_get_drvdata(m4updev)); + + put_device(&m4updev->dev); } =20 ret =3D iommu_fwspec_add_ids(dev, args->args, 1); --=20 2.49.1