From nobody Wed Feb 11 19:09:27 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4360F2D6E51; Tue, 7 Oct 2025 09:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759830295; cv=none; b=f+cSq8Fciu59Xj1wWSI6bcP5b2IAk2Wokr3nv+pE043bfNdogF+BuefinVj2gTW2fov66YQWnA3CEPv5D7CoebEoW3zPqJXoUKAdW0p1MEU+vFtyMA3rjsAvszn2p6mipD1pS+vzZfLNHcqP1mf1NzTO7/ay0u0IU98LvLV4a7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759830295; c=relaxed/simple; bh=/ZOvDlaE5co2FsuffrPvaCXpclhBsGaMcrTzFAqteP8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XPTpWSbcuyPBx1jbW11veYiFtKD6irnT9iJ/I7KdoP0ksiFCCJu5QJ4b0TKCWvlP9Gco0cNbHS8g4bcSnPA3UKyznr9wCi26ZpodGnaXr0O8nxI008aokzDByXzVCJxbl7uiOxRtuAkjBe37guRVpfqODEbY+v0efB4UDNAQY80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RSVV7yr+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RSVV7yr+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFD0AC19421; Tue, 7 Oct 2025 09:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759830295; bh=/ZOvDlaE5co2FsuffrPvaCXpclhBsGaMcrTzFAqteP8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RSVV7yr+5OVgnHY6oNeJOOgE0BC9uK4Osp/Q67gwk4md/e4XtHt+nCmFKyHbdVBQX 4k9u+lGgb/xcNve564U1DUABJd8gsM+bfq0AIHI/s4P77imstehCxIjddEk2EvzbBI EW8gg5NGGaVX8Df8Ej66Rvt9KJMHGd0xdbhK3Kr1+R+AV+lNhsVlxrnMFD6f3udobc KP3oZq0t7L7QrCENHji37nwv6rXBhSUqaoZXL1fyy1LnVEQyEdgVh/uqxDt5coEyLZ 908aPS4zWfG1ZuGbBo4zBbD+wm8dLEuNMGpDxFpqX0V+rniBXPVc2D4sTAMzOuxHmN WwyON/5bk3VYw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1v64FY-0000000035f-48dj; Tue, 07 Oct 2025 11:44:53 +0200 From: Johan Hovold To: Joerg Roedel , Will Deacon Cc: Robin Murphy , Sven Peter , Janne Grunau , Rob Clark , Marek Szyprowski , Yong Wu , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai , Thierry Reding , Krishna Reddy , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Yu Kuai Subject: [PATCH v2 03/14] iommu/exynos: fix device leak on of_xlate() Date: Tue, 7 Oct 2025 11:43:16 +0200 Message-ID: <20251007094327.11734-4-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20251007094327.11734-1-johan@kernel.org> References: <20251007094327.11734-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference taken to the iommu platform device when looking up its driver data during of_xlate(). Note that commit 1a26044954a6 ("iommu/exynos: add missing put_device() call in exynos_iommu_of_xlate()") fixed the leak in a couple of error paths, but the reference is still leaking on success. Fixes: aa759fd376fb ("iommu/exynos: Add callback for initializing devices f= rom device tree") Cc: stable@vger.kernel.org # 4.2: 1a26044954a6 Cc: Marek Szyprowski Cc: Yu Kuai Acked-by: Robin Murphy Signed-off-by: Johan Hovold Acked-by: Marek Szyprowski --- drivers/iommu/exynos-iommu.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index b6edd178fe25..ce9e935cb84c 100644 --- a/drivers/iommu/exynos-iommu.c +++ b/drivers/iommu/exynos-iommu.c @@ -1446,17 +1446,14 @@ static int exynos_iommu_of_xlate(struct device *dev, return -ENODEV; =20 data =3D platform_get_drvdata(sysmmu); - if (!data) { - put_device(&sysmmu->dev); + put_device(&sysmmu->dev); + if (!data) return -ENODEV; - } =20 if (!owner) { owner =3D kzalloc(sizeof(*owner), GFP_KERNEL); - if (!owner) { - put_device(&sysmmu->dev); + if (!owner) return -ENOMEM; - } =20 INIT_LIST_HEAD(&owner->controllers); mutex_init(&owner->rpm_lock); --=20 2.49.1