From nobody Wed Feb 11 19:09:24 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34CF22D3EDF; Tue, 7 Oct 2025 09:44:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759830295; cv=none; b=F1vKN/yd1/0XUKJDTQks+TuwV3LSAzAtA/YYTtGK6Gyme74qo69iKEPxoIF2OmwY0TaN2aF036Sx/ORIl1J2DScDV/9DCXHSwCIwLp+B9E1KGh8UPdNf9VPQQII0vIB4RA45mlyKnjpoEfrTo5J1rrDB6fFQTjjpPcO5FJDm4y8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759830295; c=relaxed/simple; bh=24lxMVd6ezJDeP+VC+ACkuc82KgwoZ9Q4vT6cNRNrWI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RoLc6nJ6OnzEwDN0n0sG6jZ7ppwlXG7W+AuHP00rH5p4hednSVCVjGDF1XD2GJIbzrupxTRSsDOkp5dYTpgWqrnXG/rYO/RkNYZv4rdbu6FQiwLYrDmbyCpL0bfErs0Zrn34f9qB3zKds9nnP2WKwAchkc3o+vqUHx/pyVCCQqs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LJcDcXAK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LJcDcXAK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA006C4CEF9; Tue, 7 Oct 2025 09:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759830294; bh=24lxMVd6ezJDeP+VC+ACkuc82KgwoZ9Q4vT6cNRNrWI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LJcDcXAKWu2jTe3Xb44iXIun7VW4wdME/I1WEC5X07Seq4WeR2ABkUmD4SqduLyF8 0wXOpmuMSbGK/MG5r0GCh+7bAJ8o+2wCw6dJYI1ySe5MARM7a8O/gdl+VDKbwqkPYH ILyOBOQOwDIVGyxLzXuCIiAB+pyZGVspU1lYPCKDG2mK11LoKaL4GSklpnURSjnYxq XkY58/YJw/2vMG3BjfNeFgqT5xmrVZm2nbTh//IXmTgBLJrVv+2vXO+JmUol5k2jWg HeMkmk1E3fh2rH8dQnWSyLYQ7w7A05btNgpxAXntt58SLZC0/QJmGSQn+o5i6BW8iL kxGPQY4syfhcw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1v64FY-0000000035Z-3O0C; Tue, 07 Oct 2025 11:44:52 +0200 From: Johan Hovold To: Joerg Roedel , Will Deacon Cc: Robin Murphy , Sven Peter , Janne Grunau , Rob Clark , Marek Szyprowski , Yong Wu , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai , Thierry Reding , Krishna Reddy , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH v2 01/14] iommu/apple-dart: fix device leak on of_xlate() Date: Tue, 7 Oct 2025 11:43:14 +0200 Message-ID: <20251007094327.11734-2-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20251007094327.11734-1-johan@kernel.org> References: <20251007094327.11734-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference taken to the iommu platform device when looking up its driver data during of_xlate(). Fixes: 46d1fb072e76 ("iommu/dart: Add DART iommu driver") Cc: stable@vger.kernel.org # 5.15 Cc: Sven Peter Acked-by: Robin Murphy Signed-off-by: Johan Hovold --- drivers/iommu/apple-dart.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c index 190f28d76615..1aa7c10262a8 100644 --- a/drivers/iommu/apple-dart.c +++ b/drivers/iommu/apple-dart.c @@ -790,6 +790,8 @@ static int apple_dart_of_xlate(struct device *dev, struct apple_dart *cfg_dart; int i, sid; =20 + put_device(&iommu_pdev->dev); + if (args->args_count !=3D 1) return -EINVAL; sid =3D args->args[0]; --=20 2.49.1