From nobody Wed Feb 11 19:10:34 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DED3C2D8789; Tue, 7 Oct 2025 09:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759830296; cv=none; b=AZ1sVpWnHQO4KjZdgaSNvsGzTB7odRy03h8+UQomo21CUHYzUTg54Vn3jfPurAFT9BRuM0U1DbcckQxDYmfAGw5R5uBR+yfG8HiF1JJJveuwlYHJBJtIUeLkS5FrqizkkdC1r5UdgLED3ZShp5xe4acdAetW9/lgc6/GxM8/PDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759830296; c=relaxed/simple; bh=XGze0MX6pPcBSBg10ExvQZidlcuv2+y5+RAOY6fdhVM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jYzEKArDLW+B6nY1VZ9eK2V+GPuMllAkThjyik+aOSDgQLB8sC+dIu9kF8C1D6m+hUr8ka5wMbIzpiVUfq9aupeVVIAvtdUw4auaSni9Z9Z3xXMzUtpOdall9F5w4+2K/zmUOyTBzPUaUkYdV+6rQafNuiuqjZr1qymrEH0BjJM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vHupJOz9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vHupJOz9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEBB5C4AF0D; Tue, 7 Oct 2025 09:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759830295; bh=XGze0MX6pPcBSBg10ExvQZidlcuv2+y5+RAOY6fdhVM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vHupJOz9DB60p6nlsJmul5k+PmHQF2uqT7w8MOSPUSAvTPbOTnu+ME+eh8CHWcjMT wm5fsCTGtJs9qUJAs5Mwp02ru4hw3mZS98SDpepcRH0rcsO1OdAJ4axx7HpECWQbd2 jdiQULvwXTBy/bv1D9z8wDSWhF2ju7rikZAcnBDqUR1KTZIX4WHeDADmvtioVCr55L 1sKcmkjsm68XDFv/Mw9FQXP6cwNvZKsUfTFH/Evo77t0iXpvdfWU/hrnsKPzlVJcwN REM9+7VszFjm2WfuM0dCaxhEL1mooWess2tlBo4lJwhkexAGPP/HsdF6/Zmgo/n+Kk imB0viAR4lxiA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1v64FZ-00000000368-3q0p; Tue, 07 Oct 2025 11:44:53 +0200 From: Johan Hovold To: Joerg Roedel , Will Deacon Cc: Robin Murphy , Sven Peter , Janne Grunau , Rob Clark , Marek Szyprowski , Yong Wu , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai , Thierry Reding , Krishna Reddy , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Maxime Ripard Subject: [PATCH v2 13/14] iommu/sun50i: fix device leak on of_xlate() Date: Tue, 7 Oct 2025 11:43:26 +0200 Message-ID: <20251007094327.11734-14-johan@kernel.org> X-Mailer: git-send-email 2.49.1 In-Reply-To: <20251007094327.11734-1-johan@kernel.org> References: <20251007094327.11734-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference taken to the iommu platform device when looking up its driver data during of_xlate(). Fixes: 4100b8c229b3 ("iommu: Add Allwinner H6 IOMMU driver") Cc: stable@vger.kernel.org # 5.8 Cc: Maxime Ripard Acked-by: Robin Murphy Signed-off-by: Johan Hovold --- drivers/iommu/sun50i-iommu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iommu/sun50i-iommu.c b/drivers/iommu/sun50i-iommu.c index de10b569d9a9..6306570d57db 100644 --- a/drivers/iommu/sun50i-iommu.c +++ b/drivers/iommu/sun50i-iommu.c @@ -839,6 +839,8 @@ static int sun50i_iommu_of_xlate(struct device *dev, =20 dev_iommu_priv_set(dev, platform_get_drvdata(iommu_pdev)); =20 + put_device(&iommu_pdev->dev); + return iommu_fwspec_add_ids(dev, &id, 1); } =20 --=20 2.49.1