From nobody Tue Dec 16 14:04:54 2025 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94EDF25A642 for ; Sun, 5 Oct 2025 18:25:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759688727; cv=none; b=TGA3fX/ZUUg78IxkXG2SrN2iedUogeg59/m7TC8VCH9Fid3/U/cI0qWbRWCxDx6kot9yQaGD++8Sjnb0bgxndL3Cp5z4HrzoVBTfQzNzj0vad8DC58HfP7MdSp/KYEsVvXSxsNWJ2gVBHdHr7nJ9o9jR4LxSRiimBAiEVHBhBds= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759688727; c=relaxed/simple; bh=uwNsvy1F00VwK4L921PJrGelX2It82/w3H9RpiCFMZQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=QQxSbXRprvPdMDpkGY05ZDG+elkAH7lxJ+CjXkjEokHNXbXOIpOb3aviuJER2LWe0JlxUea9/OiX03OmbZko6wtSt8vVQYsuEj3CUncqysD/Oh2YEFTwCWi4apF3txvmRVM9+32XAtCpbOKKAZTC7lHn4KvG+fvj9z9V4cs2sck= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=N2SfvXIo; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="N2SfvXIo" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-3352a336ee1so7608699a91.0 for ; Sun, 05 Oct 2025 11:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1759688724; x=1760293524; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Xeqf0FC6Rbstt0vQq1XdhtrR/aNogclupoL2fXVa550=; b=N2SfvXIooktyh16gjBKQsNmZV3nEqECvM4jBvogTC6zoxPOvlse2zZ2B8bhRmSFpWI LilmIuEJ+3m3I37tEMvUV8sJiBZEPLUWBOXjC4DpAYkYZJaYVMTlC33MwRiUPGuuIDWW RYuSHzn+JS428pQzSoSf0uNkMRo3udg9YXY78k44hsFPxtbnRk5f3jbE5i0xUvRQP0/t NGmZBFa/wHCDBoCB1RBJPb0TP1NaIZnyWyKH5xQdKy/+MEHwMHsEEj3UnT+gc+LjLjiy a6pxlIBkrVsguA9aYRwke+oe/9PtmfjuWeJBmGYyRzh4UN+ZaZLri1znzw3OqScQW+jx iWUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759688724; x=1760293524; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xeqf0FC6Rbstt0vQq1XdhtrR/aNogclupoL2fXVa550=; b=SsQJgMs+ieOffQ/ljgzzOHTElYkgu1o/adzuzY/Pz7ri1xoJ2JMCL2mzZpZ4jIR9ip 1W0vj9TZqB0z0Cxj2bNtFE/jdgNGiI5C4ehGv6jrg8Y3LUSWlgc9Cgctu1KkesJEqWmR uwqouXb6pYGCbwB/z2HdGcb3KLB9/QIq19T54LGT905nPBs52hkaOyaxClu1NsWqviz7 VexHppnsM4+NmD9ebI4XWBx0+6w5AxaLNCzrCCrT1RYQNwpd2cTGVH6cacHtXwDdudah gOIDHixS9p366drI6sQsetHGCQQCELP6BhGZW4rbdbVkNi5EjG4+tXGvCeycFq3WexKS hdDQ== X-Forwarded-Encrypted: i=1; AJvYcCWc3kqhwGv1YRNVTh63LdRX4bT5/BV4T4eb48fGP8tgOnDId0PBStN4pFPZM1DKe4epIwqBs7Jub2Y5bEI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz03JA6YWWM1l4w3/iTrX/gqnFS7bnpmJG6bCFjn2MY1FQF9lbp nZzG74zqdfRfD/sQx3MVXjZH2HnrWO3YvbJ+dGcv74RKTA3hPBhJ6fuhMTYSmmEBps2Zy4IiDWh w/FMizCrsdg== X-Google-Smtp-Source: AGHT+IEUtOzMV1bG2JwZSTOHgBKTjSc41VFkkFrYxUO1OVivUbK51FX1GU04iUcwyeOJAmPPIX6IQ3hAhOp/ X-Received: from pjbok5.prod.google.com ([2002:a17:90b:1d45:b0:330:49f5:c0a7]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1b49:b0:335:2d4:8b3d with SMTP id 98e67ed59e1d1-339c27bda3emr11728223a91.31.1759688723931; Sun, 05 Oct 2025 11:25:23 -0700 (PDT) Date: Sun, 5 Oct 2025 11:24:26 -0700 In-Reply-To: <20251005182430.2791371-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251005182430.2791371-1-irogers@google.com> X-Mailer: git-send-email 2.51.0.618.g983fd99d29-goog Message-ID: <20251005182430.2791371-24-irogers@google.com> Subject: [PATCH v7 23/27] perf test parse-events: Remove cpu PMU requirement From: Ian Rogers To: James Clark , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Xu Yang , Thomas Falcon , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Atish Patra , Beeman Strong , Leo Yan , Vince Weaver Cc: Ian Rogers Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the event parse string, switch "cpu" to "default_core" and then rewrite this to the first core PMU name prior to parsing. This enables testing with a PMU on hybrid x86 and other systems that don't use "cpu" for the core PMU name. The name "default_core" is already used by jevents. Update test expectations to match. Signed-off-by: Ian Rogers --- tools/perf/tests/parse-events.c | 230 +++++++++++++++----------------- 1 file changed, 110 insertions(+), 120 deletions(-) diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-event= s.c index 23f3e265e2a1..5dd2f03e952d 100644 --- a/tools/perf/tests/parse-events.c +++ b/tools/perf/tests/parse-events.c @@ -20,17 +20,24 @@ #define PERF_TP_SAMPLE_TYPE (PERF_SAMPLE_RAW | PERF_SAMPLE_TIME | \ PERF_SAMPLE_CPU | PERF_SAMPLE_PERIOD) =20 -static int num_core_entries(void) +static int num_core_entries(struct evlist *evlist) { /* - * If the kernel supports extended type, expect events to be - * opened once for each core PMU type. Otherwise fall back to the legacy - * behavior of opening only one event even though there are multiple - * PMUs + * Returns number of core PMUs if the evlist has >1 core PMU, otherwise + * returns 1. The number of core PMUs is needed as wild carding can + * open an event for each core PMU. If the events were opened with a + * specified PMU then wild carding won't happen. */ - if (perf_pmus__supports_extended_type()) - return perf_pmus__num_core_pmus(); + struct perf_pmu *core_pmu =3D NULL; + struct evsel *evsel; =20 + evlist__for_each_entry(evlist, evsel) { + if (!evsel->pmu->is_core) + continue; + if (core_pmu !=3D evsel->pmu && core_pmu !=3D NULL) + return perf_pmus__num_core_pmus(); + core_pmu =3D evsel->pmu; + } return 1; } =20 @@ -345,7 +352,7 @@ static int test__checkevent_symbolic_name_modifier(stru= ct evlist *evlist) struct perf_evsel *evsel; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D num_core_entries()); + evlist->core.nr_entries =3D=3D num_core_entries(evlist)); =20 perf_evlist__for_each_entry(&evlist->core, evsel) { TEST_ASSERT_VAL("wrong exclude_user", evsel->attr.exclude_user); @@ -648,19 +655,21 @@ static int test__checkevent_pmu_name(struct evlist *e= vlist) { struct evsel *evsel =3D evlist__first(evlist); struct perf_pmu *core_pmu =3D perf_pmus__find_core_pmu(); + char buf[256]; =20 - /* cpu/config=3D1,name=3Dkrava/u */ + /* default_core/config=3D1,name=3Dkrava/u */ TEST_ASSERT_VAL("wrong number of entries", 2 =3D=3D evlist->core.nr_entri= es); TEST_ASSERT_VAL("wrong type", core_pmu->type =3D=3D evsel->core.attr.type= ); TEST_ASSERT_VAL("wrong config", 1 =3D=3D evsel->core.attr.config); TEST_ASSERT_VAL("wrong name", evsel__name_is(evsel, "krava")); =20 - /* cpu/config=3D2/u" */ + /* default_core/config=3D2/u" */ evsel =3D evsel__next(evsel); TEST_ASSERT_VAL("wrong number of entries", 2 =3D=3D evlist->core.nr_entri= es); TEST_ASSERT_VAL("wrong type", core_pmu->type =3D=3D evsel->core.attr.type= ); TEST_ASSERT_VAL("wrong config", 2 =3D=3D evsel->core.attr.config); - TEST_ASSERT_VAL("wrong name", evsel__name_is(evsel, "cpu/config=3D2/u")); + snprintf(buf, sizeof(buf), "%s/config=3D2/u", core_pmu->name); + TEST_ASSERT_VAL("wrong name", evsel__name_is(evsel, buf)); =20 return TEST_OK; } @@ -670,7 +679,7 @@ static int test__checkevent_pmu_partial_time_callgraph(= struct evlist *evlist) struct evsel *evsel =3D evlist__first(evlist); struct perf_pmu *core_pmu =3D perf_pmus__find_core_pmu(); =20 - /* cpu/config=3D1,call-graph=3Dfp,time,period=3D100000/ */ + /* default_core/config=3D1,call-graph=3Dfp,time,period=3D100000/ */ TEST_ASSERT_VAL("wrong number of entries", 2 =3D=3D evlist->core.nr_entri= es); TEST_ASSERT_VAL("wrong type", core_pmu->type =3D=3D evsel->core.attr.type= ); TEST_ASSERT_VAL("wrong config", 1 =3D=3D evsel->core.attr.config); @@ -682,7 +691,7 @@ static int test__checkevent_pmu_partial_time_callgraph(= struct evlist *evlist) TEST_ASSERT_VAL("wrong callgraph", !evsel__has_callchain(evsel)); TEST_ASSERT_VAL("wrong time", !(PERF_SAMPLE_TIME & evsel->core.attr.samp= le_type)); =20 - /* cpu/config=3D2,call-graph=3Dno,time=3D0,period=3D2000/ */ + /* default_core/config=3D2,call-graph=3Dno,time=3D0,period=3D2000/ */ evsel =3D evsel__next(evsel); TEST_ASSERT_VAL("wrong type", core_pmu->type =3D=3D evsel->core.attr.type= ); TEST_ASSERT_VAL("wrong config", 2 =3D=3D evsel->core.attr.config); @@ -740,7 +749,7 @@ static int test__checkevent_pmu_events_mix(struct evlis= t *evlist) TEST_ASSERT_VAL("wrong pinned", !evsel->core.attr.pinned); TEST_ASSERT_VAL("wrong exclusive", !evsel->core.attr.exclusive); } - /* cpu/pmu-event/u*/ + /* default_core/pmu-event/u*/ evsel =3D evsel__next(evsel); TEST_ASSERT_VAL("wrong type", evsel__find_pmu(evsel)->is_core); TEST_ASSERT_VAL("wrong exclude_user", @@ -840,11 +849,11 @@ static int test__group1(struct evlist *evlist) struct evsel *evsel =3D NULL, *leader; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D (num_core_entries() * 2)); + evlist->core.nr_entries =3D=3D (num_core_entries(evlist) * 2)); TEST_ASSERT_VAL("wrong number of groups", - evlist__nr_groups(evlist) =3D=3D num_core_entries()); + evlist__nr_groups(evlist) =3D=3D num_core_entries(evlist)); =20 - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { /* instructions:k */ evsel =3D leader =3D (i =3D=3D 0 ? evlist__first(evlist) : evsel__next(e= vsel)); TEST_ASSERT_VAL("unexpected event", evsel__match(evsel, HARDWARE, HW_INS= TRUCTIONS)); @@ -880,7 +889,7 @@ static int test__group2(struct evlist *evlist) struct evsel *evsel, *leader =3D NULL; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D (2 * num_core_entries() + 1)); + evlist->core.nr_entries =3D=3D (2 * num_core_entries(evlist) + 1)); /* * TODO: Currently the software event won't be grouped with the hardware * event except for 1 PMU. @@ -1037,11 +1046,11 @@ static int test__group4(struct evlist *evlist __may= be_unused) struct evsel *evsel =3D NULL, *leader; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D (num_core_entries() * 2)); + evlist->core.nr_entries =3D=3D (num_core_entries(evlist) * 2)); TEST_ASSERT_VAL("wrong number of groups", - num_core_entries() =3D=3D evlist__nr_groups(evlist)); + num_core_entries(evlist) =3D=3D evlist__nr_groups(evlist)); =20 - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { /* cycles:u + p */ evsel =3D leader =3D (i =3D=3D 0 ? evlist__first(evlist) : evsel__next(e= vsel)); TEST_ASSERT_VAL("unexpected event", evsel__match(evsel, HARDWARE, HW_CPU= _CYCLES)); @@ -1078,11 +1087,11 @@ static int test__group5(struct evlist *evlist __may= be_unused) struct evsel *evsel =3D NULL, *leader; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D (5 * num_core_entries())); + evlist->core.nr_entries =3D=3D (5 * num_core_entries(evlist))); TEST_ASSERT_VAL("wrong number of groups", - evlist__nr_groups(evlist) =3D=3D (2 * num_core_entries())); + evlist__nr_groups(evlist) =3D=3D (2 * num_core_entries(evlist))); =20 - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { /* cycles + G */ evsel =3D leader =3D (i =3D=3D 0 ? evlist__first(evlist) : evsel__next(e= vsel)); TEST_ASSERT_VAL("unexpected event", evsel__match(evsel, HARDWARE, HW_CPU= _CYCLES)); @@ -1111,7 +1120,7 @@ static int test__group5(struct evlist *evlist __maybe= _unused) TEST_ASSERT_VAL("wrong group_idx", evsel__group_idx(evsel) =3D=3D 1); TEST_ASSERT_VAL("wrong sample_read", !evsel->sample_read); } - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { /* cycles:G */ evsel =3D leader =3D evsel__next(evsel); TEST_ASSERT_VAL("unexpected event", evsel__match(evsel, HARDWARE, HW_CPU= _CYCLES)); @@ -1139,7 +1148,7 @@ static int test__group5(struct evlist *evlist __maybe= _unused) TEST_ASSERT_VAL("wrong leader", evsel__has_leader(evsel, leader)); TEST_ASSERT_VAL("wrong group_idx", evsel__group_idx(evsel) =3D=3D 1); } - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { /* cycles */ evsel =3D evsel__next(evsel); TEST_ASSERT_VAL("unexpected event", evsel__match(evsel, HARDWARE, HW_CPU= _CYCLES)); @@ -1159,11 +1168,11 @@ static int test__group_gh1(struct evlist *evlist) struct evsel *evsel =3D NULL, *leader; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D (2 * num_core_entries())); + evlist->core.nr_entries =3D=3D (2 * num_core_entries(evlist))); TEST_ASSERT_VAL("wrong number of groups", - evlist__nr_groups(evlist) =3D=3D num_core_entries()); + evlist__nr_groups(evlist) =3D=3D num_core_entries(evlist)); =20 - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { /* cycles + :H group modifier */ evsel =3D leader =3D (i =3D=3D 0 ? evlist__first(evlist) : evsel__next(e= vsel)); TEST_ASSERT_VAL("unexpected event", evsel__match(evsel, HARDWARE, HW_CPU= _CYCLES)); @@ -1198,11 +1207,11 @@ static int test__group_gh2(struct evlist *evlist) struct evsel *evsel =3D NULL, *leader; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D (2 * num_core_entries())); + evlist->core.nr_entries =3D=3D (2 * num_core_entries(evlist))); TEST_ASSERT_VAL("wrong number of groups", - evlist__nr_groups(evlist) =3D=3D num_core_entries()); + evlist__nr_groups(evlist) =3D=3D num_core_entries(evlist)); =20 - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { /* cycles + :G group modifier */ evsel =3D leader =3D (i =3D=3D 0 ? evlist__first(evlist) : evsel__next(e= vsel)); TEST_ASSERT_VAL("unexpected event", evsel__match(evsel, HARDWARE, HW_CPU= _CYCLES)); @@ -1237,11 +1246,11 @@ static int test__group_gh3(struct evlist *evlist) struct evsel *evsel =3D NULL, *leader; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D (2 * num_core_entries())); + evlist->core.nr_entries =3D=3D (2 * num_core_entries(evlist))); TEST_ASSERT_VAL("wrong number of groups", - evlist__nr_groups(evlist) =3D=3D num_core_entries()); + evlist__nr_groups(evlist) =3D=3D num_core_entries(evlist)); =20 - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { /* cycles:G + :u group modifier */ evsel =3D leader =3D (i =3D=3D 0 ? evlist__first(evlist) : evsel__next(e= vsel)); TEST_ASSERT_VAL("unexpected event", evsel__match(evsel, HARDWARE, HW_CPU= _CYCLES)); @@ -1276,11 +1285,11 @@ static int test__group_gh4(struct evlist *evlist) struct evsel *evsel =3D NULL, *leader; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D (2 * num_core_entries())); + evlist->core.nr_entries =3D=3D (2 * num_core_entries(evlist))); TEST_ASSERT_VAL("wrong number of groups", - evlist__nr_groups(evlist) =3D=3D num_core_entries()); + evlist__nr_groups(evlist) =3D=3D num_core_entries(evlist)); =20 - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { /* cycles:G + :uG group modifier */ evsel =3D leader =3D (i =3D=3D 0 ? evlist__first(evlist) : evsel__next(e= vsel)); TEST_ASSERT_VAL("unexpected event", evsel__match(evsel, HARDWARE, HW_CPU= _CYCLES)); @@ -1315,9 +1324,9 @@ static int test__leader_sample1(struct evlist *evlist) struct evsel *evsel =3D NULL, *leader; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D (3 * num_core_entries())); + evlist->core.nr_entries =3D=3D (3 * num_core_entries(evlist))); =20 - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { /* cycles - sampling group leader */ evsel =3D leader =3D (i =3D=3D 0 ? evlist__first(evlist) : evsel__next(e= vsel)); TEST_ASSERT_VAL("unexpected event", evsel__match(evsel, HARDWARE, HW_CPU= _CYCLES)); @@ -1365,9 +1374,9 @@ static int test__leader_sample2(struct evlist *evlist= __maybe_unused) struct evsel *evsel =3D NULL, *leader; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D (2 * num_core_entries())); + evlist->core.nr_entries =3D=3D (2 * num_core_entries(evlist))); =20 - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { /* instructions - sampling group leader */ evsel =3D leader =3D (i =3D=3D 0 ? evlist__first(evlist) : evsel__next(e= vsel)); TEST_ASSERT_VAL("unexpected event", evsel__match(evsel, HARDWARE, HW_INS= TRUCTIONS)); @@ -1403,9 +1412,9 @@ static int test__checkevent_pinned_modifier(struct ev= list *evlist) struct evsel *evsel =3D NULL; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D num_core_entries()); + evlist->core.nr_entries =3D=3D num_core_entries(evlist)); =20 - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { evsel =3D (i =3D=3D 0 ? evlist__first(evlist) : evsel__next(evsel)); TEST_ASSERT_VAL("wrong exclude_user", !evsel->core.attr.exclude_user); TEST_ASSERT_VAL("wrong exclude_kernel", evsel->core.attr.exclude_kernel); @@ -1421,9 +1430,9 @@ static int test__pinned_group(struct evlist *evlist) struct evsel *evsel =3D NULL, *leader; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D (3 * num_core_entries())); + evlist->core.nr_entries =3D=3D (3 * num_core_entries(evlist))); =20 - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { /* cycles - group leader */ evsel =3D leader =3D (i =3D=3D 0 ? evlist__first(evlist) : evsel__next(e= vsel)); TEST_ASSERT_VAL("unexpected event", evsel__match(evsel, HARDWARE, HW_CPU= _CYCLES)); @@ -1465,9 +1474,9 @@ static int test__exclusive_group(struct evlist *evlis= t) struct evsel *evsel =3D NULL, *leader; =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D 3 * num_core_entries()); + evlist->core.nr_entries =3D=3D 3 * num_core_entries(evlist)); =20 - for (int i =3D 0; i < num_core_entries(); i++) { + for (int i =3D 0; i < num_core_entries(evlist); i++) { /* cycles - group leader */ evsel =3D leader =3D (i =3D=3D 0 ? evlist__first(evlist) : evsel__next(e= vsel)); TEST_ASSERT_VAL("unexpected event", evsel__match(evsel, HARDWARE, HW_CPU= _CYCLES)); @@ -1538,7 +1547,7 @@ static int test__checkevent_precise_max_modifier(stru= ct evlist *evlist) struct evsel *evsel =3D evlist__first(evlist); =20 TEST_ASSERT_VAL("wrong number of entries", - evlist->core.nr_entries =3D=3D 1 + num_core_entries()); + evlist->core.nr_entries =3D=3D 1 + num_core_entries(evlist)); TEST_ASSERT_VAL("wrong type/config", evsel__match(evsel, SOFTWARE, SW_TAS= K_CLOCK)); return TEST_OK; } @@ -1575,14 +1584,9 @@ static int test__checkevent_config_cache(struct evli= st *evlist) return test__checkevent_genhw(evlist); } =20 -static bool test__pmu_cpu_valid(void) +static bool test__pmu_default_core_event_valid(void) { - return !!perf_pmus__find("cpu"); -} - -static bool test__pmu_cpu_event_valid(void) -{ - struct perf_pmu *pmu =3D perf_pmus__find("cpu"); + struct perf_pmu *pmu =3D perf_pmus__find_core_pmu(); =20 if (!pmu) return false; @@ -2161,26 +2165,23 @@ static const struct evlist_test test__events[] =3D { =20 static const struct evlist_test test__events_pmu[] =3D { { - .name =3D "cpu/config=3D10,config1=3D1,config2=3D3,period=3D1000/u", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/config=3D10,config1=3D1,config2=3D3,period=3D10= 00/u", .check =3D test__checkevent_pmu, /* 0 */ }, { - .name =3D "cpu/config=3D1,name=3Dkrava/u,cpu/config=3D2/u", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/config=3D1,name=3Dkrava/u,default_core/config= =3D2/u", .check =3D test__checkevent_pmu_name, /* 1 */ }, { - .name =3D "cpu/config=3D1,call-graph=3Dfp,time,period=3D100000/,cpu/con= fig=3D2,call-graph=3Dno,time=3D0,period=3D2000/", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/config=3D1,call-graph=3Dfp,time,period=3D100000= /,default_core/config=3D2,call-graph=3Dno,time=3D0,period=3D2000/", .check =3D test__checkevent_pmu_partial_time_callgraph, /* 2 */ }, { - .name =3D "cpu/name=3D'COMPLEX_CYCLES_NAME:orig=3Dcpu-cycles,desc=3Dchi= p-clock-ticks',period=3D0x1,event=3D0x2/ukp", - .valid =3D test__pmu_cpu_event_valid, + .name =3D "default_core/name=3D'COMPLEX_CYCLES_NAME:orig=3Dcpu-cycles,d= esc=3Dchip-clock-ticks',period=3D0x1,event=3D0x2/ukp", + .valid =3D test__pmu_default_core_event_valid, .check =3D test__checkevent_complex_name, /* 3 */ }, @@ -2195,158 +2196,132 @@ static const struct evlist_test test__events_pmu[= ] =3D { /* 5 */ }, { - .name =3D "cpu/L1-dcache-load-miss/", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/L1-dcache-load-miss/", .check =3D test__checkevent_genhw, /* 6 */ }, { - .name =3D "cpu/L1-dcache-load-miss/kp", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/L1-dcache-load-miss/kp", .check =3D test__checkevent_genhw_modifier, /* 7 */ }, { - .name =3D "cpu/L1-dcache-misses,name=3Dcachepmu/", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/L1-dcache-misses,name=3Dcachepmu/", .check =3D test__checkevent_config_cache, /* 8 */ }, { - .name =3D "cpu/instructions/", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/instructions/", .check =3D test__checkevent_symbolic_name, /* 9 */ }, { - .name =3D "cpu/cycles,period=3D100000,config2/", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/cycles,period=3D100000,config2/", .check =3D test__checkevent_symbolic_name_config, /* 0 */ }, { - .name =3D "cpu/instructions/h", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/instructions/h", .check =3D test__checkevent_symbolic_name_modifier, /* 1 */ }, { - .name =3D "cpu/instructions/G", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/instructions/G", .check =3D test__checkevent_exclude_host_modifier, /* 2 */ }, { - .name =3D "cpu/instructions/H", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/instructions/H", .check =3D test__checkevent_exclude_guest_modifier, /* 3 */ }, { - .name =3D "{cpu/instructions/k,cpu/cycles/upp}", - .valid =3D test__pmu_cpu_valid, + .name =3D "{default_core/instructions/k,default_core/cycles/upp}", .check =3D test__group1, /* 4 */ }, { - .name =3D "{cpu/cycles/u,cpu/instructions/kp}:p", - .valid =3D test__pmu_cpu_valid, + .name =3D "{default_core/cycles/u,default_core/instructions/kp}:p", .check =3D test__group4, /* 5 */ }, { - .name =3D "{cpu/cycles/,cpu/cache-misses/G}:H", - .valid =3D test__pmu_cpu_valid, + .name =3D "{default_core/cycles/,default_core/cache-misses/G}:H", .check =3D test__group_gh1, /* 6 */ }, { - .name =3D "{cpu/cycles/,cpu/cache-misses/H}:G", - .valid =3D test__pmu_cpu_valid, + .name =3D "{default_core/cycles/,default_core/cache-misses/H}:G", .check =3D test__group_gh2, /* 7 */ }, { - .name =3D "{cpu/cycles/G,cpu/cache-misses/H}:u", - .valid =3D test__pmu_cpu_valid, + .name =3D "{default_core/cycles/G,default_core/cache-misses/H}:u", .check =3D test__group_gh3, /* 8 */ }, { - .name =3D "{cpu/cycles/G,cpu/cache-misses/H}:uG", - .valid =3D test__pmu_cpu_valid, + .name =3D "{default_core/cycles/G,default_core/cache-misses/H}:uG", .check =3D test__group_gh4, /* 9 */ }, { - .name =3D "{cpu/cycles/,cpu/cache-misses/,cpu/branch-misses/}:S", - .valid =3D test__pmu_cpu_valid, + .name =3D "{default_core/cycles/,default_core/cache-misses/,default_cor= e/branch-misses/}:S", .check =3D test__leader_sample1, /* 0 */ }, { - .name =3D "{cpu/instructions/,cpu/branch-misses/}:Su", - .valid =3D test__pmu_cpu_valid, + .name =3D "{default_core/instructions/,default_core/branch-misses/}:Su", .check =3D test__leader_sample2, /* 1 */ }, { - .name =3D "cpu/instructions/uDp", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/instructions/uDp", .check =3D test__checkevent_pinned_modifier, /* 2 */ }, { - .name =3D "{cpu/cycles/,cpu/cache-misses/,cpu/branch-misses/}:D", - .valid =3D test__pmu_cpu_valid, + .name =3D "{default_core/cycles/,default_core/cache-misses/,default_cor= e/branch-misses/}:D", .check =3D test__pinned_group, /* 3 */ }, { - .name =3D "cpu/instructions/I", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/instructions/I", .check =3D test__checkevent_exclude_idle_modifier, /* 4 */ }, { - .name =3D "cpu/instructions/kIG", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/instructions/kIG", .check =3D test__checkevent_exclude_idle_modifier_1, /* 5 */ }, { - .name =3D "cpu/cycles/u", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/cycles/u", .check =3D test__sym_event_slash, /* 6 */ }, { - .name =3D "cpu/cycles/k", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/cycles/k", .check =3D test__sym_event_dc, /* 7 */ }, { - .name =3D "cpu/instructions/uep", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/instructions/uep", .check =3D test__checkevent_exclusive_modifier, /* 8 */ }, { - .name =3D "{cpu/cycles/,cpu/cache-misses/,cpu/branch-misses/}:e", - .valid =3D test__pmu_cpu_valid, + .name =3D "{default_core/cycles/,default_core/cache-misses/,default_cor= e/branch-misses/}:e", .check =3D test__exclusive_group, /* 9 */ }, { - .name =3D "cpu/cycles,name=3Dname/", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/cycles,name=3Dname/", .check =3D test__term_equal_term, /* 0 */ }, { - .name =3D "cpu/cycles,name=3Dl1d/", - .valid =3D test__pmu_cpu_valid, + .name =3D "default_core/cycles,name=3Dl1d/", .check =3D test__term_equal_legacy, /* 1 */ }, @@ -2436,15 +2411,30 @@ static int combine_test_results(int existing, int l= atest) static int test_events(const struct evlist_test *events, int cnt) { int ret =3D TEST_OK; + struct perf_pmu *core_pmu =3D perf_pmus__find_core_pmu(); =20 for (int i =3D 0; i < cnt; i++) { - const struct evlist_test *e =3D &events[i]; + struct evlist_test e =3D events[i]; int test_ret; + const char *pos =3D e.name; + char buf[1024], *buf_pos =3D buf, *end; + + while ((end =3D strstr(pos, "default_core"))) { + size_t len =3D end - pos; + + strncpy(buf_pos, pos, len); + pos =3D end + 12; + buf_pos +=3D len; + strcpy(buf_pos, core_pmu->name); + buf_pos +=3D strlen(core_pmu->name); + } + strcpy(buf_pos, pos); =20 - pr_debug("running test %d '%s'\n", i, e->name); - test_ret =3D test_event(e); + e.name =3D buf; + pr_debug("running test %d '%s'\n", i, e.name); + test_ret =3D test_event(&e); if (test_ret !=3D TEST_OK) { - pr_debug("Event test failure: test %d '%s'", i, e->name); + pr_debug("Event test failure: test %d '%s'", i, e.name); ret =3D combine_test_results(ret, test_ret); } } --=20 2.51.0.618.g983fd99d29-goog