From nobody Wed Dec 17 19:17:01 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D7A81F936 for ; Sun, 5 Oct 2025 14:51:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759675910; cv=none; b=MfaZs8cV1T8ij/ChsbCQAmCEZNUAszk0eQ60FHKdXZvmR8NicG6TwNO8P77BWtxOrKpOqdzOVcyQnnfgOR6D96SUilI0MqLd868UxJwM9+88TDSMBVJrR7ueJaZFUnAandQFm6zAfsTi60V7gE1iosk52dElFbHil3FOryxgkW8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759675910; c=relaxed/simple; bh=sR+rFnluFtUzgZr7eCVi6YuN2uuLOaVxxTpLNJGEFrw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=ZZxmhK1YQmERgcP/sKNsknmtNfn87bIwIU7AkICUlj2M2CdU1C7mmjETfueNACbkWTCm4JcwoOHLcrZugqhyxnjzSfz9FPdOcWITw/3YdTxuiDneFqlSKhrh1mPX3BfJg/cgsxMrl/b+ziG7onewUvxiOQ07ZeIlQlHrVS1HjOs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dGwC4h63; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dGwC4h63" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759675908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=ZZOtTWQVxlJ4YcwEW6vJpq0v/jJHuqx77CpDcZgUiZE=; b=dGwC4h63ZVRBIxrG2qp2r5tThxzLBCJ3SwHqGUDB40heZlAUc03N5vIo/4cXsRHzNexADL knPDlDxNVujC+A1Eizphfn8miuRRbU/6kmA2G+QlCMqwQXPzQ5eppjHpT5OxP+nwjcrhK0 WjJOFNKm8nOWapruf5rgLusLAN1/vCc= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-7oP693EkMh2dU_tPBq7v2g-1; Sun, 05 Oct 2025 10:51:45 -0400 X-MC-Unique: 7oP693EkMh2dU_tPBq7v2g-1 X-Mimecast-MFC-AGG-ID: 7oP693EkMh2dU_tPBq7v2g_1759675903 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 980581800365; Sun, 5 Oct 2025 14:51:43 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.5]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 341903000198; Sun, 5 Oct 2025 14:51:38 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 5 Oct 2025 16:50:22 +0200 (CEST) Date: Sun, 5 Oct 2025 16:50:16 +0200 From: Oleg Nesterov To: Alexander Viro , Boqun Feng , David Howells , Ingo Molnar , Li RongQing , Linus Torvalds , Peter Zijlstra , Waiman Long , Will Deacon Cc: linux-kernel@vger.kernel.org Subject: [PATCH 1/5] seqlock: introduce SEQLOCK_READ_SECTION() Message-ID: <20251005145016.GA1254@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251005144929.GB1188@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The read_seqbegin/need_seqretry/done_seqretry API is cumbersome and error prone. With the new helper the "typical" code like nextseq =3D 0; do { seq =3D nextseq; flags =3D read_seqbegin_or_lock_irqsave(&seqlock, &seq); // read-side critical section nextseq =3D 1; } while (need_seqretry(&seqlock, seq)); done_seqretry_irqrestore(&seqlock, seq, flags); can be rewritten as SEQLOCK_READ_SECTION(&seqlock, &flags) { // read-side critical section } Signed-off-by: Oleg Nesterov --- include/linux/seqlock.h | 49 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h index 5ce48eab7a2a..8cd36a7c1638 100644 --- a/include/linux/seqlock.h +++ b/include/linux/seqlock.h @@ -1209,4 +1209,53 @@ done_seqretry_irqrestore(seqlock_t *lock, int seq, u= nsigned long flags) if (seq & 1) read_sequnlock_excl_irqrestore(lock, flags); } + +/* internal helper for SEQLOCK_READ_SECTION() */ +static inline int +seqlock_read_section_retry(seqlock_t *lock, int *seq, unsigned long *flags) +{ + int retry =3D 0; + + if (*seq & 1) { + if (flags) + read_sequnlock_excl_irqrestore(lock, *flags); + else + read_sequnlock_excl(lock); + } else if (read_seqretry(lock, *seq)) { + retry =3D *seq =3D 1; + if (flags) + read_seqlock_excl_irqsave(lock, *flags); + else + read_seqlock_excl(lock); + } + + return retry; +} + +#define __SEQLOCK_READ_SECTION(lock, lockless, seq, flags) \ + for (int lockless =3D 1, seq =3D read_seqbegin(lock); \ + lockless || seqlock_read_section_retry(lock, &seq, flags); \ + lockless =3D 0) + +/** + * SEQLOCK_READ_SECTION(lock, flags) - execute the read side critical sect= ion + * without manual sequence counter han= dling + * or calls to other helpers + * @lock: pointer to the seqlock_t protecting the data + * @flags: pointer to unsigned long for irqsave/irqrestore or NULL + * + * Example: + * + * SEQLOCK_READ_SECTION(&lock, &flags) { + * // read-side critical section + * } + * + * Starts with a lockless pass first. If it fails, restarts the critical s= ection + * with the lock held and, if @flags !=3D NULL, with irqs disabled. + * + * The critical section must not contain control flow that escapes the loo= p. + */ +#define SEQLOCK_READ_SECTION(lock, flags) \ + __SEQLOCK_READ_SECTION(lock, __UNIQUE_ID(lockless), __UNIQUE_ID(seq), fla= gs) + #endif /* __LINUX_SEQLOCK_H */ --=20 2.25.1.362.g51ebf55 From nobody Wed Dec 17 19:17:01 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B3601F936 for ; Sun, 5 Oct 2025 14:51:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759675919; cv=none; b=Lgz4LVTlJfGQPltco39verIwAIrdbUSmElq1+B7A0H0Y3M22UJcbk1QY8IMEDKdGHxyveeRbC9mHecjv0Ai9TT1CSlYEGH9PbmKfKFSUiaSbCe4DF6i4Z+NH4zAafcODcEQQJL3K1ZkP4/nzd2jpK/fT0V+uRvxgvqhreThpCxc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759675919; c=relaxed/simple; bh=SBpUcw9njwCcXX018ZZksLmhnkQo+yFEcYoPoFxZg1c=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=WCb1iaj+Iux3aEHhQlLyyYPdvt1dxollUsBZaP3ufbYVMVhCVTavGKQBQjdtmHpu/Hv50O2PAwFtyGgRWf/unVTML0oFVJ9A/xfPEgxfgSiUG+DoxbFKiPq8lq5d4WQf2Lsw6ZJzv7+xI58H/+cionEucppzZpjvbqV58ojMuXE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=X0/cVPQX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X0/cVPQX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759675917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=d+nrIpiBElTNAUocY+50+3qKyPURcrFXkHy9MYXyToo=; b=X0/cVPQXObp0wLOguWalSuTMaaDeKv7s8Pi5iVqTR+NYLSmYRYmY/9zex/uUXTo2Ht6A1h t8fY1bBQ1MZwgUZfa371ycRKa82cj5r1ZSKJnNTKBG8WGlgVVDgwlS4LzK1CGYi2Z1Z5B8 bRPgiJIJnvkx3fRGU6q4pP8dsEfG3tE= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-m5vRQLcSOqWiyR-LqQBr8w-1; Sun, 05 Oct 2025 10:51:51 -0400 X-MC-Unique: m5vRQLcSOqWiyR-LqQBr8w-1 X-Mimecast-MFC-AGG-ID: m5vRQLcSOqWiyR-LqQBr8w_1759675910 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D3C6318004D4; Sun, 5 Oct 2025 14:51:49 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id C40E61956056; Sun, 5 Oct 2025 14:51:45 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 5 Oct 2025 16:50:28 +0200 (CEST) Date: Sun, 5 Oct 2025 16:50:23 +0200 From: Oleg Nesterov To: Alexander Viro , Boqun Feng , David Howells , Ingo Molnar , Li RongQing , Linus Torvalds , Peter Zijlstra , Waiman Long , Will Deacon Cc: linux-kernel@vger.kernel.org Subject: [PATCH 2/5] seqlock: change thread_group_cputime() to use SEQLOCK_READ_SECTION() Message-ID: <20251005145023.GA1257@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251005144929.GB1188@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To simplify the code and make it more readable. While at it, change thread_group_cputime() to use __for_each_thread(sig). Signed-off-by: Oleg Nesterov --- kernel/sched/cputime.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c index 7097de2c8cda..2d691075b6d6 100644 --- a/kernel/sched/cputime.c +++ b/kernel/sched/cputime.c @@ -315,7 +315,6 @@ void thread_group_cputime(struct task_struct *tsk, stru= ct task_cputime *times) struct signal_struct *sig =3D tsk->signal; u64 utime, stime; struct task_struct *t; - unsigned int seq, nextseq; unsigned long flags; =20 /* @@ -330,25 +329,18 @@ void thread_group_cputime(struct task_struct *tsk, st= ruct task_cputime *times) (void) task_sched_runtime(current); =20 rcu_read_lock(); - /* Attempt a lockless read on the first round. */ - nextseq =3D 0; - do { - seq =3D nextseq; - flags =3D read_seqbegin_or_lock_irqsave(&sig->stats_lock, &seq); + SEQLOCK_READ_SECTION(&sig->stats_lock, &flags) { times->utime =3D sig->utime; times->stime =3D sig->stime; times->sum_exec_runtime =3D sig->sum_sched_runtime; =20 - for_each_thread(tsk, t) { + __for_each_thread(sig, t) { task_cputime(t, &utime, &stime); times->utime +=3D utime; times->stime +=3D stime; times->sum_exec_runtime +=3D read_sum_exec_runtime(t); } - /* If lockless access failed, take the lock. */ - nextseq =3D 1; - } while (need_seqretry(&sig->stats_lock, seq)); - done_seqretry_irqrestore(&sig->stats_lock, seq, flags); + } rcu_read_unlock(); } =20 --=20 2.25.1.362.g51ebf55 From nobody Wed Dec 17 19:17:01 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93D1228C00D for ; Sun, 5 Oct 2025 14:52:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759675923; cv=none; b=YkXVbOYwLRhxbr3QX+akuYsT3ddcpDdLXvC9Po3XQYnZyPd2ZtYQ2+ucnvsHt66rKCQZpB9zR1nAvwb/5z66xCsuZZGArmVAw+PqK+zIm0WlP0b/k1Ap8r+Z9GSIO/QUoORvNoY3VqvIWbDWej4Wijcn23rAy2v/kF0MmM3I7Fw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759675923; c=relaxed/simple; bh=buwnXEzaY/kB7xqjt5XcN5g7He6rfczFJlP2htMe0QQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=Gho5LACYt9g4Mi1FJgcAgc8gOV5hhkyu0Hd7ivsOuUZ8o8x3u8kwnurav1fDUOWh+vQ0gN8m0U4Na2Ttt+0FGqesifqwbUSaC3stoiM3+mo5TDeb8sH0NnLxHyJ81b2b8C8LDhHQMhAs8p4ysKcSSQy/wh1+VfIZiScAFMgloPE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JpnuQgIX; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JpnuQgIX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759675920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=zdv/QBAv/KWiiKvJ9bn4POQBwt628tnn7lG3kzkJLMg=; b=JpnuQgIX8ZgPoe96f+ODMJOVAXAyKlcC2EVrEhmbD8+OESoJgnsNz78S6TUnW8mbDPNrts 0hTJseZLuagCCtpGy53AxXw+/1RKOO9mCkC9EwSVHp/aZNOUCKOmm7DjlrAS6icXIbVkvF gz/KzW+SZD+FwL9FaWQoU6HjrQ34YPU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-147-_8Ayc0FPOyOyMbvZyTshBA-1; Sun, 05 Oct 2025 10:51:57 -0400 X-MC-Unique: _8Ayc0FPOyOyMbvZyTshBA-1 X-Mimecast-MFC-AGG-ID: _8Ayc0FPOyOyMbvZyTshBA_1759675916 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C4BF1195608B; Sun, 5 Oct 2025 14:51:55 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.5]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id D8EF81800447; Sun, 5 Oct 2025 14:51:51 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 5 Oct 2025 16:50:34 +0200 (CEST) Date: Sun, 5 Oct 2025 16:50:29 +0200 From: Oleg Nesterov To: Alexander Viro , Boqun Feng , David Howells , Ingo Molnar , Li RongQing , Linus Torvalds , Peter Zijlstra , Waiman Long , Will Deacon Cc: linux-kernel@vger.kernel.org Subject: [PATCH 3/5] seqlock: change do_task_stat() to use SEQLOCK_READ_SECTION() Message-ID: <20251005145029.GA1260@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251005144929.GB1188@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To simplify the code and make it more readable. Signed-off-by: Oleg Nesterov --- fs/proc/array.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/proc/array.c b/fs/proc/array.c index d6a0369caa93..99bcaa58a2bd 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c @@ -483,7 +483,6 @@ static int do_task_stat(struct seq_file *m, struct pid_= namespace *ns, unsigned long flags; int exit_code =3D task->exit_code; struct signal_struct *sig =3D task->signal; - unsigned int seq =3D 1; =20 state =3D *get_task_state(task); vsize =3D eip =3D esp =3D 0; @@ -540,10 +539,7 @@ static int do_task_stat(struct seq_file *m, struct pid= _namespace *ns, if (permitted && (!whole || num_threads < 2)) wchan =3D !task_is_running(task); =20 - do { - seq++; /* 2 on the 1st/lockless path, otherwise odd */ - flags =3D read_seqbegin_or_lock_irqsave(&sig->stats_lock, &seq); - + SEQLOCK_READ_SECTION(&sig->stats_lock, &flags) { cmin_flt =3D sig->cmin_flt; cmaj_flt =3D sig->cmaj_flt; cutime =3D sig->cutime; @@ -565,8 +561,7 @@ static int do_task_stat(struct seq_file *m, struct pid_= namespace *ns, } rcu_read_unlock(); } - } while (need_seqretry(&sig->stats_lock, seq)); - done_seqretry_irqrestore(&sig->stats_lock, seq, flags); + } =20 if (whole) { thread_group_cputime_adjusted(task, &utime, &stime); --=20 2.25.1.362.g51ebf55 From nobody Wed Dec 17 19:17:01 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FFC428BAAC for ; Sun, 5 Oct 2025 14:52:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759675929; cv=none; b=mW46qa2Y33Hkt43ieM63y0wwGbE8F5WoVL7Via1O33SCmIamq/FRnLeFQUNvSsDQ18tw6tgrkvJdXRfI+2UbuXHtIC/nkfXGrsD0nAajGh9Cxwk8fEeDcTayUmP2Sedl3yrRHLx4Rp+g8gn51Ubh9i0Z4cFk8ovOuMzIJYMXaZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759675929; c=relaxed/simple; bh=9UiiJgLfv8sTOHiIZgjN6sokKuWFef4zdJDK9xhs/bY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=msR8Idjz32fleWtdGin94YOTaGhYeC715joKgBMv60W8wENZiTFMEYZunH7IxM27nUga2eOC9SF8w6aE74tjgcL7r0oxEVijeo16xhpNX6viqmcae77AXw0cAwlcXBT/44D5HiJM74FU7sY1tUHt55ws3sBJb1lOa6KP0x6gb4k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VwCkOf9Q; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VwCkOf9Q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759675926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=ZSx5lQ4+7qrnZX1hvWPArhIGF76mwlIvFYhojlX36ik=; b=VwCkOf9QnaqerIXRzENwi+geNvnmvHhOihN/iZ/7R4l7H34KG4O0bqPv5MfH9KkQ2OqQAr lINgDryaPtaaAfmbxJugcEJCFizY+4nGeyBl14wIOtO7dLav/6op7kDjGjjCe6Wi1BZPCv tazElKQwNRszQ2bQ/KB1xR27FE5Z3Po= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-117-k9gnyN4YOhi3jiAyMQi3KQ-1; Sun, 05 Oct 2025 10:52:03 -0400 X-MC-Unique: k9gnyN4YOhi3jiAyMQi3KQ-1 X-Mimecast-MFC-AGG-ID: k9gnyN4YOhi3jiAyMQi3KQ_1759675922 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A4970195608B; Sun, 5 Oct 2025 14:52:01 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id E34F319560A2; Sun, 5 Oct 2025 14:51:57 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 5 Oct 2025 16:50:40 +0200 (CEST) Date: Sun, 5 Oct 2025 16:50:35 +0200 From: Oleg Nesterov To: Alexander Viro , Boqun Feng , David Howells , Ingo Molnar , Li RongQing , Linus Torvalds , Peter Zijlstra , Waiman Long , Will Deacon Cc: linux-kernel@vger.kernel.org Subject: [PATCH 4/5] seqlock: change do_io_accounting() to use SEQLOCK_READ_SECTION() Message-ID: <20251005145035.GA1263@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251005144929.GB1188@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To simplify the code and make it more readable. Signed-off-by: Oleg Nesterov --- fs/proc/base.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index 62d35631ba8c..7ec507efbb99 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -3041,20 +3041,15 @@ static int do_io_accounting(struct task_struct *tas= k, struct seq_file *m, int wh if (whole) { struct signal_struct *sig =3D task->signal; struct task_struct *t; - unsigned int seq =3D 1; unsigned long flags; =20 rcu_read_lock(); - do { - seq++; /* 2 on the 1st/lockless path, otherwise odd */ - flags =3D read_seqbegin_or_lock_irqsave(&sig->stats_lock, &seq); - + SEQLOCK_READ_SECTION(&sig->stats_lock, &flags) { acct =3D sig->ioac; __for_each_thread(sig, t) task_io_accounting_add(&acct, &t->ioac); =20 - } while (need_seqretry(&sig->stats_lock, seq)); - done_seqretry_irqrestore(&sig->stats_lock, seq, flags); + } rcu_read_unlock(); } else { acct =3D task->ioac; --=20 2.25.1.362.g51ebf55 From nobody Wed Dec 17 19:17:01 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A250928B4F0 for ; Sun, 5 Oct 2025 14:52:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759675935; cv=none; b=l3iwtzXNB2ILoTjFR3HlpoG6DooGLvZZjLzNFZKEvRGlRlyuND58XHwErwLhV7NJRcdfkLyBVJqEy6uBgyTZrM3Bk/BEPZIufb50lFcIBGmd6uZIK1AXYYrBvaI276T8ADm0nNPG7UEDg0yDDuG++XEtlKfc7Pg6/5iVGhaoFXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759675935; c=relaxed/simple; bh=eNMb/LOH8STtC2n7cxPseKu/VPrmpdGzSGzzVQe6kFo=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=pSpXQwGo85ggVRBoA93SvVrOOYueRzJKyj0cu22tQE4IRgqrXJHg3Il44PTFkwxq8aLehLAO8OtwLX/aBgEU9oEFJ/l3/jhX5xgco2EcEEJafKI/Tz838iZksK/BfVW5F2JQnNcI32ug3gYni8wlD3n9gJQkT6JFOhCSKi3EUq8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZvLWnqb8; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZvLWnqb8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759675932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=ttN0gc8Al1vCK63h1373HhrrlY+8UEv8GvNSaU8FRRE=; b=ZvLWnqb8Ejml9yLFs6ryuyJcTQCru7eHnUPFzU82tmCxHVAd5W9XXrsRB0vQIAOUu12pCo 0Usc7FK3lIx7hPRh+r2HkXdktEQx/KW/Cb8leOi7XV+TUbo8jcmlTBlCMTI0igRADna2Bf Fc9RVjVkOr+Gi6KcvzGWLalZfYJaZus= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-311-t5Jw6-0hPfKxeJPQOQC4Yw-1; Sun, 05 Oct 2025 10:52:09 -0400 X-MC-Unique: t5Jw6-0hPfKxeJPQOQC4Yw-1 X-Mimecast-MFC-AGG-ID: t5Jw6-0hPfKxeJPQOQC4Yw_1759675928 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E5B5B1956087; Sun, 5 Oct 2025 14:52:07 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 894EB1956056; Sun, 5 Oct 2025 14:52:03 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 5 Oct 2025 16:50:46 +0200 (CEST) Date: Sun, 5 Oct 2025 16:50:41 +0200 From: Oleg Nesterov To: Alexander Viro , Boqun Feng , David Howells , Ingo Molnar , Li RongQing , Linus Torvalds , Peter Zijlstra , Waiman Long , Will Deacon Cc: linux-kernel@vger.kernel.org Subject: [PATCH 5/5] seqlock: change __dentry_path() to use __SEQLOCK_READ_SECTION() Message-ID: <20251005145041.GA1266@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251005144929.GB1188@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To simplify the code and make it more readable. Signed-off-by: Oleg Nesterov --- fs/d_path.c | 31 +++++++++++++------------------ 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/fs/d_path.c b/fs/d_path.c index bb365511066b..0dab1ab1e78d 100644 --- a/fs/d_path.c +++ b/fs/d_path.c @@ -332,28 +332,23 @@ static char *__dentry_path(const struct dentry *d, st= ruct prepend_buffer *p) { const struct dentry *dentry; struct prepend_buffer b; - int seq =3D 0; =20 rcu_read_lock(); -restart: - dentry =3D d; - b =3D *p; - read_seqbegin_or_lock(&rename_lock, &seq); - while (!IS_ROOT(dentry)) { - const struct dentry *parent =3D dentry->d_parent; + __SEQLOCK_READ_SECTION(&rename_lock, lockless, seq, NULL) { + dentry =3D d; + b =3D *p; + while (!IS_ROOT(dentry)) { + const struct dentry *parent =3D dentry->d_parent; =20 - prefetch(parent); - if (!prepend_name(&b, &dentry->d_name)) - break; - dentry =3D parent; - } - if (!(seq & 1)) - rcu_read_unlock(); - if (need_seqretry(&rename_lock, seq)) { - seq =3D 1; - goto restart; + prefetch(parent); + if (!prepend_name(&b, &dentry->d_name)) + break; + dentry =3D parent; + } + if (lockless) + rcu_read_unlock(); } - done_seqretry(&rename_lock, seq); + if (b.len =3D=3D p->len) prepend_char(&b, '/'); return extract_string(&b); --=20 2.25.1.362.g51ebf55