From nobody Wed Dec 17 19:41:16 2025 Received: from delivery.antispam.mailspamprotection.com (delivery.antispam.mailspamprotection.com [185.56.87.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B59ED1C9DE5 for ; Sun, 5 Oct 2025 20:53:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=185.56.87.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759697634; cv=pass; b=r7LsfiDTF9ecq5WogJrTjs7MSxZRGWebrBcmMjallcVy4C6UAdaVZQF6vcXWNfakVBrZlbvaHgeA1bwR/zI9nVpJ21nvsn19k07/KsG5RopqDDlW/TDT4uSi58CT5QHDr5KBOADwYayBTVC0CAh1yzhaCKv9p/xZuOn1yqWwxzg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759697634; c=relaxed/simple; bh=DMujsWVb0XBsms7mI+BZ4jG8OwIgPWKdo+JBJu5h68M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KvbuT6OzxFMHgpgA7v2AA0bdxMGCIO79hW8ofbyBMYcHvfv0cV4ABml+VJzkMhvdL2j0GZ7pFQ4YFJFjp3oFPRbdxmoLrFVFWSew898GRt342Amq6Dxs/p/rXTS+0sJKaFMO3hWAiE7Hao+xf4X1nJs2kLNKA3tKw7dOME8+eJ4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valla.it; spf=pass smtp.mailfrom=valla.it; dkim=pass (1024-bit key) header.d=antispam.mailspamprotection.com header.i=@antispam.mailspamprotection.com header.b=ghoIGgWQ; dkim=pass (1024-bit key) header.d=valla.it header.i=@valla.it header.b=gunbTzzo; arc=pass smtp.client-ip=185.56.87.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valla.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valla.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=antispam.mailspamprotection.com header.i=@antispam.mailspamprotection.com header.b="ghoIGgWQ"; dkim=pass (1024-bit key) header.d=valla.it header.i=@valla.it header.b="gunbTzzo" ARC-Seal: i=1; cv=none; a=rsa-sha256; d=outgoing.instance-europe-west4-nf36.prod.antispam.mailspamprotection.com; s=arckey; t=1759697632; b=GkhTphA1bD7w+4GEGiPxiAr4n+M+rq/NGpoL+cXQ8reRwWrYvTaeZGV/jZzfif0PthigYLvy/0 Vr0bNZCNrdlMO4sN+/9CBXlAdnoY7Qyv4RGyRLufEUVEocIXNXVWmGahIUYvKQNY5mejCDlgaT rj2pZVhGuybgwgpbAfbRkpuK9DF3savo+dhmDafmYG+Xtru/7YmSBBSy+RS8p3zUc2UrjYNVNk K9tgxEHwBLBlBmTmkm1G3qn8/AJAbt4dcpz8TPx3PcjvgFdcHeO9ZYwGY5a+C5/6uZV/P1VVBO Cgh1sR8hpfETU44ytU+0i16e3mBul3NJwm8tTa6ODP/Apw==; ARC-Authentication-Results: i=1; outgoing.instance-europe-west4-nf36.prod.antispam.mailspamprotection.com; smtp.remote-ip=35.214.173.214; iprev=pass (214.173.214.35.bc.googleusercontent.com) smtp.remote-ip=35.214.173.214; auth=pass (LOGIN) smtp.auth=esm19.siteground.biz; dkim=pass header.d=valla.it header.s=default header.a=rsa-sha256; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=outgoing.instance-europe-west4-nf36.prod.antispam.mailspamprotection.com; s=arckey; t=1759697632; bh=DMujsWVb0XBsms7mI+BZ4jG8OwIgPWKdo+JBJu5h68M=; h=Cc:To:In-Reply-To:References:Message-ID:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:DKIM-Signature:DKIM-Signature; b=Gfm+Ooh1E3kbD0Ny7i5XPVHCTNlDOMvA56S6miCYYlofBCWXZpy48HF9y9PeXacfR8+kX60Xxi tfWAuCwOMQqnOZQ5djNNJ8gcCPN0+X7Nu6k0urlEL7yxRcjswzcoacfBVPrQgX+LtNxCZCU6S9 WKFXBLhUawHyCxui9ojKXz2N2ZGPAPwwlQadCI3kNdYceS4uETcl9jDAcExfRhx/X2XVV/pt4C Rz5BmZRGVC8RSsJIi8Qf5mirR+X/4TDXOX2WYuKPXQ/GXX7QmtfvL2liKDnRQML50N2KpMXsgA I5LOucFtX8e4kE/ABxKngeh2uZmsGiuM5aJyoXoMtLc9dw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=antispam.mailspamprotection.com; s=default; h=CFBL-Feedback-ID:CFBL-Address :Cc:To:Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject :Date:From:Reply-To:List-Unsubscribe; bh=ab/UoitdFlXPH53JKWWYVjj8RBffXVQrAXU9vps/ES0=; b=ghoIGgWQv83QBCGyxEzOzpBnPY yCbvhtAwLaviYISxuSwqIBwab2Ir4YIzzC867xzVrWX7eDoWcaYkaM6j8sISFNYHrn041GfPKcV/g hQVupPLRAzr07V3FfbZ7HKL/QvfiXTzSY8M0pMmJI+sDV9ISupiuwFTwWNgo3Et1uM+w=; Received: from 214.173.214.35.bc.googleusercontent.com ([35.214.173.214] helo=esm19.siteground.biz) by instance-europe-west4-nf36.prod.antispam.mailspamprotection.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1v5VF1-00000008Ii7-2rki for linux-kernel@vger.kernel.org; Sun, 05 Oct 2025 20:22:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=valla.it; s=default; h=Cc:To:Subject:Date:From:list-help:list-unsubscribe: list-subscribe:list-post:list-owner:list-archive; bh=ab/UoitdFlXPH53JKWWYVjj8RBffXVQrAXU9vps/ES0=; b=gunbTzzondc57kzWj29s1Tz4aA 5664+ptkekCB0xBm4HZX1kmnb6QTRDH8TXyQM+c11XmLKwHRuThhC+hJZRXkQnEGvgTMAHAioBRNb Sw0f3GZkfYkcXwLP1ljHKzd6qpo0u4Q1Ypzi0ue7Sgtzrc/G3tTH2aewTbV/uWy7PfFA=; Received: from [87.16.13.60] (port=64461 helo=fedora.fritz.box) by esm19.siteground.biz with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1v5VEu-000000001im-416r; Sun, 05 Oct 2025 20:21:53 +0000 From: Francesco Valla Date: Sun, 05 Oct 2025 22:21:34 +0200 Subject: [PATCH 1/3] drm/draw: add drm_draw_can_convert_from_xrgb8888 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251005-drm_draw_conv_check-v1-1-9c814d9362f6@valla.it> References: <20251005-drm_draw_conv_check-v1-0-9c814d9362f6@valla.it> In-Reply-To: <20251005-drm_draw_conv_check-v1-0-9c814d9362f6@valla.it> To: Jocelyn Falempe , Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Francesco Valla X-Mailer: b4 0.14.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - esm19.siteground.biz X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - valla.it X-Source: X-Source-Args: X-Source-Dir: X-SGantispam-id: 848ddd08561cc6884978eb8aaef64364 AntiSpam-DLS: false AntiSpam-DLSP: AntiSpam-DLSRS: AntiSpam-TS: 1.0 CFBL-Address: feedback@antispam.mailspamprotection.com; report=arf CFBL-Feedback-ID: 1v5VF1-00000008Ii7-2rki-feedback@antispam.mailspamprotection.com Authentication-Results: outgoing.instance-europe-west4-nf36.prod.antispam.mailspamprotection.com; iprev=pass (214.173.214.35.bc.googleusercontent.com) smtp.remote-ip=35.214.173.214; auth=pass (LOGIN) smtp.auth=esm19.siteground.biz; dkim=pass header.d=valla.it header.s=default header.a=rsa-sha256; arc=none Add drm_draw_can_convert_from_xrgb8888() function that can be used to determine if a XRGB8888 color can be converted to the specified format. Signed-off-by: Francesco Valla --- drivers/gpu/drm/drm_draw.c | 84 +++++++++++++++++++++++++++------= ---- drivers/gpu/drm/drm_draw_internal.h | 2 + 2 files changed, 63 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/drm_draw.c b/drivers/gpu/drm/drm_draw.c index 9dc0408fbbeadbe8282a2d6b210e0bfb0672967f..2641026a103d3b28cab9f5d3786= 04b0604520fe4 100644 --- a/drivers/gpu/drm/drm_draw.c +++ b/drivers/gpu/drm/drm_draw.c @@ -15,45 +15,83 @@ #include "drm_draw_internal.h" #include "drm_format_internal.h" =20 -/** - * drm_draw_color_from_xrgb8888 - convert one pixel from xrgb8888 to the d= esired format - * @color: input color, in xrgb8888 format - * @format: output format - * - * Returns: - * Color in the format specified, casted to u32. - * Or 0 if the format is not supported. - */ -u32 drm_draw_color_from_xrgb8888(u32 color, u32 format) +static int __drm_draw_color_from_xrgb8888(u32 color, u32 format, u32 *out_= color) { switch (format) { case DRM_FORMAT_RGB565: - return drm_pixel_xrgb8888_to_rgb565(color); + *out_color =3D drm_pixel_xrgb8888_to_rgb565(color); + break; case DRM_FORMAT_RGBA5551: - return drm_pixel_xrgb8888_to_rgba5551(color); + *out_color =3D drm_pixel_xrgb8888_to_rgba5551(color); + break; case DRM_FORMAT_XRGB1555: - return drm_pixel_xrgb8888_to_xrgb1555(color); + *out_color =3D drm_pixel_xrgb8888_to_xrgb1555(color); + break; case DRM_FORMAT_ARGB1555: - return drm_pixel_xrgb8888_to_argb1555(color); + *out_color =3D drm_pixel_xrgb8888_to_argb1555(color); + break; case DRM_FORMAT_RGB888: + fallthrough; case DRM_FORMAT_XRGB8888: - return color; + *out_color =3D color; + break; case DRM_FORMAT_ARGB8888: - return drm_pixel_xrgb8888_to_argb8888(color); + *out_color =3D drm_pixel_xrgb8888_to_argb8888(color); + break; case DRM_FORMAT_XBGR8888: - return drm_pixel_xrgb8888_to_xbgr8888(color); + *out_color =3D drm_pixel_xrgb8888_to_xbgr8888(color); + break; case DRM_FORMAT_ABGR8888: - return drm_pixel_xrgb8888_to_abgr8888(color); + *out_color =3D drm_pixel_xrgb8888_to_abgr8888(color); + break; case DRM_FORMAT_XRGB2101010: - return drm_pixel_xrgb8888_to_xrgb2101010(color); + *out_color =3D drm_pixel_xrgb8888_to_xrgb2101010(color); + break; case DRM_FORMAT_ARGB2101010: - return drm_pixel_xrgb8888_to_argb2101010(color); + *out_color =3D drm_pixel_xrgb8888_to_argb2101010(color); + break; case DRM_FORMAT_ABGR2101010: - return drm_pixel_xrgb8888_to_abgr2101010(color); + *out_color =3D drm_pixel_xrgb8888_to_abgr2101010(color); + break; default: - WARN_ONCE(1, "Can't convert to %p4cc\n", &format); - return 0; + return -1; } + + return 0; +} + +/** + * drm_draw_can_convert_from_xrgb8888 - check if xrgb8888 can be converted= to the desired format + * @format: format + * + * Returns: + * True if XRGB8888 can be converted to the specified format, false otherw= ise. + */ +bool drm_draw_can_convert_from_xrgb8888(u32 format) +{ + u32 out_color; + + return __drm_draw_color_from_xrgb8888(0, format, &out_color) =3D=3D 0; +} +EXPORT_SYMBOL(drm_draw_can_convert_from_xrgb8888); + +/** + * drm_draw_color_from_xrgb8888 - convert one pixel from xrgb8888 to the d= esired format + * @color: input color, in xrgb8888 format + * @format: output format + * + * Returns: + * Color in the format specified, casted to u32. + * Or 0 if the format is not supported. + */ +u32 drm_draw_color_from_xrgb8888(u32 color, u32 format) +{ + u32 out_color =3D 0; + + if (__drm_draw_color_from_xrgb8888(color, format, &out_color)) + WARN_ONCE(1, "Can't convert to %p4cc\n", &format); + + return out_color; } EXPORT_SYMBOL(drm_draw_color_from_xrgb8888); =20 diff --git a/drivers/gpu/drm/drm_draw_internal.h b/drivers/gpu/drm/drm_draw= _internal.h index f121ee7339dc11537f677c833f0ee94fe0e799cd..2ab4cb341df94fc4173dd6f5e7a= 512bdcfa5e55c 100644 --- a/drivers/gpu/drm/drm_draw_internal.h +++ b/drivers/gpu/drm/drm_draw_internal.h @@ -24,6 +24,8 @@ static inline const u8 *drm_draw_get_char_bitmap(const st= ruct font_desc *font, return font->data + (c * font->height) * font_pitch; } =20 +bool drm_draw_can_convert_from_xrgb8888(u32 format); + u32 drm_draw_color_from_xrgb8888(u32 color, u32 format); =20 void drm_draw_blit16(struct iosys_map *dmap, unsigned int dpitch, --=20 2.51.0 From nobody Wed Dec 17 19:41:16 2025 Received: from delivery.antispam.mailspamprotection.com (delivery.antispam.mailspamprotection.com [185.56.87.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E91A7189F20 for ; Sun, 5 Oct 2025 20:53:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=185.56.87.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759697586; cv=pass; b=bC8C3CtAuaeMWweQQybW+/3iSbUJZdVtSzSTtMPsuTaedoU3r8UfbRPPZ+Wn0ryGwIX7D4z0qcpiYAsr5ODmvX52a+7ls21fNTYNxiRLaduHwcDzum+/ymQLdVbOgi750dAOP8QSxI19u2lxj4vjLmRCdd7CJwEItG7tXn+Vivs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759697586; c=relaxed/simple; bh=47IvIiXfgXszMY+cAV0lSu8Ko5qTBff2hny8UxJ0ZUw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QLfk2lc2uwBjA06WGfhx7RD7mP1rboDiJGAK3vnzf47y8b0/2t/iSvaJIaWP8XgeDXQQMDnPX1JoD4JVNM5bCKhPXXWpZvGUTdB/yiBXVD/HlDxhnWVTA6hyuotXj+quCL2XS8TV3rFHUokrdTIPlBpdRIKa4ni2N1onNIY0GiI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valla.it; spf=pass smtp.mailfrom=valla.it; dkim=pass (1024-bit key) header.d=antispam.mailspamprotection.com header.i=@antispam.mailspamprotection.com header.b=ySCY/pNn; dkim=pass (1024-bit key) header.d=valla.it header.i=@valla.it header.b=eIo8APPw; arc=pass smtp.client-ip=185.56.87.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valla.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valla.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=antispam.mailspamprotection.com header.i=@antispam.mailspamprotection.com header.b="ySCY/pNn"; dkim=pass (1024-bit key) header.d=valla.it header.i=@valla.it header.b="eIo8APPw" ARC-Seal: i=1; cv=none; a=rsa-sha256; d=outgoing.instance-europe-west4-nf36.prod.antispam.mailspamprotection.com; s=arckey; t=1759697584; b=q2ITUt+4JkKWLVDjgqoK6wmnp93aYm4hKy0GhthU3s8elb6UDI7750Ta2HqKt9F9928qPvD6Ep v134o6p6mkNC6hkh12oDi6Hlj4eZ7+rMiGq9Dt/JD94Jo0xOW/lHlXqtHeyr9rwSSVgQRI21bK LjJ/fv2rv6YqRXLYdptnEcoKZMWuDLpH5uFlXnt948n6qzL3VCCudarjx1Y7SpM1zAvi4xhQsQ phKHEfZeaYtoTeQiH2cogYto5qdPPI6SAoHAJ4zGAzl3unXZj9DM3Nadub2bN3vBWeCNFpf6Gv 9rjLlJQyiHokU2coW+zo3eJrRRiZc1eHZNUN1TpmW2qKGA==; ARC-Authentication-Results: i=1; outgoing.instance-europe-west4-nf36.prod.antispam.mailspamprotection.com; smtp.remote-ip=35.214.173.214; iprev=pass (214.173.214.35.bc.googleusercontent.com) smtp.remote-ip=35.214.173.214; auth=pass (LOGIN) smtp.auth=esm19.siteground.biz; dkim=pass header.d=valla.it header.s=default header.a=rsa-sha256; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=outgoing.instance-europe-west4-nf36.prod.antispam.mailspamprotection.com; s=arckey; t=1759697584; bh=47IvIiXfgXszMY+cAV0lSu8Ko5qTBff2hny8UxJ0ZUw=; h=Cc:To:In-Reply-To:References:Message-ID:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:DKIM-Signature:DKIM-Signature; b=mdcNHgU1wjFVKhbO6yTWryiOo8LK9EA5+Q3To7HX7gJsjt4R/njMT4UzBPiT9VN74DT4Y1rQNW 1KI2osHHIGO33pw/4YnlRL1ow9PRZIR4Vr8Y3UmTepSK+qAl2XrUKTSs2pFwOm6b9BPzDYMe1S dZPV9SpmA/g2i3yJTfiqJbPys/AuLZc8S81EZUIfXCYX2VEwDyEwmRD0IviV5NNB9Cz+iEUdcc mUgHPoKK6Bu21Hq/45TP5BzcgX3MgBC0yiCTgqkqFIKezEIvAHOa22ySTYIQzvGZu9D7JfX1N5 Sgb7wJBGRyfpwfLKBQgtnwCVkZuN6S2YuHdKe2pWU0BEDA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=antispam.mailspamprotection.com; s=default; h=CFBL-Feedback-ID:CFBL-Address :Cc:To:Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject :Date:From:Reply-To:List-Unsubscribe; bh=bXAG6V6q0Gu2P/Y5b57UaRwcg3Y2X9SQRXNhHXSl2EQ=; b=ySCY/pNntYuD3l1Ja41jOY3x/I tbzx+Rh6FmKgduSYPieTl2sjSmnQ6kNJSPDZ1XaH9sU2m2M7DgaJuZQUwDOeOJlheYyW1CTr/0mmq MhWZyk5+X19Ni1zxMyU5cbfn1Pe5WbDoZhW8gqBxl83nuYtLJOtuICunySZ6XrGZ8k10=; Received: from 214.173.214.35.bc.googleusercontent.com ([35.214.173.214] helo=esm19.siteground.biz) by instance-europe-west4-nf36.prod.antispam.mailspamprotection.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1v5VF3-00000008Ijs-084U for linux-kernel@vger.kernel.org; Sun, 05 Oct 2025 20:22:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=valla.it; s=default; h=Cc:To:Subject:Date:From:list-help:list-unsubscribe: list-subscribe:list-post:list-owner:list-archive; bh=bXAG6V6q0Gu2P/Y5b57UaRwcg3Y2X9SQRXNhHXSl2EQ=; b=eIo8APPwUd+a7hb0bvMXEmvfQn iQOBNyA6XEjTKlNNZS68j1e8HF9DZtPNjYe41LAnF3CTzli4Nu4XX9oYfy+d2CINvDWeou26PxawU eTMnX6ev6uGoZ6KyJUIG8AOJQ48qQPs+nuAG8eGOuMB8lp5c1s0y0JxGO6wcJOsEvatA=; Received: from [87.16.13.60] (port=64461 helo=fedora.fritz.box) by esm19.siteground.biz with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1v5VEv-000000001im-3olJ; Sun, 05 Oct 2025 20:21:53 +0000 From: Francesco Valla Date: Sun, 05 Oct 2025 22:21:35 +0200 Subject: [PATCH 2/3] drm/log: avoid WARN when searching for usable format Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251005-drm_draw_conv_check-v1-2-9c814d9362f6@valla.it> References: <20251005-drm_draw_conv_check-v1-0-9c814d9362f6@valla.it> In-Reply-To: <20251005-drm_draw_conv_check-v1-0-9c814d9362f6@valla.it> To: Jocelyn Falempe , Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Francesco Valla X-Mailer: b4 0.14.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - esm19.siteground.biz X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - valla.it X-Source: X-Source-Args: X-Source-Dir: X-SGantispam-id: c60f707575d8b7054020355cf62fab3d AntiSpam-DLS: false AntiSpam-DLSP: AntiSpam-DLSRS: AntiSpam-TS: 1.0 CFBL-Address: feedback@antispam.mailspamprotection.com; report=arf CFBL-Feedback-ID: 1v5VF3-00000008Ijs-084U-feedback@antispam.mailspamprotection.com Authentication-Results: outgoing.instance-europe-west4-nf36.prod.antispam.mailspamprotection.com; iprev=pass (214.173.214.35.bc.googleusercontent.com) smtp.remote-ip=35.214.173.214; auth=pass (LOGIN) smtp.auth=esm19.siteground.biz; dkim=pass header.d=valla.it header.s=default header.a=rsa-sha256; arc=none Use drm_draw_can_convert_from_xrgb8888() instead of drm_draw_color_from_xrgb8888() while searching for a usable color format. This avoids a WARN in case the first format is not usable. Signed-off-by: Francesco Valla --- drivers/gpu/drm/clients/drm_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/clients/drm_log.c b/drivers/gpu/drm/clients/dr= m_log.c index d239f1e3c456397ad64007b20dde716f5d3d0881..c0150f0c3b4b395e6e2126cf0d9= 660c967c182ec 100644 --- a/drivers/gpu/drm/clients/drm_log.c +++ b/drivers/gpu/drm/clients/drm_log.c @@ -182,7 +182,7 @@ static u32 drm_log_find_usable_format(struct drm_plane = *plane) int i; =20 for (i =3D 0; i < plane->format_count; i++) - if (drm_draw_color_from_xrgb8888(0xffffff, plane->format_types[i]) !=3D = 0) + if (drm_draw_can_convert_from_xrgb8888(plane->format_types[i])) return plane->format_types[i]; return DRM_FORMAT_INVALID; } --=20 2.51.0 From nobody Wed Dec 17 19:41:16 2025 Received: from delivery.antispam.mailspamprotection.com (delivery.antispam.mailspamprotection.com [185.56.87.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19513257859 for ; Sun, 5 Oct 2025 20:53:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=185.56.87.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759697590; cv=pass; b=mmVr7BKfoYUvsjJACrEtpkmnUmMnqdgqRwhJKvwMUMtsgiKiCrtZ7Os46loRAoqvlWPivOsLAQXvCagVvgmhzXBXnnBZZTECW6O6uB9TtoqDVi21ZOoW4bZNBhvHIO0ESQbBCkFBDzvxzUIZxeLDw1neUZVf2IZ55SrJmoNr6FM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759697590; c=relaxed/simple; bh=DRH7iMOTbuY1/iWEix7sZhqd6n/2Tw1ybJZR6DrwRcU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GoTaWY5z/MgAQBut4ANDdZ62NECgkKYj1nkPV8WsLtMt12rKutHqINEWRN9/REIillnK3esahkZjDTiP+bppmFG02gJ/cRT8fAYxxDpkBaU5BNbdq+ohDY/7MMR21asCdE/yP1rL9Bcvq1meF/ELsAy0awXw2NlJoHFl8XRrPOw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valla.it; spf=pass smtp.mailfrom=valla.it; dkim=pass (1024-bit key) header.d=antispam.mailspamprotection.com header.i=@antispam.mailspamprotection.com header.b=I13tSTBV; dkim=pass (1024-bit key) header.d=valla.it header.i=@valla.it header.b=brOnScoF; arc=pass smtp.client-ip=185.56.87.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valla.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valla.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=antispam.mailspamprotection.com header.i=@antispam.mailspamprotection.com header.b="I13tSTBV"; dkim=pass (1024-bit key) header.d=valla.it header.i=@valla.it header.b="brOnScoF" ARC-Seal: i=1; cv=none; a=rsa-sha256; d=outgoing.instance-europe-west4-nf36.prod.antispam.mailspamprotection.com; s=arckey; t=1759697589; b=UnSJUkzmZ9x/s2ubVjhjvvoNklrtlo3DoRLWmMrGt1fvfGEbvEkRbBO4PysgGkwNcn1BTDl1bC HNtqfVQPHD80bkaZ+pmBXa6cid1uAP5dfPfOy88ao3G40zql0+oKsmPRDbJsolCRwLZHzos0RD kvWQpxn3ca74yorEQ35h9+Mb/CRYu8DfgSTyL2BYTGirBCKu1DtGbtjEoe/yPRwFt9fih4Dydi v19Q1uOj8TtKN7g20dsA6wpYYAQxfa3YYMdLpa4pwRsXcFy+gCiT+UmKnkn0vUmLhD+axs/1FT 4UM+H80pSp7M6G1ucrAcKjs0GC1NAdNRC2Vpdyvxztir1g==; ARC-Authentication-Results: i=1; outgoing.instance-europe-west4-nf36.prod.antispam.mailspamprotection.com; smtp.remote-ip=35.214.173.214; iprev=pass (214.173.214.35.bc.googleusercontent.com) smtp.remote-ip=35.214.173.214; auth=pass (LOGIN) smtp.auth=esm19.siteground.biz; dkim=pass header.d=valla.it header.s=default header.a=rsa-sha256; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=outgoing.instance-europe-west4-nf36.prod.antispam.mailspamprotection.com; s=arckey; t=1759697589; bh=DRH7iMOTbuY1/iWEix7sZhqd6n/2Tw1ybJZR6DrwRcU=; h=Cc:To:In-Reply-To:References:Message-ID:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:DKIM-Signature:DKIM-Signature; b=AlNO/adCv1ONCEHPkFaZc4xbQe+J7wGh5h/nkGYXpaaJm392otqD1ylC5wY7gzZacCf+CpoOqP qeDcwJGoz2D5OyCfG4TT8Aplp0ygYoxUJlAYWNDI3xWS7v+06EO/iK7yxtObBLLCg9StmvCY/+ Zqtoec5/Qpz2pcfUyG2Z9CbcJRrnw1A5j9ccN/LDsFRLIxao1q1evgVoXhgGFKUxJ2uIitMViq K4WhM4PmOwt4soi9tMy3c7VzYDpdb8aSKm3FM8Rt5iov5rRBCy4LyPY65gZRd8WeGlc6pC7Uxj VcbRgP3ShsfpfHxi4BeWSyiznapy39v75c2WiAnwLAy3yQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=antispam.mailspamprotection.com; s=default; h=CFBL-Feedback-ID:CFBL-Address :Cc:To:Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject :Date:From:Reply-To:List-Unsubscribe; bh=kdy+0w++K99irbhKozpIsd52YcoplzuImJedZzCCHOA=; b=I13tSTBVgcOD/yrZdcT56fMkVh lg4tIiRqQ5lcq+JW7YDGD98WEBHRBP5n8dPky7nMUzyZCOE4KIiZo+iJ03ig7/tN4BObCmeraY2TV OTvumvdaNBc7lIXzO+PNPs+pNnnWuA6huMTIs4ZvoM9N4HkQJvePJtR3llwnoKyEATog=; Received: from 214.173.214.35.bc.googleusercontent.com ([35.214.173.214] helo=esm19.siteground.biz) by instance-europe-west4-nf36.prod.antispam.mailspamprotection.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1v5VF3-00000008IlU-3lzy for linux-kernel@vger.kernel.org; Sun, 05 Oct 2025 20:22:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=valla.it; s=default; h=Cc:To:Subject:Date:From:list-help:list-unsubscribe: list-subscribe:list-post:list-owner:list-archive; bh=kdy+0w++K99irbhKozpIsd52YcoplzuImJedZzCCHOA=; b=brOnScoFUOdb5rfvddxtf6dIzJ QHcTzeakvVQYLUxz/aozGCByYNUlSmwYcGNrBEPBwWTVl747lsY0UqnsCF9bL4zP01z00z+BoKYYm jcbWemFa9JSI/loZJEGm9J2CmQglfzgg56OW+PWTr7smY/sRT8QLpB5jTxfCMbYFL4DQ=; Received: from [87.16.13.60] (port=64461 helo=fedora.fritz.box) by esm19.siteground.biz with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1v5VEw-000000001im-3ajW; Sun, 05 Oct 2025 20:21:54 +0000 From: Francesco Valla Date: Sun, 05 Oct 2025 22:21:36 +0200 Subject: [PATCH 3/3] drm/log: avoid WARN when checking format support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251005-drm_draw_conv_check-v1-3-9c814d9362f6@valla.it> References: <20251005-drm_draw_conv_check-v1-0-9c814d9362f6@valla.it> In-Reply-To: <20251005-drm_draw_conv_check-v1-0-9c814d9362f6@valla.it> To: Jocelyn Falempe , Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Francesco Valla X-Mailer: b4 0.14.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - esm19.siteground.biz X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - valla.it X-Source: X-Source-Args: X-Source-Dir: X-SGantispam-id: 2c942ea9770ae9de52d512dd8c6454c1 AntiSpam-DLS: false AntiSpam-DLSP: AntiSpam-DLSRS: AntiSpam-TS: 1.0 CFBL-Address: feedback@antispam.mailspamprotection.com; report=arf CFBL-Feedback-ID: 1v5VF3-00000008IlU-3lzy-feedback@antispam.mailspamprotection.com Authentication-Results: outgoing.instance-europe-west4-nf36.prod.antispam.mailspamprotection.com; iprev=pass (214.173.214.35.bc.googleusercontent.com) smtp.remote-ip=35.214.173.214; auth=pass (LOGIN) smtp.auth=esm19.siteground.biz; dkim=pass header.d=valla.it header.s=default header.a=rsa-sha256; arc=none Use drm_draw_can_convert_from_xrgb8888() instead of drm_draw_color_from_xrgb8888() while checking if a color format is usable. This avoids a WARN in case the first format is not usable. Signed-off-by: Francesco Valla --- drivers/gpu/drm/drm_panic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c index 1d6312fa142935fcf763381920ad889ca4cf4b27..4ba961e445e576d03cfb58953ee= ad90d32b40151 100644 --- a/drivers/gpu/drm/drm_panic.c +++ b/drivers/gpu/drm/drm_panic.c @@ -785,7 +785,7 @@ static bool drm_panic_is_format_supported(const struct = drm_format_info *format) { if (format->num_planes !=3D 1) return false; - return drm_draw_color_from_xrgb8888(0xffffff, format->format) !=3D 0; + return drm_draw_can_convert_from_xrgb8888(format->format); } =20 static void draw_panic_dispatch(struct drm_scanout_buffer *sb) --=20 2.51.0