From nobody Wed Dec 17 10:44:37 2025 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E85F287503 for ; Thu, 2 Oct 2025 20:02:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759435367; cv=none; b=EVPzz4842cL9UYaNYIrR4+ofNvgMwYisr3uLDds9aJmKACLAXVlIxEZgynNVxqd20WXfMrdHahlPUPzLPeru+wodBqYKD0iqxZo21ANPWJT/meW5xNt8a8HPN0tEl5Dv9B0bvqBTDFVGPSn5Rrf78VS59H0tif5AhsaKWxygTHQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759435367; c=relaxed/simple; bh=RWsMT7+A3hOigM/6lKe9y0xp7C7c2WQ715Dnkvpx1sA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rjPXgscTnluziSlRp3JMq9aiMzlMIFGKkfxTAbA6PVvONx/YJEqg5IxW/y40ZkJT3WO981irpvgagU/FLq0vYR+WHMujYJaTdttVpSYI1gN94+H1d1fG0RpRQy36dbE/tMW37nyNRRbP1GUNnJpXXOoHfO05oO0ftZ5eabbmxDE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jY/HhwZP; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jY/HhwZP" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b3d50882cc2so292168766b.2 for ; Thu, 02 Oct 2025 13:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759435364; x=1760040164; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8EXqlzb/n7e+U7sXee7rlDRiXcbYy1hChaEgy4phOls=; b=jY/HhwZPFa5Y78c7vY+N4KI/c8/3keXc/UQNq4IgK1BB3WdVofZofy3VqcEUgG7EK0 JlB03TeWEZp8BinjqL9H1AaXPEkLguzuWuuGmRyrs7zWCPlcMqSy5cy6q+wPN4Jpo9jB 0W8dnkTrjMX/2vx7qba6WzCtMFvDB4QO54O4WearBFBX9sB0mL4qRxReM4qUWO8r7kXS +ZnvOelPWI9m88fc6CeyVlHe+uNV8Kp0Fray8+qrWLv4mMXyRPE58r+StbA2APDJUMly 38XNEyHJ4zl+dvlRNeQANsqVMGaUludRCjDVpGqQBKycrxeqjH4P1zDnce0IuQB8jf8/ 3Lig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759435364; x=1760040164; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8EXqlzb/n7e+U7sXee7rlDRiXcbYy1hChaEgy4phOls=; b=osd2WY1ifXC1vjcCIcs49MSH+JZCpB2GTdL/iJMOsfCo45NqGL30wggJQGdliv1eJq dYDj9IHuyaNqK1yHAjMaN85zMI3irJpHe8KSZCwItzG7/yGMie6Ob2565x67KCx4Ckq1 BqGhuo8r+/0fiKRIru3ibqvSFX+Zu28eR1FDjJaDXTKABdwZ5+KKIMYz4Kqm4HjUFqR5 gQqKzdAbUWSkmCP4rmwU/ZxR7jKqIhFBtopYVgo2h5m4LkQM2OGo4ZhCPM5fgxMrN8fQ RhEgSExkxfM1zTp3AMPWwHpN6Nq23Q+8JW2mykPPP7HAcg4RJuJaaaW+f0IulRZNjgB7 XbOQ== X-Gm-Message-State: AOJu0Yz0BkVb++vffWHsSn4a24GOdJ6FFDA+4oai8rZWWBlg+pllSp2L KaCllTO4aIK9Crj0X51j1Eaos0MnGxFh0Le1MpCKFO6USWblFVeBye/7 X-Gm-Gg: ASbGncsnF4Bv8SsEEZQ9JmaXbzoGzYYDfiTWu0W2eCTInKdGEBbbTyYa785nR6tuiBY 5FMKWQsnkfToLujyre2UHHMEsu+N7o4ImMaFS+0q9Dva7207G9H77O/2TY600h5Ol+2s45EEJEn KEJaJBrWMukg8F9An4Bh65ZlSLnYPhlhP0+7IUYZ8/khmmeQJojEBLUNt19zUTG89Giat3SgYDD CZFieamCs+o4dFVIi6lxYKcE4IZVu/zQxocRKVqo9sneO8YKDONbyClsQ8BAxqzZzkmyFlyrPKi at9w+1UwwGBDNcw4GzF+qzc2PIJFVdIDY/H0wGKzo+av9Tn3raIluI46ZzIB3Nk/MRYiRAzfKvH kiN2vc7hk0alXDiH+erJbeNWR+JJ6cvRaExsfaxYnAs3EmS81RfeuuFo= X-Google-Smtp-Source: AGHT+IGDdBFIO4tfvjNMAM3xa2U/WAw5504eAo3K2h133YQZPtkoxtvH6poX5eZQ+RiUYMpg/ev5nA== X-Received: by 2002:a17:907:3c89:b0:b3c:896:abdc with SMTP id a640c23a62f3a-b49c525eccamr75259466b.60.1759435363618; Thu, 02 Oct 2025 13:02:43 -0700 (PDT) Received: from localhost.localdomain ([78.212.167.232]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b4869c4c1f6sm270880466b.78.2025.10.02.13.02.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Oct 2025 13:02:43 -0700 (PDT) From: Antoni Pokusinski To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux@roeck-us.net, rodrigo.gobbi.7@gmail.com, naresh.solanki@9elements.com, michal.simek@amd.com, grantpeltier93@gmail.com, farouk.bouabid@cherry.de, marcelo.schmitt1@gmail.com, Antoni Pokusinski Subject: [PATCH v4 1/5] dt-bindings: iio: pressure: add binding for mpl3115 Date: Thu, 2 Oct 2025 22:02:02 +0200 Message-Id: <20251002200206.59824-2-apokusinski01@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251002200206.59824-1-apokusinski01@gmail.com> References: <20251002200206.59824-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" MPL3115 is an I2C pressure and temperature sensor. It features 2 interrupt lines which can be configured to indicate events such as data ready or pressure/temperature threshold reached. Reviewed-by: Rob Herring (Arm) Signed-off-by: Antoni Pokusinski --- .../bindings/iio/pressure/fsl,mpl3115.yaml | 71 +++++++++++++++++++ .../devicetree/bindings/trivial-devices.yaml | 2 - 2 files changed, 71 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/pressure/fsl,mpl3= 115.yaml diff --git a/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yam= l b/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml new file mode 100644 index 000000000000..2933c2e10695 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/pressure/fsl,mpl3115.yaml @@ -0,0 +1,71 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/pressure/fsl,mpl3115.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MPL3115 precision pressure sensor with altimetry + +maintainers: + - Antoni Pokusinski + +description: | + MPL3115 is a pressure/altitude and temperature sensor with I2C interface. + It features two programmable interrupt lines which indicate events such = as + data ready or pressure/temperature threshold reached. + https://www.nxp.com/docs/en/data-sheet/MPL3115A2.pdf + +properties: + compatible: + const: fsl,mpl3115 + + reg: + maxItems: 1 + + vdd-supply: true + + vddio-supply: true + + interrupts: + minItems: 1 + maxItems: 2 + + interrupt-names: + minItems: 1 + maxItems: 2 + items: + enum: + - INT1 + - INT2 + + drive-open-drain: + type: boolean + description: + set if the specified interrupt pins should be configured as + open drain. If not set, defaults to push-pull. + +required: + - compatible + - reg + - vdd-supply + - vddio-supply + +additionalProperties: false + +examples: + - | + #include + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + pressure@60 { + compatible =3D "fsl,mpl3115"; + reg =3D <0x60>; + vdd-supply =3D <&vdd>; + vddio-supply =3D <&vddio>; + interrupt-parent =3D <&gpio1>; + interrupts =3D <4 IRQ_TYPE_EDGE_FALLING>; + interrupt-names =3D "INT2"; + }; + }; diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Docum= entation/devicetree/bindings/trivial-devices.yaml index f3dd18681aa6..918d4a12d61c 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -113,8 +113,6 @@ properties: - fsl,mma7660 # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer - fsl,mma8450 - # MPL3115: Absolute Digital Pressure Sensor - - fsl,mpl3115 # MPR121: Proximity Capacitive Touch Sensor Controller - fsl,mpr121 # Honeywell Humidicon HIH-6130 humidity/temperature sensor --=20 2.25.1 From nobody Wed Dec 17 10:44:37 2025 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 619A128D8CC for ; Thu, 2 Oct 2025 20:02:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759435373; cv=none; b=AvwPfSncqPT57m8MbpIDFWCRdQjWFblQY5B57HDK+T4X9zn5L2omYSAU4EVvOXiOF1DTb7ZzFOdE/SBhM7yoEexDvKGwZ0+9A5NCNDuZPti7BDckpiIlV+hxgnahxzKDy7NbxwEqpM5tbqKaD1CAdcQeKM9bNvcxasVVr7aZoU0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759435373; c=relaxed/simple; bh=xqA4WfL7S6BHVcS+M//q/p+VfDFq76/O5OymsIWiwqI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LkPmdcijFaDjT4WPwdrD7h1W9M8c8zlmX5wcARyAh2+SeAf6ZLz82lSD1XH6lXDGblTmmMArNWEMbcadGzAJbGW2zUrcV0NoEhoD9N8ywmuaDQSYH6QafYgz3vPxKow7j2ui7x/KZVX5E/oevs0QFPEn7ZL6eJN49ESIO8mSgJE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KESQnFLB; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KESQnFLB" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b3dbf11fa9eso264739366b.0 for ; Thu, 02 Oct 2025 13:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759435370; x=1760040170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xTj76Kc5BTuQhN8FqnbvXwRLBgS3SMtN0BmmDUIv/k4=; b=KESQnFLBlMfbq+a1bsjHmWLrwW2dirpjFdLAp8Hv9qA5hlQJ/LUm6BI+w5Qh7KVJaE A3qjOYsZKUb9teywpoT0pWXeswOFVJ5q4mfMOTfUm5wAAAgtbXgfhiz7rgt8btrOfNCc QIAQDLLt/wJCxPG9EoRdz5qK5VAdtEQsjI34f75Fkknx8Uj0keblqdqJt4sYkR6JbnEq bG1/SD9yPDD3uM2DTtledgw1k/veFCRzXZscCjlrsJc5D3MpwGavsNUBxNf6H27/Npy4 eYFSnej8e8eOsuU+3HkeBoS4vXkGgEVRueQvKct8tlUionGmX6+CQPzhBuctjYSBDf7+ CZnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759435370; x=1760040170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xTj76Kc5BTuQhN8FqnbvXwRLBgS3SMtN0BmmDUIv/k4=; b=X50+HFa1hs4laP7Aw086y66X+5VkN6oV/mtWHwILMlPM2yAewwm7XgeQDJIZKZXBPN rTy8iwBufzB0uePUuY3uaWQ/elU/hxfK4bhKM4tIgQmn9n68Z/KItgeZfjFmxLSt76I1 11kzn3ARP93X1p6YiCmYSAM0r7Q1R4z5ARC7fZkse0H/RG8oo36iQm1wC838RyCNN5Qx NXJdsk/ewnCB2y/sOBpOTwt4S5nJo3C60ktzfmScDZWEc1X8BIwtUFcoELNXI+MWhhPG suQqTjJYw1n/dA+a72Yb4YSfxAsVuh6VFmgEe0/LZKQEcq9lO+GV7X4FpXWZWhiATjvJ Oblw== X-Gm-Message-State: AOJu0YzipcNzQveLXlReusOP9YNxVBKcDoWsRPzDWEiHJUUxRML0QS+N Ng7k6XEKtNc1jY+5gT1eleoRoP76qtfEmhvcil5ODLSV6cbyf10z9VQS X-Gm-Gg: ASbGncs+5oOEoaTTojWTkdp8Yolbdl5rwP0jq3yHZwI2xUkrfsKUJDc93TrhgsJQZw1 fDyE0cqRVXAnQigLC9Mx/FWvozeeayA7tBA5upFKshdrvtLBAn+u7pO1T5qGoibvzJwcs6qYGVx 6QAqJvabdJyBsrEbGB9bBT3K/Ce5vI21yUgNEQodXQdj1yClvr2oTut+yqZdck7sSh+cxuUqjXD 87rskOZCsg4soadUc69l1m4GAcfKbjdw1HMD1qTeOY5lVSYrNt/l2+uvyoweMFP1qaZp+PJJOiC +dXV3JPz9RipIi5zRzADugY4Zs8+zDw7CsSirNdeCTBmBksiRql2Iki8R6CbaMkATrzMQhPM6sD eCdRW0DCs3LzpZYFU0ENm/jrCC1RxM0lnNADp9mm3bGu9 X-Google-Smtp-Source: AGHT+IHirNV8dhsgxR2JvSGmnkIh+1Ct4YXCMozn1CUIlPWZh3N8EYqS2S96FuJZnf+B79k/VIzObA== X-Received: by 2002:a17:907:608c:b0:b45:e8e2:ade3 with SMTP id a640c23a62f3a-b49c439483amr76122266b.64.1759435369591; Thu, 02 Oct 2025 13:02:49 -0700 (PDT) Received: from localhost.localdomain ([78.212.167.232]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b4869c4c1f6sm270880466b.78.2025.10.02.13.02.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Oct 2025 13:02:49 -0700 (PDT) From: Antoni Pokusinski To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux@roeck-us.net, rodrigo.gobbi.7@gmail.com, naresh.solanki@9elements.com, michal.simek@amd.com, grantpeltier93@gmail.com, farouk.bouabid@cherry.de, marcelo.schmitt1@gmail.com, Antoni Pokusinski Subject: [PATCH v4 2/5] iio: mpl3115: add separate function for triggered buffer data collection Date: Thu, 2 Oct 2025 22:02:03 +0200 Message-Id: <20251002200206.59824-3-apokusinski01@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251002200206.59824-1-apokusinski01@gmail.com> References: <20251002200206.59824-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Factor out the code responsible for collecting data for the triggered buffer from the trigger handler into a separate function. Signed-off-by: Antoni Pokusinski --- drivers/iio/pressure/mpl3115.c | 54 +++++++++++++++++++--------------- 1 file changed, 30 insertions(+), 24 deletions(-) diff --git a/drivers/iio/pressure/mpl3115.c b/drivers/iio/pressure/mpl3115.c index 579da60ef441..1da78081ca7e 100644 --- a/drivers/iio/pressure/mpl3115.c +++ b/drivers/iio/pressure/mpl3115.c @@ -148,47 +148,53 @@ static int mpl3115_read_raw(struct iio_dev *indio_dev, return -EINVAL; } =20 -static irqreturn_t mpl3115_trigger_handler(int irq, void *p) +static int mpl3115_fill_trig_buffer(struct iio_dev *indio_dev, u8 *buffer) { - struct iio_poll_func *pf =3D p; - struct iio_dev *indio_dev =3D pf->indio_dev; struct mpl3115_data *data =3D iio_priv(indio_dev); - /* - * 32-bit channel + 16-bit channel + padding + ts - * Note that it is possible for only one of the first 2 - * channels to be enabled. If that happens, the first element - * of the buffer may be either 16 or 32-bits. As such we cannot - * use a simple structure definition to express this data layout. - */ - u8 buffer[16] __aligned(8) =3D { }; int ret, pos =3D 0; =20 - mutex_lock(&data->lock); ret =3D mpl3115_request(data); - if (ret < 0) { - mutex_unlock(&data->lock); - goto done; - } + if (ret < 0) + return ret; =20 if (test_bit(0, indio_dev->active_scan_mask)) { ret =3D i2c_smbus_read_i2c_block_data(data->client, MPL3115_OUT_PRESS, 3, &buffer[pos]); - if (ret < 0) { - mutex_unlock(&data->lock); - goto done; - } + if (ret < 0) + return ret; pos +=3D 4; } =20 if (test_bit(1, indio_dev->active_scan_mask)) { ret =3D i2c_smbus_read_i2c_block_data(data->client, MPL3115_OUT_TEMP, 2, &buffer[pos]); - if (ret < 0) { - mutex_unlock(&data->lock); - goto done; - } + if (ret < 0) + return ret; } + + return 0; +} + +static irqreturn_t mpl3115_trigger_handler(int irq, void *p) +{ + struct iio_poll_func *pf =3D p; + struct iio_dev *indio_dev =3D pf->indio_dev; + struct mpl3115_data *data =3D iio_priv(indio_dev); + /* + * 32-bit channel + 16-bit channel + padding + ts + * Note that it is possible for only one of the first 2 + * channels to be enabled. If that happens, the first element + * of the buffer may be either 16 or 32-bits. As such we cannot + * use a simple structure definition to express this data layout. + */ + u8 buffer[16] __aligned(8) =3D { }; + int ret; + + mutex_lock(&data->lock); + ret =3D mpl3115_fill_trig_buffer(indio_dev, buffer); mutex_unlock(&data->lock); + if (ret) + goto done; =20 iio_push_to_buffers_with_ts(indio_dev, buffer, sizeof(buffer), iio_get_time_ns(indio_dev)); --=20 2.25.1 From nobody Wed Dec 17 10:44:37 2025 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93BAA299948 for ; Thu, 2 Oct 2025 20:02:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759435377; cv=none; b=H+BNQPVDcrwNQRJmdBAL1cpC9VqR/Mk15xBHAX4OUmC0//PufsO0v1qmWpcQWwODZDmSflV2Tpbf81Yj308JUJ98V0ctI9wwxAaaFv5V8mp5QRCoawiAeHRGo1hqxEewhBguRjyGVQmGb9bg9M2WoOQ0SF0JKV0UMn+KUrJH5Rc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759435377; c=relaxed/simple; bh=REDD5MKT+T6fE11WtgKxnSCfTx1waCKVI6IWJJQuEiw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GO3WktHDusA8SzIn0d+UcQwCFaGG+uFhjxXaD/auXvl/+CxVIy5MC14nCjv45Tffi5o53FrR4KK4c4lNCgkJE0aZk4gP8O67q5KU8DboT5WbwuJqT4Vjr/mF2+ioGH4KLEbqiGq5tJcdz9agoSxdqZm23RnGo1od8fiz7d1lT7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lHf2aNm/; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lHf2aNm/" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-637e74e92easo1656324a12.3 for ; Thu, 02 Oct 2025 13:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759435374; x=1760040174; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i5B+iY1CVYEWEXhFVr0arn1MWUauujSFMSYkHP0zG1o=; b=lHf2aNm/HR0E1L8j+2OMz5cHcVL8uyDCe9WYS6Q/U1i6WB6ObwzglCKTQ+NWWA7H08 yZGYi1j+BTjn6IdHumi/76nclBQ2fhwxC9Zq7Rd2muJpgAphvqJMJ8WPwjJWykDOm8dU u5pFa+kEnTtLi2P4SCY87KZo+TqwSkeVAwCUSlRh0rm0rj3EHJOqd3Yz8YEBNxR7iZ1Q ctIWa+AzzIUuP/GkI+MGhNiuQG+Zskr80pg8FnrkGvZO4z14QANmYNR0KQlGsNB4NrmA jbSoERbHa/eQQcCuR7hv1i/jS3RWkb8+gwAyYsRxyq+2Af8uAg5BE0c5yfhYBcoTuZxL F8DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759435374; x=1760040174; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i5B+iY1CVYEWEXhFVr0arn1MWUauujSFMSYkHP0zG1o=; b=GdpF7z5CkqPBKJVq5vpLqVNYVZ5TnjiDmrbIBAuNumTj8K4c5O0z5yxjCD7c1cCaD7 fsR+ZXrdc12WdwrRD1vI1EpbyZRBF8cSpleHUW5sJ7rpgg5UDP/eGW7zzDksjwEXXSSL 8H3y9Bw+nhuNopvjrrkjpFGFOwCqSc4d9K/0hPVsByA7tRSbXWxW8s5b+tACyER2aPbF h/RwN5t5HpOkpzNQTKqCRYVPMU7M8bi8d0tnua3CZJpOViMXneCpJsJEyQfVHYTZwTDk roXOYuNc4+jRmYW1Fv6eKrybdZwo/QlkVqrYBhzLoaqbbe3zKSzQ0hfHP2kVYQxuBlB1 557Q== X-Gm-Message-State: AOJu0Yw99hVayFb6mmBAXlw+VHQd2TNJqNuM8HBKjtDydS5PWBMeju1b 6zWiStkX9QTTmYEK6zVGP6DHAUKoR86APGAxGICDQyszgSC+QgBQECfc X-Gm-Gg: ASbGnctzYHvdDucI6fxvBPoprKucPG1S8P7i3UWB1Nv8xpbmJ7gNSQB9jz9H+tHiRL1 xyxE5kJ2JTbwHEI6d7/yO7Ti/rYbt4RA7dRXH6q06E2YUi78SaH0lOtE1/hK6+APr0ZmrvY/F8S Z0m0cgH01W0D/Db2Rj95h6WaCUDs7KdMWY/FS3OUL2urppdUHjdBI5eXgRlQZhgRUi0/ymoC91C cHrTDISPdAHrOo78mHOWranGd5PC4QA3v4PTaIDMsLpKcYC5l2xF7O4tN0Iq4NaCFtMevq0Cxtd iPJLUZcITQ9jYXaA4GgcVnFgR+Aw357RcuGi2TPkOe7fy5ibKJOJvgQL0IJ9w0KU0f+4AixTBFb ej0nHjtzH43OVPJGkanUXNTBHay622UonZ2nVAf2ghXjUfCzCWjad7eE= X-Google-Smtp-Source: AGHT+IHLLuSxZSfWj6JmA7gazFVSXaP5F8QLszT1jN6eLNAVZ7qyjvjL4BW50x/00CvbU9ELpFQ4Hg== X-Received: by 2002:a17:907:6eab:b0:b0d:ee43:d762 with SMTP id a640c23a62f3a-b49c12809ddmr83263966b.4.1759435373813; Thu, 02 Oct 2025 13:02:53 -0700 (PDT) Received: from localhost.localdomain ([78.212.167.232]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b4869c4c1f6sm270880466b.78.2025.10.02.13.02.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Oct 2025 13:02:53 -0700 (PDT) From: Antoni Pokusinski To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux@roeck-us.net, rodrigo.gobbi.7@gmail.com, naresh.solanki@9elements.com, michal.simek@amd.com, grantpeltier93@gmail.com, farouk.bouabid@cherry.de, marcelo.schmitt1@gmail.com, Antoni Pokusinski Subject: [PATCH v4 3/5] iio: mpl3115: rename CTRL_REG1 field macros Date: Thu, 2 Oct 2025 22:02:04 +0200 Message-Id: <20251002200206.59824-4-apokusinski01@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251002200206.59824-1-apokusinski01@gmail.com> References: <20251002200206.59824-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the bitfield macros of CTRL_REG1, so that their names clearly indicate their relation to CTRL_REG1. This is a preparation for introducing the support for the DRDY interrupt which requires the usage of other control registers. Signed-off-by: Antoni Pokusinski --- drivers/iio/pressure/mpl3115.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/iio/pressure/mpl3115.c b/drivers/iio/pressure/mpl3115.c index 1da78081ca7e..61830edd959b 100644 --- a/drivers/iio/pressure/mpl3115.c +++ b/drivers/iio/pressure/mpl3115.c @@ -30,10 +30,10 @@ #define MPL3115_STATUS_PRESS_RDY BIT(2) #define MPL3115_STATUS_TEMP_RDY BIT(1) =20 -#define MPL3115_CTRL_RESET BIT(2) /* software reset */ -#define MPL3115_CTRL_OST BIT(1) /* initiate measurement */ -#define MPL3115_CTRL_ACTIVE BIT(0) /* continuous measurement */ -#define MPL3115_CTRL_OS_258MS (BIT(5) | BIT(4)) /* 64x oversampling */ +#define MPL3115_CTRL1_RESET BIT(2) /* software reset */ +#define MPL3115_CTRL1_OST BIT(1) /* initiate measurement */ +#define MPL3115_CTRL1_ACTIVE BIT(0) /* continuous measurement */ +#define MPL3115_CTRL1_OS_258MS GENMASK(5, 4) /* 64x oversampling */ =20 struct mpl3115_data { struct i2c_client *client; @@ -47,7 +47,7 @@ static int mpl3115_request(struct mpl3115_data *data) =20 /* trigger measurement */ ret =3D i2c_smbus_write_byte_data(data->client, MPL3115_CTRL_REG1, - data->ctrl_reg1 | MPL3115_CTRL_OST); + data->ctrl_reg1 | MPL3115_CTRL1_OST); if (ret < 0) return ret; =20 @@ -56,7 +56,7 @@ static int mpl3115_request(struct mpl3115_data *data) if (ret < 0) return ret; /* wait for data ready, i.e. OST cleared */ - if (!(ret & MPL3115_CTRL_OST)) + if (!(ret & MPL3115_CTRL1_OST)) break; msleep(20); } @@ -268,10 +268,10 @@ static int mpl3115_probe(struct i2c_client *client) =20 /* software reset, I2C transfer is aborted (fails) */ i2c_smbus_write_byte_data(client, MPL3115_CTRL_REG1, - MPL3115_CTRL_RESET); + MPL3115_CTRL1_RESET); msleep(50); =20 - data->ctrl_reg1 =3D MPL3115_CTRL_OS_258MS; + data->ctrl_reg1 =3D MPL3115_CTRL1_OS_258MS; ret =3D i2c_smbus_write_byte_data(client, MPL3115_CTRL_REG1, data->ctrl_reg1); if (ret < 0) @@ -295,7 +295,7 @@ static int mpl3115_probe(struct i2c_client *client) static int mpl3115_standby(struct mpl3115_data *data) { return i2c_smbus_write_byte_data(data->client, MPL3115_CTRL_REG1, - data->ctrl_reg1 & ~MPL3115_CTRL_ACTIVE); + data->ctrl_reg1 & ~MPL3115_CTRL1_ACTIVE); } =20 static void mpl3115_remove(struct i2c_client *client) --=20 2.25.1 From nobody Wed Dec 17 10:44:37 2025 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C1CA2BD036 for ; Thu, 2 Oct 2025 20:02:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759435381; cv=none; b=XuLv7v+EYZuPL4JHiHirBqUU9NhrPtCssGaIMTs66DWPcceQ2IIhRS0KvC3BeqcTAw53I7f/16JvsEI7L/hAtwigeDJS4kB9XAmm2ZHSYrjIkE7zdniKJu0dxukkJRhZQPyO6v2cY12A6IzlUtqfFIrhAluJC28xKk7DQfNzfAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759435381; c=relaxed/simple; bh=6FPUEALquhk+vxSbziWXS7XB72pS9nEdo3V5a45iILU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jOaYV+HuSMurW4ywSDNaWd0ISy2Jzd/25G1Uor7X2Yh/sNfRHuwb7Tr6VphdPpkZRw588jysggGkz+ig0//0Z37IQJF1HxxTJ0jN1fSRYL8Yufue5Oq27CjTI4mWbN0HKWWLPKJJXIMcVn8F44vApi4SPn2SjoK49OrpgHtahYA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AdrZUm8/; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AdrZUm8/" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b3da3b34950so251114166b.3 for ; Thu, 02 Oct 2025 13:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759435378; x=1760040178; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kcMlC5LUde4mDf43AKd1K4g7ws7NF5+Rvc2t/AmCk+8=; b=AdrZUm8/9fqD2sX1bir3XHxdmupqxILUL7frR3K6m/DVrAGPNjLthXqGimSjCWJ3HJ xHb3pgRpG+i+RRb3DbGu24k9G/I7HMRvaXe7J5S0+BheYjXlapSIKBC4ZLnnPql/PIoy 9h12oO2W3XDDlFRQLV0otyoakkLrlbTXBp4RCy4gjeM21eCCdPEyLa7iepdcgQOMjdQD MOZ2nVL8BXTyWOosBNtbJeVQjpFuLAmGJR7Twug1wHy390s+8+XGm7Pwni+Jyox0khfK RQ2Fgr6Yr9bfLQ7S4k0ROwvpPryLh0upCsUTZcF6psE+chVc5CtPHq0YvT+LaUNK/8jB VzdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759435378; x=1760040178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kcMlC5LUde4mDf43AKd1K4g7ws7NF5+Rvc2t/AmCk+8=; b=s3WhjiO9uZR3vZ/e8zbotD36Z8QLQ+YTYtxcS19WRelFNlvv880mmTzKKj17zRFud2 QKYi+HlpttFbnb9G4A5qYbfFB9EHZZhrkkZ+8deixZdAGHYLOf+5gcGazI+MxlheV0wq t9+devaLh+Xn9DxJEzBl+m1wYqApdVc2PWL6oOBmcJ9Rjp9ushLX7ub5KZh6GFd0+y0e mFcpblFRtQBNlUt/N8MhJb7L4fjSl6MFVparYUadKmrqDZ1BjbcbSQVnf4jelRfNAmZU /KcDvEmykmml+J5fEDm6QwuJtrcs72+b8ZG44emC0NY2/VzceUN6Y21HfBcNRxgOJ2j2 omnA== X-Gm-Message-State: AOJu0YwWBRURbKKtvCIHWP4yg2Z2MUtoFBQ31mEK0wdzh+8eJefPy9hp DV5aIvh28D+tj4yyr+I8DHS+wtooO8CPhJKka+tItTizlT9aoB7w3kIL X-Gm-Gg: ASbGnct7Pyb5tj6QL067X7UdzNYhrswg/QNRULFDHxukINtTeoVLz53N4wFovycqCDT 00LnN+HspVb7RVaUxyibZAi/KMzFwwPeYxa6X86lvYooF3pLTkXxCBIqONOPgKarR0Wt6a4UZCD GZFN2JSxFrmi3PFZDf+k9DcI1G8NRHgqlEA61+6+LWn4Cfv81Iaebr/rCNuVtkx4KKiakefHEM9 QNZh2TLg+SiiIeUUWQeJfy+mtg9lg+1vNEefcW36SdqhvOrwiELQARIfchq+1mzgytBqjBe5wEO /MQxEsctd6QEXwhrNuvFKOTiWf7jIfEVhfln/Ev55iOqViD5LFf9a2lFhY5zNIyZW/Frw2jnAu6 2AIjf5jTvmirtqbudQnhXanubbZO9DhSQYforPksANtfG X-Google-Smtp-Source: AGHT+IHg9gM8XCrDWo7eM+upb/VtHZKVPWNJsXPFkFgCw0z7uYndYI6jplCbzBzQzMx0xQZMDxHaZg== X-Received: by 2002:a17:907:868f:b0:b45:33bb:24f3 with SMTP id a640c23a62f3a-b49c2c5dd45mr82884666b.44.1759435377619; Thu, 02 Oct 2025 13:02:57 -0700 (PDT) Received: from localhost.localdomain ([78.212.167.232]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b4869c4c1f6sm270880466b.78.2025.10.02.13.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Oct 2025 13:02:57 -0700 (PDT) From: Antoni Pokusinski To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux@roeck-us.net, rodrigo.gobbi.7@gmail.com, naresh.solanki@9elements.com, michal.simek@amd.com, grantpeltier93@gmail.com, farouk.bouabid@cherry.de, marcelo.schmitt1@gmail.com, Antoni Pokusinski Subject: [PATCH v4 4/5] iio: mpl3115: add support for DRDY interrupt Date: Thu, 2 Oct 2025 22:02:05 +0200 Message-Id: <20251002200206.59824-5-apokusinski01@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251002200206.59824-1-apokusinski01@gmail.com> References: <20251002200206.59824-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" MPL3115 sensor features a "data ready" interrupt which indicates the presence of new measurements. Signed-off-by: Antoni Pokusinski --- drivers/iio/pressure/mpl3115.c | 183 +++++++++++++++++++++++++++++++-- 1 file changed, 175 insertions(+), 8 deletions(-) diff --git a/drivers/iio/pressure/mpl3115.c b/drivers/iio/pressure/mpl3115.c index 61830edd959b..e1b2c9f2bb43 100644 --- a/drivers/iio/pressure/mpl3115.c +++ b/drivers/iio/pressure/mpl3115.c @@ -7,40 +7,66 @@ * (7-bit I2C slave address 0x60) * * TODO: FIFO buffer, altimeter mode, oversampling, continuous mode, - * interrupts, user offset correction, raw mode + * user offset correction, raw mode */ =20 -#include +#include +#include #include +#include +#include + +#include #include #include -#include -#include #include -#include +#include +#include =20 #define MPL3115_STATUS 0x00 #define MPL3115_OUT_PRESS 0x01 /* MSB first, 20 bit */ #define MPL3115_OUT_TEMP 0x04 /* MSB first, 12 bit */ #define MPL3115_WHO_AM_I 0x0c +#define MPL3115_INT_SOURCE 0x12 +#define MPL3115_PT_DATA_CFG 0x13 #define MPL3115_CTRL_REG1 0x26 +#define MPL3115_CTRL_REG3 0x28 +#define MPL3115_CTRL_REG4 0x29 +#define MPL3115_CTRL_REG5 0x2a =20 #define MPL3115_DEVICE_ID 0xc4 =20 #define MPL3115_STATUS_PRESS_RDY BIT(2) #define MPL3115_STATUS_TEMP_RDY BIT(1) =20 +#define MPL3115_INT_SRC_DRDY BIT(7) + +#define MPL3115_PT_DATA_EVENT_ALL GENMASK(2, 0) + #define MPL3115_CTRL1_RESET BIT(2) /* software reset */ #define MPL3115_CTRL1_OST BIT(1) /* initiate measurement */ #define MPL3115_CTRL1_ACTIVE BIT(0) /* continuous measurement */ #define MPL3115_CTRL1_OS_258MS GENMASK(5, 4) /* 64x oversampling */ =20 +#define MPL3115_CTRL3_IPOL1 BIT(5) +#define MPL3115_CTRL3_IPOL2 BIT(1) + +#define MPL3115_CTRL4_INT_EN_DRDY BIT(7) + +#define MPL3115_CTRL5_INT_CFG_DRDY BIT(7) + struct mpl3115_data { struct i2c_client *client; + struct iio_trigger *drdy_trig; struct mutex lock; u8 ctrl_reg1; }; =20 +enum mpl3115_irq_pin { + MPL3115_IRQ_INT1, + MPL3115_IRQ_INT2, +}; + static int mpl3115_request(struct mpl3115_data *data) { int ret, tries =3D 15; @@ -153,9 +179,11 @@ static int mpl3115_fill_trig_buffer(struct iio_dev *in= dio_dev, u8 *buffer) struct mpl3115_data *data =3D iio_priv(indio_dev); int ret, pos =3D 0; =20 - ret =3D mpl3115_request(data); - if (ret < 0) - return ret; + if (!(data->ctrl_reg1 & MPL3115_CTRL1_ACTIVE)) { + ret =3D mpl3115_request(data); + if (ret < 0) + return ret; + } =20 if (test_bit(0, indio_dev->active_scan_mask)) { ret =3D i2c_smbus_read_i2c_block_data(data->client, @@ -234,10 +262,145 @@ static const struct iio_chan_spec mpl3115_channels[]= =3D { IIO_CHAN_SOFT_TIMESTAMP(2), }; =20 +static irqreturn_t mpl3115_interrupt_handler(int irq, void *private) +{ + struct iio_dev *indio_dev =3D private; + struct mpl3115_data *data =3D iio_priv(indio_dev); + int ret; + + ret =3D i2c_smbus_read_byte_data(data->client, MPL3115_INT_SOURCE); + if (ret < 0) + return IRQ_HANDLED; + + if (!(ret & MPL3115_INT_SRC_DRDY)) + return IRQ_NONE; + + iio_trigger_poll_nested(data->drdy_trig); + + return IRQ_HANDLED; +} + +static int mpl3115_config_interrupt(struct mpl3115_data *data, + u8 ctrl_reg1, u8 ctrl_reg4) +{ + int ret; + + ret =3D i2c_smbus_write_byte_data(data->client, MPL3115_CTRL_REG1, + ctrl_reg1); + if (ret < 0) + return ret; + + ret =3D i2c_smbus_write_byte_data(data->client, MPL3115_CTRL_REG4, + ctrl_reg4); + if (ret < 0) + goto reg1_cleanup; + + data->ctrl_reg1 =3D ctrl_reg1; + + return 0; + +reg1_cleanup: + i2c_smbus_write_byte_data(data->client, MPL3115_CTRL_REG1, + data->ctrl_reg1); + return ret; +} + +static int mpl3115_set_trigger_state(struct iio_trigger *trig, bool state) +{ + struct iio_dev *indio_dev =3D iio_trigger_get_drvdata(trig); + struct mpl3115_data *data =3D iio_priv(indio_dev); + u8 ctrl_reg1 =3D data->ctrl_reg1; + u8 ctrl_reg4 =3D state ? MPL3115_CTRL4_INT_EN_DRDY : 0; + + if (state) + ctrl_reg1 |=3D MPL3115_CTRL1_ACTIVE; + else + ctrl_reg1 &=3D ~MPL3115_CTRL1_ACTIVE; + + guard(mutex)(&data->lock); + + return mpl3115_config_interrupt(data, ctrl_reg1, ctrl_reg4); +} + +static const struct iio_trigger_ops mpl3115_trigger_ops =3D { + .set_trigger_state =3D mpl3115_set_trigger_state, +}; + static const struct iio_info mpl3115_info =3D { .read_raw =3D &mpl3115_read_raw, }; =20 +static int mpl3115_trigger_probe(struct mpl3115_data *data, + struct iio_dev *indio_dev) +{ + struct fwnode_handle *fwnode =3D dev_fwnode(&data->client->dev); + int ret, irq, irq_type, irq_pin =3D MPL3115_IRQ_INT1; + + irq =3D fwnode_irq_get_byname(fwnode, "INT1"); + if (irq < 0) { + irq =3D fwnode_irq_get_byname(fwnode, "INT2"); + if (irq < 0) + return 0; + + irq_pin =3D MPL3115_IRQ_INT2; + } + + irq_type =3D irq_get_trigger_type(irq); + if (irq_type !=3D IRQF_TRIGGER_RISING && irq_type !=3D IRQF_TRIGGER_FALLI= NG) + return -EINVAL; + + ret =3D i2c_smbus_write_byte_data(data->client, MPL3115_PT_DATA_CFG, + MPL3115_PT_DATA_EVENT_ALL); + if (ret < 0) + return ret; + + if (irq_pin =3D=3D MPL3115_IRQ_INT1) { + ret =3D i2c_smbus_write_byte_data(data->client, + MPL3115_CTRL_REG5, + MPL3115_CTRL5_INT_CFG_DRDY); + if (ret) + return ret; + + if (irq_type =3D=3D IRQF_TRIGGER_RISING) { + ret =3D i2c_smbus_write_byte_data(data->client, + MPL3115_CTRL_REG3, + MPL3115_CTRL3_IPOL1); + if (ret) + return ret; + } + } else if (irq_type =3D=3D IRQF_TRIGGER_RISING) { + ret =3D i2c_smbus_write_byte_data(data->client, MPL3115_CTRL_REG3, + MPL3115_CTRL3_IPOL2); + if (ret) + return ret; + } + + data->drdy_trig =3D devm_iio_trigger_alloc(&data->client->dev, + "%s-dev%d", + indio_dev->name, + iio_device_id(indio_dev)); + if (!data->drdy_trig) + return -ENOMEM; + + data->drdy_trig->ops =3D &mpl3115_trigger_ops; + iio_trigger_set_drvdata(data->drdy_trig, indio_dev); + + ret =3D devm_request_threaded_irq(&data->client->dev, irq, NULL, + mpl3115_interrupt_handler, + IRQF_ONESHOT, + "mpl3115_irq", indio_dev); + if (ret) + return ret; + + ret =3D devm_iio_trigger_register(&data->client->dev, data->drdy_trig); + if (ret) + return ret; + + indio_dev->trig =3D iio_trigger_get(data->drdy_trig); + + return 0; +} + static int mpl3115_probe(struct i2c_client *client) { const struct i2c_device_id *id =3D i2c_client_get_device_id(client); @@ -277,6 +440,10 @@ static int mpl3115_probe(struct i2c_client *client) if (ret < 0) return ret; =20 + ret =3D mpl3115_trigger_probe(data, indio_dev); + if (ret) + return ret; + ret =3D iio_triggered_buffer_setup(indio_dev, NULL, mpl3115_trigger_handler, NULL); if (ret < 0) --=20 2.25.1 From nobody Wed Dec 17 10:44:37 2025 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 750B52BEC28 for ; Thu, 2 Oct 2025 20:03:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759435387; cv=none; b=T49CANwLUCUsKliTp6T41KSJtx7uIXyZQRItYPGHdcT564yJPiJVhZz1LLlVSkzL9V8OAzXJqGboxTh3FfwhXErZXLR29oNUrk1lAqjxZ2By60k7PytLxIqJ7SDefcs/B3eKGwB3ze2wj5G9LNyljngSmeaIyQXccaeApR9AGb8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759435387; c=relaxed/simple; bh=EpL1W1edi9h8REPOr4noDqXYtDbsdKwiqoOsc/wHtq0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=caT9XhWCo9FFOXckZ4albSwb2gMvIYG9zVYmU6XorxY5ECFo2NHJAcTSTWMMkowNu+IUohS6X0uz28FD6Pzz6wcKgM1v/Eb9YtraQHtagvE5F62Tkt5/nUxr076DJCzc2Pijb+PFg0zFrWsOivpA9WDPhidY1NHDhIyx8k/pzdA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WSdzkMuV; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WSdzkMuV" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b3ee18913c0so257032466b.3 for ; Thu, 02 Oct 2025 13:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759435382; x=1760040182; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pzCar1H1ETumQy6I5ubSkBWahxrlTkku+nLQixUObJ8=; b=WSdzkMuV9d676lRKDiOCXh7AcXk3otIz3QqZPLH+0ucFS/fZhblai2fH4Z1izdFgqN jw8aEYQAsIjYHNeKvVH1AP1PAcOXhq4Qq8GEbCwnMjSyPpPPNwUKPVkQ+EO/zTBj6tBW ZbZXqTy2FGaKy9vsYgJHP9YCuzlbq+8/MZerAZNXLIf5UtgaNRsS5fvcl1Yi9R2m8Sim +2/hicfSOZIkoDxsMwCVFlgics2zIZvSShR5x7eb0D6meagjVDF86q1tNbAoKBwpSTV4 bw+nBqT40/rG8o5nrpq6r6YSnH98hvmXEqUjZvmDkHERAED0kTZ6a+D9KiUnl6Kdnqmn LksA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759435382; x=1760040182; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pzCar1H1ETumQy6I5ubSkBWahxrlTkku+nLQixUObJ8=; b=jKNrjnE9Yimasu2xYZ0I2xk10nIcPUyNSWjQfh3DuPD7TIf/ViS4xCN5kAMV5jBTgC naJnpGPcIxUzuvhzNHkjW7oIC2iVB0BnfCeiC1H4t3jJH3uqlYPGVQXutJ4sQmwp4ngg cqsGCs8ssXEJljdWIxZigCFp9bYzmFaov0F9fuwLYhrT6FGCVyEXNAmdkSe9MTV+Yrza Hi5ZKzNuQczAOjhP1s7GXUx+w/EoYzDR7j/egzBZv6IP6IXnvMImZcr4ga+neL8JJ5H1 Uuc2tYGTgVxIMJ5RaWt2btjzbHFv9y1ivNbBM8f57LzAtn2WxeRRfMfsiVoIwmqVnoRP GiUw== X-Gm-Message-State: AOJu0Yw0HqSg3gNxFbVlqTcn+xnSMe+xwP/PYEA07D/727S17TPBM7Hr bxK4+RbSiGeE8ZFnQtbGH3g2EPyO9IUm1ukME0rjnLQZ9PqHJGEoejiQ X-Gm-Gg: ASbGnctOiUPXRhWd+nRMe9+U/vFFllKr+aG+WjPMuKPq4CBLblkvODjKTcA04z52UlC kr/N7swHhN4AxtO2oscsU0lK8O9mqLRyxoDL0OVrKSs3+KRoTEInuV0bA1TQ42z868Lcb7UVxwv PgBI6VB9PYE+4JnUPzqz/jKaxhXUorP90t6uc7hfc/fHduXjoY505X43k/Ay+6eRfbareVypLQe jOS2noW2ZbCDN/9d//6LvJxKN8kPJYoNMGTI3C3dsljED59g0VFyE8gwnIwN9t6Uj50cNZVdjyf hv1DvqqnVUp6wiAGHuCn3Q7J0tsr1tuBUcxT9WgIs+hRKdrjU42vzaaJWgXtlR/9Xj7DJh+REWn W9Ucev8Tm0K6n8RdaEvh9Fc5Qvtsk+bvfTVaCNIEDUKrV X-Google-Smtp-Source: AGHT+IGpyfeRLCnDjETKLlKioZzpJNMyWdT6kQuGS4FrfAMdqmpJBwjfEWnwHVuo/pNjJ2S0NuC65A== X-Received: by 2002:a17:906:9f85:b0:b41:f729:77b0 with SMTP id a640c23a62f3a-b49c19775ccmr82770566b.21.1759435381559; Thu, 02 Oct 2025 13:03:01 -0700 (PDT) Received: from localhost.localdomain ([78.212.167.232]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b4869c4c1f6sm270880466b.78.2025.10.02.13.02.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Oct 2025 13:03:01 -0700 (PDT) From: Antoni Pokusinski To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux@roeck-us.net, rodrigo.gobbi.7@gmail.com, naresh.solanki@9elements.com, michal.simek@amd.com, grantpeltier93@gmail.com, farouk.bouabid@cherry.de, marcelo.schmitt1@gmail.com, Antoni Pokusinski Subject: [PATCH v4 5/5] iio: mpl3115: add support for sampling frequency Date: Thu, 2 Oct 2025 22:02:06 +0200 Message-Id: <20251002200206.59824-6-apokusinski01@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251002200206.59824-1-apokusinski01@gmail.com> References: <20251002200206.59824-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable When the device is in ACTIVE mode the temperature and pressure measurements are collected with a frequency determined by the ST[3:0] bits of CTRL_REG2 register. Reviewed-by: Nuno S=C3=A1 Signed-off-by: Antoni Pokusinski --- drivers/iio/pressure/mpl3115.c | 82 ++++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) diff --git a/drivers/iio/pressure/mpl3115.c b/drivers/iio/pressure/mpl3115.c index e1b2c9f2bb43..c212dfdf59ff 100644 --- a/drivers/iio/pressure/mpl3115.c +++ b/drivers/iio/pressure/mpl3115.c @@ -10,6 +10,7 @@ * user offset correction, raw mode */ =20 +#include #include #include #include @@ -30,6 +31,7 @@ #define MPL3115_INT_SOURCE 0x12 #define MPL3115_PT_DATA_CFG 0x13 #define MPL3115_CTRL_REG1 0x26 +#define MPL3115_CTRL_REG2 0x27 #define MPL3115_CTRL_REG3 0x28 #define MPL3115_CTRL_REG4 0x29 #define MPL3115_CTRL_REG5 0x2a @@ -48,6 +50,8 @@ #define MPL3115_CTRL1_ACTIVE BIT(0) /* continuous measurement */ #define MPL3115_CTRL1_OS_258MS GENMASK(5, 4) /* 64x oversampling */ =20 +#define MPL3115_CTRL2_ST GENMASK(3, 0) + #define MPL3115_CTRL3_IPOL1 BIT(5) #define MPL3115_CTRL3_IPOL2 BIT(1) =20 @@ -55,6 +59,25 @@ =20 #define MPL3115_CTRL5_INT_CFG_DRDY BIT(7) =20 +static const unsigned int mpl3115_samp_freq_table[][2] =3D { + { 1, 0 }, + { 0, 500000 }, + { 0, 250000 }, + { 0, 125000 }, + { 0, 62500 }, + { 0, 31250 }, + { 0, 15625 }, + { 0, 7812 }, + { 0, 3906 }, + { 0, 1953 }, + { 0, 976 }, + { 0, 488 }, + { 0, 244 }, + { 0, 122 }, + { 0, 61 }, + { 0, 30 }, +}; + struct mpl3115_data { struct i2c_client *client; struct iio_trigger *drdy_trig; @@ -170,10 +193,61 @@ static int mpl3115_read_raw(struct iio_dev *indio_dev, default: return -EINVAL; } + case IIO_CHAN_INFO_SAMP_FREQ: + ret =3D i2c_smbus_read_byte_data(data->client, MPL3115_CTRL_REG2); + if (ret < 0) + return ret; + + ret =3D FIELD_GET(MPL3115_CTRL2_ST, ret); + + *val =3D mpl3115_samp_freq_table[ret][0]; + *val2 =3D mpl3115_samp_freq_table[ret][1]; + return IIO_VAL_INT_PLUS_MICRO; } return -EINVAL; } =20 +static int mpl3115_read_avail(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + const int **vals, int *type, int *length, + long mask) +{ + if (mask !=3D IIO_CHAN_INFO_SAMP_FREQ) + return -EINVAL; + + *type =3D IIO_VAL_INT_PLUS_MICRO; + *length =3D ARRAY_SIZE(mpl3115_samp_freq_table) * 2; + *vals =3D (int *)mpl3115_samp_freq_table; + return IIO_AVAIL_LIST; +} + +static int mpl3115_write_raw(struct iio_dev *indio_dev, + const struct iio_chan_spec *chan, + int val, int val2, long mask) +{ + struct mpl3115_data *data =3D iio_priv(indio_dev); + int i, ret; + + if (mask !=3D IIO_CHAN_INFO_SAMP_FREQ) + return -EINVAL; + + for (i =3D 0; i < ARRAY_SIZE(mpl3115_samp_freq_table); i++) + if (val =3D=3D mpl3115_samp_freq_table[i][0] && + val2 =3D=3D mpl3115_samp_freq_table[i][1]) + break; + + if (i =3D=3D ARRAY_SIZE(mpl3115_samp_freq_table)) + return -EINVAL; + + if (!iio_device_claim_direct(indio_dev)) + return -EBUSY; + + ret =3D i2c_smbus_write_byte_data(data->client, MPL3115_CTRL_REG2, + FIELD_PREP(MPL3115_CTRL2_ST, i)); + iio_device_release_direct(indio_dev); + return ret; +} + static int mpl3115_fill_trig_buffer(struct iio_dev *indio_dev, u8 *buffer) { struct mpl3115_data *data =3D iio_priv(indio_dev); @@ -237,6 +311,9 @@ static const struct iio_chan_spec mpl3115_channels[] = =3D { .type =3D IIO_PRESSURE, .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW), .info_mask_shared_by_type =3D BIT(IIO_CHAN_INFO_SCALE), + .info_mask_shared_by_all =3D BIT(IIO_CHAN_INFO_SAMP_FREQ), + .info_mask_shared_by_all_available =3D + BIT(IIO_CHAN_INFO_SAMP_FREQ), .scan_index =3D 0, .scan_type =3D { .sign =3D 'u', @@ -250,6 +327,9 @@ static const struct iio_chan_spec mpl3115_channels[] = =3D { .type =3D IIO_TEMP, .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW), .info_mask_shared_by_type =3D BIT(IIO_CHAN_INFO_SCALE), + .info_mask_shared_by_all =3D BIT(IIO_CHAN_INFO_SAMP_FREQ), + .info_mask_shared_by_all_available =3D + BIT(IIO_CHAN_INFO_SAMP_FREQ), .scan_index =3D 1, .scan_type =3D { .sign =3D 's', @@ -328,6 +408,8 @@ static const struct iio_trigger_ops mpl3115_trigger_ops= =3D { =20 static const struct iio_info mpl3115_info =3D { .read_raw =3D &mpl3115_read_raw, + .read_avail =3D &mpl3115_read_avail, + .write_raw =3D &mpl3115_write_raw, }; =20 static int mpl3115_trigger_probe(struct mpl3115_data *data, --=20 2.25.1