From nobody Sun Feb 8 14:52:00 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25F9F25776 for ; Thu, 2 Oct 2025 01:04:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759367059; cv=none; b=Ol8giFnSDb7ugrubE1lG0xzWPSfmV0U8tcf41tF2VShgpcX8lYhuxFkToWCoSjShVWWA6oa1z6aY/6R5ruyqeK9qz2c3qP6b2ueBqYZaqLbcikIpmAKm/4SPbLPiqVwDq2WpSmyOE/ogFkDeq4k9asF8kU17mN1b7S7+uC4SJyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759367059; c=relaxed/simple; bh=Y505aKQKUnwUfjNG+Qp9UI4/UlFZuJIXU1Q3R7U1VQk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nd0mpqKzRRpjruGl1NMgMKDsq+5jlE/C5E4eOLSKe6Gd0utmvnJT0q3rweY3qsTnc+DktEmpPxW0s4lnpaOnMd41slPC5vbj8NJuGCATQ6nWi+SkjQkkxFjamV2c8jGlNUeFUgUjpeaM0NSgiTIN14RmiEiCRRSCif0u7nIIe3o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XUVAA4jQ; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XUVAA4jQ" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-330631e534eso566836a91.0 for ; Wed, 01 Oct 2025 18:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759367057; x=1759971857; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pHTDHANhx2I7dIzGsQLBn00mkeR2Scl9/Qsf768Yqmk=; b=XUVAA4jQxE2GzEGj1p+3rCXuCEWhnqL9FPU18AeYaCKDXhVqXewfXVrSXjPXnYGinv zrweugwmjPfeKpA0PHVipI0U9AYEtGRaUq8Dx+KIVIV+wFtxUBjtpKKEPIc0ZX2PybSF yev9WGg+MEwntDz8bhgtMKBeUnQeAlTr+Wq3H6vYPChvNZdz20IA9FrUAUVgMuU7sEv1 X+RJJtuwAc2xSdN44aT9VA6byut8C3b0gQhvj3kTb+U67gqllF0MBVhr40CqCjEzsFAF F5r9Nxhdl7stVAloWvl0gDxQkLZpMDBEd+0/IhQQMeK4vCnjrGD3eYzNZxoRgZ92B/4H +gWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759367057; x=1759971857; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pHTDHANhx2I7dIzGsQLBn00mkeR2Scl9/Qsf768Yqmk=; b=V6LfplVyMwJzBnCVfOnnhQ1fcQzhYXTlWemqL/LKKLapsSUJD+jHr9dHfRHEiLXN2E O5BKX9HsaFruusTlEYcZFbypBpUgEwu/KYTde0TOzpw+QDNGZ2N3gQHPhDoDJvhpUIex 0veKJn3OF1VBhQaPAPETm3dj2dLINHvQAdjo4DoFSFCdL5WU7hPPHqRvcQQka8fqrPJl uUry9I73t+ujBj3rw9rQevH5sIyYUW2rGpS8Pat6D7z2fGm2QwpV/ysEfGbdMV5xTKcW KtOtoYGKCSC+tIEY32GaBMIP3nsbNL0hK+Bzjbh5TpQ3G1p4jTOr+cbw1FGj1z1kmRhL jTgQ== X-Forwarded-Encrypted: i=1; AJvYcCUl+0lUOhVahaFIkiTkEkeN9t8y5d0XOwGHwKcplwSvadajRaj5eEJL2cso0wBiCFiJquXgE9C64xVpqNA=@vger.kernel.org X-Gm-Message-State: AOJu0YwHGQ1ScJNM+avjcEBrJhHcWplYinMozrziGd5yS80V6ZzFboJO L8gmSCa27dfrsOlIstkEF2K1r//vneC890n9biRJl5JPa5ipyNp0eMSk X-Gm-Gg: ASbGncu8HB534uSd6pKE73QtXA7hxDloE87xAXtcDSI7sO/vaOkBS574nM/pAWnugfI M6VZ/vYCa+azGPmpDZjNZPfACH6t8FbXOUnY9eputVfK8yyODLz+Nmc7zufmlKvLrLxlczvXB+7 vZPP0n4TYlSXExdmg/YhMJdrLkIi1F9a/b3EQjtsUTjQ6PInDmRDg8b/FmcxNJ/IGn+e1gbTSdx pNOqGzCyPGdwCGNQuYAV5/F4kIQgHM3LL/SPnoYucJsLM/4uLPZkjP+u/jP6tlVUhtrrYR3xrsU jZ8HoCj92bVJX58JqXPQwouEY+Wz4A/1Tfct273hHkz37JmdJm3337tZ6cckeMPMV3IN+LDQPnM 7KIhIfIlcTAVtAxJn1gDyrMyUsgkX1eiNWxQfajt9jWaSjrxqZrkKPPVwhA== X-Google-Smtp-Source: AGHT+IF3t1LeatYEk8zV1ykLzbl5xhmZAqb1p7kS4fD0Fq+BS96TmnxU8ltYTQ5Psy74eDVDoRHjJQ== X-Received: by 2002:a17:90b:1b0b:b0:32e:a535:4872 with SMTP id 98e67ed59e1d1-339a6e281ebmr5626461a91.2.1759367057231; Wed, 01 Oct 2025 18:04:17 -0700 (PDT) Received: from ryzoh.. ([2804:14c:5fc8:8033:f637:ab:9082:d04]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-339b4f3ceedsm943113a91.18.2025.10.01.18.04.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Oct 2025 18:04:16 -0700 (PDT) From: Pedro Demarchi Gomes To: Ulf Hansson Cc: Aubin Constans , Nicolas Ferre , Alexandre Belloni , Aaro Koskinen , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Pedro Demarchi Gomes Subject: [PATCH] mmc: use octal file permissions instead of symbolic Date: Wed, 1 Oct 2025 21:57:14 -0300 Message-Id: <20251002005714.6380-1-pedrodemargomes@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As stated in Documentation/dev-tools/checkpatch.rst, octal file permissions are preferred over symbolic constants because they are easier to read and understand. Replace symbolic permissions with their octal equivalents. Signed-off-by: Pedro Demarchi Gomes --- drivers/mmc/core/block.c | 6 +++--- drivers/mmc/core/bus.h | 2 +- drivers/mmc/core/mmc.c | 4 ++-- drivers/mmc/core/mmc_test.c | 4 ++-- drivers/mmc/core/sd.c | 2 +- drivers/mmc/host/atmel-mci.c | 10 +++++----- drivers/mmc/host/davinci_mmc.c | 6 +++--- drivers/mmc/host/dw_mmc.c | 10 +++++----- drivers/mmc/host/omap.c | 4 ++-- drivers/mmc/host/omap_hsmmc.c | 4 ++-- 10 files changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index 9cc47bf94804..78dc1a9ca2ef 100644 --- a/drivers/mmc/core/block.c +++ b/drivers/mmc/core/block.c @@ -387,10 +387,10 @@ static umode_t mmc_disk_attrs_is_visible(struct kobje= ct *kobj, if (a =3D=3D &dev_attr_ro_lock_until_next_power_on.attr && (md->area_type & MMC_BLK_DATA_AREA_BOOT) && md->queue.card->ext_csd.boot_ro_lockable) { - mode =3D S_IRUGO; + mode =3D 0444; if (!(md->queue.card->ext_csd.boot_ro_lock & EXT_CSD_BOOT_WP_B_PWR_WP_DIS)) - mode |=3D S_IWUSR; + mode |=3D 0200; } =20 mmc_blk_put(md); @@ -3244,7 +3244,7 @@ static void mmc_blk_add_debugfs(struct mmc_card *card= , struct mmc_blk_data *md) =20 if (mmc_card_mmc(card)) { md->ext_csd_dentry =3D - debugfs_create_file("ext_csd", S_IRUSR, root, card, + debugfs_create_file("ext_csd", 0400, root, card, &mmc_dbg_ext_csd_fops); } } diff --git a/drivers/mmc/core/bus.h b/drivers/mmc/core/bus.h index cfd0d02d3420..8b69624fa46e 100644 --- a/drivers/mmc/core/bus.h +++ b/drivers/mmc/core/bus.h @@ -20,7 +20,7 @@ static ssize_t mmc_##name##_show (struct device *dev, str= uct device_attribute *a struct mmc_card *card =3D mmc_dev_to_card(dev); \ return sysfs_emit(buf, fmt, args); \ } \ -static DEVICE_ATTR(name, S_IRUGO, mmc_##name##_show, NULL) +static DEVICE_ATTR(name, 0444, mmc_##name##_show, NULL) =20 struct mmc_card *mmc_alloc_card(struct mmc_host *host, const struct device_type *type); diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index 5be9b42d5057..e4b7829469ea 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -830,7 +830,7 @@ static ssize_t mmc_fwrev_show(struct device *dev, card->ext_csd.fwrev); } =20 -static DEVICE_ATTR(fwrev, S_IRUGO, mmc_fwrev_show, NULL); +static DEVICE_ATTR(fwrev, 0444, mmc_fwrev_show, NULL); =20 static ssize_t mmc_dsr_show(struct device *dev, struct device_attribute *attr, @@ -846,7 +846,7 @@ static ssize_t mmc_dsr_show(struct device *dev, return sysfs_emit(buf, "0x%x\n", 0x404); } =20 -static DEVICE_ATTR(dsr, S_IRUGO, mmc_dsr_show, NULL); +static DEVICE_ATTR(dsr, 0444, mmc_dsr_show, NULL); =20 static struct attribute *mmc_std_attrs[] =3D { &dev_attr_cid.attr, diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c index 80e5d87a5e50..62b4983c1ef5 100644 --- a/drivers/mmc/core/mmc_test.c +++ b/drivers/mmc/core/mmc_test.c @@ -3218,12 +3218,12 @@ static int mmc_test_register_dbgfs_file(struct mmc_= card *card) =20 mutex_lock(&mmc_test_lock); =20 - ret =3D __mmc_test_register_dbgfs_file(card, "test", S_IWUSR | S_IRUGO, + ret =3D __mmc_test_register_dbgfs_file(card, "test", 0644, &mmc_test_fops_test); if (ret) goto err; =20 - ret =3D __mmc_test_register_dbgfs_file(card, "testlist", S_IRUGO, + ret =3D __mmc_test_register_dbgfs_file(card, "testlist", 0444, &mtf_testlist_fops); if (ret) goto err; diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c index ec02067f03c5..5ed6bc47f1c4 100644 --- a/drivers/mmc/core/sd.c +++ b/drivers/mmc/core/sd.c @@ -744,7 +744,7 @@ static ssize_t mmc_dsr_show(struct device *dev, struct = device_attribute *attr, return sysfs_emit(buf, "0x%x\n", 0x404); } =20 -static DEVICE_ATTR(dsr, S_IRUGO, mmc_dsr_show, NULL); +static DEVICE_ATTR(dsr, 0444, mmc_dsr_show, NULL); =20 MMC_DEV_ATTR(vendor, "0x%04x\n", card->cis.vendor); MMC_DEV_ATTR(device, "0x%04x\n", card->cis.device); diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index 777342fb7657..d4a504f0aded 100644 --- a/drivers/mmc/host/atmel-mci.c +++ b/drivers/mmc/host/atmel-mci.c @@ -609,12 +609,12 @@ static void atmci_init_debugfs(struct atmel_mci_slot = *slot) if (!root) return; =20 - debugfs_create_file("regs", S_IRUSR, root, host, &atmci_regs_fops); - debugfs_create_file("req", S_IRUSR, root, slot, &atmci_req_fops); - debugfs_create_u32("state", S_IRUSR, root, &host->state); - debugfs_create_xul("pending_events", S_IRUSR, root, + debugfs_create_file("regs", 0400, root, host, &atmci_regs_fops); + debugfs_create_file("req", 0400, root, slot, &atmci_req_fops); + debugfs_create_u32("state", 0400, root, &host->state); + debugfs_create_xul("pending_events", 0400, root, &host->pending_events); - debugfs_create_xul("completed_events", S_IRUSR, root, + debugfs_create_xul("completed_events", 0400, root, &host->completed_events); } =20 diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index c691f1b60395..3174e7ac65b3 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc/host/davinci_mmc.c @@ -145,17 +145,17 @@ #define MAX_NR_SG 16 =20 static unsigned rw_threshold =3D 32; -module_param(rw_threshold, uint, S_IRUGO); +module_param(rw_threshold, uint, 0444); MODULE_PARM_DESC(rw_threshold, "Read/Write threshold. Default =3D 32"); =20 static unsigned poll_threshold =3D 128; -module_param(poll_threshold, uint, S_IRUGO); +module_param(poll_threshold, uint, 0444); MODULE_PARM_DESC(poll_threshold, "Polling transaction size threshold. Default =3D 128"); =20 static unsigned poll_loopcount =3D 32; -module_param(poll_loopcount, uint, S_IRUGO); +module_param(poll_loopcount, uint, 0444); MODULE_PARM_DESC(poll_loopcount, "Maximum polling loop count. Default =3D 32"); =20 diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index c5db92bbb094..2380ab82812a 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -175,12 +175,12 @@ static void dw_mci_init_debugfs(struct dw_mci_slot *s= lot) if (!root) return; =20 - debugfs_create_file("regs", S_IRUSR, root, host, &dw_mci_regs_fops); - debugfs_create_file("req", S_IRUSR, root, slot, &dw_mci_req_fops); - debugfs_create_u32("state", S_IRUSR, root, &host->state); - debugfs_create_xul("pending_events", S_IRUSR, root, + debugfs_create_file("regs", 0400, root, host, &dw_mci_regs_fops); + debugfs_create_file("req", 0400, root, slot, &dw_mci_req_fops); + debugfs_create_u32("state", 0400, root, &host->state); + debugfs_create_xul("pending_events", 0400, root, &host->pending_events); - debugfs_create_xul("completed_events", S_IRUSR, root, + debugfs_create_xul("completed_events", 0400, root, &host->completed_events); #ifdef CONFIG_FAULT_INJECTION fault_create_debugfs_attr("fail_data_crc", root, &host->fail_data_crc); diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 52ac3f128a1c..5fc7d6d722b7 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@ -326,7 +326,7 @@ mmc_omap_show_cover_switch(struct device *dev, struct d= evice_attribute *attr, "closed"); } =20 -static DEVICE_ATTR(cover_switch, S_IRUGO, mmc_omap_show_cover_switch, NULL= ); +static DEVICE_ATTR(cover_switch, 0444, mmc_omap_show_cover_switch, NULL); =20 static ssize_t mmc_omap_show_slot_name(struct device *dev, struct device_attribute *attr, @@ -338,7 +338,7 @@ mmc_omap_show_slot_name(struct device *dev, struct devi= ce_attribute *attr, return sprintf(buf, "%s\n", slot->pdata->name); } =20 -static DEVICE_ATTR(slot_name, S_IRUGO, mmc_omap_show_slot_name, NULL); +static DEVICE_ATTR(slot_name, 0444, mmc_omap_show_slot_name, NULL); =20 static void mmc_omap_start_command(struct mmc_omap_host *host, struct mmc_command *cmd) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index adc0d0b6ae37..5c679b795af1 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -747,7 +747,7 @@ omap_hsmmc_show_slot_name(struct device *dev, struct de= vice_attribute *attr, return sprintf(buf, "%s\n", mmc_pdata(host)->name); } =20 -static DEVICE_ATTR(slot_name, S_IRUGO, omap_hsmmc_show_slot_name, NULL); +static DEVICE_ATTR(slot_name, 0444, omap_hsmmc_show_slot_name, NULL); =20 /* * Configure the response type and send the cmd. @@ -1673,7 +1673,7 @@ DEFINE_SHOW_ATTRIBUTE(mmc_regs); static void omap_hsmmc_debugfs(struct mmc_host *mmc) { if (mmc->debugfs_root) - debugfs_create_file("regs", S_IRUSR, mmc->debugfs_root, + debugfs_create_file("regs", 0400, mmc->debugfs_root, mmc, &mmc_regs_fops); } =20 --=20 2.39.5