From nobody Mon Feb 9 04:29:07 2026 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 984C53128AE for ; Thu, 2 Oct 2025 14:42:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759416139; cv=none; b=W4HZC/39+BzAF3bn1/HjrxTRKT7+xJvtIZ2gaMVf4UNGVeTfAa21lX7OHccTs1tA3BIuPWi5KEivB12uVjNnJ6RHtPT4hWkNxPh1It+bJVqmGHtrL2guTuisKfZ5TU++F14Nbjg72L3+ScdTJhnLLxuGY2BMY4zEhNsc/8k8brw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759416139; c=relaxed/simple; bh=w+MZYaVZ02IqzT3KVbIc8v+JL5IabUx7ix7rNxqMcO4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Avpzt6Hqw8uilH7aGgO30RIUvYc4xjAfx2D9RNeT3fvm2aSp2eO2Hr48EyA6wiWOdUAh50/kBxznxY94Dc7OfH1xlJQIxCSzLoQAvTaD09uERn5oF+1zJ/VGfqARk+rI96qgfJi8KAsixDWl3t4VcJYyaf5hzCb1nw+cz+KVZ3Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CMKeQG0P; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CMKeQG0P" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5797c8612b4so1424089e87.2 for ; Thu, 02 Oct 2025 07:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759416136; x=1760020936; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=b2uUwOXeOx+ZJwhfggQur4FjGWmefpICu6kR9jNyeuE=; b=CMKeQG0PlZRSdDX0Om1olTue4VCe3F5imKRjNCLi4YYn9pTMFmjUNs6etY14gUH80w A647zT/slVjNtQI/Jfv9WsPQ/6c7G3x2HzwISH+RhN+KK3k8xnnQViv1I4mAb07kHEv+ BcGaeQERitomkvRihRWdRZVDrBmeSxXWgm8lIyURZgeUWq8TnlmmJARzIVfmd65J63Ap gE8eJQkeVWYl21O7uILe0IFBSdQ5kUYPhjjol+ayZXHx5cfqNH2zL0bDf6f8CsQZyuUn 2S+YKCxPasB+8rjqZgDhGD04Ex4TB2Vo3drxq6+nUFeqNlTf/LN+FUWB+2O1bgB3qPOJ HIrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759416136; x=1760020936; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b2uUwOXeOx+ZJwhfggQur4FjGWmefpICu6kR9jNyeuE=; b=eOwD8EhWX9Wfs2tNfNQbA3h+eK5y3Dz1J1fiXtM0tz+DomRUbZ1uiy9Zc1GKebo56j H5g8lyh+yHUnf0OJPzAt8X3+/+FvIHkHWU4JziH3Y54bUILdBtVpCrMXlknuCcskPB+w f3EeAa7a9HmKNtf0xUc2cEbMB6xxF2G7htmdVz6NL4bDKNlIb5nJ0FUEnlN4CKcyCXNC AuOFAuBwOJ3+s1Y3i5tvRKmtQS/aHnOoSilUapiQ1HEZyLjn8WDEcZZzr0Js8u8ksQ/o h90+xTwqo2/JyvwkmWuA7s9BLJLzftTegE2Yjpnge/MiB+GFuwQP6Ya6sqIgckGbX61C hrZQ== X-Forwarded-Encrypted: i=1; AJvYcCVcRnVmbLhyKZEk6Gaq3rV9Ofczwf28QSRTejp5uRwcIi4z6d5Zbqp91hFwqxQo7wN1zILGHgMxHX2P2VE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6Ywea22EZHvh7XITbA5vg8Xfp61EutbKN/Avm8qfQrYvF/wQ4 j9xvkk+2YabIUNChQ/gALeEoJ68fG/Qgjg0WuPRj3amoW4OIYhGgGFB8 X-Gm-Gg: ASbGnctDWntrr/Ow0hpCJAFCNoZQUAoJ5Dw+DRu0pGbwAHGrwPp/VtbWZih3LImFR+K J/aMDIFIj405z+HntbKxRgNSrNzRH3fZ/6ZplthkGME9y/bFd8oBSVQRYqtiH4WN5+Zq5R3GbMX w6x9c9CTyMMIeVq8+4VQSatWmp1RwbkbXmysWPPK5LqCXKccoJuLfmdJpuFiVseyPE3tr0CuVZN kVuCrLK5hhhc6r4u70J+pRpfKGjsSspAutzl1gCjNXz+zAMdDt2xr9s5PvthF/JfaJcejP0rnqE F40+sTUmw89p28VYcAPN9TNx7Hib0YIl3+Q/dGnmfOG39FYMusiVEthK1ASB8HuRIV3DAAGOo3c VMRFLuSZVI/a9AaftSWY4ievlWgaDBJihSTRi73oRQIH5Ea7yqtuNv5SAQu2Wg46UZLfMvwju0I PMQaTlLxHsE/rJm0fU7OBIPWgI2g== X-Google-Smtp-Source: AGHT+IGhPnOc8T9NtMczj2X/q8cc3NRXoSP7R5os6ByTZSjWiGkW7WZLddjDX41weWGkosgmQFMyOw== X-Received: by 2002:a05:6512:2356:b0:57b:8675:e35b with SMTP id 2adb3069b0e04-58af9f0e6d6mr2525880e87.5.1759416135487; Thu, 02 Oct 2025 07:42:15 -0700 (PDT) Received: from [192.168.1.166] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-58b0119e60fsm884712e87.94.2025.10.02.07.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Oct 2025 07:42:14 -0700 (PDT) From: Marcus Folkesson Date: Thu, 02 Oct 2025 16:41:34 +0200 Subject: [PATCH v2 3/5] i2c: davinci: calculate bus freq from Hz instead of kHz Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251002-i2c-mux-v2-3-b698564cd956@gmail.com> References: <20251002-i2c-mux-v2-0-b698564cd956@gmail.com> In-Reply-To: <20251002-i2c-mux-v2-0-b698564cd956@gmail.com> To: Wolfram Sang , Peter Rosin , Michael Hennerich , Bartosz Golaszewski , Andi Shyti Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marcus Folkesson X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2838; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=w+MZYaVZ02IqzT3KVbIc8v+JL5IabUx7ix7rNxqMcO4=; b=owEBbQKS/ZANAwAKAYiATm9ZXVIyAcsmYgBo3o8zNqj3vWMKZsDPeq2WJrbZnQsZi3dBQR9Mo 6gj5akCgoSJAjMEAAEKAB0WIQQFUaLotmy1TWTBLGWIgE5vWV1SMgUCaN6PMwAKCRCIgE5vWV1S MmgTD/9icKEup0hYMJO82jco9VRXMaEsGVKncS5vll1JbZPr8WQ2r4IJnYUWXxqBKADQMZ2U/hk V+o3PNP8BlHsaBMwKztFGDfcHgBO/6+wn0e8DWNAF6tAKZsuZW6E6zkjfjDFcuXfiUC5ydl53ym iVpyETHBXPuRv5W7GuwzvT5+gr6GES41OtLRiK/Gi1vXMayKzY2nJTjSykw9sqm0xcsuxIqW8/B ZGzl2qCIqcwlkhnu1+mCjQend/g6a8D/kdVie8E/NyWPd7ksKbR0vMPPPA653lY8WLwAYJpfifT z0xNjGM+YON2rgCpnfiJlnacm0IrDZ+A8eDHwe0xM3RvD/uC88Cn/haIjm8FnyYnT4xleV1/9IA 4iNhKsnrYiivRvKXL8hIQaLbGmH7lHxK4WrSMHJLjIO38PgUojiz02X/BKGQ8GnO1Ej1wgGQZOA NNUvNirR0LynQEehGbyx7EOfXxT6jTqAMLHeA9pAYaxR2a72f5eCzslBktQ2lp3Zz6RzNvR71eo /REyhcaxkOQ2n/ngZculFBggFBTcmG4n07/ibjVjpHIsYzbGBtioGjbdtiJF7ljmcEJfpWq3Rsg JQrNfVKRru5T5oYP2lcaD7ExPYbdb7M/p+rIbBYUW+6kILoPMH2Ix1gSNiyGmiIZmhqBmBCuHYy cVXz3ZtyG79o0Ag== X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 The bus frequency is unnecessarily converted between Hz and kHz in several places. This is probably an old legacy from the old times (pre-devicetrees) when the davinci_i2c_platform_data took the bus_freq in kHz. Stick to Hz. Signed-off-by: Marcus Folkesson Reviewed-by: Bartosz Golaszewski --- drivers/i2c/busses/i2c-davinci.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davi= nci.c index 6a3d4e9e07f45ecc228943e877cde1fd9d72e8cb..82f295619c4d0ef108c57d13c10= 004aa25014cbf 100644 --- a/drivers/i2c/busses/i2c-davinci.c +++ b/drivers/i2c/busses/i2c-davinci.c @@ -117,8 +117,6 @@ /* timeout for pm runtime autosuspend */ #define DAVINCI_I2C_PM_TIMEOUT 1000 /* ms */ =20 -#define DAVINCI_I2C_DEFAULT_BUS_FREQ 100 - struct davinci_i2c_dev { struct device *dev; void __iomem *base; @@ -134,8 +132,8 @@ struct davinci_i2c_dev { #ifdef CONFIG_CPU_FREQ struct notifier_block freq_transition; #endif - /* standard bus frequency (kHz) */ - unsigned int bus_freq; + /* standard bus frequency */ + unsigned int bus_freq_hz; /* Chip has a ICPFUNC register */ bool has_pfunc; }; @@ -209,16 +207,16 @@ static void i2c_davinci_calc_clk_dividers(struct davi= nci_i2c_dev *dev) if (device_is_compatible(dev->dev, "ti,keystone-i2c")) d =3D 6; =20 - clk =3D ((input_clock / (psc + 1)) / (dev->bus_freq * 1000)); + clk =3D ((input_clock / (psc + 1)) / (dev->bus_freq_hz)); /* Avoid driving the bus too fast because of rounding errors above */ - if (input_clock / (psc + 1) / clk > dev->bus_freq * 1000) + if (input_clock / (psc + 1) / clk > dev->bus_freq_hz) clk++; /* * According to I2C-BUS Spec 2.1, in FAST-MODE LOW period should be at * least 1.3uS, which is not the case with 50% duty cycle. Driving HIGH * to LOW ratio as 1 to 2 is more safe. */ - if (dev->bus_freq > 100) + if (dev->bus_freq_hz > 100000) clkl =3D (clk << 1) / 3; else clkl =3D (clk >> 1); @@ -269,7 +267,7 @@ static int i2c_davinci_init(struct davinci_i2c_dev *dev) davinci_i2c_read_reg(dev, DAVINCI_I2C_CLKL_REG)); dev_dbg(dev->dev, "CLKH =3D %d\n", davinci_i2c_read_reg(dev, DAVINCI_I2C_CLKH_REG)); - dev_dbg(dev->dev, "bus_freq =3D %dkHz\n", dev->bus_freq); + dev_dbg(dev->dev, "bus_freq_hz =3D %dHz\n", dev->bus_freq_hz); =20 =20 /* Take the I2C module out of reset: */ @@ -761,9 +759,9 @@ static int davinci_i2c_probe(struct platform_device *pd= ev) =20 r =3D device_property_read_u32(&pdev->dev, "clock-frequency", &prop); if (r) - prop =3D DAVINCI_I2C_DEFAULT_BUS_FREQ; + prop =3D I2C_MAX_STANDARD_MODE_FREQ; =20 - dev->bus_freq =3D prop / 1000; + dev->bus_freq_hz =3D prop; =20 dev->has_pfunc =3D device_property_present(&pdev->dev, "ti,has-pfunc"); =20 --=20 2.50.1