From nobody Thu Oct 2 00:53:54 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020102.outbound.protection.outlook.com [52.101.69.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B57928643C; Wed, 1 Oct 2025 22:24:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.102 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357443; cv=fail; b=lf/y6dBkuu+7xvGPknINuGa3brFxhcfCdqerDqaqMFLQn/GViCXzJxdwscwrvlLK7165ufXz2AduKMEoHTVnDRshxTVuesCnKiCEsLs2FTtb//3hRBcFQGz2yr16EgM3GPNGeNBt5fz/7yw5cHKMQ7/VtAdxSYG0XnxVLXOfF2E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357443; c=relaxed/simple; bh=A1bSBGy2kZH8EFv3WwQRHeaHSvuGuDCdM/uEwJlCwto=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=uYAmg+TCGhS8EASaD7nZJqbGNmc/0unD/tdlEGn5X/oB5wGPUKh2UeWHCnb3+VHOevyxxAtMgrSIhaRoTwsD8tt+vrAjfswi+2VCDkP6i1Hh9As5o6rUVxXwe7nUEMrJdwVuPZZbam3gfbScySZmRHVOCBL0rl4Ifme6FT+quIA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=Ntw69pbp; arc=fail smtp.client-ip=52.101.69.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="Ntw69pbp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A00TqnBT9WmCMkp97v6Gwmibpt2sSfqWWHxNyOa7uu4gWlTyB3YCz93UXfdhXsi4+Oi11wSIHhHU+mkM5w9XAgwyD5P5gXvnTv52fzTNsBCe5/ytgGAL0bkXYW+4QZFBCf7/i5k3ebx4Tc9+Jhff9Idrx+L87L5X3KcmgbhPsCacIZ+IJb+kQ+eu9tY43Vpfy5MWye1r2EHj7pUnFUA2Az16o5NIwIVV7M63k3QSmhXYAp+FviQFk+2wUxJxbG+CfbcNUY0Pn+udkJbAM3Cva3dOR0nT26buhbGdrsO0AK6hm0wCOPzbgvy+2ayEU5AAzMLjjoOEWTuU3V+zb8nXBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DHZ5zpP9tC1wl8ucs9JOwOjBMT1xIexdwM8R+ImbukQ=; b=No24jjQhygw7ZSLah6tFruzSpL456VF7D9EyWhyiSb+EGty8yTqgT6X9zzwlNMIzQadr+6ILJRgY0aBa3f60rjagay66w6Q8B91CEAh5kHse5kQw5Ysokwv3hqFB+LWbAYe9nbr+1+Vhzs1SO/5zQajj25Nv4tEWQSH1+m7eWRwXijD0ZFt1lNNZbNmSuA3imvQD/Q3w+BZFFGMukxmKlaR3lf1NxMjhUF8DjlG6Lajzatygwa1zWGTvygjvN9o7D4Ork4tN+/JxNroerY8vdZ7U2XBr/MJ3NeE6WjofXsveamYSmN78FqAIpew1CywaluaV/K/bEPLbH54B2Ph7cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DHZ5zpP9tC1wl8ucs9JOwOjBMT1xIexdwM8R+ImbukQ=; b=Ntw69pbp28DeBTheEWQA1imcEb+/AeypyDnvOiBxnDu6OqRMQSc/Gn+9DAE13+/lOu8zgjiuNYOe+hfnsnPCT0UP8hPfdjxG6IYqCO97BE+CpaZxtG8rS1wu3K4sSp3WK1syzmKJVuusCCgS+dg46qda8FagswS72sXfs0ZNW88WnWUj+SNBDpSpB2pCOmf2kNQl2KOTFL0EmuTTgfNofgiWpu0ZxFn3gg35smAmq+ZMF4MAsDS6DHBYSIA4/9Enyi1ZsNGYfx3Kzjh0CzY7YFLYq3BZ/Rz5/jQ1SKkJndq47Ba3uPqkDapRdZ731TLnLpHi+DeONPyBEkpdlP6IOg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6302.eurprd08.prod.outlook.com (2603:10a6:102:ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 22:23:55 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%3]) with mapi id 15.20.9160.017; Wed, 1 Oct 2025 22:23:55 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mikhail Kshevetskiy , Andreas Gnau , Frieder Schrempf Subject: [PATCH v6 01/13] spi: airoha: return an error for continuous mode dirmap creation cases Date: Thu, 2 Oct 2025 01:23:34 +0300 Message-ID: <20251001222347.3386506-2-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> References: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0447.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::13) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: 5579dafc-e1f2-42ff-db7c-08de01393590 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Pom2IXUAGY/sCutOYJ6njLN8+/8VUr3ka4FyZDFpNSM6g3Me3uZeD9+upoy+?= =?us-ascii?Q?2UTxK/BTGyrGu2nD3iVs/OY/t9gjurk8lmCYrXZ6zc+7CKoWSGPCUS8B44Lw?= =?us-ascii?Q?bEcGBB00snPaemGb2NyuUc5tEPUF2w6UMsi9Il8tgKGssODno//BvxuepTzs?= =?us-ascii?Q?UjbR0sPJWsn6gbUWBDUCSpQIFIeBXfXhjNS1nZK0bAHJX7uVmBlTSFdkQ8ZQ?= =?us-ascii?Q?ZSmuyqCcpa72vOEuCNquK6lgS8J27K9lXda8MrPTbho4kfHLOFXBak1fQR3A?= =?us-ascii?Q?QakYEWDA8ZEkNhQtHvKdr4YKONUsbffA22KqGOYAfymMXII+WMb2PlzuBvl5?= =?us-ascii?Q?plcfNyOPQnZDRFjORP9Yvp55ZYq3XRp7rQOSqHeUQFJD3Ez1ab19+oR3U9rI?= =?us-ascii?Q?XKm+IFVp0Ur4BPbuSvkjpq8QDaXCC/MwLcDTwwKeOA2hrXo6l8QG2mf+XP8O?= =?us-ascii?Q?VJQXbLrkVuZQCKSVbYt10j107cWkef3rwostjSFZpUD4W9hVwmMP+51xbsDI?= =?us-ascii?Q?gCIT7YberPRlICy+U+0iCyGnehvoZH7bXavVDMkpHiBCV6LdKs0QbUniRhk9?= =?us-ascii?Q?3k+/pxq8KbDTmBLMlPBjc7WaaSg0WFqvL2Rla9goakHy4rhEfI77egjkfwra?= =?us-ascii?Q?13BXsCTleeW6yZORg8STWgI7OgXLRbJHKIeuHY22aFYONuU0dHWHtBG/adi/?= =?us-ascii?Q?eyVeYeSh5UuXSzSgfd660rY77Jxz/jskWO7AD2Q/lus2b3KPxTeJFjMuDgaQ?= =?us-ascii?Q?6lbIaGxGX1A0kvrFlplz+YGDYrsQEUxOS5o+/R/GgQBSpkFoecP2D40jfFyy?= =?us-ascii?Q?1cj84aU8J98R2l5Mq4s7BDuyuXCGrPXgF1vCcN/L18JEbjrwpuTptsDO0tA7?= =?us-ascii?Q?/7H5OqyPewTEgg15jPRQ8gCFDdoOMSi6s8YhsOlMBL9z7GMtP38yee7D5qM1?= =?us-ascii?Q?Xj0MmIkEfkNySXRpVEv/vTSaxtPw/gAdhSlt4GuvNdLcUMRvfRJVVpKSYy+3?= =?us-ascii?Q?5efRvYY6NUxyVnG2keIx08fOw+UZT9MVkffs7TLqJMlgtWdkKPSQkHIcCPsI?= =?us-ascii?Q?ENyXUxijBCadZm7VBxNv0TTZv0bj5bOSMPky1H36ljZ9jQw5318Jdff27IWC?= =?us-ascii?Q?wFcfTC1PrSWyGd9T0IeA0NyNRlQWoQ5UC0WcDLoG7kaxS5tYBbRZdg48hu/d?= =?us-ascii?Q?ALuFz7ch1VF/Xh1TJeN46UkU24OHCX8qtknj2TQMZtthXTQD2fpeS3N2k0lV?= =?us-ascii?Q?NwxhkalshY6lMmJJQYv1CPEQ6AkeHsIbLV6muCr0ASwt8QPaKiCKxT0fGAT4?= =?us-ascii?Q?1BwafQ3nvsIU81+0Ab4//omXVhRLKmPKtZig1xWEib9A5uWxyDRroGcWVIcO?= =?us-ascii?Q?7ZEeGh3qcLjn2Peb0r4dAwaK9UN0LeiTRQHjO0o5eCHZwMcjkfxNa5uzbw8B?= =?us-ascii?Q?gtd7qwZUEiEmT49u0p0ie7iF5egeRWYABHd3MT3F8mlO4gUpLRknWKUYymzP?= =?us-ascii?Q?naZGkNjmlW8bRS1fGiW4VwvISzRez0CNRqR3?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oad2zINkUH/kHzrYAWSzzZkH2Uc4E/+60fxqY2T0xFQgTGGVl6HCZCXNRYd8?= =?us-ascii?Q?9ZcVGU8o2rdLNHwrZJFbYJEiYG2cggzcZ59nuKkQt4SPAs1F2mSAhhK5ZJ1y?= =?us-ascii?Q?qmoo1QKXXCE/A7irMJBex5LpBJzUVlNHwyaLiu98twpO6/ebqVOkrc/vbRVK?= =?us-ascii?Q?cItqMBQR/jiA/DbZVhEnakKpeehBsmOU3up6WIhjLBIjpu/IpdVbN2Uwo4Mw?= =?us-ascii?Q?n9XKGYk8vR+8yBDr+G/rvDGldRzaWgYsTqkTdJ6Wu6FlQDPEae0DjS5tLwzK?= =?us-ascii?Q?zKcfAZfZaTt/1a5H0aGQ+eemmU73lm68t9gqtxQK1NE4ZKscuzkQeBdYmnz5?= =?us-ascii?Q?Ha8tO+dujrdylKRfDjuelnt6G03cKcBMezeFe0z5zvzqOm469vmMwqMsjC73?= =?us-ascii?Q?9fAUHslP+zlm1aX1HpBXp4ZiVLYbszN8dbHU3lufe8SxdRGZdg/kRwnQvZhj?= =?us-ascii?Q?vU+NQwdsK3ZL2htuPQ1mM6xA3pMiRU4SZ0pB3UBzaRxWVCm1u4//rPoq1FQ3?= =?us-ascii?Q?fLF5M3yjO1//iMJt2+Nym5H+XMM8WThkM7xKEk123TMeAvcicFP3jBl/128G?= =?us-ascii?Q?AEHo16QOqTqK5WIdEzRy41pOx483toVCKNgYfNt0rmjL4VZaiGUbprb92Fks?= =?us-ascii?Q?CHp7Hg9CG3lcxM8fl7PzLKfS4HTdzNBGz77cwgdS1MgnyE38aZHSf9jZ0ra1?= =?us-ascii?Q?mthmTxgkPKoGafvQljP1Af5TqGFVrS0ys1R2TigU7EJzRn9YS5jRi14UrTKv?= =?us-ascii?Q?/BFSKPalZAVU+ZF0eiI6Z1X67c8mRy5L6lWV8QsGsMta1ezjAE/OVs43Ls3t?= =?us-ascii?Q?VcFcBUS4z+viAG6uiUuXlnhS498iOgfXqVi9/ryzl79YKGFlww4HpqD5COmb?= =?us-ascii?Q?8248aJp3pFk+7rmTPqPeNn38w/PaAX4kUPxRg2J1JAmGDxNsDCIJL05hfOVc?= =?us-ascii?Q?+Qx+dhaMaw804EHws5uf1qpIbHRceXPSnLR8iBam4oTLMt2w4wZisA2CTyt7?= =?us-ascii?Q?yiw9iE3rovcKsVms4s8MhQ4789m4Q1plLc2asAfWdJPtuqywCQKajRmq945k?= =?us-ascii?Q?T5dCLN76Suz6EW5eR1eF/pu83qqRVfQYedYMjkuRxRVSc4l3+1xhF3vLPDum?= =?us-ascii?Q?1K/ltDsl2OgYs4jLZprfpyEjkgjt5nkrusweoHK8H//+WQKkgyrbmvA/G9sV?= =?us-ascii?Q?PahHpvLceu3U3pS+o33FWQkvAeeELfplByTnreYRSAtIJm898M3GlNcXa8U5?= =?us-ascii?Q?bMnL+fuvIqzhZujsq3HAuVjrCTrD0zAHTtcp5VDT2/UJzLGQTCMRtUtQ5Pvc?= =?us-ascii?Q?p5VjcsNCOBjCgXIVjcj7TrUzTwskwgDEFUOh03OkMRFnb1Kcbtik+myMNHfU?= =?us-ascii?Q?G9qQxpWTKkCQhf+95k1AHNQwu4Hka9uuGJCu+ue0HUbXpN4UAiMSSBrYBZTd?= =?us-ascii?Q?EUUQGbDz3CCTanFAjGtR0SrgRsapl2YlGZrYZZpxKwc70xq+pJGqSSBgl4NJ?= =?us-ascii?Q?0C+s+1WxW2MGinAI8G5MgCJ9csj9mkTlnrXdktl2bG/6iUI3Hy/Sjj5rczdF?= =?us-ascii?Q?0pYTI5S7czQVEPi44/E6av2KhyIuW4KCkjr+BqcLZh3K6qy490s68uG+erNl?= =?us-ascii?Q?1TRODddp3/QULk6R7lE+bNE=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 5579dafc-e1f2-42ff-db7c-08de01393590 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 22:23:55.8412 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CBcjvZ/q7tU8XWvJfYUwVNObZ50/OkBY/v8oK3u2ogYQRQBVnMsGNGZf1cq+GUYAiiTyiprEWg0QvqOhxTdeROcaosk9z8Q6hX5Ie+Ke6nI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6302 Content-Type: text/plain; charset="utf-8" This driver can accelerate single page operations only, thus continuous reading mode should not be used. Continuous reading will use sizes up to the size of one erase block. This size is much larger than the size of single flash page. Use this difference to identify continuous reading and return an error. Signed-off-by: Mikhail Kshevetskiy Reviewed-by: Frieder Schrempf Reviewed-by: AngeloGioacchino Del Regno --- drivers/spi/spi-airoha-snfi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index dbe640986825..043a03cd90a1 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -618,6 +618,10 @@ static int airoha_snand_dirmap_create(struct spi_mem_d= irmap_desc *desc) if (desc->info.offset + desc->info.length > U32_MAX) return -EINVAL; =20 + /* continuous reading is not supported */ + if (desc->info.length > SPI_NAND_CACHE_SIZE) + return -E2BIG; + if (!airoha_snand_supports_op(desc->mem, &desc->info.op_tmpl)) return -EOPNOTSUPP; =20 --=20 2.51.0 From nobody Thu Oct 2 00:53:54 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020102.outbound.protection.outlook.com [52.101.69.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77C6928C86C; Wed, 1 Oct 2025 22:24:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.102 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357445; cv=fail; b=dVnrQCMijQJJqvKOdow17ctYn6nGKw4aX9Apd5kLPcR18XZtNF69HK1H9CQT1KBATLTq46wcdHUat4dNwXBZRn0H568Rlz7Pm28FlWqLvJmQuo79uvJjZCmSK0gVtK7tl4VA3wuQqfxrhWHrYUvAOtl10uq34De+FPgvOBU20P0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357445; c=relaxed/simple; bh=obHIhFUcGxmWKO6movIYZRxfkEvNHpdj1r8QrGoJf4Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=idoeF0LJRN6j+9ZxSkZGECo5j7cMS0QzDuWSxRvuat35thToWvYMrK3R2kESjxusgdMf00KVkWhU8YfbyG0qXyLNUsxyiBUxoT67XBBPGI3rgO8Q6wGrLPQ/cLCd/SLtHH+cFq8rPDF9W4xjF1O+zLBxfmkdSd1MlAwbJwbXcbI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=kDywf3Oi; arc=fail smtp.client-ip=52.101.69.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="kDywf3Oi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fkZoUOvYnsKP0Yw5m2jttrc8FWN9TRMYe3GAd6Lu8OEKqDOX5FWKx2+mKKY8JzlbNOAevgCo03HRtsXNEfPzoNbLHKFtP0cGDYfLwW2slZJoJ+RXavazf1d2zWnK7DFXN+yuavVpB8Oj6PJEjA3CYUDEM+pSsRkUbOmBzDmPyVhUhUgfkJ0aaXmWms/d/tsXHwDBnW4Ky5yvtLiKhe1QLRroqqvaOhkERIB+AvifE+jhyjp1oFFLAVLnyPUfY+Y+iATH4XB+/5Xuf2OxPUSFUPnvqkEJwgT1AcLDdzSz5+hkPT5BCJ74NsASWUbyWNysesvf8A0l309Q/wfUEZJogQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=18eqlHdcSvn8mzWmPDAf/8pve1cI5mVsrNxED55XZZ8=; b=wuUXtE2+sYSR7vi8Dueto91tyxlHPxQPOucaHLfxmn751xnrHlpRAsRecJkaq3HJfRDwq0rimBmBq9nKer6Lik4GyaopsXgGwDeqJDilM+1q6lvsxva4euqMh7MIYsEC1UHa41yMoQVVEUW+h6ufpNy+lXKSOUYetZzm4UtFkbInH0Wd4TpVmCqlsueV0l+GvXl053ZI8CH+MyRoaHq/BmEwpIIG+7aZOfYX34nLSGWFgkUqstUT9p8nXXA1zk4UdlAue06uUY7u5Z7Dr9995QjwPevlYR/JlOG4aoadTnY+bGPdELBYkmafaGBC92mR+7+zmqvs7pf0bgCAB/6ODw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=18eqlHdcSvn8mzWmPDAf/8pve1cI5mVsrNxED55XZZ8=; b=kDywf3OiWB74g9OtveiZUp0hDnu2NE9h5Gbcy7jFZCe1SUGtrvM48jT/ZlXyBjK4g7mFYetkmsxnagykpyeu4dP/WWm75GCFj3kT0wWZ4tcsJ6Kg/vASUyAJBIuZIbZoCfFMp+QJuRfGSqjUmqRvhFvcsELpczhz95fGOXn+BUOrZv8bOVWevAoYxUJG2uKKnCP1TnMEhP+Qy4FT9rJnLPOdufWB69BO+5AEKIc/jJOry+PsfMCLktXh0sZQVdTVQ5Jou9xlDwpe4bnpELrR/7h/p+QRE6vvMs2LlRh6OMwiJSe4jfJrvqYPYtyz2BywsxcPl1JHk6a1k10zV5Ykjg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6302.eurprd08.prod.outlook.com (2603:10a6:102:ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 22:23:57 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%3]) with mapi id 15.20.9160.017; Wed, 1 Oct 2025 22:23:56 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mikhail Kshevetskiy , Andreas Gnau Subject: [PATCH v6 02/13] spi: airoha: remove unnecessary restriction length Date: Thu, 2 Oct 2025 01:23:35 +0300 Message-ID: <20251001222347.3386506-3-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> References: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0447.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::13) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: 75f21206-07fa-4a56-53fd-08de0139362a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?h1UwCgFAT+jhD/5SyXsZAdchBAZJHJBIoVqPNXeP4FjeFBUxCOf/3WwTouo+?= =?us-ascii?Q?NTrdysRGZN+7a11I76lHdwzNcJAhQ8B2NB4Aj3r19xPoPKhJR3eYVIKCfO5H?= =?us-ascii?Q?vr4fWAkMIx1rfz1oXLsCXsolw9uLkhGnaCaHd4Ymof6yPW+tFGPPWZPacUvu?= =?us-ascii?Q?oLEiighkAeUX99eAvkjdD8Q7A0XE1cP+QENKHg66y4Rl9p4/S/qFbg4uRFQ7?= =?us-ascii?Q?G+3s5r1y8zt8Fh2G/aODzhf4lWEzYCW3ZVSrr3E6SPiihCBleVYp0mDDmbAB?= =?us-ascii?Q?mplbmzsGrxWR/qXGFzex2MuDsHKqRTQWvbQnFgJG4cz9egFG9Iv4qtShn/hb?= =?us-ascii?Q?xKullHHiQq0J1JDGCafKwOH1GeS7DeKMlAoA3wLkBDyA2mNiZAg7Pcfsg4gA?= =?us-ascii?Q?Tu8KQB5Zdy32B9QBugWKbSLJViv3W5GN7SDVcWkuWDUjYN34Qkbtd42ezQjD?= =?us-ascii?Q?t8P85sEP6LwW4Pynt40y2FAfge2RmckwFz7aWRQOyOOvbsNtqu3eURiY1ntx?= =?us-ascii?Q?Hdm4zN1ZRRWES8ncL37U0MxUH3dOv2T2TjMAqoKLKRocsbaW2zuIDzvMnouS?= =?us-ascii?Q?MSywoMv+g1YdItRC54St/IwGNSh7JsrwLiaXVKv59fDI+xKkwTTUx/cWNXG/?= =?us-ascii?Q?px9NhVHokHBHuzGc/KJDIUqaLMh381gS0gRxYKgAIGgCG+kUoRf+aHJyrCby?= =?us-ascii?Q?vKVooQaSaOM6s/xmKuKtf/hEDsB8iyKdtR1ZkcOfCaRqyyIKanCz9Qfg3x3Z?= =?us-ascii?Q?dr9ITKFH1tR7WSrNpUUUSGL7I39WDCqlISxYclJ5+WAHx1HeZ/9aoU+1MEdy?= =?us-ascii?Q?4nE10u/SU6qg7Ick9GV+vt+suvqDRPYPhE0T2CkeZuG2gzkxKzWD0i27D27J?= =?us-ascii?Q?zhZqiVWawpKR+TZ5OIgp7kQ0+F7jvWwnPSl+FNXudbnCScvjIfnYc2AgOdiv?= =?us-ascii?Q?Ge+HQBf+qKrzrKdqWgH/oNlQ717DeuIhJEF8Yl2M74VOkOZoXfLDcOXwehg8?= =?us-ascii?Q?rQ/rNqBq0SBDlsGxY//VbLJwodvfwP3cVXRcdZzVVG6rJX64L71hvpni0sNq?= =?us-ascii?Q?a3Jv3iV92kg1QWGqbU5UIrDoGX1LmQf55/VZARWd+vZluiNZih6qfOGQQ9nH?= =?us-ascii?Q?4ROkkq6upuQD5CQonywQCANC07wM8JM8SPMoVEsd2ZIB28u6d1r5cZu9qIaC?= =?us-ascii?Q?E5wYWlzBsxQYdu3TuyygXYM+Oo35bSNkY+ZlHnH5TApK/foniGGBCC2TGiwI?= =?us-ascii?Q?eUkBX8cT2wzjXys8vtJZtgynwIJ9X0UgsLVc8VxqDX/vv+g5mxybk9+I3gp7?= =?us-ascii?Q?ifhgph173NV1DJ0fWEYzvg8vKV8xObb3uSIEaRKTsfQrx0iJSteF6oq1dFfx?= =?us-ascii?Q?Sdik/7cQIRFHmo6WIKfU0gChDvB/IKo9xGYfIEbLD7re1MWEBGkT5ZzcBLkK?= =?us-ascii?Q?5g6ZciIMbFWpiRjbY/+P2r6/nkhER/Rq/w+N4fBvy5pWEy6kCAguPSTCKQq4?= =?us-ascii?Q?iG5dVUMEqcLO9chjIfhaK+0Dti3mIvvoJOCT?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?59PLEuGXt3UPFp53Lo92uYL7JTe+FzHTwdvK7vk/rJ4rXkaSgJMrcpAcf0LU?= =?us-ascii?Q?8fJn8PFrIGwbG8s4+aFbxukiCXUuCQsPNiXUvPCh7g6fhApSDiBd+mxv771S?= =?us-ascii?Q?zGOSTxboh00XMHhNU0rrIL1SlxoLZ9+yQ1uTzqScpXqzXYiy2nCLFECEQPGr?= =?us-ascii?Q?0O0js4rWnUwA4L3PFj9gNnTPBHwbtd08bSZbRAd57fX8ncdAPNcJWkXnNIkq?= =?us-ascii?Q?HcnpM7WOYobb99M0MdVthoFKU2XOm1Yu2EoHzQmHGB5Q8hmkug85H3XnqC3B?= =?us-ascii?Q?vFnmpTMjx0FojI7/N2LsxU+tcUNp4JiiKwTEBRXGH7hLxTnzxQUn+9xCaTya?= =?us-ascii?Q?7oeoKSyt49pZCNguEYslnw8T1qvqBj/t5Cw0ca0snCbsdjgwg5rXjZLTCSYq?= =?us-ascii?Q?P5iZDpATHlb1BTnKY9P434DWXTjUQgBKq/jB5SrruGxW8mTeazYMRs1ld0OS?= =?us-ascii?Q?i4R0oGCmKHvzjFYjCxEPrke9MhlLNXQkoQyVT2fRFysKyyxAGLnHbvWlgU0e?= =?us-ascii?Q?v4fIkrqrpN0e9fQEWJ3fLEYAnzhoGnjYinmIweCNXK0Gp8vsWbC6jhJjlBUt?= =?us-ascii?Q?diMJEccqWcFl1K9SudZSPYWTs1d8/hTOX5ug8j2XSOnuSdADGa5Y+ftgmEl5?= =?us-ascii?Q?pYS4M4rGfEDJbLtTdtnsyNCJXMuK4cMD341/Y1zREYnKgBB5cd8qBiwIZIj3?= =?us-ascii?Q?jGghV1nzrfDHBsGAZBGETT6YQTQC10Y5OHbU3gOtfh0TEeA6CbX96k3ULVq1?= =?us-ascii?Q?MzddLLeWYpngNFFwzf26q7W9KYzDznA9znhiKVhWlLbBTDD6gAKp6asqlRCf?= =?us-ascii?Q?uyRNPRFvV+ENCDeDLK8vved75xB0t3IcLmSZv7Zd87DI4pljXPVNWC6orYBt?= =?us-ascii?Q?WJopiJxmMQ968/Lqj5rlKi/YOXVRiFeH94wA8d0WhRka//0eWszc8bBlDgTF?= =?us-ascii?Q?I7Qw0myvAIbhKbU/2WW4/tjtN5GVXpmm2egAvGs7uCan+8ZVKOsnUQTkvKLQ?= =?us-ascii?Q?ceUbDhATmmw5eiUKgpuexUmm2qtLbuf1Q+U1HRF/Q+14W9InwgjvQ0a+Qx9H?= =?us-ascii?Q?VdncVWF98l7xAEzfcCI1xY7yzqvivLL4xY8Jg03PIlizT4kWYF2/R+r+Pbxp?= =?us-ascii?Q?w1J7zGv9uZy5id8zMqzsj5lgyhDHeLd50LKAupm/LbDv4tq7J3EGo8MPQ91C?= =?us-ascii?Q?p4fWZeWWoU4/Kch3gwa7zWEI6Q2x10zGIHTke5zUgM/O9wMwnQykCIOWpTxu?= =?us-ascii?Q?6JFpyV3b3YqldkIqKOVyR9PKl7Yv9Prfk9n0Jdf0+nZhGDJ9qbsfkn+GKOwM?= =?us-ascii?Q?0zHcEjnh9pVoun0qFM4z6SV22CAord+9DAumLwltrtX3EWl4buOXXUg9YZsr?= =?us-ascii?Q?VkSrt2MTPUP0x1YvJlAYB/3SIPbrngL0PTFKDXZYBmfF0gkT94lITnZzDg9f?= =?us-ascii?Q?HPevbIpJn766AblMgrjI1nu2scxdzOrr3FZdhDWeWnLIdCa4DMW89SIPoxQ7?= =?us-ascii?Q?92srIdUPcUiH6JhjnoeuA2njGRXbhHG/71azpR+y19QteiyZaDd3h9wuWkeJ?= =?us-ascii?Q?UNqfLQIxQoV/CVTs7soF6XXEl3q1EYpCzDhzh/63KdTrdUV6cSocrVrKhAYl?= =?us-ascii?Q?P2XUJY6qfFYOunlyFacKp4M=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 75f21206-07fa-4a56-53fd-08de0139362a X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 22:23:56.8607 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D/u9mlV+lH3t6P8QuYv/ViUYU1Be49t/wXZ+3p7g3XkqvrE8uXVkYZmK1tCjtToYzJIgNZAo3c/CYwMbqlqDLCsgC3knkjdQG1LphzMY22g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6302 Content-Type: text/plain; charset="utf-8" The "length < 160" restriction is not needed because airoha_snand_write_dat= a() and airoha_snand_read_data() will properly handle data transfers above SPI_MAX_TRANSFER_SIZE. Signed-off-by: Mikhail Kshevetskiy Reviewed-by: AngeloGioacchino Del Regno --- drivers/spi/spi-airoha-snfi.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 043a03cd90a1..bcc464ec9c61 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -579,13 +579,6 @@ static int airoha_snand_adjust_op_size(struct spi_mem = *mem, =20 if (op->data.nbytes > max_len) op->data.nbytes =3D max_len; - } else { - max_len =3D 1 + op->addr.nbytes + op->dummy.nbytes; - if (max_len >=3D 160) - return -EOPNOTSUPP; - - if (op->data.nbytes > 160 - max_len) - op->data.nbytes =3D 160 - max_len; } =20 return 0; --=20 2.51.0 From nobody Thu Oct 2 00:53:54 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020128.outbound.protection.outlook.com [52.101.69.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFC1430F53C; Wed, 1 Oct 2025 22:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.128 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357449; cv=fail; b=WrmL9MkuL+tnn2RdOKXvhb7EvnVEr+IgWdN8i71DzQYWqRY/k48466HEhLN5YiI7ac8LAmFY9k+42gbUsRY/SIFpNguLTpd+YHKXH67n5yZzh929r1/GNUTKOlb1EdnPKWTlY272dCyFgEs4LKM/0WY0u/ZygqU9oq18lFxUGEk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357449; c=relaxed/simple; bh=4vEupTlFblAxVYLWw8wNiQeHRVE4Pd1f1C8AoyYUpKI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Z/ENeWff6PBh4FoZviLMnODOyAe7PjaArH+XytwxbKiNGjR61aLVmFwgyoBZQIH2GgJc4Hltq9buSvWWcCx3qRLaP4548/zBlPZQqMOcU8Enfg2crHF82t7lIyVQvc2PCRvN0H9bYjHOv3nnPYvCsXo7HHyfQbkNuToSaUDFq1Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=bKyvCc+W; arc=fail smtp.client-ip=52.101.69.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="bKyvCc+W" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NrQtDkLKk8TNsd/RKxSl9bRiIRqui2dId4KFdWZq1uPHHVVKLKdgaasssIcx5bYMfsRl3WSU9Vs3RSTUXJvMCq5gpuw9rkt6RWjr9yMXGdjaHSs3kyiPetdinihX8GijpRPEKB3OvJfZ2CgTO3Dh/PCYWg+6cEwCBUtWrXK+S1cIo2lG0Vk3QeWJg00HT5jceZ7y1zlRwAM1If5MyTw7XyXHr8WWQW3CTZY/e11K+hE5BIUA0XnJgmtK036q8Q0T4YsSQctqIP+EUxhPTczx9bcc01HV54xdoDlU0RuPDQ9T+od2Mw+2151xjvb6cT9TLfkwxbRRAQ9nHYhufh8FeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vYefZq1Kji++ENuMNeN4dsMVnRysysPfLivp5ZCp2Ho=; b=fRxyO0GmfWLmqdGD0JM5TCvrJrHMooPstX4ZK3kbAPDTgOdjyIDFY9GI4H5LPGT+6wZfZYXEncpqruVcPZ8VMiU75NYlS07erzA6eIQb0ESUY15hSynuy11SrkMQYXGev8EqsCcg3wNmBI0QDbQ2sI3xUI675pm8cYlXlIQ395zXLcj7VdLCa5euCC8Hmq25xnzX3eEUWINIakkBk7jwMZoQby1VWdU0BZckeQKhJBM6y5aSaH5hNt0SnUSqpW7rs8LZsQt3jX2Ui+YvGeWuM4oz6CVy/eSA1qRfVXY20li/JYkTf+VX4YoXgUmuACzNTyChbMZqHP8Q/znLkEGWPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vYefZq1Kji++ENuMNeN4dsMVnRysysPfLivp5ZCp2Ho=; b=bKyvCc+W5OrKQW6/Y/zD3cZxppJEkUmxf2oiB0CXLpAf2+XcnyfQTcvDdlV7rGUlDvNKHLox4hez/6dywCAHYHKPs9QUxidXt8SQfympAL6JyNxtLg2BW1unN9qQlP0FW8hKcGIJGZSRFBNLhurJ5IgiwlxJC57+maVMPe6kUEU1oOZlfZ7DtYAIQi4q0tgsRD2cdriwvjaCgRLWB4n+rp8hcuJ/7ZdMX/adJgLSgItWepmsClcnXP8xojphrREwS/RKdEMcDhveuI47iM0CcJkMU+JhMgDwUJ1A8QkJPIPGthDYAerTEYPBhIXRBn7Oi+qqRj0UuDR2XRZvQWCRwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6302.eurprd08.prod.outlook.com (2603:10a6:102:ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 22:23:58 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%3]) with mapi id 15.20.9160.017; Wed, 1 Oct 2025 22:23:58 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mikhail Kshevetskiy , Andreas Gnau Subject: [PATCH v6 03/13] spi: airoha: add support of dual/quad wires spi modes to exec_op() handler Date: Thu, 2 Oct 2025 01:23:36 +0300 Message-ID: <20251001222347.3386506-4-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> References: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0447.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::13) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: 63033376-9479-4f2a-c76b-08de013936cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rOqq+wgpkAjZshEVcvDFxXsezWfzIISgRBWf/rDPbwUxRR62J3/RdoEhT7rx?= =?us-ascii?Q?9BVI3lfzVk3ZrPHePQZfswHxJHblQxieGnGZXwiDnbt4mCFRT6mF8qlXsZkl?= =?us-ascii?Q?62hnJv/L5L+6CUN5f+rKtP5a2tdAK++7BGge+PWW+TVT7iE/qfGGovmOLtT5?= =?us-ascii?Q?na8iOSmmjlOT82e3uba1WgcwOzOhnNAkA0e7wyL2kKeBd32Nv1BYZ/NIflt5?= =?us-ascii?Q?yC1mSg9Sn1Nhqk/GxEkoEPzUF3fiw/3LxavcMeU0eV0DwyB8cThvOL6sQ0k0?= =?us-ascii?Q?Za+uAzfPc6N/oDj6e3zwIcwwws3bu///cCBZkKoqAJG9BpgWOgy+HCTxPRWD?= =?us-ascii?Q?UdrLhBlSi1cHzMMpW2lWD9uVVNz5a0tP6K8DP0XNJ79/i3BhegwTs+UG5UeI?= =?us-ascii?Q?9nV59hRWNfr3PYL+sSIGHUQCjSoKAalIGpp0pFrtRv3eeeU+ABabx1m5fWt5?= =?us-ascii?Q?4/YaOzmJfM16mFR5xg/ttbwLlsGmaj5RTF4DG2YwWBXHj1LytpZB07qmOpLt?= =?us-ascii?Q?cL5+vbgmh5U9DOe9tn2ogE9Vx96+fIiTfaa+oH0SbZsaw+SfoaVanrlfA4dS?= =?us-ascii?Q?HHBwKdOuQVdDDGSnqwNCBr9KRDfDsgh2wUFoqgrIbQJCuB2S7A0AzCrXeb/l?= =?us-ascii?Q?c3Hrkm7D/l1n4FfhGVbrQaTly5uPCaITjqdypNieQAjkwljMcdtE6USgGvdA?= =?us-ascii?Q?Nzk5b1ju1qe0dOtkLkCt0cvbdvFbHNrSEUvC3xGR0kSJFsXAMpbKO7gHXWXY?= =?us-ascii?Q?akDzvKrFGyz+zFuGSctglLv1aH9FrH4CHO04jz7KAPofWqV/HBGM0PElvvzl?= =?us-ascii?Q?VbrGs+bRWPb5PnisX1U9upvR2tDNKYC75d70ryPCDOBrxTNfsWb7DBY4LAFy?= =?us-ascii?Q?hzC62+O5sljojdYQn3ZGkgtwEZpxIQ1hnVKYgH+ChDYMXQvl19n5MenoKWvF?= =?us-ascii?Q?pUo1QGxhOpgd2U5A5kFx/MPzuIHVwWJfVuOSjykPEfMucl4UoeoB5OdtokdH?= =?us-ascii?Q?CXd0G3jEaxEXuWqhRPZHiDMJ3/8d+U7xz23dImoRxaDKMk+NZaYRVL9e9eBl?= =?us-ascii?Q?wdTYeXgvAVlWrO4cVe143uZvk5rY+DOHcbn09GZVRZLHNGmJZf1hicvG/NAR?= =?us-ascii?Q?BFYE8wqDf5stHqPT3dsnrq28uur6ot3K7ICNoVnnVhmc0CBcih2zva60AC9o?= =?us-ascii?Q?VqvkS/AEW5UkkXGgzkUTCpiHdmuIki0BzvCw72ZpYwzrsxiH5zLMmzhHVi2F?= =?us-ascii?Q?I5VtzrnSha46G9Co6ImLMbiwENZw2DdpqWPL6LtWP5c4rjR/5I00om7J9kKA?= =?us-ascii?Q?/F0Awag5YKEpfpPqdy6jchdGwuBoTSgNJ5kpXJ6Rh4y5xlnpbPux70YVcL/d?= =?us-ascii?Q?mIkl6WYsTfYx3/pQr1xQQ0eCw63yJ/hG2QHO0QVSeWiVHgEp7CPwaT/HyEbE?= =?us-ascii?Q?yL6+N1vEeBPLqk/yIPplvVJJX32YSic85cGY7Ow3M4mwicWa6BOHlABpvMhA?= =?us-ascii?Q?L9WIQmJDXAXS0vzLG3pF7AzDYSYGB87xtPll?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pyZ/rKCMJZnNsdSrmprVMRAEFwgWgSDZg6FHC4czZO/up1VKQ7sI1m2QB4SN?= =?us-ascii?Q?rJWyKv3ffriDltgkgbO2xgGoagnagWczmPgwzkXuhHj74ypuLKB0Zy/9X3UT?= =?us-ascii?Q?n2LdETGzZLwgyQdyD/9VLuamMvRA+M7MjVDcdULFUsdEaEqcuBoCva6N6gfD?= =?us-ascii?Q?jyDwR4F0KhVxX/n1+SzWb88zNK7Q62RfuH+WSTNDNc9pFEllICPru/UQXuLb?= =?us-ascii?Q?dnjid7POQErhIrXfKUdVzXuzBamo/DQBKc9EHcvlhP2mAuydYuv6do2lgi22?= =?us-ascii?Q?8U+sqPPxHJ6CW7pf6KJWRPz4YyKmHFubQ3Jh30gtBRkiSPPwS8CrrotbnRxz?= =?us-ascii?Q?tDQ/JSz8IUKx061uEcz/x0CTgZyictu1e1/cVJogWy/YdTb4CqpqZC/LohLt?= =?us-ascii?Q?Ewnkb9blw/E08jSflarod3dg3AGCFKAmHcvRNUX9NuH0MXrySB2GOfkAdak6?= =?us-ascii?Q?ZrOb8/Gak8elOWml11AxD3s1oI1UU36yzca+qG1WQANUyLIP8KEhkeq6T1z6?= =?us-ascii?Q?+XiVicawkp+DTxT+KgboUsU8Y9NV3Lpzr4Hmw3dStSLj+E+cox3Du80C8REU?= =?us-ascii?Q?/nazezfJtZEl7CKrNI6/WVrkb4h1uD25EPdOxe+5Qi0QL4HHglsLCJtHQ0Zm?= =?us-ascii?Q?AuXHZtPCfxEUmFMPk/vj7AnNFpbCqcL4KxNP8CX4XjnE2epAOFaQhXIIQh+c?= =?us-ascii?Q?O/QX0pQcU5iPNNjd2C49OjDOLgASSXD9T9xujWrFbGuEmi0++oQ2FQN4BRCt?= =?us-ascii?Q?9ongOolY7Ud+Yg15SsoPvV8B0M/KyufPhM6o0NUoZruNYSRl09UKq3LmDymy?= =?us-ascii?Q?UsZ624FquNPRDD35x6l76eP2a3rfGVVtNJgBpolJm88+Ym+Vy7K/IplUajEy?= =?us-ascii?Q?UR0qtblIGtpkG7BneIwz8K57qUTuqbLSJfjAjSk9v87UuNU1YVcJWDYj7NIQ?= =?us-ascii?Q?NwkFtnk4gU445S3Id8YPKd+7zHSYUi9k23bQhgQ5Jz+mOtk2d7Ga0ZD6lW5Z?= =?us-ascii?Q?ydgw5gfilKWbvHZOiKt2TaUxBrDh+REt+xzvtHOdWbBocSx9x1FoGZtiXrLm?= =?us-ascii?Q?dGo8V5PpN+g4nzQHcfdmKr8A62ELTlitxwBWnuYnIeiqTEqFdEZY4AfDpLEX?= =?us-ascii?Q?p0FPMC1YMJiv2tnoI0lm8ZNqKmELPAFc05WvwpnovFC7vVh6cQYHN3YgNiAA?= =?us-ascii?Q?bxFFWDQza14wXlRQAGIymqdVOck9oWKznWwFN5MRxbyKZnEPGcv3MuxgZvc6?= =?us-ascii?Q?A9m+80wdG2ZW9eTrCUWSYovU5YPVzy1EXMxV9w49tGuKNUcOWYstnyHlzgSQ?= =?us-ascii?Q?p/9cytJy9XpCaOv/5BTlVILfddi9aLoRm5zzz4Xb7v6NTFSyBMZnGj+C21C+?= =?us-ascii?Q?ScCR+LWlkc/eftNlORfaJm4CMXfLe/G8Kvq85I/3zy6gufLNS7ArI/4fIyUS?= =?us-ascii?Q?lzg9o4FPmb+y1aDRGdja7bBSVBngOuYd3G1WrURKiZ+W7hTCuL8qXSRXznn2?= =?us-ascii?Q?cL5ICeCZYRIbIxJtGW/k4aUbKajabOSYUESwzIvx92yHntS/b6B+7GBv1yPX?= =?us-ascii?Q?jL177pI6SFxXbG7FwZgkCYmdzYxFGgqxidvMRGq+sKgjSDXmNmr+4KsUFNzS?= =?us-ascii?Q?QY7d8KAKHZf/HCHZ5zQmIQU=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 63033376-9479-4f2a-c76b-08de013936cb X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 22:23:57.8985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ky6rkYKiXOjijbts/2LaI9iBILsP8wPI4Qw11efU2F5hZy9YzLyeJ2xuLxHeFU5tudGn9vTBZQOs16tf/k7uZnjd4dk+3P/HvmAJolslR80= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6302 Content-Type: text/plain; charset="utf-8" Booting without this patch and disabled dirmap support results in [ 2.980719] spi-nand spi0.0: Micron SPI NAND was found. [ 2.986040] spi-nand spi0.0: 256 MiB, block size: 128 KiB, page size: 20= 48, OOB size: 128 [ 2.994709] 2 fixed-partitions partitions found on MTD device spi0.0 [ 3.001075] Creating 2 MTD partitions on "spi0.0": [ 3.005862] 0x000000000000-0x000000020000 : "bl2" [ 3.011272] 0x000000020000-0x000010000000 : "ubi" ... [ 6.195594] ubi0: attaching mtd1 [ 13.338398] ubi0: scanning is finished [ 13.342188] ubi0 error: ubi_read_volume_table: the layout volume was not= found [ 13.349784] ubi0 error: ubi_attach_mtd_dev: failed to attach mtd1, error= -22 [ 13.356897] UBI error: cannot attach mtd1 If dirmap is disabled or not supported in the spi driver, the dirmap reques= ts will be executed via exec_op() handler. Thus, if the hardware supports dual/quad spi modes, then corresponding requests will be sent to exec_op() handler. Current driver does not support such requests, so error is arrised. As result the flash can't be read/write. This patch adds support of dual and quad wires spi modes to exec_op() handl= er. Fixes: a403997c12019 ("spi: airoha: add SPI-NAND Flash controller driver") Signed-off-by: Mikhail Kshevetskiy Reviewed-by: AngeloGioacchino Del Regno --- drivers/spi/spi-airoha-snfi.c | 108 ++++++++++++++++++++++++++-------- 1 file changed, 82 insertions(+), 26 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index bcc464ec9c61..fffed26ff990 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -192,6 +192,14 @@ #define SPI_NAND_OP_RESET 0xff #define SPI_NAND_OP_DIE_SELECT 0xc2 =20 +/* SNAND FIFO commands */ +#define SNAND_FIFO_TX_BUSWIDTH_SINGLE 0x08 +#define SNAND_FIFO_TX_BUSWIDTH_DUAL 0x09 +#define SNAND_FIFO_TX_BUSWIDTH_QUAD 0x0a +#define SNAND_FIFO_RX_BUSWIDTH_SINGLE 0x0c +#define SNAND_FIFO_RX_BUSWIDTH_DUAL 0x0e +#define SNAND_FIFO_RX_BUSWIDTH_QUAD 0x0f + #define SPI_NAND_CACHE_SIZE (SZ_4K + SZ_256) #define SPI_MAX_TRANSFER_SIZE 511 =20 @@ -387,10 +395,26 @@ static int airoha_snand_set_mode(struct airoha_snand_= ctrl *as_ctrl, return regmap_write(as_ctrl->regmap_ctrl, REG_SPI_CTRL_DUMMY, 0); } =20 -static int airoha_snand_write_data(struct airoha_snand_ctrl *as_ctrl, u8 c= md, - const u8 *data, int len) +static int airoha_snand_write_data(struct airoha_snand_ctrl *as_ctrl, + const u8 *data, int len, int buswidth) { int i, data_len; + u8 cmd; + + switch (buswidth) { + case 0: + case 1: + cmd =3D SNAND_FIFO_TX_BUSWIDTH_SINGLE; + break; + case 2: + cmd =3D SNAND_FIFO_TX_BUSWIDTH_DUAL; + break; + case 4: + cmd =3D SNAND_FIFO_TX_BUSWIDTH_QUAD; + break; + default: + return -EINVAL; + } =20 for (i =3D 0; i < len; i +=3D data_len) { int err; @@ -409,16 +433,32 @@ static int airoha_snand_write_data(struct airoha_snan= d_ctrl *as_ctrl, u8 cmd, return 0; } =20 -static int airoha_snand_read_data(struct airoha_snand_ctrl *as_ctrl, u8 *d= ata, - int len) +static int airoha_snand_read_data(struct airoha_snand_ctrl *as_ctrl, + u8 *data, int len, int buswidth) { int i, data_len; + u8 cmd; + + switch (buswidth) { + case 0: + case 1: + cmd =3D SNAND_FIFO_RX_BUSWIDTH_SINGLE; + break; + case 2: + cmd =3D SNAND_FIFO_RX_BUSWIDTH_DUAL; + break; + case 4: + cmd =3D SNAND_FIFO_RX_BUSWIDTH_QUAD; + break; + default: + return -EINVAL; + } =20 for (i =3D 0; i < len; i +=3D data_len) { int err; =20 data_len =3D min(len - i, SPI_MAX_TRANSFER_SIZE); - err =3D airoha_snand_set_fifo_op(as_ctrl, 0xc, data_len); + err =3D airoha_snand_set_fifo_op(as_ctrl, cmd, data_len); if (err) return err; =20 @@ -895,12 +935,28 @@ static ssize_t airoha_snand_dirmap_write(struct spi_m= em_dirmap_desc *desc, static int airoha_snand_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) { - u8 data[8], cmd, opcode =3D op->cmd.opcode; struct airoha_snand_ctrl *as_ctrl; + int op_len, addr_len, dummy_len; + u8 buf[20], *data; int i, err; =20 as_ctrl =3D spi_controller_get_devdata(mem->spi->controller); =20 + op_len =3D op->cmd.nbytes; + addr_len =3D op->addr.nbytes; + dummy_len =3D op->dummy.nbytes; + + if (op_len + dummy_len + addr_len > sizeof(buf)) + return -EIO; + + data =3D buf; + for (i =3D 0; i < op_len; i++) + *data++ =3D op->cmd.opcode >> (8 * (op_len - i - 1)); + for (i =3D 0; i < addr_len; i++) + *data++ =3D op->addr.val >> (8 * (addr_len - i - 1)); + for (i =3D 0; i < dummy_len; i++) + *data++ =3D 0xff; + /* switch to manual mode */ err =3D airoha_snand_set_mode(as_ctrl, SPI_MODE_MANUAL); if (err < 0) @@ -911,40 +967,40 @@ static int airoha_snand_exec_op(struct spi_mem *mem, return err; =20 /* opcode */ - err =3D airoha_snand_write_data(as_ctrl, 0x8, &opcode, sizeof(opcode)); + data =3D buf; + err =3D airoha_snand_write_data(as_ctrl, data, op_len, + op->cmd.buswidth); if (err) return err; =20 /* addr part */ - cmd =3D opcode =3D=3D SPI_NAND_OP_GET_FEATURE ? 0x11 : 0x8; - put_unaligned_be64(op->addr.val, data); - - for (i =3D ARRAY_SIZE(data) - op->addr.nbytes; - i < ARRAY_SIZE(data); i++) { - err =3D airoha_snand_write_data(as_ctrl, cmd, &data[i], - sizeof(data[0])); + data +=3D op_len; + if (addr_len) { + err =3D airoha_snand_write_data(as_ctrl, data, addr_len, + op->addr.buswidth); if (err) return err; } =20 /* dummy */ - data[0] =3D 0xff; - for (i =3D 0; i < op->dummy.nbytes; i++) { - err =3D airoha_snand_write_data(as_ctrl, 0x8, &data[0], - sizeof(data[0])); + data +=3D addr_len; + if (dummy_len) { + err =3D airoha_snand_write_data(as_ctrl, data, dummy_len, + op->dummy.buswidth); if (err) return err; } =20 /* data */ - if (op->data.dir =3D=3D SPI_MEM_DATA_IN) { - err =3D airoha_snand_read_data(as_ctrl, op->data.buf.in, - op->data.nbytes); - if (err) - return err; - } else { - err =3D airoha_snand_write_data(as_ctrl, 0x8, op->data.buf.out, - op->data.nbytes); + if (op->data.nbytes) { + if (op->data.dir =3D=3D SPI_MEM_DATA_IN) + err =3D airoha_snand_read_data(as_ctrl, op->data.buf.in, + op->data.nbytes, + op->data.buswidth); + else + err =3D airoha_snand_write_data(as_ctrl, op->data.buf.out, + op->data.nbytes, + op->data.buswidth); if (err) return err; } --=20 2.51.0 From nobody Thu Oct 2 00:53:54 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020102.outbound.protection.outlook.com [52.101.69.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AABC2D9EC7; Wed, 1 Oct 2025 22:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.102 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357447; cv=fail; b=qwPCbw58Ri3lHWZrvj168Ia1ywZdRjiwE+13Vh4e7QjAAIUQagONMoiP1cCZJ2sXULGNhauGkRqBhL6QWP5M4qUbIpFJzXUS6PBFkxIw5dZQEt5I/j1R0xoiiUoAeTqwabcs5bq7wxopk0Ce/djM5sgNwo7WuSYeGeMHniL19BY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357447; c=relaxed/simple; bh=ln9Uv+JjcDjysM4q50VJX3fGqO1QoWoTBi9g3lH9b7M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Q3EEzp3BUcWTMUL0GzK1LDFnhax1U8idSsnrFKHuSNuzA/Gu1e1xEYjDszkt+ZbAewLinf9lybn/xYDJPB5rAlQv52JjjRn/yrLzF1bszHJfhkHvkN0qDiaHek0TBLJNJ7+3X7SrkV4BMqeboh9ImvWMtr1FLJnEkeZbFTvs9b8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=HSctmQZB; arc=fail smtp.client-ip=52.101.69.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="HSctmQZB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qoQbSGyWkPU3gzRTzMTzlSL3kRSr7wNtgF/NM1WPTu2mRQKZ4dhH8e1ebgpDd6VV5qIJZ8Cxi58Y87gwShpPAhkc1zsdoD9/eg5owROs9u4SvWZyvgxFQeT+pqTRLKHCNd+geIvwXtmGyGfXDyhIh3t9dUzpc1bH0WlIFcN0DbEjAJF9acOdE9/xMydLpOol7MLzbHfOVB6Ei+sWTLKZm6HYjtxG6URjQCi5lplIMF6fXMFxvj3EYLIKFc93xh8LLMVzIOW966UyNh/ZeeDvwmSlMJTw/1mly5OcsRZP4g1ntZs+4Dy0xplmMY1ZddxR9p67FZt+uCjuLqFtfRt50A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oRs3E6XYJFP2n905LhT/DxgKVk6bbVkUK5bfx5yHGus=; b=CtLxFGoWKfcR4dNUnEtI54UoKSkwnlhPi6z8SWzgac6hQPxNvD3ymm2Puz/wz6INR7OzJFBQygtms19yvNYNnPVWv3+N6nJ8ZoktsMfVfQhbg7saHuw2cJk6PnQLi+O2U+f3kRJ6A0aCltEDuBFpk9qXh4F41aJUQ1+6ujNOSWN4C2DcN9GC0fKRj1E9Qjt3M74Q1VdXFZA5Pk0iZD2cuEh3XekeR6gThTFpV3FmR/1dPBKSTtWBdHjDxw8xq7lc4wSqoPCGQFLfpEbrBIGJjqWDULtdz3iQ8s7nwr+X+AQ+4Q4S8QqCpLQBtr4y1893+5/S0a7Nh5HJ586RijM7zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oRs3E6XYJFP2n905LhT/DxgKVk6bbVkUK5bfx5yHGus=; b=HSctmQZBW8UZdXTzZSMTL5C9NvUNJ+AzIinYkPZWuAuiRDMhPRMpa6Jh/mXoIBrOXltypjGKlCuRIp752HGOxVKWh0V6tzNTJ1Rte3cAFsJ6njBmPPVrxDxMCouoddIEoR2eD2SW96c/hkm2+h7gj3mIlOeAF0GoF7s/RMRZSXiBtYjvBIGpv3oN50UG7J5CunGgK43iw7gfzlzOIqL26G+viWPUS+C0FbLFaAMCTzzLNDkEzxwWhHQJYHBfLoaP8iKkRBaHZrrOLXlOQhHXeft78TrbtaXUNBhGGq1tAps467N83cOZEufmj/B+Lr5M5f8tMMMedUg8wYWmsAtlKw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6302.eurprd08.prod.outlook.com (2603:10a6:102:ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 22:23:58 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%3]) with mapi id 15.20.9160.017; Wed, 1 Oct 2025 22:23:58 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mikhail Kshevetskiy , Andreas Gnau Subject: [PATCH v6 04/13] spi: airoha: remove unnecessary switch to non-dma mode Date: Thu, 2 Oct 2025 01:23:37 +0300 Message-ID: <20251001222347.3386506-5-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> References: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0447.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::13) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: 5039b2dc-f225-4861-b946-08de01393761 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?VJPsiw7nybdNAqATjrRw5N4EKN74G2Zj+++Nqa/azlmqHRMLTJA5ePootN4Z?= =?us-ascii?Q?ojLO8H8Y6vW4fOksD5CHOADZgmTu5YHN77M5FzzM5E9dmb4oycwTVgseCI8y?= =?us-ascii?Q?gf+JDNS6mKESCV1vtCAD3OYU2lV/WzBOjtWx8pKcOYmBVExJq39TqMyfqBtS?= =?us-ascii?Q?f9GZKZPb6VALeKcsrCFA2MPcXUmjU59JtLQ7KEa+Ina27N6muW5m5tOYvczg?= =?us-ascii?Q?45HyDr0hX/EMnXGKb4029zezhLbOLinDPE29H746vi6NJjccPKux4O17fVRN?= =?us-ascii?Q?tBiqeE/mM3Z1sdP+5vNBPNeHFdGcwuWvfzJrYZtHLVYJ00q0CdfNaBhC4dwV?= =?us-ascii?Q?zcVWiXcTxFsUiZSO37pHYr1Wu8+zZ9dToQ0ndl0Db1ZQuE+wmngVdL9yilsK?= =?us-ascii?Q?gUVs1NJcyS+bGL5/MyiWSqAiKWdapRrg36CHBBhY+ofuJxqiP4PdjIQlccDC?= =?us-ascii?Q?4ScrPDDgGCrXRAzVn+kun3ornEnrtqWFCXKQtijSsmFZXLBZA1dL2HUQu5C9?= =?us-ascii?Q?sGNEOPrqbKseGLiSkE8joJndNFGyq8H4PR9yxF1slJIOGlNyiChq5ieNPjtb?= =?us-ascii?Q?ryUy+PktO6fDp1ygfOfL9noX628iuh/DnknM+QYW0syaEP6T/QxjBkVLMYDx?= =?us-ascii?Q?r7pQvyD7uOSm2pjPVb/ZqrFh+01wHIOebTgIOrDvxC+xlKfyHyyCZiFT5p+x?= =?us-ascii?Q?OV/8cEzmNuAY+IJwR9RSA3oJ69rNV12VaxtN4Bem+pr2wPrzEvtY62Fbh+pU?= =?us-ascii?Q?lvthcXY2APEqDf+a29F9DB4XCU53QIPQpIr5D2IbPIE3ArJPPTtgXOGppvlu?= =?us-ascii?Q?dX2mUL9f8ytU+czWa9kEFUbXypWDHMETomxLK7Q5inwytrzuTWHYlpV4LDyu?= =?us-ascii?Q?hcv750AlA3EV42YixzmIk0jV01fHaJXCMdXjP1TyPXEK2EnQ3tmTP7Q3AhPE?= =?us-ascii?Q?OMFsqFW7cxduLbJWwtGoxgiAbNLl9picEn16Q4fZjKKGXdDsGP/lq2HoefO3?= =?us-ascii?Q?BvaR0lk0HjKZk60hbisEvibDfkyVIh2WoK6bjCv3UY3HSWasEEliHv8c8keu?= =?us-ascii?Q?u91sS+lw/GlgK+OQbSqs/p6Okf5qtcrXO8Bk30lPgc3D6pb6Q+SIweu4wkuB?= =?us-ascii?Q?7TMsNh1uk4trVJ56yCWLEdsul5IyXKCBzb9+8n0/js/rg2lhQZ7Mvm5HbF5H?= =?us-ascii?Q?J9z7E2sNO+k4yCFYw6zi8+KxpQjnZbastpax4g0xPrT1kwjws3Y9Aij5B0n+?= =?us-ascii?Q?9cPBJLTqOyiC4qADWT2v8DzS+6EubMbmqvC92MFZxFhfMkX86cxfsZd3ITxr?= =?us-ascii?Q?PUA6SaBGUUUnaWRzQ14Y6/haKl4xVdFmzFuV0bzlvhYZOgyeFuonEWLXaGDg?= =?us-ascii?Q?+XdoDRvu9I5X838eutDPQvvXKt7tUfrMpDAz7Aj9HRklYkAXFCc35HskB2S3?= =?us-ascii?Q?hpBix+xsb4LdtH/9YHTQLWtjBeKqIphsaG1VebD+g5pCOZ4EBDDD5NYwQGVB?= =?us-ascii?Q?VSdjEhGLJfWSomE1ff22xt7/80kmh6tjy7GS?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(7053199007)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c3RrVsq4IKOCjTd6VU1LqvlwFG4r8eqvQa93TkhDvX7oQ35F2JVsedWxXiJL?= =?us-ascii?Q?fwXHLNeGFKLhm/ZyvZtB8vi8D2/EzflkBk2Ze3LO/9E/ofJDkgTlNNyc8m9h?= =?us-ascii?Q?zzmzP8djARbO1h8dJMQ1jPcWnSoY0doB0GHhMHrTGbIF7k8EG/cNzgQk/kx+?= =?us-ascii?Q?QVQgQWrLG78XwPzAHjNAyqIYKhObhpeZqgK+4NQ2QijZqLtp9QOPZSg666po?= =?us-ascii?Q?NpVVmyiRKugLDZODOBeNRNAX1nhN95nuzjSOXJcfHJDFRNvcx2uc8wnTVAwP?= =?us-ascii?Q?bs8cDAPg40oJa3I2Cb0UwQNpy6X8reiFyqY54SE97npTYY3jqx7u/hrxIS2k?= =?us-ascii?Q?17GxCVnfWfSe9RS1izA/ZQTjCYrA3NjYwA8ddkTYid9+RFdAQ9IXehEvKyY1?= =?us-ascii?Q?IwH18OfJEhTWFY03vaYrp1KnMLwdnsqo+CpD94e7SwBxncC7JmhPuMlgrUVW?= =?us-ascii?Q?ZeT5JCFZq7ZRjpgDsLm7wUKImtq3IY9OgCdwiybmywOTP8u2dwV683pWL9GJ?= =?us-ascii?Q?jEgZA42VIt1xo2X7LdCoR581sC8aQppUoDZpLVAPn7BR2IPqBEmVU7RSloBr?= =?us-ascii?Q?dyqKm2SEMMKg1PcMEZvHS7ulRfuIrZl2EuebHztTHgBrdAPztRU6zjrIxUt8?= =?us-ascii?Q?SRd6LvSkbsSWpwySVS+jx+A+mK7uT6CA7oxUvNcxdOpwJPxaQlzu6xeIUSvd?= =?us-ascii?Q?2AZXZ9ZcIVwXudLUhSUHL76D5y/zZw543eyGKQf7eWXKQmFcvbh48Rj7aHq0?= =?us-ascii?Q?fx2XmwEpvb/Y/0fIMi3GUmwwwRLtCTW0mo8E3B3q9PvlBS7F7zNYNZdGdqJE?= =?us-ascii?Q?5cD/jD0EiAASuZ+FpcCwYfTZ+/BXHF9mpXOLuUddIV5N0nsib0Bjex9Uvjzo?= =?us-ascii?Q?GIOvaYqf1WaBymifkkn3mYg3gqiQRqsQcG8DPSZ4+9pOgDIyeRBMrvlCA4cV?= =?us-ascii?Q?nMq0BQsNVp7Jr6ubuw8dGATAxpbOYwrZ0BuIDnAk2JkwpDxRKHXDh49TTrWx?= =?us-ascii?Q?jq/kdT1m0bV6LCKB5YiyZGOSt8Lqn6/01Px6mBP2HERsE+DsyTHimsK6h1D1?= =?us-ascii?Q?xB6W+6R2rm21JSw1cXWD7yauXSM6ULjWAXzPSpIfTT/P3UDERYTqk/REutfH?= =?us-ascii?Q?bdE9DthtzARSJFMN8o1JD6NhSHVaZYMgWqhFz2SCXE/evq1TCaJ+N0K7AluM?= =?us-ascii?Q?SAnNh76Ocu8AveTji4ff/oFYNL9i6F6/YvbOPi0tEADtcW+gxwcn0DFrCgDc?= =?us-ascii?Q?Ipjk9wZQHuWRUZIU7nWjSapUX0E8qM9Sa5AES0Ji7QHKqILgeTeOc+7S1iv6?= =?us-ascii?Q?zJEeuihijfr+cWXGG8RwklIo1IjYTW9Jop8LaAKdkPdLXbbYuJPdG7DqPH99?= =?us-ascii?Q?5k5WDO+zcOUat4QCUyrkvQF+fjLA+utJVucs0Sy28NFYi3sN7O2PpYKunOoV?= =?us-ascii?Q?eWGCUvXn4M/EeTW1ZYfWkGkoV62i96gL1sUHBJ//04BK9pr5hVw30zqlKJgZ?= =?us-ascii?Q?wFO2ZANI0VYIopsAZXlno+2SzcgSdgLSMnKtcx3Nsm/TO6R3K0BM7yEv9mvB?= =?us-ascii?Q?Zn7i374ZPTa/SbkMJ1zJFpcohPD/RZfTo361iU7H5qa8CF4Zjl+ZgqOvWxmW?= =?us-ascii?Q?FT5mMJpYKKfMnXBygF1I5rQ=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 5039b2dc-f225-4861-b946-08de01393761 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 22:23:58.8742 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: spgdjfTe2yGtGHzQw8UQWN9Trr+sKM/jht39YhiUKV+ngc7ykDzRS2UTySRC7MSqXm5D92XdEuwOFgCmmBSNIknLd+OFGXrLixkjOZvpGas= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6302 Content-Type: text/plain; charset="utf-8" The code switches to dma at the start of dirmap operation and returns to non-dma at the end of dirmap operation, so an additional switch to non-dma at the start of dirmap write is not required. Signed-off-by: Mikhail Kshevetskiy Acked-by: Lorenzo Bianconi Reviewed-by: AngeloGioacchino Del Regno --- drivers/spi/spi-airoha-snfi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index fffed26ff990..2d86dc62dbde 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -812,9 +812,6 @@ static ssize_t airoha_snand_dirmap_write(struct spi_mem= _dirmap_desc *desc, int err; =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); - err =3D airoha_snand_set_mode(as_ctrl, SPI_MODE_MANUAL); - if (err < 0) - return err; =20 memcpy(txrx_buf + offs, buf, len); dma_addr =3D dma_map_single(as_ctrl->dev, txrx_buf, SPI_NAND_CACHE_SIZE, --=20 2.51.0 From nobody Thu Oct 2 00:53:54 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020102.outbound.protection.outlook.com [52.101.69.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 921D8311971; Wed, 1 Oct 2025 22:24:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.102 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357449; cv=fail; b=u945HkunO53xTpXVYoj1cgDceC3nAY/MYZ3IAaHvbyUs7gjp5LRAuPijhrXcFfL9pN4dbuJCu1ktudZIG/GXO8Ul+5JD5yL9FrAWOjcD65v/l/DtnPWDSjTKE6dzRtb9YY/stgnco9zKQvR7tffCxfwBUZJ8tCnj/cIhjyalVgI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357449; c=relaxed/simple; bh=E2M8lRG6zN/Y5R2EJPWZ8XXbtiAD084miYqnGi5jqec=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=kJ11VwGV98P9m2BCT75s/o9UXiUQ6FtZ/eagW1Oxg1RHuqkfQsmi199IamtaocpVEm72fRzqOOafAgCvy9yHQCei/kOpHmOI9tdzgy6PFDBOUROvXSZxU2pulF0sS/YWjk/DIibon1onSzqPosKfoW1ueZ5CF6h60uM428SnUG4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=aEejbtrc; arc=fail smtp.client-ip=52.101.69.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="aEejbtrc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rzxAsi1XqxRYsSKTo3zwuk5X0gmXpfr+nsZ57xAhuL0+jFVsu+a6BRuvvvmzf5gRsAVsG34oxiYgVQCPqmyiCunFy+R/7sf9TwbaDkLPYdm0RDQyKibj/fkzicZPatezaZpQkWEwIJv44v95DfV+IcwsrzGuXKJR2MirmI7E5zVMQsi6M7cFnAuwtdGfisVcwoW3neickyse8BgJmm6rqh/r9cyZ2F0tB1PRu2OTzvvPo72hg37KnwyWXkOAzNN6WMs290/0cr+Lo5FQZPvMRVwRzXdhL2Des14nQ7gpmTsvUcha6UGy+rNMhG/5k5H8IamWn3YG/v0xgUPZsVGy1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2snrpNrzRAzTOeqpJ8KPLiTOapJVIgdfhM9IUrv732o=; b=snRpV1re514AWLBh7UFlIMD+0N2X86C41OAUJP/+Db6R1x8Vq2d4rjz0FZWW54NTUF9zNVvrUeMT9Fy3UPs5kGihwwim8rbHc0SdP6wqSpKSEVB75ZBcw7iRFtqUGFWW+OZi7E7IwiO799zHqtNF8xCOmy7ogxNxTFxzt8qsmxKIlPnfUJ+qpIIjJtIU3CZKJm0W8b+7Rr0GHbNMJ57cVqFjDhLlpnF4LzuD/H0M9C8VYCajOKz2kQHHGkGvUSLtqZjZVfIA+gd1ZZUELS+7Wc5dyrVkuig4vEDQ7BffGVtBUmpYO5o9mrVxSvUf8xZWjgpfJXXnxbU/vUB9wp3CuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2snrpNrzRAzTOeqpJ8KPLiTOapJVIgdfhM9IUrv732o=; b=aEejbtrc39eZ51o+lW3hkjegiPY4U5H5v91I/euMpuJVOMrPkn0ZbbIYshbKqBYIGEwT/xN1tyV00HBgg1Uk6hBQBuIJiq4MVaYy6yZ38SmUSM+wHfNMYYsHL1AqsrpQvGag0nE7hC84XlIiuiyC+OxtxrPiWm3BPKE9a7C+0mr7ERpsVj/ghXOCtY1bcDUrBimbc2MZEP2MIuqrvzVjeK7uuO1/HR90ojiDzfjG8DbSUlloK/j7UEqCdTu7/EmD/kmbEo0f/4kmHCZH/4C0QWidLiYkDlbUxWe9UAQOrTveKa0GtN4wEfGZ31KgmVkfa6Jht4kGi3j5qCHgQS1+3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6302.eurprd08.prod.outlook.com (2603:10a6:102:ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 22:23:59 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%3]) with mapi id 15.20.9160.017; Wed, 1 Oct 2025 22:23:59 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mikhail Kshevetskiy , Andreas Gnau Subject: [PATCH v6 05/13] spi: airoha: switch back to non-dma mode in the case of error Date: Thu, 2 Oct 2025 01:23:38 +0300 Message-ID: <20251001222347.3386506-6-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> References: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0447.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::13) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: c2b8a3e7-8582-4572-7cf3-08de013937f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|7053199007|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GHtdUTCXWkZKxeN9QiJjUBp1Z7IpqyXfSV2/aBEgf0xH2AyzaqbmRc7IGXLv?= =?us-ascii?Q?lMNTqOz+MOhYofJAjkOVa8AvFNmp8dysdkeIQUhrXv2ikDIY4VshocJBd8qN?= =?us-ascii?Q?GvbYwVfOFXsD0AJrzcMWE+1Ywz25K/hypgZI83DR/c6CTdWi6Mz7PsNlR5T2?= =?us-ascii?Q?Xd2xokxTaDfePsMob4ThmxoVguAggLbfsHbKo2iYuEBNuIc5y/weSv7v8J2U?= =?us-ascii?Q?JlLp4lAt6kLN6tlR8069tiyc/M6Sdn23tSGG83+tzduIUZT+HUkspbm+OzlO?= =?us-ascii?Q?eDO8Dj6IHns/c0MjIs+2iWdHOyZ9d9MYlb1igaZjlsi2usptDXtIgJ76sBqb?= =?us-ascii?Q?HMikBDhtVoPKnMyp+hJ31hWnAh+V2G66p4ih9lSGGH0x/0LaBcJd/39J+GiN?= =?us-ascii?Q?gqPYHliJGpncws4pEfoU5B8gimguSC1PxVb0XJOtCXZ6/LOr/ORb0LBGTuZv?= =?us-ascii?Q?4j8WqnHpRJBKSNQaKPgUQ8MKA1jgqA7BvJkKIW9QlPm+qJATrM5AG7nlXbH4?= =?us-ascii?Q?gGbYPjfqsItDNhcBl+a99+UHZ4JCYWS0ePJKFEecZ4CZlNfJ4HWoEHxaPult?= =?us-ascii?Q?pnn+b0XUyVU4rvq9JluzRaX01QJBv+ezi+PSvSzmNnXoeSoT2fPFgpTm/0S9?= =?us-ascii?Q?4mypgfTnyWltfDv4epEujqOjB6J/2rd1kTBXsG1TKMaW6oxs2y9OdQrKdqmj?= =?us-ascii?Q?JKCTzbOlrjbWNv4tRuIh6fVHCDj5LIV2l/XyMPsTrTsZ6ccSDdlmQ+hULLSq?= =?us-ascii?Q?kdhERZktDGuwuCwYRM/7AiHmcQj7XrVt37YWgqIXUV34tC+i0xOYeXdyTC0k?= =?us-ascii?Q?THjnue0qalWDMVUy8QeQadkvNhZ0ppJRp1nHeN4mN0B/sqw8YcZnwqzq2sNW?= =?us-ascii?Q?zDoYxKIfpETLsu537YTMHHNjZcMuvWHr0cljLn1ZrDfkKRzn5hFyaqRJk1I7?= =?us-ascii?Q?YraxoqbyEu0GYrfiY+M1HW7ruML9Zexw8XGY8KlGpkKZRt9QkhQyC7yawG4g?= =?us-ascii?Q?lOWOC1UdaXbFxho/lPp/EaHkDic1IEvHQ9gp6QrUX/Iuu8R4F5YyIoes/kTb?= =?us-ascii?Q?XXIOyOkXzZdunpcEJF6Pk1i4UHKUj07qmADeNhSSipjIkSo2CSXIzZgjCLPt?= =?us-ascii?Q?sFezpkWxJ/DFwk74kZG7u5y2vPJKw7rT201teQHwxhosPKLsnK6KxcVmeMQH?= =?us-ascii?Q?s5I+ASZQwVFzS7VbL4SpndrPan2O+cfw88HUunwYs0j4MtKR0ovkGweCqNqZ?= =?us-ascii?Q?ZDo2BbmQe8hMVtMVeUgO6djL+D7nXlMllYlE7MRJyAZVKjcxAkiS5awn1e+6?= =?us-ascii?Q?ZvyTcIh0W9ZjsoCgLAssO1QXZkz8nzgCPdOjmd+IhOurWe2P+nX12nRV8Kg/?= =?us-ascii?Q?o5+xv+Psh103oqkJ/Mmz9+usWg/3ELLPH+GvPjAqNNBh2DTR2i3bsZsqJPw9?= =?us-ascii?Q?AXJj5qeZXG0CNvzcxZRoGRRc8/PJ0ChJafR4stmz1b94ode3TMxRJLzYblO0?= =?us-ascii?Q?1WXf+ekScekXjUzrzbwKvXk38zpKo87R9Z0g?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(7053199007)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lFpycQkiNyD149rPhTZu3uifE7seofs+QPQi5QHWatBQWDkuknykZ5X85cwE?= =?us-ascii?Q?OTiEaDUmVgwsKEZZ6Cch+fyrbINrKSZWJcAgbqZM3iL8ZV+ZZOYyQsiRvTjm?= =?us-ascii?Q?z2krRvx6/rXIPolQwM9uG5oGI9CNyvgYw4HvwocUNybiW5QYwubxBl1+9EMW?= =?us-ascii?Q?vJBlCQxN2HEF28SEs0ypp+XloXNVxchmAfABoM77Cx7ps8nQhC3YvFBS0XAh?= =?us-ascii?Q?31Muj1bqUMM3lFPZch4H0SBzG7sShrYQqp2qZaGhVr3/Yz7Su4TFQadXFVuF?= =?us-ascii?Q?1SwBRQownRZPopsNhfMDq3sQViTa2yC12fAYO2Pj6maCMcZTJiLDP0wke59c?= =?us-ascii?Q?cBcg1ZQ38JFXN1Nx4KAVyndR1BN1DfKRzT+pH4wFy+A2SwoYRAC5q3swzdzK?= =?us-ascii?Q?FIC4ofVTdbgVnhNj4Ds3PkE6F3ARM4d6EAUW/SNPpV96bvmvaXm7vtHSkyFW?= =?us-ascii?Q?Tr/QuCMCegdIB7rj6SdKu3YxBs/B54fBqcBlzgU6rzJeijlrrPsO9w8WL4qd?= =?us-ascii?Q?P25tK3qZVplWBMOr0OMFWyXYdjFK1NJlCiASeBdYpmJHewC58xRKeXfOgBN3?= =?us-ascii?Q?CDW8AkIgZKSj5PTdAN+VKbDJ++XMZgT+TQ+ANudVC1zAOg9XunMVKGeSqDSZ?= =?us-ascii?Q?iTPT4agxaEefziZ4vocYQc7KNS+OU7z0dYtcFuWAmSs1KyXnK+2lTplRsbBO?= =?us-ascii?Q?YFyc+ha4caO3aFiVib9zS8K/eXkmvXt1MSoF12v1Z0EN11IeaUF2bAQzVD4p?= =?us-ascii?Q?zCUfW0QJY/r5ojDUqJOv/gq5hnV8W67hYQNlPXYLCrqoB05zv05To/Y38lUw?= =?us-ascii?Q?g07X8eu4WrdG4AlqNdJoQ/YO/ubGuAmYxiSq8mDu0ZqxSJpFZ9H1xPGRVS8q?= =?us-ascii?Q?JQynjvNlD4sL+UIfcbib3ztbyU5ODrBV+tAQS0GwT29yHBNswtXF9qVCfHPo?= =?us-ascii?Q?QqiiFj4UPi/67qrjxw4T0RFDzOC1k/fiikX53f2HtAIIpuzRoXXN2MZ8d2iu?= =?us-ascii?Q?UDLPxQO8UbEia5s0YHBcsoe+GeOMNwlIO8qaZs3WRsvoFo5AzUo5m2nqHPbO?= =?us-ascii?Q?6CKg7Brrcxe3bJywuewNjo/vPPjoK2VBmWRFQhZk84in4AMH0jKbSH/SNmSE?= =?us-ascii?Q?fVXBaRkBI7rcuPWj4wEM61HCa4IHjmjIFqbm2KSb9vfDUOn/bkwxbtFwgd3V?= =?us-ascii?Q?tM8WZQY6HW9wsJglpClz1ww6+nCwx3srP0HFHNFUh425y12zZqfuzTOKqMBS?= =?us-ascii?Q?OwhYXC8D3NikK8MpDi8K2I3AVirH3d6pxwmMMZyhcRExdAxpP+hyAiER5Eh1?= =?us-ascii?Q?/kIFU6q74pY5ZwtMCStjP66pqq7le3mWVQdtIZvNXBpIisxgubAFDgvq1cwS?= =?us-ascii?Q?5iAc5caUIRmZwbitfvGNtR1V1HiKYvR1+kZceQDVxLJUdDXGxtZdEdvc/V7B?= =?us-ascii?Q?2Hw+z8v5m0F1k303q8JhDh/KU3UCaq0BWIlim2Wu3a8tvedEutyM0LQdAGIM?= =?us-ascii?Q?sj2Fw+Rw8UM2XSNC0CoKeW+LCu9p9ueZdd54AAk66e6azm5n5b1A+X9w6q7A?= =?us-ascii?Q?yOgTsHK/IANu52vAri5HGK7lqmlaXmBRiim7FYxDoNuGeEEnArEEu4ZH201Q?= =?us-ascii?Q?TzgmTgRWb21GW6lVTvZ1CIc=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: c2b8a3e7-8582-4572-7cf3-08de013937f5 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 22:23:59.8008 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZBetxVK20f2vkOfQsCUJ5q42CKIQmitvU2CPmJFUK1wAtCp5Y+b883LkBK3ZoyEQ/mrPgvzfT9NCg7jQBTkwa9F5BidSHdPoikwMCOJYkmo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6302 Content-Type: text/plain; charset="utf-8" Current dirmap code does not switch back to non-dma mode in the case of error. This is wrong. This patch fixes dirmap read/write error path. Fixes: a403997c12019 ("spi: airoha: add SPI-NAND Flash controller driver") Signed-off-by: Mikhail Kshevetskiy Acked-by: Lorenzo Bianconi Reviewed-by: AngeloGioacchino Del Regno --- drivers/spi/spi-airoha-snfi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 2d86dc62dbde..a39c3ab4af5c 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -691,13 +691,13 @@ static ssize_t airoha_snand_dirmap_read(struct spi_me= m_dirmap_desc *desc, =20 err =3D airoha_snand_nfi_config(as_ctrl); if (err) - return err; + goto error_dma_mode_off; =20 dma_addr =3D dma_map_single(as_ctrl->dev, txrx_buf, SPI_NAND_CACHE_SIZE, DMA_FROM_DEVICE); err =3D dma_mapping_error(as_ctrl->dev, dma_addr); if (err) - return err; + goto error_dma_mode_off; =20 /* set dma addr */ err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_STRADDR, @@ -797,6 +797,8 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, error_dma_unmap: dma_unmap_single(as_ctrl->dev, dma_addr, SPI_NAND_CACHE_SIZE, DMA_FROM_DEVICE); +error_dma_mode_off: + airoha_snand_set_mode(as_ctrl, SPI_MODE_MANUAL); return err; } =20 @@ -926,6 +928,7 @@ static ssize_t airoha_snand_dirmap_write(struct spi_mem= _dirmap_desc *desc, error_dma_unmap: dma_unmap_single(as_ctrl->dev, dma_addr, SPI_NAND_CACHE_SIZE, DMA_TO_DEVICE); + airoha_snand_set_mode(as_ctrl, SPI_MODE_MANUAL); return err; } =20 --=20 2.51.0 From nobody Thu Oct 2 00:53:54 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020128.outbound.protection.outlook.com [52.101.69.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50915311C38; Wed, 1 Oct 2025 22:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.128 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357451; cv=fail; b=MujkXt7Xe854g01zo7ZjJvXmX/P6RnVI9UeAsO4qTaWcQUfyLTAx+w3fWepYGgOd4BT8YbPZE01XGCitnrEdP8tYoywk8pgTbWyt1oD/9T0nPST94D0VkvnGDFALhrsShcZ5PPC5t3ExkXTM+B7JZmdk1zQzJgDFBq+dtIRUOqM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357451; c=relaxed/simple; bh=FMrVF5Vv1XqxxA6IzimgjaqpoFwdt1ebmex3NhH4hkI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=rUJIXRujAws3hs+PoJP+A0N3u/dGmrQEjZXYvHV9YMSqFwnJRpVGuBf1RzM8sQM8ja6a57B7Y/X8m4Ekqubs1KEAZJNyf6N7ICVxFDKJZu2zNfF1bh0bM9c1ZPzzTV/KNj4mAcuCQK3FTSeB+zB0z1WhCIyDJBVOAOTR/F37XQM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=NilqiBIz; arc=fail smtp.client-ip=52.101.69.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="NilqiBIz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RW5s4sAsaBuw5w1o3mx9Lgp0UlogEGdpmXE8JoeqDdO2YvA+P7iZ/Ok1WNiudlYqmtacehVuqYSBTe+wjRn3X4dEq4C9xRPrnQsFwdvoC9Zv/LT5h9626uWg/ewbrnoE5lxsfD+VI/0n5aE11bItmSCgplU/w755B1cBc7qh+Ae6aTNUy+6UiX5sWBtquMQNrvCTFtQN1khYjwsR6DAHNTgrtTjMCFZFO9QQbuF/4qL/UmmAx9nSAumqWaa6lZOBXlME1Vk13EmHein9lYC265D3k4SPR8Gj/gaNUlfaPqtGvEfFmaVpAI8Uw1mOt63ofCG7CIG/4JDfzoGwAIBwsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tvX94nIt6Ushebm+TMBumijXPGW+xCDBR3BCYJgUfgw=; b=pidknm4lu1YhsteLRdafDRxvjmKibOsRDiSrroihUy/MHGJpGsfiuk7dDidgHZdgYgmz7I29LYHnKIfwcUo/VpJkunZT+Rypbgth3fbSmjIF6kb2fXlbYpsO1Ejo8wvmvIZt7ETrzA8tBqwrYyKiHzWCfzDCUacZRBPYlZGgXlZ84E+IYE0b3Y5GHVrSTqFOVviHYfpepaTMmGGrG+1yzmGdXDeRWg9qdpp5hnKuAEd1DMF8OTsiVq30I9SF0upUpacG47eKvAmg8WisAoLaOxs3VrNxMnT8kxekRPHsVsZjdjRlpjOZGbROZn+8fMeXhC23MHyFEVQHBpdvXd/MWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tvX94nIt6Ushebm+TMBumijXPGW+xCDBR3BCYJgUfgw=; b=NilqiBIzpmFniYrkLjz89uWtqDM/bvAoasTm40Iq+kaCgBhEBz7cp2FwJ0zhDoAQwnTK3P27wN9M/TAK96sK+FcaxGUEFtQQKC7af3MNzZOq3SWdf5rT8HyAxq2/Zycwdstv4cZaxY2cZWZCTnz7JE40g2X0ZUzfyZKLHCT6JsfMVGrfNBpN8gUMRXTo6J7w+PQh9cSG7o/ZFZmLkncM5FcejUMCv634ccGAjEgOLiZ/BFXaIchtawSFYBMGLQTUHotj2jDcav/j11l53S3DOSONkbIQbIPNHP1uCsYVLmOgeu7ary/kYpjeru/We/A77rDXbefIThDBYqXUZdo95w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6302.eurprd08.prod.outlook.com (2603:10a6:102:ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 22:24:00 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%3]) with mapi id 15.20.9160.017; Wed, 1 Oct 2025 22:24:00 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mikhail Kshevetskiy , Andreas Gnau Subject: [PATCH v6 06/13] spi: airoha: fix reading/writing of flashes with more than one plane per lun Date: Thu, 2 Oct 2025 01:23:39 +0300 Message-ID: <20251001222347.3386506-7-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> References: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0447.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::13) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: c27138da-c26d-45f3-0ed9-08de01393883 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?9lAer/KtXAY/KY3HW0Ru2qlOEq42efhnk4xXpif8VvEdaY1ABQBqpqKkXoDV?= =?us-ascii?Q?pZjRq8bgYc2uPHFtJApphAQZgiaoHyylEQ3E9iZECq78V4C9lnClFUWR/QoN?= =?us-ascii?Q?oRZLDgkhbfuBscrEPLxajZJHjoXb47duweNxklDsLV2oJK8lMPt8DzePDYs1?= =?us-ascii?Q?zHzxWUPI+OWKK0X25AHGOIH3CoTS1rz+rsFkfBn5F+YNN96DlxL5To2DzpvO?= =?us-ascii?Q?NmDyWriRVZSgwSHITsqb7EUKIq23sp5982j4Hq3/ngL9P6QsZ/aiQU7jOs//?= =?us-ascii?Q?LReUtQN/h/JE/4OzLLm7GKjAgUegRkasExmuKX3Yae4FFdOB0ohbvDgWzERU?= =?us-ascii?Q?61oJ1cX6YIKfLB8v74ckF6OdTbmM/qbskNsamRtda+wr2Z5ZC3hwCv+9rYH3?= =?us-ascii?Q?DSaEKF/5SoYm8GAYrk9Jdk6AOaX+he/02bm76396qK98DXgxI4pfHWbhGqWJ?= =?us-ascii?Q?YC0u17QUQdK9Xpk/r5XXy9I6CONbcYL5oNqOVmgvSKnui8lQ7OIx3FTHrrNV?= =?us-ascii?Q?xFJf8UqpAVdh27fyNxI0CZ9Vjc5wSPXsqKw0A5oHp1QFprbGuhzozE90K9/A?= =?us-ascii?Q?K9+gw9UK+o3tXxqRomL7X3JYwijw30XmXkLzpqBaEa82otB5iHQFzLcxoQK/?= =?us-ascii?Q?Qgg+C0TFqNQwCJYPgO+AjrNGDkRIcwrcI2BC2Bs4ZF+bW2jeCwaYyAS+tZa8?= =?us-ascii?Q?1D4ir6YRZhu6FdUOFauFNJVR+oToP7j1D6U0uFZgUHcl0eF0OJ2vG9e77R0O?= =?us-ascii?Q?iNKUjseeA9TOTOz93e+2/TrNE6I59hohGv5M8TZ2PDK82mlx9y9N8pCqP29T?= =?us-ascii?Q?qZtIojn5z3NwBeFPgM78JRvlEN4AnRSoT0NHoH9o1rAid1Xad7R9MRXN4CLM?= =?us-ascii?Q?1wj+E+Re0bON2yDVXRHZMQGAV/vXomWl9IFoz2AsBHWcScxjwrA0uM8bQEtb?= =?us-ascii?Q?cpntTVc2e+CnUZ2EXpH4vngIRaLKUV6u9qgzqvYcYNUDwoJSaa0EjmqcYht7?= =?us-ascii?Q?gQr8SPQn/FjuVaPefJKCif/w6ahlznjaW82hN8rj/ToJnJgbffvISwAgiCBO?= =?us-ascii?Q?pl6gmoGnnI4RBk+XDdsFo7EII+ns9WZglugkJJgnMPkuSEG6KZf+HPv4B9CC?= =?us-ascii?Q?x7P58+lOMMskBR06FJMieUsO2YmD3tC8mVz1CLCq/udeJ78uPEuEymGCaVXq?= =?us-ascii?Q?wMqD7LTTM0DokUtJN4eJiQ+jB4yl7Q6l1iFNrjKkcU4F6a4GtSaA171CMfIM?= =?us-ascii?Q?kyAiGBojwm2xxbJkQBDakUC6M1AYBg5/A1cz/TZlGUG3tjMXvBoDiaRsNq7n?= =?us-ascii?Q?P6hD0VLcp3qpgKfeUv3bEIeOWkla8CHVa9a5e13CzsFZFWIJGJKRucZVxPCS?= =?us-ascii?Q?5vTVYfXlpaG4eVRKU4A789fTbAXHed62k+7t1MgrhBORRe+du7b5yoo/RxfF?= =?us-ascii?Q?z6BeMoIhHNgT7Lgdbqa0XyLRk7GoGT/7YHnHRzp+UKTzg8oXRh2M5AEOVb6F?= =?us-ascii?Q?7EmQj+YrPcRWJgQrNOW6ETMS2SW7XDHoKI/d?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m4Xav3J74Vmwbs6ep26qhjsu6naYEYbOC4eirnpOsvQCjAUg4XELaU0z5WCb?= =?us-ascii?Q?c7xSfxJ9e84SVanO14qxM7FdrAq4OaVO6AO9xWn6tRB/L5btu5e6xL65YG7t?= =?us-ascii?Q?sMcc3+zOVTVcUKBHLdjgIrYwv/XhMB0YlGHT+3RNokYRk1sRLPdBlb4zfvIZ?= =?us-ascii?Q?lAk7qY7z9Rh8NR98X+UMotW/7rdTTJUn57D1357Xe3DE5tupAVnZxbFQohqh?= =?us-ascii?Q?0Mb+kfE8X/qDzdU1GVkdoENc2oRCwe0uB95aGrpVzyQAO9LM+3EW9N64+VUu?= =?us-ascii?Q?2uOwtwF72rj0ZnrKV8E23XPrxJjaAdTL7VOqhj83Hxq/rNI4E/eVjSuBf/Ji?= =?us-ascii?Q?hIjD2KvZ3YbSEvaLSCmW0DdhhlpcJuFaL/lLUDyZDbe9NoYOwUk08q0NrWZ1?= =?us-ascii?Q?wKSLxe/9PysxbwzwfFJ6dpKZcczbSK/axvz0zhrrRp81pdgJEzY2u+XOu9y0?= =?us-ascii?Q?8MuwalOzkrBxxveupkJdJ30SNRzIYsyrZVzZcvlefD7pb5GRMOM8vLhYiVT/?= =?us-ascii?Q?KKG1Z8zRMrTngR8Jh58VM33F8k82gM5DMBxuREd52WgU4vWoAqN7P1JHuPzJ?= =?us-ascii?Q?IV/HCjI01Aj1lY5tgav1vClFz5ltdujHLdMHpNFYfVMOtstd8Zb5CA04/E6U?= =?us-ascii?Q?p7PapfGsqOMemr0gNR+x30zejHDVIwswJ3QXyprVbH5UZdt80J8zDMU9g/iN?= =?us-ascii?Q?VAFMOe8JGXb3a5pnN/CMx+EZMCqQZEddg4iLED+OOeotf2iR7wlQVAKvDMa9?= =?us-ascii?Q?9y/m+euTFF0kxnXTJYLPbdasX/2NXkpE00CX/PETAq7JFGKU8YW+gWV9v1cI?= =?us-ascii?Q?+NUbEM6OPR++tQRfgsUJnxarGnZL8BUHwZ78Sq+GBb20pC7tgRIkNVbxuN+a?= =?us-ascii?Q?AjpfXiILKZPBUft+/bTOOND/4mRRedYuJrhfpvicpNEJGvsFRd5o8yiHYRdB?= =?us-ascii?Q?+/5mcDvvlvJFQCc+Fdell+3/nNwp+G42WaxnCDILzD65y6/JNtyYfXBPoBGa?= =?us-ascii?Q?SRO4rFuqQPmXa0P1mG9dwCcR7ZXboL4kVlCQa6herveyCCKD1LfgqLe/kFMo?= =?us-ascii?Q?60bacFvyZXWjCVKUsvVQKlupA0puZnqkSVhS7s0/NRCoubNneKTw17+DSuOs?= =?us-ascii?Q?67ZlrF3iwBlm8uB9Y2qPb07lCDbgA9v1kxoqMja5qmSSEa42lA7fMgaM2Im1?= =?us-ascii?Q?VcKhvbQ5WwzEmhHQ4x6yGhxHJG1w5W4//0DslsiKa4GhwoUWd052uzIh2uwE?= =?us-ascii?Q?G829LQ7X9soC2yJ9oEsMu+xhGxaNjbM5s+NSTLQ0DdJlVI/H5/xOpWhX28FX?= =?us-ascii?Q?i4+v1Km9IgJUc4CGqa67t2zz5xrKoFv5RykkSJCeCj1zlGEbkFLkGjIo3dPo?= =?us-ascii?Q?/O9Xq5liEexhW/uF/Gxd2KhTtZ48DXGK/K4MaKg+XjqP9hhz6uZYENYkZ92m?= =?us-ascii?Q?wzw+zk4hdSArK8TpotRmHX13yvcm4suEliICsyTsdMQx7drBY7i9Kb1TnT2f?= =?us-ascii?Q?Af3Noor2n4ZvdJLf1k88TUgB+hMj4fNAMuTy6FXSYW8lv8e+GhIyJAxEYfiy?= =?us-ascii?Q?JhPUWknnU/eKKldBmIeMg5GgA9GVlVrPD6+clPBPKgahjktExiq7oLFHCmmZ?= =?us-ascii?Q?eg/Nd+9fzzx/AU7aEa8QBX4=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: c27138da-c26d-45f3-0ed9-08de01393883 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 22:24:00.7643 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VYoj9UsFuvZezWCSkeKgF2WrnIW7Ga2axbyqS8NoB5grktgPKE6hgRjVw/JllmnsSEbyLPkb9aE2FliHfzvNMxp1SGDz1vmqEnsf79kmbeQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6302 Content-Type: text/plain; charset="utf-8" Attaching UBI on the flash with more than one plane per lun will lead to the following error: [ 2.980989] spi-nand spi0.0: Micron SPI NAND was found. [ 2.986309] spi-nand spi0.0: 256 MiB, block size: 128 KiB, page size: 20= 48, OOB size: 128 [ 2.994978] 2 fixed-partitions partitions found on MTD device spi0.0 [ 3.001350] Creating 2 MTD partitions on "spi0.0": [ 3.006159] 0x000000000000-0x000000020000 : "bl2" [ 3.011663] 0x000000020000-0x000010000000 : "ubi" ... [ 6.391748] ubi0: attaching mtd1 [ 6.412545] ubi0 error: ubi_attach: PEB 0 contains corrupted VID header,= and the data does not contain all 0xFF [ 6.422677] ubi0 error: ubi_attach: this may be a non-UBI PEB or a sever= e VID header corruption which requires manual inspection [ 6.434249] Volume identifier header dump: [ 6.438349] magic 55424923 [ 6.441482] version 1 [ 6.444007] vol_type 0 [ 6.446539] copy_flag 0 [ 6.449068] compat 0 [ 6.451594] vol_id 0 [ 6.454120] lnum 1 [ 6.456651] data_size 4096 [ 6.459442] used_ebs 1061644134 [ 6.462748] data_pad 0 [ 6.465274] sqnum 0 [ 6.467805] hdr_crc 61169820 [ 6.470943] Volume identifier header hexdump: [ 6.475308] hexdump of PEB 0 offset 4096, length 126976 [ 6.507391] ubi0 warning: ubi_attach: valid VID header but corrupted EC = header at PEB 4 [ 6.515415] ubi0 error: ubi_compare_lebs: unsupported on-flash UBI format [ 6.522222] ubi0 error: ubi_attach_mtd_dev: failed to attach mtd1, error= -22 [ 6.529294] UBI error: cannot attach mtd1 Non dirmap reading works good. Looking to spi_mem_no_dirmap_read() code we'= ll see: static ssize_t spi_mem_no_dirmap_read(struct spi_mem_dirmap_desc *desc, u64 offs, size_t len, void *buf) { struct spi_mem_op op =3D desc->info.op_tmpl; int ret; // --- see here --- op.addr.val =3D desc->info.offset + offs; //----------------- op.data.buf.in =3D buf; op.data.nbytes =3D len; ret =3D spi_mem_adjust_op_size(desc->mem, &op); if (ret) return ret; ret =3D spi_mem_exec_op(desc->mem, &op); if (ret) return ret; return op.data.nbytes; } The similar happens for spi_mem_no_dirmap_write(). Thus the address passed to the flash should take in the account the value of desc->info.offset. This patch fix dirmap reading/writing of flashes with more than one plane per lun. Fixes: a403997c12019 ("spi: airoha: add SPI-NAND Flash controller driver") Signed-off-by: Mikhail Kshevetskiy Reviewed-by: AngeloGioacchino Del Regno --- drivers/spi/spi-airoha-snfi.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index a39c3ab4af5c..5ad3180ac6da 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -726,8 +726,9 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - /* set read addr */ - err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_RD_CTL3, 0x0); + /* set read addr: zero page offset + descriptor read offset */ + err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_RD_CTL3, + desc->info.offset); if (err) goto error_dma_unmap; =20 @@ -860,7 +861,9 @@ static ssize_t airoha_snand_dirmap_write(struct spi_mem= _dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_PG_CTL2, 0x0); + /* set write addr: zero page offset + descriptor write offset */ + err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_PG_CTL2, + desc->info.offset); if (err) goto error_dma_unmap; =20 --=20 2.51.0 From nobody Thu Oct 2 00:53:54 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020102.outbound.protection.outlook.com [52.101.69.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B13E3126B3; Wed, 1 Oct 2025 22:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.102 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357451; cv=fail; b=NzmWw96pwdiLYeQJ4TOCFatruWYgR/Rg8HDc/MdPTtreQ0KC9tqSHABmOim6yDqt7vqMSetYWj3BJh8xDmHEFNEU5Wgw55EhufcAevmIx82pUmyyVv0QUxKMHY9wvwN0Wnz5BQ5nXMjiZ49LUrYEQMuWcsjEg+AQf/p7mJC5Wao= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357451; c=relaxed/simple; bh=8l9JymTCgM+epgUzk4VcWqTdwxznhd6zcMGkq7eDAt0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=hRF9fEXO1EbQjDQwlNNz9kQ0REeOKo1vHHHK9GsQEaywS3OuzZRn6WtIaZV/HqLcO8j+qcC/X76dMx71Jdwar5TkxKTiobc8hZgGG3NMsgC8j5Ex60R3RCZMV/WFIsJeOIMqxYtt8t+/cBVnlEfqJ6UYZwtFoL6sWAbCeHx5bXc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=p3gm0NLq; arc=fail smtp.client-ip=52.101.69.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="p3gm0NLq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ug/KtfsmWJ0SXCsH8xuSxzsSjqXqJSCdHK3HY+nffDPDQy8AafSllwFV/67sn9Z3KLsHU7VCYxgPG1WQKQtVIHmIqj0Xv9k1y19rCODY00gyJ0nJJTiLVCyACGjckipRFW7CaYOrFGE7jCp2tAUudbgZVsPIZKdiV2wKk32mpJoaQN/QFNsSCwiBKjpuu3iLp3L54SMPzoHgkFZBDTiXyZM6LDte1rWEL87UC/VWd8WdL4vJxDGy2ltwAnjDwH5zoIHuRKYPk/jY/GhFFW8LjQzGba7TQgACDkkZjismheFIHdHhAygYbyXDbSWRdESTKzI5FWz+c7gByppQoVXRaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BNX4iO0o0uMaRyxU4/UJ53mvcG+yuhoVl4mVMBYOSyU=; b=rhWzu2B61ZHiIKBb3URSiGZUee3fTOznv3W08cIBx9v8ztMSnnyKmeN26kPSNiC+ZxNTgwvn26sv5YC2I4yUo+I+BZiFlvlBMr41Xr8e1yhuZcVu882MqFO+tlb/0/wqdQ1PLXny8TH9tPdsgwy3hytaxU/Mq1zhO7+ElLlDGI2n3Hsq+zHi7nbs9YIBujmoVNIIXFBpnzdaS35LyDN6AmVmqehIQbI6Z4yposqPvwuYzf8jOyPjnmNQUV+3yfna0Hj8om1ndvPm5ytoZ92nRqZ2aQY9Df867FeJ+A+9WwAQ41DmQpanjUin/CI7J+2MDb5oFn9DycWXNr7ntsb3Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BNX4iO0o0uMaRyxU4/UJ53mvcG+yuhoVl4mVMBYOSyU=; b=p3gm0NLqSAjHuHFv+lKHDlaJadb+6A/T5WudQBxWoNn1vy6l6VbtqoKZNw1bvbqa9lRrc8cJ7MAe4JbpukZGjc61P/Uq6w+lHSY2c9czXYDnbvxiTD9D15d8nQrql9/NrRCziMN/xVkeVdOHQAupwnGWFfbEHQAxPw0N8S5h6vVXkEjfFxbXZFyvh3wO36umQeSgdxXMZfj5QGZRyzEPXXEjJRmlPRogg1k5+ZBN8jCsHbRK8vrqGrj7Zif6cprCwQRe+VzokRhLLC4JRPYYaVrs8m/Bdb3bxvc1gHzHPpm4fSFS4vbSxBSBU3USpu67YOiWloiQTxQ5Wsezn+0Uxg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6302.eurprd08.prod.outlook.com (2603:10a6:102:ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 22:24:01 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%3]) with mapi id 15.20.9160.017; Wed, 1 Oct 2025 22:24:01 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mikhail Kshevetskiy , Andreas Gnau Subject: [PATCH v6 07/13] spi: airoha: unify dirmap read/write code Date: Thu, 2 Oct 2025 01:23:40 +0300 Message-ID: <20251001222347.3386506-8-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> References: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0447.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::13) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a87d7cd-f451-4ab0-9571-08de01393916 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KEq3zSlNy3Yil+NtQnIgKyDvUzUjXnICE5CY+yKtkHrG5vXb+Kl1Mioh8P2j?= =?us-ascii?Q?BI3cl11imtZZ6A5SDJrt/UsiFqAJp81pu08SU8S8I5FgbvrNgOl2LNPZ5Us3?= =?us-ascii?Q?PIG8JFiEky86gUFOxUgh7cY2micoW0P2nMe2zWqGEhG4kTqyTbTSBpB9OtMd?= =?us-ascii?Q?3Xl6gpbERB7XhFZnSYJRFkpQceytUiiDPJXcU1mSx5e3zghuzGwrrw+AQzCT?= =?us-ascii?Q?KWztaq2fucTJgCe6EYAoO38yo+vaMRVEJamt9WwITJudhXyWSZB+dBlOozCG?= =?us-ascii?Q?u2ZFcABluOsUxe8kxInxC648YFMYRJYqkAGHtdGKopIZCqiwoClW7cK/qQec?= =?us-ascii?Q?ZAazH52qsuaZXwK/A5mG+b0LKXu31d9gBxaacP59Zd2gbOSFeZdXQDW9dkLk?= =?us-ascii?Q?yCLnGy5XnKdkl6m3eouKRJX4A48LPqx2ygef3w85wLZHvUqxQCIEA+xccNL9?= =?us-ascii?Q?uaxvUqpgj7VFM9Ergrit97QpxGysqP3QfsGn365lwRIrn4dOuOECDtWPKAzj?= =?us-ascii?Q?S89yhSfpvDotAZEPUBoIwjz34lklaVgtk2+PRlDzmR56Antv91XLHvSVdZJE?= =?us-ascii?Q?+gIah6xtu0UYLD/VdH1vNfAjLZYAAy74ARVf4l114SM69F8w8kePr5J5qrq8?= =?us-ascii?Q?kQdknhWOX9WmO9hizhmx0p2rBjhh87biVnNOSo6bGWyi3KtM0+OXWxAsqIxr?= =?us-ascii?Q?fmWgEPXEiRhspoU//uz+oaOqXvFTQvWgGgCuWQXskDrKVcs2tz76Yi4A3e1G?= =?us-ascii?Q?RiZS+WNYukrsDaSL+uh8i4qitZuHGSDI2nP79u5EGrij3WV0/K8jDyKEduwi?= =?us-ascii?Q?fPip0lteRV2R/+zVM8/QAs6OR/Dvy/S/60hy21RQFlscAsUdfaGynxiLNKX9?= =?us-ascii?Q?mDFSVf9JcjqfkzEU+INROpQ5ib3ChEHDaTqm+XKa0u0kF9iVDOyMYbemHJel?= =?us-ascii?Q?FHWk2bfgL00rec00TMqWzkws8J4qdNGQ7Yb33dQgcGuz5V5aTzlOQEk6wX49?= =?us-ascii?Q?AxKICBctaVLNhboo1cnaPdA6mULzqKaK3UExdm50cvdFaxUad0tQ9FJnbQ/l?= =?us-ascii?Q?+ZYvZ/wzoxc65Oc0AfFpZ8U4j23rnMC5RREHppcmQG+RFTIv4wIAakhAsyyh?= =?us-ascii?Q?kOEwfipnSV50sV6IT0F2nsv1Fqs6u8tOwhQ7q7em27LbridFxJuzZ47BLnrH?= =?us-ascii?Q?T2F1TaMh0pzSrZom8wvSTikitJlN+KZYelo460mbq52fBvHSlVlsnGk4jZ/C?= =?us-ascii?Q?oNAXeXBI7OyxN5dMDEUZJd/jcwoHMjTctC0KLWToy4x7rg70lMl5NsE8ZuvT?= =?us-ascii?Q?hoOX2Vx+PNHObUj7cB4taOECkT3k/ntRGUvB4QbpPcuvY/9gDHONhkqcitYp?= =?us-ascii?Q?ASY55hhhFVFkSiSJoKvjJjZUfN8Hn/6GgGckvAzw9tcrpVxokRBeN1Qie/j3?= =?us-ascii?Q?KYDeSJTxeKes4qN+Fcwdk7JzSH7D0AFu41rqS+GXv0lQojb+YoNRzF1ooBEu?= =?us-ascii?Q?9s1RRK9Cgugv3KVdvFgh1iZTL1fBbHbMCFRz?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tbxU7oPMZuw6zl4B1BiSYU8ksulPorXGum4SnzxQ+eDvWnq5tVLSxuPPTe71?= =?us-ascii?Q?kpouiypGzIz0dU6VqhSXccdLkSQq2W+GJgj17V6bb5HfxuaeV7EqMfj8LBIb?= =?us-ascii?Q?yym5eYF6ezyoMm4XsxO8uomUPGATbScKM9OIIZ4qh0e6uWimWWlXVYaBsaNP?= =?us-ascii?Q?Tmd1Sa2wKTNOVy5ky+l1AUxwk+nemv92RkvMrSb++QsNSPXu7fAHj/rNCqbi?= =?us-ascii?Q?/6QreAfLk09HNo+B7pXuoZTWSp3g0351eFmqek2lGrDyOgVTYW/PzTyUqa1A?= =?us-ascii?Q?7wP8TzUGd+oLQL05TUdO9m30CLoq0nsYJy/AYFT0bo8ZoAZdNOie0OA7z6T7?= =?us-ascii?Q?uwGR+PclF4GWPV8womOOheJCh9Sps7U7eLVRrum6f+/0apFV0kLc7/+S64vf?= =?us-ascii?Q?UxHiyxFANcybO6ci6+VpPTfiVY8DhdCC01rQPS7V8HcU7eRmOhTRFsxchUsm?= =?us-ascii?Q?KozaaRaSgbT63OrntQEZe95ptd5Zc1NG6I15oHGYoYcxOWwBo4zmF8sdT9+v?= =?us-ascii?Q?ijLEbz37StTOmcOhAC/n1+vwTB2J6WeF2TfwGq99kHGwKx9tjLq36unlI+Iw?= =?us-ascii?Q?pX5ccQfFeGSxsBkPINqvH6fXST2nDzF7+56iREgecjJ8+jn5Zt9fryJaoMax?= =?us-ascii?Q?nrttMOGoFpfljpTWTc/DtGVcRtpAz2a8PkkTlvnBaoBy2yyE1d0XNBG1FyKz?= =?us-ascii?Q?ZEOZzW9PQEGYjuODDSpHcXRQRIah8xP7L46uYj5i/pd22AyCpvJ6DipvyyQ6?= =?us-ascii?Q?XsUVM5LCWekok9TeUU9V9VyTiKJXrWWbdDS9Xc9a9Ae8I4Y34DxyrS+XWPWQ?= =?us-ascii?Q?r0LPm59ciWN5rLNxBK8+yfoGR9N8QdG8zg3SLRTx4X2y2m4UzCNO34KYe77R?= =?us-ascii?Q?muc/F88qfbZZEchZj8MTpwJY60tPV+1JoO7Jp9yE7VHZXoXm52x3vPB9/o8o?= =?us-ascii?Q?3fQnts9YUBCd8E5TL0HZdJysLiMCl1guWUxm2Vu2NnECLJNc5ZrZsjPpK8zO?= =?us-ascii?Q?HTowaCCKiZuQy1mNYfsdpXlYOTb82RR9pZau0rqJbB+mVQ0OoYfyFBYG2SMQ?= =?us-ascii?Q?rLB2o31qSbBbJZVeAnJC58y/4EhBxCMs462s3Fr0tKIImI9hI0pxMudV5g20?= =?us-ascii?Q?rKajzWWk1P9A/Ew2yknZnaS/tZkcq9MMEfNWJKz8i5OAHAFdWYSCy2aBPAfN?= =?us-ascii?Q?yi35it/q63phTat6Z9YtKO/PsWtpfrYZ71BhBYAwOzrCLHidK62vkC88lJGY?= =?us-ascii?Q?/zqq1kSexeupXrXIphnfXiTfIT0A3Pm/G5ecIchZ14C7jIXeIBrz7UEcBGnV?= =?us-ascii?Q?cWXVgh1s+SmAXt5ylAKzVxjj6WXwenat1ljrmVdxsn3WCoaKgnIqdBFOFv5m?= =?us-ascii?Q?0qr0uFIb2Ie5KIizy9B8rWigoknOpOTOOpP/re+sGgsF3WHIQmhnc2FZdTbT?= =?us-ascii?Q?BNJHC4EeXJtE7z/WInQxIEfiffpJECu4r6zkiIPkeNq+WihaSQ3I2p6PO4yu?= =?us-ascii?Q?esjjKr+1QV2HgTEVUdNnzYFwCS5HG/SHVYCstzT4JdxryzU5DPecXWiqO/6+?= =?us-ascii?Q?oCbN2oP/6dhtHu0bnKcrO3V84G5DwpilwKsDJZnpx65Qq6jMz/OvVb++k1N7?= =?us-ascii?Q?E2WUS1+otsfArsThVCGvYMI=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 1a87d7cd-f451-4ab0-9571-08de01393916 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 22:24:01.7032 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GOtxPKQNM0oN0Cr+APxBzlcZeZktK0P/Ac4JyFfBHvvkPDZG0jKn8PybfZFhQeFdApKyGIAo09rMfXK2m2FvfNhcbzeiyVO+nDr/hWGU6BM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6302 Content-Type: text/plain; charset="utf-8" Makes dirmap writing looks similar to dirmap reading. Just a minor refactoring, no behavior change is expected. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 50 ++++++++++++++++++++++------------- 1 file changed, 32 insertions(+), 18 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 5ad3180ac6da..e90fab69d81e 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -672,6 +672,8 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, u32 val, rd_mode; int err; =20 + as_ctrl =3D spi_controller_get_devdata(spi->controller); + switch (op->cmd.opcode) { case SPI_NAND_OP_READ_FROM_CACHE_DUAL: rd_mode =3D 1; @@ -684,7 +686,6 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, break; } =20 - as_ctrl =3D spi_controller_get_devdata(spi->controller); err =3D airoha_snand_set_mode(as_ctrl, SPI_MODE_DMA); if (err < 0) return err; @@ -748,7 +749,7 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - /* trigger dma start read */ + /* trigger dma reading */ err =3D regmap_clear_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, SPI_NFI_RD_TRIG); if (err) @@ -806,37 +807,47 @@ static ssize_t airoha_snand_dirmap_read(struct spi_me= m_dirmap_desc *desc, static ssize_t airoha_snand_dirmap_write(struct spi_mem_dirmap_desc *desc, u64 offs, size_t len, const void *buf) { - struct spi_mem_op *op =3D &desc->info.op_tmpl; struct spi_device *spi =3D desc->mem->spi; u8 *txrx_buf =3D spi_get_ctldata(spi); struct airoha_snand_ctrl *as_ctrl; dma_addr_t dma_addr; - u32 wr_mode, val; + u32 wr_mode, val, opcode; int err; =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); =20 + opcode =3D desc->info.op_tmpl.cmd.opcode; + switch (opcode) { + case SPI_NAND_OP_PROGRAM_LOAD_SINGLE: + case SPI_NAND_OP_PROGRAM_LOAD_RAMDOM_SINGLE: + wr_mode =3D 0; + break; + case SPI_NAND_OP_PROGRAM_LOAD_QUAD: + case SPI_NAND_OP_PROGRAM_LOAD_RAMDON_QUAD: + wr_mode =3D 2; + break; + default: + /* unknown opcode */ + return -EOPNOTSUPP; + } + memcpy(txrx_buf + offs, buf, len); - dma_addr =3D dma_map_single(as_ctrl->dev, txrx_buf, SPI_NAND_CACHE_SIZE, - DMA_TO_DEVICE); - err =3D dma_mapping_error(as_ctrl->dev, dma_addr); - if (err) - return err; =20 err =3D airoha_snand_set_mode(as_ctrl, SPI_MODE_DMA); if (err < 0) - goto error_dma_unmap; + return err; =20 err =3D airoha_snand_nfi_config(as_ctrl); if (err) - goto error_dma_unmap; + goto error_dma_mode_off; =20 - if (op->cmd.opcode =3D=3D SPI_NAND_OP_PROGRAM_LOAD_QUAD || - op->cmd.opcode =3D=3D SPI_NAND_OP_PROGRAM_LOAD_RAMDON_QUAD) - wr_mode =3D BIT(1); - else - wr_mode =3D 0; + dma_addr =3D dma_map_single(as_ctrl->dev, txrx_buf, SPI_NAND_CACHE_SIZE, + DMA_TO_DEVICE); + err =3D dma_mapping_error(as_ctrl->dev, dma_addr); + if (err) + goto error_dma_mode_off; =20 + /* set dma addr */ err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_STRADDR, dma_addr); if (err) @@ -850,12 +861,13 @@ static ssize_t airoha_snand_dirmap_write(struct spi_m= em_dirmap_desc *desc, if (err) goto error_dma_unmap; =20 + /* set write command */ err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_PG_CTL1, - FIELD_PREP(SPI_NFI_PG_LOAD_CMD, - op->cmd.opcode)); + FIELD_PREP(SPI_NFI_PG_LOAD_CMD, opcode)); if (err) goto error_dma_unmap; =20 + /* set write mode */ err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_SNF_MISC_CTL, FIELD_PREP(SPI_NFI_DATA_READ_WR_MODE, wr_mode)); if (err) @@ -887,6 +899,7 @@ static ssize_t airoha_snand_dirmap_write(struct spi_mem= _dirmap_desc *desc, if (err) goto error_dma_unmap; =20 + /* trigger dma writing */ err =3D regmap_clear_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, SPI_NFI_WR_TRIG); if (err) @@ -931,6 +944,7 @@ static ssize_t airoha_snand_dirmap_write(struct spi_mem= _dirmap_desc *desc, error_dma_unmap: dma_unmap_single(as_ctrl->dev, dma_addr, SPI_NAND_CACHE_SIZE, DMA_TO_DEVICE); +error_dma_mode_off: airoha_snand_set_mode(as_ctrl, SPI_MODE_MANUAL); return err; } --=20 2.51.0 From nobody Thu Oct 2 00:53:54 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020128.outbound.protection.outlook.com [52.101.69.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AFB9312811; Wed, 1 Oct 2025 22:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.128 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357453; cv=fail; b=NGzZi7YCdS/BriV90S9xgo7+LL50KfA/3wcQyPTMUB5WQ5tj9tnx/lPym6X1/ROp0xEfaO8a8dH1fjpIo0l+afWKk+d8pCbDNgkf4fQXdnS/g4O/NfsaiB+0LW5M5DIA7Bznw8OK5PHwkYzRBNhIDYDQwNpcYf2+yxWj33YBc8Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357453; c=relaxed/simple; bh=yls5E1AQJW8UjaQIdkFn4PFMkKchlzz5HVhY0hyRl2c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=ulEJPvj/ag6NgkVMggROMQqQ3M4sUcLKF0ibDagKx0PXqII96wArX3mjlRVFx+QbV27rZd2ZBHkF75etj/fbfxdvs4SDR0rs9JDzMEKrKaqPcT6UhBnkrqmu0An59qgU/RdhnCIhisCeiFMN2I9xrNuPvhWUXPX3WrBfuBlGTg8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=5fnne4w0; arc=fail smtp.client-ip=52.101.69.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="5fnne4w0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qeJnsRAn0UiHx4uwMnZvV0ybqqgEMZ19aTcGU8q/sUYeqO4eVRjjLUbqVer7HJjFRZ5BCGprvRemBb7YfmayB+Og1Qgxk+hhoBS4RBytFWzG8cGvcw+VhLu/OX5KnYSnjioYmlvxoz9mklHv0ehAWnvc4XPFrAGUgCH/PFfiSbshrn/wttnpFgt94kSML3/6KzFnE5CbSMdIlcLsyOJq647HpVCPJOHXBvYXjMcs3f/ZTY3JPbKn0Lpb7NA0/3lFT3nZdfEmqrCbaAsT3iQZJ8JUYG00tSJEfmucC+TerSqmAJGVM9FsExk1tYGANKs+xrTH+0QrM4qVF5r59gReTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nFKNDFk6oF+S+8lmQu7ZvbBpT1DDV81X0kaPUpu4tAg=; b=B/dtpj+Y0Sq2vgQamPqmXMj7KJTaTtM7+4EG/3+eFfwdIS/fNfrV7IIlhGylPkgldCXVAEsL28RLfQMIbhzQOi8XkFqIq9bBVJvUroonJU3bl3onrcQvPvppjRhua/ttCPTmaBiWYBA70RYZut+DwjB3lA0b2YGUr2Ipxp7yz5GJlw9Ri1WJoTr7cckULfTbKA/ol7jITwp8FKegAi5aoLujF9hOd1UXn22w8bkXAMI57eI8LgkrE2ncuZSc1uB3SnT6o3lJyzkmnUCTrkamJrSGWpmMo5drL91a0swr7wq4k2PEmD8S+3LJTbhDHmD8/MhiaFqJl9ZYLH5hGmoMYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nFKNDFk6oF+S+8lmQu7ZvbBpT1DDV81X0kaPUpu4tAg=; b=5fnne4w0DimtYna3X0nevwTRrZcInz6+nhMHjvyCYeKKydIFnyJkl+SRnJBvUVQNYk2Zzuh7JuQJ9RYSBMi751iIsNHrzqdpQEpquZekmfILLoKw6zsCxR5dpe7Lr6l01uranCSMArZ2W9Z/Huz8vLkTQYEts1BPIJdsbkg4wx9XMA8BHt6pl5H3wk3+czeWp+hEuz/+85ymNWWITB1biB+5dHv3thwNHX2sHPd7KiL8rixQT0hE1cfhZAeODe5k8FirJfZ0E/bBGMRWbvfP3B1G0SQAAhR9RuCz1ClcKqezmDzpqqEU0HDacRY9eqCOAj172AeBvKFQJsL6OT2U5Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6302.eurprd08.prod.outlook.com (2603:10a6:102:ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 22:24:02 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%3]) with mapi id 15.20.9160.017; Wed, 1 Oct 2025 22:24:02 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mikhail Kshevetskiy , Andreas Gnau Subject: [PATCH v6 08/13] spi: airoha: support of dualio/quadio flash reading commands Date: Thu, 2 Oct 2025 01:23:41 +0300 Message-ID: <20251001222347.3386506-9-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> References: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0447.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::13) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: 45d042c6-6f45-43f7-2d09-08de013939a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?InjO2RE8LWVMa8bme8tPLauF3qVv5UBBeXFZ1YBrZtbobJ1UAAY3ZtRQs7D8?= =?us-ascii?Q?OU7KRf71ybtTT+aafwXpqosm+p/3+piAGE/w1uFEF2HGXSK8orvRlI9vvq+A?= =?us-ascii?Q?LISTHN5D5zVKwYra97u5tYxbBqZxlQdriu7VpxgORuPCU5smICQLxYKA0I/J?= =?us-ascii?Q?wHrY3DM9SOtnjHEaEED11iycDNPW/kz01vqmahNHrJx7XZ3Us9HQjLOaERMp?= =?us-ascii?Q?8EIA6XJEFAcK4TxbblMiRmAj+jI2QkxKP9Sps4lzLMuJU7nNBkKBF31MHPhx?= =?us-ascii?Q?juD0ZCDWIq9DkQpQ79bVH9vgLgr9QicRJ/9V6QuFhYPJYoxGaOkd/hstAZw1?= =?us-ascii?Q?K7YCQj923f7CwXJTiARkFeFyMV3j19i/95mD5e5NvSWCDRZzz+C0acZ18Fqx?= =?us-ascii?Q?VC4PTfSkZcE40mqsF/Xw6TSPSLOfJ6XT2Mh1jqP7scUhtfxIVY6zpOstkcZa?= =?us-ascii?Q?hDetYxVRJ7M29m7nh01CBND6Vdk39mAjyrXDU2sVJyR7UnZUE1qFRAjXzWaD?= =?us-ascii?Q?KRNyFSPyh3cnNc3vOGk/vH/fMf5JOIxH+xQ7JHecoECtJWCgAxTo1zOY4ihj?= =?us-ascii?Q?yRQdd0CakSVcMmFoJtrFjh6h/G8Heeb/HP85RZJhBBVgCX/6o52AVnyIubTm?= =?us-ascii?Q?sJgaXFde7Wt3KXRXvV6T1NAG/rbZxqduumw1m6z05xx+X+H0eW2CDhbJwZVm?= =?us-ascii?Q?QW93nOR1VsR9T99Exdpax00c+j4etNTrViAt98+TcwaaTl3EJdBJinsedZfx?= =?us-ascii?Q?nQaeFAf8Wm+vuF3wn4O35o44W9FxObT3HVW04DuWJcS6sH26Z29mNnmjPbYE?= =?us-ascii?Q?IJbKzGnNfEmHT9kAzh1a++VXR88rX/REKGRh/nx28osfS6MCW1z/XZN/4eWC?= =?us-ascii?Q?CQGrutAFOPjvapfMv+CcvSfHRwh/mC5KyiPymgpp3tLG2N7dlAjg3Eg9VAEW?= =?us-ascii?Q?EwJLUzpuVNhBZTIYf0WjayRqkWHF8HO8fNS4RSQ/2nMDp8Evx90nexUlQlyQ?= =?us-ascii?Q?kkh2EfuVPFRrjfGYjVBxIiK8Fp07MiwB6a5fDvN3uw8iZ9ct0fAGE1tDslx+?= =?us-ascii?Q?6l7/zs1aVR1N46TU4C06OlJEw2xdVsfDRW08KPfvAl+IiNUhYppn8/bapH3D?= =?us-ascii?Q?VZLM4q5dr3QIpc9/bo8RAmqd9HrSEWbFKgXHRETo3zRWdtL4HyXp6WFbAtBs?= =?us-ascii?Q?IBlNBZHJVqICcUEhpq46XxBnitBQPxzErsGaQgmFcVb0OYDHHyPWKgH8WlZ+?= =?us-ascii?Q?FcroQik/FbCKKrPG0kvG1vck75jGjjF03LwIGW5a6jcn+chhx2vFz4rEx8L2?= =?us-ascii?Q?o/O5BBt/8+HP4PPb3n46KT0yYbdQ6Dh8y28UdHpYtl9FGU/IVWW0OcDBgCy3?= =?us-ascii?Q?v6FhhhFJmJwBLHzU0w9kGN8YbVDYmNhyAgE/JZI8+lBjCeUE2MweiXu+p5q6?= =?us-ascii?Q?KdVoJVjbd8tickyQ17OelKKygwzewPeh69J+DSKe1OiwaIjzmPGfl0LP/Kpr?= =?us-ascii?Q?tPx42IQxQMIVrTUmwuCgRbROQckFt9BHMtLz?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0YOXicNCnAsFRcjsQofzgyeVC52+yg568P4jcFw6maxsUVqts2XZedNuRw56?= =?us-ascii?Q?2OTBkemV1sslfM+a0IGnyy+gQ0k176+qCY2mfzJMKRfXyo4GHmcvzABT0Bs4?= =?us-ascii?Q?7CwVrhgJrA96ZT3gPaVJ+EHYXWhHiWVo+V/Zqujtb7EW9kNeSS56N2yMXFLs?= =?us-ascii?Q?sI1B0kWUBdPJxLnC0nJ6jsJO8VcUOB9qKSris5z7ZoPmd3yLecFCtcZQwfE0?= =?us-ascii?Q?ps62Nj1GKRZ9c0c8gKPLA3GWKXVABLte3EJPQFB86duFJi6RXvX82Si/0pbU?= =?us-ascii?Q?mTIylXdxkyXquub2HT+NMogHzLxCS3Kue+N6JzqbzCcMz2TeXOblo92dqwUH?= =?us-ascii?Q?DK1jNUZ98j+wgmjXmwC6tZm/ZrVXE/mXSxnuqZPoUEO/nqM3B2zn31ncIa19?= =?us-ascii?Q?i/VSAonZW7ALtOhS6oHb5z5bBYHJen0i4N3HiK6+SIE3pGgo0dzrqKu6r5yL?= =?us-ascii?Q?0wcs3qQvkUO6vyh2+sbAX3O0VXnK7QVebdnff2dCg0MNmO6VQeiQ+r7tglRu?= =?us-ascii?Q?l0Fk8UAU0sHq4Fq7M18hrSPaCh/fqGSPxI1pnqrRGnX7mD56g4+G6OyXlQys?= =?us-ascii?Q?fTDEpzPwx6uYt10g1vICGWsDISAq67vyMYLH9QAoTB3mh/wMMtEyKZec2V4F?= =?us-ascii?Q?9wEP7XcXLph1QF71+jY3f76IfZ2PAQQJYCb+Qjw3325o2Pb6rH43zsCbgeqR?= =?us-ascii?Q?9LOk+umteY7spXYHCTM9sePHw5bwik0B/QjZ3/IM/mVUluEfcHlyZXt52nZ9?= =?us-ascii?Q?fPOzffJy+Oixp0l5flF3067e0aRf4KZP0w+3R7yXUkg2WuQ69Vp0+2wOyx9V?= =?us-ascii?Q?qG1pji3QPcI+Aj6mBoJI/qirvG+kQY+xlPdvgaDbv3K8ijhhiftlVsy+5BCE?= =?us-ascii?Q?Pxlvykrd7BSY6WGpI8xA1HO5UOq+QOo9IRIX7yLvlG2/2uVF9Q71xlUZUCIc?= =?us-ascii?Q?HWBVj20jEphXT9o7+XG0iuxHCMxfwiTf1ESidgarIGVfCztRBAFc/5pdK7jy?= =?us-ascii?Q?eNxrle8q2y51Z3gUim60VU7CkCllAbNyBmP9s246e32W03JKNNmYTDyuTy/N?= =?us-ascii?Q?xfVIJQLgnumabintDel/0J0I/34yqhtruNXsXOa8rE8D/9Mmbt1mnfDNM/1f?= =?us-ascii?Q?8XW3ApCl3Ylin8/meBDu2zxrzAjdXHGezcPZSRGkK31dyHUteVY+AJwLCKKi?= =?us-ascii?Q?1teFohKm0mcdqu3PdNG2WSzQzcOEz2ZhLd+EfapKivk/6C/1Z+rebw7RP09U?= =?us-ascii?Q?VakK0eTDEGs00If54+lYrjeZoixdY+2EgbVoA0HewTEqAMTTMA2YsQcyLzeI?= =?us-ascii?Q?Tqm4hAEWIWDxhN/DPA27vRz1sIGvkQJCb3qZEfN5qyy7nJGlQIp11AxrJi0c?= =?us-ascii?Q?XV5DM3iyfBz5mBYrZ2YNQZfb+qTWsmsxTk6wkfF5J2QgODgCcMutbmCMQ96m?= =?us-ascii?Q?tHExs307xp3UyZSzPCed8PW1B17tPZpLyU39rb0bKwTsVZwqpH5ZvBw/AcEA?= =?us-ascii?Q?l6c9ANLzCQPEZ2z1tUF8QoyPiY0y6XhM2xwKAv4WeMhCGKsDn5zD2paVZvut?= =?us-ascii?Q?0qdZeJXyAM1Ai77qTzl9h9oLJon3owNgYW7cgqMuGW8CugCx+LeNLQmPknLb?= =?us-ascii?Q?QHwd14B5Hb4LWtjI7e1VVrs=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 45d042c6-6f45-43f7-2d09-08de013939a6 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 22:24:02.6713 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pk4M0aQJNYThzPdrlI26M9pfGETcz5gRB9+03aWAA32k+FiJuAEfM9owbWo/N5CR2tCoUKCB3NzQHxMh9IPItkp9QS5RZ2XRAoT9CKbOWwQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6302 Content-Type: text/plain; charset="utf-8" Airoha snfi spi controller supports acceleration of DUAL/QUAD operations, but does not supports DUAL_IO/QUAD_IO operations. Luckily DUAL/QUAD operations do the same as DUAL_IO/QUAD_IO ones, so we can issue corresponding DUAL/QUAD operation instead of DUAL_IO/QUAD_IO one. Signed-off-by: Mikhail Kshevetskiy Reviewed-by: AngeloGioacchino Del Regno --- drivers/spi/spi-airoha-snfi.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index e90fab69d81e..744eeb2b24ef 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -147,6 +147,8 @@ #define SPI_NFI_CUS_SEC_SIZE_EN BIT(16) =20 #define REG_SPI_NFI_RD_CTL2 0x0510 +#define SPI_NFI_DATA_READ_CMD GENMASK(7, 0) + #define REG_SPI_NFI_RD_CTL3 0x0514 =20 #define REG_SPI_NFI_PG_CTL1 0x0524 @@ -179,7 +181,9 @@ #define SPI_NAND_OP_READ_FROM_CACHE_SINGLE 0x03 #define SPI_NAND_OP_READ_FROM_CACHE_SINGLE_FAST 0x0b #define SPI_NAND_OP_READ_FROM_CACHE_DUAL 0x3b +#define SPI_NAND_OP_READ_FROM_CACHE_DUALIO 0xbb #define SPI_NAND_OP_READ_FROM_CACHE_QUAD 0x6b +#define SPI_NAND_OP_READ_FROM_CACHE_QUADIO 0xeb #define SPI_NAND_OP_WRITE_ENABLE 0x06 #define SPI_NAND_OP_WRITE_DISABLE 0x04 #define SPI_NAND_OP_PROGRAM_LOAD_SINGLE 0x02 @@ -664,26 +668,38 @@ static int airoha_snand_dirmap_create(struct spi_mem_= dirmap_desc *desc) static ssize_t airoha_snand_dirmap_read(struct spi_mem_dirmap_desc *desc, u64 offs, size_t len, void *buf) { - struct spi_mem_op *op =3D &desc->info.op_tmpl; struct spi_device *spi =3D desc->mem->spi; struct airoha_snand_ctrl *as_ctrl; u8 *txrx_buf =3D spi_get_ctldata(spi); dma_addr_t dma_addr; - u32 val, rd_mode; + u32 val, rd_mode, opcode; int err; =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); =20 - switch (op->cmd.opcode) { + /* + * DUALIO and QUADIO opcodes are not supported by the spi controller, + * replace them with supported opcodes. + */ + opcode =3D desc->info.op_tmpl.cmd.opcode; + switch (opcode) { + case SPI_NAND_OP_READ_FROM_CACHE_SINGLE: + case SPI_NAND_OP_READ_FROM_CACHE_SINGLE_FAST: + rd_mode =3D 0; + break; case SPI_NAND_OP_READ_FROM_CACHE_DUAL: + case SPI_NAND_OP_READ_FROM_CACHE_DUALIO: + opcode =3D SPI_NAND_OP_READ_FROM_CACHE_DUAL; rd_mode =3D 1; break; case SPI_NAND_OP_READ_FROM_CACHE_QUAD: + case SPI_NAND_OP_READ_FROM_CACHE_QUADIO: + opcode =3D SPI_NAND_OP_READ_FROM_CACHE_QUAD; rd_mode =3D 2; break; default: - rd_mode =3D 0; - break; + /* unknown opcode */ + return -EOPNOTSUPP; } =20 err =3D airoha_snand_set_mode(as_ctrl, SPI_MODE_DMA); @@ -717,7 +733,7 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, =20 /* set read command */ err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_RD_CTL2, - op->cmd.opcode); + FIELD_PREP(SPI_NFI_DATA_READ_CMD, opcode)); if (err) goto error_dma_unmap; =20 --=20 2.51.0 From nobody Thu Oct 2 00:53:54 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020102.outbound.protection.outlook.com [52.101.69.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6CF3312828; Wed, 1 Oct 2025 22:24:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.102 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357453; cv=fail; b=FVemGsOBa0Tn0TvSAZCxq2W1+2bkeOvvhpWZ3kJAXen8x91en3JyGTefMS8na1I0mEBzeLCzmfGii3JWbhySRqJLc/No+GSgXoGcbnjAMqjTuauHo+8pJMKWlx1E1n2Ja8ibIswJGSbHg1PuOXbL+0/DARxXu/39PxdC7a4bhaA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357453; c=relaxed/simple; bh=1Z4+3ky3F5ePAz1LwMNxiUe87RYnFEz9pATQjAUyt5U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Bhq6hbMmaHuuf5akDqA61m3AUzpHeIEhh6psnto00U4Q7azTzxlRqs1Cme/gGwwEI13hwUMkqKwPsoqX7byDMrktUFjMf0MpeTB3uUFQIrT6+cpvnQ8/qzwUhVh3J308VfJJeDHJ1khACCFKsM70HGTBaHKm8MH2wxEN7wqpemA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=1PJsw6di; arc=fail smtp.client-ip=52.101.69.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="1PJsw6di" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=w4lKrejI7zsGRjPw02IDFRMY+kd1fqG0dQjzsC3wFDsbxRspWk5NyQoDWn6OaBNR9gDJ7xDE1zDO9h6sT+QNXtueKB9z/wPkJ9LeUiSa0vsoaOcpCeW0nB3IAzflGLwYovk2mDQV9QyISbWWJpSqrAf30QVldqvIQxR7gV6CjYmMVOi+kViaGYDcnshmC7Sh4rbTAJPJxvMo0D5apIHjAUl2B4xyRZkav9g5z7vc3nAKxzFShB2AEmY8E8SdH31AysEEMfi0ZzwMFyq/s2p8O5dGNMhDx1Cp3e2DQecibp9mr0POus3t4Do/suP7XDRO6zIu9pErVxj0qzehS04NzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LqWlm7do5dhcKQcKUBo5lauX4m4f79tFnTIC1Cw+Sgs=; b=inegdTE+o+N+MCx1IQipnszE0EXX2/q3qHtsPxnsYLYHWxLcritVnKkuolQFD+ZUzy6YSGl5HJfGqfSh/c1pj3qjDlcjcOMhOtMs/yH0aHgY7tBf6l+nFpcCwKX53ilnCwjsO1M6Kf5wuMh3+P49P5YAuAbjOHySYO0Qq7cf+GRATpi0WtSVJC5QS9ppnMuNz0xtc/t8xhuQoDyx0jd9+3WqbP8v0nPYgwiSYWbyTxqADX5mEy0y8C8EtIkh5i2vk1tuDY7G+oc2pX42l7IY1HFjNHcn5T5jm+dJP/STr+PHF0GKhyy+vK/9IingVDDQ72+i0VO243v5mWLKi0swFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LqWlm7do5dhcKQcKUBo5lauX4m4f79tFnTIC1Cw+Sgs=; b=1PJsw6dibTiyDJhEMTFcd0Stqdj9Kc2jHy8O3FHxrqKvlvvyDnmaSQF8e7CN5dGZ0JM9HOufQMu2hAObpkGtttH9hz0cbvU1onEr//0a7nFHZt5XRgPrMPRL8tnonklnUXdAXdF9IdnsOcQuVlH1oQf9ekLr32komw0+Qz4W68eqM0p51rLXAfAvRKITZZ/u8VZuWPBbyAl80CgVMEww90W8t3OYccob+EM8SsZrBoC8X28NvbwuGKIinZkIbWyKE+fCmjm7JUIVSnQ3P/GRRF/Vy48JAo6i71RCuB+DTzC4o6lrKfBMEtTu/lLBBUxpLkBB3HK05QRvy6Gb8420/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6302.eurprd08.prod.outlook.com (2603:10a6:102:ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 22:24:03 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%3]) with mapi id 15.20.9160.017; Wed, 1 Oct 2025 22:24:03 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mikhail Kshevetskiy , Andreas Gnau Subject: [PATCH v6 09/13] spi: airoha: avoid setting of page/oob sizes in REG_SPI_NFI_PAGEFMT Date: Thu, 2 Oct 2025 01:23:42 +0300 Message-ID: <20251001222347.3386506-10-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> References: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0447.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::13) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e9ee37e-fc15-4094-c20d-08de01393a3b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mxIUBaPm7GJn7P5V5eyaoF34Y8ah/Wy1tdGw5wB5PQ/xxF/aG1K/wK3Y4F/t?= =?us-ascii?Q?kmDdQa6qBga9HLcoeXT1K+JqYwX+UfLMKIzVOREvk+5BcRjJ6JCoANR24e+j?= =?us-ascii?Q?eB53lj7ZPxRuRVMDbWfCkuAHu/LiTG/vKIZOYDUUxTnVpZAzwh7ugS+Aya6N?= =?us-ascii?Q?9wZWf9UrAl4x2bybvHc3Cjv6h1lqlZpCktOHmfIwTLEY3TmvjLEZqnuDMp6B?= =?us-ascii?Q?yIi8Naz1+xARDHFweipabCTFp3n8S828kSCN9/mCjvT6n1ZSU0Irch61VwAn?= =?us-ascii?Q?S0+YEWQtzQXSJETouwV5AfCQD49sCzNML9ocEeBGY4AfhlaJUFihbt/K5L/O?= =?us-ascii?Q?fLLsEgu3ozHETcYfHCwhiY72mfgpBGOpig3tI870sfcW60wXYIF5ZNXaUiLO?= =?us-ascii?Q?tEvavjeF7GEKCuob1xlTRm7v/NpgQ16jLphtzFuUDDFgRVYkgzH9t1M8bDiD?= =?us-ascii?Q?hIFf1aACeWkrTI/jz4tWr52T/x/VhVv8yEW8TEzZs6OtjOBm9xgyaajG6wdr?= =?us-ascii?Q?TGhme1u9SWOZgUMcc3rYlOGzlOJkPtOP1hMvlSoeDTkvDA3yWH8uhA0DTwhH?= =?us-ascii?Q?ubhA9X+rkqK0Wl2B6rsI9Wm664j42uIxqaBRXLOaMuObFe1vEOkSrkCWq0Og?= =?us-ascii?Q?a7ao718GbMpFkPn/kYKxI2aUucEJ7JLQW8KiARTRPibAy6DWZHT4a8HiZj/i?= =?us-ascii?Q?QTYV2NEtw3LmKD/dPrQLT9Ktqt5nZle9EQbo/kMRQHHidwG47gSu8OANHtEu?= =?us-ascii?Q?yKGC7WNCj2ocSlm3O0SSuz/m/kBLqQTxBH5vz6YDP5SdzEMdb00jw3E+kwDs?= =?us-ascii?Q?wSnhXi7BEfo2WMqwO9pPM3NhFr5F/PfY1qdw0Y1QE0wGoIm4vswrz1mIwNDh?= =?us-ascii?Q?3Iqa6rn4/KiLXLpz5Y5KKKG5yfRfxWZkUZ7tE72mbUIEEsr9O17jaupGVFKq?= =?us-ascii?Q?llp8KuzawU8zotoPiYw/JsR7amTf2fh9nx0VWGfUXV8wmFrw26zvfki8SCtT?= =?us-ascii?Q?ZVyYkorXNTgj8BjR6GzrmOh8PGtirJqqRMnqlytJV282IHqAbWJ+Glp64qw0?= =?us-ascii?Q?/KHBCWwhW9BlSz/gOLyd3Qi2Me9HzTY1Tewl5wsgUm+1VMfF0dkfyBYcmmjN?= =?us-ascii?Q?dN84WpRcnxPzyDd5l0kLmzVMgRGLj8eLcoIZJ8tzw3LReL1hIYX20TngDOFe?= =?us-ascii?Q?5+ujCQQtZjRnBBDBZ19EQ5r3FrDkEn5FXUXSxmXSH1F3W8YRAwQpZHKHGAsT?= =?us-ascii?Q?wTyBzON2kwVVFMaUzXWSngsTOTGT89/G7ezh29aacNUZRVF8FOfLkDMcPTsu?= =?us-ascii?Q?S7eUtwQxGhA8FBKaS3/oerjyA4sfHWZnjDUjyAFtyijgMRoA9OYeqElLKEMm?= =?us-ascii?Q?RXUyWR/4NQuDE8MvVxCO2KWKjgF9ZEwkv1+S9qVKdBnOcxFdS/HhO3/9L99D?= =?us-ascii?Q?RUfOMzabym2NqTcEK+28/7IA7MJ6RCb/XetOVbEEEpov/y4IhUAp6PLTAgpW?= =?us-ascii?Q?BJplS1brhbJJa0R64JlXb/kMUojEN/gXySfS?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?h4KWd3iq1IMd1ZOSwCBkaVFGHcgNKOu7DQwbOdtibPc3vqTZRlWTDbpcXob4?= =?us-ascii?Q?GHTp1uGiRlORxrLk39cvHZzxo++6wBoEPok6YANiofGKRAqmt5THeetxHE7d?= =?us-ascii?Q?FPSN69DrgkF81mDpSD+1uvno085BmbGOWDDu+Xd1Cd4gvoOVfCsCItUiLP26?= =?us-ascii?Q?EK8lKuKYWoLkT9goIl354WGE0zqdfvgeGxOusIR93Gxia8+N88/t+GQIvGex?= =?us-ascii?Q?PhWbCKniME8HWS6p/DJDSRSNvI3Cs7Tnf/yz24RUCXR7CIpVZ7NGueaqNoLS?= =?us-ascii?Q?LOZFrAriEOWtf6vV9BzveC3XirseREpzkzLvuwUNraZ/gI4gltWtKcaOqQgr?= =?us-ascii?Q?fG/IK9GPALyxBOJIiYZfriowBEIm2ougKkuGs5YSzE0HcHwarSMVhgBQm2mh?= =?us-ascii?Q?SxB86zMTb1zEO3yguMFIpGc+A70VHZrIB+faQqnZ9Kc+yMBZiL4YbvAu5iay?= =?us-ascii?Q?oLh/qXRYkTD453ht/lxCPi37Bpu6bWSGogg5qmge3BV/99e43vfDHHQoNyW8?= =?us-ascii?Q?SyxQFSMPPGsk7PI5R3cJO88P2J6rA0bMIvIjB/8APu/oRRXqkUMqzeIgCviO?= =?us-ascii?Q?N9B1cyy49lxz3JR8m/cCRqp6vZg6sDwcaKrEgOuvUEiYWmd1WCUI9Pjckvdg?= =?us-ascii?Q?NTBHN1aoFofNuf6fYUlELNOsoc7/l15kcmKlgddnvIouZhUyYy2iNE0gSbu9?= =?us-ascii?Q?5JCWyLvZY08LAgfMV+nYjsj5oQhZIqTOJiJ1KcIVub8bCxCgIfFwyXY+umC9?= =?us-ascii?Q?lDua2DREF5ODJiW1UBdFfzM/HBM8bYBpeY7d9eb68+41OKlngD44PZCsCFEV?= =?us-ascii?Q?GhS6cPgJzcgWgc/VU+hSOf+1NfEVpj+EnROrg5D2ptD7O/5dwoPqUh0gQH0H?= =?us-ascii?Q?kZCd4L510PWYO6mICZJ0zIOX7j9xpanJ5hr42BPWalhPJJ3RK8IbAmKLgxNV?= =?us-ascii?Q?icqO5hlmbSU2Gr/MsRAuaOj29ZKPiNrcp5Rd+Hx4XEpGj+9DTDg0na3zkO+v?= =?us-ascii?Q?NbEvCectfhf0l/LikhuqbL7sNLNmUmVTB7v16a5XyKihV6BCHC6L1cXEObZw?= =?us-ascii?Q?c+DYRUfbFNzjv/6YTmwkQSxNq9bFB0RX3TiQnYjvEk4eSDho00WWdaWumy5J?= =?us-ascii?Q?4C3d/aQPN257X5YxJVI4e5rZro5Vu5ajhX3HURnPW/GeYn/ZTOywE0YkPS5z?= =?us-ascii?Q?by2iUV08gG1T6O6FqKFdRGHfeTw8iFYgpzyfyiifXq8E7Rz3Ge4zBSdFyWPy?= =?us-ascii?Q?sEhFI8zKTBSRv1B5yO30dxIDxSZZak2BEsqmL3IuxnFFw+0aZxtd9E9b2uDL?= =?us-ascii?Q?Ru02JIiWpvx7qwlQRu65dvNh0Y31xVOKiyzNTM8tWxQt3O91Z5MaMu4kfsRP?= =?us-ascii?Q?JRwy1VFb0stp7B/19M+PCJfR6tuHEI+y6W4lTCavDkJS0h4JfMx4erFDVa4A?= =?us-ascii?Q?f0iy0qM71Tn5hnSxivlEEKcBv7mBNN8TDEdMJYDhYShoY/LuyP4NwCf09z2Q?= =?us-ascii?Q?viTUCoP2LTd306gzOE5jS+T1wiCKs91hiaxVuCXg/aEfebVKhd/KhHv7lxiQ?= =?us-ascii?Q?O5y74ZCPXTGsdrDSmJFwH191UJx32chJomC8sjVKcJuDJdM0yAtchJlbc5Y2?= =?us-ascii?Q?JResXwj6wqjSvYp3Zzqwmyk=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 7e9ee37e-fc15-4094-c20d-08de01393a3b X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 22:24:03.6491 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jYEaTS5LEEphOLJe5RcUbNINtMBU21drQvqpJDi5HxHcnB90MGHU0HyAc9wPDhPHZnj+ksp8Gfr90v22iSzfQngs764+o8MJaTNlOh0Mr7E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6302 Content-Type: text/plain; charset="utf-8" spi-airoha-snfi uses custom sector size in REG_SPI_NFI_SECCUS_SIZE register, so setting of page/oob sizes in REG_SPI_NFI_PAGEFMT is not required. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 38 ----------------------------------- 1 file changed, 38 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 744eeb2b24ef..719b424d4cce 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -518,44 +518,6 @@ static int airoha_snand_nfi_config(struct airoha_snand= _ctrl *as_ctrl) if (err) return err; =20 - /* page format */ - switch (as_ctrl->nfi_cfg.spare_size) { - case 26: - val =3D FIELD_PREP(SPI_NFI_SPARE_SIZE, 0x1); - break; - case 27: - val =3D FIELD_PREP(SPI_NFI_SPARE_SIZE, 0x2); - break; - case 28: - val =3D FIELD_PREP(SPI_NFI_SPARE_SIZE, 0x3); - break; - default: - val =3D FIELD_PREP(SPI_NFI_SPARE_SIZE, 0x0); - break; - } - - err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_PAGEFMT, - SPI_NFI_SPARE_SIZE, val); - if (err) - return err; - - switch (as_ctrl->nfi_cfg.page_size) { - case 2048: - val =3D FIELD_PREP(SPI_NFI_PAGE_SIZE, 0x1); - break; - case 4096: - val =3D FIELD_PREP(SPI_NFI_PAGE_SIZE, 0x2); - break; - default: - val =3D FIELD_PREP(SPI_NFI_PAGE_SIZE, 0x0); - break; - } - - err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_PAGEFMT, - SPI_NFI_PAGE_SIZE, val); - if (err) - return err; - /* sec num */ val =3D FIELD_PREP(SPI_NFI_SEC_NUM, as_ctrl->nfi_cfg.sec_num); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, --=20 2.51.0 From nobody Thu Oct 2 00:53:54 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020128.outbound.protection.outlook.com [52.101.69.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E375E3128C7; Wed, 1 Oct 2025 22:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.128 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357456; cv=fail; b=txgjele8M2aUct8nM8sbaUPHkkcMkZG8VQ2PX9JT1t3QmUHVjEXKXMTcH++3wvH1fgBlxN3Y44iA21gPK57zvANjK4JpWURdnzvPoxWjELSfkgCDQxYp1bwUQ21rUHufSNwoJQ+Wl0uggUMJb1IL8KDKbCefYCXUrH18MkQP2pk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357456; c=relaxed/simple; bh=cBHsnFZtmlxn0wHvSPe8hsUcctWdvufB77xOkfG7jHU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=GWa8P1XWyyhmK0WO0Q6lBWkrOjWGCTPKtYaTwV22B5VBECvoBj9ygmJIAekWKK38E62kijhiUwM1TjS8060BJk8p3SzcGA/iIaJ1r7Zno295WsYcENCdhxb4jckJdp4dtcCccYlxyOnnCFb9VTXgpHSLBId6n6RMY7K+C7CK5Jc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=2r8qyoc2; arc=fail smtp.client-ip=52.101.69.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="2r8qyoc2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=a2oeLdEUW54sgkTvt+EanagXLv6X8YtuwpNW6Kc+jUaafizGXcHvqBeihkKMIradHzQho4eU5qaYr9KdBXUJmAzwWz+fspmo23iWEUnXWLYGplmQTk0Aq/sHKKs+zSYdS7KXgEgpJj2XgTseUSB3qfHnUUSwJ1Ekx3oD0mL9rf4Vunk38alACYErH1jGU/z8y3mDcTLZcTjuu+yrFiiOcYflw/bFnw2MMZ2mnHrFm8IZ/K95vPu4RmnYWxzdnN915WbSLEgxsFL3t6/ylO6BCHD8WyiFDIVqTnwmjYFMWZcxYrX1uaPTr16+a2pzz8ck2p8N5Yr9Mq8OfFKCAyr+HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XaeR23XjV99KyKxtEKYRWyvyl2v/64v49i3KS/BYe9E=; b=TFpvLqu7Ssa8azu2PjTcAbrXd8RiVkuMzlL+ZBf2Ig8KWBSK4jiZ0Bm1mk673a68c1Xee+KrQHyj4YKMUY93C3U4k4ncVReD4ogV1SvfHw6nq/ABN99g4ly3/Teji/ACw5akCMDP8qQUxjXQ44nt+ekO2y1fG25jB9biaYJQbnwBslphxiEPYsDcqjYZBEOsjAKKYrSsX95K3ioleoUHwWj5e3DBYk+RFMz0NG0cir017J3ecCRzknqntWNYxNmnblgjT8s5We6qw/lNkkNLv8usij6iXDujmr8LlbCsauB5tUD6aMYXX+7n/i9m2oKYvRHYioTdfGuXBSVCXO83qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XaeR23XjV99KyKxtEKYRWyvyl2v/64v49i3KS/BYe9E=; b=2r8qyoc2td59QwoqRwMpebZYHKgQcL/c7WC7w3BANnxirvk9q5tSs/TV1qfFKZL20RZkq3eWJdbwJreDwhrdcLWRd4xBtgO6y+3KNL3eqO2RmRII8nLvm+MK4RXDR2HMKHFzwg8F+EStKUnSM1FAT6IwVlO18DCa+HiSHR1krJHQysiVpd2ux37yF1ZtDp2yLSwzbKA/Ofdhjqb3HB7kvR9Y6S5onVNFffTnJ/HLhq431YzxdO8qqNyyfJa9f+ew1Mcj7IwLQAtX6IEYxbA1xR2nJKRklIkAoUPoD3hWmvjf/a+M1qeMsAItSTimWNLqXS5T/uK79FijrrpulQGd4A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6302.eurprd08.prod.outlook.com (2603:10a6:102:ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 22:24:04 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%3]) with mapi id 15.20.9160.017; Wed, 1 Oct 2025 22:24:04 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mikhail Kshevetskiy , Andreas Gnau Subject: [PATCH v6 10/13] spi: airoha: reduce the number of modification of REG_SPI_NFI_CNFG and REG_SPI_NFI_SECCUS_SIZE registers Date: Thu, 2 Oct 2025 01:23:43 +0300 Message-ID: <20251001222347.3386506-11-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> References: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0447.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::13) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: a2c998d3-d1a7-4a77-249a-08de01393ad1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?MxuT8jtFNR6vMZ7DncefJjsAuOo9nU/r/OEce98ewP/z3h7n7LfzUQV7Qsgx?= =?us-ascii?Q?lyrwwJ7ap/iPmODHMFJjeGdOILe6BP7SYtixNv57w4wPw8FExkKuxTh8iOJ3?= =?us-ascii?Q?2rguIyri6bdxz7qiLV80GfyZaxPEdEVDzz9nI0N0QhOtMQwBZkQb8pebmo1a?= =?us-ascii?Q?J0lZk13SK+HEzFNtxFNF6WRLlJJ4HxdTsWa5Lyq1VVMUqQyP+qAniLQYLvDq?= =?us-ascii?Q?H4PrIPy57SWndsOhmB1A8IkmVUanktnHZOooeuy16kSIxlYYGbZQ9Edf5qe+?= =?us-ascii?Q?SunMqlU3HGqNABtOoA3YHMTvbv0CBLVyeAPdPhGZx/kJp8fJOQbQigi7SZlj?= =?us-ascii?Q?fUu3ET+CfU/ss0GGeif9/rrX2929wV199/SvuBSZmFXSbmPb9Q/TyK0UFKs0?= =?us-ascii?Q?wAs8lelVydrCB3GGfbO/m/wjblwRpD1GlR39FMIYgLmwlshn7G0TZwh2/S9l?= =?us-ascii?Q?UbMiXpILUkST42jWhWLMLlHIrM7P1n9Bd7RdgkvfdNbr0GP1/Ri/H6QTPEZX?= =?us-ascii?Q?oES0br36dqZds+Vi9696aWE7yTN2XCnzd0I4ZXNwC0XsCGAOht+xxnojzgSB?= =?us-ascii?Q?psru0/vTPzFClx5TfLoYU26u+gJqudm6qL75k0QzYqKWqRrbaxCU26ez55ac?= =?us-ascii?Q?03qWmiTSqT95FXcfTG9l2K1Ia5crudSODPwI0pGB+EIEeUgock5G5KdgBXez?= =?us-ascii?Q?yyvhMRIzS4JDU5LoesSvlDz6wZPS9dqJEhrNjoX7gp9aOeqXaUm43xKhLuH5?= =?us-ascii?Q?69TVD4ny2VsWUaM2MGO6jicQifoenSvAxyu2DAzbGgNNCSJT3rmDMcLd/Gpo?= =?us-ascii?Q?Dd0goAGDU0RdoAMNzymf7sm8fHxLQMc7JYNxx6WNc4zbb59/NHEYtzCVqWaA?= =?us-ascii?Q?ASjlnOTfg6YgYl+huU5rEFmePxzEIfgaxjK7KfPyB9LNc0Q5y7H/z74Ws2EW?= =?us-ascii?Q?l+RJ09UH1IwNMwpIJab19VuYsrcO8RRTW31jSXblXQu6HqhEQdIxWMQe5Czt?= =?us-ascii?Q?VDYFtvxQZRWoE/JXFdAwBw/PNxZUaNct/ahWAz+WX/fTTfMATPM5t/askE4V?= =?us-ascii?Q?Y4mjyuaRJkbDaKZoj7JLWf25ZKQYNIiIs2EULf0bQtdVq6fGJylxAFjspeUQ?= =?us-ascii?Q?clFm3C4eWLvOBqVlnqm85hvVi90Cu9iGHtB8L6XXprw7W8dowcOLK6dU2bCb?= =?us-ascii?Q?jpN5nPZcNtJuO58Dd+n4loFqeAV07kLLCGqA93d4xpUrtGYCbdcL0s0zAnIc?= =?us-ascii?Q?em6RvMYLn3Oa8lL1qmBCcvHhi51b05jcQS4Kx1TQ0E6wX62vWCnSwPKyOath?= =?us-ascii?Q?Cug/lozPcaAI05ymHvNVpthq+RWGa2X/iJsGRbPAzJixfRMIlDyJuaaQmq/3?= =?us-ascii?Q?3B7cpkd3bdleqtLHa8j+wsu5CD1mFMPGBAwQx7HCxcd67sseOmIvjfaspPpL?= =?us-ascii?Q?53KmHC7auQdlGwBwHjln73mtjNW8DZgWFhuu8TmsAK4g+eNi74F2gBvlMVOL?= =?us-ascii?Q?8WOOwADE2z3vR4qD+m3fzOV6XHULmzifi5Ay?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cma57ki91a5oGS9a1Ewa2adoIKUGrOpJd1E5kGSS/X4Eo8b07FGJS+haIDG3?= =?us-ascii?Q?uXhy7QBfQGHMxvYWbn9xKKok4lJxUXRRZKAMUUbaLPjAQDXfDJ6/T2TeGYNf?= =?us-ascii?Q?RROMfb5eFpZ3mFbOXxD8Qf76SwtJkU0LNxz7k4weUSiFhpcoMgOzyaFdE8/1?= =?us-ascii?Q?L5TTGcpBFdrn5j9dqPcVuwM1wdUjWTMzoK+DlI0ztiR7pOLljLhy3nRY9pik?= =?us-ascii?Q?zvY6XmjVmFh1Ag6ZCWQWAln4qDcWvjoWujzYr/S19MkGSapSIWNnZGMCJSaR?= =?us-ascii?Q?j9+89Z4xsmh++3V9Ry1gp1kBZfKFp6ZhDXL+UoWgo/jSGI0bvOHTjjn7B/EP?= =?us-ascii?Q?T+YBM3b+U/qRNqxkLLREbBd8M+7M3YO+dsp8ZdMUpEZljkrifXlPMZYVqTTA?= =?us-ascii?Q?CDDdlu8D9KwbBXPgrLtzto7Iicmmz/ZAtq3b5T8gW6cSL/8D0UoCK4XbzwBd?= =?us-ascii?Q?c/6+ik8wpHA1TJFwermN0cuSvfCO0d1Nll6vJ/pnRvc3r0BeQJIS+JP5JBXm?= =?us-ascii?Q?0WLaGd6piqz9emJoRio+xCQ3uqrDN/ewAQ2hTmpbil2sOVo0/xnJ5AewDIdX?= =?us-ascii?Q?04Q+lgS8aiyaUFmcaoLCXAEFibQPKa161gCkWAgHE3w2keI9HgVd/TnpKVoc?= =?us-ascii?Q?c7gbB8d4xRzdfG3+YUjwhoSxMT9hOwhaLU1AFlwQhqAHhXVpLECeVb/zhWj2?= =?us-ascii?Q?21ZHKwAhxlOaYkdf7ORF0UL2iAUbz4lkcRRiG3JxEH9KWYYxMtvw90GgE9ij?= =?us-ascii?Q?+cDKXEe6zf7zpuSz22238mqtvSRojcMFTG9U95vPvE7Jx0dzdmlX5kzB97oR?= =?us-ascii?Q?rwO6txNMTza2FcunRhCjIH1HuBiw9G0dhmQ/gTkz7Sxk11t5WYn2KtXMmi35?= =?us-ascii?Q?sHJGHsRoXsBAmSfirgB/r0KerUlbluGFdVk8EqfqmhucGNKEFFPKpXF68QxO?= =?us-ascii?Q?IU/RoQ0uYTVZro2gSqv1Zbgvmr6SRxRf0oXsd/bih+lAZfqb4FlAzPEwaVFl?= =?us-ascii?Q?b3gAhzl7HyjkiUpmHxJvBkdQ+tHeROasklGm6+oOe9Oa5RPOpe+vmKI0HJ7u?= =?us-ascii?Q?uP/svP+Kin2hYtyd3CgM4jsJQxdFwKdpPQCKLMFJA0GWkH5+WWd2hu0bUFMb?= =?us-ascii?Q?940llXiWWFrSDVQsf79rH9MDx1LzKr2ry65GM6ys/TEwNpX2JkWhzQSi/VDV?= =?us-ascii?Q?pif9aSEWTfmuYEmDRtleGxffIEtoSpyyyXQsu6PhKqkruO4fkf6+W8rXNZJ5?= =?us-ascii?Q?F9Y7nPkzB+WELl1QEMRDplxS0gzdQ2mEAhpNWSe1wpyQOO6jU1nrI6Xd1xrk?= =?us-ascii?Q?wQZYqIh1eAqgrlwzXnPNIZSGjMT0UyjP7BDA5we3zrqYv5Mn2Wr9CFKW+6QP?= =?us-ascii?Q?vKpIdR3LpEUlAOe1duey00wH6+DzI6nvrde6mAuZkB1cCHoMdeo6kf8NiN36?= =?us-ascii?Q?RmEMsSp6scfjo8P8zeUTIGlzJ5yrLIg83ViZQ7L+GuHuON2+h612jCo9mFzk?= =?us-ascii?Q?/ictk2W0J97AmTRT8f1SMqA83n/lIQiU46AchdFr06fdxKAarvOxRVuA0hAg?= =?us-ascii?Q?FmL/YVXqdhdrGiQyp2pI+CBkA+pAF5W4DXB+mlyPKEPYbSssf87gFRi+Smzn?= =?us-ascii?Q?n+KAvu7VvJ4oenHloUH4CuM=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: a2c998d3-d1a7-4a77-249a-08de01393ad1 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 22:24:04.6036 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8ywXdchVs60QJ8gDtdXNNMmxgwBfPAt8B1UvXLtbyFLtnKNJ7NRQ8BoaNg0d4mTVKTXa1E4BXikWx7cPPo2qtfh4m0bAQigYLlrqJiNU7UM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6302 Content-Type: text/plain; charset="utf-8" This just reduce the number of modification of REG_SPI_NFI_CNFG and REG_SPI_NFI_SECCUS_SIZE registers during dirmap operation. This patch is a necessary step to avoid reading flash page settings from SNFI registers during driver startup. Signed-off-by: Mikhail Kshevetskiy Reviewed-by: AngeloGioacchino Del Regno --- drivers/spi/spi-airoha-snfi.c | 135 +++++++++++++++++++++++++--------- 1 file changed, 102 insertions(+), 33 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 719b424d4cce..3fb76e2dd5e3 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -668,7 +668,48 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem= _dirmap_desc *desc, if (err < 0) return err; =20 - err =3D airoha_snand_nfi_config(as_ctrl); + /* NFI reset */ + err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, + SPI_NFI_FIFO_FLUSH | SPI_NFI_RST); + if (err) + goto error_dma_mode_off; + + /* NFI configure: + * - No AutoFDM (custom sector size (SECCUS) register will be used) + * - No SoC's hardware ECC (flash internal ECC will be used) + * - Use burst mode (faster, but requires 16 byte alignment for address= es) + * - Setup for reading (SPI_NFI_READ_MODE) + * - Setup reading command: FIELD_PREP(SPI_NFI_OPMODE, 6) + * - Use DMA instead of PIO for data reading + */ + err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, + SPI_NFI_DMA_MODE | + SPI_NFI_READ_MODE | + SPI_NFI_DMA_BURST_EN | + SPI_NFI_HW_ECC_EN | + SPI_NFI_AUTO_FDM_EN | + SPI_NFI_OPMODE, + SPI_NFI_DMA_MODE | + SPI_NFI_READ_MODE | + SPI_NFI_DMA_BURST_EN | + FIELD_PREP(SPI_NFI_OPMODE, 6)); + if (err) + goto error_dma_mode_off; + + /* Set number of sector will be read */ + val =3D FIELD_PREP(SPI_NFI_SEC_NUM, as_ctrl->nfi_cfg.sec_num); + err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, + SPI_NFI_SEC_NUM, val); + if (err) + goto error_dma_mode_off; + + /* Set custom sector size */ + val =3D as_ctrl->nfi_cfg.sec_size; + err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, + SPI_NFI_CUS_SEC_SIZE | + SPI_NFI_CUS_SEC_SIZE_EN, + FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, val) | + SPI_NFI_CUS_SEC_SIZE_EN); if (err) goto error_dma_mode_off; =20 @@ -684,7 +725,14 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem= _dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - /* set cust sec size */ + /* + * Setup transfer length + * --------------------- + * The following rule MUST be met: + * transfer_length =3D + * =3D NFI_SNF_MISC_CTL2.read_data_byte_number =3D + * =3D NFI_CON.sector_number * NFI_SECCUS.custom_sector_size + */ val =3D as_ctrl->nfi_cfg.sec_size * as_ctrl->nfi_cfg.sec_num; val =3D FIELD_PREP(SPI_NFI_READ_DATA_BYTE_NUM, val); err =3D regmap_update_bits(as_ctrl->regmap_nfi, @@ -711,18 +759,6 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem= _dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - /* set nfi read */ - err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_OPMODE, - FIELD_PREP(SPI_NFI_OPMODE, 6)); - if (err) - goto error_dma_unmap; - - err =3D regmap_set_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_READ_MODE | SPI_NFI_DMA_MODE); - if (err) - goto error_dma_unmap; - err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_CMD, 0x0); if (err) goto error_dma_unmap; @@ -815,7 +851,48 @@ static ssize_t airoha_snand_dirmap_write(struct spi_me= m_dirmap_desc *desc, if (err < 0) return err; =20 - err =3D airoha_snand_nfi_config(as_ctrl); + /* NFI reset */ + err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, + SPI_NFI_FIFO_FLUSH | SPI_NFI_RST); + if (err) + goto error_dma_mode_off; + + /* + * NFI configure: + * - No AutoFDM (custom sector size (SECCUS) register will be used) + * - No SoC's hardware ECC (flash internal ECC will be used) + * - Use burst mode (faster, but requires 16 byte alignment for address= es) + * - Setup for writing (SPI_NFI_READ_MODE bit is cleared) + * - Setup writing command: FIELD_PREP(SPI_NFI_OPMODE, 3) + * - Use DMA instead of PIO for data writing + */ + err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, + SPI_NFI_DMA_MODE | + SPI_NFI_READ_MODE | + SPI_NFI_DMA_BURST_EN | + SPI_NFI_HW_ECC_EN | + SPI_NFI_AUTO_FDM_EN | + SPI_NFI_OPMODE, + SPI_NFI_DMA_MODE | + SPI_NFI_DMA_BURST_EN | + FIELD_PREP(SPI_NFI_OPMODE, 3)); + if (err) + goto error_dma_mode_off; + + /* Set number of sector will be written */ + val =3D FIELD_PREP(SPI_NFI_SEC_NUM, as_ctrl->nfi_cfg.sec_num); + err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, + SPI_NFI_SEC_NUM, val); + if (err) + goto error_dma_mode_off; + + /* Set custom sector size */ + val =3D as_ctrl->nfi_cfg.sec_size; + err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, + SPI_NFI_CUS_SEC_SIZE | + SPI_NFI_CUS_SEC_SIZE_EN, + FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, val) | + SPI_NFI_CUS_SEC_SIZE_EN); if (err) goto error_dma_mode_off; =20 @@ -831,8 +908,16 @@ static ssize_t airoha_snand_dirmap_write(struct spi_me= m_dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - val =3D FIELD_PREP(SPI_NFI_PROG_LOAD_BYTE_NUM, - as_ctrl->nfi_cfg.sec_size * as_ctrl->nfi_cfg.sec_num); + /* + * Setup transfer length + * --------------------- + * The following rule MUST be met: + * transfer_length =3D + * =3D NFI_SNF_MISC_CTL2.write_data_byte_number =3D + * =3D NFI_CON.sector_number * NFI_SECCUS.custom_sector_size + */ + val =3D as_ctrl->nfi_cfg.sec_size * as_ctrl->nfi_cfg.sec_num; + val =3D FIELD_PREP(SPI_NFI_PROG_LOAD_BYTE_NUM, val); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SNF_MISC_CTL2, SPI_NFI_PROG_LOAD_BYTE_NUM, val); @@ -857,22 +942,6 @@ static ssize_t airoha_snand_dirmap_write(struct spi_me= m_dirmap_desc *desc, if (err) goto error_dma_unmap; =20 - err =3D regmap_clear_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_READ_MODE); - if (err) - goto error_dma_unmap; - - err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_OPMODE, - FIELD_PREP(SPI_NFI_OPMODE, 3)); - if (err) - goto error_dma_unmap; - - err =3D regmap_set_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_DMA_MODE); - if (err) - goto error_dma_unmap; - err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_CMD, 0x80); if (err) goto error_dma_unmap; --=20 2.51.0 From nobody Thu Oct 2 00:53:54 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020102.outbound.protection.outlook.com [52.101.69.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BE7E312816; Wed, 1 Oct 2025 22:24:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.102 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357456; cv=fail; b=kB9S3us/wYgvTSCC4gQq5bu787iC4KWBMWYHdY9ZW8jDO7yz8PQqG2bhf7fbDg4/Gi4vzrFSjH8x8JPlMRYgF3E1Yw/t74mACuSnlTeqxuOWaRmAP7vhPz9qz7PJMaPTo9OH6e2v52jKjhLD7DrJBS4Up08mSUk9J17zAfotWB0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357456; c=relaxed/simple; bh=RiKbo/qwhlU6jP31RsuFL9gEwPwjUa/P/53eg/G8Wy8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=qdN5MGuALSax7NG7wYnT52E6apcvd6/WqaBaUtY29teVO+k+hwdHMFvG4IfdjWGzHup02JAc3DKWKDS9U4FszUfbBhqdgWjeWRdhkuFbF3oBV0fRciKdKMsIElezIFTVDm++fuQ8P9cCA/TQnY8HVxzulbrxOs9/Tq0/USArk6g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=OyLxFIOp; arc=fail smtp.client-ip=52.101.69.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="OyLxFIOp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gErU7mwb4T55aY/0L/ZGE88SHMfha5SI1APsFvsYKMdzgam9cnybMXikxJjFV8ScJcRRNWe2+TwZHi5/MZJgGb7wQ0kdeKYku9KeDk/KF8qyg8mPOiODVxNTNIhxZmru8diMLDgHVGxjhy2Ukr7qETNnTrXy/lKnHrkTgdDdi+i0jxTPfh3T37ChSJha6KkVdjJhMtv0Axs8JcYZRLXz7I7Rxm5FcMb+qP2ByUbfYJygVUUSp350RVkKL0Su5YKKo/K6ScV9V3LQFz5tufhwjoN9vZ+r1/hRYKBNOyBtqyhYTRpiQIcwxmSKSRMXBBp7YcNYDwumlv10U0/5+TWFeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iSyv9KzWw/RI12dwfNpi4y8uBoDZVv0XdyTCW2gY7B4=; b=VLz3/koZRV+3Lgp/LsC3jIZG73+qEKZzNgU8ufyoSFuhbTKum6a7+9yX4Pn4RdwXddgQ0XRvZW/PnKm58UjERNU/39hGtNc1+vW4PeVJBI7IzmmJRA+pAMrTACIqa9K6vfP/Y9/s+R6Ohzjq8fnvW9cjLG+VOt8FX4zkS3qKQlUp12dFu3DZ9UTVdvd+rYzlU47z1rGu2kZvRVOmW6sIfm+as7ogq8PwwgpRW0ZFnXG/KKO9Eq6AV1sXIjSgKbEX50WVWVsYBMsuSM6FYOw7hV6KXF1pgtlOoOreZ1eCosSLrBHmivVzYSExGtPlJ8kDIB4fSkSSxOa2D9KR3+wllw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iSyv9KzWw/RI12dwfNpi4y8uBoDZVv0XdyTCW2gY7B4=; b=OyLxFIOp64Xo2mvWWsCQUHh4xBnvooG3loq4xGPS84D0p6E6haNqBiYgIm4ZCyFXbSDfVwDsO8O25MGRNDeIm/c+ewvKdwL3ypghOZ/r4EKPqML25zKxqY2jgAPMSBUF7BaGzWthUWFRSekUQ2u7ysXg8Rjl3liZrsFFAJceraY86ti5ruKAAtSgbIJb5F5AUAk+lLHeL0HfSD1Kff63n5iQnj6SMPx3nmru/b+8dYD2P778eEgofUQvdpZiCXO0z2dQRghoXn6tdRD+5TCMbPwXCeh63tYEZFzld5d8TrV/n7YN+SgNwItje9LROwZ2jeboFRsaZYBdBUNcoYLK9A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6302.eurprd08.prod.outlook.com (2603:10a6:102:ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 22:24:05 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%3]) with mapi id 15.20.9160.017; Wed, 1 Oct 2025 22:24:05 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mikhail Kshevetskiy , Andreas Gnau Subject: [PATCH v6 11/13] spi: airoha: set custom sector size equal to flash page size Date: Thu, 2 Oct 2025 01:23:44 +0300 Message-ID: <20251001222347.3386506-12-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> References: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0447.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::13) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a3a060a-9320-48a2-20cd-08de01393b62 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/0I11EGevuvyMEDt6kq64wqjL+vNVgXDfrD6rpPw7F5Slt0eLQPhgasvN933?= =?us-ascii?Q?xPkSJU5zAO+lIea/tSgK+kB7LB+4HstOEIeGKdGGrquvTGXMDkywBXMScAZ9?= =?us-ascii?Q?UERalIkkrG0jcHz7pv7BdRJtarIvMIqUxzQDxWdH/QU4g5xoeE09yBCR2GrX?= =?us-ascii?Q?CvArmGjIy/2mH6IDnhmKx+EBnrPtTYwXRm+6uuZzzkNG7tOUnsD6xfmzbV8C?= =?us-ascii?Q?c/GzYRMb7H52yXwixKfwYW2PsWk9xksF9DOOzkkMU1ls/zVWwemmvu2wbgSd?= =?us-ascii?Q?6CBoBw4L3B2S/JnlSMFLqe/1zmh8eYt4CK98gxdeDFeijT6b2DAzlrRI877w?= =?us-ascii?Q?IhsJbZlZH8QBQazzyxEYZZFGEMSKB+CFVv+MvAtcJg/9Yy0KkEjNyOgMDCWK?= =?us-ascii?Q?wjUMUC//+qciniFaf4a1lKLRMFTDZg3ZEYuLyYLpekNmtLYlr4mqX5BZ0YXG?= =?us-ascii?Q?4DpmxsseDWEOBQA+KGZv1DCcj+RDTNdGWmdTCaTGLn+saUbZ8d21vQRMAxFM?= =?us-ascii?Q?LWyCPVy+sKkOCGuAa+SR7LTUg2weH8cJIaPKgy9oDWUerVexdiqw/qDjf+PB?= =?us-ascii?Q?gDXFpybRgYp0eUdrWzgQfXufSfMchoOTUq/iyAMpZf5pODlfvBnbfNrxvgw2?= =?us-ascii?Q?OQDssW8crXemNwApiaa4KENeunmsKOWHjEVAaS9ueeDJV28l7cc10/2BNZyO?= =?us-ascii?Q?Wt+z+BmfmATJphjtGfxyG6VCubUwO36x/D9sMRsFS5X+iWpXt1kA5BEQ6Rdk?= =?us-ascii?Q?zx2Uc3XT69kUKFyiFvgGEuf8flTEIAqn06OT5TXvcLO6x+oaBnwmmVBooi8Q?= =?us-ascii?Q?uYoMNC9aR5QPJsl+toPcSQikQQVxmPNoK1PmbpQ6neu3XHTBpQD7AfTki8FQ?= =?us-ascii?Q?KSTVGC01R/qtFMbDISUeg+V2vSirbs30WvAb+aBqbqTAy+8P2ImUTdFTRpN1?= =?us-ascii?Q?EFWpAlA2j33T8AGJnlcujPOCEI2CpvlFM+OUpBEIyiAuyOrbvaoNANC2dzAV?= =?us-ascii?Q?digDnj3FB0TV0sKgv4K/2+Pl36qgUBYOvF8dgqcJGobXC9mTxvn7MUE9Z/gr?= =?us-ascii?Q?B1EPT9fGW3y4G0dm3m8U3bw0N8aQMOmqjnpIFocOPBj1thWzFlRE5rtmJaec?= =?us-ascii?Q?MN4+SKbsKMxr+hwNFDX/fVVPwAIedIFEbeoHhm5Gt5J0vMjsnZnh98+3LE0w?= =?us-ascii?Q?GU3qjI5S6zjfjx0jDM3v/hSD9wYXyVTkkE+YlWZ4lna/mlWao4z+oKgK5I1e?= =?us-ascii?Q?Ueno6V0xpDx/tgZgo2ECMm/px3F5HOC17Kz1M/cc4zG/53dhnIZ5gvWYZoy6?= =?us-ascii?Q?5jm55FsyB+IyXHi1Bma+K73lyLaYpZ2DZMyKB5ujdwp0R3eCA2aKMNxx3T+5?= =?us-ascii?Q?7THcHDTEoFrJ4lQCr7Bo5q34xAAtypOyYrn1sqbvpe+eZgVqLe8YXttIkgqf?= =?us-ascii?Q?9iN5FD5MNkaJ96cRnPFgmbxHLR2GdZE3rikDu5cMmKG1o8TFxHc3F6IwqPCx?= =?us-ascii?Q?7CwXlvHOQFOiwBVU1fQGXklfKiVdsHH/Pf4T?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FU22JyoiUAGBnyO6w1872ZrPghaU0Fyj+NiV2Ms3g6WC3H2TZsVCExRgfJor?= =?us-ascii?Q?Rd3odOV3T6O5gG1i9fK7F+35t9Idujm5AturLL1CCE41y5FpzQGO0vfeQkww?= =?us-ascii?Q?rH0eY24/S4PSePPHbvOpsfd7F/hNSaw/1bxIHdx26qkN21e808+rUKougUCN?= =?us-ascii?Q?BmUhvCRlptXZ8feJMpe2aTW5ipma7/uXwT1cENv69jbWEQtofAmrFy1T06aB?= =?us-ascii?Q?YF1WXVDAH0q7W4Bw6gR2xDOIG55TLKupicpu22u6Y7WEK29/L57a02fS8MLp?= =?us-ascii?Q?Kqp1QiXIXZC/VEAO3ychpGLHoffQTB8ZzF/20OeRS9Y3x175BD8DbBbXTPbd?= =?us-ascii?Q?rVn5VVomVn8QEsEq0p6yQABlRJeJfQUSQyHCBPIlycmqtPN9Ne9fOvoAlUGU?= =?us-ascii?Q?p5zHnAELvOpMEo/Mhnrg9QxTVWuQTy8ujKj4dr8yOgMmSjHZiit3z6VxQoYE?= =?us-ascii?Q?LHFXvxFPxR0cHCm9eZimp3NvpBSCVuwovUanUbWgcqu/7H0DA/gMEzgv8k7g?= =?us-ascii?Q?04A/rnQR3WWycQtXb4yXQlh/tICxndD0+pwmpQVbYDAEaGIiDgpVSzlin1Ud?= =?us-ascii?Q?pki6X6Q+aWRdycOzfjdrUtPsjzd+QV5kbw/d6Fa/q7jL8eN0CrSMmvrAZb2/?= =?us-ascii?Q?I8YJ7Da4wizubf43XSyXayttghtGJ/3htU/CR8/wPsxJThkRWuYfVzkZit2G?= =?us-ascii?Q?Mcm0DW/p1YaWkW6SZssBXNOj+ctAoFE08Ti46cfacl77cGXEEOg3AurISoL6?= =?us-ascii?Q?1qhNw5hFv054elQ20y8qmCENydV1EM70+0sp70AlTlfeD+EXehzkYCiTB5Q9?= =?us-ascii?Q?wB3K5dl18+dKOQGerXQyyQNc+gQQh+VTMr0jNVlZrYbDYcJg2K41AACfX41U?= =?us-ascii?Q?4i3p77GPIUY8fxVAoCV6KdJwCLmDF3C3oEorwL5LLjYNvqWSGBUEyYQ4/+LE?= =?us-ascii?Q?CYNiJgPsL+wAgWaqPfBm2OeA3UlY3N0mGm52hTR7LgWwcpPR0OwnXtQBgz2D?= =?us-ascii?Q?PzC3bdNx35SfpEe8BORN0dgwIqgCcDPU/Yte3JTKCgftqx+NQksmvInVdsFw?= =?us-ascii?Q?SvW+86EoNPayldFwkkp2PiXeyTvv9CtJTbHwPK3cGeVVY0e65Kl/Mh5MP6uB?= =?us-ascii?Q?xAS/Q/ooIgsCDNMiPEZxIq5Az/7AQhVnnMiSSgdDqO/hHNlwD87sZv/j265R?= =?us-ascii?Q?drATOOYkkDY5MhhhLVkT1wvruByW+YAu9KTZv0z8gmx2dZtWiIe5MR1hVKSA?= =?us-ascii?Q?jCSjndHotK2S4Fmyxlz5DIcGsegfMt18xEGjM6P5HM80dg4aqlANAWsf+LxF?= =?us-ascii?Q?bhil/4tToWxLNBBO1Lo5lyOlsNhPU7PvPelGOrJ7te/+jKMx7XN4wCDytTCA?= =?us-ascii?Q?srkXQIx45e3JxyKJCDavl3Jsj6+732waOF4Rf9AN4jaybplZTcbI9Qw3gfWc?= =?us-ascii?Q?daR9rSbGT7u0zk2MUuIxb+L9j9LaJwzmMgcKdvWBq8BoVYLVFb1CGa6Wg0V5?= =?us-ascii?Q?CCF/wUBaxdTvPk2ejst42nLrNgKeIq8JCD6VTUK9jzJZEVDKBNtJenzeIw4X?= =?us-ascii?Q?WFcNy6M3hI+1GAeADf57frE6zkyI+KE5Vok/wOPEKB5otIu/WhlCCWGO7Wmf?= =?us-ascii?Q?ybFDLMIadLQwLP59bXafYKs=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 3a3a060a-9320-48a2-20cd-08de01393b62 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 22:24:05.5454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Xu78SVMfFWEXH68GVblyvi+C4MuKIB/feLZOoIzugYM/dsK5N9LOgvcKh2lGHyO6M3AkPgV5oTiVv6SD0t+fGe0uY7Fe0OZLgs+SCkUVIO0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6302 Content-Type: text/plain; charset="utf-8" Set custom sector size equal to flash page size including oob. Thus we will always read a single sector. The maximum custom sector size is 8187, so all possible flash sector sizes are supported. This patch is a necessary step to avoid reading flash page settings from SNFI registers during driver startup. Signed-off-by: Mikhail Kshevetskiy Reviewed-by: AngeloGioacchino Del Regno --- drivers/spi/spi-airoha-snfi.c | 35 +++++++++++++++++++---------------- 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 3fb76e2dd5e3..babf7b958dc3 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -519,7 +519,7 @@ static int airoha_snand_nfi_config(struct airoha_snand_= ctrl *as_ctrl) return err; =20 /* sec num */ - val =3D FIELD_PREP(SPI_NFI_SEC_NUM, as_ctrl->nfi_cfg.sec_num); + val =3D FIELD_PREP(SPI_NFI_SEC_NUM, 1); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, SPI_NFI_SEC_NUM, val); if (err) @@ -532,7 +532,8 @@ static int airoha_snand_nfi_config(struct airoha_snand_= ctrl *as_ctrl) return err; =20 /* set cust sec size */ - val =3D FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, as_ctrl->nfi_cfg.sec_size); + val =3D FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, + as_ctrl->nfi_cfg.sec_size * as_ctrl->nfi_cfg.sec_num); return regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, SPI_NFI_CUS_SEC_SIZE, val); @@ -635,10 +636,13 @@ static ssize_t airoha_snand_dirmap_read(struct spi_me= m_dirmap_desc *desc, u8 *txrx_buf =3D spi_get_ctldata(spi); dma_addr_t dma_addr; u32 val, rd_mode, opcode; + size_t bytes; int err; =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); =20 + bytes =3D as_ctrl->nfi_cfg.sec_num * as_ctrl->nfi_cfg.sec_size; + /* * DUALIO and QUADIO opcodes are not supported by the spi controller, * replace them with supported opcodes. @@ -697,18 +701,17 @@ static ssize_t airoha_snand_dirmap_read(struct spi_me= m_dirmap_desc *desc, goto error_dma_mode_off; =20 /* Set number of sector will be read */ - val =3D FIELD_PREP(SPI_NFI_SEC_NUM, as_ctrl->nfi_cfg.sec_num); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, - SPI_NFI_SEC_NUM, val); + SPI_NFI_SEC_NUM, + FIELD_PREP(SPI_NFI_SEC_NUM, 1)); if (err) goto error_dma_mode_off; =20 /* Set custom sector size */ - val =3D as_ctrl->nfi_cfg.sec_size; err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, SPI_NFI_CUS_SEC_SIZE | SPI_NFI_CUS_SEC_SIZE_EN, - FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, val) | + FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, bytes) | SPI_NFI_CUS_SEC_SIZE_EN); if (err) goto error_dma_mode_off; @@ -733,11 +736,10 @@ static ssize_t airoha_snand_dirmap_read(struct spi_me= m_dirmap_desc *desc, * =3D NFI_SNF_MISC_CTL2.read_data_byte_number =3D * =3D NFI_CON.sector_number * NFI_SECCUS.custom_sector_size */ - val =3D as_ctrl->nfi_cfg.sec_size * as_ctrl->nfi_cfg.sec_num; - val =3D FIELD_PREP(SPI_NFI_READ_DATA_BYTE_NUM, val); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SNF_MISC_CTL2, - SPI_NFI_READ_DATA_BYTE_NUM, val); + SPI_NFI_READ_DATA_BYTE_NUM, + FIELD_PREP(SPI_NFI_READ_DATA_BYTE_NUM, bytes)); if (err) goto error_dma_unmap; =20 @@ -826,10 +828,13 @@ static ssize_t airoha_snand_dirmap_write(struct spi_m= em_dirmap_desc *desc, struct airoha_snand_ctrl *as_ctrl; dma_addr_t dma_addr; u32 wr_mode, val, opcode; + size_t bytes; int err; =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); =20 + bytes =3D as_ctrl->nfi_cfg.sec_num * as_ctrl->nfi_cfg.sec_size; + opcode =3D desc->info.op_tmpl.cmd.opcode; switch (opcode) { case SPI_NAND_OP_PROGRAM_LOAD_SINGLE: @@ -880,18 +885,17 @@ static ssize_t airoha_snand_dirmap_write(struct spi_m= em_dirmap_desc *desc, goto error_dma_mode_off; =20 /* Set number of sector will be written */ - val =3D FIELD_PREP(SPI_NFI_SEC_NUM, as_ctrl->nfi_cfg.sec_num); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, - SPI_NFI_SEC_NUM, val); + SPI_NFI_SEC_NUM, + FIELD_PREP(SPI_NFI_SEC_NUM, 1)); if (err) goto error_dma_mode_off; =20 /* Set custom sector size */ - val =3D as_ctrl->nfi_cfg.sec_size; err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, SPI_NFI_CUS_SEC_SIZE | SPI_NFI_CUS_SEC_SIZE_EN, - FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, val) | + FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, bytes) | SPI_NFI_CUS_SEC_SIZE_EN); if (err) goto error_dma_mode_off; @@ -916,11 +920,10 @@ static ssize_t airoha_snand_dirmap_write(struct spi_m= em_dirmap_desc *desc, * =3D NFI_SNF_MISC_CTL2.write_data_byte_number =3D * =3D NFI_CON.sector_number * NFI_SECCUS.custom_sector_size */ - val =3D as_ctrl->nfi_cfg.sec_size * as_ctrl->nfi_cfg.sec_num; - val =3D FIELD_PREP(SPI_NFI_PROG_LOAD_BYTE_NUM, val); err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SNF_MISC_CTL2, - SPI_NFI_PROG_LOAD_BYTE_NUM, val); + SPI_NFI_PROG_LOAD_BYTE_NUM, + FIELD_PREP(SPI_NFI_PROG_LOAD_BYTE_NUM, bytes)); if (err) goto error_dma_unmap; =20 --=20 2.51.0 From nobody Thu Oct 2 00:53:54 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020128.outbound.protection.outlook.com [52.101.69.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AD1B313294; Wed, 1 Oct 2025 22:24:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.128 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357458; cv=fail; b=T3qxh0olpy4innAAm7i5uULEW3ZeXINws6qis/VETmIrUNfZDyk+VERijbzn2tZjbrj3cQ+0iGptLRVK10d1AHYTRKZzWJg6YLBfXHuK3X8mRwZviHjD6BspZSwPCZVAh4nR3NAK/EygaICs+UxupBdtTMQITApeHMrUy6UFkZw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357458; c=relaxed/simple; bh=TW0r7ZDi5Kpc0NOqesGU8kDdpINxRHGh/ajmzO2PuQE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=FsLt+bhla9sziR1Lyfw5G5NP++myvv+vabztKf+vsbHx/rVHgeReC3+FCzne7NPu1Ew5j9MR+RVAkCJP2FRZZ7CP0u/g96aOX1PEcoHkLEfjbrAXa8rljFVy/KC+Og7a+0jzORfj6g1/m9HUB3dTAdG5XzJthLjfUYXHf5K2H8c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=Ky8UN6vp; arc=fail smtp.client-ip=52.101.69.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="Ky8UN6vp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sfgP+u9ZDB6dDX7JWm5/VLX9nPfTiPJK9xWIP66J0DY0M3v7Y4RCSFLsWBZ0lF5hGPhRme3iyZpex8hGAwQ2JTzGm/of9fzaBeEOSi3mLni/L9LkV9xKIw830TgjRMt7y4cdhSEDlyV3lrhWF/VeuotM8qlOAcSiqRTvNOugXUV6FEkmmGkS0CPxMJhz0XpZxc6DWJKy7FuF7eKEPBHN7R7WAUpqvWSGhe2ZmU/MCHcZw0HEKUE3EAlpoXE8cvLdS8mm+VqiaEZSylm8E3sAdtwn7pUS2Ht0sgBwVU5rrDjViH5cGh2EJig2SeTyubMWpn2Zd+g8FRhczjuwWMrehA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sEk8brtdw5W01o7qoOkKslSSjbVNlZcNRZIgXO6c4j0=; b=l/FO/VA2iFsFQdPjc4dJYkwKDAC/hoN14QlZw/z7ADAGPDhcPcXqcz/n9wfZpw/6OCT8uyacDI5nJKa+5p1iC74sth9URSERQWJmWo/H45C1JFv0m3FbB5CC4HseIeThEITEqF14qjxL/v4N7G5Tcxvzd2hCv8vg6CinJk7TnW/g6nGgVTZf5tOJpYRUSHpV7b6umsy64w6I94upfuGXkpsDs5zdWse9qFRRwE6wvRNhsMKawzTQWGwaIwZyEtCeyGLGWUvILXQvPA/7HfyasmFSENHLwsFYFd8IPT8TaER5an1Nmg5HenvT+ABPGArX/1ZeHl90yk7F+76aVOS33g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sEk8brtdw5W01o7qoOkKslSSjbVNlZcNRZIgXO6c4j0=; b=Ky8UN6vpmIKdzpsMb0Say32aITEZvwxzHo6IByNOwFVSQcH/VOzNu08D6YM7yREjvrEyHo8FylmQhb1vnHHt1yIIBqPDhjCRSkEWa6MlX6BMi5rS9nSC0h7Hnb0NDvlTpQPs2p2DtRkO3LjClGndmm+w5Um69MJpk3sQZDXXbjgF6Byyti0ZZ2pjuhe3oEgxlNuf1+Fm8QiH6UQvaCwtucx1fTeO/ZYV/FBnwjceOIOTopVSjqcf2+3BvOfU3WJoy/XhuudN8hXagGK8zHBjnR4VrvOOXHwpgvDck31P5AkZ06eTxlXSQoapcSfGwdCcoVT0rqO6OGaYBMtqgAq8AQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6302.eurprd08.prod.outlook.com (2603:10a6:102:ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 22:24:06 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%3]) with mapi id 15.20.9160.017; Wed, 1 Oct 2025 22:24:06 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mikhail Kshevetskiy , Andreas Gnau Subject: [PATCH v6 12/13] spi: airoha: avoid reading flash page settings from SNFI registers during driver startup Date: Thu, 2 Oct 2025 01:23:45 +0300 Message-ID: <20251001222347.3386506-13-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> References: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0447.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::13) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: 31025cb6-c85b-4de4-3722-08de01393bf3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?qkWcIJ8XXai+tVSM+7umAULmfhGo2HgvO3DcRjdULsJP5Xrz4OUGx4R/SCeN?= =?us-ascii?Q?1qs7QqT3AWr2d+D/PT0KdYlLDybPyJ32trSTybBsCxBgsqLigNGzqBFxgZVi?= =?us-ascii?Q?vCgJy2VQIld3hp4MkPoMBy4CfJSCI07vPxeLjjjBeQGJibdJKfmhoA0dXyFp?= =?us-ascii?Q?4vsZ8ji6Jo4vtdGnHJ2Z1l7UsBU+jS/ryga2Qe2FccvJ9HTx06pf254K4KOi?= =?us-ascii?Q?uf2XZmxlMU142KoOvGIxBcwiO8ITvHyDn+2g1RYclrC1JW/eKYpk6KYXZf6t?= =?us-ascii?Q?9E3Q5rzJmZAkCmjjG3jBCk4CtwDNG/4vwqF4wNrLuLBqFyc5jnmHP7DksCcq?= =?us-ascii?Q?jJPTTt2e4jSSPR0PqpnBCKN4W5hZ7VtQVVSgWrzEDujMUSolaKRp3vpmb9N+?= =?us-ascii?Q?sF9LGsAF7ySEcD1Auhma8ETSiQ68xOkA/220P2k5yZ+xpa9OhDvlNT1Hu8Sl?= =?us-ascii?Q?FJNg54rDP6HoSovYVHwmpWkzo97v7GgQiX047jcTXEBuctJIKy4JxxGrVBKW?= =?us-ascii?Q?Oh/P05G/2nO+Lxn8WpWsti/4e6Yy1atUkwWtS+dm4kvKiRUnu+rdQXO+PtAS?= =?us-ascii?Q?ZZPn6lAb+nMpo6ad7KMOL403lDoSIcLNXRvMzJVViHgypLx7Y5N+ktksynSk?= =?us-ascii?Q?mlD/UicoQMTTWT3PQECMKNblIkpdnBrtawzsWnOQvnTR8hwGGgxS5cOrNovf?= =?us-ascii?Q?H2Iklk5CF4K1sFmG3UhEQgxeoXk+ugWxL3BGwBhq+0gUBQLEHnrLSrCfFCCb?= =?us-ascii?Q?qehLbUIciKn74IGRzXCcqcaLJSbWh0IrKnZK7l79UcR2l0Sy6GBqtAIwD/TA?= =?us-ascii?Q?o+Or0GZYre68PhFpzUrwHpGztPCopDj9+aEBGUY7egWXrAUUg1ixMgHpHXaN?= =?us-ascii?Q?+nGn+wzwFA90nYUc/Uf+sRj2gkn5zajBvNY9UM7ZlvRcVa/RuqHObu3vE4t+?= =?us-ascii?Q?Qoc2IglMjhHp4xUQk384gmKyJjMZ3WMDZkllTN/OS+wwwXW9+bQ1XM5R92y6?= =?us-ascii?Q?wDTl66joRwZeu4IXZNYIDuUqkqtfb/rsW3qqK1hN5THRFDglf2/CuL68LEzh?= =?us-ascii?Q?MU8kKOEHchtQar9wA9JcrwvQ7rIf/uxhH00W93YHKFtXxRpN00d+i+vtcl23?= =?us-ascii?Q?ZPKegJigflXdD4qqPhAUJP1COWNqOHyDl+SzOBpeHFzEyIU3Q+PouNFr96rv?= =?us-ascii?Q?6q9e1EUrFcwCEqlbhdTFmjkNA3ae5p6CnPjvCV8kjOkr5W+jO9x3SDh/+/u6?= =?us-ascii?Q?t1FH6pGM/A5MXexODKFMdVOJurYdlpFwwXfutatoFsLD/mQ0eIQQl96GeF3/?= =?us-ascii?Q?z0yTjOwupc8KpdXAgrLBaDiH5KlHEqiw0kghGZRLzEDeUksPQ1952NruJPVx?= =?us-ascii?Q?jrZ59gXt8WfNStU4nStQUEDCyHuPqxGru3jpz/8XhFIl8rduxKEAlmuAL9Sq?= =?us-ascii?Q?GLo75Qaepa+aPY81NfwI7V+bRsuF4Wzu36Ah9ogI+uTrfZtISMT+LqM5IiDE?= =?us-ascii?Q?esEl3NtrF2yqns9PIy0MqOXRjPULI+/SOh0t?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W3ihe9PcdUmjQYsPkSCDCoFP9F3kGNg1f0H6shDNqXimgBtLRnqtj2YVu/3B?= =?us-ascii?Q?k5mxIQcbTfnr4Pr4uwvTwZLPe3xso9mUSOQaV6NtChMXGfVRpNnEkpGwzZZg?= =?us-ascii?Q?yHD7BjbgUpdMf3sGyHDzZmSsIvvsgaqezWw6Y4mYQL/yNVVPRljuwPH/LW2K?= =?us-ascii?Q?cSulgOOb8KUSnqkL3Wp61mvlruPmGglv240d1bHsDEjZG7Nbq15THxT88qFo?= =?us-ascii?Q?9xuzn6tkKWDOVpN1qPjC0kdibb6mqpFir/0uRKIeK1m7dujLW++vS7JgUfFw?= =?us-ascii?Q?HryAYPCPPIEu58pmNNiInm3k76pv01a5pgWdUXMmpW8b7OK2OFr0/XSj4mar?= =?us-ascii?Q?oEXUhoMSdVOpAg7Mi2350xu1dNmVeUEj2xGn1rkaYIrMx/hiVzDQRcK2cudI?= =?us-ascii?Q?SmKUliSN+qExnQFjbegWUxGkGMwC3P+frBr5LY6/EesfH2fzLX+7xmMelBVj?= =?us-ascii?Q?Je1IXm9gxOdJRzO7EAbIWWCmkRUDbH0ORhvZf8/IGwZKbJAIzwi7+VRhdepj?= =?us-ascii?Q?C0n8fWPJhGpCme/EiJbuZ7eFkjZ7eQyeXj3UWYJbaZUl0pmZnrKT1CcBceYV?= =?us-ascii?Q?gfP/SYiOXKIkfXCBo3OaItoDWg+v9r7mBB6l+UMBB4HGhKe+mHyurXocr8i/?= =?us-ascii?Q?3Z5ZsxYKXi1V78LB8dEVFoWogjnP6iqgETuVckeD3Ss1wxkcUlanBLlJDwjo?= =?us-ascii?Q?w1/Pfkpg1l5zIXLqv6KPZKRMvU4eQqFPMMtPno0ZJaZeo+kP0QvRQvWh1Kfc?= =?us-ascii?Q?v+ppEx4C3dTVoTf0938yExbCj+nvF3gQGTUY1ddv/ityQOpCBJvapbB371Du?= =?us-ascii?Q?8ZemVqJbpKO/yz2Q1JtG7dymPh20QDGQwwS1AoOADvRDMOkdUXHN32nbuXuD?= =?us-ascii?Q?FsMQ97hl8pVQe7uVVr3jBBZ0ITPF1hByaAqgeuikQOfMuoIOQKT1WJxXfM6P?= =?us-ascii?Q?OPwOCG3uohO7ihTNfF00xetUGlPi2rnLW08PrkGgcXsQtllb8g30ind0RmH/?= =?us-ascii?Q?IccFALSILuTUk3kL3aF34j1Xyexs+zSdCfc1PCrW9uJWISG8dGI2Ai1QjKLx?= =?us-ascii?Q?tNUu5SdcgMLKtdyQBc056m/8XcKH+GW4PGhoHymQaAdbXpfdSQLWv8Z747Qs?= =?us-ascii?Q?CPYPjSzQt/Ed1zC1h9x1l+O+Gvj3A6BgSnbUPAnopIWD0BbR19U5zXAM3CbV?= =?us-ascii?Q?iWKHIew0OG6kDzB20e4TMTUlexfSsMb4SrTJOwI2hTxodBLwuQMsBbKcH4SR?= =?us-ascii?Q?73+GnpPGBUKr94PH6rDb5XFmeYNCmUaY59jdr5D4Fke7Vx1ZQmXbVOqlfbkw?= =?us-ascii?Q?/JkoC1Zfrx+Zxm/IR1hW3FU5l4ULQyeE6ie7Wpk24I9TDxXR7MwImjATeXeI?= =?us-ascii?Q?jw/VasFXky514qbQPggvyUCYzp3Xa4NP2eZB9ZVe2A1jye4u0yI/6IlfiEjK?= =?us-ascii?Q?la4A98NqIoABqqwl+f/BNQFpKk4yfIRQac16IJ8xsv/YFhPIiD1FdvXH//qH?= =?us-ascii?Q?kYkcC3Tti9ApywSjwYtHZ++y8MmzUvozB/b6cIUapXrgNH4geWPBgHE07Dvp?= =?us-ascii?Q?j1FhBGJ9StCILVK+IFQqsleiTlqp+BM3skNP6ZvenxMA9/NBWD4JtduWecCH?= =?us-ascii?Q?0yCzP0cwzck8D7pxD2ZSkLs=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 31025cb6-c85b-4de4-3722-08de01393bf3 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 22:24:06.5180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pWkTDZG8OJxEwyoFCmHJfvGZp0NKiWHu1pM6E3opf/F71X+lD7WpGMeRZDtTEuDkKFOfXYs5NYpYsY69GqutWuiacBc3zKRvDlsVAJTFZHw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6302 Content-Type: text/plain; charset="utf-8" The spinand driver do 3 type of dirmap requests: * read/write whole flash page without oob (offs =3D 0, len =3D page_size) * read/write whole flash page including oob (offs =3D 0, len =3D page_size + oob_size) * read/write oob area only (offs =3D page_size, len =3D oob_size) The trick is: * read/write a single "sector" * set a custom sector size equal to offs + len. It's a bit safer to rounded up "sector size" value 64. * set the transfer length equal to custom sector size And it works! Thus we can remove a dirty hack that reads flash page settings from SNFI registers during driver startup. Also airoha_snand_adjust_op_size() function becomes unnecessary. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 115 ++-------------------------------- 1 file changed, 5 insertions(+), 110 deletions(-) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index babf7b958dc3..437ab6745b1a 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -223,13 +223,6 @@ struct airoha_snand_ctrl { struct regmap *regmap_ctrl; struct regmap *regmap_nfi; struct clk *spi_clk; - - struct { - size_t page_size; - size_t sec_size; - u8 sec_num; - u8 spare_size; - } nfi_cfg; }; =20 static int airoha_snand_set_fifo_op(struct airoha_snand_ctrl *as_ctrl, @@ -490,55 +483,6 @@ static int airoha_snand_nfi_init(struct airoha_snand_c= trl *as_ctrl) SPI_NFI_ALL_IRQ_EN, SPI_NFI_AHB_DONE_EN); } =20 -static int airoha_snand_nfi_config(struct airoha_snand_ctrl *as_ctrl) -{ - int err; - u32 val; - - err =3D regmap_write(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, - SPI_NFI_FIFO_FLUSH | SPI_NFI_RST); - if (err) - return err; - - /* auto FDM */ - err =3D regmap_clear_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_AUTO_FDM_EN); - if (err) - return err; - - /* HW ECC */ - err =3D regmap_clear_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_HW_ECC_EN); - if (err) - return err; - - /* DMA Burst */ - err =3D regmap_set_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CNFG, - SPI_NFI_DMA_BURST_EN); - if (err) - return err; - - /* sec num */ - val =3D FIELD_PREP(SPI_NFI_SEC_NUM, 1); - err =3D regmap_update_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, - SPI_NFI_SEC_NUM, val); - if (err) - return err; - - /* enable cust sec size */ - err =3D regmap_set_bits(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, - SPI_NFI_CUS_SEC_SIZE_EN); - if (err) - return err; - - /* set cust sec size */ - val =3D FIELD_PREP(SPI_NFI_CUS_SEC_SIZE, - as_ctrl->nfi_cfg.sec_size * as_ctrl->nfi_cfg.sec_num); - return regmap_update_bits(as_ctrl->regmap_nfi, - REG_SPI_NFI_SECCUS_SIZE, - SPI_NFI_CUS_SEC_SIZE, val); -} - static bool airoha_snand_is_page_ops(const struct spi_mem_op *op) { if (op->addr.nbytes !=3D 2) @@ -571,26 +515,6 @@ static bool airoha_snand_is_page_ops(const struct spi_= mem_op *op) } } =20 -static int airoha_snand_adjust_op_size(struct spi_mem *mem, - struct spi_mem_op *op) -{ - size_t max_len; - - if (airoha_snand_is_page_ops(op)) { - struct airoha_snand_ctrl *as_ctrl; - - as_ctrl =3D spi_controller_get_devdata(mem->spi->controller); - max_len =3D as_ctrl->nfi_cfg.sec_size; - max_len +=3D as_ctrl->nfi_cfg.spare_size; - max_len *=3D as_ctrl->nfi_cfg.sec_num; - - if (op->data.nbytes > max_len) - op->data.nbytes =3D max_len; - } - - return 0; -} - static bool airoha_snand_supports_op(struct spi_mem *mem, const struct spi_mem_op *op) { @@ -641,7 +565,8 @@ static ssize_t airoha_snand_dirmap_read(struct spi_mem_= dirmap_desc *desc, =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); =20 - bytes =3D as_ctrl->nfi_cfg.sec_num * as_ctrl->nfi_cfg.sec_size; + /* minimum oob size is 64 */ + bytes =3D round_up(offs + len, 64); =20 /* * DUALIO and QUADIO opcodes are not supported by the spi controller, @@ -833,7 +758,8 @@ static ssize_t airoha_snand_dirmap_write(struct spi_mem= _dirmap_desc *desc, =20 as_ctrl =3D spi_controller_get_devdata(spi->controller); =20 - bytes =3D as_ctrl->nfi_cfg.sec_num * as_ctrl->nfi_cfg.sec_size; + /* minimum oob size is 64 */ + bytes =3D round_up(offs + len, 64); =20 opcode =3D desc->info.op_tmpl.cmd.opcode; switch (opcode) { @@ -1076,7 +1002,6 @@ static int airoha_snand_exec_op(struct spi_mem *mem, } =20 static const struct spi_controller_mem_ops airoha_snand_mem_ops =3D { - .adjust_op_size =3D airoha_snand_adjust_op_size, .supports_op =3D airoha_snand_supports_op, .exec_op =3D airoha_snand_exec_op, .dirmap_create =3D airoha_snand_dirmap_create, @@ -1101,36 +1026,6 @@ static int airoha_snand_setup(struct spi_device *spi) return 0; } =20 -static int airoha_snand_nfi_setup(struct airoha_snand_ctrl *as_ctrl) -{ - u32 val, sec_size, sec_num; - int err; - - err =3D regmap_read(as_ctrl->regmap_nfi, REG_SPI_NFI_CON, &val); - if (err) - return err; - - sec_num =3D FIELD_GET(SPI_NFI_SEC_NUM, val); - - err =3D regmap_read(as_ctrl->regmap_nfi, REG_SPI_NFI_SECCUS_SIZE, &val); - if (err) - return err; - - sec_size =3D FIELD_GET(SPI_NFI_CUS_SEC_SIZE, val); - - /* init default value */ - as_ctrl->nfi_cfg.sec_size =3D sec_size; - as_ctrl->nfi_cfg.sec_num =3D sec_num; - as_ctrl->nfi_cfg.page_size =3D round_down(sec_size * sec_num, 1024); - as_ctrl->nfi_cfg.spare_size =3D 16; - - err =3D airoha_snand_nfi_init(as_ctrl); - if (err) - return err; - - return airoha_snand_nfi_config(as_ctrl); -} - static const struct regmap_config spi_ctrl_regmap_config =3D { .name =3D "ctrl", .reg_bits =3D 32, @@ -1204,7 +1099,7 @@ static int airoha_snand_probe(struct platform_device = *pdev) ctrl->setup =3D airoha_snand_setup; device_set_node(&ctrl->dev, dev_fwnode(dev)); =20 - err =3D airoha_snand_nfi_setup(as_ctrl); + err =3D airoha_snand_nfi_init(as_ctrl); if (err) return err; =20 --=20 2.51.0 From nobody Thu Oct 2 00:53:54 2025 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020102.outbound.protection.outlook.com [52.101.69.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8499E2BDC00; Wed, 1 Oct 2025 22:24:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.102 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357458; cv=fail; b=Bkzqur2b+f+yfTeJ18oyzkv0DngeOXFLuF17VF5fZOk5LSjByPBNHZ0A9av0SLOfgM97GPG7RY4tqM/gDlFSD8mhdNnjkkRpw7NcHV6CATTMRl/iRuldyWXIBjIt5+ZI2orZDU8Ea4BhYjMMwZfJpnS8yXtDtIhGz04Y1vUo9gM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759357458; c=relaxed/simple; bh=7yFHZDTm9S6W8TJZL/M1/sCMtKCsZubnBVOvfenNeoI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=kJZXh3eEj8zHStxp5k/LD5uqucfImlJw5vpoQIC5M02K4gokzqcCYtyq1vPMmdPdspeHEa62lFqKRTsO70wMSftF0RkhgMwjdAao5d+AlWnzoRzloJveamUMctg/UriKsuS8PKv6dvFuzE/dZbuhXHsMuxkyRXz8QNNf1vULK2w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu; spf=pass smtp.mailfrom=genexis.eu; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b=mDNLZ0SI; arc=fail smtp.client-ip=52.101.69.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=iopsys.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=genexis.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=iopsys.eu header.i=@iopsys.eu header.b="mDNLZ0SI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QwuDoFka4l+b55zrMBDzOpqXPP+EM+HjSp1tAae6oxWakzWVaUarCnXJcturthLCRdz4mOxLcqWKeCH5Sz8UjP18M7baCuws9ruXA65c+rQJtfggIlAHMk4bXT3vN4/3uUcJ3yuh1aY+TJkFJdbOegDxhlODjn2wAVn6/qdL9rBTbgtfa/6J7kOun1eyX+Fkv8DM51ihd2uyS7MpCTG2Dx2uEWY4aXzOcs6OZ/BUdy34pooz5kg3J0MpQY7cI0Z3awYv2XoCeROzKF0NuRCTA1j0G8nINedQvou/bTbbPhHrtx/CiqLG5OIxAWG2N+sR9dpj9Ux7I5OOxvUrrdlaKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ux1isKseYcwD6TYau7kY/FyTZaKVnyeDUD3WyihxIOc=; b=DvSNU2yVwtn2Nubw9hNZJ/CunEslb9uxYz6GhXGYCfGQ2x4vANMuuSXIvsmonjWV7C/3n/bA9z36SdjRkc5MJNnJcm9NyVaPgSoDFcv9MSMyJXvQGbiMmwrXxUQI7Z0KvVHNhb/cfJpmo410ZGUIAzImR1/QkGlKzhJEyOIDfKyiVCvcgY2kfh+vODOo/29ec9MNoBLEvI9jo5Jo33oC71atG4HZUr9j+PawuDXvSYCPw63m5I6tcIOx4UBx0uCYXYTWU2+VseDwq97ywDbRUlUR5NXivKaGxHLThXpxayRedz0RUmvGgOjd676wAFfk4oTr6MEoB7xsE6lkgdZIFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genexis.eu; dmarc=pass action=none header.from=iopsys.eu; dkim=pass header.d=iopsys.eu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iopsys.eu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ux1isKseYcwD6TYau7kY/FyTZaKVnyeDUD3WyihxIOc=; b=mDNLZ0SIqdJWWmUaLvvqh91Q3vNmQ1K0KpHhWUvDlAUQ/4QcjY0geti8VJq098aDYlyTrLLarNhGUvwpit+sT6JDKWPhCHMnRp+BwuKVYtsPdyNRD8m93W8kjD8r98zvbHToIJ/bLyAYbHDJpXiBMY/dhFSLPRE0UsjjwdgilFLjmE0ReUgtlTLaXpcVuD2poZwsp+97gqJsnmJOJEmQp+Nr1cZ9XxOOUfhjTre+aWH2amsPwLBeB+uJlMor/zshW3bVcGTzZBibq5FW7CXk2PTDjQMXbYc9kmikfZs36ynhgqZ7Pe2fpng5Z/fxEIAInfYWHjJHVEmkJWlVMt6DOA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=iopsys.eu; Received: from GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) by PA4PR08MB6302.eurprd08.prod.outlook.com (2603:10a6:102:ed::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 22:24:07 +0000 Received: from GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0]) by GV2PR08MB8121.eurprd08.prod.outlook.com ([fe80::4cd3:da80:2532:daa0%3]) with mapi id 15.20.9160.017; Wed, 1 Oct 2025 22:24:07 +0000 From: Mikhail Kshevetskiy To: Lorenzo Bianconi , Ray Liu , Mark Brown , AngeloGioacchino Del Regno , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mikhail Kshevetskiy , Andreas Gnau Subject: [PATCH v6 13/13] spi: airoha: buffer must be 0xff-ed before writing Date: Thu, 2 Oct 2025 01:23:46 +0300 Message-ID: <20251001222347.3386506-14-mikhail.kshevetskiy@iopsys.eu> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> References: <20251001222347.3386506-1-mikhail.kshevetskiy@iopsys.eu> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0447.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c6::13) To GV2PR08MB8121.eurprd08.prod.outlook.com (2603:10a6:150:7d::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR08MB8121:EE_|PA4PR08MB6302:EE_ X-MS-Office365-Filtering-Correlation-Id: 97a1df31-f970-4485-6168-08de01393c85 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XwM4zMsYdWX/H6Y+K/fOeETVtwac3xtusO7C/wmorlm3HJiNbzkH0vFzHsbh?= =?us-ascii?Q?rqfoK/205YJFZ/JHkCoSxIHolKL0dM4sRMnc5ZeIMSI08HhEy9/LMVrT2Jyk?= =?us-ascii?Q?U5ZCBsbcB0bEHh8IHzC1bGUtG5oap03WEXpEr7HjOBFwQbUu9PUBLGjMGD3B?= =?us-ascii?Q?hbCCHUXmenDiRDUNqJyd49wQ1dHHKJAnKII1wn8kcJDknXeHgnNIj2xZ/m3m?= =?us-ascii?Q?X1g4BKFf0p3Jd4y7vQL7kz5ll8R6K0dUCLmhEdU6SVM/AYbUOS9fuwyrf2YY?= =?us-ascii?Q?YV3S9fPdoed0ailWglT4htFu5HNWX4fM7AdQgKuNq+4uckUzvDntvr8L5d+d?= =?us-ascii?Q?QTCI+aOdL1ZwF3SJ1j+4kA8M8p6I9IchHTZe31BMj+WVx4zUJNdSA0O4hOQI?= =?us-ascii?Q?wz9+u9Iqsr1luxkHU+odgA1Plzawvbd7olj2jifg3BnPG4FKLhFReWd7s58c?= =?us-ascii?Q?0FRnTmChdjrwjlC+yU/Bjz7IGSb/bXNvHoCLgMmtWqacgwoR2/LOiXCPhnUM?= =?us-ascii?Q?Tjh/XJzqz+lNKt/ucS3ueA3We7ysLLVLTDMIU8fxEfbQzxuqYqtUWJs79o0u?= =?us-ascii?Q?rYrN75KRFl00rtVupWXBnH01f0u1ulzNaAbJpH0Xt2Edtf1GWB7dZsJ6dn4n?= =?us-ascii?Q?zeOgdl6IPRmjpips8zCVMPhfmnFOi18skugFysmdgRV/vIR4RwTOzoOt4IXQ?= =?us-ascii?Q?k7LusXsHuTiFfAF5U0hzj9nVqrFMxOfbHLtcYO4ArLHz6gCK+T+T7uFhojqw?= =?us-ascii?Q?KFqXBJvThOOwe1u9XS85541d7D3Q0/z2CHmT2ZKxJ4TiZn1M/9uFQWSWpzgs?= =?us-ascii?Q?tea/jS3+NEP2x9QUsjQpWSdxyOUrafjrtXvb2T5q7jPSOMbw3vP8tF2jWot9?= =?us-ascii?Q?NxbWVZrJ/TNd+atazSEccXs+gLXQN57vuPh4Ntq7MGHQHBVV08zMuVA1TkA+?= =?us-ascii?Q?RO/fxSlvQKPmFEGWqn1ZW39ulh9wvdGh5VzsFM4RFUolT1wJz3KuBgeRtsjO?= =?us-ascii?Q?zrRf/Zoyl/oUBsPXyKfzzT9WVLPjxnLVtpHZeeI0M9S7WbI0NVNPLH/A9XsJ?= =?us-ascii?Q?TwT6CxvhN/kZjaP7QcGBexCoJuOrR9COA7MnVzAYubThIRSeBEYZmfvcT6uc?= =?us-ascii?Q?qQ5f4MuxLIcmuZMoxOQM1ok/LNVW4RZlK8ffp0EaS+iB7row/j43Cft2QDFd?= =?us-ascii?Q?ICc33LPI2yV6POvUu/kuu94yTrVPaPQEd/vAgBL+QfJ4mpCBDay3CfXLyGP7?= =?us-ascii?Q?y3PAneuIg/uSd6Z9Q0oWxl73PUNjFK0eM7kNhs1Qh1gI1+VT3kEpdEoyKKUO?= =?us-ascii?Q?MLjsNxly0Pt/C+FFZ5gbf1ghTUUBaXuqc6QqvBXd71sL6I0yVm8tf0V4p3Da?= =?us-ascii?Q?agWx4a70UV19umCUEJJtu7vxdjux5AThSffSYW8JQu2WC8cnj58Zjkl1h1so?= =?us-ascii?Q?E6tomPyWY2T8qmbsbFJSeSWIezunLZv+CVA0JQEi6ntlHPR0bqec0YFXh/wc?= =?us-ascii?Q?cDmCLq6taTG0nX+QsrqoslwIFeU8wa9vXtIp?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV2PR08MB8121.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UbdRM79pDUH8z8V59IejjUr3KL441vc6JJW/ksgN3mSwvKle7cqtGQadyZCO?= =?us-ascii?Q?oQhpbw+Frvx2y31xWL+o0LcO5RskbS0bQq2UJc8jiiyQjbOynEk50XGoO4hi?= =?us-ascii?Q?Odkvb/QM4u1GRHr9i4Ejd0lOYHQ8WSJeF4NeyRS64ZVQNhFZey+pLpw0dm+A?= =?us-ascii?Q?9llc6K2Y3vemicvdOso+38BxGey7l2p+brK4HApTVB55YnGNpqEbfYpwPbYv?= =?us-ascii?Q?tRK0xsQkh1NPGNHvce/vS+9Mhq7eUmb862BnkguaSy2epckEdasB5JroRgdj?= =?us-ascii?Q?wr3/WUtGe+Pj9nHA12ePKNMAUHIv77dcBS3o15w4qGNSHvYz+6gAahSQ72P1?= =?us-ascii?Q?QlXFHtprDaNNvqTmk7XWAWBjgBw37O+xkZTYLrqLLCdX/u3uTGnMDRzND0ac?= =?us-ascii?Q?c8uU+MrEsk7atbtpDph7hNIaGjeLpokG+/NmrGn3B/GPJweONKxHVfrWPRQy?= =?us-ascii?Q?cvtwzKOdAR+DI16PkQSRsW2SJ+VlSkLNPcqeVJAf6H14YQCnkThb2tPM03Dq?= =?us-ascii?Q?NaeXutSMli549D2HpHkYHFD2B/NO3wEIuN4sOwleufTuG2PQGg7cZS+cckbL?= =?us-ascii?Q?/wlpy2k8JnvO8DAVMIt/ofSd5YIkjaKagvwTwAvtNxgWdD4u0IO2RgUoA5g7?= =?us-ascii?Q?W/oSUdIO10vFDJCLHwB7qQfVtnH7aoxJxRFiESj3mT6i9iLivkUYanHRXcbX?= =?us-ascii?Q?JU2xU7SPhpQnsU2Dyeq2ASHLiDlF5cqB95mZXy0/098ZDyaA6Oa/Tf5IeGeJ?= =?us-ascii?Q?HYIZYbcCnM3ZUECjefiepO1npqY/3j9YBH2+H9L3FPNBNdUTEVXaJhLyeSkP?= =?us-ascii?Q?dY53/ZhDAYEOtU+7MD9fUSW3OjfY0SQaF4eHdgpnyf1W6hcZiMoQ9E79KY1C?= =?us-ascii?Q?6fNt1kuGKzCzGgb1mbEVF57gRmtNgvC6/w8DnIwDxqp/LRUbwHYbxe6O8vVP?= =?us-ascii?Q?wGEk0iCo4wg9AyTg3GH1GwhOHv7m2hYgqiG/OK2DxOcFp6Dmf6GciicB94tm?= =?us-ascii?Q?xjXgMgndM0eWbnFDGvUXLO/o8YqU+XmjbUQxsGBw19Pcx7lj/UPNihhKlo9I?= =?us-ascii?Q?uS1au+Vn2XtznhJk6Ss6lWPjpJOrf/onersQ2HJe4Lwnp0q1vuPNnmvTf0Se?= =?us-ascii?Q?WsEdt/BLBCUSLz/UVlzjemuXqWrbMHZy+7u3h96Lhe0ZJOpNGDoiAdKDQDkX?= =?us-ascii?Q?cIHxZdQx7o2AppuzFlAaEssmgpEtRYa/g7ta0kqikWm+vbMb8tlST7yzYtoW?= =?us-ascii?Q?YLpg2sDeB2t52i/NEJZZHKUc8N9jaAFxDFIR2yeBnRmocZ+272H8BWY0BhUT?= =?us-ascii?Q?FUoPRad+K1SBrjXXCvH011T6M5X6NEimCN1FkwYUiJxxtauaetS5jwe9O/rM?= =?us-ascii?Q?fZyXFBF4TtHEsSTtSbG8bpDa37ai1Xl9Oeg4kLeHQBX5vvpYjlzR73FgOSoS?= =?us-ascii?Q?g/LWiBL41PzaaL6WWuJMQg+gkaPir/7eQBYf/TT1D0SgxiecUGHF8rbjM+j3?= =?us-ascii?Q?9fyhEh3udWaVNNstpdGk7A/1/QutzMo6Gk9a3/yDGWdfyXtTc1qf0WMvn4mb?= =?us-ascii?Q?WmrKM/AhBZyrsUcdeL7P0WYRApTWBwDpYBJT2nGuF4mzqkG/0/I+dyU4oipG?= =?us-ascii?Q?fsJIKQNrojenutUK6+6j54o=3D?= X-OriginatorOrg: iopsys.eu X-MS-Exchange-CrossTenant-Network-Message-Id: 97a1df31-f970-4485-6168-08de01393c85 X-MS-Exchange-CrossTenant-AuthSource: GV2PR08MB8121.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 22:24:07.4968 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8d891be1-7bce-4216-9a99-bee9de02ba58 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mBjXzwalB+TnJP8lT3wyDJ9yhT+0kaCQBvdLqUT/b55iLJFexuDrWD6f56lBAZfc+0Z2N6u3xxHp4U2fvSnKG9woEt6xmnAnd/qFyM8n3pU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6302 Content-Type: text/plain; charset="utf-8" During writing, the entire flash page (including OOB) will be updated with the values from the temporary buffer, so we need to fill the untouched areas of the buffer with 0xff value to prevent accidental data overwriting. Signed-off-by: Mikhail Kshevetskiy --- drivers/spi/spi-airoha-snfi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/spi/spi-airoha-snfi.c b/drivers/spi/spi-airoha-snfi.c index 437ab6745b1a..8408aee9c06e 100644 --- a/drivers/spi/spi-airoha-snfi.c +++ b/drivers/spi/spi-airoha-snfi.c @@ -776,7 +776,11 @@ static ssize_t airoha_snand_dirmap_write(struct spi_me= m_dirmap_desc *desc, return -EOPNOTSUPP; } =20 + if (offs > 0) + memset(txrx_buf, 0xff, offs); memcpy(txrx_buf + offs, buf, len); + if (bytes > offs + len) + memset(txrx_buf + offs + len, 0xff, bytes - offs - len); =20 err =3D airoha_snand_set_mode(as_ctrl, SPI_MODE_DMA); if (err < 0) --=20 2.51.0