From nobody Wed Oct 1 21:23:26 2025 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD6263019C5 for ; Wed, 1 Oct 2025 14:01:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759327279; cv=none; b=avWt0BtcuislAKYeetZZ2F62TEWr8RyZMv+BiiYrS0QenzA/Fd3gVJPXTRPvFlX8AbsBiseER4A29mixmjj+vqx++DFXlpBXrlG6uU2CtSprvlqi1jiqDkdd6NHCQXK8bE6nDVvCqbfR2PcHkAGn1FwQueqZVnZKoZGRqlVf7Tk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759327279; c=relaxed/simple; bh=iFoDKGEqMBtBJk9VDF0RT1YA/LVK+0RXAMU5TYBYIbU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DJWCDJXnRblFBGck3CrRFQHNmsXaxOR0aKWLxv4/9JIBI5hu46SNnmGwDec03eNjaQRRWN7pOSmTqN8NL0R52EgDhqNdk08jA3Ek3nrPWPELISJPf8Vd0m8if7O52gA0jDmUG0pbR5aDxCbLDx5zpIsKnFnul8u9Rtt/2K83kMg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q7HLYlNC; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q7HLYlNC" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-46e384dfde0so77202275e9.2 for ; Wed, 01 Oct 2025 07:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759327276; x=1759932076; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r88bVkU6R3YFAsO3wz4+pTX+MHJI0oI//rtTqu0aO6E=; b=Q7HLYlNCyq1vStuweotD7DYBrzuSViFE67I0aEAHAAdExTPDJBUFKPtmgKVtvJOWXt PhEvrWU40prIcuzBScHN871J/Ufaveu4RCni/JmO94tgA5JfubJv3kNR+5oTiQupPuzN AJX0JGRvQqSC/zzTY2s70HgcmILYmvsecAb5Ek4TiSKPO+9QG5HWYiYxrAdaaE/W2Smh HUNR/UOOOB4OkDB1C8FLsDNkpasTo0U4oBCflxaD54IskTwde+jbo1D9qs/ES1JjbbFY zz/xbxC5/ap9iXH/sNf3lsNxKvXcFdQRt1gL28sDmOB0mYGTeMsCCX01fo4kyqlL2NG5 StnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759327276; x=1759932076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r88bVkU6R3YFAsO3wz4+pTX+MHJI0oI//rtTqu0aO6E=; b=omZfEYcbSVFCYJ0zTBq7kk+PfW+Ue0k7AyqROUuhmEN6UWG9jNcRsMaNut2YrLp7UF JSOSo8HIckJvt/Lo8Kmtl+1WpnZUvmWijSS2AAYLAggseLkaUrz2Kzp6rPZ23Z3uIBgI FXQ0NprInmHmKaHSR03Jfbsjkf8OiDF23xg/DAyP0j97nKw66+uatQzQ3O24ckIJ1zD9 4krF/vpmhP9Ca+KszKtbsz5qIffdktbgMGajhgINGojabx5h1TL0IoSZGjFL+5LDVihT j4A8ufgDqxtL/FfTPd8tgy2JDD8Lp0CsIimM8ahbnc+KSyZzzrDXiHGg/d42JLFaFeXd ekJA== X-Forwarded-Encrypted: i=1; AJvYcCVxmdVJPYco1WWJ+JzelrLC1uBCcIEAbgBxnvCdET7fCVjcanljqEcjKwgaxs7XojDV3CDKOKY/lscvN7c=@vger.kernel.org X-Gm-Message-State: AOJu0Yzu8H/YRSFjMc9g3wKGvQFPm8VmG2dcyzEiW+c8laASnZkuiTfg GBaiUGXSCBZ3LZuU3s5IG44OuImaaKb3STvW7oKuirac1MqfeGbNo30X X-Gm-Gg: ASbGncv2kViDeAXoC5HW9xz5fomKIkdLcBXRyQPEC6ozY3Jb8j7F+2+e3FHs9h/6KFE os0sdj/FHrueZxMClXGV4+NChcYsX1oEbSAb7zQYHmIRDti+8X9R55Nyj9RtjjHeK2yYVUbWZuT GHcrPC14bMgLRANT5tcBpYYjjsljPFYhVAhdbMVBV5fX5VmrQ0mvXtYwH8ifWApddyGeGYAXYce wLZh/zJ1Tq4kvcKXYU1fB8wMSzLBSv58BJODA/sBbqWGMgXYTMco/6++Gb3c6dNMKPYGytMbfKf lnog1urFir4S0xjH5wJcGGat/1lAHcXjDo7pAr+2J1OVV32cli8Yx2CNErtT7i82QL/A4OmM1pq tnkSfttyeYWobt2KwGz6HwzSA6+klJLvM2S2IGla575HdEqNNfIwVRL2O9Ieq0Mxvk+3tfOs65g PTMgl5JUiSFg+ZtY1P/7yX+u9Ul8J9ya4zEIp9MqM8A+Itu4sURyL0AQ== X-Google-Smtp-Source: AGHT+IF6jIPdEU9MFXPhCPUkqzhyaWrP5uY2bhk5OwNgz8t2vPUiheyA7QIaNPR9raR1Aa2Qrunkyg== X-Received: by 2002:a05:600c:4e4a:b0:45b:9a46:69e9 with SMTP id 5b1f17b1804b1-46e612de19dmr34857695e9.31.1759327274375; Wed, 01 Oct 2025 07:01:14 -0700 (PDT) Received: from LAPTOP-AMJDAUEJ.soton.ac.uk (globalprotect-nat-extbord.soton.ac.uk. [152.78.0.24]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-40fb89065b5sm27029828f8f.17.2025.10.01.07.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Oct 2025 07:01:14 -0700 (PDT) From: Junjie Cao To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Antonino Maniscalco , Jonathan Marek , Eugene Lepshy , Jun Nie Cc: Junjie Cao , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: [PATCH 2/3] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1 Date: Wed, 1 Oct 2025 21:59:13 +0800 Message-ID: <20251001135914.13754-3-caojunjie650@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251001135914.13754-1-caojunjie650@gmail.com> References: <20251001135914.13754-1-caojunjie650@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jun Nie Some panels support multiple slice to be sent in a single DSC packet. And this feature is a must for specific panels, such as JDI LPM026M648C. Add a dsc_slice_per_pkt member into struct mipi_dsi_device and support the feature in msm mdss driver. Co-developed-by: Jonathan Marek Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie Signed-off-by: Junjie Cao --- drivers/gpu/drm/msm/dsi/dsi_host.c | 25 ++++++++++--------------- include/drm/drm_mipi_dsi.h | 2 ++ 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/d= si_host.c index e0de545d4077..773ce8520698 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -166,6 +166,7 @@ struct msm_dsi_host { =20 struct drm_display_mode *mode; struct drm_dsc_config *dsc; + unsigned int dsc_slice_per_pkt; =20 /* connected device info */ unsigned int channel; @@ -910,17 +911,10 @@ static void dsi_update_dsc_timing(struct msm_dsi_host= *msm_host, bool is_cmd_mod slice_per_intf =3D dsc->slice_count; =20 total_bytes_per_intf =3D dsc->slice_chunk_size * slice_per_intf; - bytes_per_pkt =3D dsc->slice_chunk_size; /* * slice_per_pkt; */ + bytes_per_pkt =3D dsc->slice_chunk_size * msm_host->dsc_slice_per_pkt; =20 eol_byte_num =3D total_bytes_per_intf % 3; - - /* - * Typically, pkt_per_line =3D slice_per_intf * slice_per_pkt. - * - * Since the current driver only supports slice_per_pkt =3D 1, - * pkt_per_line will be equal to slice per intf for now. - */ - pkt_per_line =3D slice_per_intf; + pkt_per_line =3D slice_per_intf / msm_host->dsc_slice_per_pkt; =20 if (is_cmd_mode) /* packet data type */ reg =3D DSI_COMMAND_COMPRESSION_MODE_CTRL_STREAM0_DATATYPE(MIPI_DSI_DCS_= LONG_WRITE); @@ -1069,12 +1063,8 @@ static void dsi_timing_setup(struct msm_dsi_host *ms= m_host, bool is_bonded_dsi) else /* * When DSC is enabled, WC =3D slice_chunk_size * slice_per_pkt + 1. - * Currently, the driver only supports default value of slice_per_pkt = =3D 1 - * - * TODO: Expand mipi_dsi_device struct to hold slice_per_pkt info - * and adjust DSC math to account for slice_per_pkt. */ - wc =3D msm_host->dsc->slice_chunk_size + 1; + wc =3D msm_host->dsc->slice_chunk_size * msm_host->dsc_slice_per_pkt + = 1; =20 dsi_write(msm_host, REG_DSI_CMD_MDP_STREAM0_CTRL, DSI_CMD_MDP_STREAM0_CTRL_WORD_COUNT(wc) | @@ -1683,8 +1673,13 @@ static int dsi_host_attach(struct mipi_dsi_host *hos= t, msm_host->lanes =3D dsi->lanes; msm_host->format =3D dsi->format; msm_host->mode_flags =3D dsi->mode_flags; - if (dsi->dsc) + if (dsi->dsc) { msm_host->dsc =3D dsi->dsc; + msm_host->dsc_slice_per_pkt =3D dsi->dsc_slice_per_pkt; + /* for backwards compatibility, assume 1 if not set */ + if (!msm_host->dsc_slice_per_pkt) + msm_host->dsc_slice_per_pkt =3D 1; + } =20 ret =3D dsi_dev_attach(msm_host->pdev); if (ret) diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 3aba7b380c8d..2ddec7931bd0 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -180,6 +180,7 @@ struct mipi_dsi_device_info { * be set to the real limits of the hardware, zero is only accepted for * legacy drivers * @dsc: panel/bridge DSC pps payload to be sent + * @dsc_slice_per_pkt: number of DSC slices to be sent as in a single pack= et */ struct mipi_dsi_device { struct mipi_dsi_host *host; @@ -194,6 +195,7 @@ struct mipi_dsi_device { unsigned long hs_rate; unsigned long lp_rate; struct drm_dsc_config *dsc; + unsigned int dsc_slice_per_pkt; }; =20 /** --=20 2.48.1