From nobody Wed Oct 1 22:30:30 2025 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013014.outbound.protection.outlook.com [40.107.201.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C199726981E; Wed, 1 Oct 2025 06:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.14 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759301304; cv=fail; b=tziZkgVvfEoJOojj/h4jZmtcBrcMuEPy7IqJnmF75srylA/25U65MlTSBf7EGB7A1UJN++AcjcmUYNq5AoDT4Lyo09cxmejZOYLNAxVkoa0Mnnfm+EmtKuAFBfjQvGwKWQQ07vM+Ygo9UGhacWRy0p2Crc3ka/Y1aSj/KxZvQrM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759301304; c=relaxed/simple; bh=BGMp4af+sBF6u17MZ7fQVzdSjrQDvf0kilIqxqLiAbo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UewmGgoBgzSIWh8l76Ip6/fvvv2UeP5u0N8SxL2ExkGVHl/PTSu/uv6OTvph7olmnp4foCHqiotoxSBDpJgIf+Gdz6hXFZwiKB6pr2Ki88cX47TMC83Rtl4wHXHPiJJZEalstk0yKPzjJCvFrX/xF0oD7tA4F6x7L+XBMi1j/mE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=V/3Zh7tu; arc=fail smtp.client-ip=40.107.201.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="V/3Zh7tu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Sw+Elk86xuGqqVcdAL9G5bkDNBRoCxQaJ7RUrmb0ZNJ92ln0wFI2JiTbL5u2IFGPLJpiJuD444fxMvYCk8mqCN2g7J4CzzDOcUALKFJ01kcJ/qxP9CdJ6p7nChnL08B0QEVNzlum9UaA6xBAwSx5DLOVJS8W9KB+VTuggfUQ9bZFuFpzvOzvG0nnZqp7R6adMf6ICbfjgnrgBM/xnv3d7CCOuQQfNMxhG8JL8FW7II9+xNd0vYs5iudGBqlmK8QAzzdo/eui3SlzHHp/au3VeSNeRiWPxZEVHbI0ZHquP/GPoQqeC5ytfnFSK0+yYxTObMA9rbd7YKAx98SlsyGbwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vOh3h7o5P2fNyAWQcu3XHfD4XJ5LopcCpOEC1KHR0dM=; b=v7jvEbZgNeCtZlK5QAb+vtGVV4ICDyh48lWV1BHnLO/lLOFLqEG3GebzLVH6Tx9d44vnpyUo98Ge419FVlFN8TlsEsCm4PmykXt5hSPEMop3M5XX+Mj1vsHMRyR3uQ+k57W6e2raPyESfAEh1bah375fsGUCGv1MVMVms1jHAxQ3tsY7aJoKa4UrqV8+lS2JuVgRhmlUpZCw2LgmIYMS20e095+Govcb/VXqnQHtjAwAye3LJhjjDxpcoCX5kIBD0IHtrR6dJ0bOsSrZU1Bk/R7PZ4ydmRSNNrfg+LYJrymMGS8AyUhXybxht3TByAXQhEz2gw3r8rGDYrH1B2ph9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vOh3h7o5P2fNyAWQcu3XHfD4XJ5LopcCpOEC1KHR0dM=; b=V/3Zh7tu6nm0JiDk8YcaqXLeEVxGbbmk5/dTdJnhkBYTExw7x8NPdDMReiQPVXhclbCFV0kORKhy5Zw8uxHfAMJOmWW8390Qn/GTFtB4QcgQD+iyK/n67Zc2KkhFinMb/Z234pR8l4DF1Nzi2URHSR0WmwA7e0VT+l3I/JmPizGPBO4/afxJROfylNf2jSgaxLP/CLOTAWNrdIgIbg/8yU/jmgiTb+ZnDRG9VnX98Jx8CfOZxgVVl5WvPt2JBGXN4BsUxc30r01pVenKOebfHOhJMtIDC1rPOqik3qeUg/PuE6X0/VILWO0Yrz+auPp0e0nfI8L1Y0s5IFBKzo7E5w== Received: from DS7P220CA0005.NAMP220.PROD.OUTLOOK.COM (2603:10b6:8:1ca::7) by CY5PR12MB6249.namprd12.prod.outlook.com (2603:10b6:930:23::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.18; Wed, 1 Oct 2025 06:48:18 +0000 Received: from DS2PEPF00003442.namprd04.prod.outlook.com (2603:10b6:8:1ca:cafe::f4) by DS7P220CA0005.outlook.office365.com (2603:10b6:8:1ca::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9160.17 via Frontend Transport; Wed, 1 Oct 2025 06:48:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by DS2PEPF00003442.mail.protection.outlook.com (10.167.17.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9 via Frontend Transport; Wed, 1 Oct 2025 06:48:18 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 30 Sep 2025 23:48:11 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 30 Sep 2025 23:48:10 -0700 Received: from kkartik-desktop.nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 30 Sep 2025 23:48:06 -0700 From: Kartik Rajput To: , , , , , , , , , , , , CC: Subject: [PATCH v9 1/4] i2c: tegra: Do not configure DMA if not supported Date: Wed, 1 Oct 2025 12:17:56 +0530 Message-ID: <20251001064759.664630-2-kkartik@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251001064759.664630-1-kkartik@nvidia.com> References: <20251001064759.664630-1-kkartik@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003442:EE_|CY5PR12MB6249:EE_ X-MS-Office365-Filtering-Correlation-Id: 465a5d8c-4c32-4202-d059-08de00b680fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|82310400026|36860700013|376014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7ejPirNeX1ZrWcbkvhKAogmrD3wnr6JMB5b/tDJj4Y1F9lD6pWx6+CZr6FRE?= =?us-ascii?Q?uobB2si+C1RN6LONoYc5RbO6P5378/LNfvIQh7gOriFhimD+LcJQSOUoO5Sw?= =?us-ascii?Q?YNHuoH3RR5HkR2yFLXlwgbCRczXHEhEPDPATtMh7Y0nFe7YHBWvC2ORbTADl?= =?us-ascii?Q?gWV122edKMlZ3fRJhZPWw0oefZf0YdBoyJpD/yt5FVPB+PA8i56lfHgThqKq?= =?us-ascii?Q?HWOUsObWviHpnA0C7/uh+u9T4vbYuESF3QP5Pmczpe35UMDdZk4+QAPzCfW3?= =?us-ascii?Q?QRbECUEeAUFlVcq5I8wVCIb8ehbu2706tMYHYtFn2jKsXBoEPPtfZxjpgiZJ?= =?us-ascii?Q?0P2C5l7Cnzt0TCLKDgw4fK3U7fnec7Avgkj+B5UEOs82dQoxSYs+0ak988kY?= =?us-ascii?Q?6UVvZP2H2sv0T77R//Dx9Py88KgYe5BIa73qVADFb1V67kqmld3eGnRbMZmW?= =?us-ascii?Q?i6t0TKxUlzsGLI8iKZaPb2o6spydRn9P3pW2hmQB2Zg942RZIVXPdRL4jyZQ?= =?us-ascii?Q?XK4ZcAvCIELtYlvgdNVUrp8fK4fS4JJaFDszEK9vWv+P9lOcXx03ZG/+AZw1?= =?us-ascii?Q?oAxllnW2nKHL/cECju3bs/hETiAfOO9kgnI6aGVT+KdvSIn2Buh5s/b3TXzk?= =?us-ascii?Q?qbK0SvqROeXNFsGVeEwxB8jcHmjbneJATwdKU8VQLq8gWY2MkKXBQxIHUi5S?= =?us-ascii?Q?TGFNyuujkv68DuXL5ZAT9QCm26xMlImciwCVwYsFHOs8tEnfmQtIwpQfx7sq?= =?us-ascii?Q?87uAAyh5/uujJbNoi72x42j1jvE4jerBIdf88jZ22Y0hG2gbMWhaCycHy49j?= =?us-ascii?Q?wdeisG1AVLHHyX095VGFLhijrMkTqsiZtep1N7q7JLyRu7KhA29a1nsOZqfM?= =?us-ascii?Q?My5xeTpbRjqs0RMYVhgxMi2WXO86j9nqb+bpGev/Bk2fk1JfRy8aaYhzNkpZ?= =?us-ascii?Q?soHQoEXqywBNNpBUFZx7LEiSGJNJKRwjmw6F4h60NBM0M1iEM96PukOVBG8o?= =?us-ascii?Q?pfmB805K0TZmTe7yXL4jhMGba39Xnyhzl9zzvbpaCHzhndj6qAu/S8kjPSl/?= =?us-ascii?Q?UxjW9Jn1G5VVgCHN72uwzcBXXJkdfmQILwhx/mC+xIFJDTAHNFYiLV3ww+T1?= =?us-ascii?Q?f3wMvOPo8DuMfEnBAUECa2lAGlKEqEWgNVfsIWaRQ+P9WMaaK0JEvfT5NOFv?= =?us-ascii?Q?HWEAzg0Tnh47YHTUCdYfcXlGLPchkVTtRtDIca7f4Jp5DLi6nsF5IoMD/O/l?= =?us-ascii?Q?ygxRI3qKWqzQlFmbaYuMbkDtueR3rrOKTjefk5skzo7nD9mfZzgwL0UjpJ5l?= =?us-ascii?Q?9mc0Nw0CyIQjNpI2faup7o3uKsbg5JzAO9Q5K+g6zHZMK96r7aVyQN1PVucV?= =?us-ascii?Q?cAGKA7xh2qiMoGaRrrz5ZbIT/iLCQFNX/RWWJ+x/w9gHZoycKCwnmMknZmq7?= =?us-ascii?Q?TBAEyRAHfEx2ZkST7FPV+4dOXVu2JGE2Y1/d6SFyeN2zvV8vK3hpKJ6Q4F16?= =?us-ascii?Q?IKRIhx1K6mequNNTuJHySN+bczxOHaaCfxbHtiMG3+gEx2Yf67HX9j/Akvuy?= =?us-ascii?Q?IjK8qpG6k+QZCQEw2Dg54fi87suoSh+5dGeGhI7H?= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(82310400026)(36860700013)(376014)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 06:48:18.0442 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 465a5d8c-4c32-4202-d059-08de00b680fe X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003442.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6249 Content-Type: text/plain; charset="utf-8" On Tegra264, not all I2C controllers have the necessary interface to GPC DMA, this causes failures when function tegra_i2c_init_dma() is called. Ensure that "dmas" device-tree property is present before initializing DMA in function tegra_i2c_init_dma(). Signed-off-by: Kartik Rajput --- v4 -> v9: Moved the condition down to have all dma checks together. v2 -> v4: * Add debug print if DMA is not supported by the I2C controller. v1 -> v2: * Update commit message to clarify that some I2C controllers may not have the necessary interface to GPC DMA. --- drivers/i2c/busses/i2c-tegra.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index e533460bccc3..aa7c0d8c0941 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -449,6 +449,11 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2= c_dev) if (IS_VI(i2c_dev)) return 0; =20 + if (!of_property_present(i2c_dev->dev->of_node, "dmas")) { + dev_dbg(i2c_dev->dev, "DMA not available, falling back to PIO\n"); + return 0; + } + if (i2c_dev->hw->has_apb_dma) { if (!IS_ENABLED(CONFIG_TEGRA20_APB_DMA)) { dev_dbg(i2c_dev->dev, "APB DMA support not enabled\n"); --=20 2.50.1 From nobody Wed Oct 1 22:30:30 2025 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010017.outbound.protection.outlook.com [52.101.61.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E45B23D28C; Wed, 1 Oct 2025 06:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.17 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759301312; cv=fail; b=S1KT1Q/S25WUf8LZpMKDnf3A1gRcYujAeYeu3ln+J80RKaasIFdJnUgUxzwY5dcRwk76Iui+1fVBtZmE7CCkD9fYeqoQ8ShwtyqxaHDMbOnFCCjxBea9sEWHSTs6LUaWTcv9xWAnhnR98qUCOIHNOukXkVDcix+OFLsHuxMG3CY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759301312; c=relaxed/simple; bh=jOyK9geY8BaE3nYHoLpft7ielXsz8r0QesHfahqL98A=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rct2GXjCbWbIPm17N2Slz9AKnH5vUck+BPXMkYnfUwddZ0ewVVYqEfbDxLC1CCrbuwM3cZ++F8W36ODgS8FEFCTMqp7nzXK1ASwj3XV2NJpFVujFkJRZRmBlBLRvprwkOL97odfJxiR/qlMZwLnoHR1iUIz9U6aIbet9Qemss4w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=eWwclbmX; arc=fail smtp.client-ip=52.101.61.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="eWwclbmX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YGK0D1gptSbOoQK+bjUcIlM91S42PbuGNuM6jya1RqWlPgfKv/r8IUuRKMQuNpa99JrGkhM4FajfUbmuKwP61mpj7IeD9UO6aD9VLdD6FqVkklWVqEBZ1TUKdqnevzSq66pVfGXPsamgDCsLiBdQ2D3TtuUG2jqJgbtAAmMPQrS7vc8uRoqCg5u2NcjE2n3WiP1XbQadPpkBz1cG/uKfmsr4IhLtDFhLMPFKgSnmY+7nPZIRiYYrFBItHw0iJHlJPvV7bLAq/tcPSNUsj8qZv0Lu/d6792UnI84xXOUvDNTbOlHy5W7/9cAf0t/PyVf8QCYW30ZUwAedqpZxtThenw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=unYBWW9nSnIYUFjPRYqEXNXBCzpb3rnO9t3RGDflYNs=; b=chqm7Fs9tJwG8jiZlB5vdEQFjWcX/4T6ZSi8MwuWPFhDTcr+fcRPRvaNdkeYoWozJ3Y88tGMJ9rXl2dPqtXQFT00V/2+L1FCd373ibnm0keqIRIMfbozRKxEIDiVXuMevDRhn1B3B3w5iUsKa4P0TL1uOb6dhK2vLaYypFPIW9V4nDFJWgbBSng6NCmpxyr1jXKGcxXpncH5PzIbwpwthVpmdBSSufrOnTFVUripq7z0UWr0V5ToNt/sR/63HAADd8qKnM/FJeZ7+PKm2rtw4T9JFVBjGEP5Zdz/37AmKP3/rMdGw4aSUa9DkyNX8sq78zMqrEJnxHKY4TmlNOoxEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=unYBWW9nSnIYUFjPRYqEXNXBCzpb3rnO9t3RGDflYNs=; b=eWwclbmXozdgAW1shFnQO4e2neHyZQAdc3qmYaOgz3MfAJEtGQc63uTpksw6lfvl5nL2xpMMBxu33+shED7AXcdVVLP2f+oc3m+CfqcchCa6xB2BeynmLmdf97YWj0At7rSxYJ7G0Et0EWKEEZ20O1aCnDrmqh9UZUE7TiHdr2j0cJtOsyWumcKkzdYEmKD/GrW90oI1Yc0LBjOXQ7m5FFpYavaumvk/dn/3/QubpcOFiavhQ6buqthm1Q83PgrTt3ceQ6bQ7gFrdFcW/NdyS4nYTYZ7V4Ns/HdJ04kapL8+gWswYoEYUNzoi0T0Ow/6am7aeIEv2emykPtSgWexTg== Received: from DS7PR03CA0294.namprd03.prod.outlook.com (2603:10b6:5:3ad::29) by SJ0PR12MB6941.namprd12.prod.outlook.com (2603:10b6:a03:448::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.17; Wed, 1 Oct 2025 06:48:23 +0000 Received: from DS2PEPF00003444.namprd04.prod.outlook.com (2603:10b6:5:3ad:cafe::79) by DS7PR03CA0294.outlook.office365.com (2603:10b6:5:3ad::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9182.14 via Frontend Transport; Wed, 1 Oct 2025 06:48:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by DS2PEPF00003444.mail.protection.outlook.com (10.167.17.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9 via Frontend Transport; Wed, 1 Oct 2025 06:48:22 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 30 Sep 2025 23:48:15 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 30 Sep 2025 23:48:14 -0700 Received: from kkartik-desktop.nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 30 Sep 2025 23:48:11 -0700 From: Kartik Rajput To: , , , , , , , , , , , , CC: Subject: [PATCH v9 2/4] i2c: tegra: Add HS mode support Date: Wed, 1 Oct 2025 12:17:57 +0530 Message-ID: <20251001064759.664630-3-kkartik@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251001064759.664630-1-kkartik@nvidia.com> References: <20251001064759.664630-1-kkartik@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003444:EE_|SJ0PR12MB6941:EE_ X-MS-Office365-Filtering-Correlation-Id: 16efb842-7812-4212-7062-08de00b683c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014|7416014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?U9w76Smbzt0baO5/AX9jlgB4r8NPJPadC9UAM2hG3vsUNA47YzGFkGJTm7JK?= =?us-ascii?Q?vev4N/wGi8TXcfFhalfDPKoodTE2UR8bZyGFBZbFFXNSyxEx7VKjiFR+7/Ei?= =?us-ascii?Q?NYkGWfjMOOY1KbmJ/Tn+j+DeActFTTzmn1d2jA29jut0QkNSO2+rQ3QtolOI?= =?us-ascii?Q?igPAyhLlqLGsD29PgXhEiQRk1adSVY5454JMNFVBeA8KbSyg4dDWrgZgkwPU?= =?us-ascii?Q?i6L6L61enmLp05w4pKA+qo1gqE33YR79XHCOIYfvZOzgTOCpTIWSqyhcOf7s?= =?us-ascii?Q?jeXl7an1g66jZL5LGp+tA9YiWQeBSdqEA4EzBQG0AOQ9WP1h5ujEsGEWuqHS?= =?us-ascii?Q?Y9zdtOYoMG5R5x8hEKzd3JojR3NvoNTJPfh/osoYHMMt30xRRLwuF4nDeIUE?= =?us-ascii?Q?Wayr8XdOUHM7hVgkMPy95uUQ4keRVjwiSGq5wK/SkXuue1VjXaRFoWZUMDQX?= =?us-ascii?Q?qZ3S0nleW9cRI6XaOltPhM6SzseHCulZbNfzkpdzTZEihnYh092fxvdQjvr7?= =?us-ascii?Q?eKpYFwQ9FLF5rOzctebTpjJdA2hl1pDGibvkw4XiV5aZZFHvtDyaiAVa0BCK?= =?us-ascii?Q?v6ykldmsY0nNVAqS4Z1qsuAd5yLRko29p/uIwXfDW0bfxtRRP7CablTVc2t0?= =?us-ascii?Q?VvOvtm8KpcdxmDegrjFcRfPX8hWSb3sR9nWiK306Ly+xXlpRbny3Cx5fKeJy?= =?us-ascii?Q?C4lxRWcDNxrwBpRAMSMXD/b91Wik7o17vjT2vx86lFCWZnigB09imoYbZMKU?= =?us-ascii?Q?eGkhHzRKcGLeAdDm+QrNBO/TU/5Mrir1Yc96Lbyj8Y/tZFAam1fp3pTCAhwP?= =?us-ascii?Q?ozivvYt0Fl6Ga+T029nXC4ekKmXMDneXpK7of0BK3QQRukVK83updohxa310?= =?us-ascii?Q?ENSaaAtSY6AAdQUJGGPW6RjdrwZVtHSvSJUFHru7WRrJVSvOHXn75IBuweg5?= =?us-ascii?Q?gNbD3cFewpev861B2shXD2thX3jFmciiS3V6tRR0zvo0dKpNpwvEFCXq7Ddt?= =?us-ascii?Q?Qv9/o/AndvMJMCJod2rhjS80A6QBXh9mOFZD6f18eGbJTA8xjS5AUpCG+gSu?= =?us-ascii?Q?tTC10h3MaY6al5r0PoI2r7zDL8SaPgvJ8eFoZbKGyPx1mlWP8t+J8m9cDb7h?= =?us-ascii?Q?z56iZjwHHy7oD8qLfIvhv0BjZj7WOy309bfCNP1qic15PJG6FRG3k6Mlh0MP?= =?us-ascii?Q?jjj4ZazUtl/3SEyB9kPkGRCrmIne01cxPl13Du6oVl48MDasM5DHhI/jTsyM?= =?us-ascii?Q?lyJIRqeSgd7R3hjNnl0Bc16y0S6MDcaBS092WWWk+eM1IFy3Eqync8m5Dczg?= =?us-ascii?Q?CagBjslYE3d8WktzI1BVY+MgDeOBLtkDjl1Jn1Q3dzsu86VPPPn6C23jgbmj?= =?us-ascii?Q?qCy3dmr5u0Kb3qtY2dHln33u8BuNXNlKCUU92Z8DDy8hBLNB9auqRBmXREtU?= =?us-ascii?Q?qKjzUcAEaps7O2fyL+PD0ulxRNMeQ66dyQEMguzLoWexUuceD1V4ugl3+EAo?= =?us-ascii?Q?x4YSNbbSLlxNig7TgVexpU1+Gc/0YEnS0ppnPziYVWS1LLb3glEJfPpC9QCM?= =?us-ascii?Q?+j1MhUuxm77qEU822nyEtI/oQ4sgcn/8xNCY9YuR?= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014)(7416014)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 06:48:22.6538 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16efb842-7812-4212-7062-08de00b683c3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003444.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6941 Content-Type: text/plain; charset="utf-8" From: Akhil R Add support for HS (High Speed) mode transfers, which is supported by Tegra194 onwards. Also adjust the bus frequency such that it uses the fast plus mode when HS mode is not supported. Signed-off-by: Akhil R Signed-off-by: Kartik Rajput --- v5 -> v9: * In the switch block, handle the case when hs mode is not supported. Also update it to use Fast mode for master code byte as per the I2C spec for HS mode. v3 -> v5: * Set has_hs_mode_support to false for unsupported SoCs. v2 -> v3: * Document tlow_hs_mode and thigh_hs_mode. v1 -> v2: * Document has_hs_mode_support. * Add a check to set the frequency to fastmode+ if the device does not support HS mode but the requested frequency is more than fastmode+. --- drivers/i2c/busses/i2c-tegra.c | 49 +++++++++++++++++++++++++++++++--- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index aa7c0d8c0941..cc75340f6cb5 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -91,6 +91,7 @@ #define I2C_HEADER_IE_ENABLE BIT(17) #define I2C_HEADER_REPEAT_START BIT(16) #define I2C_HEADER_CONTINUE_XFER BIT(15) +#define I2C_HEADER_HS_MODE BIT(22) #define I2C_HEADER_SLAVE_ADDR_SHIFT 1 =20 #define I2C_BUS_CLEAR_CNFG 0x084 @@ -198,6 +199,8 @@ enum msg_end_type { * @thigh_std_mode: High period of the clock in standard mode. * @tlow_fast_fastplus_mode: Low period of the clock in fast/fast-plus mod= es. * @thigh_fast_fastplus_mode: High period of the clock in fast/fast-plus m= odes. + * @tlow_hs_mode: Low period of the clock in HS mode. + * @thigh_hs_mode: High period of the clock in HS mode. * @setup_hold_time_std_mode: Setup and hold time for start and stop condi= tions * in standard mode. * @setup_hold_time_fast_fast_plus_mode: Setup and hold time for start and= stop @@ -206,6 +209,7 @@ enum msg_end_type { * in HS mode. * @has_interface_timing_reg: Has interface timing register to program the= tuned * timing settings. + * @has_hs_mode_support: Has support for high speed (HS) mode transfers. */ struct tegra_i2c_hw_feature { bool has_continue_xfer_support; @@ -226,10 +230,13 @@ struct tegra_i2c_hw_feature { u32 thigh_std_mode; u32 tlow_fast_fastplus_mode; u32 thigh_fast_fastplus_mode; + u32 tlow_hs_mode; + u32 thigh_hs_mode; u32 setup_hold_time_std_mode; u32 setup_hold_time_fast_fast_plus_mode; u32 setup_hold_time_hs_mode; bool has_interface_timing_reg; + bool has_hs_mode_support; }; =20 /** @@ -678,16 +685,28 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_d= ev) tegra_i2c_vi_init(i2c_dev); =20 switch (t->bus_freq_hz) { - case I2C_MAX_STANDARD_MODE_FREQ + 1 ... I2C_MAX_FAST_MODE_PLUS_FREQ: default: + if (!i2c_dev->hw->has_hs_mode_support) + t->bus_freq_hz =3D I2C_MAX_FAST_MODE_PLUS_FREQ; + fallthrough; + + case I2C_MAX_STANDARD_MODE_FREQ + 1 ... I2C_MAX_FAST_MODE_PLUS_FREQ: tlow =3D i2c_dev->hw->tlow_fast_fastplus_mode; thigh =3D i2c_dev->hw->thigh_fast_fastplus_mode; tsu_thd =3D i2c_dev->hw->setup_hold_time_fast_fast_plus_mode; =20 - if (t->bus_freq_hz > I2C_MAX_FAST_MODE_FREQ) + /* + * When HS mode is supported, the non-hs timing registers will be used f= or the + * master code byte for transition to HS mode. As per the spec, the 8 bi= t master + * code should be sent at max 400kHz. Therefore, limit the bus speed to = fast mode. + * Whereas when HS mode is not supported, allow the highest speed mode c= apable. + */ + if (t->bus_freq_hz > I2C_MAX_FAST_MODE_FREQ && !i2c_dev->hw->has_hs_mode= _support) { non_hs_mode =3D i2c_dev->hw->clk_divisor_fast_plus_mode; - else + t->bus_freq_hz =3D I2C_MAX_FAST_MODE_PLUS_FREQ; + } else { non_hs_mode =3D i2c_dev->hw->clk_divisor_fast_mode; + } break; =20 case 0 ... I2C_MAX_STANDARD_MODE_FREQ: @@ -717,6 +736,18 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_de= v) if (i2c_dev->hw->has_interface_timing_reg && tsu_thd) i2c_writel(i2c_dev, tsu_thd, I2C_INTERFACE_TIMING_1); =20 + /* Write HS mode registers. These will get used only for HS mode*/ + if (i2c_dev->hw->has_hs_mode_support) { + tlow =3D i2c_dev->hw->tlow_hs_mode; + thigh =3D i2c_dev->hw->thigh_hs_mode; + tsu_thd =3D i2c_dev->hw->setup_hold_time_hs_mode; + + val =3D FIELD_PREP(I2C_HS_INTERFACE_TIMING_THIGH, thigh) | + FIELD_PREP(I2C_HS_INTERFACE_TIMING_TLOW, tlow); + i2c_writel(i2c_dev, val, I2C_HS_INTERFACE_TIMING_0); + i2c_writel(i2c_dev, tsu_thd, I2C_HS_INTERFACE_TIMING_1); + } + clk_multiplier =3D (tlow + thigh + 2) * (non_hs_mode + 1); =20 err =3D clk_set_rate(i2c_dev->div_clk, @@ -1214,6 +1245,9 @@ static void tegra_i2c_push_packet_header(struct tegra= _i2c_dev *i2c_dev, if (msg->flags & I2C_M_RD) packet_header |=3D I2C_HEADER_READ; =20 + if (i2c_dev->timings.bus_freq_hz > I2C_MAX_FAST_MODE_PLUS_FREQ) + packet_header |=3D I2C_HEADER_HS_MODE; + if (i2c_dev->dma_mode && !i2c_dev->msg_read) *dma_buf++ =3D packet_header; else @@ -1502,6 +1536,7 @@ static const struct tegra_i2c_hw_feature tegra20_i2c_= hw =3D { .setup_hold_time_fast_fast_plus_mode =3D 0x0, .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, + .has_hs_mode_support =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra30_i2c_hw =3D { @@ -1527,6 +1562,7 @@ static const struct tegra_i2c_hw_feature tegra30_i2c_= hw =3D { .setup_hold_time_fast_fast_plus_mode =3D 0x0, .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, + .has_hs_mode_support =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra114_i2c_hw =3D { @@ -1552,6 +1588,7 @@ static const struct tegra_i2c_hw_feature tegra114_i2c= _hw =3D { .setup_hold_time_fast_fast_plus_mode =3D 0x0, .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, + .has_hs_mode_support =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra124_i2c_hw =3D { @@ -1577,6 +1614,7 @@ static const struct tegra_i2c_hw_feature tegra124_i2c= _hw =3D { .setup_hold_time_fast_fast_plus_mode =3D 0x0, .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D true, + .has_hs_mode_support =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra210_i2c_hw =3D { @@ -1602,6 +1640,7 @@ static const struct tegra_i2c_hw_feature tegra210_i2c= _hw =3D { .setup_hold_time_fast_fast_plus_mode =3D 0, .setup_hold_time_hs_mode =3D 0, .has_interface_timing_reg =3D true, + .has_hs_mode_support =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra186_i2c_hw =3D { @@ -1627,6 +1666,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c= _hw =3D { .setup_hold_time_fast_fast_plus_mode =3D 0, .setup_hold_time_hs_mode =3D 0, .has_interface_timing_reg =3D true, + .has_hs_mode_support =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra194_i2c_hw =3D { @@ -1648,10 +1688,13 @@ static const struct tegra_i2c_hw_feature tegra194_i= 2c_hw =3D { .thigh_std_mode =3D 0x7, .tlow_fast_fastplus_mode =3D 0x2, .thigh_fast_fastplus_mode =3D 0x2, + .tlow_hs_mode =3D 0x8, + .thigh_hs_mode =3D 0x3, .setup_hold_time_std_mode =3D 0x08080808, .setup_hold_time_fast_fast_plus_mode =3D 0x02020202, .setup_hold_time_hs_mode =3D 0x090909, .has_interface_timing_reg =3D true, + .has_hs_mode_support =3D true, }; =20 static const struct tegra_i2c_hw_feature tegra256_i2c_hw =3D { --=20 2.50.1 From nobody Wed Oct 1 22:30:30 2025 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013013.outbound.protection.outlook.com [40.93.201.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9C27238D32; Wed, 1 Oct 2025 06:48:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.13 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759301332; cv=fail; b=MsF6TxESnli8opjQnXPG8hjALjKMgs31sJ+sWngmKNB9q4l9RjjHvKfWV1Axtt7OFrvw4kyqdKJsQqGrTM9V7NaDzG63+6mbjLN+auUgXG9oPMpU0aRNgJYQ/pomU8t3v5fO+TEWgpTQ3ca4rAmL6vz26i8mFBreodnWs1YBhkU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759301332; c=relaxed/simple; bh=eqs+8l+1tKVv0YvGXO5os6Zsh9hvMca+IOQKGxeEJO4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=P0FQ/jBu/C7bymRse0HRX6py5vvIeemPXFcCrAQDKFHgP0h7vjVgX8M/VvIbu42/s98z26RVlTOANUGY5CP0QbyZzXZ+UrVq/+94FEuG6Z66J6O8zaHsDpRI6+sqWfwUbVgJx8BDE0QM6sI9iweOelk9aVJmVvsaPQACp+07omQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=U6nl+nlF; arc=fail smtp.client-ip=40.93.201.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="U6nl+nlF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EII48k/HzCeq3u+YuWKiTho4fxAckIaCKHmXEzjq22a6mLJtjQbfqlboMbpMAEkvapRiwHGckCpHNyaqVgLSwsjZy9q+CPuhnKH/9FuaAXMu3xUuJLI/2VQt0jdDq9AYFX5s3xYDpheC7kJrs0Y51scfeVzG3G35dATVPa14OZBzwB+XmoN4kExe85LaLFDv4X3G9gxSwoPsL4KmIvX2Pje9pGB8h3guJjGuIzElBiuhrgBQQhgWTblnTV6olL+a/Y2Glch0UnaDsgMHDYJES8xRnmd1iJjT+xTki/M5k7kRSTQTI6oom4EwN1P8rg18ZFOShERl7VV2du8olsPK8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rmT2tEpcYvxDwmfvayDqa9J14rUB8OymWeMjsgEEMu8=; b=VkTwMVVN6033O5YZnxPXqpGt2qGWIFc2TkK+C7GPA6l0pM1siOl/c45B1PcX0KLnKSWkhFSUL831D9raKLs+eiSak22VX9CX4sxayS+nkryCn+48gtJujOzo4DGTXlYGv96B61mL8RpW1s6kEZCxCF5oYPvT47rRkb1QAjZiS/9jsNzbsBvlk2+T65wsyQxcM96kLRKW4e+Z6s/Mo6Rw3IMcV/5iu6fz2CtDQQ7txRRN9LJ7WXRn2UWS1j99XjUIDZem9R8iNb1gQ+SbjbJpuMyvAQj0Qa+BfGk5z+RXycHe+LBnygMO+m0V4T/iwjXYRs9L1Z8icUGRqSWpznsZkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rmT2tEpcYvxDwmfvayDqa9J14rUB8OymWeMjsgEEMu8=; b=U6nl+nlF0SOFQAQnOSCT/Azn3Zr18ERWd2lEeOOwzZepEq9XrLc3jcJJdSNF+k7pmTI7N3JEwUbA6iBgUMxBKUfvtgBmHsNkbiVTT7CQSST7M6rM4B/1nIBcB+ZWhfkI5RCicCPpVZDzTfCyyFkADBg+t/lgbJq/HjzN+qBUcojV3TrkRMN/LyXDx+4EweWb1lnqgU2LODjAMNt+jmpj65RYYaq3OZ9/Wjk5VygcvnEBDpJtwOQX53eQkfpJwVhUOfQdKB3L+PuUGVnM4ip267xtUCgfLQOl1eCzBfXDQTj5f1vvEQ2UG2KRC0a9LIN5ornFaEpxj492SKt9x//oHA== Received: from BN9PR03CA0867.namprd03.prod.outlook.com (2603:10b6:408:13d::32) by BL1PR12MB5849.namprd12.prod.outlook.com (2603:10b6:208:384::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.17; Wed, 1 Oct 2025 06:48:46 +0000 Received: from BN2PEPF00004FC1.namprd04.prod.outlook.com (2603:10b6:408:13d:cafe::10) by BN9PR03CA0867.outlook.office365.com (2603:10b6:408:13d::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9160.17 via Frontend Transport; Wed, 1 Oct 2025 06:48:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by BN2PEPF00004FC1.mail.protection.outlook.com (10.167.243.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9 via Frontend Transport; Wed, 1 Oct 2025 06:48:46 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 30 Sep 2025 23:48:19 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 30 Sep 2025 23:48:19 -0700 Received: from kkartik-desktop.nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 30 Sep 2025 23:48:15 -0700 From: Kartik Rajput To: , , , , , , , , , , , , CC: Subject: [PATCH v9 3/4] i2c: tegra: Add support for SW mutex register Date: Wed, 1 Oct 2025 12:17:58 +0530 Message-ID: <20251001064759.664630-4-kkartik@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251001064759.664630-1-kkartik@nvidia.com> References: <20251001064759.664630-1-kkartik@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF00004FC1:EE_|BL1PR12MB5849:EE_ X-MS-Office365-Filtering-Correlation-Id: a6dce2b4-0780-44ad-c2a1-08de00b691dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|36860700013|1800799024|82310400026|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?qvsvuRPm3A1I2CbtZ0XH0cfDNoAOh77/0oiEXPm0t4x/pu8WUd10zt/SnZo7?= =?us-ascii?Q?MUDm2ltESpg/kI0MVE9yc29kxpscycXaZm/lbXsm/uFGy9L+S1wgjocyzlJ2?= =?us-ascii?Q?D4HYcMniaVlH67D8XuXVdYgT7VLgo3VlYLAhDXoSAcWN2+F3UlyHcn1g+Ucx?= =?us-ascii?Q?prSCGHhOTAyhP3HRrZK2q0n7ilx9/R/8ZszzQuipFT+guarxkCN9RtM9LhFA?= =?us-ascii?Q?b30RiDjCmaocQ0iXEzK4nT9+B3BOEjuPvatlvNnLC4TFX5OxThn6erm6D7zo?= =?us-ascii?Q?uczSCa6QwQeK2RRHR8uBMI71NsGptKwiADeLAwdxqgiM6RqCACetnPXO/DCm?= =?us-ascii?Q?sTj380lqCCyMMa51v8lHR237Vfw8ZlOczmuk+Ff3vVKTw0/Y1m/3oj9Nb/Au?= =?us-ascii?Q?xbqgGUTrO3EW2MVLCvNafEVR+BhlGC/MlPLoEESRAXZIXkQBu0ixc3vxTcIf?= =?us-ascii?Q?01zJQet7AcbK4la5WksWsF6WqQi85gR5Td4tlhoz+MHJuko93ZzSf7amx5XF?= =?us-ascii?Q?4OI7kABZ57OPiv+iKCFRqLdld6lN5EivFNQw7gRGiHB/Ic8iIsIVOvGUYk49?= =?us-ascii?Q?5y8A6NuZJKWq9km72ukDL3RxnGcR3NH6VXpiRODKEDVxtBVBiIOTcKqdU8rb?= =?us-ascii?Q?q0rENl/TJ9pQoBwAQjQhyXYt0HFrO6JZk2/1mmrCcb3faarwzPNDEppufbyi?= =?us-ascii?Q?sMRr3zoilT7KQUc2w2fKr1sQoz6uF5NpXSAbCBidYubi643TuWYT0Bf+zLwd?= =?us-ascii?Q?ppWmKTb89JTHBsnVpLny27UJhVzKMCuhM9H2+wLGonSFBQhoSTcnCXr7NR+5?= =?us-ascii?Q?IwqImcCnVtpBDb3RdMFTdEiBSPOHoTFldIhF+I7xhtkDTXro0SsUYeQ1Qs/o?= =?us-ascii?Q?YLFbXX5KXyStIr+iegrQ4KBlBZyRI2tB8wymQjPY4TAp0hCwmE5bifa7v9v/?= =?us-ascii?Q?jcxYcR6pIV5Xqz7PD4nHJJmnPDYpjfM9yCqrCnCrZTG5Pdr6ZTWhJhq61QnV?= =?us-ascii?Q?+NVZ/oHs0J/QgWpSwnYm5oF9dg8I3TUfB+4CjQZUqwSQQcR3qt3fnR4PE5cM?= =?us-ascii?Q?fZgjJLL62oAJ9rUSIbriELOJwDIaYH/DzN06CVYVbf/Ctu1ieLHUbFayUw9k?= =?us-ascii?Q?et5vm1TvoZaJ6JVxOY0YlxbiLOyUh2hSYbW6EZK+f0tfoZ6hLy5YTVvYrePg?= =?us-ascii?Q?df2iphX+ZjxlQTanDpeP8F91Nff+QvYLMnaEqa5F9gPP92WcRU3oWUqJjhfG?= =?us-ascii?Q?IKGu6l160o811buiJyZMjLKB6BAp3xwFQa/oAD9FYW4SZudivDvVtireedEZ?= =?us-ascii?Q?eh0kR8W4rif9fhq8Y0hbYoZhIK3Y0/e6ysL4uA8t7Nsb1FC3DNEZiBN9YtON?= =?us-ascii?Q?oaee30sadf32PA2DKc3RrdeeRCi05zyfUr6oweyamX2VXo18R+V2DPlDEMgb?= =?us-ascii?Q?url8Ruq6dk+9Qape6DRkJ0a0z1y41jsjfxlP4qCXaLNU5bjtpTYJscDMYFbV?= =?us-ascii?Q?TMWdTO+NqZXv+idasTUcNhlgjqTJw+SoH8uh4FlVO9HoO1iLgKkwgEdf73u2?= =?us-ascii?Q?wGfWggTzvNwCIrgfUfUYyWcfVZWun98h6yADUCUT?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(7416014)(376014)(36860700013)(1800799024)(82310400026)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 06:48:46.2455 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a6dce2b4-0780-44ad-c2a1-08de00b691dc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF00004FC1.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5849 Content-Type: text/plain; charset="utf-8" Add support for SW mutex register introduced in Tegra264 to provide an option to share the interface between multiple firmwares and/or VMs. This involves following steps: - A firmware/OS writes its unique ID to the mutex REQUEST field. - Ownership is established when reading the GRANT field returns the same ID. - If GRANT shows a different non-zero ID, the firmware/OS retries until timeout. - After completing access, it releases the mutex by writing 0. However, the hardware does not ensure any protection based on the values. The driver/firmware should honor the peer who already holds the mutex. Signed-off-by: Kartik Rajput Signed-off-by: Akhil R --- v7 -> v8: * Use `bool` instead of `int` for `locked` variable in tegra_i2c_mutex_lock() function. v6 -> v7: * Return bool from tegra_i2c_mutex_acquired() and tegra_i2c_mutex_trylock() functions. * Move `has_mutex` check inside tegra_i2c_mutex_lock/unlock functions. * Remove redundant empty line added in tegra_i2c_xfer() in v6. * Fix pm_runtime_put() not getting called if mutex unlock fails. * In tegra_i2c_mutex_lock() simplify the logic to check if the mutex is acquired or not by checking the value of `ret` variable. * Update commit message to describe the functioning of SW mutex feature. v4 -> v6: * Guard tegra_i2c_mutex_lock() and tegra_i2c_mutex_unlock() to ensure that they are called on platforms which support SW mutex. v3 -> v4: * Update timeout logic of tegra_i2c_mutex_lock() to use read_poll_timeout APIs for improving timeout logic. * Add tegra_i2c_mutex_acquired() to check if mutex is acquired or not. * Rename I2C_SW_MUTEX_ID as I2C_SW_MUTEX_ID_CCPLEX. * Function tegra_i2c_poll_register() was moved unnecessarily, it has now been moved to its original location. * Use tegra_i2c_mutex_lock/unlock APIs in the tegra_i2c_xfer() function. This ensures proper propagation of error in case mutex lock fails. Please note that as the function tegra_i2c_xfer() is already guarded by the bus lock operation there is no need of additional lock for the tegra_i2c_mutex_lock/unlock APIs. v2 -> v3: * Update tegra_i2c_mutex_trylock and tegra_i2c_mutex_unlock to use readl and writel APIs instead of i2c_readl and i2c_writel which use relaxed APIs. * Use dev_warn instead of WARN_ON if mutex lock/unlock fails. v1 -> v2: * Fixed typos. * Fix tegra_i2c_mutex_lock() logic. * Add a timeout in tegra_i2c_mutex_lock() instead of polling for mutex indefinitely. --- drivers/i2c/busses/i2c-tegra.c | 92 ++++++++++++++++++++++++++++++++++ 1 file changed, 92 insertions(+) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index cc75340f6cb5..1c8c24ae54ed 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -137,6 +137,14 @@ =20 #define I2C_MASTER_RESET_CNTRL 0x0a8 =20 +#define I2C_SW_MUTEX 0x0ec +#define I2C_SW_MUTEX_REQUEST GENMASK(3, 0) +#define I2C_SW_MUTEX_GRANT GENMASK(7, 4) +#define I2C_SW_MUTEX_ID_CCPLEX 9 + +/* SW mutex acquire timeout value in microseconds. */ +#define I2C_SW_MUTEX_TIMEOUT_US (25 * USEC_PER_MSEC) + /* configuration load timeout in microseconds */ #define I2C_CONFIG_LOAD_TIMEOUT 1000000 =20 @@ -210,6 +218,7 @@ enum msg_end_type { * @has_interface_timing_reg: Has interface timing register to program the= tuned * timing settings. * @has_hs_mode_support: Has support for high speed (HS) mode transfers. + * @has_mutex: Has mutex register for mutual exclusion with other firmware= s or VMs. */ struct tegra_i2c_hw_feature { bool has_continue_xfer_support; @@ -237,6 +246,7 @@ struct tegra_i2c_hw_feature { u32 setup_hold_time_hs_mode; bool has_interface_timing_reg; bool has_hs_mode_support; + bool has_mutex; }; =20 /** @@ -381,6 +391,76 @@ static void i2c_readsl(struct tegra_i2c_dev *i2c_dev, = void *data, readsl(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg), data, len); } =20 +static bool tegra_i2c_mutex_acquired(struct tegra_i2c_dev *i2c_dev) +{ + unsigned int reg =3D tegra_i2c_reg_addr(i2c_dev, I2C_SW_MUTEX); + u32 val, id; + + val =3D readl(i2c_dev->base + reg); + id =3D FIELD_GET(I2C_SW_MUTEX_GRANT, val); + + return id =3D=3D I2C_SW_MUTEX_ID_CCPLEX; +} + +static bool tegra_i2c_mutex_trylock(struct tegra_i2c_dev *i2c_dev) +{ + unsigned int reg =3D tegra_i2c_reg_addr(i2c_dev, I2C_SW_MUTEX); + u32 val, id; + + val =3D readl(i2c_dev->base + reg); + id =3D FIELD_GET(I2C_SW_MUTEX_GRANT, val); + if (id !=3D 0 && id !=3D I2C_SW_MUTEX_ID_CCPLEX) + return false; + + val =3D FIELD_PREP(I2C_SW_MUTEX_REQUEST, I2C_SW_MUTEX_ID_CCPLEX); + writel(val, i2c_dev->base + reg); + + return tegra_i2c_mutex_acquired(i2c_dev); +} + +static int tegra_i2c_mutex_lock(struct tegra_i2c_dev *i2c_dev) +{ + bool locked; + int ret; + + if (!i2c_dev->hw->has_mutex) + return 0; + + if (i2c_dev->atomic_mode) + ret =3D read_poll_timeout_atomic(tegra_i2c_mutex_trylock, locked, locked, + USEC_PER_MSEC, I2C_SW_MUTEX_TIMEOUT_US, + false, i2c_dev); + else + ret =3D read_poll_timeout(tegra_i2c_mutex_trylock, locked, locked, USEC_= PER_MSEC, + I2C_SW_MUTEX_TIMEOUT_US, false, i2c_dev); + + if (ret) + dev_warn(i2c_dev->dev, "failed to acquire mutex\n"); + + return ret; +} + +static int tegra_i2c_mutex_unlock(struct tegra_i2c_dev *i2c_dev) +{ + unsigned int reg =3D tegra_i2c_reg_addr(i2c_dev, I2C_SW_MUTEX); + u32 val, id; + + if (!i2c_dev->hw->has_mutex) + return 0; + + val =3D readl(i2c_dev->base + reg); + + id =3D FIELD_GET(I2C_SW_MUTEX_GRANT, val); + if (id && id !=3D I2C_SW_MUTEX_ID_CCPLEX) { + dev_warn(i2c_dev->dev, "unable to unlock mutex, mutex is owned by: %u\n"= , id); + return -EPERM; + } + + writel(0, i2c_dev->base + reg); + + return 0; +} + static void tegra_i2c_mask_irq(struct tegra_i2c_dev *i2c_dev, u32 mask) { u32 int_mask; @@ -1432,6 +1512,10 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, = struct i2c_msg msgs[], return ret; } =20 + ret =3D tegra_i2c_mutex_lock(i2c_dev); + if (ret) + return ret; + for (i =3D 0; i < num; i++) { enum msg_end_type end_type =3D MSG_END_STOP; =20 @@ -1461,6 +1545,7 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, s= truct i2c_msg msgs[], break; } =20 + ret =3D tegra_i2c_mutex_unlock(i2c_dev); pm_runtime_put(i2c_dev->dev); =20 return ret ?: i; @@ -1537,6 +1622,7 @@ static const struct tegra_i2c_hw_feature tegra20_i2c_= hw =3D { .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, .has_hs_mode_support =3D false, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra30_i2c_hw =3D { @@ -1563,6 +1649,7 @@ static const struct tegra_i2c_hw_feature tegra30_i2c_= hw =3D { .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, .has_hs_mode_support =3D false, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra114_i2c_hw =3D { @@ -1589,6 +1676,7 @@ static const struct tegra_i2c_hw_feature tegra114_i2c= _hw =3D { .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, .has_hs_mode_support =3D false, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra124_i2c_hw =3D { @@ -1615,6 +1703,7 @@ static const struct tegra_i2c_hw_feature tegra124_i2c= _hw =3D { .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D true, .has_hs_mode_support =3D false, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra210_i2c_hw =3D { @@ -1641,6 +1730,7 @@ static const struct tegra_i2c_hw_feature tegra210_i2c= _hw =3D { .setup_hold_time_hs_mode =3D 0, .has_interface_timing_reg =3D true, .has_hs_mode_support =3D false, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra186_i2c_hw =3D { @@ -1667,6 +1757,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c= _hw =3D { .setup_hold_time_hs_mode =3D 0, .has_interface_timing_reg =3D true, .has_hs_mode_support =3D false, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra194_i2c_hw =3D { @@ -1695,6 +1786,7 @@ static const struct tegra_i2c_hw_feature tegra194_i2c= _hw =3D { .setup_hold_time_hs_mode =3D 0x090909, .has_interface_timing_reg =3D true, .has_hs_mode_support =3D true, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra256_i2c_hw =3D { --=20 2.50.1 From nobody Wed Oct 1 22:30:31 2025 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012023.outbound.protection.outlook.com [52.101.48.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 616E927281C; Wed, 1 Oct 2025 06:48:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.23 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759301337; cv=fail; b=TnVJOT6axYAbwETym/NdkUIxERhlrjhKoxXLjF6lx4C8Y/FcBplm4mQojY8NYTpLVkBuKWa+5ZMNhttuZXbUvr13tfRRW3Z1FaHndQvMzcuNJgrZT5hyCartXoOptWe1oTQgmG1GwMwmXCQFD6PqPYCrFYqD+2yAoXB1kAxxQ5s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759301337; c=relaxed/simple; bh=qIAUNMQx6bUSf7SL8hk3oozqGh8HSqxh93dMWCi7e6I=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ht7/TJuuZppf77cw59krdLwYYeibUzIdbNC/H0wvB1N+U/G3kpjL6zd9Hguup+MRobmOa+ErbU1TvMiOlD0R/8I7BpY/wrmWsLeVyBxTwm+aAAJpAxbSI8vrtTRnpg0qk5N0dKlAtUYuFr2YfTnsjvwYC6NndXLh/XzEKK6B8Dk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ccDQmFPG; arc=fail smtp.client-ip=52.101.48.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ccDQmFPG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YHmduH4T5g6UWwt0wPcNHDphJizqwvFTB1DQtYeVI3zV1Z4klqPsfW2/w5xh1XLj002yIk/+hsv9SaSC+ONGdy/vxq64y2NTrL4H1fiBGXHQhXIIF3DYQ6Rgxzdp4OTJN2YBVZYSOAwWHFuK1x03SJ53qmRBXwPHOFSf8GFulApKRMNGU2x35hXKVr0uNmvLr5z0UOZhBPbiyR8/0f9Mdi4l7Om6ERbJ86YEPL/KQ7B0t8V+NFzvxgY9sxXtSHnrC+hoeurI82D4UKfERncKAX8PGRccUeiCaeW2xTwaqQvip4eMYc55Fx7Ibq9a0JzNKa1XrvSQP/dgsZHRUO5C+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pJ/Xt0l41KB3wn0UXa2TEd4STHS/h7f/fkiWWAbREg8=; b=WADp8CfO6knas8ZbYnJMaRXYrFT3W9rmVTXwmD/NwAWiQXcXarpZ7U8yyTGGh+eil8cFU7WPQvNYQkLCm8s0TfqoYQBI7bQ2vGY2ZCWod5eS9HKv0hSn5R3UUHubFcSwBwG5j96ezpkG4oxSf5/Qm4uxjfK42pbU07K4GM8gDj7VYb3vTkaQAJU5ZMQr4uit08+Pmibo0P9Asnr7iU8dOnbkCwSJIKuKxbb3DPs9y0GD/2ZLnkHRIL5QwNpVnWjnR7B4ER/9iN3UqS8cpMP5UZyQZ4LBvmfeqGVj8nno22kLfFOb9cnVsPapoIubgaqGD6B343R9ixOy6yxRQg3KjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pJ/Xt0l41KB3wn0UXa2TEd4STHS/h7f/fkiWWAbREg8=; b=ccDQmFPGueWQrjCb1yYBulbI4ING6SESDVIub/k8Nh77z1Xv00zsqymve3pn8n6HIzq+dQ76rAOWZE1DRgRsMhtFQDuZJVOf428Ne4wTjk3qFmg+JYtvJZf0ygUOm4O3b81vl91aD5l8449dVv4aWL/MLHeCSkpFNtBuBGGR+uH4XVSnzys1V0tb5n0oKHqeCvScgO86B++typMufJ9e9ppfCJYwBsndSSggpcZKpuEuGk+AJabDChHMiMNOMtQYXzmUUNwHch1IPq2GFlmxhzHXy+OIQljbDRPnx6bJMT5RhC6PUu/t2PKef+ViRaf6QaZ9RCauXcL4wSdYQMbH3A== Received: from BN9PR03CA0863.namprd03.prod.outlook.com (2603:10b6:408:13d::28) by DM4PR12MB6496.namprd12.prod.outlook.com (2603:10b6:8:bd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9115.19; Wed, 1 Oct 2025 06:48:49 +0000 Received: from BN2PEPF00004FC1.namprd04.prod.outlook.com (2603:10b6:408:13d:cafe::a3) by BN9PR03CA0863.outlook.office365.com (2603:10b6:408:13d::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9182.14 via Frontend Transport; Wed, 1 Oct 2025 06:48:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by BN2PEPF00004FC1.mail.protection.outlook.com (10.167.243.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9160.9 via Frontend Transport; Wed, 1 Oct 2025 06:48:48 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 30 Sep 2025 23:48:24 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 30 Sep 2025 23:48:23 -0700 Received: from kkartik-desktop.nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 30 Sep 2025 23:48:19 -0700 From: Kartik Rajput To: , , , , , , , , , , , , CC: Subject: [PATCH v9 4/4] i2c: tegra: Add Tegra264 support Date: Wed, 1 Oct 2025 12:17:59 +0530 Message-ID: <20251001064759.664630-5-kkartik@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251001064759.664630-1-kkartik@nvidia.com> References: <20251001064759.664630-1-kkartik@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF00004FC1:EE_|DM4PR12MB6496:EE_ X-MS-Office365-Filtering-Correlation-Id: b4b5e785-253c-4402-aa16-08de00b69347 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|82310400026|7416014|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YFaaWqymw4d8mdNuKmCow4PpaHqVk7fLrmWnxdpuSEl3j/NTOSyyZLvTfQ3G?= =?us-ascii?Q?0U7JJ5f7MKw1L/Zfcw4VZIbairoapVYpiUx33ZoAqgvRYsXV0G04zslssOhs?= =?us-ascii?Q?45n6FZBT1oZMVHXq5FHxnDSbcPDaQJ4rwq7POiuoLS/YmxIKLhnxa5KOxvpP?= =?us-ascii?Q?rpWW08n4oC4BRnUbGjswIywgTwaiVYq/cFASkoPrimfF/UE0dfz5WstHLx+e?= =?us-ascii?Q?BUhI1A8kQRpPoPjLQuj9jY5dL7fiyAwz/pMdpstpIZEB6nEwePP3728ej44E?= =?us-ascii?Q?hWcjSLxwd4iZokVNo8CqdI3WNX5V2Sef7CgJoXjMJ8X7gTerNnfvA8RVZkP8?= =?us-ascii?Q?CTiYlz4eOnqCh9EhAZv/gonzTMr4h8QUMKAWEtUqRi3WRCZcKLTKCy5zwEHH?= =?us-ascii?Q?JKHxo2vZc07tz6BHAq2XZPAfNSNiTgZRcUwckbDvz3fyV7mKhYBTxn4ccMjb?= =?us-ascii?Q?y5Un72MTDj/sym7EysOap4H3Q1bU5f0AF6jDLPuZqBJtD+Rh4Ek627ygOk9e?= =?us-ascii?Q?FUq/oUqGtcfR6WLKTWbnsLGGxjSJvT+WqNCTutoi13cXRAcMcLE58LrIZ9mT?= =?us-ascii?Q?1QoMNEvrrKPD61uXF+2XigN1oWrGd3Zh7lWOjgJ866Aj5M34I9gR9CLcDxWs?= =?us-ascii?Q?O+EmlSwB9naHtepQtQFSrM/+WmQKUb34Zez/FVtEfsSPGeNnS/GbMLtNDo9l?= =?us-ascii?Q?wjtz7M99On6ZMuL1WZg7u70JZQTNv0Bab6CdnCPdxEih+2MT3Dp3kLLZdAVt?= =?us-ascii?Q?+zr1ePPbJmCgMEGzpHYGuRDac+nQlFOEHyIhwR2z1fpWvEjnGwVFtkDvevtP?= =?us-ascii?Q?itA1Kml20Va9NGLvC8QuNN/jaKJZ8Dg5xqJYVgBqYnTSChXeRP4dctcJkTv/?= =?us-ascii?Q?TzUUjWy7qvCILbCOun9Pbop0H3PMTJWl0BucC57l0xnGNjp3jfMsC7e3nQF1?= =?us-ascii?Q?iOMENM4n4tOeWPxE2gOnZUVcLD7nWQ3JKl4gB+3tTMqkE10wiAAuPwtMQpsr?= =?us-ascii?Q?V8bGLJTtJw1fmrQZSw5FaUyRGRVDC8dVAky/UzJ9rtTVLZUmumf/VLR2iEXH?= =?us-ascii?Q?Ctp00V2r2wLZ0lhPqzyMPIwSLooCQEyMW6tofGHjHiCjsDakwtwrby5JwQdi?= =?us-ascii?Q?McX9q69lv+e3VfxqXZkoYeXK86PCI/Lh23WrW9orS0MktvsCpZG+5D2Uq+vQ?= =?us-ascii?Q?F8rRutXs9MFddpu8aRpOOn+NXxZfA2N9F6Ul5djtzWj3iM2bTmOLLJ3ZLTvs?= =?us-ascii?Q?1wb1os20KSZHPM/JicHXvoVNTo+wlcis5M+t+9hgv73elAJ4lQAH3Qi2jkFy?= =?us-ascii?Q?H3yJ+vgDWSNkImpEnkhtJEF7ZHQ9796dzkseSw322X5APo3TkZh8sQ3ALnQ0?= =?us-ascii?Q?oIyXijqgsQWDvanW66u4BinzRehKMDcH/1PUokfrBzvOR1bG43tKzcN3HtCI?= =?us-ascii?Q?oq9Aq1rgqtP7JdoKB/LZy1L2J1t8Z5I3l055FQoWYmM8LtlKjePhWxVGTvJS?= =?us-ascii?Q?2aOvJi1RQ3USQmLi+sRVrYaCvgiiQQxdT8ysAZT5Ra0B6N3bJarEbKBwO7EK?= =?us-ascii?Q?J/u0aMkuRt2fCGYBFjO6cX3V9H/CXv1vBbDOtXgt?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026)(7416014)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2025 06:48:48.6361 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4b5e785-253c-4402-aa16-08de00b69347 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF00004FC1.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6496 Content-Type: text/plain; charset="utf-8" From: Akhil R Add support for Tegra264 SoC which supports 17 generic I2C controllers, two of which are in the AON (always-on) partition of the SoC. In addition to the features supported by Tegra194 it also supports a SW mutex register to allow sharing the same I2C instance across multiple firmware. Signed-off-by: Akhil R Signed-off-by: Kartik Rajput --- v1 -> v4: * Update commit message to mention the SW mutex feature available on Tegra264. --- drivers/i2c/busses/i2c-tegra.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 1c8c24ae54ed..f324cf3b1f28 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -1814,7 +1814,36 @@ static const struct tegra_i2c_hw_feature tegra256_i2= c_hw =3D { .has_interface_timing_reg =3D true, }; =20 +static const struct tegra_i2c_hw_feature tegra264_i2c_hw =3D { + .has_continue_xfer_support =3D true, + .has_per_pkt_xfer_complete_irq =3D true, + .clk_divisor_hs_mode =3D 1, + .clk_divisor_std_mode =3D 0x1d, + .clk_divisor_fast_mode =3D 0x15, + .clk_divisor_fast_plus_mode =3D 0x8, + .has_config_load_reg =3D true, + .has_multi_master_mode =3D true, + .has_slcg_override_reg =3D true, + .has_mst_fifo =3D true, + .quirks =3D &tegra194_i2c_quirks, + .supports_bus_clear =3D true, + .has_apb_dma =3D false, + .tlow_std_mode =3D 0x8, + .thigh_std_mode =3D 0x7, + .tlow_fast_fastplus_mode =3D 0x2, + .thigh_fast_fastplus_mode =3D 0x2, + .tlow_hs_mode =3D 0x4, + .thigh_hs_mode =3D 0x2, + .setup_hold_time_std_mode =3D 0x08080808, + .setup_hold_time_fast_fast_plus_mode =3D 0x02020202, + .setup_hold_time_hs_mode =3D 0x090909, + .has_interface_timing_reg =3D true, + .has_hs_mode_support =3D true, + .has_mutex =3D true, +}; + static const struct of_device_id tegra_i2c_of_match[] =3D { + { .compatible =3D "nvidia,tegra264-i2c", .data =3D &tegra264_i2c_hw, }, { .compatible =3D "nvidia,tegra256-i2c", .data =3D &tegra256_i2c_hw, }, { .compatible =3D "nvidia,tegra194-i2c", .data =3D &tegra194_i2c_hw, }, { .compatible =3D "nvidia,tegra186-i2c", .data =3D &tegra186_i2c_hw, }, --=20 2.50.1