From nobody Wed Oct 1 21:27:10 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C9BB827470 for ; Wed, 1 Oct 2025 04:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759292719; cv=none; b=ls4XHvMmWbjlgXV90XevDRaakWW8fhYCrEwHj9SR3M6EWiqEvOnc0YvbwC8QsGYXKj0g8Nd3m4FdNjjCuCT+zV8AM8I6gT9AJo01BJOjnugFmGxP2zWrU+zSeql4x6q51QNfr23YLyi3BNzxed+EhM74vXkOiiEAGdz3clpUGLw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759292719; c=relaxed/simple; bh=3v9l6cWin8qA5atXuLUSIuYcNTkRwhwS6cq52axBA8c=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=CnSL3LO34UYqBgdygfEYt1oDqe5Nm6DuBs9tuWZpA8+YFgjG9usjXgmQjC8F84KTZhvw8q/xlV8qTVWiihMb7rDuvLyMA02KbrbJWYTFgdmOpDffaT6RCp36o951iwEzgRKt6yOLx7N8iwJFnolLhRz+QM/6rvXh0q6VGSc57yg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1CCC616F2; Tue, 30 Sep 2025 21:25:03 -0700 (PDT) Received: from ergosum.cambridge.arm.com (ergosum.cambridge.arm.com [10.1.196.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B4C903F66E; Tue, 30 Sep 2025 21:25:09 -0700 (PDT) From: Anshuman Khandual To: linux-mm@kvack.org Cc: Anshuman Khandual , Andrew Morton , David Hildenbrand , linux-kernel@vger.kernel.org, Dev Jain , Lance Yang , SeongJae Park Subject: [PATCH V2] mm/ptdump: Replace READ_ONCE() with standard page table accessors Date: Wed, 1 Oct 2025 05:25:02 +0100 Message-Id: <20251001042502.1400726-1-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace READ_ONCE() with standard page table accessors i.e pxdp_get() which anyways default into READ_ONCE() in cases where platform does not override. Also convert ptep_get_lockless() into ptep_get() as well. Cc: Andrew Morton Cc: David Hildenbrand Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Reviewed-by: Dev Jain Acked-by: Lance Yang Acked-by: SeongJae Park Signed-off-by: Anshuman Khandual Acked-by: David Hildenbrand --- Changes in V2: - Replaced ptep_get_lockless() with ptep_get() per David Changes in V1: https://lore.kernel.org/all/20250930025246.1143340-1-anshuman.khandual@arm.= com/ mm/ptdump.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/ptdump.c b/mm/ptdump.c index b600c7f864b8..973020000096 100644 --- a/mm/ptdump.c +++ b/mm/ptdump.c @@ -31,7 +31,7 @@ static int ptdump_pgd_entry(pgd_t *pgd, unsigned long add= r, unsigned long next, struct mm_walk *walk) { struct ptdump_state *st =3D walk->private; - pgd_t val =3D READ_ONCE(*pgd); + pgd_t val =3D pgdp_get(pgd); =20 #if CONFIG_PGTABLE_LEVELS > 4 && \ (defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS)) @@ -54,7 +54,7 @@ static int ptdump_p4d_entry(p4d_t *p4d, unsigned long add= r, unsigned long next, struct mm_walk *walk) { struct ptdump_state *st =3D walk->private; - p4d_t val =3D READ_ONCE(*p4d); + p4d_t val =3D p4dp_get(p4d); =20 #if CONFIG_PGTABLE_LEVELS > 3 && \ (defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS)) @@ -77,7 +77,7 @@ static int ptdump_pud_entry(pud_t *pud, unsigned long add= r, unsigned long next, struct mm_walk *walk) { struct ptdump_state *st =3D walk->private; - pud_t val =3D READ_ONCE(*pud); + pud_t val =3D pudp_get(pud); =20 #if CONFIG_PGTABLE_LEVELS > 2 && \ (defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS)) @@ -100,7 +100,7 @@ static int ptdump_pmd_entry(pmd_t *pmd, unsigned long a= ddr, unsigned long next, struct mm_walk *walk) { struct ptdump_state *st =3D walk->private; - pmd_t val =3D READ_ONCE(*pmd); + pmd_t val =3D pmdp_get(pmd); =20 #if defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS) if (pmd_page(val) =3D=3D virt_to_page(lm_alias(kasan_early_shadow_pte))) @@ -121,7 +121,7 @@ static int ptdump_pte_entry(pte_t *pte, unsigned long a= ddr, unsigned long next, struct mm_walk *walk) { struct ptdump_state *st =3D walk->private; - pte_t val =3D ptep_get_lockless(pte); + pte_t val =3D ptep_get(pte); =20 if (st->effective_prot_pte) st->effective_prot_pte(st, val); --=20 2.30.2