From nobody Wed Oct 1 22:18:42 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70BBA27602A for ; Wed, 1 Oct 2025 02:21:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759285313; cv=pass; b=Zfwufj6BABI5bR/VNtpn3BH/xXHBC6ArkEe5TTudFW+9VHfy3UIE/ccL2YAY0WFZHkiLxtPSkYR64Eb2p4/RU5mxBZd3BrsHDt/gG/wzuZGjRhMt+oywhZHTmM1DK4TOzXtp/rliCQ0lJ30NFtUABsYuwcB2Rn8hzbBqzYivPDQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759285313; c=relaxed/simple; bh=lL54sr82ww+i1m5jAk0XNvFmpWdrTujWodsSVoMNIFY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Vr/oI7dErTwYM+9Nx64J2bgT7rxlHje3/eM38JO73AFO/2FiQG6tIM2ofXheaaycpSxh5PVg3tqS60TK6ez4aV7RQ1ZB4fZan6raFoA7RlFjp+u7aJfSb357abr46gig4ELtr8R6ZfYCDL+psndFUH97UOB7/qUCjq/OfatgeSE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=UozHyXWp; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="UozHyXWp" ARC-Seal: i=1; a=rsa-sha256; t=1759285294; cv=none; d=zohomail.com; s=zohoarc; b=cHF/V38bU0FZA6K9ew5G6bFqjEakgwR6TNM3IwgXWN01Y532aKaN+dSuTJnk9lEeCLAJr45NeGFIt77H3qsaAmBxZSVa5pgb3yt35SKLvtBryLKUWLtx4KK3tjiFe1p3DcEGNhT1Pbpw4R81eV3Z+foYH7xxUZ1b1h+Mait0C7w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759285294; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=azOK+vxt87W3qxkV+a6seP3tbi8bqqnaCFPSt0amZxE=; b=CeEdbeqmGdGUEWV95sj3dg9TEZ/rqarfSpWozOeJhK6V4Q8xY65CI6+m+EZkmitLIikxf2ltp3m3CsfWUdj0HMbSFT5vs3sQfW4Ezwn4U+VScg0xXg6to6PsRe3xDwhOdjQUJ+MNB8+Dx6L176Pa1eGH1ZMFBpKZ8tjM40MjPAc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1759285294; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=azOK+vxt87W3qxkV+a6seP3tbi8bqqnaCFPSt0amZxE=; b=UozHyXWps3EqHdWudso/Tg2ZmLWhNH+1Nz0oFrh8q0P7Oi/Np5Dnxkg7t/jG+fCv 5C09GD7YmPRKy45Psf5eNYLqmd5225TWsFhAGX5W+qeKPGSZkIvRAo5yq6AQ/5j1nIi rK6kryBKhQDBl4Ram7ByzQALok3gesYfVdZFCSyI= Received: by mx.zohomail.com with SMTPS id 1759285292925257.3212091874468; Tue, 30 Sep 2025 19:21:32 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Rob Herring , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v4 06/10] drm/panfrost: Don't rework job IRQ enable mask in the enable path Date: Wed, 1 Oct 2025 03:20:27 +0100 Message-ID: <20251001022039.1215976-7-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251001022039.1215976-1-adrian.larumbe@collabora.com> References: <20251001022039.1215976-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Up until now, panfrost_job_enable_interrupts() would always recalculate the same job IRQ enablement mask, which is effectively a constant. Replace it with a compile-time constant value, and also in another couple places where an equivalent expression was being used. Signed-off-by: Adri=C3=A1n Larumbe Reviewed-by: Boris Brezillon --- drivers/gpu/drm/panfrost/panfrost_device.h | 4 ++++ drivers/gpu/drm/panfrost/panfrost_job.c | 19 ++++--------------- 2 files changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.h b/drivers/gpu/drm/p= anfrost/panfrost_device.h index 474b232bb38e..ac7147ed806b 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.h +++ b/drivers/gpu/drm/panfrost/panfrost_device.h @@ -26,6 +26,10 @@ struct panfrost_perfcnt; =20 #define MAX_PM_DOMAINS 5 =20 +#define ALL_JS_INT_MASK \ + (GENMASK(16 + NUM_JOB_SLOTS - 1, 16) | \ + GENMASK(NUM_JOB_SLOTS - 1, 0)) + enum panfrost_drv_comp_bits { PANFROST_COMP_BIT_GPU, PANFROST_COMP_BIT_JOB, diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panf= rost/panfrost_job.c index ba934437a8ea..54764ce91dea 100644 --- a/drivers/gpu/drm/panfrost/panfrost_job.c +++ b/drivers/gpu/drm/panfrost/panfrost_job.c @@ -428,17 +428,10 @@ static struct dma_fence *panfrost_job_run(struct drm_= sched_job *sched_job) =20 void panfrost_job_enable_interrupts(struct panfrost_device *pfdev) { - int j; - u32 irq_mask =3D 0; - clear_bit(PANFROST_COMP_BIT_JOB, pfdev->is_suspended); =20 - for (j =3D 0; j < NUM_JOB_SLOTS; j++) { - irq_mask |=3D MK_JS_MASK(j); - } - - job_write(pfdev, JOB_INT_CLEAR, irq_mask); - job_write(pfdev, JOB_INT_MASK, irq_mask); + job_write(pfdev, JOB_INT_CLEAR, ALL_JS_INT_MASK); + job_write(pfdev, JOB_INT_MASK, ALL_JS_INT_MASK); } =20 void panfrost_job_suspend_irq(struct panfrost_device *pfdev) @@ -757,9 +750,7 @@ panfrost_reset(struct panfrost_device *pfdev, drm_sched_start(&pfdev->js->queue[i].sched, 0); =20 /* Re-enable job interrupts now that everything has been restarted. */ - job_write(pfdev, JOB_INT_MASK, - GENMASK(16 + NUM_JOB_SLOTS - 1, 16) | - GENMASK(NUM_JOB_SLOTS - 1, 0)); + job_write(pfdev, JOB_INT_MASK, ALL_JS_INT_MASK); =20 dma_fence_end_signalling(cookie); } @@ -832,9 +823,7 @@ static irqreturn_t panfrost_job_irq_handler_thread(int = irq, void *data) =20 /* Enable interrupts only if we're not about to get suspended */ if (!test_bit(PANFROST_COMP_BIT_JOB, pfdev->is_suspended)) - job_write(pfdev, JOB_INT_MASK, - GENMASK(16 + NUM_JOB_SLOTS - 1, 16) | - GENMASK(NUM_JOB_SLOTS - 1, 0)); + job_write(pfdev, JOB_INT_MASK, ALL_JS_INT_MASK); =20 return IRQ_HANDLED; } --=20 2.51.0